[08:33:53] tonythomas: meh, around? Please always set "Needs more work" in GCI when the student has not "fully passed" yet otherwise your mentor's 36h review time is running. [08:34:40] tonythomas: that's why https://gerrit.wikimedia.org/r/#/c/325816/ has now passed the 36h deadline so I think I have to let the student just pass if you don't review these 4 lines very soon :-/ [08:35:20] hola, you both around :) [08:35:31] heh :) [08:35:35] :) [08:35:40] * andre__ double-checks if he really is [08:36:34] LOL :D I just realized today that I am still getting used to the GCI site, and missed comments from a student on this one: https://codein.withgoogle.com/dashboard/task-instances/5375229285105664/ [08:37:46] Although, I've contacted my fellow mentor our team member, and Benoit will take a look. [08:38:03] andre__: I'm reviewing it now [08:39:24] I remember a gci rule about previous work not being eligible for gci. i am sure i read it a few days ago, but cant find it now [08:41:23] andre__: from the phabricator link, the intent of the task is not clear to me, and whether or not what changes the student has made to the documentation makes sense or not. Any pointers would be much appreciated! [08:45:35] jayvdb: section 4.2 in the rules [08:45:57] also linked at the end of https://www.mediawiki.org/wiki/Google_Code-in_2016/Mentors#Proposing_tasks [08:46:06] legoktm: thank you a lot! [08:47:57] andre__: oops. let me check [08:48:20] I reviewed the code in Gerrit yesterday, forgot to mark it in the gci website ;\ [08:50:14] andre__: clicked on 'Needs more work'. I hope it was not too late ? :o [08:50:28] uhh, tonythomas, I just merged the patch :) [08:50:36] legoktm: wow. Thank you! [08:51:25] well :\ I clicked the wrong button in GCI then. Let me see if I can still accept it [09:00:10] andre__: finally that task is done with! approved and submitted! [09:01:46] Thank you! :) [09:02:32] wow. I never knew these kind of things would happen, btw! [09:02:48] Mentors have 36h (on the GCI site) to review. [09:02:49] anway, nice learning- and why I should be careful about GCI [09:02:59] The GCI site does not know if you do something in Gerrit or not. [09:03:15] So whenever more work is needed, please click that on the GCI site too. :) Thanks! [09:03:29] true. I will keep that in mind! [09:03:31] It's the rules. And I know it's all very tight. [09:03:48] makes sense anyway - more GCI tasks coming in - https://phabricator.wikimedia.org/T152666 [09:03:53] yay! [09:05:06] srishakatux: in theory you should get mail notifications from GCI. But it feels... spammy :-/ [09:05:33] srishakatux: I hope Benoit will be back today. I can forward the question [09:09:09] andre__: if you could approve -- https://codein.withgoogle.com/dashboard/tasks/5749784692391936/ [09:13:22] will do in a sec [09:13:51] andre__: Thank you! [09:30:28] Thanks andre__ , you're probably not going to like it, but .. I'm not sure about that rule, and have posted a query on : https://www.mediawiki.org/wiki/Talk:Google_Code-in_2016/Mentors [09:35:44] thanks. I'll reply later today! [11:23:51] qgil: I will shortly update our test instane in labs with all the latest change. [11:43:25] andre__: one more for you to accept - https://codein.withgoogle.com/dashboard/tasks/4790563876372480/ [11:55:28] will do, thanks! keep'em coming :) [12:05:55] andre__: hehe. More on the line :D [12:06:03] the thing is we need more testers, so these things would come up [12:20:43] andre__: one more :D https://phabricator.wikimedia.org/T152678 to accept, please [12:22:46] tonythomas: accept in Phab or GCI? :P [12:22:53] GCI! [12:23:08] ok, let me find that :D [12:23:25] andre__: https://codein.withgoogle.com/dashboard/tasks/4645698790227968/ [12:25:17] Published! [12:25:25] andre__: danke! [12:25:30] I somehow need to trick you into making the first line like this: [12:25:31] This task requires you to install the [Newsletter extension](https://www.mediawiki.org/wiki/Extension:Newsletter). [12:25:37] Markdown for the win. :) [12:26:32] andre__: alright :D I will add that to the following ones! [14:55:02] I feel a little bit trolled by a GCI student who first uploaded an MP3 and now a photo of themselves when 'submitting task for review'. :) => "More work needed." [15:00:58] How much patience do we need to have with someone clearly trying to game the system (or thinking that we are robots, or bored humans)? [15:01:54] tonythomas, ref newsletter extension ok! [15:02:39] I was thinking that the Extension page in mw.o should define "1.28 or later" as compatibility version. Currently it says 1.26 but that is not true. [15:03:52] I will request the #miraheze admins to wipe out all the data from the extension and install it anew. Now they have 1.28 but there are still some fishy stuff going on due to pre-1.28 data (I think) [15:58:50] andre__: do we have a place that we are tracking projects for the hackathon a the dev summit? [15:59:09] reedy and I are talking about working on the blockers for T27000 [15:59:10] T27000: Review and deploy ThrottleOverride extension to Wikimedia wikis - https://phabricator.wikimedia.org/T27000 [15:59:27] because the current system is dumb [16:10:40] bd808: is still up in the air. srishti is w working on it, or about to. [16:11:33] cool. I've flagged the ticket so maybe I won't lose track of it in phab again. :) I seem to remember it about once every 2 months for a day or so [16:38:15] We could create a column for Hackathon projects in the summit 2017 board... [20:55:58] andre__: I put up a new task, at the request of a GCI participant: https://codein.withgoogle.com/dashboard/tasks/5557251240624128/ [21:09:43] qgil: yeah. that makes sense - should that be a gci task (maybe a beginner task, of course) [21:17:05] andre__: around ? [21:17:16] I am wondering if I should import https://phabricator.wikimedia.org/T150125 [21:17:31] one of the student had made a minor contribution, but it requires loads of rework [21:17:51] from my side, I dont have any problem with mentoring it - or letting him continue with the perks of gci [21:17:56] want to hear from the rules side [21:28:13] ragesoss, thanks! Shall I publish that right now? [21:28:30] andre__: please do. [21:29:44] ragesoss, I cannot. Translation tasks are not allowed. [21:30:12] okay, cool. sorry about that. I'll inform the participant. [21:30:21] Meh :( [21:30:35] ragesoss, That's a pity. That would have been a great task with lots of instances :'( [21:30:41] Hope you can find some more ideas! [21:31:07] tonythomas: What would the GCI task be about? Improve the existing patch? [21:31:39] I'm asking because of 4.2c of https://developers.google.com/open-source/gci/resources/contest-rules [21:31:40] andre__: well - the task can be to implement undelete feature, just like that "? [21:31:48] let me check [21:32:12] "you may not claim a task that you have already completed" [21:32:33] yeah - that gerrit change is far from completion though! hmm tricky [21:32:49] I dont know, to be honest :-( [21:32:49] Could you maybe ask on the GCI mailing list? :-/ [21:32:55] yeah. will do it now! [21:33:14] tonythomas: Me neither. If you scope it as "bring that existing patch to completion" it might work? [21:33:28] (but of course it must be open to any students, not just the one who has already worked in this area.) [21:33:41] yeah - but that makse sense as anyone can do it [21:33:48] its in Gerrit! [21:34:49] true that. If we link to https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 in the task desc [21:38:05] andre__: anyway, I mailed gci-mentors too [21:38:12] thanks [21:39:11] heh. and I think we have 12 tasks from Newsletter completed already. 2 in progress too :D [21:54:41] One day you'll have to write why and how GCI works for your project. [22:08:20] andre__: hehe. probably :D