[20:55:29] andre__: srishakatux : are we falling low on GCI tasks ? [21:08:12] tonythomas: yes, always. [21:08:27] (Sorry, but that's the usual reply in GCI times, and it's not a lie.) [21:08:50] andre__: I see that. No idea where to come up with tasks at this phase from the newsletter extension, but there should be something! [21:09:01] like there is a task which I got no idea on how to implement [21:09:33] but I think the partciipants might've more idea :D Can we have such a task in GCI with a disclaimer that - take it at your own risk :D [21:09:53] like someone was telling in #wikimedia-dev that there are only 2 php tasks or something [21:16:18] :D just asked that in #wikimedia-dev [21:24:20] Heh, thanks... [21:29:59] andre__: :) come'on :D lets see how this go [21:30:30] andre__: take a look at that [21:30:41] Phantom42> tonythomas: that seems to be an interesting task. I think I can do it once I finish my current task and if it gets imported to GCI website [21:30:43] fish! [21:34:04] :) [21:34:45] andre__: and we got https://codein.withgoogle.com/dashboard/tasks/5079541397585920/ [21:36:28] andre__: now we gotr more MtDu_> tonythomas: oh that does seem interesting. :) [21:36:35] looks like that task is overhyped at this point [21:37:49] tonythomas: do you want me to publish it? [21:38:09] andre__: yeah. they are waiting for it :D [21:38:21] tonythomas: so the task expects me to add write code? or create a mockup first? or both? [21:38:27] that's not entirely clear from reading the description to me [21:39:18] andre__: oops. I just copied the description. The task requires them to write the code to implement the mockup which looks something like https://phabricator.wikimedia.org/T131492#2904672 ? [21:39:21] tonythomas: (I guess you first want to review a design idea, before people start writing code that you might not like? If so, explicitly say so in the task.) [21:39:26] andre__: exactly [21:39:34] let me tell that there then [21:39:40] +1 :) [21:40:02] I wonder how they would come up with a design though [21:40:34] either mockup, or describe the concept in words? [21:40:51] andre__: right. That looks fine. We might need someone to evaluate that too [21:41:04] so discuss with the mw design team to come up with a mockup for the same should be the first part ? [21:41:32] There is a design team? :P [21:41:42] I wouldn't make it too complicated. [21:41:52] ahhahah. alright. so let them think about it :D [21:42:17] The only thing I always want to avoid is that people write a lot of code, throw it over the wall, and then the maintainer says "Hmm, okay, but that's not how I'd want it, you should have talked to me first." [21:42:22] (I thought there was a design team though. Where would I go if I need something special in my extension, and I dont know the MW standard of putting it" [21:42:24] Because that happens a lot in FOSS projects [21:42:34] andre__: exactly. [21:42:45] There is a design team actually. :) Maybe you could ask prtksxna or Pau or so [21:42:54] but that might slow it down significantly [21:43:08] which might mean: splitting into two task: design part, and code implementation [21:43:17] if you want that... well, it's a different question :P [21:43:39] you could also write in the task that it consists of two parts: describe the UI idea, get feedback, then implement [21:43:42] really, as you like [21:43:52] I just want to avoid disappointments on both sides [21:43:56] ¯\_(ツ)_/¯ [21:44:24] I think I will go with andre__> you could also write in the task that it consists of two parts: describe the UI idea, get feedback, then implement [21:44:35] let me edit that task description a bit [21:47:20] andre__: https://phabricator.wikimedia.org/T131492#2914588 ? [21:50:29] tonythomas: Yessss [21:50:35] nice [21:51:32] tonythomas, ....and published on the GCI site. Thanks! [21:51:50] andre__: dankeshön [21:52:50] tonythomas: da nich für [21:52:58] damn I didnt get that [21:53:11] you should never write that anyway :D [21:53:23] "not for that" basically [21:53:45] Hahah. Google translate got me something like "Since not for". close enough [21:54:06] as I said, that's pretty slang'ish [21:55:06] true :D Lets see how the task go [22:30:32] Ho tonythomas, did you see this question? https://phabricator.wikimedia.org/T115095#2904840 [22:30:52] It refers to https://meta.wikimedia.org/wiki/Oversight_policy [22:31:52] Since Newsletter info pages are handled by ContentHandler... I guess these pages and their logs can be supressed just like regular wiki pages? [22:33:00] qgil: oops. was shocked by https://phabricator.wikimedia.org/T154530 [22:33:04] qgil: checking [22:34:14] There goes my resolution for a bug-free 2017. ;) [22:34:37] qgil: I dont know too much about this thingy but if a wiki-page can do it, Newsletters can also do it as of now [22:34:42] andre__: new tas there :D [22:35:16] I'll try to reply there tonythomas [22:35:18] thanks [22:35:36] qgil: Thank you! hopefully legoktm mgiht be able to help though (if he's around) [22:35:58] btw. https://phabricator.wikimedia.org/T154229#2914760 -- right now any autoconfirmed user can create a newsletter right ? [22:36:14] did you mean if ^^ is hardcoded somewhere ? [22:36:24] Yes [22:36:36] checks [22:40:31] qgil: the closest I can see is https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/master/extension.json#L168 [22:40:59] like that limits peopel with newsletter-create only to make stuff in Newsletter: namespace [22:41:02] but there is a glitch [22:42:03] What I mean is, how does a MediaWiki owner define which user group can create newsletters? [22:44:37] qgil: I hope you can see http://newsletter-test.wmflabs.org/wiki/Special:ListGroupRights -- it looks like currently anyone who is autoconfirmed gets to create a newsletter. I think it is hardcoded somewhere [22:44:42] trying to find it out [22:45:03] qgil: ah. gotcha https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/master/extension.json#L18 [22:45:06] its hardcoded there [22:46:58] tonythomas, right, thank you. A quick solution for now would be to move create-newsletter to sysop too (a very simple GCi task?) [22:47:29] qgil: true, and kill it from autoconfirmed users ? [22:47:39] The actual solution would be to offer these defaults (all sysop) but then allow to set different user group via variables in LocalSettings.php, like other extensions do [22:48:17] Yes, autoconfirmed users should not be able to create newsletters for now, as per the phab task. [22:48:58] qgil: we have that option too actually. If we set $wgGroupPermissions['group']['newsletter-create'] = true; -- it accepts in correctly [22:49:38] Ah, ok, and then will it override this L18n file defaults? [22:52:47] qgil: oh which one ? the one showing up in http://newsletter-test.wmflabs.org/wiki/Special:ListGroupRights ? [22:53:22] https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/master/extension.json#L18\ [22:53:26] er [22:53:27] https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/master/extension.json#L18 [22:53:48] What I mean: [22:54:34] oh haha . it was L18. I got it confused with i18n [22:55:01] well, since that thingy is in extension.json, it would just stay - but I never had tested it though [22:55:41] Are the hardcoded values at extension.json being superseded by the values defined at $wgGroupPermissions? [22:55:43] it would be strange to see what happens if we give $wgGroupPermissions['autoconfirmed']['newsletter-create'] = false; too [22:55:52] btw. I can test that straightaway. sec [22:56:15] Test: after setting $wgGroupPermissions to sysops, autoconfirmed users should not be able to create newsletters [22:56:20] qgil: it got overwritten [22:56:36] qgil: well, you will have to set $wgGroupPermissions['autoconfirmed']['newsletter-create'] = false; too [22:56:41] ok, good, thank you for testing! [22:56:46] as by default we have this thing hardcorded there. [22:57:03] ideally, we would want to remove it afaik. [22:57:26] it is easier to set everything to sysop by default [22:57:29] simpler [22:57:44] right. and remove that autconfirmed clause completely [22:57:48] yes [22:58:15] gci task ? [22:58:21] imho yes [22:58:25] to document it too [22:58:25] qhy not [22:58:29] right. [23:00:23] qgil: https://phabricator.wikimedia.org/T154534 [23:00:39] and sadly I will have to leave as I got a paper to finish :/ [23:01:58] Thank you! [23:02:06] My paper is called sleeping. [23:02:28] qgil: heh. Its quite during the night, so the best time to write [23:02:35] *quiet