[06:43:32] bd808: Thanks! [13:17:54] qgil: I get a feeling that our only outstanding patch https://gerrit.wikimedia.org/r/#/c/355226/ is gonna take forever again :-( [13:18:29] or we should get one of them devs to review them up. [13:18:56] addshore:, bawolff or anyone else interested. [19:48:25] bd808: bd808> Code of Conduct link is now live in the wikitech and wikimedia.org footers -- I cannot see it on them footers of wikimedia.org though [20:18:44] tonythomas: oh.. mediawiki.org. Probably a typo from me before [20:46:05] bd808: I see that. great ;) [22:24:05] tonythomas: have you tested that newsletter patch? The code looks ok to me but I don't have things all setup to actually test it. If you say it works I'll +2 it with full faith that you actually tested the functionality [22:24:39] bd808: I had tested it back and forth, yes. But I want to know if that is something which we expect to show up on an Undo button [22:24:48] the thing is - usually there is a diff and etc which show up [22:25:08] to be sure - I can just pull this to our test instance, and you can take a look at this for yourself! [22:25:09] sec [22:26:34] (wait, the newsletter-test instance is going on a git pull after an year) [22:26:40] heh [22:31:21] for some reason, whenver I login to that wiki - I get redirected to a 404 at http://login-newsletter-test.wmflabs.org/ [22:31:22] :/ [22:33:09] tonythomas: https://newsletter-test.wmflabs.org/wiki/Main_Page [22:33:10] alright. I have the change pulled. check out http://newsletter-test.wmflabs.org/w/index.php?title=Newsletter:The_Signpost&action=history [22:34:11] as of now - any user can create and play around with newsletters (you can even try one - if you want :D) [22:35:03] (even though I know you would get into and get the access yourself to do it if you really feel like :P) [22:36:07] I try not to hack other people's wikis unless they ask me to :) [22:36:45] so the change here is that when you undo now you get an edit form reset to the prior version and can change from there. [22:37:02] what did it do before? just restore the undone version? [22:39:21] so I guess the question is if you should have a diff as well like this shows -- http://newsletter-test.wmflabs.org/w/index.php?title=Undo_test&action=edit&undoafter=267&undo=268 [22:40:04] bd808: it is. so before the patch - it would just show the present version on an edit button - which is pretty bogus [22:40:19] it would show just the current version for every single undo button on that page :/ [22:40:54] *nod* so the new behavior is better but maybe not the ultimate UX [22:41:30] yeah - the diffs. I can even write the code to manually create a div html on that page - I think there are some straightforward code for that - but I want to know if there is some other existing stuff which I could use and these things all show up - like I just pass the new and old revision id to it, and the function renders that entire undo page [22:41:48] *nod* [22:42:26] is this stuff implemented as a content handler or have you jsut built a special page that does all the things? [22:42:41] bd808: its on a contenthandler, yes [22:46:34] I wonder how this works for eventlogging... [22:47:18] well - eventlogging as in the one we see on the edit history - or wfDebugLogs ? [22:47:36] as in https://meta.wikimedia.org/wiki/Schema:MediaWikiPingback [22:47:51] that's a content handler thingy [22:50:07] yeah - we are more or less that - with a fancy edit page [22:50:22] (sadly I have to go now - around 12:50 now) :-( [22:51:04] tonythomas: I'll look around a bit more and make a note for you on the patch if I learn anything [22:51:44] bd808: great. Thank you!