[05:59:46] tgr: Hi [06:00:02] hi smartyrad [06:01:31] tgr: I have finally completed my proposal for Outreachy in phabricator as well as on the main website. Here is the phabricator link https://phabricator.wikimedia.org/T178697 . Kindly give your feedback when you're free :) [06:02:15] thanks! I am going through those as soon as I can [06:02:21] Tgr: Btw, for the task will be using the dataset that we used in Task 3 or will we be creating our own dataset? [06:03:06] for the real project, you mean? [06:03:15] tgr : Yes [06:03:32] collecting that is part of the project [06:03:54] that was just some sample dataset from some random IT company [06:04:03] I ask cause right now I've written a rather vague timeline and wrote that we will be creating our own dataset. I am glad that I wasn't wrong [06:04:10] which is not really useful as it does not contain bots [06:04:27] tgr: Exactly. They had created it in some hackathon [06:04:51] for a hackathon [06:05:16] the dataset is probably real, they collected it from their users [06:06:11] tgr: Yes but I don't think that it will help us get accurate predictions as it was based on the usage patterns of only about 7 users [06:06:34] but it only includes humans, it might display different behavior as these people where using some kind of administration interface, not a login form [06:07:16] and it's very small, and not diverse enough - we want to use data from all parts of the world, for example [06:07:28] so yeah, it's not really useful [06:08:54] I have also created a patch here for task 4 https://gerrit.wikimedia.org/r/#/c/383299/ . Hopefully this shouldn't take much of your time as I have tried to address each of your comments [06:09:34] Couldn't beleive that there was so much of redundant code in the initial commits! [06:09:45] *believe [06:12:33] Tgr :The only thing that I'm kinda skeptical about in the latest patch is the usage of messages which I get a feelign isn;t the right way although even this would work [06:15:18] as Saint-Exupery said, perfection is reached not when there is nothing more to add but when there is nothing more to take away :) [06:16:13] yeah, the messages won't work [06:16:23] or you forgot to add some files to the patch [06:17:47] tgr: I haven't forgotten it actually. I just thought that it'd be a rather tedious task to make it for all languages. So shall I create one with just english instead ? :) [06:18:34] you have to add to en.json and qqq.json [06:18:50] all else is the translators' job [06:19:47] see https://www.mediawiki.org/wiki/Localisation#Adding_new_messages [06:20:04] although in this case you'll probably have to create the files as well [06:20:04] tgr: Oh, I didn't know about that! Guess there's a bit of work left afterall :) [06:20:58] also, please make sure everything has a visibility [06:21:23] tgr: Yes, I have done that :) [06:21:33] not everywhere though [06:21:41] also, if a PHP method does not have an explicit visibility, it's public [06:21:54] so it has to be public in your subclass as well [06:23:23] Oh okay, I'll check that once again as well [06:23:27] as a subclass needs to provide all functionality that the parent class provides [06:24:14] there are a couple other things, I'll add comments to the patch [06:26:07] Cool, thanks :) [06:58:44] tgr: Added a new patch with the messages and it works now as well :) [06:59:51] tgr: Please don't review it now, I'll address your latest comments and ping you after creating a patch for them as well [07:26:30] tgr: I checked out options-message [07:27:00] I have understood as to how to get it running but one issue is as to whether we can set a calue to the option? [07:27:53] tgr: I saw an example here https://github.com/wikimedia/mediawiki-debian/blob/6a4a101a0091a8684784156635058a6f532cbfe7/includes/specials/SpecialBlock.php#L158 but they don't assign values to it either [07:29:00] options-message and options-messages are different [07:29:12] you probably want the second here [07:29:37] options-message is really meant for scenarios when th dropdown should be customizable [07:29:45] since wiki admins can override messages [07:31:00] in that example, it's a kind of "saved responses" functionality, admins can add common responses by editing pages like https://en.wikipedia.org/wiki/MediaWiki:Ipbreason-dropdown [07:31:18] and the software will generate the list straight from that page [07:31:35] for the captcha you don't want anything like that [07:38:07] tgr: Thanks, figured it and created a new patch with the changes :) [23:40:30] tgr: Hi [23:55:06] hi smartyrad [23:58:19] tgr: Have you had the chance to check out the proposal or verify eligibility? I ask because there isn't a lot of time left for making changes and hence was getting kinda worried