[00:09:20] andre__: Have a look at this, https://phabricator.wikimedia.org/T183674 [00:09:34] I'll complete the list tomorrow, it will be manual work but I'll give it shot [00:10:01] If it looks okay, we can mimic what legoktm did for minus-x and create tasks on GCI [16:59:23] andre__: Any word about this: https://phabricator.wikimedia.org/T183674. [16:59:34] Sorry if you're on a plate of food :D [17:00:05] It's Christmas, my plate is cold and I need like 2 more hours on IRC :D [17:02:26] d3r1ck, do you have a specific question? [17:02:46] I cannot judge if this makes sense. :) [17:02:52] andre__: Yes, is it suitable for GCI? If yes, we could get it up and running? [17:03:44] andre__: I spoke with legoktm about this yesterday, he says it's good [17:04:08] But maybe you could ping hashar since he's the CI guy? But I think this would be super useful :) [17:42:10] andre__: I also spoke with Florian too :) [19:07:57] d3r1ck: Ah, thanks! Feel free to create such a task on the GCI site if you feel like having enough skills to mentor it? :) Would someone co-mentor? [19:08:04] Thanks for that idea :) [19:09:32] andre__: I left a note on the ticket if someone wants to co-mentor, it cuts across so many extensions [19:09:40] Some of them I don't even know much about [19:10:13] Here is it, https://phabricator.wikimedia.org/T183674 [19:10:21] I left notes on the ticket, hoping we'll get some co-mentors :) [19:10:49] Florian told me there are 181 tickets left in the system so we need more since we still have like 3 weeks [19:11:39] yes, we do always need more :) [19:12:07] sure! Once I get some feedback from community, I'll start creating tickets for each of the extensions [19:12:12] They are 47 in total :) [19:13:11] or maybe combining two or three in one task? [19:13:18] well. we can sort this out. thanks. :) [19:14:54] andre__: yeah! it's still under discussion! [19:15:10] The issue is, students need to investigate the kind of tests based on the extension in question [19:15:18] So it's not as easy but the lines of code will be small [19:15:36] Some research has to be done, I was thinking 1 extension per task [19:15:48] ah alright [19:16:45] Legoktm will have a look tomorrow and give some feedback [19:16:56] Also, we'll get some feedback from hashar if he is free ;D [19:26:03] d3r1ck: Do you plan to review https://codein.withgoogle.com/dashboard/task-instances/4551263544934400/ in the next hours? :) [19:27:03] d3r1ck: ah well, looks like there is currently nothing to review anyway, so would you reset that task's status? [19:27:26] Yes reset! [19:27:49] We are had a discussion about this issue on #wikimedia-dev [19:28:01] there is some uncertainty about the approach to take in the task [19:28:11] divadsn is the one working on that [19:28:24] d3r1ck: the task is in "please review" state. [19:28:28] d3r1ck, but there is nothing to review. [19:28:35] you have 36 hours to review only. [19:28:42] so you should reset the state of that task. [19:28:47] andre__ well there is a solution [19:29:03] I was investigating, but I left a comment on that task [19:29:21] divadsn: Can you reincarnate the patch? [19:29:37] divadsn: Oh yeah, I see your work and it's lovely. Where I am coming from right now is that mentors have 36 hours to react on the GCI website. And the GCI website does not know whether stuff is in Gerrit or not. [19:29:42] Let's have a look, maybe Brian can use his experience on it [19:29:53] So I ask d3r1ck to please reset the task status on the GCI website. As d3r1ck is the mentor here. [19:31:01] d3r1ck: Does that make sense, or do I need to explain a bit more why you should click "More work needed" on that task? [19:31:27] d3r1ck, sure, I restored the patch [19:32:28] andre__: Is "More work needed" == "Reset"? [19:32:37] d3r1ck, in this case yes [19:32:41] andre__, well the thing is on the other side I just solved that task and I left d3r1ck the decision whether my solution was ok [19:32:53] d3r1ck, because you only have 36 hours to review, once a student has requested a review. [19:33:01] d3r1ck, and 17 hours are already gone. :) [19:33:18] Okay! [19:33:44] divadsn, that all makes sense. I'm really only having those emails from Google in mind once a task has gone 36 hours without review on the GCI website. And the GCI website does not know discussion details or Gerrit patch status. it only knows the status of the GCI task on the GCI site.... [19:33:55] it's how GCI works :-/ [19:34:30] andre__, I a bit confused too :/ [19:34:35] *I'm [19:35:00] divadsn: Thanks for restoring! I'll mark it as need more work while i have a closer look! [19:35:27] d3r1ck, alright, hope we find a solution :) [19:35:33] Sure! [19:35:43] I'll talk a little with bawolff about your solution [19:35:59] divadsn: you set the task on the GCI site to "please review" 18h ago. And until a few minutes ago, there was an abandoned patch in Gerrit as the work to review. So I asked d3r1ck as the mentor to reset the GCI task status to more work needed as d3r1ck only has 18h to react (approve or "needs more work") on the GCI site. [19:36:14] and yes, it can be confusing... :-/ [19:37:20] andre__ no problem, I am still on my Linux machine so I can respond to everything for now :D [19:38:31] thanks everyone :) [19:42:31] andre__: You are welcome my able GCI org admin :) [19:50:55] * divadsn shares christmas love to anyone :)