[16:06:02] good morning Jeff_Green! [16:07:32] hey atgo [16:07:41] how are you doing? [16:07:50] alright--you? [16:25:10] good! i'm on your coast [16:25:31] Jeff_Green: i just wanted to see if you'd gotten what you needed to get that civi account set up? [16:26:34] atgo: ohrlly. enjoying the fine weather!? [16:26:49] ha it's actually warm in nyc today! high of like 66 [16:27:07] yeah, you just missed the cold snap [16:28:11] atgo still haven't heard back from the user [16:28:22] at least, unless I missed it somehow :-( [16:28:43] no... ccogdill any news on heather's cell? [16:28:59] yeah she replied to the thread yesterday [16:29:31] ah, but looksl ike she didn’t cc anyone [16:29:41] I’ll forward to you Jeff_Green [16:30:05] ok [17:03:50] Jeff_Green: ccogdill lmk when that's all done and i'll mark it off my list [17:36:38] AndyRussG: hi! I'm just catching up on stuff, and wanted to double-check that you would be amenable to flipping the CN configuration today, once meganhernandez and K4-713 agree on the timing? [17:37:00] Hey awight! How's it going? [17:37:02] It sounds like nobody has noticed issues with the mediawiki.org rollout... [17:37:14] howdy awight and AndyRussG [17:37:15] AndyRussG: great! twas quite nice to have a week without a computer [17:37:16] I was just thinking about the timing... [17:37:26] Hey ejegg :) [17:37:37] (although all my relatives had computer maintenance stuff :-$) [17:37:41] awight: heh, does that exist? I thought it was physically impossible [17:37:47] hehe see ^^ [17:37:54] right... [17:38:00] but no laptop!! [17:38:09] I slept like a baby [17:38:19] heh, right... [17:38:37] No more nightmares about allocation precentages? [17:38:50] hehe nah that has been your albatross [17:39:02] mmmm hmmm [17:39:02] smelling pretty good these days, though! [17:39:37] it's just the maggots that are digging in (to the albotross) [17:39:56] yes they have become beautiful butterflies [17:39:57] I was noticing, in the U.S. Thursday and Friday are holidays this week, right? [17:40:06] yep [17:40:23] and fwiw I'm a jerk and will probably be out Tuesday as usual [17:40:49] ...not a jerk, that's totally cool... [17:40:58] We do want some time to monitor impressions, I think... [17:41:28] right. I'm still hoping for flipping the switch ASAP [17:41:57] definitely will follow your opinion of course [17:42:19] no well I don't have an opinion that's worth giving more weight to than others... [17:43:00] u would be comfortable with a rollout today, and have time? [17:43:06] I had been thinking of trying out and fiddling with more browser tests first, but two days is not long for monitoring impressions [17:43:31] awight, AndyRussG: Start your engines, guys. We can flip the CN switch today. [17:43:37] Oh yeah, this is the highest priority on my plate.. [17:43:45] K4-713: word! [17:43:46] Uhh [17:43:46] ok. woot [17:43:52] party tiiiime [17:43:53] K4-713: has spoken [17:43:57] Bam. [17:44:10] hehehe. AndyRussG was just saying we should check that the ice is clear [17:44:22] * awight inspects more tea leaves [17:44:42] * AndyRussG is still kinda tending towards caution when millions of users are involved... [17:45:04] ...or I like to imagine I am... [17:45:07] we did get burned by that mobile thing... [17:45:54] The best thing I can offer on behalf of an accelerated schedule, is that it's better for users if we deploy further in advance of the big campaign... [17:46:03] Yep [17:46:10] We can still turn on a couple of non-wikipedia projects first [17:46:20] ejegg: Hmmm good point... [17:46:26] the code is deployed everywhere, right? [17:46:34] Yep! deployed everywhere [17:46:35] * awight inspects Special:Version [17:46:36] k [17:47:04] If we had infinite time to play with tests, we might do more w/ browser tests and more variety of allocation cases via the test fixtures [17:47:11] * AndyRussG checks finite watch [17:47:16] that fixture thing... is a serious problem [17:47:31] we need our own instance, and a mechanism for deploying fixtures. [17:47:35] Neither of which exist [17:48:58] Mm well the tests do seem to work [17:49:11] after Zelko's intervention, woot [17:49:12] !! [17:49:18] ah yes thos [17:49:20] those [17:49:32] re:allocations, I was kinda thinking of augmenting the code so it can tests more simultaneous campaigns and various buckets [17:49:39] yes [17:50:26] Also maybe seeing of Krinkle and/or Roan would like to take one last look at our RL stuff before we push the button [17:50:32] s/of/if/ [17:50:52] AndyRussG: well, maybe when K4-713's out of her meeting you two can discuss. [17:51:10] Yeah that was certainly a snafu that Krinkle found, as we were deploying! [17:51:17] shhhh! [17:51:35] Have you been able to test the real-world caching behavior for that RL module, yet? [17:52:07] It appears to work. ejegg witnessed first-hand the version # changing... [17:52:07] like, watch the data contents across the edge of a CN campaign... [17:52:18] ok! [17:52:24] lemme see if I got CN admin rights yet... [17:52:32] right! [17:52:40] AndyRussG: Yeah, I'd love to take a look [17:52:41] We can make that happen fast. [17:52:46] Tell me where and I'll give you a quick check [17:52:47] Krinkle: thanks! [17:53:07] Krinkle: thanks! one sec... [17:53:33] I donno which interface you prefer. https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/includes/CNBannerChoiceDataResourceLoaderModule.php [17:53:55] Krinkle: the status is it's all now in the CentralNotice master branch and deployed everywhere, but only activated on a few sites via a config variable switch [17:54:07] awight, AndyRussG: I'm not really out of meetings until 1pm or something. [17:54:11] urgh [17:54:19] K4-713: ok we'll fake your signature ;) [17:54:39] It's just squiggles: You'll be fine. [17:55:25] But, on a serious note: Don't rush if you don't think it's a good idea. [17:55:54] AndyRussG: which sites? [17:56:08] or rather, which switch [17:56:10] K4-713: I'm still sniffing and don't see anything tangible to block on. Only common-sense caution. [17:56:12] awight, AndyRussG: You're just clear for whenever, and my feeling is that earlier is much better than later, unless you want to wait until the mid-December slump, or January. [17:56:24] Which is totally valid. [17:56:35] Krinkle: BTW, apologies again for my crazed last-minute mistakes that you commented on in CNBannerChoiceDataResourceLoaderModule::getFromApi()... fortunately that code path (the API bit) is only relevant for 3rd party users... In any case I'll fix a bit later... [17:56:52] wgCentralNoticeChooseBannerOnClient ? [17:56:57] Krinkle: yep! [17:57:13] if ( $lang === 'aa' && $site === 'wikibooks' ) { -> wgDBname === 'aawikibooks' ? [17:57:14] it's enabled on mediawiki.org, aa.wikibooks.org, and test.wikipedia.org [17:57:17] yep [17:57:21] Also on the beta cluster [17:57:28] Krinkle: sorry, that's my rush-hack [17:57:40] It's a bit weird to use lang/site fo that [17:57:46] I've never seen that before [17:58:03] Krinkle: we'll remove that soon, it was the only thing I could guarantee would work in... the 30 seconds I had :) [17:58:08] Reedy might wonder why it's in CommonSettings instead of in a switch in InitialiseSettings, but that's outside my area of concern. [17:58:12] k [17:58:44] K4-713: yeah, earlier makes sense so we can test in a real setting... Do you have a preference w/ regard to what time today? [17:58:52] Nope! [17:59:05] AndyRussG: We're following you guys. Whatever makes sense on your end. [17:59:35] awight: k, got a standup, will get back to you in 30 minutes [17:59:36] Lemme see what's still enabled on Meta [17:59:41] when's your ETA? [17:59:45] AndyRussG: Just please do let us know what makes sense once you figure that part out. :) [18:00:05] Krinkle: awight: K4-713: let's aim for flipping the switch as noon SF time? [18:00:14] today? [18:00:16] AndyRussG: works for me! ejegg ^^ [18:00:17] ye! [18:00:20] For all production? [18:00:24] today [18:00:29] yea [18:00:30] awight: Might need 1-2 hours more if you want my feedback first. [18:00:40] Krinkle: you got it! [18:00:41] I can't move it up that much [18:00:44] OK [18:00:48] any time works for me [18:00:49] Krinkle: no problem, thanks a ton [18:00:54] and sorry for the last minute notice [18:01:00] K 2 pm SF time [18:01:01] ? [18:07:54] AndyRussG: sure. Are you able to work late EST, though? [18:08:05] awight: sure np [18:08:14] ok then [18:08:22] I'll reserve a deployment window [18:08:32] Ah! didn't know we needed one... [18:08:44] I'm not 100% certain, it's just a config change [18:08:55] I'll ask... [18:09:13] (I may have a few interruptions between in the early evening, nothing major tho...) [18:10:58] awight: Order of magnitude? [18:11:04] * K4-713 defects to astronomy [18:12:28] K4-713: wat. I think that's stock jargon [18:12:44] Oh, totally. :) [18:12:55] e.g.: I'd like to order some magnitude, here [18:12:56] dude [18:13:09] I just really like the "Hack off a zero, w/e" [18:13:15] :) [18:13:36] yeah what's a 9x difference, anyway [18:13:41] Pff. [18:13:46] Trifles. [18:13:49] how could that possibly add up to siginificance [18:14:07] * awight makes to edit the WP article on this [18:14:27] AndyRussG: ejegg: ok we're reserved for 14:00-15:00 PST [18:15:04] wohoo! banner boogie [18:15:14] rockin [18:16:33] the-wub: I sent an email, the punchline is that the new contribution_source columns can be used safely, now. [18:17:57] ejegg: AndyRussG: any CR I should be looking at? [18:19:25] awight: not that I know of... I had started very tentatively on the bucket features that would come after this, just to have them on hand in case, but I doubt it make sense to go ahead with any of them before January [18:20:05] awight: one thing for the silverpop export [18:20:07] one sec [18:20:09] AndyRussG: I'm out of the loop on that judgement call... Happy to give feedback though. [18:20:13] ejegg: yep, https://gerrit.wikimedia.org/r/#/c/175163/1/silverpop_export/update_table.sql,unified [18:20:16] looking at it now [18:20:21] cool [18:20:41] wrt the bucket stuff, I think the most urgent for this week would be even more tests, no idea what else is around in other areas... [18:20:43] also I think we should stop deduping on contact ID, at least for opted out addresses [18:21:13] to make sure all opted-out email addresses in the system get exported [18:21:31] and maybe we should add an is_deleted = 0 to the initial select [18:23:22] AndyRussG: sure, I'll work on that! [18:24:00] ejegg: right. oh, that's huge. We're opting out a contact if any of their emails are opted out.? [18:24:17] Yeah, which actually might be wrong [18:24:42] well, definitely is wrong after my editing = add an on-hold address [18:24:59] So we want one row for each address [18:25:48] yep. Lemme see... yeah we should only send to is_primary addresses. All the others should be on the suppression list, so that's simple enuf. [18:28:00] (CR) Awight: [C: 2] "Looks safe" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/175163 (owner: Ejegg) [18:28:46] (PS1) Ejegg: Export all email addresses for each contact [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/175475 [18:29:22] hi awight! welcome back [18:29:31] (PS1) Ejegg: Do not export email addresses for deleted contacts [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/175479 [18:29:36] atgo-meeting: /me looks around [18:29:48] never mind the PM behind the curtain! [18:34:00] awight: i'm in nyc :P [18:34:27] hey awight do you have any ideas on this one? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2190 [18:35:20] atgo-meeting: ah, thanks for bumping that one. I need a bit more info. [18:35:27] what do you need? [18:35:30] i've got ccogdill in a call [18:35:35] oh heh [18:36:04] ccogdill: hey, for #2190, you have this postal code data for the AU contacts in a spreadsheet or something? [18:36:30] yep awight, in a spreadsheet [18:36:38] not yet on the server, but it can be :) [18:37:03] ccogdill: ok. I'm not sure whether there's any update/import thing like we would want, give me a few... [18:37:10] okay [18:37:12] thanks! [18:37:25] Usually the built-in import processes insist on a contact ID, afaik. [18:37:33] hmmmm [18:37:34] We can of course custom code something quickly... [18:37:46] okay [18:38:03] well talking to Anne about priorities - there are more important things [18:38:06] so don’t drop everything ? [18:39:12] ccogdill: actually, you might be able to self-serve this one. Please try it on the staging server first. [18:39:24] Go to /civicrm/import/contact [18:39:48] The trick here will be to set "For duplicate contacts" = "Update", and then do something tricky with the Dedupe Rule. [18:40:10] You'll want the dedupe rule to match if the email is a duplicate, with no other fields matching. [18:40:12] okay… let me get there [18:40:37] Also... save the import data as a CSV. [18:41:39] awight I can’t find how to get to “import” from the staging homepage [18:41:49] Contacts -> Import [18:41:50] nevermind [18:41:53] k [18:42:42] so yeah I don’t know what to select for the dedupe rule. am I supposed to create a new one? [18:43:53] ccogdill: you want a rule that only requires a matching email. look at /civicrm/contact/deduperules?reset=1 [18:43:56] I will, too. [18:44:43] ccogdill: all individual contacts, or does this include organizations? [18:45:16] ccogdill: ok I've created a rule "Email is enuf" [18:45:25] ccogdill: try... one or two contacts at a time. [18:45:27] okay awight, thanks! and just individuals [18:45:31] sorry, was wrapping up a meeting [18:45:52] np. you should be set, then. Please ask if anything is unclear. [18:46:58] will do, thanks! [18:47:04] atgo-meeting: that's crazee, I was in Bryant Park just yesterday. enjoy the warm weather, we got blasted by a polar vortex all week. [18:47:16] i was in bryan park on saturday!! [18:47:22] ridiculous. [18:47:38] i bought a hat. because it was cold. [18:47:40] anyway, I see you enough :p [18:47:48] awight actually one more question [18:47:52] ccogdill: yessir! [18:47:57] is there a specific field name I should give the postal codes? [18:48:06] how will Civi know to map to that field? [18:48:14] ccogdill: do these donors already have country=AU, btw? [18:48:19] yep [18:48:22] ccogdill: yeah field mapping is all built into that import wizard. [18:48:35] call it whatever you want, and make the mapping explicit. [18:48:40] okay so field name = postal code will work? [18:48:41] it's on... screen 2 or something. [18:49:03] ccogdill: r u at the mapping screen yet? [18:49:29] ohh… no :D I wanted to have my file right first but perhaps I was getting ahead of myself [18:49:50] ccogdill: yes, call me when you're at the mapping screen, I think it will be self-explanatory-ish [18:49:59] got it [18:50:06] ccogdill: just try a file w/ one or two lines, IMO [18:50:23] k [18:52:38] (CR) Awight: [C: 2] Export all email addresses for each contact [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/175475 (owner: Ejegg) [18:58:44] awight: I'm going to update tools and re-run the table update [18:59:24] ejegg: awesome [18:59:56] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/175487 [19:00:14] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/175487 (owner: Ejegg) [19:01:22] !log updated tools from b537e2ec80d16b84f8e0539d4e3d78c8afef1b63 to 113dfe160b750657626e07450003cc88d3939fbd [19:01:26] Logged the message, Master [19:01:57] (PS5) Ssmith: Show actual SQL instead of query string in db modal [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/173632 [19:02:20] hey K4-713 we have our weekly during the strategy thing today [19:02:34] Strategy thing? [19:02:39] atgo: please remind me, we aren't trying to get any of the GRabbit reporting changes into Civi until 2015, right? [19:02:45] awight: correct [19:02:46] ejegg pushed that edited patch up for ya [19:02:49] k thx [19:02:54] K4-713: check out yo calendar [19:03:07] atgo: I have no strategy thing. [19:03:18] you're on the invite and accepted it [19:03:23] (CR) Ejegg: [C: 2] Show actual SQL instead of query string in db modal [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/173632 (owner: Ssmith) [19:03:26] it's called "fundraising strategy" and is at 1130 in 61 [19:03:28] Oh, *that* strategy thing. [19:03:29] :p [19:03:37] :P [19:04:07] pizzzacat: good stuff, I'll start on the big english route [19:05:33] cool yay! [19:06:05] so K4-713 i feel pretty good after this morning with megan, unless there's sometehing specific you wanted ot talk about i think we can try to connect tomorrow or wednesday? [19:06:31] atgo: I think I just released the room. [19:06:47] looks like it [19:06:57] Rad. [19:07:13] Ah, I think we covered everything I had for today, so far. [19:07:17] word. [19:07:17] Maybe tomorrow I'll have more. [19:07:26] ...maybe I'll have more in an hour. [19:07:29] yeah there's always time :P [19:08:54] ejegg: I see you're talking with qgil about our Phabricator project--was the decision to use Fundraising, or Wikimedia-Fundraising? [19:10:05] atgo: For what it's worth, I'm on the obt card now. [19:10:22] awight: is that for bug tracking? [19:10:29] i have a fundraising phab project too [19:10:43] atgo: I'm looking at https://phabricator.wikimedia.org/project/view/41/ [19:10:46] rad, thanks K4-713 [19:11:10] oh boy awight [19:11:30] * awight canaries over dead [19:12:17] :P [19:12:36] hey awight - I can confirm my test import on staging went well! the dedupe rule you created isn’t on the production instance of civi though [19:13:21] ccogdill: ok I'll create it there as well [19:13:38] awesome, thank you [19:13:49] ccogdill: great to know this is possible with out-of-the-box stuff! [19:13:54] seriously, so easy! [19:14:41] ccogdill: ssh :) [19:14:56] haha I won’t tell [19:15:24] ccogdill: ok done [19:15:29] merci! [19:16:32] atgo: on this note. What is the pressure like to move our sprint planning into the Facebook tool? [19:16:40] We will survive until next year, I hope? [19:16:46] awight: yes [19:16:51] k.... [19:16:57] we are exempt from the timeline of the other groups :) [19:17:20] awight: sorry, was I actually talking with qgil about Phabricator? [19:17:29] oof [19:17:33] I think I just subscribed to notifications [19:17:59] ejegg: oops, I misread the bizarre threading [19:18:37] 'the Facebook tool', huh? [19:18:40] yeah the threading is one of my complaints [19:18:42] * ejegg senses hostility [19:18:50] argh, now I can parse correctly. The bugzilla stuff will be ported over as a separate project. [19:19:03] :) [19:19:10] hehe. yeah FB was behind the original development of phab, right? Then the guy went crazy and solo? [19:19:27] yeah [19:19:31] Ah, didn't know the origin story [19:19:52] and then the sun disappeared until balance can be restored [19:23:38] atgo: I noticed MG was not on the invite for the strategy thing? [19:23:50] that's true. they are already in the loop afaik [19:23:56] okok [19:24:13] lisa showed me the deck and i was like "man i bet tech would love to see this!" [19:24:22] and she was like "yeah, that's a great idea!" and here we are :) [19:24:40] atgo: that's awesome, thx [19:24:41] I see he thought highly of his fellow PHP FB developers [19:25:10] (the developer of phabricator) [19:25:22] AndyRussG: I bet. but where are you reading? [19:25:48] I remember something in the doc being like "PHP is so easy your dog could program it blindfolded in the dark" [19:26:17] oh heh. cos I mean, regardless of the venality and stark immorality of the whole Facebook paradigm, their devs seem to be doing some amazing things. [19:26:25] considering the language was invented by dogs. [19:26:57] heh [19:28:07] (PS1) Ssmith: Update with numeralJS and fontawesome upgrade [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/175493 [19:28:26] ejegg ^ fixed my gerrit issues [19:28:49] which patch did you want me to do the submodule upgrade with? [19:29:15] or does it matter? like, could do it with my next one coming up [19:29:17] pizzzacat: the same one that adds it to bower.json [19:29:30] just so each patch leaves the repo in a working state [19:29:37] oh ok. will see which one that was and then update [19:29:41] rockin [19:29:42] totally [19:40:55] awight: AndyRussG: reviewing now [19:42:36] Krinkle: thanks! [19:42:59] awight: AndyRussG: Hm.. getting warnings in PHP due to use of strtotime() in LocalSettings.php/CentralNotice.php, which is before MediaWIki's date normalisation has been loaded. [19:43:24] basically unable to load any page without hacking mediawiki first [19:44:16] Krinkle: Hmmm... that's unrelated to this change... [19:44:30] Yeah, I'm installing it locally to review the file. [19:44:40] Just noticed my mediawiki suddently didn't work [19:44:52] should probably use a gmt-based date function instead of one inflienced by local timezone [19:48:30] Hmm [19:48:40] OK I'll look into it, not sure why that function was used... [20:06:48] awight: AndyRussG: So the in-class cache, I thought that was removed in a previous revision? [20:07:16] Uh it was... (?) [20:07:16] It doesn't account for resourceloadercontext arguments, and seems obsolete in general. [20:08:26] I wouldn't feel comfortable with that extra caching layer outside the many layers we already have. Afaik there's only ever one call, and if there's more, I fear it has a different context and would pollute other caching layers with wrongly composed data. [20:09:49] Krinkle: K I see, yeah a class variable was added back in because of the call to getChoices() in getModifiedHash() [20:10:09] One is used for the startup module request, the other for the composition request to load.php with the extra module [20:10:21] it'd never be utilitsed for caching [20:11:20] Hmmm... so the'd never be both called in the same Web request? [20:11:31] getModifiedHash is called by modules=startup, getScript is called by the request to load.php?modules=bannerChoiceData [20:11:32] AndyRussG: Nope [20:11:33] I'm not sure we'd want to assume that's part of the RL contract [20:11:48] AndyRussG: And if it were, it might be a different context object, so different user/skin/language etc. [20:11:59] And that is very much part of the RL contract [20:12:07] RL has sufficient caching layers. Not a single module does caching like this afaik. [20:12:53] Krinkle: or better, utc instead of gmt (more precise) [20:13:07] it's possible in theory, and if that becomes an issue adding this in would make sense. Or we could put it in memcached to really cache it well between requests. [20:13:18] Hmmm [20:13:31] but for now I'd recommend removing it as it currently is open to cache pollution [20:13:48] and not needed in the current version of resourceloader as they'd never happen in the same request. [20:14:21] We could certainly remove the instance variable and re-fetch the data each for getScript() and getModifiedHash() [20:14:45] Or we could do as before and create a key to be sure that we're not returning the wrong value [20:15:06] The data retrieval does involve a few DB queries [20:15:30] AndyRussG: But it's not actually being cached. It's an instance variable which is re-created each instance/request. [20:15:37] yes [20:16:13] And for each request, only one of those two paths is chosen. That's part of how RL is designed. Account for that is not realistic. [20:16:43] OK... [20:16:58] if you like, you could match what FileModule and WikiModule do for title mtime caching. Which is to make it an assoative array, keyed by $context->getHash() [20:17:16] (PS1) Ejegg: Add backend Big English config and default filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175501 [20:17:31] choices[$context->getHash()] [20:19:46] Krinkle: I recall having some issues getting all the required info out of $context. For example, $context->getUser I think just checks for a request param, which wasn't sent, as far as I could see [20:20:14] We can also just not store any data in the class, retrieve it afresh each time, and add a comment explaining that it's assumed both methods won't be called in the same request [20:20:34] (CR) Ejegg: "Requesting /data/big-english will give you hourly data for Dec 2014 filtered to amount < 5000, but you can get a different month that with" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175501 (owner: Ejegg) [20:20:44] AndyRussG: OK, if there's any doubt at all, just drop that layer for now. It's all very theoretical. For all intends and purposes, it's overhead that doesn't pay off in any scenario rightnow. [20:21:11] And remember, it's heavily cached in front of this. [20:21:22] These are essentially 'compute' classes. [20:21:25] Krinkle: Yeah. I think the priority right now is to be sure we're getting the right data [20:21:41] Adding caching here is hard to review due to the many ways the code is called. I wouldn't trust myself to review that in less than a day. [20:21:44] We're about to start the year-end fundraiser and still need to test a bit on smaller campaigns [20:22:36] Hmmm yeah it's a complicated system! I'm sure I'd take a lot longer to work through all of the details... [20:23:30] In any case even without any in-class caching this should be less load on the backend than the current system, WRT DB selects [20:25:02] So for now if there's any doubt, I think we should get rid of it for now [20:25:45] Alrighty [20:26:26] Krinkle: do you see any other issues (outside getFromApi) ? [20:26:52] BTW most of FR is in a meeting, I'm suree awight and others will see the backscroll in a sec... [20:32:44] awight: ejegg: ^ [20:40:46] (CR) Ejegg: [C: -1] "Something's screwy with the where clause - will fix in another PS" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175501 (owner: Ejegg) [20:47:14] (PS1) AndyRussG: Clean up getFromApi() in CNBannerChoiceDataResourceLoaderModule [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175505 [20:52:07] (PS2) Ssmith: Add board stats piece [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175161 [20:52:59] ejegg: I just went to the patch where I updated the submodules and ran git submodule add. it for some reason appears that only node_modules was updated, even though bower is what I was going for…. [20:53:14] AndyRussG: If you don't mind, could you change the isset(result->value) to result->getValue() !== null or result->isGood() ? [20:53:23] Format::parse returns a Status object [20:53:41] value is an internal member that is always set from the very beginning, its value may be null however if nothing set it. [20:54:08] I'm not sure how the code came to be accessing ->value, but afaik no prexisting code does that and the documentation reflects similar usage (getValue and isGood) [20:54:30] either value !== null or isGood will do. Whichever you pefer. [20:55:40] Krinkle: OK... I made a separate patches with the fixes 4 silly mistakes in that method... looks like null is also not an accurate check, https://doc.wikimedia.org/mediawiki-core/master/php/html/classFormatJson.html#a38722541c9bf55c894b21643b24016d2 [20:55:46] So all add it into that patch [20:56:20] pizzaLunchCat: I think you just need git add src/bower_modules, not git submodule add [20:57:29] speaking of pizza... [21:00:59] (PS1) AndyRussG: Make CNBannerChoiceDataResourceLoaderModule stateless [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175508 [21:05:33] there be crickets in the standup [21:06:00] AndyRussG: Other than that, I got nothing [21:06:30] AndyRussG: I installed it locally but was unable to test it. I'll defer that to you guys. I assume it "generally" works and has been and will continue to be tested. [21:10:40] AndyRussG: we can't hear you/you're in slo mo [21:11:18] atgo: ejegg|food: sorry!! :( I didn't have more to add, trying to join the hangout again... [21:11:22] ok [21:11:32] when's the switch-flipping probably going to be? [21:11:52] atgo: today! in like an hour :) [21:11:59] Or two [21:12:02] woo!! meganhernandez is ready to do some load testing whenever you are :) [21:18:16] (PS2) AndyRussG: Clean up getFromApi() in CNBannerChoiceDataResourceLoaderModule [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175505 [21:18:36] hi yes, i’m good for world pay vs global collect 100% test in the US. will get that campaign ready to go [21:18:44] (PS2) Ejegg: Add backend Big English config and default filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175501 [21:18:49] weee! [21:18:50] katie just got back with her lunch. maybe once she is donE? [21:19:10] so the global collect vs world pay test will just use buckets A & B [21:19:40] and then tomorrow moring ill run a test full screen banners in bucket A & B, and top banners in buckets C & D [21:19:55] meganhernandez: I don't know much about global collect and WP, but with regard to buckets, the per-campaign buckets are about to be enabled everywhere, I think [21:20:56] yeah katie will monitor for the world pay test for WP specific stuff. and you be on the lookout for campaign/bucket issues? [21:21:26] OK! :) [21:22:00] I think we'll be looking at impressions data for that [21:25:14] (PS3) Ejegg: Add backend Big English config and default filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175501 [21:26:00] (PS3) AndyRussG: Clean up getFromApi() in CNBannerChoiceDataResourceLoaderModule [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175505 [21:28:23] (CR) AndyRussG: "Thanks for catching my silly mistakes! Fixes are in https://gerrit.wikimedia.org/r/#/c/175505/." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173980 (owner: AndyRussG) [21:34:53] hey AndyRussG what time do you want me to put the US up at 100% ? [21:37:27] meganhernandez: it shouldn't matter with regard to how buckets will work, because of the smooth transition from old to new buckets. But if you want to wait until 23:00 UTC, you could have the campaign run entirely on the new code, which might be relevant for checking that everything is running smoothly, I think [21:38:19] The deployment windo for making the change is 22:00 - 23:00 UTC : https://wikitech.wikimedia.org/wiki/Deployments [21:38:34] ok will plan for 23:00, let me know if that moves at all [21:39:13] (CR) Awight: [C: 2] Clean up getFromApi() in CNBannerChoiceDataResourceLoaderModule (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175505 (owner: AndyRussG) [21:39:42] meganhernandez: OK! [21:39:45] (Merged) jenkins-bot: Clean up getFromApi() in CNBannerChoiceDataResourceLoaderModule [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175505 (owner: AndyRussG) [21:44:52] (PS2) Awight: Make CNBannerChoiceDataResourceLoaderModule stateless [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175508 (owner: AndyRussG) [21:44:57] (CR) Awight: [C: 2] "Thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175508 (owner: AndyRussG) [21:45:33] (Merged) jenkins-bot: Make CNBannerChoiceDataResourceLoaderModule stateless [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175508 (owner: AndyRussG) [21:47:11] (CR) Ejegg: "Changed the minutes and dollars per second query to use 60 minutes for all but the current hour." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175501 (owner: Ejegg) [21:48:20] (PS4) Ejegg: Add backend Big English config and default filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175501 [21:51:08] AndyRussG: any other patches we're trying to get in there? [21:51:32] awight: not that I know of! [21:51:36] k! [21:51:55] Any final comments? [21:52:12] <_< [21:52:13] >_> [21:52:25] Punch it! [21:52:39] :) K4-713 has caught the enthusiasm [21:52:49] Or the flu. [21:53:50] Reedy: can you remind me what unpacks the per-wiki selectors in InitialiseSettings.php? No rush... [21:54:58] meganhernandez: something excellent and French is happening on http://128.114.160.142/kzschigh.mp3.m3u [21:55:02] in case y're homesick :) [21:55:34] kk will check & thanks for looking out [21:56:03] AndyRussG: ejegg: fyi (don't merge!) https://gerrit.wikimedia.org/r/175556 [21:56:51] everywhere at once, huh? [21:57:53] ejegg: I am open to reasoning [21:58:05] (PS1) Awight: Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/175557 [21:58:45] Yea, let's do it. I'm pretty sure we won't be killing any sites this time around... [21:58:48] >_> [21:58:52] The worst that can happen [21:58:56] <_< [21:58:57] signed, sealed, delivered! [21:59:12] is that some banners from 2001 will show up in 2030 and vice versa [21:59:15] I'm yours! [21:59:31] O_o how does marktraceur do it? [21:59:32] *rejoicing begins* [21:59:41] marktraceur: you know, you could have quite a career as a troll :) [21:59:44] maybe it's a bot? [21:59:45] awight: I have a "cheesy musical reference" alarm in my apartment [21:59:50] it's amazing. [22:00:00] part bot [22:00:39] (CR) Awight: [C: 2] Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/175557 (owner: Awight) [22:01:05] ejegg: AndyRussG: I forgot to ask. Mind if I do the deploy :)? [22:01:10] (Merged) jenkins-bot: Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/175557 (owner: Awight) [22:01:17] awight: be my guest! [22:01:20] Pls do! :D [22:01:38] ewulczyn: just to make a mark in the historical record, we're deploying the new CentralNotice banner choice algorithm during this hour. [22:01:54] I'll log once it goes out, and there will be 5-15 min of cache lag, of course. [22:02:04] pizzzacat: big english query should be set for code review: https://gerrit.wikimedia.org/r/175501 [22:02:19] awight: exciting! [22:04:35] fwiw, core changes are https://gerrit.wikimedia.org/r/#/c/175560/ and https://gerrit.wikimedia.org/r/#/c/175561/ [22:05:11] waiting for Jenkins to merge... [22:06:44] I think I forgot to send the actual CN-admins mailing list message... correct? [22:07:22] thanks ejegg! [22:08:01] AndyRussG: I haven't seen it yet. [22:08:04] https://lists.wikimedia.org/pipermail/centralnotice-admins/2014-November/thread.html [22:08:15] Donno the cron interval on that... [22:09:41] Yea I was asking myself the same... silly me... [22:09:43] atgo-away: JINX. [22:09:48] 123456 [22:10:00] * atgo-away is silent [22:10:15] Wait. This is a terrible idea. [22:10:27] * atgo-away is actually away and will be back in a bit [22:10:37] * atgo-away sticks out tongue [22:10:49] !log pushing CentralNotice patches [22:10:54] Logged the message, Master [22:11:40] AndyRussG: ejegg: ok patches are pushed. about to deploy the config switch... [22:11:51] Wee again [22:11:52] ejegg: sorry, I noticed you aren't in #wikimedia-operations ^^ [22:12:50] * K4-713 goes squee [22:13:02] I don't see any issues on enwiki so far... [22:13:03] awight: oops, just joined [22:13:13] ops oops? [22:13:31] We should have an oops channel. [22:13:40] lol! [22:13:59] !log enabled client banner choice config everywhere [22:14:01] Logged the message, Master [22:14:02] ^^ [22:14:26] meganhernandez: ewulczyn: ^^ please holler if you see anything odd! [22:14:48] That's a bit of a wide definitiion. [22:14:59] quick, hide yer oddnesses! [22:15:03] can they type that fast? [22:15:07] I can't. [22:15:49] K how long does it take for the config change to go out? I guess however long the startup RL module is cached, so that the new config will reach clients' JS [22:16:21] yeah I think. so < 5 min? [22:16:40] In theory. I think. [22:16:47] I don't actually know that. [22:16:54] But it sounds good. [22:16:54] JS console so far: [22:16:54] > mw.centralNotice.chooseBannerOnClient [22:16:54] > false [22:17:09] Yea I think about 5 minutes is it [22:17:44] If I set ?debug=true, I do get mw.config.get('wgCentralNoticeChooseBannerOnClient'); = true [22:18:24] Woah. I didn't realize that bugzilla is fully redirecting to phabricator now. That's cool. [22:18:26] I just got a banner! and w/out debug= true, chosen on client! [22:18:35] http://en.wikipedia.org/wiki/Main_Page?country=FR [22:18:53] Woo! [22:19:22] Loading via Special:BannerLoader as expected... [22:20:03] hmm I'm not getting anything, even with http://en.wikipedia.org/wiki/Main_Page?country=FR&force=1&reset=1 -- I'll check expected allocations... [22:20:12] not worried, yet. [22:20:24] awight: clear yer banner close cookies and related? [22:20:41] there's also a special wait cookie for that FR campaign [22:20:56] the reset=1 should clear all cookies... [22:21:08] hmm yeah maybe not the close-hide ones. [22:21:40] I'm getting legacy cookie values correctly copied into the per-campaign buckets.. [22:22:10] Yeah just clear cookies like there's no tomorrow and you'll get a banner [22:22:13] ok, getting banners. yeah it was donate and close box cookies [22:22:30] http://en.wikipedia.org/wiki/Main_Page?country=FR&useformat=mobile [22:23:08] Well, we're out of the weeds then. I guess the last step is just to wait for ewulczyn to look over impressions numbers. [22:23:18] yeah! [22:23:40] Dang, guys. Well done. :) [22:24:38] cool, jalexander already nibbled at AndyRussG's bait! [22:24:46] ... [22:25:08] K4-713: thanks! Yay, stacking banners for the holidays! [22:25:29] awight: Ah, the email. [22:26:44] awight: thanks alerting mobile [22:26:49] yep! [22:26:59] ejegg: good catch re: LYBUNT! [22:27:05] (^ yea I meant "thanks for...") [22:27:36] Splitting out the yearly rollup seems like the way to go, right? [22:27:56] move the is_XXXX_donor columns to wmf_donor, probably [22:28:11] then just copy from there during the export [22:28:11] ejegg: I'm sort of approach-agnostic on this, I'd say whatever is the easiest to code, or your preference [22:28:54] OK, I'll see if that approach runs into trouble. [22:29:22] ejegg: I'd like to overlap the silverpop job with a high donation interval, though, to shake out any more deadlocks. [22:30:04] word. Is there a 100% test on soon? [22:30:15] wait, there's a calendar for this someplace... [22:30:16] oh yes :) [22:30:58] meganhernandez: I noticed your testing calendar has a lot more than the Fundraising Schedule calendar... is that more detailed one public? [22:37:10] just got one of the fullscreen French banners on the new system, looks fine... [22:37:24] http://fr.wikipedia.org/?country=FR [22:38:08] fine except I can't freaking dismiss it by clicking outside the modal dialog. [22:38:22] Mmmm not my department [22:38:26] :) [22:38:45] We just serve 'em, if u don't like the food go talk to the kitchen [22:41:57] awight: so... which calendar should I be looking at? [22:41:57] this also works, tho you gotta wait 4 it: http://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal?country=DE&uselang=de [22:43:51] (CR) Ejegg: [C: 2] Update with numeralJS and fontawesome upgrade [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/175493 (owner: Ssmith) [22:44:01] (CR) Ejegg: [V: 2] Update with numeralJS and fontawesome upgrade [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/175493 (owner: Ssmith) [22:44:56] awight: Want to hear a funny joke? [22:45:07] y. [22:45:07] ideal broke because something changed in core. [22:45:34] * K4-713 slaps knee [22:45:56] * AndyRussG hears ideals sadly snapping all around [22:46:05] 8p [22:46:10] what [22:46:18] Specifically, WmfFramework::isPosted() or, you know... lower. [22:46:24] oh my [22:46:27] Right? [22:46:37] You'd think that would... cause more of a... thing. [22:46:41] that's something that should have been in the release notes [22:46:48] It's still there. [22:46:55] * awight furiously looks at release notes [22:47:05] It just stubbornly tells me that my data wasn't posted. [22:47:09] nothing. [22:47:12] nothing about post. [22:47:18] PYLE [22:47:28] I'm... sort of surprised that we're not more broken. [22:47:31] Like, a lot more. [22:47:38] yes. like all the gateway forms. [22:47:42] yep [22:48:12] Like, really quite a lot more broken. [22:48:14] ewulczyn: By the way, you'll now be getting some more data about buckets in Special:RecordImpressions. The new URL parameters, bucketStart and bucketEnd are there to confirm that you're on the new bucket system and that the buckets have the expected duration [22:48:17] HOW IS THIS WORKING RIGHT NOW. [22:48:30] well, this is sketchy. $posted = (array_key_exists('REQUEST_METHOD', $_SERVER) && WmfFramework::isPosted()); [22:48:43] I've got logging all over that statement. [22:48:52] do we have hhvm issues, too? [22:48:57] er. [22:49:02] No? [22:49:10] k good [22:49:21] we don't want that running overly fast. [22:49:22] :p [22:50:11] So, the reason I had to look for the 'REQUEST_METHOD' key, is that isPosted used to throw hella errors in batch mode. [22:50:23] ah. I should move that to WmfFramework [22:50:24] fwiw [22:50:43] That's terrible though. You'd think a FauxRequest... sigh. [22:51:06] I hate it when things go this deep. [22:51:07] * awight in a smaller voice [22:51:10] what changed in core? [22:51:16] No freaking idea. [22:51:29] oh. yeah there's nothing in the release notes, did I mention. [22:51:37] But that's where our code ceases to believe it's a post. [22:51:46] Right in that core-shaped... area. [22:52:09] Which, come to think of it, we're trying to decouple anyway.... [22:52:49] but how can it be so borken [22:53:19] public function wasPosted() { [22:53:19] return $this->getMethod() == 'POST'; [22:53:19] } [22:53:25] public function getMethod() { [22:53:26] return isset( $_SERVER['REQUEST_METHOD'] ) ? $_SERVER['REQUEST_METHOD'] : 'GET'; [22:53:28] } [22:53:29] wtf [22:54:13] omg. that was older. I just stepped over a core change: [22:54:14] public function getMethod() { [22:54:14] return $this->wasPosted ? 'POST' : 'GET'; [22:54:15] } [22:54:30] Trying to figure out where they set wasPosted... [22:54:34] public function __construct( WebRequest $base, $data, $wasPosted = false ) { [22:54:39] NOOOOooooo [22:54:45] Holy Shark. [22:54:54] oh ok let's not do this real-time thing :) [22:55:04] that was DerivativeRequest, which I already know is completely broken. [22:55:13] Of, phew. [22:55:24] Back to square zero: nothing changed in core. [22:55:27] Rad. [22:55:39] * awight shakes off a shiver [22:55:39] But, it must have. [22:56:25] Am I blind? I seriously can't see where this var is being set. [22:56:46] it's that same stuff I pasted [22:56:53] includes/WebRequest.php [22:56:54] hey K4-713 AndyRussG still good for the 100% US test? [22:57:09] Up to AndyRussG. I think so. :) [22:58:05] https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&method=listNoticeDetail¬ice=C14_enUS_dsk_FR [22:58:05] meganhernandez: All set! The config has been enabled for more than half an hour [22:58:10] No issues so far! [22:58:16] awight: That's where I'm looking, yes. I guess I meant "successfully". :p [22:59:01] meganhernandez: currently WMDE, FR France and Wiki loves etc. banners are displaying fine, as far as I can see [22:59:26] meganhernandez: I think the real test will be when we look at the impressions data, but at least nothing big and obvious seems to be crashing [23:00:00] mobile also has no issues seemingly [23:02:12] (CR) Ssmith: [C: 2] Add backend Big English config and default filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175501 (owner: Ejegg) [23:02:17] aw man i enabled the US capaign [23:02:24] but am not having issues with my laptop in general [23:02:26] (Merged) jenkins-bot: Add backend Big English config and default filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/175501 (owner: Ejegg) [23:02:27] so i think it’s up [23:04:23] K4-713: ok i can confirm the same broken posted=falseness [23:04:32] Har. Thanks. [23:04:37] yeaaah [23:04:38] I'm going to keep on the trail here. [23:04:51] I've like... triple-confirmed for myself. [23:05:00] sorry. I just couldn't believe it [23:05:05] I know the feeling. [23:05:12] meganhernandez: lemme check... [23:05:42] K4-713: omg. [23:05:47] oh laptop [23:05:52] sorry AndyRussG it was not up [23:05:52] awight: I'm also looking right at a print_r of $_SERVER, and it all looks like it should be.... what? [23:05:58] ...it looks fine. [23:06:06] * K4-713 frowns [23:06:11] (PS1) Awight: typo-O [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175591 [23:06:29] I'm going to fire myself, for the day. [23:06:29] meganhernandez: Ah OK... It can take 5 minutes or so to get going du to caching [23:06:31] * K4-713 squints [23:06:42] ok it’s up now [23:06:43] ooh [23:06:46] (CR) jenkins-bot: [V: -1] typo-O [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175591 (owner: Awight) [23:06:54] nah my internet stopped working, but i’m back now! [23:07:00] awight: jenkins agrees, looks like. :p [23:07:17] jeez, who +2ed that? [23:07:20] > > [23:07:21] < < [23:07:25] oaaaah man [23:07:35] awight: Let me guess. [23:07:37] * awight hops up and down on coals [23:07:39] Translations of legal text. [23:08:18] 23:06:21 IOError: Lock at '/srv/ssd/jenkins-slave/workspace/mwext-DonationInterface-testextension/src/vendor/.git/HEAD.lock' could not be obtained [23:08:27] er [23:08:30] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175591 (owner: Awight) [23:08:50] well, at least there are two scapegoats in town now [23:09:08] gah [23:09:29] asking on ops [23:10:01] Incidentally, that totally got it. [23:10:05] On my local. [23:10:15] so guys [23:10:19] Whose idea was that shim. [23:10:20] <------ [23:10:24] blaaahrgh [23:10:34] i looked at the banners for this test a little over an hour ago [23:10:40] they looked fine [23:10:43] * awight snaps upright [23:10:44] (CR) Ejegg: [C: 2] "Sorry I didn't catch this when it first went up" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175591 (owner: Awight) [23:10:44] now i can’t see them anymore [23:10:56] neither can ccogdill or PPena [23:11:00] meganhernandez: Can't see them anymore? [23:11:07] meganhernandez: can we haz link pls? [23:11:31] http://en.wikipedia.org/?banner=B14_1030_enUS_dsk_gwy_gc&force=1 [23:11:31] http://en.wikipedia.org/?banner=B14_1030_enUS_dsk_gwy_gc [23:11:35] http://en.wikipedia.org/?banner=B14_1030_enUS_dsk_gwy_wp [23:11:48] i’ll take the campaign down in the meantime [23:11:50] AndyRussG: TypeError: mw.cnBannerControllerLib.bucketsByCampaign is null [23:11:52] Is this incogneto? [23:12:06] yes [23:12:10] was the campaign up? [23:12:23] meganhernandez: U don't have to take the campaign down [23:12:27] actually, that’s strange. they each have about 80 banners [23:12:29] we didnt get a massage with an update… I was just ramdomly testing :) [23:12:31] meganhernandez: I think this might only affect people who directly force the banner [23:12:31] it’s still up awight [23:12:34] awight: where is that? Maybe it's an effect of caching? [23:12:35] k [23:12:41] AndyRussG: my js console [23:12:46] TypeError: mw.cnBannerControllerLib.bucketsByCampaign is null [23:12:56] i mean they each have about 80 donations [23:13:15] yeah, what awight said... [23:13:18] ejegg: awight: what URL and what browser? [23:13:22] ok cool [23:13:27] AndyRussG: bannerController.js line 397 [23:13:29] so we started at 3pm PST? [23:13:42] FF 33 linux [23:13:47] FF, private browsing (so no cookies), http://en.wikipedia.org/?banner=B14_1030_enUS_dsk_gwy_gc [23:13:49] (CR) jenkins-bot: [V: -1] typo-O [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175591 (owner: Awight) [23:13:58] Aw geeze. [23:15:37] AndyRussG: yeah I think it's only when forcing a banner, cos campaign is not set [23:15:53] I wish QUnit tests had picked that up... [23:16:31] awight: ejegg: K i see [23:16:36] and me-unit tests [23:16:55] * AndyRussG smokes (not a cigarette) [23:17:13] meganhernandez I think we are showing CB icon for the US form [23:17:19] noo not the exploding cigar! [23:17:21] I mean, /me smokes like a smouldering machine [23:17:28] awight: Okay, so, *now* it's the french text being changed. :) [23:17:35] meganhernandez should be showing Amex instead [23:17:41] I'll fix that and then you review and rebase? Blah. [23:17:56] K4-713: that's reediculous [23:18:11] I think at some point we wanted that to scream like woah. [23:19:19] im not sure if that was created PPena [23:19:43] this is the only US world pay form i have, do you have another one with the card logos you want? [23:19:49] meganhernandez it should have been, we tested with that priori to France [23:20:17] K4-713 Do we have a US specific form? [23:20:27] Uh. What for? [23:20:53] Worldpay? [23:21:45] K4-713 yes. The form meagn is testing now shows CB, which obviosuly dont work in the USA [23:21:48] and doednt show Amex [23:21:59] I knot we have tested with a different form [23:22:27] I don't think the ffname is different, but it's supposed to pick up on the country and fly in different things. [23:22:29] AndyRussG: oof, I think I QUnit smoked yr latest patches wrong. [23:22:34] I also see failure in Wrong number of banners allocated in "geoNotInCountry". expected: {}, actual: [ [23:22:48] PPena: I don't know if we did that yet, though. atgo would know better than I do. [23:23:03] meganhernandez: awight: K4-713: ejegg: yes, the force= option is broken, so it's no longer possible to preview banners on-wiki. That's a pretty serious issue, but I bet it's a quick fix. Shall we take out a deploy slot? [23:23:07] pizzzacat: Did you ever do US modifications for the WP form? [23:23:22] awight: I saw all good on QUnit tests on jenkins... [23:23:26] AndyRussG: please do. Maybe ask greg-g for asap [23:23:39] greg-g: got some ASAP? [23:23:51] AndyRussG: I see this exact issue, now. I think it passed on Jenkins cos the client choice variable defaults to false. [23:23:54] It's in a big jar on his desk, I think. [23:24:11] yeah being able to force banners is definitely needed [23:24:11] K4-713 what did those entail? [23:24:23] pizzzacat: I think just different cc icons? [23:24:40] If this does not sound familiar, it's just a "no". :) [23:24:44] this is the first I've heard of this [23:24:47] :) [23:25:14] Okay. Well, dang. [23:25:37] (PS1) Awight: default to client banner choice [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175597 [23:25:41] awight: ejegg: looks like the we could take 17:00 PST, whaddya think? [23:25:50] AndyRussG: I'd like earlier... [23:25:54] pizzzacat: I could swear that when you set it up, CB wasn't default everywhere. [23:26:09] 16:00-17:00 PST i taken by the evening swat [23:26:11] AndyRussG: but only out of selfish "have to go home" reasons :) [23:26:14] (CR) jenkins-bot: [V: -1] default to client banner choice [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175597 (owner: Awight) [23:26:16] pizzzacat: Maybe I just mean "are there different cc icon sets?" [23:26:34] pretty sure I just deleted everything besides what France needed. [23:26:39] Ah, okay. [23:26:49] because we weren't thinking about US yet. [23:26:57] sounds likely [23:27:08] AndyRussG: if u base your fix on the config change above, you'll get QUnit help... [23:27:18] Hmmm I had even thought of running thsoe tests locally, but I was like, that's what jenkins is for... [23:27:22] PPena: Sounds like we're going to need a card for the WP US form. [23:27:26] AndyRussG: nvm about deploying earlier... sorry [23:27:27] K4-713 meganhernandez ok then its not really a fair A/B [23:27:34] will show us if WP works, though :) [23:27:48] awight: ejegg: I'm gonna grab 17:00 PST then? Can one of U do it? :) [23:28:21] sure [23:28:31] awight: cool thx! [23:29:09] resutls so far [23:29:10] https://docs.google.com/a/wikimedia.org/spreadsheets/d/1bl1FbyyGbOwxGJ-vYdnOPUfppKNGdFP_8KuDybBIdZE/edit#gid=511645806 [23:30:13] meganhernandez: we should start including impressions# [23:30:23] yeah we do [23:30:27] oh [23:30:32] with statler [23:30:38] ./statler B14_1030_enUS_dsk_gwy -s 2014-11-24 [23:30:39] ah, in another thing. sorry! [23:30:53] but get the payment method breakdown in ecom still [23:31:51] AndyRussG: awight what's up:? [23:31:55] (PS1) Katie Horn: Removing language cruft and copypasta in usin tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175599 [23:32:10] (CR) jenkins-bot: [V: -1] Removing language cruft and copypasta in usin tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175599 (owner: Katie Horn) [23:32:14] Ah hi greg-g-- awight suggested we summon you in case we had trouble getting a deploy slot quickly [23:32:17] But we did get one: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_November_24th [23:32:20] the h... [23:32:51] greg-g: thanks in any case-- awight is tht all u wanted to ask of greg-g? [23:33:12] yep, thanks [23:33:35] What is this lock business. [23:33:53] K4-713: I'm asking in -ops [23:34:05] ori is suggesting we override jenkins :( [23:34:06] greg-g: thanks much!! :) [23:34:21] awight: ugh [23:34:29] This is a test-only patch. [23:34:45] I mean, it works on my local. [23:35:42] you guys care how long this runs? [23:36:50] (CR) Ejegg: [C: 2] "Good riddance!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175599 (owner: Katie Horn) [23:36:52] meganhernandez: I would like to look at the leading and trailing edge cache effects, so an hour is good. you were thinking of making it shorter? [23:37:14] (Merged) jenkins-bot: Removing language cruft and copypasta in usin tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175599 (owner: Katie Horn) [23:37:16] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175599 (owner: Katie Horn) [23:37:41] aw man. Now I don't know if it was me poking it, or you poking it. [23:37:44] K4-713 https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2193 [23:37:44] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175591 (owner: Awight) [23:37:51] ok will leave up for a full hour [23:37:59] awight: gonna re-run the sp export now [23:38:04] ejegg: :) [23:38:19] meganhernandez I dont, because this wont really let us know which success rate is higher [23:38:21] awight: Rebase that typo thing? [23:38:32] I can deploy it now and complicate my evening even more. [23:38:42] meganhernandez we should run a test later on, with WP form corrected [23:39:35] awight: thanks. :) [23:39:51] (PS2) Awight: typo-O [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175591 [23:40:44] awight: ejegg: I don't see any uses of the "force" param in there, is it maybe form a bygone era [23:40:52] can anyone tell me what the SHA-1 of this patch is? https://gerrit.wikimedia.org/r/#/c/175055/ [23:41:14] it's not the same as the change ID, apparently [23:41:33] AndyRussG: force= is implemented in banner code. Did I understand your question? [23:41:45] awight: yes [23:41:47] pizzzacat: I think it's b41cb8ea5632274098f354aee707aec97c0b94bd [23:41:53] pizzzacat: Yeah, it's the... see where it says "Patch Set 3"... exactly. [23:42:02] AndyRussG: It's still a thing: http://meta.wikimedia.org/wiki/MediaWiki:CentralNotice/Resources/BannerShowHideCountDate.js [23:42:10] awight: get the error without force but with banner= [23:42:16] yep [23:42:23] ok sweet, so it's like a more specific change ID [23:42:40] AndyRussG: afaik force= is unrelated to the problem at hand [23:42:45] sorry if I said otherwise [23:42:58] pizzzacat: Change ID groups the patches. The hex code is unique for all changes. :) [23:43:05] awight: NP! It looks like just fixing banner= will do it [23:43:16] yes I think it will [23:43:36] makes sense now. [23:44:15] I was trying to sort of slightly-retroactively create a branch specific to only Big English widgets, which I'm refactoring out into their own modules [23:44:48] and I realized that my local BigEnglishModules branch did not mean that Gerrit understands this is a separate branch [23:44:55] which I vaguely remembered from long ago [23:45:12] so I go in to #officially create the branch [23:45:28] oops my sarcastic hash tags mean something in IRC maybe [23:45:37] …anyway… [23:45:51] it gives me this option to start from a specific sha-1 [23:46:10] so I give it the first BigEnglish-related patch (the one I just linked to) [23:46:21] and this happens: https://git.wikimedia.org/log/wikimedia%2Ffundraising%2Fdash.git/refs%2Fheads%2FBigEnglishModules [23:46:49] and I am squinting and moving my laptop around [23:47:02] is this correct? [23:47:17] because here's master, for comparison: https://git.wikimedia.org/summary/wikimedia%2Ffundraising%2Fdash [23:48:02] I think actually it is… I am just missing a patch. but it's not merged. so that's probably why. [23:48:12] pizzzacat: you could rebase your other branch to pull in the last couple things from master [23:48:20] wait, but neither is that one.. [23:48:42] true, but would they be in two places? and they aren't merged [23:49:07] I was trying to work independently of those getting merged but I don't think I really am helping myself here [23:49:27] but I do need to move on [23:49:33] hi again! [23:49:44] pizzzacat: Sorry, wandered off to get water. [23:49:48] Catching up. [23:50:00] no worries. [23:50:08] hydration is important [23:50:33] Indeed. [23:50:53] So, ah... what looked wrong about the history? [23:51:13] well. I'm just missing one patch from either set [23:51:16] er [23:51:18] the same patch [23:51:38] (CR) Awight: "Weighing in a bit light and late on this one, but: TODO: add a test that includes a translation fixture, with escape-sensitive stuff, and " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/175599 (owner: Katie Horn) [23:51:45] and it hasn't been merged yet [23:51:50] so I was like oh, that's why, [23:51:58] hey AndyRussG! reading the backscroll i'm not sure how the switch-flip went? [23:52:02] but the top of BigEnglish isn't merged yet eitehr [23:52:05] *either [23:52:19] atgo: production great! meta previewing banner on wiki button, drep [23:52:22] anyway. just trying to work on top of master, but master isn't merged/reviewed yet [23:52:48] and am unsure of the level of changes that will ensue [23:53:00] so unsure how to proceed [23:53:00] (PS1) AndyRussG: Fix previewing banner on-wiki [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175606 [23:53:06] "meta previewing banner on wiki button, drep"? [23:53:09] AndyRussG: ^ [23:53:18] (i don't know what that means haha) [23:53:39] drep, means, a silly person broke that while writing code for per-campaign banners [23:53:45] So all's well with our fundraisees [23:53:48] ahhhh i see [23:54:00] per-campaign buckets I eant [23:54:02] meant [23:54:03] rrrgggg [23:54:10] :P [23:54:14] ^ there's an initial patch to fix it, and we have a deploy slot for 17:00 PST [23:54:18] pizzzacat: Ah, okay. So... it sounds like you want to write something that *is* dependent on what isn't merged into master yet. Is that correct? [23:54:39] ah I meant derp, not drep [23:54:39] Or did I just miss the point? [23:54:55] yes, was thinking more like, those two unmerged patches, which I locally call "BigEnglishModules" needs to be an *acutal* branch called BigEnglishModules [23:54:56] drep derp dorp whatever [23:55:21] pizzzacat: in github, or gerrit? [23:55:27] (CR) AndyRussG: "Tests still failing locally..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/175606 (owner: AndyRussG) [23:55:31] gerrit, we have abandoned github [23:55:38] woo. [23:55:42] This is probably good. [23:55:44] ...now. [23:55:45] pizzzacat: how long do you want the branch to stick around? [23:55:54] it was a nightmare to merge with gerrit because gerrit requires change ID's [23:55:59] like, hours / days / months? [23:56:03] which github didn't use [23:56:06] among other issues [23:56:14] days [23:56:14] pizzzacat: wait. Which did you abandon? [23:56:18] github [23:56:27] you are back to your nightmare? [23:56:31] yes. [23:56:35] ohwow. [23:56:38] have been for a few weeks. [23:56:41] *songbirds of freedome twitter and tweet* [23:56:54] maybe even longer [23:56:54] Stop me if this sounds crazy. [23:56:55] well, for just days, do "git push gerrit HEAD:refs/for/BigEnglishTurd" [23:57:08] * K4-713 waits for people to stop her before she starts [23:57:22] lol [23:57:40] pizzzacat: for more convenience, edit .gitreview and set defaultbranch=BigEnglish [23:58:22] Can you check out master, create a new local branch, cherry-pick everything you want that isn't merged over to it, and push that to a new branch? [23:58:30] not in gerrit :) [23:58:37] it's specially designed to make everything horrible. [23:58:42] Oh good. [23:58:52] I guess what I thought I was doing when I created the branch in gerrit and set the first sha-1 to be the first of two unmerged patches that I want to be in the new BigEnglishModules branch was that I was moving them into the new branch and out of master [23:59:07] This is probably part of the reason I never bothered with having branches *in* gerrit, other than deploy. [23:59:14] the new f'ing banner covers up the page content!!!!! [23:59:16] well maybe I should just not bother. [23:59:16] WTF?! [23:59:17] there is one more option, which I don't recommend for this, but you can push directly to a special sandbox area, "git push gerrit HEAD:sandbox/awight/WIP-english" [23:59:24] and just keep going with master. [23:59:26] however, that doesn't give you reviewability [23:59:58] sorry for "!!!!", but it was quite annoying