[00:00:59] awight: awight-babiesbab: Ah yeah I see, the name of the Mediawiki: page for the banner has that as the prefix, silly me [00:01:48] I guess we'll wait for the whole beta cluster to more or less start working and then see if our specific issue is still there... [00:12:09] Eloquence: will we fill these new vacancies with wikibugs? [00:13:07] How many wikibugs does it take to replace a developer? [00:15:00] if you have a wikibugs shortage, you can always acquire some chaos monkeys [00:16:00] Hmmm not sure our cluster will run Shakespeare [00:17:33] Though at least one line will include an or operator [00:22:59] (PS1) Ejegg: Delete PayflowPro [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/206339 [00:35:22] awight: I guess in the long run we could have better oo structures for bannerController and ths lib [00:36:48] My conflicts around the choiceData.length == etc. related to implied separation of concerns, I think that's where you're coming from too, no? [01:40:24] (PS2) Awight: Make resultswitcher processing slightly less funky [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206307 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [01:43:38] * awight Wistfully reads the backscroll [01:43:42] ah, literate programming [01:45:15] Yeah, separation of concerns, but more so, the complexity of code paths in a single function. It's awesome to see the monopoly breaking up with each of your patches! [01:52:59] (PS8) AndyRussG: Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) [01:54:51] awight: thx! [01:55:38] I've felt pretty engaged on this patch, though I'd undertand if everyone were tired of seeing it not move on the sprint board... [01:58:33] (CR) AndyRussG: Allocation: choose campaign first, fix throttling bug (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [01:59:24] On the contrary--you pack a lot of diligence into these big changes, and the directedness also is inspiring! [02:00:31] Mine these days is pretty well characterized by "dirt monster" productions ;) I find myself constantly sticking extra patches onto the beginning, end and middle of everything. Pretty sketchy stuff. [02:01:28] ... and leaving my cards on the sprint board for at least as long :p [02:27:16] dirt monster does sound fun! [02:32:36] not when I have to figure out what went wrong with the card house [02:33:31] (CR) Awight: "TODO: needs exception handling and error tests around backend calls." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) (owner: Awight) [02:33:56] while sketch another name for iteration, the bits I saw definitely didn't look sketch [02:34:15] speaking of which :) I almost tried to push that code out without error handling! [16:33:10] (CR) Awight: Make resultswitcher processing slightly less funky (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206307 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [16:41:33] AndyRussG: Rats, I see you found a way around doing i18n inside a Mustache template. pizzzacat and I just ran into that wall, doing DonationInterface templating. [16:42:50] It turns out, Mustache doesn't support helper functions! Even if we used handlebarsjs, it seems like a tough problem on the client side, cos you would need to know which message strings are needed before doing the substitution! [16:50:53] awight: hi! Mmm yeah I remember thinking about that! It might be fun if MW added a feature whereby you could just include an i18n key in the template [16:50:58] Fundraising Sprint House of Pain, Fundraising Tech Backlog, Wikimedia-Fundraising: Backfill donor language information from logs? - https://phabricator.wikimedia.org/T94670#1234042 (awight) [16:50:58] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: BUG: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1234041 (awight) Open>Resolved [16:51:39] I see some mention of functions here: https://github.com/janl/mustache.js . What do you mean by helper functions that's different from that? [16:51:49] woohoo thanks for t94506 awight! [17:02:18] AndyRussG: This is the only mention I see in the spec, https://github.com/mustache/spec/blob/master/specs/~lambdas.yml [17:03:15] I think the conversation is still open, about whether we use any of the Handlebars extensions. [17:06:02] I'm not sure any of this will be palatable in client-side template rendering though, cos even milkshake (https://github.com/wikimedia/jquery.i18n) loads the entire list of i18n messages, AFAICT. [17:06:36] It wouldn't be very fun to have to maintain a list of msgs which are exported to the client... [17:06:58] * awight ponders kicking this over the fence, to i18n and mw-core teamsen [17:10:24] Flow uses extensions via lightncandy to do their i18n: https://github.com/wikimedia/mediawiki-extensions-Flow/blob/master/includes/TemplateHelper.php#L141 [17:11:31] we could ask if they have a roadmap to using the core wrapper [17:12:06] ejegg: Thanks! [17:14:54] awight: here: https://github.com/janl/mustache.js#functions [17:15:08] { [17:15:08] "name": "Tater", [17:15:08] "bold": function () { [17:15:08] return function (text, render) { [17:15:08] return "" + render(text) + ""; [17:15:09] } [17:15:12] } [17:15:14] } [17:15:23] Isn't that a helper function? [17:15:51] Templates could have a special character before an identifier to indicate it's an i18n key [17:16:21] And another to indicate that the value of the variable name passed in is a key [17:18:21] wrt jquery.i18n, which list of messages? can't be all the i18n messages available for MW... Or do you mean, the values for all languages for each every key? [17:18:52] Yah, I imagine it should look like "{{ i18n donate-interface-foo 1=count_things 2=other_thing }}" [17:19:14] woo that'd be fun :) [17:19:35] ejegg: never tried lightcandy... I've heard that Flow has some nice stuff going on under the hood, tho... [17:20:02] Well, it shouldn't be our problem to solve, but it looks like jquery.i18n wants to load the entire list of i18n messages available. [17:20:05] I want Flow to integrate an AI to automatically summraize long entrenched discussions and suggest compromise positions [17:20:14] :D [17:20:21] Or troll lulz [17:20:21] AndyRussG: nice [17:20:34] "you're both wrong 8p" [17:20:44] heheh [17:21:37] maybe just the i18n messages made available in the definitions of the RL modules invoked? Tho that could still be a lot.. [17:23:15] Thanks for talking me down :) That's not such a terrible thing! [17:25:35] Fundraising Sprint Indigo Girls, MediaWiki-Templates, MediaWiki-extensions-DonationInterface, I18n: Mustache renderer needs to support i18n - https://phabricator.wikimedia.org/T97149#1234135 (awight) NEW a:pizzzacat [17:27:57] awight: ah I'm not saying you're wrong! Just trying to understand :) [17:30:17] It seems like silly repetition, but if we're already listing i18n message keys explicitly for RL, we can probably reuse that list. [17:30:57] Would be nice to have something like gettext which can extract the i18n message keys used :~/ [17:36:34] gettext is evil [17:38:23] :L haha [17:38:56] Yes it is. I just added gettext support to C++, using cmake rather than automake. Totally unsupported and insane. [17:39:25] Still not quite working right once I build the .deb package [17:49:09] awight: what C++ deb packages are u building? [17:55:56] AndyRussG: software I ruined my wedding with ~~~ https://github.com/adamwight/booths [17:56:33] https://github.com/adamwight/booths/commit/420e219035421e3d6ad600f999c4ebebd5859875 [17:56:37] let's leave it at that [17:57:27] That's when I realized my vocation was not to be a programmer :) [17:59:07] O_o [17:59:11] o_O [17:59:47] * AndyRussG was indeed wondering whether asking about the details was a good idea [17:59:49] It felt sort of like fixing a friend's bike, then hearing they were in a terrible and unexplained crash. [18:00:06] Ouch [18:00:11] * awight lightens the mood [18:00:36] Good thing we're just raising small amounts of money for the last remaining free knowledge in the world :D [18:00:50] The last of the Buffalo? [18:01:34] Aww [18:01:50] I wonder how the beefalo are doing... [18:01:54] Heh don't worry, I won't give WMF staff large quantities of the tequila that had an unusual effect at my wedding... [18:02:27] ono [18:02:32] that sounds more fun! [18:02:35] (...after the event it might have been dubbed "tequila tumba-novias") [18:02:49] * awight hasitily dictionaries [18:02:58] O_o [18:03:11] o-o` [18:03:54] ("tumba" as in "cause to pass out" and "novias" as in "brides") [18:04:00] baahahaha [18:04:21] * AndyRussG stops self from sharing more family secrets in public forums.... bah [18:04:21] ok good. I was hoping I read that wrong: https://www.google.com/search?q=tumba&tbm=isch&tbo=u&source=univ&sa=X&ei=TYU6VZWnJ4ewogSw9YEY&ved=0CB4QsAQ&biw=1280&bih=729 [18:05:13] We did have a large quantity of homemade "meyer lemon wine" and plum "wine", luckily our friends avoided actually drinking any [18:05:14] Ah right that's another meaning... I wonder if it the two meanings are related... [18:05:49] what is that? http://listastop.com/recursos/imagenes/b06341d9ea298c4.jpg [18:06:44] These are not real. http://cabeceras.eldiariomontanes.es/imagenes-actualidad/galerias/58/tumbas-y-lapidas-extraas-081024x768-982.jpg [18:07:43] ouch [18:11:57] Gack, I get a js error in Special:CentralNotice&subaction=noticeDetail, from the datePicker stuff... [18:26:16] awight: in which patch? [18:26:32] actually I'm getting errors all over the place with the RL patch in core and the mixin patch in CN [18:27:03] Though only in one of my 2 MW installs... [18:27:05] PHP Notice: Undefined index: file in /home/lap/Development/mw2/includes/resourceloader/ResourceLoaderImageModule.php on line 180 [18:30:47] urp [18:31:19] Yawllup [18:31:25] Well, I'm smoke testing 205193, but I think this has been around much longer. [18:32:07] There are also a ton of deprecated globals warnings in JS, which I can't quite track down. [18:36:26] awight: what error are u getting? I didn't get none... [18:37:54] Hundreds of these, 'Use of "wgMonthNames" is deprecated. Use mw.config instead.' so I don't think it's our fault... it's just messing with my signal:noise ratio [18:38:05] pretty much every global appears! [18:38:14] Wierd! [18:38:31] And what version of core are u on? Did you remember to do composer update when updating core? [18:38:42] weird I meant [18:39:21] * awight clutches to toothpicks to avoid being swept down into the rabbithole [18:42:04] rabbitsand! [18:42:20] Yeah I don't think that patch'd affecte any of that... [18:44:00] Ah, some of it is junk coming from old templates I'd transcluded from the banner... [18:45:54] awight: you're planning to pull phpqueue into PaymentsListeners, right? [18:48:10] ejegg: yep, also into the CRM [18:48:27] actually--don't write anything new in the PaymentsListener repo, sorry! [18:48:37] New listeners should be written as SmashPig modules [18:49:05] ohh, right! Oops, was playing in the wrong mud puddle [18:49:18] hehe well don't dry yr feet just yet [18:49:32] There are some things going on in SmashPig, which you should feel free to change... [18:49:38] Cool [18:49:55] We still use PaymentsListeners for paypal though, right? [18:50:18] We need to port that over to SmashPig, too... [18:51:20] But in the meantime, yeah we'll leave the legacy listener alone. I don't think it touches the limbo queue, so we shouldn't have to add php-queue there. [18:52:37] ejegg: gotcha: the PaymentsListeners/SmashPig submodule pointer is way stale, and deprecated. [18:53:07] refer to the repo directly, ssh://XXX@gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig.git [18:53:16] thanks! [18:53:28] * awight facepalms that I didn't mention this in the card [18:54:19] orphan slayer, antidata, smashpig... [18:55:00] I... named all of those things. [18:55:14] Back from the undead! [18:55:18] Sort of! [18:55:27] That's the best time to name stuff, for sure! [18:55:36] Straight away [18:55:42] Oh, indeed. [18:56:01] If I've been undead for more than like 20 minutes, I can only think of the most boring of names [18:56:26] It's all "Uuuuuuuuurgh" and "Hnnnnnnnngh" and things. [18:56:33] Ah sorry I meant unundead [18:57:22] I do like those names actually [18:58:21] The most interesting name I've got to work with currently is "mixin", and that was awight's doing.... [18:58:26] Huh, no dependency either way between DonationInterface and SmashPig. I thought we'd be sharing some stuff [18:58:49] Eventually, it should. I think. [18:59:18] I mean, smashpig was *supposed* to be the independent payment libraries, initially. [19:00:43] So slowly migrate shared logic from DI to SmashPig and require it that direction? [19:01:00] I think that was the original plan. [19:01:41] And, I should know that, because the original plan was mine. But then mwalker ran off with it... [19:01:55] Our plans diverged more than somewhat. [19:02:25] Cool. Signature verification is the first thing I can see to share in the case of Astropay [19:03:03] Nice. [19:03:32] There may be some difficulties in actually setting things up the way I'd thought about it initially, though. [19:04:34] May have to descend in to some kind of submodule madness. [19:04:54] well, at least they're both composer packages now! [19:08:59] Let's revisit the SmashDonation PigInterface plan when you get back from strapping AstroPay to the foundation... [19:09:40] yaaaaay [19:09:42] My hesitation is that, a lot of the great things about SmashPig should actually be independent components: the logging and configuration. [19:09:57] Well, yes. I have others. I think. [19:10:25] We should get all whiteboardy about it. [19:10:49] And lots of other things we need for DI haven't been figured out yet, like plugin architecture, transformers, and even message queueing [19:10:50] ahh, ok. Signature validation would be a pretty tiny amount of duplicated code to require lashing them together [19:11:18] I'm all for including SP from DI, if you see a use for it [19:11:26] I'm not sure that I am. [19:11:29] At the moment. [19:11:39] I can get behind that, too :) [19:11:58] heh [19:12:08] think i can write a listener without any drastic dependencies [19:12:41] I doubt it... I wouldn't even bother, just do 'em like the others [19:13:15] ah right, i meant without adding any new dependencies between our big chunks [19:13:21] oic, yeah [19:13:43] * K4-713 is still giggling about PigInterface [19:13:59] I really feel like this is a hazing ritual, and probably illegal somehow [19:14:35] I don't know if anyone has ever sat down and actually written the frontend, listener, and audit integrations for a processor... [19:14:36] I have come to suspect multiple levels of hazing going on. [19:14:36] it has been a good crash course in what I didn't realize I didn't know about our code [19:14:59] * awight braces self for the suckerpunch [19:15:02] awight: In their current form? No. Just ejegg. :) [19:15:19] It's a *special* distinction :p [19:15:22] ejegg: Your feedback is important to us. [19:15:25] hehe [19:16:26] Particularly if that feedback is in the form of half-snarky public documentation. That would be great. [19:16:35] the DI bit definitely would have been a worse before awight's Jan-Feb refactoring [19:16:48] :) [19:17:59] (CR) Awight: [C: -1] "Tiny blocker" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [19:19:05] K4-713: ah I think I get it... [19:19:14] You do? [19:19:30] * awight rushes over to watch the fight [19:19:33] Oh good. Somebody should. [19:19:57] AndyRussG: What are we talking about? [19:20:14] Ah the name "smashpig" [19:20:26] Sorry I skipped a bit of the backscroll [19:20:49] a "safe place" for your donation :) [19:21:28] oh, i had assumed awight named that one, and it was something like smashing capitalist pigs [19:22:22] the ironic payments library [19:22:56] Hmm not pigs that look simply smashing, I guess [19:23:01] I almost don't want to tell you. The theories are great. [19:23:26] (CR) Awight: "Another potential blocker: I've created two campaigns with one banner each. The first is throttled at 51%, the other is unthrottled. -> T" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [19:23:38] Poets aren't supposed to explain their own work to people ;) [19:23:45] <_< [19:23:46] >_> [19:24:21] * awight gets a new, lighter-colored disguise for surviving potential Bart police encounters [19:26:42] awight: checking allocation stuf [19:27:17] AndyRussG: don't worry about my second comment, yet. Something really strange is going on, I'll investigate & let you know if it's the patch, or my setup. [19:27:42] Hmmm... well try master... [19:33:34] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: BUG: Campaign date fields cannot be edited as text - https://phabricator.wikimedia.org/T97159#1234683 (awight) [19:33:45] That was one problem :) [19:35:35] even -master looks broken... which means it's me that's broken... argh [19:38:05] I’m desperate need of some mysql help… awight or ejegg, can I steal a bit of your time at some point today? [19:38:14] I’m *in... [19:38:23] ccogdill: sure, this is a good time [19:38:28] excellent [19:39:05] AndyRussG: I'm on BannerAllocation (-master), and see a FOUC with the correct allocations, which is immediately hidden, leaving just empty allocations. Is this a thing? [19:41:08] awight: update your master [19:41:28] That's a css bug that's been fix't [19:44:14] I'm at Date: Tue Apr 7 19:02:39 2015 +0000 [19:44:30] ok yep, stale! geez... [19:46:28] You know that CN moves like lightning.... through plastic... [19:51:32] * awight bleaches eyeballs after looking at Special:BannerAllocation at all [19:54:18] How does lightning move through plastic? [19:54:41] well, certainly not very fast :) [19:54:49] Probably with a lot of melting. [19:55:03] I'm sure it smells amazing, too. [19:55:11] K4-713: haha [19:55:38] It's so Friday on this channel... [19:56:00] Isn't it usually? [19:56:15] Well yes, but Fridays even more so, no? [19:56:26] Oh, you're probably right. [19:56:37] awight: I set up 1 campaign at 51% and the other one unthrottled, at the same priority, and I'm getting the correct allocation both server- and client-side [19:57:04] Maybe you're missing some detail about targeting, such as logged in status or device that the banners target, or something? [19:58:05] If you're become stumped maybe a screenshare, if you think that'd be useful [19:58:09] ? [19:58:38] (CR) Awight: [V: 1] "Smoke tested, looks correct! Please ignore my last comment." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [19:59:04] awight: still gotta fix that bucket param... [19:59:20] silly silly bucket bucket [20:00:05] AndyRussG: I was hitting a fun bug, https://phabricator.wikimedia.org/T97159 [20:00:32] Just gonna look to see how it is that things were actually working with the wrong bucket param [20:01:14] I think it will look like 0, and only throws a notice if php.ini error_reporting includes E_STRICT [20:02:00] Hum! maybe I should set that, then... [20:02:49] A complement to that bug ^ is that sometimes the browser autofills values in the CN admin form to make it look like something changed but it hasn't [20:03:25] I dunno how the-wub and friends live with stuff like that... ;p [20:04:16] * awight palm-faces [20:04:44] ooh, that stuff drives me nuts. [20:04:53] i think we can hint not to do that [20:05:15] It's like, it says spaghetti but really it's burnt risotto [20:14:38] K4-713: ? [20:14:42] ejegg: if I was supposed to hear any of that, pls irc... [20:18:58] Hazing isn't what it used to be [20:19:07] It totally is. [20:20:04] AndyRussG: This is the stuff that could use a little extra CR: https://github.com/adamwight/php-queue/commits/master [20:20:07] That was bizarre [20:20:21] Or was it a joke? [20:20:25] I could hear everyone. [20:20:38] AndyRussG: My profile image is a broken image icon from the 90s. [20:20:42] Because I am a jerk. [20:20:47] How do I know that was even you? [20:21:00] I didn't see the green dots either [20:21:04] huh [20:21:10] Yeah [20:21:12] I can verify that she was her. My voice is my identity [20:21:18] err [20:21:18] verify me [20:21:23] my voice is my password [20:21:26] thx [20:21:26] passport, actually. :p [20:21:43] right! how could I forget the phoneme extraction dinner scene [20:22:01] That word just sounds really sexy: passport [20:22:04] So great. So, so great. [20:22:20] :/ no sound, no phoneme jokes [20:23:29] awight: K I'll check it out! Should I be looking at the diffs with the unforked lib https://github.com/CoderKungfu/php-queue? [20:23:48] K4-713: sorry if I was unintentionally interrupting you then [20:23:56] awight: one comment for you on GH about empty vs isset for options [20:24:21] AndyRussG: The really weird thing is that you weren't. It was like you were politely waiting for breaks to tell everybody you couldn't hear anything. [20:24:49] * K4-713 is still being hazed [20:25:24] O_o [20:25:26] o_O [20:25:31] crazy [20:25:55] I did see a message that said "I'm still talking" which made me think I must have been interrupting [20:26:03] aww, what a teaser. https://www.youtube.com/watch?v=Cng2aPF_WAc [20:27:33] AndyRussG: I'm interested in anything you notice about those patches or the underlying code. Especially interested in your thoughts about the interfaces we'll be using, in src/PHPQueue/Interfaces [20:27:59] awight: K u bet! [20:28:10] AndyRussG: yeah, looking at diffs would be fine, too [20:29:30] Speaking of diffs, I had a great experience using Meld to rebase the mixin patch on the rolled-out allocations patch. I'd never used a graphical diff tool for actualy resolving conflicts, just checking aut differences [20:29:43] yah! git mergetool? [20:29:52] Yeah exactly! [20:30:05] The git integration is really nice, but I can never remember what each pane is supposed to be [20:30:06] I did the rebase and it got paused as expected to resolve conflicts [20:30:31] rebase -i :) [20:31:23] Yeah I did that! But there were stil conflicts, 'cause the rollout took only some changes from certain files [20:31:39] And then there were more changes folloing CR in the allocations stuff [20:32:22] I got three panes. The middle one was where I put the stuff I actually wanted in the file following the rebase [20:32:46] I think its initial contents may have been some automatic attempt at a merge, not sure [20:33:20] pretty soon, we'll be on full autopilot https://www.youtube.com/watch?v=rQbj9uvYL8I [20:33:29] And the left panel was the file as it is in the new parent and the right one, in the the old parent... I think... [20:35:25] lol [20:36:07] Rrrg if my kids hear the sound they'll come and scold me for not working! [20:37:39] I was also happy to discover that I could just edit the files right there! Now I'm like, I wanna play with that more but I don't have any merge conflicts to fix [20:43:08] (CR) Awight: Make resultswitcher processing slightly less funky (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206307 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [21:03:24] atgo is out on vacation, isn't she? [21:03:56] Now who am I going to stare at with a haunted look and ask what on Earth I'm forgetting to do? [21:04:45] her OOO message says scuba diving! [21:04:51] * K4-713 tries staring at awight for a minute [21:05:29] * K4-713 stares ineffectually at OOO message in inbox [21:05:46] * K4-713 stares at rapidly cooling bowl of soup [21:08:05] ...nope. It's no good. The soup tells me nothing. [21:15:13] LOL [21:16:03] I was just silently lolling to myself about however you pulled off years more stability while the fixtures are falling off the walls around us. [21:16:20] Thanks btw :) [21:16:26] <_< [21:16:27] >_> [21:16:30] Aw. You're... welcome? [21:16:37] hahah [21:17:58] I wish I didn't have exactly the kinds of experiences at all previous jobs that were clearly applicable to the ongoing state of the donation pipeline, but... [21:18:28] * K4-713 looks haunted again [21:18:38] We really should replace all those pennies with actual fuses. [21:20:52] My grampa wired up a bunch of old houses with the electricity live. I wonder what the Soviets were doing, at the time... [21:21:50] Storing the electricity in large, truck-mounted capacitors every several city blocks, I suppose... [21:22:00] Wow. Was your grandpa dipped in insulation? [21:23:46] Man it's so insidious that in php you can say $uninitialized_variable % 2 and it silently gives you just 0 [21:24:01] I just wanna scream "Java"! [21:26:08] Oh man. I wonder if Dylan remembers how I feel about Java. [21:26:12] Probably. [21:26:19] It used to be a great routine. [21:26:29] K4-713: nah, but I have a gruesome story about him getting dipped at the hospital if you want. [21:26:35] eeep [21:26:56] And then that tiny part of me that can't turn away a gruesome story intervenes... [21:27:19] AndyRussG: yeah, bring on the null pointer exceptions :p [21:28:35] Not even... all I'd need are compile-time errors highlighted in my IDE [21:29:21] (PS9) AndyRussG: Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) [21:30:53] (CR) Awight: [C: 2] Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [21:30:59] Woooooooooooooooooooooooo [21:31:17] Is there a keyboard shortcut in gnome for that mobile-y application menu button that a lot of apps have nowadays? [21:31:35] (PS2) Awight: bannerController call to BannerLoader: Remove unused params [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/206142 (owner: AndyRussG) [21:31:40] Now, comrades, to the beta cluster! [21:31:49] Well, wait 3 minutes [21:32:03] Or more, because Jenkins [21:32:33] (Merged) jenkins-bot: Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [21:45:17] (PS1) Awight: Update to $wgCentralSelectedBannerDispatcher [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/206467 [21:45:48] working finely and nicely on the beta cluster tooooo [21:47:55] Funny, in the browser console on the beta cluster I do see all those warnings you were talking about, awight... I wonder if I need to change a setting to see them locally, or if it's just 'cause I don't have the warningful extensions installed... [21:50:38] hey awight, remember when you told me not to hesitate to holler again? :) [21:50:39] (CR) Awight: [C: -1] "I don't think we can remove the "country" param, cos it's used in testing." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/206142 (owner: AndyRussG) [21:50:45] I could use a sanity check... [21:52:04] (CR) Awight: [C: 2] "The blob storage still causes me a slight twitch, but OK while this is on a feature branch." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [21:52:09] (PS5) Awight: WIP Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [21:52:48] (CR) Awight: "Oops! Hopefully I removed my CR+2 just in time. Not merging cos: WIP." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [21:53:15] awight: yeah I was gonna rebase again too [21:53:45] Ah I see that's wut you did [21:55:33] (CR) Awight: WIP Campaign-associated mixins (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [21:55:54] ccogdill: hi! sure [21:56:04] hi awight! thanks [21:56:09] my query is taking FOREVER [21:56:16] AndyRussG: sorry, I'm hands-off any more rebasing! [21:56:24] so can you look at it to make sure I’m not waiting for data that will never come? [21:56:25] ccogdill: oof. Open a second window [21:56:27] sure [21:56:29] k [21:56:42] in the 2nd window, try adding "explain" before your whole query. [21:56:49] ooh okay [21:56:50] awight: that was fine! I just was confused [21:57:02] Then um... https://phabricator.wikimedia.org/paste/create/ [21:57:04] or something [21:57:42] AndyRussG: I was just thinking about how this commit --amend nonsense makes it easy to accidentally revert changes between patchsets. [21:58:05] I don't even want to verbalize the scenarios... [21:59:17] awight I’m not totally sure what to do with this explain stuff. there are things here that look promising but I don’t know… but maybe I’m shooting myself in the foot for starting with a large table [21:59:24] * AndyRussG imagines changes running through a maze of patchsets looking for a home [21:59:39] ccogdill: can you paste that explain stuff into https://phabricator.wikimedia.org/paste/create/ or a pastebin? [21:59:53] sure [22:00:09] I don't really understand it well enough to explain, but there are certain colors, shapes and smells that I might recognize if I see th eoutput [22:00:17] :) [22:00:19] like "filesort". that is bad. [22:00:28] no filesort [22:00:30] Large numbers of rows are sketchy. [22:00:31] k [22:00:43] I’m trying to do a join with a like clause which i s making me nervous [22:01:00] hahaa me too [22:01:01] awight https://phabricator.wikimedia.org/P558 [22:01:04] It's so arcane [22:01:30] Yeah that's... just a lot of rows to start with, 10 million. [22:01:35] okay [22:01:39] Not unreasonable, though... [22:01:51] so I should have started in my special db and joined to civicrm_email instead, huh? [22:02:03] This is not something I have seen before: "Using where; Using join buffer (flat, BNL join)" [22:02:24] haha me neither… do you think it’s bad? [22:02:33] donno yet [22:03:00] okay. so you think I just wait it out and see if I get results or not? the query doesn’t look insane to you? [22:03:19] well, no reason to kill the query yet [22:03:25] you can keep working in a second window... [22:03:50] oooh [22:04:11] the "like".. %% thing is killing the whole world. [22:04:34] Please don't kill the whole world on a Friday. [22:04:41] well, killing one db cpu [22:04:41] Wednesday. [22:04:49] * awight chuckles [22:05:07] eeek so I should kill it? [22:05:11] ccogdill: yeah, you can try to kill that query, -c is the best [22:05:13] man I knew the like thing would never work out :( [22:05:36] Thursday is good too, but that's what they expect. [22:05:37] well, we do have a secret other field which should match those Order IDs directly [22:05:38] I'll shut up now. [22:05:47] I would *love* that [22:06:02] re the order ID field, not k4 shutting up :D [22:06:08] bahaha [22:06:09] lol [22:06:14] WHY NOT BOTH. [22:06:28] haha just let the record show I didn’t ask for it! [22:06:30] ccogdill: one thing, you get street cred for not using table aliases :) [22:06:35] so much typin! [22:06:39] those confuse me too much [22:06:44] it’s not street cred it’s ignorance [22:06:45] me too... [22:07:00]