[00:12:46] Congratulations! [00:34:42] awight: thx! I'll check the DB results in a bit too, going to a quick post-dinner kid outing [00:43:49] (CR) Krinkle: [C: 2] Fixed a few IDEA doc errors [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234161 (owner: Aaron Schulz) [00:43:52] (PS3) Awight: Skip DO_PAYMENT for already pending charges [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233889 (https://phabricator.wikimedia.org/T110264) [00:44:48] (Merged) jenkins-bot: Fixed a few IDEA doc errors [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234161 (owner: Aaron Schulz) [00:45:20] (PS4) Awight: Recurring charge can settle incomplete transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233889 (https://phabricator.wikimedia.org/T110264) [00:45:58] Fundraising Sprint Rowlf the Dog, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Make GlobalCollect recurring processing more robust, handle stale status 600s - https://phabricator.wikimedia.org/T110264#1578026 (awight) [00:47:11] (CR) Krinkle: Use DB slaves for Campaign reads on GET requests (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz) [00:48:07] (CR) Awight: "Thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234161 (owner: Aaron Schulz) [00:50:56] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding Anna Stillwell as a Steward. and Solicitor - https://phabricator.wikimedia.org/T108118#1578052 (awight) a:awight [00:56:52] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding Anna Stillwell as a Steward. and Solicitor - https://phabricator.wikimedia.org/T108118#1578064 (awight) Steward options: https://civicrm.wikimedia.org/civicrm/admin/optionValue?gid=44&reset=1 Solicitor option... [00:58:30] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding Anna Stillwell as a Steward. and Solicitor - https://phabricator.wikimedia.org/T108118#1578067 (awight) OK, Anna is added to Stewards and Solicitors. @astillwell: Please close this task once you have verified... [01:01:44] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Deploy CentralNotice schema change - https://phabricator.wikimedia.org/T104508#1578079 (awight) [01:12:42] arg! kid musical evening event in the park was already over... The organizers goofed on the program schedule [01:24:43] (PS1) Ejegg: Limit OID reset on recurring changes, log resets [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/234200 (https://phabricator.wikimedia.org/T110367) [01:25:53] (CR) Ejegg: [C: 2] Limit OID reset on recurring changes, log resets [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/234200 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [01:26:17] (Merged) jenkins-bot: Limit OID reset on recurring changes, log resets [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/234200 (https://phabricator.wikimedia.org/T110367) (owner: Ejegg) [01:27:54] (PS1) Ejegg: Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/234201 [01:28:33] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface for deploy [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/234201 (owner: Ejegg) [01:29:30] * awight|dishes cheers [01:29:38] thanks! [01:32:11] !log updated payments from 8ba4b5299f195cf48e6809b18a21e2d53f6eec1b to 6ac552f280fb839069d117386c4ecbe9e52f90a8 [01:32:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:50:32] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Spike: Lots of 21000050 errors for Globalcollect, since July - https://phabricator.wikimedia.org/T107845#1578181 (Ejegg) Caught one! From the Japan form, trying to donate via JCB: '2100... [01:54:15] (PS1) Ejegg: Add space after temp log prefix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234206 [01:58:20] (CR) Awight: [C: 2] "Wow, I had to download that patch to see the difference." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234206 (owner: Ejegg) [01:58:44] (Merged) jenkins-bot: Add space after temp log prefix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234206 (owner: Ejegg) [01:59:08] heh, whitespace! [02:01:40] worldpay must have flipped a switch because i get a different response with the test creds now, and if i pass IsHosted=1 i get a redirect url instead of a token. progress! [02:01:48] nice! [02:02:43] i'll dig into it tomorrow but now i've got to start dinner. g'night! [02:04:13] it's easy, they just have to put the wire here... http://fivefish.net/diy/PM1000/images/rackinside.jpg [02:04:52] switchboard operators are standing by! [02:05:06] ejegg: I can take over monitoring, unless you've really got nothing better to do... [02:05:31] ehh, pretty sure it didn't make anything worse! [02:05:43] just waiting for a real recurring donor to hit the switcher [02:06:17] had one try like a dozen times and we kept getting a null expiry date error on our get status call [02:06:31] doesn't the frame show that error message? [02:06:56] NOthing to see here... http://lh4.ggpht.com/oPG9Kap2KbFn25E19QgcvDzwWPkuorGli8S9KciRkg5wi0v1MmvCAJ5LFir7RmUEYLDbQAvCHjFFZrZb8Zkt=s580 [02:07:21] trapdoor iframe spider [02:07:45] click here to edit [02:13:51] ejegg: I'm gonna deploy a config change to the orphan slayer... cleanup and explicitly adding the stomp port. [02:14:13] crossing your fishing pole? [02:15:01] nah, go right ahead [02:15:04] cherry-pick? [02:15:13] if not, plz see deploy note on failpage thang [02:15:33] it's a *LocalSettings* deal [02:15:48] oh yah, you said config! [02:15:54] go right ahead [02:16:55] !log push config change to the payments orphan slayer: explitly give stomp port to work around strict notice, clean up unused globals. T109911 [02:17:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [02:19:07] I might as well make these config changes to the frontend too, while it's on my mind... [02:19:56] We'll have version control on that pretty soon, I hope. [02:20:19] yeah, i saw you and Jeff_Green chatting about that. Exciting! [02:23:35] Fundraising-Backlog: Fundraising vagrant role provisioning fails - https://phabricator.wikimedia.org/T108844#1578297 (awight) @pcoombe: Sorry about the delay! Can you try this again? Grab this patch for vagrant, unless it's been merged already: `git review -d 234033` [02:23:59] ejegg: orphan slayer log... Aug 27 02:20:04 payments1004 orphans: globalcollect_gateway_tr 27600060:6583658933 processResponse: 20001000 REQUEST 7508224 NULL VALUE NOT ALLOWED FOR EXPIRYDATE [02:24:28] yeah, I was seeing a bunch of those for a recurring person too [02:24:52] oh wait, that's the same CTID [02:25:24] Dunno why GC bounces them back to our return url when they didn't fill out the form in the iframe [02:25:56] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, Unplanned-Sprint-Work: Fundraising vagrant role provisioning fails - https://phabricator.wikimedia.org/T108844#1578318 (awight) [02:25:58] but I suppose we could provide better feedback if they're giving us that info [02:26:24] that poor soul bounced back and forth at least 8 times with a null expiry date [02:30:42] That's... almost worth writing a test so it doesn't regress [02:31:10] is that a regression on GC's part? [02:31:31] I mean, we don't touch the expiry date [02:33:47] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, Recurring-Donations, Patch-For-Review: GC error causing donors to create multiple recurring donations - https://phabricator.wikimedia.org/T110367#1578362 (Ejegg) Code fix seems good, but I see a whole lot of these in the logs. I will get a lis... [02:33:49] I can't reproduce that [02:34:12] And good point, it's not our code [02:34:33] Hmm, that donor was from CA - their iframe varies by country, right? [02:34:51] donno :( [02:35:47] Interesting that there are suddenly a ton of 21* errors [02:36:04] yeah, definitely odd [02:36:32] I imagine they're slowly taking punchcards out of an ENIAC [02:36:37] well, they're still doing client-side validation for CA [02:36:57] Field Expiration date: has a minimum length of 4 characters. [02:36:58] Could be js fail on those dropdowns. [02:37:05] ...on a pair of dropdowns [02:37:27] omg it totally is. [02:37:32] inspect the source [02:37:43] hidden EXPIRYDATE that must be updated by js [02:37:54] GetMissingDataAll.js, huh? [02:37:55] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Spike: Lots of 21000050 errors for Globalcollect, since July - https://phabricator.wikimedia.org/T107845#1578403 (atgo) We aren't...? I thought we were. [02:43:00] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Spike: Lots of 21000050 errors for Globalcollect, since July - https://phabricator.wikimedia.org/T107845#1578452 (Ejegg) Nah, for GC that's all in their iframe. But we're even seeing so... [02:44:28] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Spike: Lots of 21000050 errors for Globalcollect, since July - https://phabricator.wikimedia.org/T107845#1578461 (awight) Chiming in, we get CVV validation results back from GC, so that... [02:44:39] W00t! Got a recurring donor successfully through the result switcher. I'm signing off for the night, but that ticket still has cleanup work... [02:44:50] later awight atgo [02:46:20] see ya! [02:53:54] ciao! thanks ejegg|away [03:17:17] !log deploy config cleanup for paymentswiki [03:17:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [04:39:30] (CR) AndyRussG: "Thanks much!! I'd be interested in doing a careful review of this before it's merged, if possible, since a lot of funny meandering code us" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234164 (https://phabricator.wikimedia.org/T92357) (owner: Aaron Schulz) [09:07:40] (CR) Gilles: [C: 2] Remove dead code for targetting users based on UserDailyContribs data [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/225669 (owner: Ori.livneh) [09:08:51] (Merged) jenkins-bot: Remove dead code for targetting users based on UserDailyContribs data [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/225669 (owner: Ori.livneh) [09:34:59] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team: [WMDE-Fundraising] Explanation of new Central Notice Features - https://phabricator.wikimedia.org/T110321#1579204 (WMDE-Fisch) a:WMDE-Fisch [09:37:37] TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team: [WMDE-Fundraising] BE: member-view in analyzation-section - https://phabricator.wikimedia.org/T104435#1579206 (WMDE-leszek) a:WMDE-Fisch>WMDE-leszek [12:52:01] (CR) AndyRussG: "Thanks, all!!! :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/225669 (owner: Ori.livneh) [13:57:39] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, Recurring-Donations, Patch-For-Review: GC error causing donors to create multiple recurring donations - https://phabricator.wikimedia.org/T110367#1579976 (MBeat33) We haven't seen any new instances of this error. @Ejegg, if DS can help process... [16:36:00] morning awight [16:36:33] modest progress on the WP front but i have about 2 million DI questions [16:43:18] Fundraising Sprint The Pogues, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkTypeMaintenance: Editing broken for contacts with employer - https://phabricator.wikimedia.org/T107114#1580525 (DStrine) [16:43:48] cwdent: fire away! [16:44:38] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Patch-For-Review, WorkTypeMaintenance: AstroPay gateway not incrementing order ID in some circumstances - https://phabricator.wikimedia.org/T106039#1580527 (DStrine) [16:45:10] Fundraising Sprint The Pogues, Fundraising-Backlog, Patch-For-Review, WorkTypeMaintenance: Bug: JCB logo not always appearing in second position in Japan - https://phabricator.wikimedia.org/T106705#1580528 (DStrine) [16:45:19] awight: got time to get on a call at some point? i'll wear out my fingers typing [16:45:43] Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, Patch-For-Review, WorkTypeMaintenance: AstroPay adapter is spamming cc-limbo queue - https://phabricator.wikimedia.org/T107787#1580540 (DStrine) [16:46:12] cwdent: now works, or any time. lmk [16:47:00] Fundraising Sprint The Pogues, Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Log timing for each cURL attempt, not cumulative time - https://phabricator.wikimedia.org/T107539#1580543 (DStrine) [16:47:06] awight: now is great! i'll hit you up in a minute [16:50:13] Fundraising Sprint The Pogues, Fundraising-Backlog, WorkTypeMaintenance: Kick Silverpop export job - https://phabricator.wikimedia.org/T107184#1580569 (DStrine) [16:52:21] awight: i just sent an invite [16:52:30] i managed to just open a hangout from the calendar [16:52:45] i hate doing that call feature where it rings [16:53:01] too stressful [16:53:11] well uh add me or send the URL [16:53:36] no mail yet [16:53:42] this is much better than just calling :p [16:54:54] Fundraising Sprint The Pogues, Fundraising-Backlog, fundraising-tech-ops, WorkTypeMaintenance: Footer images on payments missing - https://phabricator.wikimedia.org/T106728#1580603 (DStrine) [16:54:55] i did call! [16:55:10] got the machine [16:58:09] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint The Pogues, Fundraising-Backlog, and 2 others: Recent Engage Import - Contribution Type = Cash when it should be Engage - https://phabricator.wikimedia.org/T100853#1580622 (DStrine) [17:00:10] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, and 7 others: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1580635 (DStrine) [17:26:30] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding Anna Stillwell as a Steward. and Solicitor - https://phabricator.wikimedia.org/T108118#1580767 (CaitVirtue) @awight: I used to know how to do this myself, but I forgot and we had to create this task. Do you h... [17:26:48] cwdent: https://payments.wikimedia.org/index.php?title=Special:GatewayFormChooser&testGetAll=true [17:27:50] DonationInterfaceFormSettings.php [17:34:49] Fundraising Sprint Queen, Fundraising Sprint The Pogues, Fundraising-Backlog, Astropay Integration, and 3 others: AstroPay donors all sent to fail page - https://phabricator.wikimedia.org/T108059#1580803 (DStrine) [17:36:30] Fundraising Sprint Queen, Fundraising Tech Backlog, Fundraising-Backlog, Astropay Integration, WorkTypeMaintenance: Diagnose AstroPay ffname errors - https://phabricator.wikimedia.org/T106050#1580809 (DStrine) [17:38:04] Fundraising Sprint Queen, MediaWiki-extensions-DonationInterface, Patch-For-Review, WorkTypeMaintenance: Something broken in payments-antifraud and payments-initial message generation - https://phabricator.wikimedia.org/T109022#1580834 (DStrine) [17:44:21] ejegg: Top o' my wish list, whenever you need a break: https://gerrit.wikimedia.org/r/#/c/233889/ [17:46:55] (PS5) Awight: Recurring charge can settle incomplete transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233889 (https://phabricator.wikimedia.org/T110264) [17:47:00] awight: ejegg: XenoRyet cwdent: is it OK if I add port 80 to the default security group for the fundraising group on labs? [17:47:10] AndyRussG: totally! [17:47:17] cool rice! [17:47:24] Sounds fun, whatcha doing? [17:53:29] looking now awight! [17:53:49] Also trying to find duplicate recurring contributions from the past week or so [17:54:45] so your patch lets the orphan slayer clear up stuck recurring contributions? [17:56:19] The first use will be to clean up some recurring contributions, actually. But it will be helpful for the slayer too [17:56:33] hehe, unless you beat me to it [17:56:58] I don't think the orphan slayer calls Recurring_Charge, cos it's doing initial payments [17:57:06] nah, i'm just looking for IDs so far, hadn't even started digging on the fix [18:01:04] https://etherpad.wikimedia.org/p/DI_maintenance_scripts [18:03:07] Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1580921 (MBeat33) @awight thank you, I tested the % wildcard on some Amazon donor records and though slow it seems to find them often enough. If altering th... [18:13:33] ejegg: dude. Read from recent and historical logs, and put recovered messages on a queue. [18:13:41] (PS1) AndyRussG: Banner history logger: again, update EventLogging schema version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234329 [18:13:55] I've been fretting over this for days, how to not rewrite the log munging code. [18:13:56] ^ just another schema version update (fixed a detail in the description) [18:14:43] awight: yeah, that seems like incredibly useful functionality [18:15:42] Scan logs for a regex, and dump order IDs with a matching line. [18:15:49] you have suggestions to make that better? [18:16:07] woot! [18:16:25] awight: you mean still using the DI code? [18:17:06] I have some half-baked grep/awk/sed monstrosities that could metastasize to fit the debug use cases [18:17:07] Just soliciting help, you already nailed it with optionally specify start and end dates! [18:17:12] yes. perfect [18:17:19] That's way better than PHP text processing. [18:17:59] heh. I need an excuse to practice awk more than quarterly so I don't have to re-learn it each time [18:23:45] right? [18:27:01] awight: ejegg: cwdent: quick +2 NEone? https://gerrit.wikimedia.org/r/234329 Sorry 4 the bother! [18:27:26] sure [18:27:30] thx! [18:27:32] glad to - just out of curiousity, where do the numbers come from? [18:27:40] (CR) Cdentinger: [C: 2] Banner history logger: again, update EventLogging schema version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234329 (owner: AndyRussG) [18:27:42] ejegg: https://meta.wikimedia.org/wiki/Schema:CentralNoticeBannerHistory [18:28:00] ah, revision of a wiki page! Awesome [18:28:01] It's just the number of the verison of the schema on Meta that ur using [18:29:12] cwdent: ejegg: yeah... In brief, yesterday there was an issue on the beta cluster about EventLogging data getting into MySQL. I think they're fixing it now, but I wanted to get the schema update out to beta before anything went to MySQL, 'cause that creates a separate table for every version of every schema [18:29:28] It was just an update to the in-schema doc, but I felt we might as well do it! [18:29:36] word, sounds good [18:29:47] :D [18:29:59] yeah that mysql integration sounds gnarly [18:30:52] cwdent: Scarily enough, there's a templated UNION around the whole thing [18:31:13] you can use that to query all the versions of tables [18:31:40] ejegg: Is it useful if I work out the log parsing regexes, and you can plug into awk? Or u already have working drafts of those? [18:31:58] awight: go right ahead! [18:32:20] * awight rubs hands with relish [18:32:28] I love a good regex puzzle [18:32:38] awight: heh I'm actually pretty curious to see how it'll deal with our nested schema! [18:32:46] I'm just re-reading GC docs to make sure I understand exactly how recurring is supposed to work [18:32:57] Hopefully not fall over and die [18:33:05] AndyRussG: yipes! Could you enter that with the GUI editor? [18:33:21] awight: yep it's right here: https://meta.wikimedia.org/wiki/Schema:CentralNoticeBannerHistory [18:33:24] awight: I forget if I learned about it here, but http://regexcrossword.com/ [18:33:32] Actually documented in the EL code in schemaschema.json [18:33:54] ejegg: it's just, DO_PAYMENT -> SET_PAYMENT for successive charges. But their appendix is pretty good! [18:33:58] I mean, it was a GUI editor for entering JSON code in a wiki page [18:34:05] thanks [18:34:07] But it GUI displays nicely [18:34:10] AndyRussG: holy cow, that worked [18:34:22] I tell ya, EL is a monster [18:34:40] I wonder how many levels you can make [18:34:44] Such a sleek monster [18:35:08] AndyRussG: Does that schema describe the repeated elements, too?? [18:36:03] awight: yeppers, the l is an array the elements of which are objects, all declared as such in the schema [18:36:17] That's really impressive that you can define the schema for array elements [18:36:26] * awight knocks on wood [18:36:30] Heheh indeed [18:36:42] * AndyRussG makes a note to tell Ellery to knock wood [18:37:25] Man Jenkins is a bit slow this morning [18:37:27] "morning" [18:37:29] (Merged) jenkins-bot: Banner history logger: again, update EventLogging schema version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234329 (owner: AndyRussG) [18:37:33] Theeeere we go [18:43:25] If I want to have some CN commits just to use on the performance-testing instance, what'd be easiest? A **Don't merge** change on Gerrit, or a Github fork? [18:44:07] awight: ejegg: cwdent: XenoRyet: ^ ? [18:45:12] Same deal, or gerrit branch. Only difference I see is how you deploy, which doesn't matter if you own the VPS. [18:46:40] K cool, thx! [18:48:29] (Abandoned) AndyRussG: ***Pls don't merge*** Performance marks for benchmarking on labs [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/233040 (owner: AndyRussG) [18:55:25] ejegg: any way i could talk you into holding my hand through making a new form use the mustache stuff? [18:55:40] cwdent: sure! [18:55:57] awesome, whenever you have time, don't wanna interrupt [18:57:19] If you look at the getFormClass method in astropay.adapter.php, that should get you started [18:57:57] yeah, so i copied that into the worldpay adapter but it seemed to override the default behavior [18:58:01] cwdent: Thinking of switching all uses of the WP gateway, or just some cases? [18:58:19] ejegg: i think just the new one... [18:58:34] the iframe case [18:58:36] (PS1) AndyRussG: ***Pls don't merge*** Performance marks for benchmarking on labs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234341 [18:58:40] Another thing you two might want to sync up on is how GatewayFormChooser plays with mustache [18:59:29] hmm, so you'll have to be able to distinguish the mustache case by the time the gateway page tries to show the form and calls getFormClass [18:59:47] awight: you mean with the form settings? [18:59:59] (CR) jenkins-bot: [V: -1] ***Pls don't merge*** Performance marks for benchmarking on labs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234341 (owner: AndyRussG) [19:00:28] so for that part i made an entry called worldpay-if and copied stuff from AP [19:00:28] yah, I remember you were trying to explain something to me about how we no longer need to switch behavior using gateway chooser config [19:00:46] and added ffname=worldpay-if to the url [19:01:56] i also added this to localsettings: [19:01:58] $wgDonationInterfaceFormDirs = array( [19:02:00] "/srv/DonationInterface/gateway_forms/mustache/index.html.mustache", [19:02:02] ); [19:02:04] ^seems wrong... [19:02:29] yeah, I don't think you'll need that [19:03:19] But over in getFormClass you'll want to check the ffname in that if statement [19:04:51] ah cool, so if it's not present i can call the parent function for the rapidhtml behavior? [19:05:32] awight: oh right, I was thinking the 'FormSettings' would be more like 'ChooserSettings' with just the countries/currencies/methods/recurring for each gateway, no reference to specific form names [19:06:06] cwdent: yeah, I think at that point you can getData_Unstaged_Escaped('ffname') to test it [19:06:23] ejegg: how would we do a/b stuff? [19:06:35] like, if we want a form mutant to appear just in one language and country. [19:06:53] awight: chooser just passes along ffname from the banner, and the form rendering class does something with it [19:08:24] ehh, or maybe we do want to be able to control that mutation from our settings [19:10:37] Both sounds like a nice compromise [19:13:02] hmm, so maybe FormSettings just collapses down to one per gateway, plus one for each mutation, with the file letting you override the base template [19:18:55] i am getting such weird behavior [19:19:09] cwdent: from the form stuff? [19:19:13] how so? [19:19:13] sometimes the form loads and sometimes i get "Requested an unavailable or non-existent form. No valid html_base_dir for 'worldpay' - '/srv/DonationInterface/worldpay_gateway/forms/html/worldpay.html' was not whitelisted. .." [19:19:23] i also sometimes get that for the mustache one [19:19:29] that's why i stuck em in localsettings [19:19:33] but it seems really inconsistent [19:20:02] it feels cachey [19:20:07] hmm, that html_base_dir thing is only for RapidHTML [19:20:26] ah yeah, so that's in RapidHTML.php [19:20:41] did you remove the setting where you clobber wgDonationInterfaceFormDirs? [19:20:59] yep [19:21:45] heh, if you're getting inconsistencies, I'd say to kick your php module again. I remember that helped before! [19:22:17] hehe yeah i beat that thing like it owes me money [19:33:06] yeah there's totally some caching happening [19:33:29] i submitted the same url twice and got two different calls [19:33:49] is there anything baked into this setup taht would be doing that? [19:43:32] cwdent: there's some session stuff that hangs out, but shouldn't be any caching [19:44:28] hrmph. must be the browser [19:45:06] ah crap, I owe an apology to like 90 recurring donors [19:45:29] and we need to cancel something like 100 duplicate donations [19:46:58] :S [19:47:24] ejegg: i have all my changes commented out but am still getting: No valid html_base_dir for 'worldpay' - '/srv/DonationInterface/worldpay_gateway/forms/html/worldpay.html' was not whitelisted. ..cc [19:48:08] MBeat: There were a lot donors affected by my bug than the 11 who complained. I'm almost finished getting the list of duplicates, but it looks like there were 200 donations from 90 donors. Some tried recurring a second (or third) time, some gave a duplicate by another method. [19:48:21] sheesh [19:48:43] were they all recurring, ejegg? [19:48:52] Yeah, I really regret this one. Those are the people that want to support us most! [19:49:34] MBeat: yes, I was just looking for people who got the 'forbidden' error after submitting the CC form [19:50:03] Going to relocate for tech standup, then I'll get you a spreadsheet right after [19:50:44] thanks, and no worries. we’ll cancel the dupes & refund the extra donations, and send an email update to the batch. the donors we’ve dealt with so far have been really great (some even say ‘keep the extra donation’) [19:51:14] man, they are very gracious! [19:51:25] ok, brb [19:53:12] ejegg awight cwdent XenoRyet I'm running late, pls don't wait up! Sorry! [19:54:01] AndyRussG|mob: We'll try not to say anything interesting without you ;-) [19:55:08] XenoRyet thanks! Heh may not make it at all, as things are going... [20:10:00] XenoRyet: something like, rsync -av -e 'ssh -l vagrant -p 2222' /host/vagrant/srv/crm/ 127.0.0.1:/srv/crm/ [20:10:03] GROSS [20:24:05] https://meta.wikimedia.org/wiki/Research:Revision_scoring_as_a_service/Clustering_in_reverted_edits [20:29:41] (PS1) Awight: WIP New maintenance scripts for manipulating GC charges [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234417 (https://phabricator.wikimedia.org/T109668) [20:29:44] ejegg: ^ that one [20:30:17] cool, I'll look at that too [20:34:13] just to prove it: http://screencast.com/t/TFF8J7Lql [20:34:56] That's sick [20:35:10] Your parents must be proud :p [20:35:14] I took a class at the crucible in oakland [20:35:44] fundraising-tech-ops, operations: package udp-filter for Trusty, for use on fundraising banner_logger - https://phabricator.wikimedia.org/T110592#1581705 (Jgreen) NEW a:Jgreen [20:36:20] most of my family has not idea what I'm doing most of the time. They keep asking me when I'll get a real job. Maybe they think this internet this isn't going to catch on [20:37:44] :D That sounds a little like David Sedaris [20:40:41] fundraising-tech-ops, operations: package udp-filter for Trusty, for use on fundraising banner_logger - https://phabricator.wikimedia.org/T110592#1581723 (Jgreen) [20:41:54] Except, he was a Macy's Santa and you were eating fire. [20:45:44] awesome dstrine [20:46:22] * dstrine looks for santa suit.. realizes it's already packed for burning man. [20:49:04] there has been a big spider building a big nest on my porch for a few weeks [20:49:24] recently a little spider came along, killed the big one, and moved in [20:49:29] and just left the body on the lawn [20:54:27] MBeat: awight and I are working out how to batch refund the transactions. Could you help us with the communication? [20:54:38] sure thing [20:54:52] Do you have some kind of mail merge for this? [20:55:16] hmm. we can create tickets for the donors in Zendesk [20:55:39] from which to send a template [20:56:07] Oh man, I really hope you don't have to do too much by hand. [20:57:05] we live for these kinds of projects, seriously it’s good to bring Kristie and Andrey in on stuff like this, it varies their workload [20:57:24] Do these fields sound good: language, email, fname, lname, refunded txn currency, amount, and date ? [20:57:56] I can add on the non-refunded txn data too. [20:58:14] yeah, that sounds great. will the export be able to indicate cases where there were multiple cancels/refunds from same donor? [20:58:40] Sure, I'm guessing one row per email address will be most helpful. [20:58:46] perfect [20:59:56] Is tacking on extra columns for multiple refunds better than some janky comma concatenation? [21:03:38] OK, MBeat, just double checking some rows and I should have that for you within the hour. Thanks so much! [21:04:13] np! [21:04:39] will the extra recurrings also have been canceled, or should we do that, ejegg? [21:19:42] MBeat: we're trying to automate that, so maybe hold off actually sending the emails till we figure out whether we can do that? [21:20:32] sure thing. if it’s non-automatable, that’s ok too [21:33:17] (PS3) Ejegg: Clean up orphan classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233877 (owner: Awight) [21:33:26] (CR) Ejegg: [C: 2] Clean up orphan classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233877 (owner: Awight) [21:33:59] (Merged) jenkins-bot: Clean up orphan classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233877 (owner: Awight) [22:43:42] (CR) Ejegg: [C: -1] "Oops, I think I screwed this code up back in Ibc7461df00e3388b0596e0fa60b94066f1e8d280. Fix looks good! Just one stray error_log to remo" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233889 (https://phabricator.wikimedia.org/T110264) (owner: Awight) [22:49:05] (PS2) Awight: WIP New maintenance scripts for manipulating GC charges [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234417 (https://phabricator.wikimedia.org/T109668) [22:49:09] (CR) jenkins-bot: [V: -1] WIP New maintenance scripts for manipulating GC charges [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234417 (https://phabricator.wikimedia.org/T109668) (owner: Awight) [22:49:57] (PS6) Awight: Recurring charge can settle incomplete transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233889 (https://phabricator.wikimedia.org/T110264) [22:53:02] (CR) Awight: "I won't argue that you screwed it up :p but pretty sure it's never been able to do the resume thing until now." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233889 (https://phabricator.wikimedia.org/T110264) (owner: Awight) [22:58:35] (PS7) Ejegg: Recurring charge can settle incomplete transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233889 (https://phabricator.wikimedia.org/T110264) (owner: Awight) [22:58:57] (CR) Ejegg: [C: 2] Recurring charge can settle incomplete transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233889 (https://phabricator.wikimedia.org/T110264) (owner: Awight) [22:59:18] (Merged) jenkins-bot: Recurring charge can settle incomplete transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/233889 (https://phabricator.wikimedia.org/T110264) (owner: Awight) [23:03:36] ejegg, awight: i know you guys are busy with those recurring charges and i don't want to bother, but i'm pretty stuck with some mustache vs. rapidhtml stuff. lmk if i should hold till tomorrow? [23:04:06] cwdent: I'm at a good place to context switch. want to do a screeen share? [23:04:34] that'd be great! [23:07:42] ejegg: ring me whenever you're ready? [23:25:41] awight: hi! say I think we're close enough to deploying BH & friends to do the schema deploy on prod... what do you think? [23:31:21] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, Unplanned-Sprint-Work: Fundraising vagrant role provisioning fails - https://phabricator.wikimedia.org/T108844#1582484 (Pcoombe) @awight - still getting the same error. [23:41:12] (PS1) Awight: Update DonationInterface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/234441 [23:47:04] http://www.webpagetest.org/result/150827_SG_1BKF/1/details/