[00:05:29] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Another spike in unsettled GC 600s - https://phabricator.wikimedia.org/T114192#1687811 (awight) We've only run INSERT_ORDERWITHPAYMENT and then stopped processing these orders due to h... [00:05:42] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Donate button on Amazon form should only show up when a card is selected - https://phabricator.wikimedia.org/T114198#1687813 (Ejegg) NEW a:Ejegg [00:05:44] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Another spike in unsettled GC 600s - https://phabricator.wikimedia.org/T114192#1687821 (awight) a:awight [00:30:55] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Another spike in unsettled GC 600s - https://phabricator.wikimedia.org/T114192#1687892 (awight) Open>Resolved turns out this is normal, it was just some attempted fraud. @Mbeat3... [00:31:43] Fundraising-Backlog, Documentation: Document GC credit card processing - https://phabricator.wikimedia.org/T114204#1687906 (awight) NEW [00:33:44] Fundraising-Backlog: Ask GlobalCollect to let us cancel status 600 transactions - https://phabricator.wikimedia.org/T114205#1687915 (awight) NEW [00:35:39] gotta run for now, bye! [00:48:53] (PS1) Eileen: CRM-17306 fix location update action [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242423 [00:49:43] (CR) jenkins-bot: [V: -1] CRM-17306 fix location update action [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242423 (owner: Eileen) [00:53:29] (PS1) Eileen: Civi46 update CiviCRM submodule version [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242426 [00:53:31] (PS1) Eileen: Civi46 update refund test for changed parameter (no 2) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242427 [00:53:33] (PS1) Eileen: Civi46 adjust function to get tests passing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242428 [00:53:35] (CR) jenkins-bot: [V: -1] Civi46 update CiviCRM submodule version [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242426 (owner: Eileen) [00:53:37] (CR) jenkins-bot: [V: -1] Civi46 update refund test for changed parameter (no 2) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242427 (owner: Eileen) [00:53:39] (CR) jenkins-bot: [V: -1] Civi46 adjust function to get tests passing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242428 (owner: Eileen) [00:57:38] awight: so we have a loop kind of - the civicrm repo can’t pass it’s tests with the crm repo tests - which get further - but still fail because of the civicrm repo not being merged [00:58:10] & I tried to update the submodule pointer to it in the hope - but since that isn’t merged into civicrm repo it failed to merge to crm [01:01:09] (CR) Eileen: "Note that the tests can't pass on this without the changes under review for crm repo & the crm repo can't pass without this (actually we s" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242423 (owner: Eileen) [01:05:56] (CR) Eileen: "The fix for the current fails on this one are the fixes queued on the civicrm repo" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/242410 (owner: Eileen) [01:13:31] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Donate button on Amazon form should only show up when a card is selected - https://phabricator.wikimedia.org/T114198#1688106 (Ejegg) [01:13:47] (PS1) Ejegg: WIP Ensure card selected before clicking 'Donate' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242432 (https://phabricator.wikimedia.org/T114198) [01:41:21] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1688147 (Jgreen) >>! In T97676#1687605, @awight wrote: > Furthermore, when we do ma... [03:30:05] (CR) AndyRussG: "OK, that makes a lot of sense! :) Yeah, let's do it (but see inline)!" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/241938 (https://phabricator.wikimedia.org/T113813) (owner: Awight) [09:23:01] Wikimedia-Fundraising: wikimedia/fundraising/tools should pass python lint checks (flake8) - https://phabricator.wikimedia.org/T114218#1688544 (hashar) NEW [09:23:53] Wikimedia-Fundraising: wikimedia/fundraising/tools should pass python lint checks (flake8) - https://phabricator.wikimedia.org/T114218#1688556 (hashar) [09:24:08] Wikimedia-Fundraising: wikimedia/fundraising/tools should pass python lint checks (flake8) - https://phabricator.wikimedia.org/T114218#1688544 (hashar) [09:32:25] (PS1) Hashar: tox integration to run the flake8 linter [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/242498 (https://phabricator.wikimedia.org/T114218) [09:33:19] (CR) Hashar: "check experimental" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/242498 (https://phabricator.wikimedia.org/T114218) (owner: Hashar) [09:34:35] (CR) Hashar: "With https://gerrit.wikimedia.org/r/#/c/242497/2/zuul/layout.yaml,unified , commenting 'check experimental' in Gerrit triggers a run of to" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/242498 (https://phabricator.wikimedia.org/T114218) (owner: Hashar) [09:36:33] (PS2) Hashar: tox integration to run the flake8 linter [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/242498 (https://phabricator.wikimedia.org/T114218) [09:36:45] (CR) Hashar: "Added another usage example:" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/242498 (https://phabricator.wikimedia.org/T114218) (owner: Hashar) [09:45:57] Wikimedia-Fundraising, Continuous-Integration-Config, Patch-For-Review: wikimedia/fundraising/tools should pass python lint checks (flake8) - https://phabricator.wikimedia.org/T114218#1688635 (hashar) From a preliminary run with `tox -- --statistics`: ``` 2 E111 indentation is not a multiple of... [11:45:54] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Enhance GitHub Issue template - https://phabricator.wikimedia.org/T114228#1688855 (Tobi_WMDE_SW) NEW [11:46:04] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Enhance GitHub Issue template - https://phabricator.wikimedia.org/T114228#1688863 (Tobi_WMDE_SW) [11:53:28] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Add form validation to the sensitive banner - https://phabricator.wikimedia.org/T112057#1688882 (Tobi_WMDE_SW) p:Triage>High [11:56:01] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Create HTML contents of the banner with regard on having magic values filled by CN - https://phabricator.wikimedia.org/T112055#1688890 (Tobi_WMDE_SW) p:Triage>High [11:58:26] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Add show and hide mechanisms to the banner - https://phabricator.wikimedia.org/T112056#1688904 (Tobi_WMDE_SW) p:Triage>Normal [11:59:05] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Create a test banner/campaign on CentralNotice - https://phabricator.wikimedia.org/T112054#1688906 (Tobi_WMDE_SW) p:Triage>Normal [12:03:07] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Request CentralNotice adminship rights - https://phabricator.wikimedia.org/T112059#1688911 (Tobi_WMDE_SW) [12:06:18] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Plan for automated code updates and configuration changes for deployment - https://phabricator.wikimedia.org/T113466#1688913 (Tobi_WMDE_SW) [12:06:57] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Implement GET data encryption & decryption for data transmission between the banner and the fundraising app - https://phabricator.wikimedia.org/T112066#1688919 (Tobi_WMDE_SW) [12:07:04] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Create entry point class/application for server requests coming from the sensitive banner - https://phabricator.wikimedia.org/T112061#1688920 (Tobi_WMDE... [13:51:48] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Enhance GitHub Issue template - https://phabricator.wikimedia.org/T114228#1689157 (kai.nissen) a:kai.nissen [14:23:43] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Create PGP key pair for encryption - https://phabricator.wikimedia.org/T112067#1689280 (Tobi_WMDE_SW) Open>Resolved [14:23:57] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Deploy current master - https://phabricator.wikimedia.org/T113464#1689286 (Tobi_WMDE_SW) Open>Resolved a:Tobi_WMDE_SW [14:24:17] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Switch target URL of MCP iframe - https://phabricator.wikimedia.org/T113368#1689288 (Tobi_WMDE_SW) Open>Resolved [14:24:33] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement validator class for donations - https://phabricator.wikimedia.org/T112076#1689290 (Tobi_WMDE_SW) Open>Resolved [14:24:43] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement basic tracking of the actual banner usage - https://phabricator.wikimedia.org/T112068#1689297 (Tobi_WMDE_SW) Open>Resolved [14:24:59] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Fix failing export script - https://phabricator.wikimedia.org/T114090#1689299 (Tobi_WMDE_SW) Open>Resolved [14:25:20] TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Implement general communication mechanism for the sensitive banner - https://phabricator.wikimedia.org/T112058#1689306 (Tobi_WMDE_SW) Open>Resolved [14:25:32] TCB-Team-Fundraising-Sprint-2015-09-10, TCB-Team-Fundraising-Sprint-2015-09-16, TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Add validation api to the fundraising app - https://phabricator.wikimedia.org/T112063#1689308 (Tobi_WMDE_SW) Open>Resolved [14:25:44] TCB-Team-Fundraising-Sprint-2015-09-23, TCB-Team: [WMDE-Fundraising] Automate database updates for deployments - https://phabricator.wikimedia.org/T113465#1689310 (Tobi_WMDE_SW) Open>Resolved [14:25:57] TCB-Team-Fundraising-Sprint-2015-08-12, TCB-Team-Fundraising-Sprint-2015-08-26, TCB-Team-Fundraising-Sprint-2015-09-02, TCB-Team-Fundraising-Sprint-2015-09-10, and 3 others: [WMDE-Fundraising] Move Piwik to its own VM - https://phabricator.wikimedia.org/T105289#1689311 (Tobi_WMDE_SW) Open>Re... [14:53:06] Wikimedia-Fundraising, Continuous-Integration-Infrastructure, WorkType-Maintenance: Switch wikimedia/fundraising/slander to use tox as an entry point - https://phabricator.wikimedia.org/T114250#1689433 (hashar) NEW [14:53:46] (PS1) Hashar: Introduce tox entry point and run flake8 [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/242572 (https://phabricator.wikimedia.org/T114250) [14:56:12] (CR) Hashar: "check experimental" [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/242572 (https://phabricator.wikimedia.org/T114250) (owner: Hashar) [14:57:20] (CR) Hashar: "So instead of triggering a pep8 and a pyflakes job, we just trigger tox-jessie. That job just runs 'tox', so you can eventually define mo" [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/242572 (https://phabricator.wikimedia.org/T114250) (owner: Hashar) [15:37:01] (PS1) Ejegg: Store CSV column indexes by name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242587 [15:40:53] (PS1) Ejegg: Allow skipping rows before CSV headers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242588 [15:45:27] (PS1) Ejegg: Add shortcut to get value by name from current row [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242590 [15:49:43] (CR) Glaisher: "Heh, looks like another patch which does this was merged two days ago. :P I'll upload a new patch to improve it." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234736 (owner: Glaisher) [15:53:57] TCB-Team-Fundraising-Sprint-2015-09-30, TCB-Team: [WMDE-Fundraising] Add form validation to the sensitive banner - https://phabricator.wikimedia.org/T112057#1689715 (WMDE-leszek) a:WMDE-leszek [15:58:53] (PS2) Glaisher: Improve output subtitle on Special:CentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234736 [16:00:53] (PS3) Glaisher: Improve output subtitle on Special:CentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234736 [16:02:18] (PS2) Glaisher: Special:CentralNotice: always log the summary change if it was in the request [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234834 (https://phabricator.wikimedia.org/T110315) [16:03:21] (CR) Glaisher: "Bump. This is a simple fix." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234834 (https://phabricator.wikimedia.org/T110315) (owner: Glaisher) [16:04:59] ejegg: good morning... I got a couple questions for you. I see this is still blocking the 1 hour test: https://phabricator.wikimedia.org/T86720 [16:05:51] should it move to the campaign ready epic? [16:07:33] dstrine: What did we decide on the whole name parsing thing? [16:07:55] I think we weren't even sure we wanted to try that [16:08:27] I thought Anne wanted a solution for amazon but to leave worldpay as is [16:08:29] But yeah, I guess we shouldn't have it blocking something that already happened! [16:08:34] Oh, ok [16:09:01] does your last comment suggest 2 different ways of solving this? [16:09:37] There are a couple of libraries we could use [16:10:06] ok well we can just keep it in the next sprint and wait for Anne to com back [16:10:25] but if we went so far as to figure out professional suffixes and prefixes we would want to upgrade the rest of the message pipeline to support those [16:10:33] Since Civi does have places to store them [16:11:17] is we get to campaign ready with worldpay and Amazon, will this make MBeat 's job really hard? [16:11:34] I mean if we get to campaign ready without solving this [16:12:10] it slows us down a bit, but awight suggested searching Civi w/wildcard, which will help [16:12:12] yeah, it might. [16:13:10] possible to do a partial solution? seems like it’s the middle initials that really make for tough searching [16:13:45] ok I have a couple more questions. the-wub is asking if we can put amazon into more 1 hour tests. However we are still not done with these "campaign ready" tasks: https://phabricator.wikimedia.org/T109654 https://phabricator.wikimedia.org/T111425 [16:14:01] it seems so localized that there's never be a comprehensive solution to the name problem [16:14:28] I don't want to rush anything that might make things harder for fr-tech or impact quality of work for others [16:16:13] if we are not ready, I'm fine relaying this to stakeholders. I'm not familiar with these batches of 1 hour tests [16:16:18] *there'll [16:17:01] dstrine: I'm fine adding it to tests without the audit files. Once those are ready we can run them on all the past transactions to catch up. [16:18:19] which task number maps to audit files? [16:18:39] I'm still learning a few of our terms sorry [16:19:04] dstrine: both of those report tasks you just mentioned [16:19:12] kk [16:19:32] things get described in many different ways [16:19:37] thanks! [16:20:38] There is a standup at 10am with stakeholders. I will relay all this. [16:53:57] AndyRussG: Hey, you there? [16:54:04] K4-713: yep! [16:54:45] What do you want to do with the failing CN browser tests? I know they're on your radar, but it sounds like somebody is going to force the issue. [16:55:01] K4-713: This morning I commented on the phab task [16:55:09] Ah. Well, never mind then. :) [16:55:25] One sec I'll get the link :) [16:55:29] FOund it. [16:55:36] Ah K [16:56:07] K4-713: Yeah so I mean, it's fine if they delete them. They're still in git history for when we're able to revive and cure them [16:56:23] That's why git is like cyrogenic storage of dead peoples' heads [16:56:53] heheh [16:57:21] With the difference being that git works! [16:57:28] :D [16:57:29] semi-related, this is a thing i go to every year: https://en.wikipedia.org/wiki/Frozen_Dead_Guy_Days [16:57:48] @_@ [16:58:19] it's pretty awesome [16:58:55] there's a frozen salmon toss and a hearse parade [17:00:01] There's... a cryonics facility in San Leandro? [17:00:21] cwdent: amazing [17:00:36] the hearse parade is the best: https://www.google.com/search?site=&tbm=isch&source=hp&biw=1366&bih=701&q=frozen+dead+guy+hearse+parade&oq=frozen+dead+guy+hearse+parade&gs_l=img.3...782.5431.0.5555.29.16.0.13.2.0.108.1054.15j1.16.0....0...1ac.1.64.img..12.17.955.CPeO92va17E [17:01:55] crazy times [17:02:45] :) [17:02:53] Hmm on a completely unrelated note, rumour has it that Facebook's mobile app updates have been crashing it nonstop and that we should make fun of them [17:03:06] I was doing that already. [17:03:14] I'll keep going. [17:03:20] Wee! [17:04:09] I was mostly making fun of them for not seeming to take in to account that mobile connections can, you know, drop. [17:04:30] I post status update right as I go through tunnel, status update ends up on my wall three times. [17:04:36] dur. [17:04:45] ouch [17:04:54] and they're our php dealer [17:05:10] I don't think those guys deal in php. [17:05:57] ...not the mobile guys, anyway. [17:06:35] https://twitter.com/gotojuch/status/504573685232308224 [17:09:17] Hmm [17:20:32] AndyRussG, cwdent, awight|afk, K4|meeting - anything you want me to bring up at Scrum of Scrums? [17:21:03] ejegg: all good, thanks [17:21:53] Cool, I'll just report that we're making fabulous progress on all fronts then [17:22:19] ejegg: no thanks, all good! [17:22:22] :) [17:22:26] thanks for going! [17:23:31] hey, i'm happy for the opportunity to interact with the other teams [17:29:46] K4|meeting: .. ejegg and I were talking about Amazon's audit above ~9-9:20am ... would you be ok with amazon being included in the tests? It sound like this week is already scheduled so they are now thinking about including it in next week's round [17:31:25] cwdent: that event sounds great [17:32:14] I wonder if there is a committee that organizes it. I'd love to talk to those people [17:32:35] i think it's an official ned activity [17:32:44] ned is a weird town [17:32:54] the officials are probably burners [17:32:58] sound awesome [17:33:02] lol yeah probably [17:33:18] I bookmarked it for my blog [17:33:21] nice [17:33:24] I'm totally going to email them [17:40:23] (PS1) Cdentinger: increment WP order id between auth and charge [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242617 [17:43:11] awight|afk, ejegg: i'm meddling with things i don't really understand here but i think it will fix WP's latest problem ^ [17:43:58] cwdent: awight|afk: in the fundraising vagrant role, I see there's a payments wiki with DI enabled at http://payments.wiki.local.wmftest.net:8080, and drupal at http://crm.local.wmftest.net:8080/, but there's also another mediawiki install... anyone know the address? That other one has CN installed... is it important at all to do anything with that one for testing purposes? [17:45:10] i'm not sure AndyRussG ... seem like it might just be wiki. ? [17:49:33] nope [17:50:17] I guess I can just use the test banners on my non-vagrant MW install and make the "donate" link go to the vagrant one [17:51:19] (CR) Ejegg: [C: -1] "Katie explained to me that numAttempt is supposed to only change when the user is actually trying again - there's some session resetting t" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242617 (owner: Cdentinger) [17:54:51] cwdent: yeah I wanted to see if I could help with the unique order ID business. There's a lot of context there, as you can see from the baroque order id meta functions. [17:55:00] but... have to run for an hour. [17:55:23] awight|afk: i have lunch plans today but will figure this out after [17:55:36] Actually--u should all feel invited to: https://www.google.com/calendar/render#eventpage_6|eid-NDlhZjNoamVhZXV1aTh2NTh2MmNvYzBydm9fMjAxNTA5MzBUMTgwMDAwWiBhd2lnaHRAd2lraW1lZGlhLm9yZw-0-0- [17:55:52] https://plus.google.com/hangouts/_/wikimedia.org/incubator?authuser=0&hceid=d2lraW1lZGlhLm9yZ19wc2ZpYTBoNWFrOWk5ODhvMGJ2NzAxaWdsZ0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t.49af3hjeaeuui8v58v2coc0rvo [17:56:03] (PS1) Ejegg: Add Amazon settlement report parser [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242625 (https://phabricator.wikimedia.org/T111425) [17:56:14] oh yeah i saw that [17:56:26] an Incubator meeting, I don't know much about the group's charter yet, but AFAICT they're trying to fix all the broken stuff [17:56:41] Starts in 2 minutes. see ya! [17:57:01] ejegg: awight|afk: cwdent: I fear the strategy we talked about for EL BH server-side on donatewiki, for users without sendBeacon, is naught [17:59:44] ...because the GatewayAdapter subclass is arrived at via a redirect from GatewayFormChooser, and silent redirects can only do GET requests, not POST http://programmers.stackexchange.com/questions/99894/why-doesnt-http-have-post-redirect [18:00:01] (CR) Cdentinger: Send different OrderNumbers for each WP transaction (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg) [18:00:21] AndyRussG: GatewayFormChooser could do the logging [18:02:07] ejegg: so for non-sendBeacon users, we would in theory have this whopping banner history that we didn't send to EL, and that we could in theory send in the post in the request from the banner [18:02:24] I mean, not just the log ID, but the whole log, for such users [18:02:37] right [18:02:59] But GatewayFormChooser doesn't get access to DonationData, it's in created in GatewayAdapter [18:03:12] arr, hmm [18:03:32] IIRC, we can't have payments wiki do the EL itself because PCI [18:03:42] it could still log the banner history and pass the bhid to the gatway page in the get params [18:04:05] Remember it doesn't have EL installed [18:04:08] ohh, if the PCI thing is true this whole thing is out [18:04:17] ? [18:04:19] GatewayFormChooser is on payments too [18:04:35] right [18:04:50] and we don't bounce off DonateWiki [18:04:52] My understanding is we could somehow get it all through onto donatewiki, and do the EL there [18:04:55] yea [18:05:18] I guess we could do that, bounce of donatewiki, though that would make it 3 redirects [18:05:25] off [18:05:46] whew, seems like a heck of a lot of work, [18:06:08] I think the simplest thing is going to be to find a way to do the EL client-side for non-sendBeacon users too [18:06:19] Yeah, I mean we're already creating the beacon URL [18:06:24] Yep [18:06:34] we could just create the damn img tag ourselves [18:06:41] exactly [18:06:41] and see when it loads [18:07:08] * AndyRussG concurs with the "damn" adjective ^ [18:07:26] grumble... [18:07:42] Yeah let's do that! [18:08:00] Eh could be worse [18:09:40] (CR) Ejegg: Send different OrderNumbers for each WP transaction (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg) [18:14:28] (PS7) Ejegg: More inline help for mixins [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239302 (owner: Awight) [18:14:51] (CR) Ejegg: [C: 2] "Good stuff!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239302 (owner: Awight) [18:16:09] (Merged) jenkins-bot: More inline help for mixins [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/239302 (owner: Awight) [18:34:03] I don't know if I mentioned this before but I'm WFH today. I had a whole string of meetings and it's actually easier for me to be remote for them :P [18:36:32] (PS3) Ejegg: Send different OrderNumbers for each WP transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 [18:36:54] (CR) Ejegg: "PS3: Rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg) [19:01:45] * awight catches up on AndyRussG|errndn's damn eventlogging thoughts [19:03:00] It would be ContributionTracking that would do the EL from donatewiki, not DonationInterface [19:03:14] but yeah, the 3 redirects makes my fourth stomach turn [19:09:00] (PS1) Ejegg: WIP Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) [19:09:18] (CR) jenkins-bot: [V: -1] WIP Amazon audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/242644 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [19:12:35] awight (or anyone with some spare time and interest in SmashPig) - got a string of SmashPig commits up for CR to enable Amazon audit processing [19:13:14] (CR) Ejegg: [C: 2 V: 2] Update Amazon SDK [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/242267 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [19:13:33] will do! [19:13:40] thanks! [19:13:47] starts at https://gerrit.wikimedia.org/r/242283 [19:18:20] awight: so yeah are u OK w/ just sending the URL ourselves as suggested above ^ using an evil shiney img tag? [19:18:33] (for non-sendBeacon-ers) [19:21:30] (PS3) Ejegg: Link to bug in TODO [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242063 (owner: Awight) [19:21:49] (CR) Ejegg: [C: 2] "Informational!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242063 (owner: Awight) [19:23:34] (Merged) jenkins-bot: Link to bug in TODO [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/242063 (owner: Awight) [19:24:56] (CR) Awight: [C: 2] Update Amazon SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242283 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [19:24:59] (Merged) jenkins-bot: Update Amazon SDK [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242283 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [19:33:07] ejegg: awight: cwdent: how will Ellery query the BH ids that are linked to donations? Will he look it up somewhere in civi? Any implications for PCI= [19:33:08] ? [19:33:39] AndyRussG: I think it'll be another table alongside contribution_tracking [19:34:11] so just a db query [19:35:30] ejegg: OK [19:35:48] So, no legal issues or anything there, right? [19:35:52] thx [19:35:57] nope, not so far as I know [19:36:00] cool! [19:36:44] ejegg: also, it looks like I could just throw the BHID in the same stomp transaction, and deal with any separation of data into tables (as u suggest ^) on the civi side. Does that make sense? [19:38:10] hmm, those do end up in logs in a a couple places [19:39:16] AndyRussG: Cleanest separation would be a whole nother queue [19:42:48] (CR) Awight: [C: 2] "Verra nice!" (5 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242375 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [19:42:50] (Merged) jenkins-bot: Add Amazon audit downloader class and script [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242375 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [19:45:17] The separate queue also makes sense because we aren't guaranteed to send the donation message from DI--for example, about 95% of PayPal donations come in through the realtime listener, and 5% through the audit parser. Neither of those systems would have access to the BH id. [19:46:07] awight: ooh, so we will have to associate the BH id with the CT id, at least in the queue message [19:46:52] (CR) Awight: [C: 2] Store CSV column indexes by name (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242587 (owner: Ejegg) [19:46:55] (Merged) jenkins-bot: Store CSV column indexes by name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242587 (owner: Ejegg) [19:48:18] (CR) Awight: [C: 2] Allow skipping rows before CSV headers (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242588 (owner: Ejegg) [19:48:20] (Merged) jenkins-bot: Allow skipping rows before CSV headers [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242588 (owner: Ejegg) [19:49:43] ejegg: I think that's the way to go. Personally would like to tack BH id onto contribution_tracking as a new column... [19:50:15] But that doesn't really matter... [19:50:33] do you know if Ellery wants to be able to correlate specific histories with specific donations? [19:51:08] also, thanks for all the CR! Follow-on patches in the works... [19:52:08] ejegg: So far, he says no. But CT already has any future information he wants about * started the donation flow * converted to a donation [19:52:36] hmm, ok [19:52:43] Actually, AFAIK we haven't confirmed his requirement, we're just guessing that it's "started donation flow" [19:54:07] ejegg: previous comment on this OrderID patchset says it needs an audit regex update, do you know if that's still valid or can i merge? looks great! [19:56:14] does seem like this stands a good chance of breaking something down the chain, bummer of a thing to discover last minute [19:56:16] cwdent: i'd have to dig into the audit code to check [19:58:29] ejegg: awight: I think Ellery also was ruminating about studying payment processor used and donation amount, but I have no idea how important that may be, if at all [19:58:52] ejegg: awight: I'm looking at this https://wikitech.wikimedia.org/wiki/File:DonationPipeline_201302.png [19:59:17] i'm really not sure what to do, seems like we have to bump the test, i don't know how i can possibly get this sorted out before tomorrow [19:59:38] it's suddenly leaking into so much stuff i haven't been exposed to [19:59:51] AndyRussG: yeah, amount does seem relevant [20:00:27] cwdent: i'll take a look at the audit regex thing in a few min [20:00:50] it's in crm module wmf_audit if you want to look too [20:01:03] ejegg: i will start digging right now [20:02:10] ejegg: yeah... 3rd impression gives $1 donation vs. 10th impression gives $1.01 donation... [20:02:57] awight|stoodup: standup is displaced by shrimp today, eh? [20:03:39] as far as I know, yep [20:03:49] wup [20:03:50] wups [20:03:54] ejegg: awight|stoodup: if I understand awight's comment above correctly, ^ that is to say that PayPal doesn't use the normal stomp queue but some othe weird queues, right? [20:04:08] apologies if we've been through this before :( [20:04:23] AndyRussG: It's just that the user might not get back to payments-wiki after finishing the donation on PP's site [20:04:33] So DI has no chance to send any message [20:04:47] and we only hear about it via the IPN listener [20:04:58] ejegg: right, so how does donationdata get stored for those cases? [20:05:21] (by "right" I don't mean to imply that I know what an IPN listener is....) [20:05:31] AndyRussG: it all comes from the ipn listener, or the audit processor. They send queue messages also, but have no (simple) way of accessing things stored on paymentswiki [20:05:31] AndyRussG: not entirely sure on that - awight may know more there [20:06:09] s/right/huh?/ [20:06:39] AndyRussG: something to look at is the "payments-initial" queue, check out extras/custom_filters/custom_filters.body.php validate() [20:06:56] That's pretty much how we'd do the extra queue thing, to pass along BH id [20:07:22] AndyRussG: btw https://www.mediawiki.org/wiki/Fundraising_tech/Glossary [20:07:55] https://developer.paypal.com/docs/classic/ipn/integration-guide/IPNImplementation/ [20:07:57] Ahh mm [20:08:10] nice! [20:09:24] awight: ejegg: so, for PayPal, the contribution_tracking_id gets sent to paypal and paypal coughs it back up via their own proprietary API? [20:10:11] exactly! [20:10:28] So it would be too tricky to stuff any more numbers through that channel. [20:11:00] awight: K gotcha :) [20:11:04] AndyRussG: bblack has a great response on https://phabricator.wikimedia.org/T114078 [20:12:09] Heh yeah I was gonna read that... [20:13:10] cwdent: ok, so the audit parser combines info from those horrible RECON files with info from the payments logs [20:13:46] it looks like it uses the log lines from the 'AuthorizeAndDepositPayment' API call [20:13:58] (CR) Awight: [C: 2] Add shortcut to get value by name from current row (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242590 (owner: Ejegg) [20:14:01] (Merged) jenkins-bot: Add shortcut to get value by name from current row [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242590 (owner: Ejegg) [20:14:26] based on the regex in get_log_distilling_grep_string in crm's WorldPayAuditParser [20:14:35] awight: ejegg: OK, so BHID definitely has to go via its own queue. I guess that has to happen in GatewaAdapter, since in GatewayFormChooser we don't even have access to contribution_tracking_id, right? [20:14:49] ejegg: ah ha, yeah i was looking here https://github.com/wikimedia/wikimedia-fundraising-crm/blob/master/sites/all/modules/wmf_audit/worldpay/WorldpayAuditProcessor.php#L75 [20:15:05] AndyRussG: better to hang this off of a hook, like we do for the "fredge" queues [20:15:16] the "pre-process" hook [20:15:33] eileen: hey! Shall I enfire the schema migration? [20:15:51] awight: yes - give it a go! [20:15:52] cwdent: So, as long as the order ID we see in the RECON file is the same as the one used in AuthorizeAndDepositPayment, we shouldn't need a change [20:16:22] cwdent: I'd say we go for it and see what the audit file looks like after the change [20:16:26] ejegg: i don't suppose we can know until we download one... [20:16:35] but it's probably reasonable to think they just send back what we sent [20:16:46] eileen: Starting with v4.2.17 -> v4.6.9 upgrade .. [notice] [20:16:46] right? [20:16:57] awight: now …. wait.... [20:17:01] d'oh [20:17:12] yeah... I'd ask them which txn ID is referred to in the audit file, but the 'Sale' one would make the most sense [20:17:34] awight: ejegg: and pre-process willl run... at different times depending on which subclass of GatewayAdapter it is? [20:17:45] yeah, spose we may as well try and see [20:17:48] * awight claws at the walls -- Pretty sure we did figure out what the audit file IDs were, but it's not pretty [20:18:06] AndyRussG: yes, unfortunately [20:18:22] okie [20:18:41] I think you're safe dangling the message generation right after the "payments-initial" enqueueing, cos that is guaranteed to run for every transaction [20:19:24] awight: not the file names, wondering what order id will show up in audit file if we start sending different ones for each phase of the donation ( https://gerrit.wikimedia.org/r/171561 ) [20:19:35] oic [20:19:50] Well, we should be splitting the order id into ct_id and suffix anyway [20:25:05] (Abandoned) Cdentinger: increment WP order id between auth and charge [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242617 (owner: Cdentinger) [20:26:07] (CR) Awight: [C: 2] Add Amazon settlement report parser (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242625 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [20:26:40] (CR) Cdentinger: [C: 2] Send different OrderNumbers for each WP transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg) [20:27:16] (Merged) jenkins-bot: Add Amazon settlement report parser [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242625 (https://phabricator.wikimedia.org/T111425) (owner: Ejegg) [20:27:31] awight: ejegg: K I'l study the hook code, fredge code and payments-initial queue [20:28:20] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Version banner history log - https://phabricator.wikimedia.org/T112015#1690919 (DStrine) [20:29:32] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: Banner history: always send a temporary log ID, and never send back two logs on the same pageview - https://phabricator.wikimedia.org/T113421#1690930 (DStrine) [20:29:47] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, and 2 others: Give KVStore items limited TTL - https://phabricator.wikimedia.org/T111385#1690935 (DStrine) [20:30:04] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Fix error for non-ECMA5 browsers in ext.centralNotice.display - https://phabricator.wikimedia.org/T112590#1690953 (DStrine) [20:30:51] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Fix Worldpay audit parsing - https://phabricator.wikimedia.org/T113782#1690961 (DStrine) [20:31:13] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Update WMF logo(s) in Amazon config - https://phabricator.wikimedia.org/T113563#1690963 (DStrine) [20:31:21] ejegg: for some reason that patch isn't merging...what did i touch? [20:32:01] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: Handle Amazon SDK client communication failures and any other error that bubbles up to the Mediawiki API - https://phabricator.wikimedia.org/T112924#1690977 (DStrine) [20:32:40] lemme see [20:33:31] oh, I just had to remove my -2 [20:33:44] should be able to submit now [20:34:04] oh heh, math [20:34:26] gerrit math is weird [20:35:51] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 3 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1690997 (DStrine) [20:37:35] (CR) Cdentinger: "retry" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg) [20:39:00] ejegg: sorry to bother you, i still see that -2 and dunno if i can remove [20:40:15] ah, lemme see [20:40:51] (CR) Ejegg: [C: 2] "Undoing my own -2" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg) [20:41:09] the magic word is 'recheck' btw [20:41:37] aah sorry [20:41:43] * cwdent flustered [20:41:50] (Merged) jenkins-bot: Send different OrderNumbers for each WP transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/171561 (owner: Ejegg) [20:41:55] arcane! [20:42:58] http://git.wikimedia.org/blob/integration%2Fconfig.git/HEAD/zuul%2Flayout.yaml#L205 [20:43:27] There's also a "check experimental", for testing alternative Jenkins jobs [20:43:42] oho! [20:43:45] oh man [20:43:48] brutal [20:45:22] What's the difference between order_id and contribution_tracking_id? [20:45:37] awight|fud: ejegg ^ [20:45:39] AndyRussG: should we try to ping Ellery on this: https://phabricator.wikimedia.org/T112986 I also see Dartar on another board [20:45:40] AndyRussG: good question! [20:45:55] order_id is the transaction ID on the payment processor's side [20:46:24] *Dartar is moving the task around on another board [20:46:26] awight|fud: ah so, sometimes there's none yet, correct? for example in the PayPal case? [20:47:10] dstrine: the task is resolved, I should just summarize some discussion that was had via e-mail and ask Ellery to confirm that he also thinks it's resolved, I think [20:47:15] contribution_tracking_id is the primary key from our contribution_Tracking table, which usually exists even before we start processing the payment [20:47:27] sometimes order_id and ct_id are identical [20:47:35] awight|fud: Ah K [20:47:38] sometimes we append some stuff to order_id [20:47:55] for PayPal, the order_id is totally unrelated, cos they generate an ID and hand it to us. [20:48:12] AndyRussG: ok I'm just scanning things before sprint planning. T112986 is still open and in "doing" on the tom waits board [20:48:42] awight|fud: I was just looking at how order_id is added by makeFreeformStompTransaction() [20:49:04] pls don't let me prevent u fud-ing before the meat, btw [20:49:20] awight|fud: should these two tasks be resolved? https://phabricator.wikimedia.org/T112920 https://phabricator.wikimedia.org/T112989 [20:50:48] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1691029 (awight) [20:50:49] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Parse PayPal audit data from Aug 25-Aug 27 + Sep 16 gaps - https://phabricator.wikimedia.org/T112989#1691027 (awight) Open>Resolved Confirmed working. [20:50:56] Fundraising Sprint Tom Waits, Fundraising-Backlog, Unplanned-Sprint-Work: Backfill from Aug 25-Sept 17 PayPal audit outage - https://phabricator.wikimedia.org/T112920#1691034 (awight) Open>Resolved [20:51:52] ejegg, or anyone, objections to a DI deploy? [20:53:01] AndyRussG: I think the makeFreeform stuff can be left alone, we can pass that function a minimal array of the fields we'd like to send via queue and the other required fields will be populated transparently, including all IDs that we need to reassociate with the contribution_tracking and donations tables later on. [20:53:10] really eating now... [20:53:30] none here cwdent [20:54:35] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/242724 [20:55:17] (CR) Cdentinger: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/242724 (owner: Cdentinger) [20:58:34] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/242724 (owner: Cdentinger) [21:07:41] (PS1) Cdentinger: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/242731 [21:12:34] (CR) Cdentinger: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/242731 (owner: Cdentinger) [21:15:32] (CR) Ejegg: Add shortcut to get value by name from current row (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242590 (owner: Ejegg) [21:16:13] (PS1) Ejegg: Throw exception on duplicate CSV header [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242732 [21:17:51] (CR) Awight: Add shortcut to get value by name from current row (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242590 (owner: Ejegg) [21:18:32] eileen: rats--error during the upgrade [21:18:49] dammit [21:18:49] * ERROR DEBUGINFO: RENAME TABLE `civicrm_contribution_type` TO `civicrm_financial_type` [nativecode=1050 ** Table 'civicrm_financial_type' al [21:18:52] ready exists] [21:18:55] #0 [internal function](): CRM_Core_Error::exceptionHandler(Object(DB_Error)) [21:21:02] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Configure new CiviCRM staging instance for testing 4.6 upgrade - https://phabricator.wikimedia.org/T112314#1691113 (awight) @Jeff_Green: Turns out we need to drop a bun... [21:21:41] OK, dropping tables and trying again... [21:23:25] PPena: and cwdent I just saw our message to worldpay on the email: "[TIME SENSITIVE}: IMPORTANT/ Wiki - ESOP testing" Is that concerning? are we still on track to do a 1 hour test tomorrow? [21:23:47] dstrine: probably not [21:24:15] cvv isn't working and there's a new input format problem [21:24:27] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Configure new CiviCRM staging instance for testing 4.6 upgrade - https://phabricator.wikimedia.org/T112314#1691125 (awight) @Jgreen: fyi, I dropped the database and recr... [21:25:20] http://justsmallbiz.com/wp-content/uploads/2014/01/Whack-a-Mole.jpg [21:25:27] deploying DI now [21:25:40] rockin [21:25:41] more importantly, http://www.theguardian.com/music/2015/sep/30/steve-albini-rant-about-dance-music-turned-into-billboard [21:26:11] awesoe [21:26:14] +m [21:26:14] Fundraising Sprint Tom Waits, Fundraising-Backlog, Research-and-Data, Unplanned-Sprint-Work: Review banner history log data and confirm that it satisfies use cases - https://phabricator.wikimedia.org/T112986#1691126 (AndyRussG) @ellery here're my main take-aways from our e-mail discussion from last... [21:26:36] cwdent: thanks for the info... that sucks... did that just show up? [21:27:08] eileen: fyi, it'll be about 3 hours until the database is restored for another try. [21:27:10] dstrine: the cvv thing was probably never working [21:27:26] but there was a coincidental ip velocity failure that made it look working [21:27:32] d'oh. [21:27:56] Why do they tell us these things work? [21:28:07] It's... as if they've never eaten their own dog fud [21:28:09] cwdent: ugh :( [21:28:10] the order ID thing is new since they started using our IDs to index the dashboard [21:28:22] as far as i understand [21:28:24] which is not very far [21:28:30] ooh you're using numbers with more than 3 digits! it's breaking our mainframe [21:28:41] (PS1) Ejegg: Clean up a couple ReportDownloader things [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242733 (https://phabricator.wikimedia.org/T109654) [21:29:02] (CR) Ejegg: Add Amazon audit downloader class and script (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242375 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [21:29:52] (CR) Awight: [C: 2] "Thanks!" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242733 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [21:30:11] cwdent: Stop sending us numbers, Case [21:30:49] And what's up with the curly letter & in URLs [21:30:50] (CR) Ejegg: Add Amazon audit downloader class and script (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242375 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [21:31:07] also worth noting that the dupe order IDs seem to process fine and are invalid for some other reason [21:31:38] those dupe order IDs somehow prevent us from automating refunds too [21:32:08] It's pretty disappointing that we need to make the 0.10 auth charge anyway [21:36:02] !log updated payments from bc4bcc44d2337d7a69c5a39f11ff45efdf0c8e11 to 24d5be6886d34b3600031290c7f55ee84f3dcee2 [21:36:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:36:17] cwdent: should I tell fr-online that we should hold off on the 1 hour test until this is resolved? [21:36:51] or should we wait a little while and see what they do this afternoon? [21:37:01] dstrine: let's try to sort it out this afternoon [21:37:10] if it's not confirmed working by morning i think we should punt [21:37:22] i just deploy what i hope is the fix [21:37:37] for the order# thing that is [21:37:41] as far as the cvv, that's on them [21:38:03] (Merged) jenkins-bot: Clean up a couple ReportDownloader things [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/242733 (https://phabricator.wikimedia.org/T109654) (owner: Ejegg) [21:38:09] ok I might just give a heads up the the-Wub by EOD [21:38:21] like ~5pm PDT [21:39:21] dstrine: come to think of it we may not have anyone around to test until the wee hours [21:39:39] Imaginez un monde dans lequel chaque personne, où qu’elle soit, dispose d’un libre accès à la somme de tout le savoir humain. [21:41:34] cwdent: ah good point. would it help if we asked for testing when european people start their workdays? This way we will have info when we log in tomorrow morning. [21:41:55] dstrine: yeah that seems good to me, we can make the call in the morning [21:42:34] CVV shouldn't block testing IMO--we can just impose the extra penalty for being French [21:43:01] awight: you are saying CVV should not block a 1 hour test? [21:43:07] right [21:43:12] we could even run the campaign like that. [21:43:21] yeah, that's how it was before right? when wp was live [21:43:25] yep [21:43:41] It's not ideal, so PPena is pushing them on it while we have their attention [21:43:50] awight: cwdent would cvv block campaign ready? [21:44:07] doesn't sound like it [21:44:17] PPena should make that call, but I'm happy to go ahead too [21:44:39] what does the dupe order id actually break? just automated refunds? [21:45:09] awight: are we going to get elevated donor services issues during the 1 hour test? [21:45:17] cwdent: oh, I thought you found it was breaking something else! [21:46:06] ejegg: nope! just email from WP saying it's a problem [21:46:18] ah, I see [21:46:34] well, seems like a good time to take care of it [21:53:57] dstrine we are still trying to fix the order id issue we found yesterday [21:54:56] cwdent: is there a task for the order ID bug? [21:55:31] just searching ID and order doesn't show anything in Tom Waits [21:57:17] dstrine: no sorry it just came up this morning [21:57:27] been beating my head against it since [21:58:08] kk [21:58:11] anyone know offhand which version of jquery we're on? [21:58:54] dstrine: there's an ancient one imported from mingle [21:59:36] ejegg: lol wow... and it relates to the current french campaign work? [21:59:41] AndyRussG: for CentralNotice? we need to be compatible with a few versions. checking the current version... [21:59:57] dstrine: no, related to the automated refund thing [22:00:06] but same solution [22:00:21] AndyRussG: jQuery 1.11.3 (resources/lib/jquery/jquery.js) [22:00:33] awight|mtg: cool thx [22:00:37] dstrine: be ther in a sec! [22:00:54] hrm, maybe not there [22:03:14] fyi we have room squatters [22:14:56] Fundraising Sprint Tom Waits, Fundraising-Backlog: Sprint T goal (End Q1 + code slush): amazon & worldpay 1-hour test ready, banner history being used by fr-online - https://phabricator.wikimedia.org/T108406#1691256 (DStrine) Open>Resolved [22:35:07] Fundraising Sprint Tom Waits, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Paypal IPN log is not replicated to log server? - https://phabricator.wikimedia.org/T113323#1691320 (DStrine) [22:35:14] Fundraising Sprint Tom Waits, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Paypal IPN log is not replicated to log server? - https://phabricator.wikimedia.org/T113323#1661815 (DStrine) [22:36:37] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-EventLogging, and 3 others: Beta Cluster EventLogging data is disappearing? - https://phabricator.wikimedia.org/T112926#1691338 (DStrine) [22:40:35] Fundraising Sprint Tom Waits, Fundraising-Backlog, Research-and-Data, Unplanned-Sprint-Work: Review banner history log data and confirm that it satisfies use cases - https://phabricator.wikimedia.org/T112986#1691353 (awight) Open>Resolved Thanks for looking at this! [22:40:37] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Mini epic] Activate Banner History! - https://phabricator.wikimedia.org/T112020#1691355 (awight) [22:40:51] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, Analytics-Backlog, and 3 others: Promise returned from LogEvent should resolve when logging is complete - https://phabricator.wikimedia.org/T112788#1691357 (Ejegg) Open>declined Seems to be a no-go in Eve... [22:42:34] Fundraising-Backlog: Hebrew or other non-Latin characters not making it into Worldpay donations - https://phabricator.wikimedia.org/T114000#1682081 (DStrine) [22:43:55] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, Patch-For-Review: [epic] Banner History MVP - https://phabricator.wikimedia.org/T78089#1691373 (DStrine) [22:45:57] Fundraising-Backlog: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1691379 (DStrine) [22:46:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: JPMorgan Import Not Working - https://phabricator.wikimedia.org/T113381#1691383 (DStrine) [22:47:01] Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Fix banners on IE8 and IE9 - https://phabricator.wikimedia.org/T113013#1691389 (awight) Down to a 2.11% share in the latest stats: https://docs.google.com/spreadsheets/d/1n9FhSqcBGM9iKXrlH... [22:48:01] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Write banner diet campaign mixin - https://phabricator.wikimedia.org/T112017#1691395 (awight) [22:50:16] Fundraising-Backlog, Analytics-EventLogging: Nested EventLogging data doesn't get copied to MySQL - https://phabricator.wikimedia.org/T112947#1691416 (Nuria) Let us know if this is still a problem . Thus far we have not supported nested schemas but if workarround does not suffice we can do needed changes. [22:54:06] Fundraising-Backlog: Recharge minFraud account - https://phabricator.wikimedia.org/T113105#1691451 (awight) All I know is that we still have > 500k queries remaining. [22:59:08] Fundraising Sprint U, Fundraising-Backlog: Add "direct mail appeal" column to Trilogy import - https://phabricator.wikimedia.org/T114155#1691485 (DStrine) [22:59:10] Fundraising Sprint Tom Waits, Fundraising Sprint U, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Banner history: encode all hide reasons - https://phabricator.wikimedia.org/T113813#1691487 (DStrine) [22:59:13] Fundraising Sprint Tom Waits, Fundraising Sprint U, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Donate button on Amazon form should only show up when a card is selected - https://phabricator.wikimedia.org/T114198#1691484 (DStrine) [22:59:16] Fundraising Sprint U, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Default appeal should be configurable, initial query string value should be stored in session - https://phabricator.wikimedia.org/T114127#1691486 (DStrine) [22:59:39] Fundraising Sprint U, Fundraising Tech Backlog, Fundraising-Backlog: contribution_source triggers seem to be failing - https://phabricator.wikimedia.org/T98643#1691510 (DStrine) [22:59:39] Fundraising Sprint Tom Waits, Fundraising Sprint U, Fundraising-Backlog: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#1691513 (DStrine) [22:59:41] Fundraising Sprint U, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1691512 (DStrine) [23:01:21] Fundraising Sprint U, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Default appeal should be configurable, initial query string value should be stored in session - https://phabricator.wikimedia.org/T114127#1691528 (Ejegg) p:Triage>Normal a:Ejegg [23:44:04] Fundraising Tech Backlog, Team-Practices-This-Week: Measure Maintenance Fraction for FR-Tech - https://phabricator.wikimedia.org/T114328#1691674 (JAufrecht) NEW a:K4-713