[00:00:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced Search needs an OR operator - https://phabricator.wikimedia.org/T115900#1740703 (Eileenmcnaughton) Possibly a good thing to look at when I'm over there in Nov. Search builder is more powerful than advanced search & I suspect that if it looked a... [00:02:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced Search needs an OR operator - https://phabricator.wikimedia.org/T115900#1740714 (CaitVirtue) OK, cool. Didn't know you were coming then. Looking forward to meeting you! [00:04:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced Search needs an OR operator - https://phabricator.wikimedia.org/T115900#1740718 (Eileenmcnaughton) Looking forward to meeting you too! I was a google summer of code mentor this year & got the free trip to the mentor summit in SF on the weekend... [00:06:26] atgomez: How do you create new task templates? [00:06:31] (in Phabricator) [00:07:42] atgomez: ftw: https://www.mediawiki.org/w/index.php?title=Phabricator/Help&redirect=no [00:10:18] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare queue messages for testing on upgraded Civi. Test them. - https://phabricator.wikimedia.org/T114466#1740727 (Ejegg) Fake data sets - donation queue me... [00:14:21] (PS1) Ejegg: Queue consumer can import multiple messages from JSON [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247765 (https://phabricator.wikimedia.org/T114466) [00:15:07] (PS4) AndyRussG: WIP add banner_history module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) [05:14:00] (CR) Awight: Allow mixins to specify default parameter values (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247637 (owner: Ejegg) [05:14:22] (PS2) Awight: Fix e-strict errors [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247462 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [05:14:38] (CR) Awight: [C: 2] "Thanks!" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247462 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [05:16:24] (Merged) jenkins-bot: Fix e-strict errors [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247462 (https://phabricator.wikimedia.org/T99836) (owner: Eileen) [05:41:39] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, and 2 others: Fix banners on IE8 and IE9 - https://phabricator.wikimedia.org/T113013#1741109 (awight) [05:45:27] Fundraising Sprint Rowlf the Dog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Deploy CentralNotice schema change - https://phabricator.wikimedia.org/T104508#1741125 (awight) [05:46:13] (PS3) Awight: Special:CentralNotice: always log the summary change if it was in the request [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234834 (https://phabricator.wikimedia.org/T110315) (owner: Glaisher) [05:47:06] (CR) Awight: [C: 2] "Thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234834 (https://phabricator.wikimedia.org/T110315) (owner: Glaisher) [05:48:30] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Summary of campaign settings changes is not logged in CentralNotice logs when modified using Special:CentralNotice main page table - https://phabricator.wikimedia.org/T110315#1741134 (awight) Open>Resolved Love to see the... [05:54:04] (Merged) jenkins-bot: Special:CentralNotice: always log the summary change if it was in the request [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234834 (https://phabricator.wikimedia.org/T110315) (owner: Glaisher) [06:13:23] (PS1) Awight: Remove "too many banners" warning [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247785 (https://phabricator.wikimedia.org/T109714) [06:14:36] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, Patch-For-Review: Unnecessary bucket warnings in campaign settings - https://phabricator.wikimedia.org/T109714#1741183 (awight) [06:15:12] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: CentralNotice cross-browser tests: debug and expand - https://phabricator.wikimedia.org/T108746#1741185 (awight) [06:18:06] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#1741198 (awight) @Paladox gave us the answer to conditional initialization, that for now we can write a callback function for that junk. Once... [06:18:59] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Spike: investigate negative scroll offset for cancelling "banner bump" - https://phabricator.wikimedia.org/T107967#1741202 (awight) [06:19:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Spike: investigate negative scroll offset for cancelling "banner bump" - https://phabricator.wikimedia.org/T107967#1741203 (awight) p:Triage>Normal [06:19:44] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice, Easy: Write API for campaign creation and use it to create browser test fixtures - https://phabricator.wikimedia.org/T107376#1741205 (awight) [06:19:54] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: CentralNotice: "Preview all approved translations" is dead - https://phabricator.wikimedia.org/T105558#1741206 (awight) [06:20:07] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Machine-readable CentralNotice and paymentswiki outage log - https://phabricator.wikimedia.org/T106394#1741207 (awight) [06:28:21] (PS5) Awight: CentralNotice should use content rather than interface language [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/197741 (https://phabricator.wikimedia.org/T53475) [06:29:29] (CR) jenkins-bot: [V: -1] CentralNotice should use content rather than interface language [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/197741 (https://phabricator.wikimedia.org/T53475) (owner: Awight) [06:33:26] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Patch-For-Review: Use contentlanguage for CentralNotice banners - https://phabricator.wikimedia.org/T53475#1741248 (awight) @Nemo_bis I'd be curious what you think of this feature request, do you agree that it makes more sense than targeting b... [06:47:07] Fundraising-Backlog, MediaWiki-Interface, MediaWiki-extensions-CentralNotice, Easy: BUG: Campaign date fields cannot be edited as text - https://phabricator.wikimedia.org/T97159#1741261 (awight) [06:57:29] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice, Easy: Banner controller: be sure random= override will always work - https://phabricator.wikimedia.org/T90674#1741274 (awight) The cobweb-encrusted comment is probably mine... In hindsight, we can't rely on the `random=` parameter no matte... [06:58:15] good morning jessicarobell :) [06:58:36] Good morning the-wub! [07:00:15] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, I18n: Can't use Translate extension's variables feature in CentralNotice - https://phabricator.wikimedia.org/T87448#991413 (awight) I wish we could have this for translated snippets! What do message auth... [07:01:05] fyi AU/NZ test just went up [07:05:50] Great! Thanks the-wub [07:11:46] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-TranslationNotifications, I18n: Can't send translation notifications for translatable banners - https://phabricator.wikimedia.org/T58187#1741289 (awight) Reading this bug and T87448, I'm increasingly convinced that... [07:12:02] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice, Easy, I18n: Time selector on SpecialCentralNotice should use a standardized module - https://phabricator.wikimedia.org/T38793#1741292 (awight) [07:13:51] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice, Easy: api parameter for list=centralnoticelogs are not prefixed - https://phabricator.wikimedia.org/T57832#1741294 (awight) Noting that the WMF currently has nothing that relies on the CentralNotice API, but we should check the API logs jus... [07:15:26] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-DonationInterface, and 2 others: Triage accessibility for donor-facing Fundraising components - https://phabricator.wikimedia.org/T87667#1741307 (awight) [07:18:35] Fundraising Sprint Enya, Fundraising Tech Backlog, Fundraising-Backlog, § Fundraising Sprint Abba, and 4 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1741326 (awight) Open>Resolved a:awight [07:23:40] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Untranslated CentralNotice banners should be flagged or forbidden - https://phabricator.wikimedia.org/T90634#1741366 (awight) [07:24:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Finish bucketing updates for CN - https://phabricator.wikimedia.org/T77951#1741378 (awight) Open>declined a:awight This bug never held any content. [07:27:00] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice: Installing CentralNotice using the web installer breaks as CN autoloads the CNDatabasePatcher class in $wgExtensionFunctions - https://phabricator.wikimedia.org/T57955#1741391 (awight) [07:35:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Spike: investigate negative scroll offset for cancelling "banner bump" - https://phabricator.wikimedia.org/T107967#1741448 (awight) [07:37:00] (PS2) Awight: Disable some unused banner mixin form elements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236070 [07:39:25] (PS3) Awight: Disable some unused banner mixin form elements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236070 [07:50:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Tracking: Reduce the "banner bump" (tracking) - https://phabricator.wikimedia.org/T109634#1741486 (awight) [07:53:12] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Accessibility, Browser-Support-Firefox: Can't see or click login button due to fundraising banner - https://phabricator.wikimedia.org/T74013#1741501 (awight) Should this be blocked on something about fullscreen banners? [07:55:48] Wikimedia-Fundraising, Easy, JavaScript, Technical-Debt: CentralNotice banner uses deprecated globals such as "wgUserGroups", "sajax_init_object" and "sajax_debug_mode" - https://phabricator.wikimedia.org/T86871#1741511 (awight) [07:58:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner editor should be more consistent with other editing (tracking) - https://phabricator.wikimedia.org/T116140#1741517 (awight) NEW [08:02:38] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner editor should be more consistent with other editing (tracking) - https://phabricator.wikimedia.org/T116140#1741538 (awight) [08:06:36] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner editor should be more consistent with other editing (tracking) - https://phabricator.wikimedia.org/T116140#1741547 (awight) [08:13:11] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: BUG: CentralNotice banner translations sometimes go missing from Translate interface - https://phabricator.wikimedia.org/T90863#1741565 (awight) [08:14:58] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247460 (https://phabricator.wikimedia.org/T90919) (owner: Ejegg) [08:17:01] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/236070 (owner: Awight) [08:26:22] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Central Notice message groups are slow to index - https://phabricator.wikimedia.org/T111189#1741583 (awight) [08:26:52] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: New banner messages not added to message group - https://phabricator.wikimedia.org/T106856#1741585 (awight) [09:01:01] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#1741640 (Paladox) @awright I am not sure what your asking. But yes you have to use a callback currently. [09:08:05] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#1741659 (Paladox) But anyways it dosent need a callback it already uses the ExtensionFunctions config which does it. [09:11:36] (CR) Paladox: [WIP] Add extension.json, empty php entry point (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [09:11:58] (CR) Awight: [C: 1] "It's looking great, I'll test it and respond here!" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [09:12:11] (PS9) Awight: [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 [09:12:46] (PS2) Awight: Change label from 'Save' to 'Update' on report options. [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247471 (https://phabricator.wikimedia.org/T99837) (owner: Eileen) [09:12:58] (CR) Awight: [C: 2] Change label from 'Save' to 'Update' on report options. [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247471 (https://phabricator.wikimedia.org/T99837) (owner: Eileen) [09:14:53] (Merged) jenkins-bot: Change label from 'Save' to 'Update' on report options. [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/247471 (https://phabricator.wikimedia.org/T99837) (owner: Eileen) [09:16:51] (PS10) Awight: [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) [09:21:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, Patch-For-Review: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#1741683 (awight) @dstrine @atgo @AndyRussG I'd like to pull this one in before the code freeze, a lot of work went into th... [09:22:27] (PS11) Paladox: [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [09:22:54] (CR) Paladox: "Added a callback for some configs." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (owner: Awight) [09:25:51] (PS12) Paladox: [WIP] Add extension.json, empty php entry point [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [09:26:18] (CR) Paladox: "Sorry didn't notice commit msg was updated when I was updating the code." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [12:00:37] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-TranslationNotifications, I18n: Can't send translation notifications for translatable banners - https://phabricator.wikimedia.org/T58187#1741918 (Nikerabbit) >>! In T58187#1741289, @awight wrote: > The historical re... [12:04:03] Hey MBeat! [12:04:13] hi [12:06:03] how are you? [12:06:32] good, thanks for your email. sorry for Civi blues! how soon til France banners? [12:07:43] Yeah, sorry for the delay on that! [12:08:08] We are planning to run an hour test in around half an hour to start with. Does that work for you? [12:09:13] We are waiting for some clarification on Banner history data and double checking that there are no issues regarding the audit before we launch. [12:09:51] Sure thing on the test, and thank you for the heads-up [12:09:56] cool! Thanks [12:10:23] And the delay is all mine on BE & LU :) [13:46:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New SSL cert for Rosie Lewis - https://phabricator.wikimedia.org/T115889#1742239 (Jgreen) Great, I'll generate her cert and send the password this AM. [15:12:28] Fundraising Sprint Vengaboys, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Banner impressions not updating on lutetium - https://phabricator.wikimedia.org/T116021#1742532 (Pcoombe) Open>Resolved a:Pcoombe Great, I confirmed it too. I've sent WMDE the numbers they miss... [15:14:41] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Announce new banner diet feature - https://phabricator.wikimedia.org/T115783#1742545 (Pcoombe) Just confirming that I tested the feature, and everything looks good to me. [16:16:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New SSL cert for Rosie Lewis - https://phabricator.wikimedia.org/T115889#1742669 (Jgreen) Open>Resolved >>! In T115889#1742239, @Jgreen wrote: > Great, I'll generate her cert and send the password this AM. cert & passwor... [16:51:39] ejegg: cwdent: morning! any tips on getting activeMQ messages on vagrant fundraising role, for this patch? https://gerrit.wikimedia.org/r/#/c/244109/ [16:51:54] I'm trying to see if the messages are actually getting queued... 8p [16:52:02] Hi AndyRussG [16:52:09] :) [16:52:25] Looking at http://localhost:8161/admin/index.jsp [16:52:43] ok, so you can get to the admin interfave [16:52:45] Do I have to configure a new queue or topic or something? [16:53:13] yeah totes! my fave! (excellent new word!!!) [16:53:22] hehe [16:53:30] I don't think we need topics [16:53:56] I was thinkimg that just by sending the msg it should show uo there, maybie not? [16:54:03] yeah exactly [16:54:20] Umm, you do need to configure the queue in DonationInterface though [16:54:29] let me see what I've got in LocalSettings for that [16:55:09] you need $wgDonationInterfaceEnableQueue = true [16:55:35] and then you need to configure each queue [16:55:45] $wgDonationInterfaceQueues['pending'] = array( 'type' => '\PHPQueue\Backend\Stomp', 'uri' => 'tcp://localhost', 'persistent' => 1, 'expiry' => '30 days' [16:55:48] ); [16:56:41] oh, you probably also want to configure the default queue server [16:57:02] $wgDonationInterfaceDefaultQueueServer = array( [16:57:02] 'type' => '\PHPQueue\Backend\Stomp', [16:57:02] 'servers' => array( [16:57:02] 'scheme' => 'tcp', [16:57:02] 'host' => '127.0.0.1', [16:57:04] 'port' => 6379, [16:57:07] ), [16:57:09] 'order_key' => 'date', [16:57:12] 'expiry' => '2529000', [16:57:14] ); [16:57:45] Oh, I guess most of that is probably already set up in vagrant [16:57:55] so you just need to add an entry for your new queue [16:58:15] ejegg: ah hmm lemme dig into all that... So only LocalSettings, nothing additional to go in the DI patch itself, right? [16:58:41] well, let me look at the DI patch [16:59:04] ejegg: thx! [16:59:18] this one, right? https://gerrit.wikimedia.org/r/244109/ [17:00:56] ejegg: yep! [17:01:18] Yeah, looks like you're just missing the banner_history queue configuration [17:02:49] Hmm K [17:03:01] Fundraising-Backlog: Failover Worldpay API urls - https://phabricator.wikimedia.org/T116195#1742836 (cwdent) NEW [17:03:25] (CR) Ejegg: "Please add banner_history to the list of 'non-critical queues' under $wgDonationInterfaceQueues in DonationInterface.php near line 500" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [17:03:26] I don't see anything in the vagant-provided LocalSettings.php... I seem to recall once seeing there was a directory for activatable settings, maybe it was just a dream, tho [17:03:43] ejegg: thx!! [17:03:55] hmm, let me see if there is anything in the fr role manifests [17:05:40] donation_interface.pp looks like it sets up a whole bunch of DI-specific settings, though I'm not sure what file they end up in [17:06:39] found it AndyRussG: settings.d/wikis/paymentswiki/settings.d/puppet-managed/10-DonationInterface.php [17:07:05] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Accessibility, Browser-Support-Firefox: Can't see or click login button due to fundraising banner - https://phabricator.wikimedia.org/T74013#1742852 (MZMcBride) I'm not sure how this task is low priority. [17:07:18] ejegg: weeee thanks a ton! [17:07:25] yw! [17:07:53] AndyRussG: oh, by the way, do you know how to re-apply changes to a .pp file without destroying the whole box? [17:08:13] I've tried re-running vagrant provision and it didn't seem to pick up the changes [17:08:55] Hmm no I don't know... [17:09:31] I bet there's a lower-level puppet command you can run from inside the box, but I'm not sure exactly how to run just some of those and still get the whole heirarchy of settings pulled in [17:16:45] ejegg: huh yeah that's a really good quesiton [17:17:49] i'm sure somebody round here knows [17:19:46] Nobody knows the puppets I've seen... ♫ [17:28:58] AndyRussG, cwdent: any news for scrum of scrums? [17:29:05] (sorry for last-minute ask) [17:29:11] ejegg: nothing here : [17:29:12] ) [17:29:18] thx! [17:29:19] cool [17:29:24] ejegg: nope! thanks [17:41:35] Fundraising-Backlog: Deploy Media Wiki Interface subject line in French - https://phabricator.wikimedia.org/T116199#1742941 (jrobell) NEW [17:52:29] Fundraising-Backlog: Failover Worldpay API urls - https://phabricator.wikimedia.org/T116195#1743018 (atgo) Should we do this before/at the start of the France campaign? [17:53:10] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Patch-For-Review: Use contentlanguage for CentralNotice banners - https://phabricator.wikimedia.org/T53475#1743021 (Nemo_bis) >>! In T53475#1741248, @awight wrote: > @Nemo_bis > I'd be curious what you think of this feature request, do you agr... [17:53:28] Fundraising Sprint Vengaboys, Fundraising-Backlog, Unplanned-Sprint-Work: Deploy Media Wiki Interface subject line in French - https://phabricator.wikimedia.org/T116199#1743026 (Ejegg) p:Triage>High a:Ejegg [18:04:24] (PS1) Ejegg: Update DonationInterface lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/247889 [18:04:41] (PS1) Ejegg: Update DonationInterface lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247890 (https://phabricator.wikimedia.org/T116199) [18:06:16] (CR) Ejegg: [C: 2 V: 2] "Lib update" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247890 (https://phabricator.wikimedia.org/T116199) (owner: Ejegg) [18:07:49] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface lib [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/247889 (owner: Ejegg) [18:08:46] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247891 [18:09:25] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247891 (owner: Ejegg) [18:09:27] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/247891 (owner: Ejegg) [18:12:46] !log updated crm from 22dc4bd7d041126a1d2a0d4acb9a288bfdc1b435 to f2fa7b942625b34ede520e11f20e7e0835ecb17d [18:12:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:31:18] analytics mentioned this new logstash dashboard at SoS: https://logstash.wikimedia.org/#/dashboard/elasticsearch/default [18:33:47] ejegg: cool! thx [18:34:25] Initial stats on BH indicate no history for a large chunk of users, maybe. Maybe due to Do Not Track [18:34:35] hmm [18:34:47] would be nice to have the stats on that, but... [18:34:53] Heheh yeah [18:36:22] I mean we could approximate by looking at UA strings and eliminating from calculations the ones that have absolutely BH (presumibly due to some incompatibility). Probably not a lot like that... [18:37:17] hmm [18:56:20] (CR) Ejegg: "Interesting suggestion awight, it would be nice to minimize the mixin registration code in php." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247637 (owner: Ejegg) [18:58:05] ejegg: having a hard time understanding yr proposal ^ [18:58:26] I was thinking something cheesy like a .js callback, but I think I like your idea better [18:59:01] (PS6) AndyRussG: WIP Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) [18:59:06] yeah, we'd want to move the whole param registration out of php if we were to allow js callbacks for defaults, right? [18:59:19] Only drawback there is a slower loading admin page [18:59:32] (CR) jenkins-bot: [V: -1] WIP Add banner history log ID processor [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/244109 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [19:00:09] But that pattern will also allow for more flexible parameter input down the line if we need it [19:00:28] letting the mixin register a callback on activation and save, for example [19:01:12] awight: not sure what you mean by a cheesy .js callback [19:02:51] ejegg: On third thought, it's not thrilling that we would need both an admin and a subscribing js module for each mixin [19:03:06] Maybe PHP callback is the way to go? [19:03:14] defaults are a one-time thing anyway. [19:04:33] hmm. the whole mixins registry is just a variable, so you could theoretically set the default value on anything wherever you want. [19:05:21] mmm--has to be a callback though, cos each e.g. a value based on campaign name would be different for every campaign [19:06:00] yeah, looking for post-campaign-selection hooks on special:centralnotice [19:06:32] brb after fud! [19:06:37] k [19:47:18] (CR) Ejegg: "If you still want to set the defaults in php, based on campaign data, you could add a hook in CentralNotice::outputNoticeDetail, then in a" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247637 (owner: Ejegg) [19:48:40] http://c2.com/cgi/wiki?TwoIsAnImpossibleNumber [19:48:48] Fundraising Sprint Vengaboys, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Deploy Media Wiki Interface subject line in French - https://phabricator.wikimedia.org/T116199#1743576 (Ejegg) Open>Resolved Test email looks good. [20:08:19] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Unsubscribe link doesn't work on upgraded staging 4.6 - https://phabricator.wikimedia.org/T116112#1740685 (DStrine) [20:08:57] Fundraising-Backlog: [BUG] GC100 Auth Fail Errors 10/18 very high fail rate - https://phabricator.wikimedia.org/T115818#1743643 (atgo) p:Unbreak!>Triage Ok. I'm going to put this at "needs triage" until we know if it's an fr-tech issue. [20:12:58] Mmm chicken broth + beans, cheap + filling [20:15:14] Fundraising-Backlog, Astropay: [epic] Processing via Astropay for Spanish-speaking LATAM countries - https://phabricator.wikimedia.org/T102143#1743666 (DStrine) [20:15:45] (CR) Awight: "I don't thing a hook is necessary--I'm thinking, everything as it is but 'default' => 0 for a constant, and 'default' => 'ImpressionDiet::" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247637 (owner: Ejegg) [20:17:13] awight: ejegg: cwdent: dya know where my vagrant http://payments.wiki.local.wmftest.net:8080/ apache error and access log would be, by any chance? [20:17:18] logs [20:17:55] awight: so before spitting out wgCentralNoticeCampaignMixins to client-side, we scan all param defaults to see if any of them are a callable, then replace the default with the results of calling the callable with the campaign details? [20:18:59] AndyRussG: not offhand - i'd try to track em down in the apache config [20:19:11] ah heh good idea 8p [20:20:30] awight: oh wait, I see a better place - where we're adding the data- elements with the saved values, we look for defaults if there are no saved param values [20:20:42] i mean data- attributes [20:22:31] AndyRussG: there are two log dirs. Normal stuff is in /var/log [20:23:07] but /vagrant/logs has a few of the log files, I think apache error is one of those, kept in that directory so it's shared between host and vm. [20:24:00] ejegg: mmm, yeah both those sound perfect [20:24:08] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Prepare queue messages for testing on upgraded Civi. Test them. - https://phabricator.wikimedia.org/T114466#1743720 (Ejegg) I just tried importing 1000 fake messages locally (with c... [20:24:36] awight: Civi 4.6 might need some tuning ^^ [20:24:58] ... if you agree that the PHP callback is a good way to go. Actually--I would define the defaults using a closure, and I'm suddenly uncomfortable that 'class::func' is ambiguous, callable or string? [20:25:17] ejegg: uh, oh! Thank you for pushing that forward! [20:25:27] awight: yeah, definitely should be a not-ambiguous callable [20:27:14] Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Script to compile civicrm into deployment form - https://phabricator.wikimedia.org/T115925#1743738 (DStrine) [20:27:41] Fundraising Sprint Vengaboys, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Format Monolog messages to be easier to grep, bucket them - https://phabricator.wikimedia.org/T115746#1743750 (atgo) [20:28:24] ejegg: I worry that 'sort' or something will be is_callable [20:28:26] hrmmm [20:28:55] awight: we can also check ! is_string [20:29:18] Fundraising Sprint UB40, Fundraising-Backlog: EXTERNAL: Name field hide on iframe & Iframe translations - https://phabricator.wikimedia.org/T114679#1743764 (DStrine) [20:29:54] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog: EXTERNAL: Worldpay HCG search by email address - https://phabricator.wikimedia.org/T114183#1743775 (atgo) Removing this as a blocker for the campaign. [20:30:16] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog: EXTERNAL: Worldpay HCG search by email address - https://phabricator.wikimedia.org/T114183#1743778 (atgo) [20:30:17] Fundraising Sprint UB40, Fundraising-Backlog: EXTERNAL: Name field hide on iframe & Iframe translations - https://phabricator.wikimedia.org/T114679#1743777 (atgo) [20:30:18] Fundraising-Backlog: Should we remove name fields from WMF hosted part of WorldPay ESOP form? - https://phabricator.wikimedia.org/T113303#1743779 (atgo) [20:30:27] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Worldpay frontend donation missing payment_method - https://phabricator.wikimedia.org/T115932#1743780 (atgo) Is this actually blocking the campaign? [20:33:36] ejegg: but is_string and is_callable both return true for 'sort' [20:34:04] awight: yeah, I was saying if it is_string, we don't even check for callable [20:34:10] Fundraising Sprint UB40, Fundraising Tech Backlog, Fundraising-Backlog: EXTERNAL: Worldpay HCG search by email address - https://phabricator.wikimedia.org/T114183#1743790 (DStrine) [20:34:11] Sort of a crazy edge case, it was annoying me but I'm not worried [20:34:13] so you have to use a closue [20:34:20] awight: thx! [20:34:22] closure [20:34:29] ejegg: hrm. I don't quite like either option there [20:34:53] wanna merge what you have, then we can look at extending it? [20:35:24] either proliferating code in CentralNotice.php, or adding PHP classes for new mixins just to set a default [20:35:51] yeah, I think being able to set a static default is a small win at least [20:36:17] want to make it as easy as possible to switch to mixins [20:36:25] totally. [20:36:40] The closure thing appeals to me, but we're about to put that whole structure into extension.json.... [20:36:46] ooh, right [20:37:03] Maybe I'll just calculate the default at runtime for now. [20:37:05] I still like defining it all in JS [20:37:17] me too, except the client module shouldn't have any admin stuff [20:37:25] so, it's still an additional module [20:38:15] yeah, I guess even just defining params is some overhead [20:39:05] maybe it's a single 'mixins.admin' module - same sort of central registration as we're doing with the global [20:39:17] Definitely want to keep the implementation very understandable and free of boilerplate. [20:39:26] we need to at least list them all someplace central [20:39:33] The registration actually strikes me as a wart :-/ [20:39:55] scan a mixins folder? [20:42:53] awight: ejegg: wow looks like you guys are really going somewhere w/ that default stuff! :) What is it that's going in extension.json? (I haven't followed changes in that bit...) [20:43:09] AndyRussG: most of what's in .php! [20:43:20] no way! [20:43:47] so all declarative early-start config!? [20:43:54] yah! [20:44:01] cool! [20:44:45] Yeah I did see an extension.json patch fly by there but I didn't get a chance to dig in... [20:44:55] ejegg: the cn.registerCampaignMixin thing makes the dependency two-way which is silly. AFAICT it only exists to make it easier to find the mixin module after it's already been loaded--by code which specifically knows of its existence and which campaigns that mixin runs on. [20:45:02] But I don't know better .js patterns [20:45:28] AndyRussG: the catch with extension.json has just been the if(infrastructure) conditional initialization, but I think Paladox solved it! [20:45:29] hmm, something like AMD or require comes to mind [20:45:31] We just have to test his work [20:45:39] ejegg: totally [20:45:54] K [20:46:35] AndyRussG: tried to ping about that last night during my Phabricator spree... [20:46:48] I think we should get the extension.json stuff through like *now* [20:47:03] cos, it's pretty much done, and I don't want to rebase in January [20:47:09] awight: heh I just saw an avalanche of Phab messages and got scared 8p [20:47:13] awight: but if we want things packaged up nice by RL, I think we're doomed to registering them up front [20:47:17] That's a sane response [20:47:55] ejegg: I'm pretty sure we could say centralnotice[mixin] or something [20:47:55] awight: heh who knows if it's sane... we could also put it into the sprint in any case [20:48:54] awight: hmm, not sure what you mean [20:49:11] Meaning, the campaign knows exactly which mixins are enabled on it [20:49:37] So the CN controller can do something like foreach ( mixins ) register(rl.something[mixin]) [20:49:47] right... and dynamically defines all the RL modules, not just the dependencies [20:49:52] ... just a bit of boilerplate to kill [20:49:58] ok, cool [20:50:09] hmm, yeah I hadn't thought about mixins vs rl modules [20:50:45] (PS4) Awight: Allow mixins to specify default parameter values [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247637 (owner: Ejegg) [20:51:28] (CR) Awight: [C: 2] "Perfect for static defaults!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247637 (owner: Ejegg) [20:54:11] (Merged) jenkins-bot: Allow mixins to specify default parameter values [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247637 (owner: Ejegg) [21:48:24] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Prepare queue messages for testing on upgraded Civi. Test them. - https://phabricator.wikimedia.org/T114466#1744005 (Ejegg) Ran another batch of 15 in each version with the general... [21:52:02] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Record actual amount charged regardless of what's in session - https://phabricator.wikimedia.org/T115171#1744007 (cwdent) With Worldpay ESOP we don't send the amount in... [21:52:21] hey ejegg|afk, awight does this make sense? ^^ [22:14:23] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Record actual amount charged regardless of what's in session - https://phabricator.wikimedia.org/T115171#1744079 (awight) Note from our conversation: there is logic to... [22:22:49] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, Patch-For-Review: Convert CentralNotice to use extension registration - https://phabricator.wikimedia.org/T108721#1744094 (awight) [22:25:40] (CR) Awight: [C: -1] "Thing I just noticed--we need to move the missing comments into a README." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186899 (https://phabricator.wikimedia.org/T108721) (owner: Awight) [22:31:50] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Use translatable pages for banner content - https://phabricator.wikimedia.org/T116235#1744136 (awight) NEW [22:51:56] AndyRussG|school: hey, is it a convenient time to do voice as well? [22:53:18] awight: yeah! one sec :) [22:55:27] AndyRussG: here's the old config I removed, http://git.wikimedia.org/blobdiff/mediawiki%2Fvagrant.git/65b13e795d6fdbc5fc30f113704a601cd93daf96/puppet%2Fmodules%2Fpayments%2Fmanifests%2Fdonation_interface.pp [22:56:03] It won't work verbatim, needs to be adapted for DonationQueue... I'll do that in an example patch [22:56:29] *Oh* [22:56:53] awight: Hmm good for voice NEtime now btw [22:56:56] actually, I see now the defaults are just like production. Something I have been a clever monkey. [22:57:42] ejegg: it looks like my 2 simultaneous iframes have the same order_id [22:58:04] is that not supposed to be the case? [22:58:12] AndyRussG: not working... you wanna hangout at me? [22:58:22] awight: yeah trying! [22:58:38] cwdent: ooh, that sucks [22:58:53] but yeah, order ID is stored in session too... [22:59:12] i think adding the amount to the return url would work [22:59:22] cwdent: yeah, that sounds good [22:59:30] cool, thanks! [22:59:50] awight: I think it sent u an invite 8p [23:00:20] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Show large screen banner and then top screen banner without losing an impression - https://phabricator.wikimedia.org/T90919#1744249 (Ejegg) Thanks @PCoombe. Latest... [23:01:08] AndyRussG: https://hangouts.google.com/hangouts/_/wikimedia.org/activemq?hl=en [23:04:11] AndyRussG: http://git.wikimedia.org/blob/mediawiki%2Fvagrant.git/HEAD/puppet%2Fmodules%2Fpayments%2Fmanifests%2Fdonation_interface.pp [23:07:03] hello again! [23:12:40] awight: https://gerrit.wikimedia.org/r/#/c/244109/ [23:12:47] atgomez: hi! [23:20:15] http://payments.wiki.local.wmftest.net:8080/wiki/Special:GatewayFormChooser?uselang=de&language=de¤cy_code=EUR&country=LU&paymentmethod=paypal&bannerHistoryLogID=7e3e10b4fe899b7c [23:22:46] (CR) Awight: WIP add banner_history module (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/246425 (https://phabricator.wikimedia.org/T112022) (owner: AndyRussG) [23:31:54] Fundraising Dash, Fundraising Tech Backlog: Create sandbox site for Dash - https://phabricator.wikimedia.org/T87809#1744349 (chasemp) [23:32:47] fleeing! see you on Friday [23:51:29] hehe