[00:07:00] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Update Square Cash import for changed column names and additional info - https://phabricator.wikimedia.org/T129174#2120948 (atgo) Open>Invalid They've decided to not roll out these changes to our account af... [00:11:24] I love our logging! [00:12:35] as in the logging to IRC? [00:13:31] the syslog stuff... it so often tells me everything I wanted to know. [00:16:03] yeah nice [00:17:45] I've been daydreaming about a script which would take an order ID, and would return snippets from all logs that handled that transaction [00:17:53] this would be useful for audit stuff as well... [00:36:48] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: multiple errors when cancelling recurring Ingenico donations, and with refunds reaching Civi - https://phabricator.wikimedia.org/T128389#2121016 (awight) Looks like a simple fix, we were unable to s... [00:37:49] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: multiple errors when cancelling recurring Ingenico donations, and with refunds reaching Civi - https://phabricator.wikimedia.org/T128389#2121017 (awight) Tech note: fix the lookup issue, and rewrite... [00:38:00] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: multiple errors when cancelling recurring Ingenico donations, and with refunds reaching Civi - https://phabricator.wikimedia.org/T128389#2121018 (awight) a:awight [01:02:40] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: multiple errors when cancelling recurring Ingenico donations, and with refunds reaching Civi - https://phabricator.wikimedia.org/T128389#2121074 (awight) @MBeat33 > CID=14806142 Ingenico # 56316034... [01:12:27] (PS1) Eileen: CRM-18120 make acl query less debilitating [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277439 [01:12:29] (PS1) Eileen: CRM-18193 make unique ID for request available to php & mysql [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277440 [01:12:31] (PS1) Eileen: CRM-18178 exclude _bak & _backup tables from trigger creation [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277441 [01:12:33] (PS1) Eileen: CRM-18104 Hook for for defining log tables. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277442 [01:12:35] (PS1) Eileen: CRM-18180 allow non-standard table names in logging reports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277443 [01:14:13] (Abandoned) Eileen: CRM-18104 Proposal for hook for defining log tables [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/275614 (owner: Eileen) [01:16:12] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: multiple errors when cancelling recurring Ingenico donations, and with refunds reaching Civi - https://phabricator.wikimedia.org/T128389#2121091 (awight) @MBeat33 > update 2/7: we have another recu... [01:16:27] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: multiple errors when cancelling recurring Ingenico donations - https://phabricator.wikimedia.org/T128389#2121092 (awight) [01:21:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Warn us if a donor has multiple subscriptions - https://phabricator.wikimedia.org/T129957#2121094 (awight) [01:26:11] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Update Square Cash import for changed column names and additional info - https://phabricator.wikimedia.org/T129174#2121111 (atgo) @dstrine how we we track this? Should it be in "done" or removed from sprint...? [01:28:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: civicrm.wmo is missing the Logout button - https://phabricator.wikimedia.org/T129959#2121125 (awight) [01:48:44] (PS1) Eileen: Add CiviCRM activity to put against the deleted contact [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277447 (https://phabricator.wikimedia.org/T119246) [01:58:26] (PS1) Eileen: CRM-18134 move api merge activity contact function to the BAO [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277448 [01:58:28] (PS1) Eileen: CRM-18106 create activity against contact deleted by merge [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277449 [01:59:53] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi should record merge activities on both old and new contacts - https://phabricator.wikimedia.org/T119426#2121164 (Eileenmcnaughton) [02:00:29] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi should record merge activities on both old and new contacts - https://phabricator.wikimedia.org/T119426#1826269 (Eileenmcnaughton) I just brought this in the sprint because the fix for this is among... [02:01:04] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi should record merge activities on both old and new contacts - https://phabricator.wikimedia.org/T119426#2121166 (Eileenmcnaughton) a:Eileenmcnaughton [02:02:21] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi should record merge activities on both old and new contacts - https://phabricator.wikimedia.org/T119426#1826269 (Eileenmcnaughton) This is for activity type creation https://gerrit.wikimedia.org/r/#... [02:49:33] (PS1) AndyRussG: Admin UI: Move JS and CSS for campaign pager to RL module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277453 (https://phabricator.wikimedia.org/T128869) [07:02:33] Fundraising-Backlog, FR-Smashpig: SmashPig maintenance scripts are failmailing inappropriately - https://phabricator.wikimedia.org/T129966#2121467 (awight) [07:05:17] Fundraising-Backlog, FR-Smashpig: SmashPig maintenance scripts are failmailing inappropriately - https://phabricator.wikimedia.org/T129966#2121480 (awight) [07:05:54] Fundraising-Backlog, FR-Smashpig: SmashPig maintenance scripts are failmailing inappropriately - https://phabricator.wikimedia.org/T129966#2121467 (awight) [09:28:34] Wikimedia-Fundraising, Operations: Add /fundraising to dumps.wikimedia.org - https://phabricator.wikimedia.org/T42847#464766 (ArielGlenn) Open>Resolved Well the changeset above was long since merged, so I am closing this ticket. [09:28:53] Wikimedia-Fundraising, Datasets-General-or-Unknown, Operations: Add /fundraising to dumps.wikimedia.org - https://phabricator.wikimedia.org/T42847#2121699 (ArielGlenn) [10:58:11] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice table no longer sortable - https://phabricator.wikimedia.org/T129992#2122056 (Pcoombe) [11:15:27] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice table no longer sortable - https://phabricator.wikimedia.org/T129992#2122040 (Sjoerddebruin) This only seems to affect the date columns. [11:17:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice table no longer sortable - https://phabricator.wikimedia.org/T129992#2122167 (Pcoombe) It's definitely affecting all columns for me (I used to sort by name to view all Fundraising campaigns together). [11:18:32] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice table no longer sortable - https://phabricator.wikimedia.org/T129992#2122181 (Sjoerddebruin) What browser (including version) are you using? Are the sort buttons visible? [11:30:04] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice table no longer sortable - https://phabricator.wikimedia.org/T129992#2122212 (Pcoombe) Chrome 49 on Mac OS X El Capitan. The sort buttons aren't visible. Don't see any errors in the javascript console. {F3637103} Sorting works fine o... [13:08:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2122357 (Jgreen) >>! In T111704#2120246, @Eileenmcnaughton wrote: > @Jgreen how feasible is the sort of extra disk use mentioned above? https://phabricator.wikimedia.org/T11170... [14:29:06] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice table no longer sortable - https://phabricator.wikimedia.org/T129992#2122040 (AndyRussG) This was caused by the [[ https://meta.wikimedia.org/w/index.php?title=MediaWiki%3ACentralnotice-summary&type=revision&diff=15438606&oldid=154165... [14:36:16] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice table no longer sortable - https://phabricator.wikimedia.org/T129992#2122532 (AndyRussG) As a temporary workaround (I don't have permission to edit that text) you can [[ https://meta.wikimedia.org/w/index.php?title=Special:CentralNoti... [14:36:42] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice table no longer sortable - https://phabricator.wikimedia.org/T129992#2122534 (AndyRussG) [14:50:16] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice table no longer sortable - https://phabricator.wikimedia.org/T129992#2122569 (AndyRussG) Ooops! Looking at this more closely, the extra closing div tag that w... [15:16:59] hi cwd, got a couple smashpig things in review, but i need to test that one with the 'captured' flag [15:17:47] just writing something to generate matching pending queue and IPN messages [15:18:11] fun :) [15:19:09] i remember i had the same kind of pending flag logic before and got exceptions, but they may have been because of the bugs we've fixed in the meantime. [15:19:57] ejegg: do you mean regarding those CANCELED rows? [15:21:33] nah, that's a whole nother issue [15:22:17] so, adyen sends cancel ipn messages, and we expect a class to exist for each message type [15:24:29] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Update Square Cash import for changed column names and additional info - https://phabricator.wikimedia.org/T129174#2122699 (DStrine) @atgo let's keep it in. Some time was spent on it so it should count towards ou... [15:26:51] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi should record merge activities on both old and new contacts - https://phabricator.wikimedia.org/T119426#2122713 (DStrine) [15:27:43] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice table no longer sortable - https://phabricator.wikimedia.org/T129992#2122717 (Glaisher) Open>Resolved a:Glaisher [[ https://meta.wikimedia.org/w/inde... [15:30:02] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice table no longer sortable - https://phabricator.wikimedia.org/T129992#2122728 (Pcoombe) And sorting is working again. Thanks @AndyRussG and @Glaisher! [16:01:45] hey AndyRussG joining? [16:01:56] atgomez: yyep! one sec [16:12:16] dstrine AndyRussG notes: http://etherpad.wikimedia.org/p/fundraising_call_with_wmde [16:32:00] ah! I didn't see the notes doc until just now [16:38:38] it's all good [16:43:20] anyone had any luck running tests in vagrant? i see "Fatal error: Function already defined: wfEntryPointCheck in /vagrant/mediawiki/maintenance/Maintenance.php on line 26" ... that dir makes me think this might be another multiversion quirk [17:00:38] cwd aargh, i remember working around that somehow, but I can't find the evidence [17:00:49] might have been on the other box I was using for a while [17:01:13] but yeah, it was definitely a multiversion thing screwing with running tests in our own mw dir [17:02:48] dern it [17:19:55] (PS1) Ejegg: Add script to fake Adyen queue/IPN messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/277551 [17:20:10] cwd Adyen data generator ^^ [17:20:26] I just need to set up a fake API endpoint to test the capture jobs [17:21:31] or... mock the API object [17:22:36] nice, that will be really helpful [17:27:23] cwd: oh, hey [17:27:28] long-term fixes, huh [17:27:41] wassup [17:34:12] Feel like chatting about how to dig out of this mess? [17:34:25] love to [17:34:52] Another strategy I wanted to highlight is, to consolidate all the business logic and decouple it from the support code [17:35:17] declarative syntax would be ideal, and we can do that incrementally [17:36:03] maybe we should also reconsider the subclass thing, and use hooks instead? [17:36:11] meh [17:36:17] yeah totally, you had a patch that was a huge leap in the right direction, but maybe small steps [17:36:22] yes [17:36:38] That was the manic week before Mari was born... [17:36:43] hehe [17:36:44] (PS1) Ejegg: WIP mock Adyen API for tests [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/277554 [17:36:46] to justify how crazy I was [17:36:54] perfection is the enemy of good enough, or whatever they say [17:37:01] hehe [17:37:26] but yeah there is a lot of "low hanging fruit" like just pulling the giant arrays out of the adapters [17:37:43] yepyepyep [17:37:44] put them in some json or something [17:37:45] yes. If we can't get rid of the debt code, at least we can take the clean stuff and put it somewhere safe [17:37:55] that would be so easy. [17:38:13] there's a small amount of php code inside them we'd have to refactor [17:38:35] i think just visually separating it will clear up what a lot of the problems are [17:38:47] i lose track of what i'm looking at [17:38:58] exactly, anything that shinks those files will be a great help [17:39:09] if i have a strength as a programmer i think it's that i'm not really very smart and can't tolerate much complexity [17:39:29] that and laziness will ge tyou to the top [17:39:40] ejegg: We'll probably want to continue supporting both declarative and imperative, so maybe we don't have to do anything about the code snippets immediately [17:39:51] > just visually separating [17:39:52] hell yeah [17:40:35] I'd really like to move towards composition at the same time [17:40:51] yeah! [17:41:32] maybe the stage_ stuff can be grouped into logical classes, and during initialization an adapter assigns itself a list of staging helpers [17:41:56] that's a trivial implementation, since all stage_ calls go through a single function [17:41:56] a practical question: do we want to have a sub directory of each adapter called config? [17:42:03] definitely the curl / retry stuff should go into another class [17:42:03] mmm [17:42:22] depends how many config files we need [17:42:22] "config" sounds very run-time [17:42:48] ejegg: +1 http helpers as its own thing [17:43:34] cwd: We never, ever want to change 99% of what adapters do, fwiw. [17:44:21] let's... each grab one of these potential directions and code a prototype today... [17:44:24] ? [17:44:57] awight: hehe, I like it! [17:45:01] yeah [17:45:16] awight: definitely, the functionality is not the problem [17:45:26] and any large scale rewrite would go nuclear with functionality [17:45:58] though i imagine some weird bugs will just disappear with incremental refactoring [17:47:53] I'lll take a stab at the http stuff [17:48:23] i'd be happy to just try pulling some config out [17:48:27] errr..whatever it's called [17:51:23] Fundraising-Backlog, fundraising-tech-ops: Put faulkner database on ice - https://phabricator.wikimedia.org/T130039#2123392 (awight) [17:51:36] cwd: ejegg: call a piece! [17:51:46] oh sorry, my screen wasn't refreshing [17:52:13] awight: are you at all familiar with mw-vagrant using a hacked multiversion setup for mediawiki-fr and it being kind of painful? [17:53:42] I gotta reconnect, one moment [17:55:00] That was odd. [17:55:08] cwd: what do you mean by, "hacked"? [17:55:40] cwd: which config you wanna pull out? maybe the paymentmethods? [17:55:51] yeah that sounds good [17:56:01] I can do the stage_ functions, if y'all agree that it's a good idea [17:56:06] I'm not 100% certain it is. [17:56:08] awight: well...for instance it doesn't serve static assets from the right place [17:56:24] hmm? [17:56:32] which might mean it's *less* hacked than the live one, i don't know [17:56:45] ah, your multiversion [17:56:53] the dirs in /var/www/w are symlinked to /vagrant/mediawiki [17:56:54] That might be the case [17:57:06] ooh, so you can't get the -fr static files? [17:57:14] right, unless you relink em [17:57:16] which is what i did [17:57:20] but then the regular wiki is broke [17:57:20] wowza [17:57:28] No, I'm not fermiliar with that [17:57:43] i got pointed to https://github.com/wikimedia/operations-mediawiki-config/blob/master/w/static.php [17:57:50] but became quickly confused [17:58:07] cwd: heh. Did you file a bug about that yet? [17:58:16] I know we get *some* of our static files correctly [17:58:37] * awight marvels at bd808's conjuration highlighter [17:58:45] in theory it shouldn't be too hard to add the apache rules and router script for that [17:58:47] "goddamn vagrant" [17:58:49] :D [17:58:52] awight: I ping on "vagrant" [17:59:13] bd808: heh was gonna try and not mention [17:59:20] oops! [17:59:25] I was following this vagrant on a tour of the Chicago train yards, ya see... [17:59:26] i'll say v4gr4nt [17:59:33] None of your bizness! [17:59:33] cwd: no worries :) [17:59:57] i wasn't sure if this was really a bug or expected edge case functionality [18:00:21] it's a missing feature from what we did to support your branch [18:00:49] and now we have magic to steal from to fix it :) [18:01:18] ah right on, if it's worth supporting both wikis on the vagrant role. has that been talked about? [18:01:27] having it just switch to payments for the fr role? [18:01:55] cwd: I think they're interested in keeping both wikis even when using the fr role. [18:02:08] That way we can attract casual devs, without ruining their mw-core setup [18:02:19] (PS1) Awight: Move GatewayType interface into its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277559 [18:02:34] yeah. we built quite a bit of plumbing for it already [18:02:41] bd808: the thread i was pulling on led me to resource loader (the js i was writing is RL module) and i felt over my head [18:02:43] awight: that's a great first step [18:03:09] ejegg: which one? the great stage_* diaspora? [18:03:25] hmm... RL shouldn't care. It should be using $IP to find things which should be setup correctly [18:03:25] nah, just the GatewayType extraction [18:03:28] ah [18:03:44] ejegg: please do lmk about stage_*, cos I'm only partly convinced [18:03:50] ...not that we implement that anywhere else [18:03:56] but certainly any static asset stuff is busted [18:04:18] ejegg: Well, we should use that as the type hint in other components [18:04:30] bd808: ok good to know, RL is a magic box afaik [18:04:42] (CR) jenkins-bot: [V: -1] Move GatewayType interface into its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277559 (owner: Awight) [18:04:49] cwd: you are not alone in that ;) [18:05:13] awight: not sure exactly what stage_ stuff you mean [18:05:22] mostly RL == load.php == javascript/css preprocessor [18:05:47] ejegg: I'm considering tearing out all staging functions into helper classes, then the adapters will manage them as an array of helper objects [18:06:33] ahh, this is towards that generalized data transforms goal, huh? [18:06:42] meh, it's just to clean up the adapter classes [18:06:47] for now [18:07:30] hmm, sometimes staging is a simple transform, but sometimes it needs random info from the adaptor [18:07:45] like in Astropay, staging inspects the payment_methods array [18:07:51] or payment_submethods [18:07:53] it can have access to the adapter object [18:08:00] ok [18:08:07] although... circular dependency, huh [18:08:20] yeah, not super cool [18:09:25] * awight glares at 3kloc GlobalCollect adapter [18:10:28] cwd: Agreed that a subdirectory with a separate file per define* map would be ideal [18:11:12] is config to runtime-y? seeing as runtime is the only reality in our poor language [18:11:17] cwd: How should we handle fields like 'x_description' => WmfFramework::formatMessage( 'donate_interface-donation-description' ), [18:11:27] cwd: I'm fine with config" [18:11:32] *" [18:11:54] awight: you mean cause it has procedure built in? so json wouldn't fly [18:11:59] also, 'x_trans_key' => $this->accountInfo['Create']['Password'], [18:12:18] well, for that i'd say accountInfo should also be extracted [18:12:30] no? [18:12:32] well. Maybe for the first iteration, we extract just one define* function into json, payment_methods seems eminently static [18:13:04] cwd: I think you're right [18:13:13] if we could use short array syntax i would have no problem with them being php files [18:13:15] however, how to reference one config from another? [18:13:20] screw that [18:13:41] * cwd mutters something about puppet [18:13:45] * cwd ducks [18:13:49] hehehe [18:13:51] yaml. [18:14:02] you can do dynamic includes and stuff [18:14:03] backwards compatible with json... [18:14:07] yah [18:14:20] although, if we need message strings it's looking like code again [18:14:30] I'd rather not create a DSL [18:14:38] uh huh [18:14:54] maybe, there is a hook to touch-up all the declarative data with a few code lookups [18:15:23] hmmm... [18:15:30] or a compile step [18:15:45] but that's scope creep as fuck [18:15:49] yup [18:16:29] maybe i'll just try the payment methods for one adapter and see if a solution presents itself [18:16:55] Exciting! [18:23:50] wat, we save communication stats to a db table??? [18:24:36] !!? [18:24:40] not cool [18:24:49] well, it's an option [18:25:47] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277559 (owner: Awight) [18:25:57] * awight jiggles the toilet handle [18:26:57] ejegg: I'm thinking, maybe the staging helper paradox is not actually a circular dependency. I'd be accessing GatewayType and not the concrete class [18:27:46] Fundraising-Backlog, MediaWiki-Vagrant: MW-vagrant multiversion issues for mediawiki-fr - https://phabricator.wikimedia.org/T130046#2123567 (cwdent) [18:27:49] awight: ok, that sounds good [18:28:00] bd808: just made that task ^ [18:28:34] i am happy to keep it on my radar and try to roll up a fix, it may take me awhile, but would increase my general mw-fu [18:29:03] unless it's urgent for some reason i don't know, we can hack around it for now [18:32:41] ejegg: need help. Can you remind me how to submit a patch which relies on a change to the vendor dir? [18:33:36] talk about circular dependencies... [18:33:38] awight: oh man [18:33:42] ummm [18:33:47] it's been a while [18:33:59] the production branch vendor can't have this change until the DI code is merged :,-| [18:35:10] err, so, CI isn't running composer for DI, huh [18:35:34] nooo [18:35:41] oh [18:35:49] no [18:36:41] dang, what /have/ we been doing? [18:36:49] * awight facepalms [18:36:56] too much tech debt to even get started [18:37:26] * awight twiddles resume... ;) [18:37:27] yeah, i'm pulling out the profiling stuff as a preliminary to the http helper... [18:37:43] nice [18:38:57] ejegg: I think this is a special kind of pain that we haven't run into before [18:39:06] aargh! [18:39:17] it's the composer autoloader battling the hardcoded DI classmap [18:39:38] aw jeez [18:39:39] splitting a class out of a multi-class file is causing it to load the original file twice, using the composer autoloader [18:39:54] * awight ignores [18:40:34] we obviously have to rearrange everything for psr4 compliance first [18:41:18] what I don't understand is, where the outdated composer classmap comes from. maybe just stale on the CI box [18:41:46] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277559 (owner: Awight) [18:41:53] awight: lemme see, i think that php53 job explicitly clones di/vendor [18:41:58] ooh [18:42:16] we maybe could make it run composer [18:42:29] that's going to be a problem, then. yeah. it needs to respect local composer.lock [18:43:13] fixing. [18:43:19] rockin! [18:43:57] ejegg, awight, how about this for a refactoring guideline: [18:44:37] if the patch i'm about to submit does not atomically reduce complexity, it should be broken down further. it's great to dream big, but a half finished refactor is worse than no refactor at all. [18:44:54] cwd I like it [18:44:57] +1 [18:46:49] and when an emergency comes up and you're suddenly distracted for a week [18:46:55] it sucks to deal with [18:47:34] speaking of that, what if we tried to do a quasi 20% thing that was just like, friday is debt day [18:47:40] since we try not to move mountains on friday anyway [18:47:55] I was just saying something like that. [18:47:56] yes [18:48:05] Tuesday should be a debt day as well [18:48:10] :) [18:48:24] i'm on board [18:48:25] it's already phab debt day, why not pile some php on [18:49:03] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277559 (owner: Awight) [18:49:07] live-hacked the job [18:51:22] (PS1) Ejegg: Move profiling out of adapter class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 [18:51:38] relocating for backlog grooming... [18:52:58] (CR) jenkins-bot: [V: -1] Move profiling out of adapter class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (owner: Ejegg) [18:53:14] i am going to write a sick regex to turn this php into yaml [18:53:20] perv [18:53:26] the little pleasures [18:53:27] I just use vi macros [18:53:44] yeah probably [18:53:49] awight: do you nvim yet? [18:54:06] vat [18:54:18] https://github.com/neovim/neovim/ [18:55:41] vim's source code is pretty amazing [18:56:01] I support "no new features" is a compelling reason to upgrade to nvim :p [18:56:05] *suppose [18:56:17] hehe [18:56:31] there are some improvements, some regressions, but i bet it will eventually be the real vim [18:57:58] but you will totally go "...oh that's nice" a few times during normal operation [19:02:35] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277559 (owner: Awight) [19:08:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Can we allow fallback to alternative campaign if mixin would hide this one - https://phabricator.wikimedia.org/T124969#2123770 (atgo) [19:09:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Can we allow fallback to alternative campaign if mixin would hide this one - https://phabricator.wikimedia.org/T124969#1971256 (atgo) p:Triage>Normal [19:10:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2123799 (DStrine) [19:10:28] Fundraising-Backlog, fundraising-tech-ops: Put faulkner database on ice - https://phabricator.wikimedia.org/T130039#2123392 (DStrine) [19:18:36] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (owner: Ejegg) [19:21:17] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Pull profiling code out of gateway adapter - https://phabricator.wikimedia.org/T130055#2123918 (Ejegg) [19:21:21] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog: Pull payment methods out of GC adapter - https://phabricator.wikimedia.org/T130056#2123936 (cwdent) [19:31:48] (PS2) Ejegg: Move profiling out of adapter class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (https://phabricator.wikimedia.org/T130055) [19:34:55] (CR) jenkins-bot: [V: -1] Move profiling out of adapter class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (https://phabricator.wikimedia.org/T130055) (owner: Ejegg) [19:49:28] huh, booted from hangout for 'authentication issues' and I can't get back in [19:49:57] Google does that to me sometimes too. [19:50:05] Meeting is still up though if you want to keep trying. [19:52:53] my computer has shit twice today [19:53:01] i guess it's >6mo old, time for the problems to start [19:53:08] #laptops [19:54:22] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (https://phabricator.wikimedia.org/T130055) (owner: Ejegg) [19:56:57] (PS3) Ejegg: Move profiling out of adapter class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (https://phabricator.wikimedia.org/T130055) [19:59:04] (CR) jenkins-bot: [V: -1] Move profiling out of adapter class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (https://phabricator.wikimedia.org/T130055) (owner: Ejegg) [20:00:58] Fundraising-Backlog, FR-Ingenico: Spike: do we need to make updates for accessibility with Ingenico changes? - https://phabricator.wikimedia.org/T130061#2124122 (atgo) [20:10:58] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Pull payment methods out of GC adapter - https://phabricator.wikimedia.org/T130056#2124189 (DStrine) [20:12:51] (PS4) Ejegg: Move profiling out of adapter class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (https://phabricator.wikimedia.org/T130055) [20:15:27] (CR) jenkins-bot: [V: -1] Move profiling out of adapter class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (https://phabricator.wikimedia.org/T130055) (owner: Ejegg) [20:15:41] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (https://phabricator.wikimedia.org/T130055) (owner: Ejegg) [20:16:19] i'm starving, gonna find some chow [20:16:32] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Pull profiling code out of gateway adapter - https://phabricator.wikimedia.org/T130055#2124218 (Ejegg) [20:19:18] woot, that's passing now [20:19:34] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277559 (owner: Awight) [20:25:42] (CR) Ejegg: [C: 2] "Nice! Looks like we'll want to add a few more functions to the interface when we start swapping out GatewayAdapter type hints." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277559 (owner: Awight) [20:27:18] (Merged) jenkins-bot: Move GatewayType interface into its own file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277559 (owner: Awight) [20:29:10] (PS5) Ejegg: Move profiling out of adapter class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (https://phabricator.wikimedia.org/T130055) [20:44:34] Fundraising-Analysis, Wikimedia-Fundraising-CiviCRM: Probably cause of failmail deadlocks - soft credit search pain - https://phabricator.wikimedia.org/T130068#2124330 (Eileenmcnaughton) [20:44:38] cwd: that profiling thing is ready for review [20:45:10] awesome [20:45:22] my v*grant is hosed for some reason [20:45:33] /etc/init.d/hhvm: 4: .: Can't open /lib/init/init-d-script [20:46:42] (PS1) Ejegg: Use GatewayType hints in a few places, add functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277600 [20:46:58] eew, sounds nasty [20:47:38] LOL [20:48:21] nm red herring [20:48:52] ejegg: How did you merge? force? [20:49:08] live hacked a bit more [20:49:28] nice one [20:49:35] used $WORKSPACE/src/extensions/DonationInterface instead of MW_INSTALL_PATH [20:49:42] Sorry! This site is experiencing technical difficulties. [20:49:44] Try waiting a few minutes and reloading. [20:49:46] (Cannot access the database) [20:49:48] db is fine [20:49:50] grumble [20:50:34] sudo tail -f /var/log/apache2/error.log /var/log/hhvm/error.log /var/log/syslog /var/log/mysql.err [20:50:37] none of those make a peep [20:50:48] cwd: look at the /vagrant/logs [20:52:18] don't see anything in there either [20:52:30] i mean there are files but they aren't changing [20:52:36] (CR) Awight: [C: 2] "Great idea!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277600 (owner: Ejegg) [20:53:09] cwd: $wgShowExceptionDetails = true; [20:53:09] ? [20:53:35] settings.d/00-debug.php [20:53:57] (PS2) Ejegg: Use GatewayType hints in a few places, add functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277600 [20:54:33] awight: no file there besides the example, i'll move that, do i then need to provision? [20:54:49] nah it's loaded at runtime [20:56:36] (CR) Awight: [C: 2] Move profiling out of adapter class (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (https://phabricator.wikimedia.org/T130055) (owner: Ejegg) [21:05:15] * cwd realizes he actually lost a lot of work when the laptop turned off [21:05:54] there needs to be a word for that type of shutdown where you're just typing along and suddenly the computer is off [21:10:08] (PS3) Ejegg: Use GatewayType hints in a few places, add functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277600 [21:13:05] (PS1) Ejegg: Call instance method 'cause we have an instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277608 [21:17:28] Can't connect to local MySQL server through socket '/dev/null' [21:17:31] GAH [21:17:37] i have no idea what is eating that exception [21:17:42] or why it just started happening [21:21:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Pipeline Report - https://phabricator.wikimedia.org/T128818#2124461 (atgo) We would need to add some fields to the Prospect tab in order to do this [21:22:14] Fundraising-Backlog: Civi should allow users to do email address changes that are communicated to Silverpop - https://phabricator.wikimedia.org/T122411#2124475 (CCogdill_WMF) Bringing this up again since we're in the Civi design meeting... this edit hook idea Elliott mentioned sounds promising :P This is sti... [21:25:10] (Merged) jenkins-bot: Move profiling out of adapter class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277564 (https://phabricator.wikimedia.org/T130055) (owner: Ejegg) [21:31:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Pipeline Report - https://phabricator.wikimedia.org/T128818#2086989 (Ejegg) From rating on down are all new fields. - Rating: number or dropdown (what values?) - Ask Amount: money (in USD?) - Expected Amount: money (in USD?) - Probability/Likelyhood: n... [21:32:15] bd808: weirdest thing, vagrant wiki started falling over with "Can't connect to local MySQL server through socket '/dev/null'" -- i added "hhvm.mysql.socket = /var/run/mysqld/mysqld.sock" to fcgi.ini and it came back to life. swear i didn't touch anything. have you seen that? [21:33:38] yeah. for a while our hhvm builds did not support mysql socket access. LocalSettings.php should be setting $wgDBserver = '127.0.0.1'; [21:34:18] If things started working with the hhvm config you mentioned then maybe the newest builds have socket support agian [21:34:33] but our Puppet config doesn't set the right stuff for it [21:34:46] aah yeah i did run into that before [21:36:52] cwd: you could add the setting under "hhvm::common_settings" in vagrant/puppet/hieradata/common.yaml [21:37:22] then at least a puppet run wouldn't wipe it out [21:38:02] bd808: i just changed dbserver to 127.0.0.1, it was blank, no idea what happened to my LocalSettings [21:38:27] my laptop randomly turned off and when it came back my vagrant wiki is broken [21:38:35] depends on which LocalSettings you mean :) mw-vagrant has some messed up config stuff [21:38:56] I meant the one in the root of the mw-vagrant clone [21:39:00] i'm looking at the one for -fr now [21:39:02] yeah that one [21:39:37] must be the solar radiation today [21:40:27] but yeah fixing dbserver there and removing it from hhvm conf works fine [21:41:51] script path is gone too! i dunno wtf [21:42:32] that should get set by the multiversion code [21:42:57] * bd808 sees cwd wandering a desert of mw-vagrant config files [21:43:37] * cwd wraps shirt around head [21:49:37] Fundraising-Backlog: Civi should allow users to do email address changes that are communicated to Silverpop - https://phabricator.wikimedia.org/T122411#2124571 (CCogdill_WMF) p:Normal>High [21:50:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#2124589 (DStrine) [21:52:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changing email address in Civi should be exported to Silverpop - https://phabricator.wikimedia.org/T122411#1903592 (DStrine) CCogdill says that all we really care about is that the old email is added to our unsubscribed list. Eileen points out that we... [21:53:57] bd808: this whole time i was ignoring perhaps the greatest feature of vagrant, the ease of nuke and pave [21:54:29] cattle, not pets [21:55:01] nice [21:56:05] cwd: yes! tear the roof off [21:56:08] drop database [21:59:41] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Move staging functions into helper classes - https://phabricator.wikimedia.org/T130075#2124621 (awight) [22:01:42] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Move staging functions into helper classes - https://phabricator.wikimedia.org/T130075#2124642 (awight) [22:07:24] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Technical-Debt: Move staging functions into helper classes - https://phabricator.wikimedia.org/T130075#2124661 (DStrine) [22:24:00] (PS1) Ejegg: Use GatewayType hints for everything in extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277676 [22:24:25] (PS4) Awight: Use GatewayType hints in a few places, add functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277600 (owner: Ejegg) [22:24:55] (CR) Awight: [C: 2] Use GatewayType hints in a few places, add functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277600 (owner: Ejegg) [22:25:03] (PS2) Awight: Call instance method 'cause we have an instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277608 (owner: Ejegg) [22:25:11] (CR) Awight: [C: 2] Call instance method 'cause we have an instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277608 (owner: Ejegg) [22:25:17] (PS2) Awight: Use GatewayType hints for everything in extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277676 (owner: Ejegg) [22:27:05] awight: that little change to conversion_log.body was to avoid adding deprecated methods to the interface [22:27:11] (CR) Awight: "U want to clean up the pass by reference fu?" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277676 (owner: Ejegg) [22:27:20] it's great! [22:27:46] tons of ref passing that we don't need, huh [22:28:05] ejegg: none of it--cos objects are always a reference in PHP [22:28:09] * cwd looks at vagrant provision terminal [22:28:11] sorry guys i suck [22:28:11] (arrays are not) [22:28:20] cwd: same here. Totally thwarted by other debt [22:28:38] i also nuked all the regexes i wrote when the laptop insta-offed [22:28:43] (Merged) jenkins-bot: Use GatewayType hints in a few places, add functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277600 (owner: Ejegg) [22:28:44] Let this be a moment we remember when trying to prioritize debt work [22:28:46] awight how about I do that in a followon [22:28:53] k sure! [22:28:55] (Merged) jenkins-bot: Call instance method 'cause we have an instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277608 (owner: Ejegg) [22:29:06] (CR) Awight: [C: 2] Use GatewayType hints for everything in extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277676 (owner: Ejegg) [22:29:42] pedal to the metal! [22:30:41] hah! that exact line just came up in some Iced Earth i was jamming to on KALX [22:31:11] iced earth was the first show i ever went to on my own [22:31:14] (Merged) jenkins-bot: Use GatewayType hints for everything in extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277676 (owner: Ejegg) [22:31:49] 16yo, driving to minneapolis [22:32:01] nice [22:32:02] evil! [22:32:21] the first like big out of town show anyway [22:32:23] * ejegg prepares his eardrums [22:32:32] there was plenty of shitty punk/crust in duluth [22:33:15] the punk record store was called Dull Youth [22:34:08] feeling old? :p [22:34:19] sigh [22:34:42] * cwd looks even sadder at vagrant provision window [22:34:48] back when record stores were real record stores [22:35:00] hey all, I'm going to run an errand and check back a little later. [22:35:49] see ya dstrine [22:35:51] have fun dstrine [22:36:15] i'm going to head home where the tubes are bigger, these clones are killing me, back soon [22:37:58] hehe [22:38:01] that sounded weird [22:58:38] (PS1) Awight: Simplify option value retrieval, fail fast [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277684 (https://phabricator.wikimedia.org/T128389) [22:59:00] (PS1) Ejegg: Add getFreeFormStopTransaction to GatewayType interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277685 [23:00:07] (PS1) Eileen: CRM-18246 Lybunt group clause not being included in temp table due to order of operations [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277686 (https://phabricator.wikimedia.org/T123671) [23:00:10] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: multiple errors when cancelling recurring Ingenico donations - https://phabricator.wikimedia.org/T128389#2124887 (awight) Moving to review, patch might plug the hole, and will... [23:00:47] (PS1) Ejegg: More type hints in extras, no passing objects by ref [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277687 [23:01:04] gonna step out for a bit [23:01:08] see ya! [23:01:19] cy'all later [23:01:29] (CR) Awight: [C: 2] Add getFreeFormStopTransaction to GatewayType interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277685 (owner: Ejegg) [23:03:36] (CR) Awight: [C: 2] More type hints in extras, no passing objects by ref (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277687 (owner: Ejegg) [23:06:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#2124908 (atgo) a:atgo>None [23:12:35] (CR) Eileen: [C: 1] "This makes sense to me. I looked in the code and the main area this would affect is" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277684 (https://phabricator.wikimedia.org/T128389) (owner: Awight) [23:15:17] (Merged) jenkins-bot: Add getFreeFormStopTransaction to GatewayType interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277685 (owner: Ejegg) [23:15:19] (Merged) jenkins-bot: More type hints in extras, no passing objects by ref [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277687 (owner: Ejegg) [23:15:25] (CR) Awight: "Yeah, I was feeling especially burned by silently corrupting things when we fail to find the "Failed" contribution status (due to the seco" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277684 (https://phabricator.wikimedia.org/T128389) (owner: Awight) [23:15:54] guh, provision keeps hanging on Notice: /Stage[main]/Mediawiki/Git::Clone[mediawiki/core]/File[/vagrant/mediawiki]/ensure: created [23:16:35] the next thing is probably the actual clone of mediawiki/core which is horribly slow [23:16:48] like 15m+ [23:16:59] (PS2) Awight: Simplify option value retrieval, fail fast [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277684 (https://phabricator.wikimedia.org/T128389) [23:17:22] cwd: try "PUPPET_DEBUG=1 vagrant provision" for a good time [23:17:28] bd808: thanks...i'm impatient [23:17:41] awight: +1 I was about to say [23:17:55] bd808: i was checking out the lxc back end earlier, what's your opinion? [23:18:06] I use it a lot in Labs [23:18:11] btw, you can clone the mw-core repos from your local box, just use git flags to create a totally independent repo (I forget which those are) [23:18:19] my laptop is OSX so not an option there [23:18:37] ah that's a good idea. shallow clones also came to mind [23:18:43] I guess you could [23:19:00] awight: got a sec to talk lybunt? [23:19:05] i figure no back end is going to be any faster since the bulk of the waiting is git cloens [23:19:07] eileen: sure! [23:19:12] shallow just differers the full history fetch until the first time you make a gerrit patch [23:19:27] cwd: keeping snoracle offa your box is quite an incentive, though [23:19:45] indeed [23:19:54] (CR) Eileen: [C: 2] "OK - pushing through then - if we DO catch too much we can change again without too much risk IMHO" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277684 (https://phabricator.wikimedia.org/T128389) (owner: Awight) [23:20:19] awight: this report on staging civicrm/report/instance/71?reset=1&output=criteria [23:20:24] is the core report [23:20:40] thanks for the CR! [23:20:45] :-) [23:20:56] Since the soft credit issue seems like a distraction... [23:21:20] I think the core report with the right boxes checked does everything the custom one does, faster [23:22:47] great! [23:23:00] * awight fumbles around to fire it up [23:23:02] IN which case it's a case of push through this https://gerrit.wikimedia.org/r/#/c/277686/ & then (probably manually) change the reports on live to use the core report... [23:26:45] (CR) Awight: [C: 2] "Awkward to rely on a side-effect, but it's not an issue unless we wanted to rewrite the top-level function in a subclass of Lybunt." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277686 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [23:27:21] eileen: Sure, or just delete and recreate so we don't have to worry about criteria being compatible. [23:28:21] (CR) Eileen: "Yeah - I feel like actually the Core_Report_Form function *should* call select & where before FROM - because it makes sense that you can't" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277686 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [23:28:47] awight: OK - I''ll push that out & alter the reports on live & get feedback [23:28:54] if all good I'll delete the custom report [23:29:12] I love to hear we can lop off our hack! [23:29:18] :-) [23:29:50] Donno about the general principle in your comment, though--maybe there should be a separate function initialize() or something [23:29:50] yeah - I definitely got myself very confused over thinking we had a soft credit regression when it was a 'never worked' [23:29:55] hehe [23:30:08] yeah initialize makes sense too [23:30:39] do you want to check this one too before I push that out https://gerrit.wikimedia.org/r/#/c/275615/ [23:31:29] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277686 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [23:31:53] (CR) Awight: Increase time out while doing exports (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/275615 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [23:33:01] (PS1) Awight: Simplify option value retrieval, fail fast [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277692 (https://phabricator.wikimedia.org/T128389) [23:33:10] (CR) Awight: [C: 2] Simplify option value retrieval, fail fast [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277692 (https://phabricator.wikimedia.org/T128389) (owner: Awight) [23:33:12] (CR) Eileen: Increase time out while doing exports (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/275615 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [23:34:14] eileen: Maybe try the export on staging, with a livehacked extra long timeout? [23:34:27] unless you feel confident about 300s... [23:34:56] awight: well the particular export I was testing was not much more than a minute [23:35:02] ah. cool! [23:35:11] 300 it is, then [23:35:23] I feel like we can change it again if need be [23:35:51] ini_get was bothering me just cos it might be set to 10m, in which case we actually want a shorter timeout [23:36:44] yeah - although we would want to assume that if someone has set it up we don't want to set it down over the top of that [23:37:01] ie. assume that the person who put it to 10 min did so for a reason [23:37:05] (Merged) jenkins-bot: CRM-18246 Lybunt group clause not being included in temp table due to order of operations [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277686 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [23:37:07] (Merged) jenkins-bot: Simplify option value retrieval, fail fast [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277692 (https://phabricator.wikimedia.org/T128389) (owner: Awight) [23:37:23] eileen: ah good point [23:37:35] lemme just... [23:37:39] (PS3) Awight: Increase time out while doing exports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/275615 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [23:37:51] (CR) Awight: [C: 2] "That works!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/275615 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [23:39:27] !log update crm from 090d443c856574d45c80f89c4ae7ccb86c97448f to 097bc2d298b93424ff07abb18eaf1cfb3f79a0f2 [23:39:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:39:46] zul is being pretty slow! [23:40:24] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/275615 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [23:40:59] looks pretty reasonable, https://integration.wikimedia.org/zuul/ [23:41:22] My standards have been eroded though [23:41:39] done now [23:45:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-NewFunctionality: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#2125001 (CaitVirtue) from Leanne: "We just want to make sure that an import would correctly assign the soft credi... [23:48:31] (PS1) Eileen: CiviCRM submodule update, lybunt, export [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277695 [23:49:27] awight: should I deploy that change of yours plus "2b03784 Thank You letters for executive director transition [23:49:27] " [23:49:33] while deploying my change? [23:50:11] no, please pick around it [23:50:19] I think that's supposed to go out on a schedule. [23:50:26] (something we should have mentioned in the commit msg) [23:51:06] OK - but the fail fast one should go shouldn't it? The one I just CRd [23:51:52] I deployed that a second ago, if everything went well [23:52:06] ah ok [23:52:57] (CR) Eileen: [C: 2] "Submodule update, self-reviewing" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277695 (owner: Eileen) [23:54:01] (PS1) Eileen: CiviCRM submodule update, lybunt, export [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277696 [23:55:38] (CR) Eileen: "merge commit, self-approved" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277696 (owner: Eileen) [23:55:49] (CR) Eileen: [C: 2] "merge commit, self-approved" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277696 (owner: Eileen) [23:56:29] Sorry about all the bookkeeping ;-) [23:58:20] (PS1) Awight: [WIP] Prototype encapsulation for staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) [23:58:22] cwd: lmk what you think! ^ [23:58:23] :-) [23:58:35] I feel like it's been a million years since I php'd [23:58:52] checkin... [23:58:57] it's a good feeling [23:59:10] not writing php? [23:59:13] yah [23:59:29] (CR) jenkins-bot: [V: -1] [WIP] Prototype encapsulation for staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) (owner: Awight)