[00:26:30] Fundraising-Backlog, Operations, Ops-Access-Requests: Access request: AWight access to iridium - https://phabricator.wikimedia.org/T142446#2535387 (MaxSem) Would access to stat100[23] with all the HTTP requests in Hive be better? [01:24:14] (CR) Eileen: [C: 1] "I can't figure out how to test this but I read the code and it seems to be explicitly setting a default of English where there is not othe" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303718 (owner: Ejegg) [06:53:50] (PS1) Eileen: CRM-19197 Stop Merge links from dropping the limit parameter [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/303766 (https://phabricator.wikimedia.org/T139964) [07:06:00] (PS1) Eileen: CRM-19198 Add form merge hook call to dedupe form [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/303767 (https://phabricator.wikimedia.org/T142008) [13:35:06] fundraising-tech-ops, Operations, ops-eqiad: Rack and setup Fundraising DB - https://phabricator.wikimedia.org/T136200#2536477 (Cmjohnson) Open>Resolved The server has been racked and cabled. [16:16:14] (PS6) Awight: Required limit of number of retry messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303611 (https://phabricator.wikimedia.org/T142028) (owner: Ejegg) [16:16:58] (CR) Awight: [C: 2] "Thanks!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303611 (https://phabricator.wikimedia.org/T142028) (owner: Ejegg) [16:17:10] (PS7) Awight: Requeue delayed messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302839 (https://phabricator.wikimedia.org/T142028) (owner: Ejegg) [16:18:42] (CR) Awight: [C: 2] "Great stuff!" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302839 (https://phabricator.wikimedia.org/T142028) (owner: Ejegg) [16:19:42] (Merged) jenkins-bot: Required limit of number of retry messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303611 (https://phabricator.wikimedia.org/T142028) (owner: Ejegg) [16:19:46] (Merged) jenkins-bot: Requeue delayed messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/302839 (https://phabricator.wikimedia.org/T142028) (owner: Ejegg) [16:20:12] Anybody else super annoyed at the fact that browser refresh doesn't pull in new Gerrit information ? [16:21:33] ejegg|away: btw there's one more piece before I can experiment with the new orphan rectifier: https://gerrit.wikimedia.org/r/#/c/300708/ [16:23:28] awight: what new information do you mean? [16:25:06] awight: blocker for that one is -1 https://gerrit.wikimedia.org/r/#/c/301521/2 [16:29:39] cwd: Like, when a new patchset or Zuul actions are received, you can't see them by refreshing the page, instead you have to mouse to the "updates from ..." bar in the lower corner [16:31:26] ah yes the gmail widget [16:32:59] hehe [16:33:03] well framed [16:33:10] awight: it must be if you are on an older patch set [16:33:13] and are refreshing that? [16:34:12] nah even without the PS number [16:34:27] terrible [16:34:31] It must be intercepting the refresh action, actually--maybe that's it, just a keystroke thing [16:34:49] yep. [16:35:50] F5 or ctrl R ? [16:37:28] ^R [16:38:43] yeah some really bad decisions in that UI [16:41:10] it's a lesson that you can't count on anything in this life [16:41:23] You can... count on UIs to be bad? [16:41:24] someone will always rebind ^R [16:41:50] the keyboard shortcuts are a thing i depend on websites to not do [16:42:50] It's so irresponsible... also confirms my theory that nobody else is using this garbage [16:43:12] it seems like it's pining to be a "desktop application" [16:43:24] like photoshop or something where people will nerd out on keyboard shortcuts [16:43:51] but if your code review interface is so complicated that it needs keyboard shortcuts then it is overcomplicated [16:44:07] It's fine IMO that it has shortcuts, but they aren't testing for the !@# modifiers [16:44:18] This is like 1980s programming. [16:45:11] yeah sure shortcuts are fine but not ^T and ^R [16:45:15] in a browser tab [16:46:13] I'm trying to understand the mindset of the developers... [16:47:51] https://gerrit.googlesource.com/gerrit/+/master/polygerrit-ui/ [16:53:17] What is that and why doesn't it introduce itself [16:56:10] awight: i think this is it: https://gerrit.googlesource.com/gerrit/ [16:56:28] but it's node and i think there are blockers for us [16:56:37] I spent about an hour trying to build gerrit locally. Never did happen [16:56:45] *UCK "buck" [16:56:49] damn [17:08:33] Fundraising Sprint Killing Time, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising-Backlog, and 2 others: IL donation form: CVV field only allows three digits, blocks AmEx donors - https://phabricator.wikimedia.org/T137811#2537108 (DStrine) [17:09:20] awight: what's the status with fundraising wiki? the patches from the ticket appear to have been abandoned [17:09:41] Fundraising Sprint Nitpicking, Fundraising Tech Backlog, Fundraising-Backlog, FR-ActiveMQ, and 2 others: DonationInterface normalized message format should match queue format - https://phabricator.wikimedia.org/T109819#2537116 (DStrine) [17:11:11] (PS3) Awight: Resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 [17:11:13] (PS11) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) [17:11:36] cwd: the .gitreview was on a release branch for some reason, so we had to cherry-pick over to master [17:12:44] oh i see, i am just not signed up for that rep [17:12:46] o [17:12:55] (CR) jenkins-bot: [V: -1] Resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [17:13:11] (CR) jenkins-bot: [V: -1] Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [17:13:57] hehe. my bad [17:15:49] (PS4) Awight: Resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 [17:15:51] (PS12) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) [17:18:11] (CR) jenkins-bot: [V: -1] Resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [17:18:15] (CR) jenkins-bot: [V: -1] Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [17:30:51] (PS5) Awight: Resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 [17:30:53] (PS13) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) [17:30:55] (PS1) Awight: Update composer libs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303832 [17:31:07] it's funny that we have a 1-click +2 but not a 1-click comment [17:31:16] good point [17:31:20] fire at will [17:31:31] once of those two things i really wanted [17:32:53] (CR) jenkins-bot: [V: -1] Resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [17:33:03] (CR) jenkins-bot: [V: -1] Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [17:33:09] (CR) jenkins-bot: [V: -1] Update composer libs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303832 (owner: Awight) [17:34:03] wat. [17:56:01] I suppose we should deploy this thing, then... [17:57:12] speaking of deploys, I was thinking of pushing the SmashPig updates out to see if the new DeletePending job works out [17:57:54] niice [17:58:43] that should use the same stuff as the current jobs queue right? is that a drush command? [17:59:03] same as the current jobs queue [17:59:35] which we may need to reconsider for the general case - I think each job needs to have its own config node information [18:00:00] so we don't need a different runner for each gateway [18:00:08] not needed just now, though [18:01:53] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/303843 [18:01:57] Fundraising-Backlog, FR-Paypal: Paypal donation below minimum amount causes failmail - https://phabricator.wikimedia.org/T142508#2537358 (MBeat33) [18:02:08] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/303843 (owner: Ejegg) [18:02:58] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/303843 (owner: Ejegg) [18:04:08] (PS1) Awight: Move and update FundraisingEmailUnsubscribe [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/303845 [18:04:44] (CR) Awight: [C: 2] Move and update FundraisingEmailUnsubscribe [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/303845 (owner: Awight) [18:05:02] !log updated SmashPig from 26a475bf5ae03d88ebc4c2fe9707d562d8e3afe3 to 081493d846ad3c1b063f794ca2303576157b27f2 [18:05:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:07:49] (Abandoned) Ejegg: Rearrange processing wrapper for dequeue loop [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/287872 (owner: Ejegg) [18:08:46] (Merged) jenkins-bot: Move and update FundraisingEmailUnsubscribe [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/303845 (owner: Awight) [18:10:17] !log rolled back SmashPig to 26a475bf5ae03d88ebc4c2fe9707d562d8e3afe3 [18:10:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:10:28] hm, trying to connect to the wrong db [18:11:33] ah damaged-db config? [18:12:01] ahh, yep [18:12:18] nice reflexes tho! [18:21:09] asking for a db rename too [18:21:21] pending->smashpig [18:21:42] !log update paymentswiki from b737b60c87da82543ab812ece4611c68af01307f to 4e6a68f9d0b98d9037f81b0c4d312831d7fe66bb [18:21:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:52:57] Fundraising-Backlog, FR-Smashpig: Create 'smashpig' database to replace 'pending' - https://phabricator.wikimedia.org/T142515#2537585 (Ejegg) a:Jgreen [18:54:56] !log disable pending-new queue consumer [18:55:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:59:58] (PS1) Ejegg: Fix 'use' statements and implicit fields [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303851 [19:00:00] (PS1) Ejegg: Improve phpdoc comments [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303852 [19:02:40] ejegg: cwd: https://gerrit.wikimedia.org/r/303854 when you can [19:03:25] ty! [19:04:15] :) [19:04:59] Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, and 5 others: Rewrite orphan rectifier to use the pending database and WmfFramework - https://phabricator.wikimedia.org/T141486#2500284 (awight) [19:05:58] (PS1) Awight: Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/303855 [19:06:11] (CR) Awight: [C: 2] Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/303855 (owner: Awight) [19:18:25] (Merged) jenkins-bot: Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/303855 (owner: Awight) [19:27:03] ejegg: did you do any specific XDebug config within your vagrant? [19:27:58] wireshark has been fun but not useful.... yet [19:28:27] AndyRussG: yeah, I added stuff to /etc/hhvm/fcgi.ini [19:28:36] It seems it might be a confusion between /vagrant/mediawiki-fr and /var/www/w/extensions [19:28:52] ejegg: huh I thought u had to use zend for xdebug [19:28:55] ooh, is your DonationInterface symlinked from there? [19:29:22] No, but IIRC the webserver was serving static resources from there [19:29:40] I did see that dir go over the XDebug wire but I'm not sure which side it was coming from [19:30:10] huh, i didn't do any path mapping inside vagrant [19:31:42] just pointed the remote_host to 10.0.2.2, remote_port to 9089 (I've got fcgi on 9000 on my external machine), set the idekey and remote_autostart, remote_enable, and remote_connect_back [19:31:55] some of those may be overkill [19:32:45] hmmmm [19:32:47] K thx! [19:38:32] !log update paymentswiki from 4e6a68f9d0b98d9037f81b0c4d312831d7fe66bb to 33de2ce5d7b040d733141fc12a74f70a81c09925 [19:38:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:50:07] I think it's a thing where somehow Eclipse or XDebug are automatically setting the wrong path map [19:52:28] grrrit-wm: help [19:53:30] Where's the config for grrrit-wm ? I furget... [19:54:36] labs/tools/grrrit [19:57:05] (PS1) Awight: Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/303859 [19:57:12] Fundraising-Backlog, FR-Paypal: Paypal donation below minimum amount causes failmail - https://phabricator.wikimedia.org/T142508#2537901 (MBeat33) [19:57:15] (CR) Awight: [C: 2] Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/303859 (owner: Awight) [19:57:47] !log updated SmashPig from 26a475bf5ae03d88ebc4c2fe9707d562d8e3afe3 to 081493d846ad3c1b063f794ca2303576157b27f2 [19:58:24] !log enabled fundraising pending queue consumer [19:58:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:01:12] (Merged) jenkins-bot: Update FundraisingEmailUnsubscribe submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/303859 (owner: Awight) [20:01:45] !log update paymentswiki from 33de2ce5d7b040d733141fc12a74f70a81c09925 to 6b1f3c278308f831a149c986d2269342f94e2a16 [20:01:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:01:58] !log rolled back SmashPig to 26a475bf5ae03d88ebc4c2fe9707d562d8e3afe3 [20:02:09] d'oh, deletePending had some goofs [20:04:23] AndyRussG: meeting? [20:09:33] (PS1) Ejegg: Use factory method instead of constructor for job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303862 (https://phabricator.wikimedia.org/T140959) [20:11:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM merge should not update before deleting record - https://phabricator.wikimedia.org/T142441#2537963 (awight) Open>Invalid [20:13:49] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, FR-Paypal, FR-WMF-Audit, Unplanned-Sprint-Work: PayPal audit date format changed? - https://phabricator.wikimedia.org/T142417#2537990 (DStrine) p:Triage>Unbreak! [20:15:39] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Form chooser should query gatway capabilities to route donation - https://phabricator.wikimedia.org/T131989#2538006 (Ejegg) [20:15:42] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Dismantle DonationInterface form settings and port restrictions to gateway method/submethod config - https://phabricator.wikimedia.org/T142111#2538005 (Ejegg) [20:18:53] Fundraising-Backlog, fundraising-tech-ops: Spike: decide what to do with shoot_banners script - https://phabricator.wikimedia.org/T142064#2538025 (awight) [20:23:07] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Clicking the credit card button multiple times loads duplicate iframes... - https://phabricator.wikimedia.org/T142059#2521233 (DStrine) p:Triage>High [20:28:27] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Clicking the credit card button multiple times loads duplicate iframes... - https://phabricator.wikimedia.org/T142059#2538065 (XenoRyet) a:XenoRyet [20:30:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Create UI for damaged message DB - https://phabricator.wikimedia.org/T142058#2538075 (Ejegg) @MBeat33 , what do you think of the existing interface? We'll need to rebuild it to get off of ActiveMQ, so it's a great time to rethink it. I... [20:37:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Create UI for damaged message DB - https://phabricator.wikimedia.org/T142058#2538087 (Ejegg) @MBeat, for more context: the damaged messages will be in a database instead of in separate queues. The table structure looks like this: | id... [20:58:26] (PS2) Ejegg: Use factory method instead of constructor for job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303862 (https://phabricator.wikimedia.org/T140959) [21:14:16] fr-tech does that patch look good to you? ^^^ [21:14:38] The issue is that the job is being re-created by the runner that reads it off the wire [21:15:23] but the deserialization calls the constructor with no arguments, [21:15:37] then rehydrates the object from an array of values [21:15:56] heheh [21:16:22] freeze-dried objects for vacuum teleportation [21:16:31] yah [21:16:57] i don't understand why we bother serializing an object, can't it just be an ID and an action? [21:17:17] some jobs need more than that [21:17:37] but isn't the stuff they need stored somewhere? [21:18:15] not always - for instance, the adyen capture job sends in some processor IDs that come in via the listener [21:18:42] wouldn't it be more robust to store that? [21:18:55] and the listener can't directly write to the pending db, so anything it wants to transmit needs to be encapsulated in a job [21:19:51] or at least needs to go out over the queue [21:20:40] anyway, I'd really like to get that re-deployed before the next meeting if possible! [21:24:48] (CR) Cdentinger: [C: 2] Use factory method instead of constructor for job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303862 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [21:25:53] (Merged) jenkins-bot: Use factory method instead of constructor for job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303862 (https://phabricator.wikimedia.org/T140959) (owner: Ejegg) [21:26:54] thanks! [21:27:02] sure thing [21:29:44] (CR) Eileen: "Note the upstream PR https://github.com/civicrm/civicrm-core/pull/8843" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/303766 (https://phabricator.wikimedia.org/T139964) (owner: Eileen) [21:31:06] (PS2) Ejegg: Fix 'use' statements and implicit fields [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/303851 [21:32:10] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/303919 [21:32:20] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/303919 (owner: Ejegg) [21:33:01] AndyRussG: awight meeting [21:33:12] gurrrgh [21:33:15] brt [21:33:35] dstrine: coming! [21:34:15] Fundraising-Backlog, fundraising-tech-ops, Spike: Spike: decide what to do with shoot_banners script - https://phabricator.wikimedia.org/T142064#2538348 (Danny_B) [21:34:27] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: Prioritized checklist of pre-December CentralNotice and related essentials - https://phabricator.wikimedia.org/T141918#2538349 (Danny_B) [21:34:47] can't find a room [21:35:24] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Security-General, Spike: Spike: Is the Verisign seal even PCI compliant? - https://phabricator.wikimedia.org/T140318#2538350 (Danny_B) [21:35:39] Fundraising Sprint Licking Cookies, Fundraising Sprint Muggle Baiting, Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, and 3 others: Spike: Monitor deployment of: Suppress CentralNotice ResourceLoader modules on Special and act... - https://phabricator.wikimedia.org/T139439#2538351 [21:36:12] Fundraising-Backlog, FR-ActiveMQ, Spike: Spike: Design delay handling - https://phabricator.wikimedia.org/T131282#2538354 (Danny_B) [21:36:26] Fundraising-Backlog, FR-ActiveMQ, Epic, Spike: Spike: Investigate potential for banner impressions rewrite - https://phabricator.wikimedia.org/T131278#2538357 (Danny_B) [22:01:25] (CR) Ejegg: [V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/303919 (owner: Ejegg) [22:02:38] !log updated SmashPig from 26a475bf5ae03d88ebc4c2fe9707d562d8e3afe3 to 5c180de6e424be10f9d61052c2c8dca7e0e825af [22:02:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:03:02] Is there anything pending review that you think I should be able to make sense of? [22:04:29] fr-tech seeing a lot of 'INVALID_MESSAGE Missing gateway' in drupal log [22:05:26] or rather in the 'error' log [22:06:44] (PS1) Eileen: Fix merge hook to work through UI too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303926 (https://phabricator.wikimedia.org/T142008) [22:10:36] Fundraising Sprint Nitpicking, Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Unplanned-Sprint-Work: Help setting up a Top Prospects report in Civi - https://phabricator.wikimedia.org/T113904#2538431 (Eileenmcnaughton) @RLewis we have a ticket in for the slowness https://phabricator.... [22:11:38] dstrine: just looking at Rosie's update re the pipeline report - we probably can create it on live now can't we? The main blocker is the slow group filter (I do have a fix for that locally) but she now says she doesn't want to filter on group [22:13:07] are you saying that the loading/ failing to load issues are because of the smart group? [22:13:19] yep [22:13:27] the way it builds the filter is slow [22:13:48] I have a fix to put up for review etc - but it seems that isn't blocking it now [22:14:40] Fundraising Sprint Octopus Untangling, Fundraising-Backlog: Create frack vm cluster - https://phabricator.wikimedia.org/T142533#2538452 (cwdent) [22:17:36] awight so… I should make that job regular through jenkins somehow? [22:18:02] eileen: yeah--looks like you already made the job, so it's just a matter of putting in the schedule eh? [22:18:33] (PS2) Ejegg: Fix undefined index errors in Mailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303718 [22:18:35] ok I didn't see it before but I'll look again [22:18:48] we should probably get that fix up ^^ [22:20:18] ejegg: this one ? https://gerrit.wikimedia.org/r/#/c/30371 [22:20:31] Eileen yeah if the group isn't needed then maybe just let her know that it should run better on prod? Was there anything else blocking her? [22:20:52] dstrine: I don't think so - but you created the report on staging didn't you? [22:21:06] so she might not know how to create it on prod [22:22:42] eileen this one: https://gerrit.wikimedia.org/r/303718 [22:23:28] ejegg: the patch reads perfectly to me but I don't know how to test [22:24:14] also, I wondered how it interacts with the handling in the wrapHtmlSnippet function for locale being null - it would mean it gets bypassed which is ? good? [22:25:40] eileen: i'm not sure either - awight, did you figure out how to test your phpmailer changes? [22:26:07] eileen: Build Triggers -> Build periodically -> Schedule, i believe [22:26:10] ejegg: nah [22:27:22] (PS3) Ejegg: Fix undefined index errors in Mailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303718 [22:28:45] well, the SmashPig updates seem to be sitting ok [22:28:54] (CR) Eileen: [C: 2] "OK - as mentioned on IRC none of us are quite sure how to test this - but on reading the code I'm comfortable that they are safe e-notice " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303718 (owner: Ejegg) [22:29:57] ejegg: that last change resolved my reservation [22:31:45] Fundraising Tech Backlog, Fundraising-Backlog: Convert FundraisingEmailUnsubscribe to use extension registration - https://phabricator.wikimedia.org/T108764#2538557 (Reedy) a:awight [22:31:51] (Merged) jenkins-bot: Fix undefined index errors in Mailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303718 (owner: Ejegg) [22:31:52] Fundraising-Backlog, Epic, Technical-Debt: [epic] Migrate fundraising extensions to the new format - https://phabricator.wikimedia.org/T95832#2538560 (Reedy) [22:32:00] Fundraising Tech Backlog, Fundraising-Backlog: Convert FundraisingEmailUnsubscribe to use extension registration - https://phabricator.wikimedia.org/T108764#1529881 (Reedy) Open>Resolved https://gerrit.wikimedia.org/r/#/c/303051/ [22:32:41] gonna deal with house stuff, back later! [22:33:54] cwd|afk: good luck, have fun!!! [22:34:06] Hummm now my Eclipse is crashing like a house on fire.... [22:36:58] thanks eileen [22:38:34] AndyRussG: I'm a fan of phpstorm / Intellij-Idea these days - I remember eclipse being a bit crashy [22:38:37] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303931 [22:38:48] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303931 (owner: Ejegg) [22:38:54] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/303931 (owner: Ejegg) [22:39:26] eileen: hmmm... Yeah... Since I've been on almost only FOSS software stack for 1.5 decades, I'm afraid I'm prejudiced against even trying... [22:39:48] I did give up on installing GNU/Linux on my wife's computer [22:40:05] My kids, however, are still in line for that "upgrade" ;p [22:40:53] AndyRussG: they do give WMF a free license …. [22:41:34] Right, but it's still closed-source/non-libre.... [22:42:10] phpstorm runs on Linux... [22:42:26] awight: right, but it's still closed-source/non-libre... [22:42:28] ah right I backscroll more [22:42:42] hehe I gave up on installing linux on people's computers [22:42:42] I am not dogmatic!!!!!!! rrrg [22:42:55] I just become their sysadmin immediately, it's not good. [22:43:13] Mari will appreciate it, u'll see [22:43:44] harrr [22:44:09] not sure if bash is a good first language tho [22:44:26] Spanish, English, French, Bash maybe not in that order [22:44:57] definitely not php, that definitely would put them on the road to perdition [22:45:56] !log updated civicrm from d9a765903ac682c0fbd329ced59f5ba3953970c9 to af0048c007ddf9e74c6bd15e50c73c3bd0942492 [22:46:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:46:59] eileen: btw I do appreciate the suggestion!!! don't mean to seem otherwise ;) [22:47:33] AndyRussG: that's fine - I used to use eclipse but it's slower [22:47:43] hmmm yeah I imagine [22:47:59] What I especially don't like about Eclipse is the bad JS hinting and outline view [22:48:46] And also that I have bad memories associated with a project I tried to write using the janky Eclipse GUI toolkit [22:49:11] swt noooooo! [22:49:37] But actually the PHP hinting, navigating thru classes, etc. seems decent [22:49:44] Might just because I refuse to leave the cave, tho [22:51:13] (CR) Ejegg: [C: -1] "Nice, I like only doing the filesystem stuff once per request! Just got one extra parameter left from an earlier revision." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/303699 (https://phabricator.wikimedia.org/T141948) (owner: Cdentinger) [22:51:45] gotta head out folks, have a good evening! [22:51:52] ejegg: cya! [22:52:18] I had phpstorm installed for a hot minute, but I found myself debugging the debugger. [22:52:23] Ran straight back to vim [22:52:35] ahh see that's the one I've been tempted to waste time learning [22:53:15] vim? totally worth the investment, in hindsight [22:53:20] hmmm [22:53:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ: Create UI for damaged message DB - https://phabricator.wikimedia.org/T142058#2538611 (MBeat33) Thanks, @Ejegg I mostly use the existing interface when looking up individual failmails. I've never acted on a record by selecting from Resen... [22:53:50] MBeat: I'm preparing to change the unsubscribe URL to point to a new server... should I wait until tomorrow so we can monitor this? [22:54:09] that would be great, I’m off soon [22:54:10] Back in the day I knew Emacs commands but I did like Eclipse better [22:54:31] MBeat: cool, tomorrow morning then! [22:54:39] ty awight [22:54:40] emacs will mangle your left pinky [22:57:17] After following cwd|afk's call into the IRC weeds of weechat/tmux/glowingbear, and finding it quite nice, further forrays into terminal-based hackerland seem appealing [22:58:53] back in a bit [23:05:23] Fundraising Sprint Octopus Untangling, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Decimal dates are breaking our queue consumer - https://phabricator.wikimedia.org/T140667#2472029 (awight) Last "fix" did not fix. [23:05:31] Eating that dogmatic fud again... [23:17:36] eileen: How do I set the limit parameter? I just tried the code via the normal find and dedupe UI, and got "Undefined index: limit" [23:17:50] should I purge the templates or something? [23:18:50] (CR) Awight: [C: 1] "Looks like an improvement, but I'm having trouble testing it." (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/303766 (https://phabricator.wikimedia.org/T139964) (owner: Eileen) [23:21:40] awight: in the url [23:21:49] but, actually there is a setting to give it a default [23:21:57] & then it shows up in the UI [23:22:36] it's kind of an unresolved issue - I didn't get a version done that was really prime time - but I wanted something to protect our DB [23:22:54] Maybe add error checking for !default, in that case? [23:23:08] How do I add the default locally? [23:23:24] (CR) Awight: [C: 2] Fix merge hook to work through UI too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303926 (https://phabricator.wikimedia.org/T142008) (owner: Eileen) [23:23:44] awight: just gound it - administer/system settings/misc [23:24:14] found it.... [23:25:02] At some point I should make that limit work with an offset & fix up the UI around it a bit more - but that depends on priorities I guess [23:25:15] hmm I'm still not getting the limit, lemme see... [23:26:16] nasty, I'm blocked from saving that form cos of some php.ini max file size nonsense [23:26:26] fixing [23:26:31] (Merged) jenkins-bot: Fix merge hook to work through UI too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303926 (https://phabricator.wikimedia.org/T142008) (owner: Eileen) [23:26:32] on the misc screen [23:26:51] yah I'm in there, just getting messed with by other required inputs [23:27:14] oh ok [23:30:00] argh, unable to run drush civicrm-upgrade-db [23:30:41] whee drop all & vagrant provision [23:32:01] I love that that works! [23:33:33] :-) [23:34:37] (CR) Awight: [C: 2] "Works! There's some non-prime-time trouble with the limit default, but not a blocker..." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/303766 (https://phabricator.wikimedia.org/T139964) (owner: Eileen) [23:37:17] (CR) Awight: [C: 2] "This makes it look so simple! Seems that the form params are indeed compatible..." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/303767 (https://phabricator.wikimedia.org/T142008) (owner: Eileen) [23:40:29] Jeff_Green: nvm my note about the paymentswiki web resource 404s. bubye! [23:45:12] (Merged) jenkins-bot: CRM-19198 Add form merge hook call to dedupe form [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/303767 (https://phabricator.wikimedia.org/T142008) (owner: Eileen) [23:46:00] (Abandoned) Awight: Update composer libs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303832 (owner: Awight) [23:46:45] awight: no worries. I got concerned my last round of package updates broke something, but it looks like either a mediawiki or other code change? [23:47:22] in other words...is this something that can be rolled back until monday or do I have to do something now? [23:47:54] (PS6) Awight: Update composer libs and resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 [23:47:57] (PS14) Awight: Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) [23:48:35] Jeff_Green: nothing new broke--I was using the "debug=true" URL param which a known bug on payments [23:49:07] (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303946 [23:49:08] awight gonna go back to vacant mode. text me if it turns out it needs addressing before monday! [23:49:29] (CR) Eileen: [C: 2] "submodule update - self-merging" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303946 (owner: Eileen) [23:49:50] (CR) jenkins-bot: [V: -1] Orphan rectification for Drush (SEE NOTES) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/300708 (https://phabricator.wikimedia.org/T141487) (owner: Awight) [23:49:52] (CR) jenkins-bot: [V: -1] Update composer libs and resolve global namespace conflict [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/301521 (owner: Awight) [23:57:48] (Merged) jenkins-bot: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/303946 (owner: Eileen)