[00:21:44] awight: trying locally as well, and I've apparently forgotten how to mark something for translation [00:21:56] you need [00:22:03] $wgGroupPermissions['admin']['translate'] = true; [00:22:12] ah, thx [00:22:14] also, I posted it on meta at the correct new location [00:22:16] https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_20161128 [00:22:22] ... still working on it tho [00:23:14] should it have those chunks between the paragraphs of the body of the email? [00:23:15] T44: Migrate Bugzilla attachments to Phabricator - https://phabricator.wikimedia.org/T44 [00:23:19] hehe [00:23:22] thanks stash [00:23:53] it should [00:24:06] those are the lovely Extension:Translate markers [00:24:21] ;) [00:24:58] https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_administration [00:25:47] ooh I think we're getting burned by slight changes in wiki parser whitespace handling. [00:26:21] oh man [00:26:40] hehe [00:26:43] worked around. [00:26:47] you don't want to see. [00:27:15] (PS1) Awight: [WIP] new thank-you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 [00:28:21] haha, you get if, but no else! [00:30:29] naughty haxor [00:30:36] turing tape that [00:30:39] Ah, are those missing

tags going to screw up the html version? [00:30:44] totally [00:30:58] txt also [00:32:01] oh actually the

is fine AIUI [00:32:17] Just as long as we don't have the

start tag in only one branch of a conditional [00:32:27] this one might be ok [00:34:00] hmm, make-thank-you is giving me ^A s around the greetings [00:37:11] (CR) Ejegg: [WIP] new thank-you letter (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 (owner: Awight) [00:38:05] ah, stupid thing needs doubled backslashes (or dolla signs) [00:38:38] fr-tech yeah the core branch that takes the train tomorrow, 1.29.0-wmf.4, is not cut. I asked on -releng, greg-g sed that indeed, just revert and re-apply later. I seem to remember on the call last week something being said about tagging for a later branch, or something vaguely like that, though the sound quality on my end was bad and I could just be imagining it...... [00:45:09] wat [00:45:13] does it? [00:46:31] yep :P [00:46:49] we're using $1 below, so might as well be consistent [00:48:15] aaargh [00:48:23] \$1 [00:48:28] cos php [00:48:36] but now it's throwing off the balance of

[00:48:38] s [00:54:34] (PS2) Awight: [WIP] new thank-you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 [00:54:48] k i need to deploy from home [00:54:51] see you in 1.5h [01:33:49] fr-tech: revert core change here: https://gerrit.wikimedia.org/r/#/c/324004 [01:45:58] (CR) Ejegg: [WIP] new thank-you letter (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 (owner: Awight) [01:51:43] Fundraising Sprint Stirring The Pot, Fundraising Sprint Testing on Production, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Spike: SPIKE: investigate level of completeness of civi deduped DB - https://phabricator.wikimedia.org/T146384#2829606 (Eileenmcnaughton) I have just re-run the q... [02:51:25] fr-tech opinions about doing the core revert in master or on the freshly cut branch tomorrow? [02:52:04] AaronSchulz prefers on the cut branch, ostriches in releng seems to like that better too (just chatting there now) but I feel like reverting in master would give us the benefit of a bit of betacluster time [02:52:08] hi! [02:52:34] I also said I don't particularly care that much ;-) [02:52:42] hey - just spotting that email by Michael - anyone looking at that? [02:52:48] Like, unless we *need* the change to exist in master [02:52:54] AndyRussG: Wait, how does the betacluster thing help? U mean, having betacluster match how production *should* be [02:52:57] ? [02:53:04] or more then point - should I try to make sense of it [02:53:16] ostriches: ah sorry if I misquoted! [02:53:49] Heh, close enough. I think in branch is easier, but at the same time I lack Strong Feelings(tm) about it :p [02:54:00] ;) [02:54:39] awight: just 'cause reverting on the branch pushes to prod a state of code that hasn't been integration-tested on a prod-like environment [02:54:46] eileen1: MBeat: very scary! [02:55:07] AndyRussG: yes totally. I think reverting on master is more sane [02:55:24] We can smoke test locally, but this involves multi-data-center object caching that is hard to replicate locally [02:56:25] eileen1: I think we should add that one to our "oh shit" checklist [02:57:02] However, on the flip side, it's just reverting MessageCache to the state it currently has on production, and it's unlikely that any other code introduced in this branch interacts in any way with what was added/what's being reverted [02:57:19] awight: MBeat so looking at the thread I think I need to look in our logs again for any evidence of notifications of those transactions having come in? (since ejegg[m] looked) [02:57:45] AndyRussG: the other thing that makes it more sane is that we won't be cutting it to the next branch by default--unless that's desirable? [02:57:57] eileen1: I think that's right [02:58:01] ty [02:58:15] awight: dunno. I think the idea was to wait for the lull, I think that's in 2 weeks? Though in 1 it might be lull-ish enuf? [02:58:38] mebbe not, the email campaigns are steadier IIRC [02:58:42] cos they are new audiences each time [02:59:10] On the flip flip side, if we go by K4's book of extreme caution, reverting on master would win [02:59:15] AndyRussG: The other option is just letting it go live and living life on the edge ;-) [02:59:26] -1 :) [02:59:54] ostriches: heheheh we've been trained only to do that January through October [03:00:00] I have a +10 charm on Code Review though ;-) [03:00:23] I see Heinous status returned from Amazon: InvalidOrderReferenceStatus [03:00:39] that's a bad status [03:01:11] It's heinous [03:01:18] eileen1: but that's a globalcollect transaction, isn't it? [03:01:32] yeah - I haven't spotted ingenico log yet [03:01:57] awight: lemme not distract further from payment processor issue fixings! ostriches: if Aaron, the author of the patch, doesn't have issues with reverting on master, I'm gonna suggest that [03:02:18] WFM [03:03:03] It sounded like he'd be okay with that, last we spoke [03:07:43] eileen1: d'oh. > By default, CiviCRM now disables the ability to import directly fro SQL. To [03:07:46] use this feature, you must explicitly grant permission 'import SQL [03:07:49] datasource'. [03:07:54] that's not a permission I'm aware of [03:08:05] (my cvupdb just failed...) [03:09:24] oh yeah that was a security update [03:09:30] eileen1: oops, nvm. bad submodule status [03:09:32] I'm ok now [03:11:06] argh. wmf_civicrm_update_7303 -> DB Error: already exists [03:11:43] that's weird cos it's a deletion [03:11:51] ah maybe it's the next one [03:12:15] I think this is failing, CRM_Core_DAO::executeQuery("ALTER TABLE civicrm_email_updates ADD INDEX index_id(id)"); [03:12:25] * awight considers blowing away db [03:13:06] no. that's a temporary table [03:13:34] worked the second time. I don't like [03:14:41] PHP Fatal error: Class 'DatabaseTasks_mysql' not found ....... [03:17:08] whatev. looks like I can get to the page I need [03:21:44] awight: are you still trying to get the thank you letter out? [03:22:14] yep [03:22:26] don't worry, I haven't even scratched an 8hr day yet [03:22:46] do you have everything you need? [03:22:53] are others needed for this? [03:23:36] (CR) Awight: [C: -1] "Dang. "$1" really doesn't seem okay because it should be interpolated by variable substitution before preg_replace gets a hold of it. I " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 (owner: Awight) [03:23:44] dstrine: I'll need CR at some point, yes [03:23:58] fr-tech: What are people's evening plans? [03:24:08] I also put the civicrm version of the new letter on staging - probably less time sensitive - MBeat or leanes could probably test & confirm on there [03:24:11] I'm okay self-merging if needed. [03:24:27] I should be around a bit longer - is there any complexity in doing CR on the letter? [03:24:35] eileen1: +1 those instincts, we can deploy it tomorrow safely, since it's only used during business hours. [03:24:37] awight: I'm about until my brain gives out [03:24:43] eileen1: a bit I'm afraid. [03:24:44] hehe [03:24:47] thanks, all! [03:24:59] eileen1: This is the WIP change, https://gerrit.wikimedia.org/r/#/c/323997/2 [03:25:52] The nastiness is that it's a google doc that I've wikified to use extension:translate tags, then there's a custom templating step, followed by Twig rendering. [03:26:06] I make it sound nicer than it is. [03:26:48] Routine changes would be fine, but something changed in how whitespaces are handled. Plus, the bold text is turning out to bollox text2html [03:27:27] ah ok [03:27:40] Why did you have to whitelist else - that was already in use [03:28:05] eileen1: i know! I'm freaked out by that [03:28:32] core change revert has merged btw [03:28:38] on master branch [03:28:39] THere's also this bizarre hack to replace {% endif %} by {%endif%}, otherwise Twig chokes on unknown tag "endif " [sic] [03:29:53] I'm trying not to worry about that stuff too much ATM [03:31:30] dstrine: I'll keep you updated as I go, but this is starting to be a risky change. [03:32:01] like, I'm going to have to make code changes to the thank you mailer in order to get bold text in the HTML and not screw with TXT email body [03:32:31] awight: dstrine are they negotiable on the bolding if there is risk in it? [03:32:41] awight: be bold! [03:32:57] harrr [03:33:22] EVEN IF IT SOUNDS LIKE THIS? [03:33:24] hehe [03:34:34] awight: my evening plans are to be lurking in here while i insulate the work shop [03:34:41] hehe ty [03:34:54] so you're available until the frostbite gets your fingers [03:35:18] it's retaining heat better by the minute! [03:35:41] i have a small ceramic space heater in here, and long johns and carhartts [03:35:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Html2Text should be included as a composer dependency - https://phabricator.wikimedia.org/T151841#2829655 (awight) [03:36:49] cwd: how is the bedroom? [03:37:14] dstrine: who are the stakeholders on this letter? I need to ask a Phabricator Q [03:37:39] dstrine: pretty amazing, been sleeping in there the last few nights [03:37:44] oooh um virtue, megan, comms lots of people what's your question? [03:38:07] cwd: cool and congrats [03:38:15] :) [03:38:18] kk [03:38:32] awight: maybe I can help? [03:38:59] meh I guess it's not a question, now that I write it down. [03:39:23] Of *course* they don't want any emphasis on the bold paragraph, in the text-only attachment, right? [03:40:43] awe crap. They might [03:40:51] k I'll ask then [03:41:19] I mean, we could put it out without bold and fix that later [03:41:46] I don't think I can get anyone right now who would have an opinion [03:42:24] plenty of people will read it in a plain text email either way [03:42:46] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: New thank you email for big english - https://phabricator.wikimedia.org/T151784#2829667 (awight) @Katherine-WMF @Pcoombe @MeganHernandez_WMF @CaitVirtue Friends, I'm trying to coax the new letter into the templatized... [03:43:05] Cool, I'll temporarily hack that then [03:43:54] yeah thanks. I'll comment on the phab task too [03:43:59] ty! [03:45:54] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: New thank you email for big english - https://phabricator.wikimedia.org/T151784#2829669 (DStrine) Since it's pretty late tonight, I'm going to make the call to keep it plain text with no caps, asterisks or the like. We... [03:51:01] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: New thank you email for big english - https://phabricator.wikimedia.org/T151784#2829673 (awight) Very minor question along the same lines--there's an em dash in the letter, here are our options: | HTML | text-only | c... [03:54:47] (PS3) Awight: New thank-you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 [03:55:55] Hmm I'm not figuring out much meaningful about that Ingenico one [03:56:34] eileen1: Was the ID in our logs, and was it sent to them as an ORDERID? [03:56:42] That's probably plenty of fact for the moment [04:01:26] We did a 'GET_ORDERSTATUS' passing it as the MERCHANTREFERENCE [04:01:50] oh hrr [04:02:01] um [04:02:12] god I can't remember which ID that corresponds to [04:02:35] contribution_tracking_id [04:02:46] (found in globalcollect_gateway/config/var_map.yaml) [04:02:48] I can't find it in Civi [04:02:54] so that isn't actually their order id [04:02:55] I did find a INSERT_ORDERWITHPAYMENT [04:03:07] What's in the ORDERID field in the logs? [04:03:17] that's the number we should be searching in the ingenico console [04:03:41] and it's bad that the contribution_tracking id made it into our trxn_id [04:03:54] thanks for investigating! [04:05:13] there were 2 in the email - for the first ejegg[m] had found the orderid - referered to as the error ref in the email [04:05:50] is that the answer they need - ie that the error ref is the order id & the name being different in the email is the confusion [04:06:25] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: New thank you email for big english - https://phabricator.wikimedia.org/T151784#2829682 (awight) Here's the templatized version for final review: https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_2... [04:07:25] fr-tech: https://gerrit.wikimedia.org/r/323997 is ready for CR now. I'll forward some test output [04:11:35] the text seems good [04:17:57] oh on that note, the text-only attachment needs to work too [04:19:52] yeah have you sent any examples of that [04:20:07] I'm looking at this https://gerrit.wikimedia.org/r/#/c/323997/3/sites/all/modules/thank_you/generators/ThankYou.php [04:20:45] it seems to me the new email has the

tabs in a different location & this is to still capture it [04:21:00] But, I'm wondering why you moved the

tabs [04:21:15] it looks like tidy up? rather than required for meeting the ticket needs? [04:22:15] text-only is included in the emails i sent, i believe, as mime attachments [04:22:29] hold on, baby sctreaming [04:28:24] yeah the

movement is bad and I think it's introducing leading whitespace [04:28:34] I couldn't get the preg_replace strings to behave correctly tho [04:28:37] lemme try more... [04:41:49] maybe the

explains the baby screaming= [04:41:51] ? [04:43:47] awight: my reservation about changing the handling of the

tags was just that this means it is not the most conservative patch it could be, given the timing [05:00:20] awight: I think I'm OK to merge it - it would only affect thank you email & the results look OK. I would be more comfortable without any extraneous tidy up due to the timing [05:01:18] which is kinda bizarre really… for this to be a last minute thing [05:10:21] awight: eileen2 I have a few cycles if there's anything that my looking at might help with (rrrrg grammar derp) [05:13:11] AndyRussG: maybe just eyeball it - it looks fine to me - but it's not an area I've worked on [05:13:17] is also not that complex [05:13:49] https://gerrit.wikimedia.org/r/#/c/323997/3/sites/all/modules/thank_you/templates/html/thank_you.en.html [05:15:16] (CR) Eileen: [C: 1] "This all seems fine to me & seems to work, based on the mails awight sent out. I have a reservation about the alterations to support the l" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 (owner: Awight) [05:22:00] looking [05:25:11] awight how's it going? [05:29:10] eileen2: awight on the surface it looks workable.... I don't know enough about the code to say much more, I'm afraid... [05:30:46] AndyRussG: yeah - that's where I'm at with it too [05:30:52] but, the emails worked.... [05:32:02] dstrine: fwiw successfully prevented complex core change that from going out tomorrow, as agreed [05:32:32] AndyRussG: well that's good. I also got 2 test emails and they looked ok [05:33:28] holy scope creep on the thank you email patch [05:34:00] hacking regexp the night before BE... [05:34:05] Is this homebrew parsing html? https://gerrit.wikimedia.org/r/#/c/323997/3/sites/all/modules/thank_you/Html2Text.php [05:34:40] cwd: AndyRussG eileen2 awight there wasn't any scope creep from the PM side ... just sayin.... [05:35:02] It's a pretty minor tidy up [05:35:20] removing extraneous blank lines [05:35:23] dstrine: yes no finger pointing intended [05:35:27] it just changes the regex [05:35:35] just classic programming [05:35:49] everything ends in a regexp [05:36:03] I'm 90% [05:36:06] to merging it [05:36:14] the regex change is here https://gerrit.wikimedia.org/r/#/c/323997/3/sites/all/modules/thank_you/generators/ThankYou.php [05:36:41] & I don't know where the substitution is happening for the $1 in there [05:37:32] But - I can't see any impact on anything outside the thank you letter - in which case the letter itself looks OK [05:38:50] Although the em-dash looks a bit odd to me [05:39:00] be—to settle [05:39:15] cwd any opinion on it [05:39:47] eileen2: i am staring at it googly eyed [05:40:14] :-) [05:40:18] yeah, I'm a bit the same [05:40:33] why are the EOL p tags omitted in the change? [05:41:00] you mean in the regex? [05:41:01] eileen2: I saw you comment on the task but I'm not sure I understand what choice needs to be made [05:41:20] and the closing p tag appears to be substituted with the opening p tag? $1 [05:41:21] this is about the dash ^^ [05:41:42] dstrine: it's just the regex change - ie. the one cwd is looking at now [05:41:52] ok [05:42:39] cwd yeah - I think so - it's just regex hurts my brain [05:44:02] oh wait no on that line the $1 will be the closing tag [05:44:18] but i don't understand why the change [05:44:39] cwd - I could repush it without that tweak if we felt we could approve it that way & look at the regex tomorrow? [05:44:58] it's for the top part here https://gerrit.wikimedia.org/r/#/c/323997/3/sites/all/modules/thank_you/templates/html/thank_you.en.html [05:45:35] can I help by seeing a version of this email? [05:46:25] dstrine: I don't think it's changed since awight sent on e out about 90 mins ago [05:46:37] oh ok 1 second [05:47:25] But the test doesn't include the 'Dear Donor' version - for when there is no name [05:47:39] the test email I have looks ok. What part should I be looking at? [05:47:45] oh [05:47:53] eileen2: cwd: I could be a rubber duck while u explain the code to me, if that's helpful, even via hangout if it's useful [05:48:34] AndyRussG: the question is basically how to verify this regex change is correct [05:48:45] https://gerrit.wikimedia.org/r/#/c/323997/3/sites/all/modules/thank_you/generators/ThankYou.php [05:48:48] Sorry all, I had a key pinky playing pacifier duty [05:49:02] I was hoping awight would pop up & convince it is correct & we are away [05:49:04] :-) [05:49:11] still backscrolling... [05:49:13] almost... [05:49:28] lemme double-check what it looks like w/o the regex change [05:49:59] cool ok [05:50:12] yeah lemme see what it generates with the old regex [05:50:15] I see references to '_preg_callback' in two places in that file (besidwes the definition) [05:50:29] Where is the actual regex that's used there? [05:50:41] * AndyRussG gets in the way [05:51:23] the stupid twig tag whitelist seems to be necessary [05:52:14] dstrine: one thing in the email you could look at is the dash in may be—to settle [05:52:16] AndyRussG: seems to be $this->callback_search [05:52:39] yeah that em dash bothers me cos in the text-only version it looks like a hyphen [05:53:06] & confirm you are happy (looks weird to me without spaces around it but often North American idiosyncracies pop up) [05:53:12] eileen2: that is just a tad odd but we could live with it for tonight [05:53:29] Ahh an array of patterns [05:53:46] AndyRussG: oh geez. which makes me realize there's no default clause [05:53:59] so I have no idea why this works. did I just delete those paragraphs? [05:54:08] awight: I guess the short answer is if we could let the regex changes lie & not change the

stuff at the top of the file it seems mergeable as is [05:54:27] otherwise I'll need to understand the regex [05:54:37] & figure out if it could hurt anything [05:54:56] I don't see any change in the regex itself then [05:55:11] I would just like to name that everyone here needs to be rested for tomorrow. We either ship an "ok" email or we stop for tonight. [05:55:40] what gets us to an "ok" email? [05:55:56] Not to be vindictive, but I think the correct way to deal with this 11th-hour b.s. is to say no [05:56:05] baby woke up. gimme afew [05:56:22] gah [05:56:26] baby won't take "no" for an answer [05:56:29] It actually looks fine to me. My issue is there are changes I don't 100% understand to the regex function which I feel nervous about in case there is risk [05:56:31] right! [05:56:37] I mean the letter looks fine [05:56:40] eileen2: I feel the same way [05:57:01] awight: what if I re-do it without that change while you nurture [05:57:14] Those paragraphs are *missing* from the text-only version [05:57:14] awight: can we release this later tomorrow? [05:57:21] yep [05:57:22] & when you are back you can re-test & merge [05:57:29] can live without b [05:57:36] awight: was that a yep to me? [05:57:46] (PS2) Eileen: Update thank you letter. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323988 (https://phabricator.wikimedia.org/T151814) [05:57:48] eileen2: hehe no i mean the paragraphs are missing, not just the boldness [05:58:03] oh - let me look & try to do a replacement while you nuture [05:58:04] dstrine: Yeah I'd prefer to not get all cowboy on this nonsense [05:58:21] ok let's stop for tonight [05:58:33] cwd: AndyRussG eileen2 awight ^^^^ [05:58:40] Seriously still marveling how on earth this came down to BE eve [05:58:48] +1 [05:59:02] OK - leave it then for tomorrow [05:59:08] people receiving it won't know [05:59:11] thanks all for hanging out [05:59:25] Thank you for not rush-merging, also! [05:59:26] yeah from my naive perspective the change looks nasty [05:59:30] rest up!!! [05:59:44] (CR) Awight: [C: -2] "Doesn't work--I've removed the bold paragraphs entirely." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 (owner: Awight) [05:59:48] cya! [06:00:18] ^ awight ah yeah I was gonna say, the phpdoc doesn't say what should happen if the callback returns naught [06:00:35] http://php.net/manual/en/function.preg-replace-callback.php [06:01:17] (CR) Eileen: "before merging we should test the Dear donor scenario too" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 (owner: Awight) [06:05:56] g'night! [06:13:12] turns out the regex changes are necessary. I still don't know why [06:16:28] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: New thank you email for big english - https://phabricator.wikimedia.org/T151784#2829707 (awight) Unfortunately, it wasn't possible to get the changes deployed safely tonight. We'll revisit the deployment tomorrow. [06:20:00] awight: sorry, I'm still around if you're trying again [06:20:19] ejegg|afk: naw, thanks though [06:20:24] I might hack a little [06:20:27] but don't want to deploy [06:24:04] dang, no default in that case statement [06:26:16] I'm doing a PS where I return $matches[3] [06:26:35] but I'd like to understand what's up with the


crap happening at the beginning of the letter [06:27:53] right, that's new [06:29:04] also, the

s are shifting like hell [06:29:22] blargh [06:29:29] besides the shifts in the replacements? [06:30:22] well I can't even run the templating without making those changes... [06:30:36] exception 'Twig_Error_Syntax' with message 'Unknown "else" tag in "


[error] [06:30:40] hella creepy [06:32:00] well, it's coming straight out of the api response with that
[06:41:44] You'll like this fix... [06:43:00] oh? [06:43:08] just nuking all the
s? [06:43:29] darn I thought I would. [06:43:42] nested regex to eliminate html whitespace [06:43:46] WHAT COULD POSSIBLY GO WRONG [06:44:16] ZALGO COMETH [06:44:58] vote Zalgo, the Wikimedia Foundation insists! [07:32:18] (PS4) Awight: [WIP] New thank-you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 [07:32:26] can't take it [07:32:32] see you all tomorrow! [09:00:11] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, I18n: [Epic] Use translatable pages for banner content - https://phabricator.wikimedia.org/T116235#2829945 (Nemo_bis) Do you CentralNotice folks still believe this is the way to go? [09:02:59] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Untranslated CentralNotice banners should be flagged or forbidden - https://phabricator.wikimedia.org/T90634#1063719 (Nemo_bis) awight, are you still interested in this problem (also formulat... [10:03:56] (PS1) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/324056 [10:09:28] (PS1) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/324066 [10:15:57] (Abandoned) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FundraisingChart] - https://gerrit.wikimedia.org/r/324056 (owner: Hashar) [10:16:25] (Abandoned) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/324066 (owner: Hashar) [14:04:02] the-wub: how's it going? Is it all starting? [14:04:41] dstrine: in about 20 minutes. sorry for not updating y'all [14:05:00] it's cool. I'm just morning person [14:07:28] the-wub: Seddon dstrine morning! [14:07:34] * AndyRussG|away breaks out champaign [14:08:12] Short availability message: I'm about to take kids to school and will be fully online in around 45 minutes. In case of any urgencies, pls don't hesitate to call my cell!! Have fun!!!!! [14:24:50] dstrine ppena_ Seddon: we're up now! [14:26:43] the-wub: yay!!! [14:27:38] should I see a banner on all wikipedia pages? [14:28:20] I haven't seen any yet [14:28:25] the-wub: woop! [14:29:26] dstrine: I think there's a little caching delay. we are seeing clicks though. are you logged out? [14:30:01] I am not logged in [14:30:47] I didn't realize he had a caching delay on enabling banners [14:31:30] tried incognito mode? I'm seeing banners [14:32:16] I an not in ingocnito [14:32:30] now I'm seeing them!!!! [14:38:48] amazon and paypal donations worked. I don't have credit card nearby [14:46:25] rolling in... [14:47:45] hmm, apache just restarted on 1001 - unfortunately timed puppet run? [14:48:27] looks like it, 1002 just restarted apache too [14:54:09] ejegg: I got a catchpoint alert about payments page failure - related? [14:54:16] seems to be working fine for me now though [15:00:03] the-wub: that was exactly when one of the servers was restarting, so probably related, yeah [15:02:59] ejegg: how do interpret the restart? Any opinions on the campaign health? [15:03:32] *how do you interpret ... [15:04:04] it's just the software updater running at an inopportune time [15:04:38] but it doesn't do all of the servers at the same time, and only takes apache out of commission for 2 sec [15:07:24] ok great. thanks for the context. [15:17:43] dstrine: the caching delay was not for the banner itself, but for changes campaign settings. Those are also cached and can take up to 10 minutes to reach users. When you've heard before about ResourceLoader cache delay, that's this. (ResourceLoader is the system that Mediawiki uses to send Javascript to the browser, and campaign settings piggyback on that.) [15:18:28] AndyRussG: ok thanks [15:18:55] also getting banners (when adjusting for the right country)! [15:19:04] well while people are on I'm going to head into the office. [15:42:56] the-wub: Seddon I don't see any missing banner errors since launch. Here's a short version of the LogStash page to watch (u need Wikitech creds tho): https://goo.gl/h38TRQ [15:46:50] Backscroll looks happy :) [16:16:50] awight[m]: are you using matrix? [16:22:49] * cwd glares at cwd1 and cwd[m] [16:23:11] those accounts were both signed out of riot.im but continue to ghost in here [16:23:41] one of them loves to steal my nick while i'm |afk [16:27:40] AndyRussG: I'm seeing a few banner message key errors on kibana now [16:28:04] ejegg: checking.... [16:28:23] latest seems like a bogus language code [16:28:43] oh wait, that's the only once since the campaign started [16:28:51] so... nothing to worry about [16:29:15] except why someone requested the banner in language 'qd' [16:29:31] ejegg: yeah it's a new language I guess? [16:29:37] 'reserved for local use' [16:29:41] huh [16:30:36] Maybe some bug in language variant controls for some wiki? If curious, we could look up the referer and actual country via Hiva [16:30:39] Hive [16:30:45] Otherwise I guess ignora [16:31:21] ejegg: thx for watching that! [16:31:38] I have to go afk until the 9:30 PST meeting.. backsoon! [16:32:28] ejegg: can i get a kibana url? [16:32:42] https://goo.gl/h38TRQ [16:32:46] cwd ^^ [16:41:23] thanks! [16:41:53] * cwd presses cancel in order to check the cert [16:42:27] those htaccess passwords must be great for phishing [16:43:13] heh, oh man, yep [16:45:34] Naw just trying to be like the other kids [16:45:49] Lack of persistent connection is killing me actually [16:46:01] Hehe thx for decoding the em [16:46:20] awight[m]: setting up bnc? [16:47:36] Uh, like a little plug on my backpack? [16:48:13] (CR) Ejegg: "Maybe deploy a hand-edited letter, then go back to fix the generators?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 (owner: Awight) [16:59:13] ejegg: the 'qd' code is probably trilogy forcing one. adding random uselang codes can help skip the cache when it's being stubborn. they seem very fond of the method [16:59:22] cwd: I'm in matrix but the room is empty... I thought it was a bridge? [16:59:29] aha, interesting [17:00:03] awight-shoddy: there is a bridge to freenode on matrix.org [17:00:15] which you can access through that riot.im UI [17:00:49] Bah. /me resets password for irccloud [17:01:11] wat [17:01:26] bro no [17:02:22] unfortunately that irc bridge appears to persist every login for infinity [17:02:26] Hehe [17:02:42] Et voila [17:02:57] but if you want a nice persistent experience use weechat/glowing-bear [17:03:45] So... The em thing is people logged into the matrix web GUI bridge? [17:03:59] awight: yep [17:04:02] https://github.com/glowing-bear/glowing-bear [17:04:09] Kk [17:04:13] awight: not necessarily logged in! [17:04:23] neither of my dopplegangers is logged in [17:04:26] D'oh [17:04:47] guessing it's related to the irc bridge [17:05:51] probably does not get the exit message from matrix [17:06:10] although it seems to have worked for awight [17:06:34] I was fake matrixing [17:06:36] i closed the account connected to cwd[m] [17:06:50] so i think it's just going to be here forever [17:06:59] Just using the em cos I fight that was our new shorthand for mobile [17:07:05] oh hehe [17:07:38] I got my [m] to go away by going to matrix and exiting the bridge status channel. No idea why that did the trick. [17:08:03] Hey on this note ... K4-713 or Jeff_Green, would you fix the channel topic so we get the irclogs indexed in the right order? [17:08:17] XenoRyet: wish i would have tried that before closing the account :( [17:08:20] leaving the house before I get stuck here all day... [17:08:25] awight: er, what? [17:09:05] awight: What's the right order? [17:09:28] I left a task about this.. [17:09:28] Somewhere [17:14:06] awight apparently that bot is not enterprise scale :-) [17:14:14] it takes 30s to sort the dir [17:15:51] awight: apparently I'm not channel operator, but i think this is the URL you want? http://bit.ly/2gFK6sG [17:18:19] Jeff_Green: yes totally. But that delay is uncouth [17:18:49] Rgh and irccloud can't do anything about Bart YouTube guy killing the cell tower [17:19:26] * awight resigns self to just not pretending to do work for another half hour [17:47:20] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: New thank you email for big english - https://phabricator.wikimedia.org/T151784#2831693 (DStrine) >>! In T151784#2829673, @awight wrote: > Very minor question along the same lines--there's an em dash in the letter, here... [17:52:28] Fundraising Dash, Fundraising-Backlog: add a widget to the dash that shows last year's day-by-day totals - https://phabricator.wikimedia.org/T151908#2831711 (DStrine) [17:54:06] Where is that chat? [17:58:25] We're getting a low number of timeouts to Ingenico. Nothing too concerning, yet. [18:00:02] fr-tech: Don't feed the bats tonight. [18:00:02] -- discuss. [18:00:59] aww, slander's back! [18:01:23] Gosh dang. [18:02:06] K4-713: retooled for effing with us [18:02:20] * K4-713 gives giant thumbs up [18:02:36] I'm fixing those contributions from the future... [18:02:40] I haven't seen that guy since we were using Mingle. [18:02:50] dash seems to not start until dec [18:03:12] K4-713: ejegg is it faster to fix the dash or make the fancy spreadsheet? [18:03:18] lol [18:03:36] Almost certainly faster for me to populate the spreadsheet, if what ejegg just said in standup is accurate. [18:03:38] dstrine: not sure [18:03:47] ah, yeah, probably the spreadsheet then [18:03:51] I saved all my fancy queries. [18:04:05] Also the normal ones. [18:04:23] can you put "fancy" in the name when you share it? [18:04:30] PM scope creep^^^^ [18:04:31] :) [18:04:42] That's a story point. [18:04:48] But, yes. [18:04:53] I'll buy that for 1 SP [18:05:18] fancy ronaldo [18:05:42] could be a boxer [18:05:54] "Fancy" Ronaldo [18:06:12] I forgot about Ronaldo. [18:06:37] OK, I've fixed the donations from the future... [18:06:43] I still think "Fredge" was my best naming triumph, though. [18:06:52] "What does it stand for?" [18:06:57] "Fredgerick". [18:07:01] hah [18:07:37] We tried to backronym it, but it always falls apart after "Fund Raising". [18:07:57] It's a cold place to store data [18:08:25] These days it would almost certainly be christened "fredgely" [18:08:28] FundRaising Engineering Data Gosh Eeeyes. [18:08:44] I'm still proud of 'statler'. someday I hope to write a companion tool called waldorf [18:08:54] lol [18:08:56] I also wrote a statler. [18:09:07] It did very, very different stuff. [18:09:54] It existed to know things in SVN, and tell you how horrifying it would be to merge new patches into very old and creaky branches. [18:10:50] When we moved off svn, I assumed I'd have to write a waldorf to do similar things there, except the command line interface basically covered everything nicely. [18:11:15] In git. [18:11:51] oh man, svn. I forgot we even used that. how long ago was that? [18:12:06] the-wub: I helped do the switchover in March 2012 [18:12:19] RoanKattouw: Woah. Hi. [18:12:25] So, fundraising folks, are people supposed to see the banner only once and then have it disappear? [18:12:26] :D [18:12:26] and thank you so much for it RoanKattouw! :) [18:12:58] RoanKattouw: they see a large banner once, and then smaller ones after that [18:13:09] Cause I saw https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Second_fundraising_banner_after_the_first_is_closed and then looked at it a bit in an incognito window and saw --- yeah exactly that [18:13:27] There's a banner that appears once, and a smaller (green I think?) banner that appears on every page view after that [18:13:34] If that's intended behavior, then that's fine! [18:14:21] yep. Seddon: mind weighing in on that VP thread when you have a chance? [18:14:44] RoanKattouw: I'm literally in the middle of responding :) [18:15:00] * RoanKattouw points at the-wub :P [18:15:03] the-wub: ^yep [18:17:02] huh i didn't get that experience, closed the black banner and not seeing any others [18:18:33] fundraising-tech-ops: Blank page at https://payments.wikimedia.org - https://phabricator.wikimedia.org/T134818#2831840 (Jgreen) p:Triage>Normal a:Jgreen [18:19:14] the-wub: you said you already did several tests today. are the results in a single spreadsheet or otherwise accessible? I'm just interested in learning your process. [18:19:17] cwd: I didn't close the banner though, I just went to a different page [18:19:28] Hmm the reporter did though [18:19:28] Checking [18:19:47] Can confirm [18:20:00] After closing the first banner, the second one still appears [18:20:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, FR-Smashpig, and 4 others: [Epic] Consolidate "pending" queue usages - https://phabricator.wikimedia.org/T130897#2831852 (Jgreen) [18:20:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-ActiveMQ, FR-Smashpig, and 3 others: [Epic] Deprecate old pending queues - https://phabricator.wikimedia.org/T133433#2831850 (Jgreen) Open>Resolved a:Jgreen [18:20:51] dstrine: here. you should already have access. https://docs.google.com/spreadsheets/d/102ok9aCWQZt5YVV6bMoB1bQDIo_xClsqI2eB5sgyI54/edit#gid=843826022 [18:20:56] RoanKattouw: yikes, i didn't think we did that [18:21:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, FR-ActiveMQ, and 3 others: [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack - https://phabricator.wikimedia.org/T108229#2831855 (Jgreen) Open>Resolved [18:21:34] Fundraising-Backlog: Q3 GOALS! (January-March) Keep at top of Q3 column - https://phabricator.wikimedia.org/T117466#2831856 (Jgreen) [18:22:20] Seddon: So it looks like that person found a bug after all [18:22:31] My experience was that the green banner stuck around across multiple pages if I didn't close it. Once I closed it it went away and stayed gone. [18:27:31] the-wub: thanks! [18:29:52] the-wub: is RoanKattouw's report of the green banner persisting across pages expected behavior? [18:32:17] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, Epic, Performance: [Epic] Payments performance tuning - https://phabricator.wikimedia.org/T140311#2459918 (Jgreen) fwiw I'm currently getting 2.25-2.5s under full fundraising load [18:32:44] dstrine RoanKattouw: closing the first (large) banner doesn't affect the later ones. that stems from the days when it was more of an overlay, and users basically had no choice but to close it. we could potentially revisit that [18:33:06] closing any of the small banners, should hide all banners for 7 days [18:34:20] Fundraising-Backlog, fundraising-tech-ops: Deprecate and remove twig and phpmailer projects - https://phabricator.wikimedia.org/T141914#2831954 (Jgreen) a:Jgreen [18:36:57] +1 that I expect the close box to prevent any more banners [18:37:18] Not sure what the solution should be, though--having no close box at all would be annoying. [18:38:34] uff, this dash code is pretty gnarly [18:39:36] if it's going to continue to be a thing i would really push for updating to a more current node version [18:40:46] although it was a completely different language back then so it would probably be a beastly update [18:41:33] cwd yeah. or just ditch it for kibana [18:42:19] err, or some other dashboard [18:42:46] yeah kibana is pretty nice [18:43:05] well, i actually hate the way it works, but it's very useful [18:43:59] websites that try to act like desktop applications frustrate me with their brittle ajax and terrible urls and breaking my back button [18:46:16] * cwd continues typing into angularjs irc client [18:46:23] hehe [18:51:36] Fundraising-Backlog, fundraising-tech-ops, FR-Smashpig, FR-2016-17-Q2-Ops: Figure out a sane way to deploy SmashPig.yaml configuration - https://phabricator.wikimedia.org/T147503#2832033 (Jgreen) > The key locations and syntax sometimes changes due to code deployments. Key changes need to be coo... [18:54:33] cwd: drives business to url shorteners [18:55:37] lets url shortening services log your application state [18:56:17] eh they'd never do that [18:58:38] the real surveillance revolution happens when someone finds a way to actually index and search the warehouses of hard drives [18:59:37] seems reasonable that someone will be google [19:01:07] Amazon already has the upload-by-van service [19:04:14] upload-by-tempest [19:10:09] getting some food, but i'll listen for IRC pings [19:14:11] (PS5) Awight: [WIP] New thank-you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 [19:20:46] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: Provide a sudo wrapper for running DonationInterface maintenance scripts - https://phabricator.wikimedia.org/T144572#2832182 (Jgreen) a:awight Unless I'm missing something we've had this for a long time, see /usr/l... [19:26:08] (PS6) Awight: New thank-you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 [19:26:20] fr-tech: ^ ready for re-re-review [19:27:34] dstrine: i'll be a few min late for cps checkin [19:27:59] grr, still a little whitespace in the text version [19:28:00] whatever. [19:31:02] (CR) Awight: New thank-you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 (owner: Awight) [19:34:06] awight: dstrine my connection is kinda choppy just now... [19:37:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Slow login on CiviCRM - https://phabricator.wikimedia.org/T130784#2146397 (Jgreen) This is that thing where putting a reverse proxy in front of civi breaks civi's "check for updates" feature, right? [19:48:38] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Untranslated CentralNotice banners should be flagged or forbidden - https://phabricator.wikimedia.org/T90634#2832302 (awight) @Nemo_bis I'm still interested--where can I read about the fallou... [19:50:27] fr-tech: Anyone able to review https://gerrit.wikimedia.org/r/323997 ? I just sent out a nameful and an anonymous TY to fr-tech@ [19:50:40] awight: looking now [19:50:42] The code is loaded on the staging Civi if you want to play more [19:50:56] https://XXX/admin/config/thank_you/test [19:51:31] The only glitch I've noticed so far is that the text attachment has a leading space before some paragraphs. [19:51:35] n.b.d. [19:53:09] awight: weird, gmail's 'view original' shows a bunch of char codes like "world=E2=80=99s knowledge", etc [19:53:40] that's all mime quoted-printable [19:53:44] try "message garbled?" [19:54:02] are =20 trailing spaces? [19:54:22] yah i believe so [19:55:01] k [19:55:04] is that a problem? [19:55:29] well, an old TY letter had the =20 trailing spaces too, so I'm not going to worry about it [19:55:31] I think it's okay [19:56:28] word [20:00:35] ah, that

switcheroo must have been to avoid those leading spaces [20:00:46] anyway, like you said, not a big deal [20:04:25] ejegg: I'm not sure--the initial
is new, and I think that's might be where the space is coming from [20:04:37] It's possible that it's because the block is empty [20:04:39] The actual thing that surprises me in "world=E2=80=99s knowledge" is that it uses a fancy quote character [20:05:00] RoanKattouw: ohai! Where did you get a thank-you letter? [20:05:01] it does specify charset utf-8, so that should be ok [20:05:18] RoanKattouw: yeah the fancy quotes are disturbing. Those are coming from the MediaWiki parser [20:05:21] awight: I didn't, I was just responding to 14:53:09 awight: weird, gmail's 'view original' shows a bunch of char codes like "world=E2=80=99s knowledge", etc [20:05:37] But got distracted first so didn't realize that was 15 mins ago [20:05:41] ah hehe [20:06:20] RoanKattouw: I just sent you one, while you're entangled [20:06:27] lol I saw that, thanks [20:06:31] Will check what it looks like [20:06:35] (CR) Ejegg: [C: 2] "Looks fine to deploy for now, but let's definitely keep working on the generator." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 (owner: Awight) [20:10:18] (Merged) jenkins-bot: New thank-you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323997 (owner: Awight) [20:14:03] thanks! [20:17:32] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/324259 [20:17:46] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/324259 (owner: Awight) [20:19:14] Fundraising-Backlog, fundraising-tech-ops: payments1004 should have the "mwscript" frontend to MW maintenance scripts - https://phabricator.wikimedia.org/T109665#2832508 (Jgreen) Open>declined payments1004 no longer handles orphan-slaying [20:19:54] (PS1) Ejegg: WIP bandaid for big english board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324261 (https://phabricator.wikimedia.org/T151820) [20:21:05] (PS1) Ejegg: Revert "Enable syslog on OSX" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324262 [20:21:07] (PS1) Ejegg: Revert "Change package node-syslog to modern-syslog" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324263 [20:21:55] fundraising-tech-ops, Operations, Patch-For-Review: remove fundraising banner log related cruft from production puppet - https://phabricator.wikimedia.org/T118325#2832532 (Jgreen) Open>Resolved a:Jgreen [20:22:04] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/324259 (owner: Awight) [20:23:02] !log update civicrm from 8c76f437c9a9739ffae2892339a46d62d13fdf61 to f8f9263d4aa0b5ba9b09827174c9b2e9a90a004c [20:23:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:26:31] !log new thank-you letter deployed... [20:26:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:26:45] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: New thank you email for big english - https://phabricator.wikimedia.org/T151784#2832556 (awight) Deployed! [20:27:56] fundraising-tech-ops, Operations, netops: Cleanup layer2 firewall config from pfw-eqiad - https://phabricator.wikimedia.org/T111463#2832558 (Jgreen) Open>declined We might as well close this task since we plan to replace the firewalls very soon. [20:29:39] ejegg: You still working on the dash? Need a hand? [20:30:05] awight: yeah, just doing a crappy bandaid for now [20:30:29] that replaces day(receive_date) with dayofyear(receive_date) - 333 [20:30:43] i am also available for whatever [20:31:11] seeing if I can speed up that silly dollas per second calculation too. no need to have this hideous if statement in the sql to account for the current hour [20:31:32] ejegg: where is the sql? [20:32:24] eileen1: https://github.com/wikimedia/wikimedia-fundraising-dash/blob/master/widgets/big-english.js [20:32:50] yeah... hand-rolled node sql query generator [20:33:32] that query was lifted straight from K4-713's spreadsheet generation [20:34:06] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: New thank you email for big english - https://phabricator.wikimedia.org/T151784#2832617 (awight) Crap--we've been sending Katherine's letter as "from" Jimmy Wales. [20:34:16] but we could definitely calculate that $/sec client side [20:34:23] ooh, rain, gotta shelter [20:34:44] ejegg: I think the GROUP BY on HOUR(receive_date) will bypass any index on that field [20:36:20] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: New thank you email for big english - https://phabricator.wikimedia.org/T151784#2832627 (awight) ``` drush vset thank_you_from_name "Katherine Maher" ``` [20:36:45] eileen1: yeah, I was just wondering what to do about that [20:37:13] extra columns to explode the dates? [20:37:50] ejegg: how many rows are there? maybe wrap it in a subquery [20:38:05] if if there are only a couple of hundred hours etc then [20:38:33] SELECT * FROM (SELECT blah, calculation as hour FROM… ) as sub GROUP BY hour [20:39:01] awight: Nice touch with the € in my fake thank you email [20:39:17] I would be surprised if that long IF clause is terribly slow - my guess would be the group by is the issue [20:39:18] eileen1: millions, unfortunately [20:39:24] ah ok [20:39:29] millions of hours? [20:39:42] err, no, millions of contributions [20:39:45] oh millions with hour - yeah [20:39:49] just a month worth of hours [20:40:04] RoanKattouw: Glad to throw a bone for the Eurozone [20:40:07] hmm - I think it must be possible … [20:40:18] to get rid of the group by on hour [20:40:30] thinking [20:43:49] ah the group by on the receive date is on day too [20:45:27] yeah [20:50:04] eileen1: I'm getting my butt kicked by drush [20:50:04] drush vset thank_you_from_name "Katherine Maher" [20:50:09] is only setting to "Katherine" [20:50:42] aargh this is cos drush is in a wrapper. [20:54:00] omg cannot get to the thank-you config screen [20:54:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can't access thank_you module configuration form - https://phabricator.wikimedia.org/T151941#2832726 (awight) [20:54:58] back in a bit.... [20:56:04] awight: I got it [20:56:14] howzat? [20:56:26] so you did! [20:56:29] how... [20:56:53] Tell me it involved two levels of quotes and lots of backslashes [20:57:36] (CR) Eileen: "This can be tested on staging from the edit screen - note the wierdness on currency signals is unchanged - we maybe should prioritise fixi" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/323988 (https://phabricator.wikimedia.org/T151814) (owner: Eileen) [20:58:29] (PS1) Awight: Link to the correct configuration form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/324272 (https://phabricator.wikimedia.org/T151941) [21:02:39] rebooting. [21:03:37] ejegg: Oh, did I write some crazy SQL? [21:03:40] (yes) [21:04:14] K4-713: it's some beuatiful SQL for doing all the calculations in SQL [21:04:56] but since the dash has the opportunity to massage the db output, I figure we can take a little load off the query engine [21:10:15] (PS2) Ejegg: Bandaid for Big English board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324261 (https://phabricator.wikimedia.org/T151820) [21:10:53] fr-tech ^^^ should at least let us see something on the B.E. board for now [21:11:03] checkin it out [21:11:16] Yea, I'll take a peep too [21:12:01] thanks! [21:12:12] took me a while to get the old node version working again :P [21:12:21] (CR) Awight: Bandaid for Big English board (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324261 (https://phabricator.wikimedia.org/T151820) (owner: Ejegg) [21:12:25] and I couldn't get modern-syslog to work with that version [21:12:56] Is there a staging dash somewhere? [21:13:27] node was still a very young language [21:13:35] it's like 0.8? [21:13:44] current is 4+ [21:13:59] Small fuzzy creatures from Alpha Centauri were *real* small fuzzy creatures from Alpha Centauri [21:15:16] (CR) Ejegg: Bandaid for Big English board (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324261 (https://phabricator.wikimedia.org/T151820) (owner: Ejegg) [21:16:33] awight: nope, see https://phabricator.wikimedia.org/T87809 [21:18:33] (CR) Ejegg: [C: 2] Link to the correct configuration form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/324272 (https://phabricator.wikimedia.org/T151941) (owner: Awight) [21:18:48] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Ingenico: stop calling SET_PAYMENT when GET_ORDERSTATUS returns 25 - https://phabricator.wikimedia.org/T151788#2832805 (awight) I mean, it's bad. But let's maybe not touch it... [21:23:08] (Merged) jenkins-bot: Link to the correct configuration form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/324272 (https://phabricator.wikimedia.org/T151941) (owner: Awight) [21:25:51] is it bad that the q consumer is basically keeping up? [21:27:20] hehe, bad for wmf? [21:28:09] well yeah - does it mean we have so few donations we can keep up? [21:29:30] I think those little tweaks added up [21:29:50] ejegg: but, last year weren't we like thousands of donations behind by now? [21:30:51] maybe jeff pushed the turbo button [21:30:56] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can't access thank_you module configuration form - https://phabricator.wikimedia.org/T151941#2832843 (awight) [21:31:21] we just had an hour that matched the best donation count hour for the first day last year [21:31:23] 25MHz! [21:31:36] ah OK - cool [21:32:05] BTW I still don't see data on dash [21:32:48] and the average amount was up, so we made like 20% more! [21:33:11] amazing [21:33:14] eileen1: the bandaid patch replacing days of Dec with days of campaign is still in review: https://gerrit.wikimedia.org/r/324261 [21:33:51] but you can add the x-by-y chart to a new board if you want to get hours for the past day [21:37:05] ahh, a bunch of that bonanza hour is tagged with MG annual email... [21:38:23] the other day the queue was going nuts from those emails too [21:38:29] seems like the emails are really effective [21:39:14] taking the MW email tagged ones out, it was about the same totals as the best hour last year [21:39:19] *MG email [21:42:41] relocating for meeting... [21:45:42] (CR) XenoRyet: "Looks good for a bandaid, will get the job done for now." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324261 (https://phabricator.wikimedia.org/T151820) (owner: Ejegg) [21:49:20] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: Provide a sudo wrapper for running DonationInterface maintenance scripts - https://phabricator.wikimedia.org/T144572#2833003 (awight) Open>declined The idea was to create another wrapper which would run MediaWi... [21:53:04] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, I18n: [Epic] Use translatable pages for banner content - https://phabricator.wikimedia.org/T116235#2833024 (awight) Hi @Nemo_bis, thanks for taking a look at the issue. This was erratic and wishful thinking on my part, for sure, and... [21:57:12] (CR) Cdentinger: [C: 2] Bandaid for Big English board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324261 (https://phabricator.wikimedia.org/T151820) (owner: Ejegg) [21:58:26] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, I18n: [Epic] CentralNotice translation should move closer to MediaWiki i18n standards and the code cleaned up - https://phabricator.wikimedia.org/T116235#2833058 (awight) [22:05:48] Fundraising-Backlog: missing utm_medium in the donation link - https://phabricator.wikimedia.org/T151951#2833097 (DStrine) [22:06:07] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can't access thank_you module configuration form - https://phabricator.wikimedia.org/T151941#2833109 (ggellerman) p:Triage>Normal [22:07:27] Fundraising-Backlog: missing utm_medium in the donation link - https://phabricator.wikimedia.org/T151951#2833112 (ggellerman) Talk to @K4-713 if you need more info [22:07:43] Fundraising-Backlog: missing utm_medium in the donation link - https://phabricator.wikimedia.org/T151951#2833114 (ggellerman) a:awight [22:08:13] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: missing utm_medium in the donation link - https://phabricator.wikimedia.org/T151951#2833135 (DStrine) [22:09:03] Fundraising Dash, Fundraising-Backlog: add a widget to the dash that shows last year's day-by-day totals - https://phabricator.wikimedia.org/T151908#2833143 (ggellerman) p:Triage>Normal [22:09:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Html2Text should be included as a composer dependency - https://phabricator.wikimedia.org/T151841#2833146 (ggellerman) p:Triage>Normal [22:11:27] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Determine impact of mobile CSS changes - https://phabricator.wikimedia.org/T151815#2833169 (ggellerman) p:Triage>Normal [22:11:54] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Determine impact of mobile CSS changes - https://phabricator.wikimedia.org/T151815#2833175 (DStrine) [22:13:29] Fundraising-Backlog: Generate statistics of errors vs donation attempts - https://phabricator.wikimedia.org/T151817#2833191 (ggellerman) p:Triage>Normal [22:14:37] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: missing utm_medium in the donation link - https://phabricator.wikimedia.org/T151951#2833195 (K4-713) Update: Just kidding! This spike that was landing in an unknown category, is largely "MGAnnual_email". Apparently we d... [22:15:21] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: missing utm_medium in the donation link - https://phabricator.wikimedia.org/T151951#2833196 (K4-713) Open>Resolved [22:18:56] Fundraising-Backlog, FR-Smashpig: Don't log: "Data is not null, time limit (90) is not elapsed, message limit (700) is not reached." - https://phabricator.wikimedia.org/T151954#2833216 (awight) [22:22:08] Fundraising-Backlog, FR-Smashpig: Don't log: "Data is not null, time limit (90) is not elapsed, message limit (700) is not reached." - https://phabricator.wikimedia.org/T151954#2833216 (cwdent) +1 this scared me in some unrelated fail mail [22:33:47] !log disabled CiviMail activity creation for thank you sender [22:33:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:37:54] Fundraising-Backlog, FR-Smashpig: Don't log: "Data is not null, time limit (90) is not elapsed, message limit (700) is not reached." - https://phabricator.wikimedia.org/T151954#2833328 (DStrine) p:Triage>Normal [22:46:33] (PS1) Ejegg: Less noisy queue consumer logging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/324343 (https://phabricator.wikimedia.org/T151954) [22:49:29] !log extended donation queue consumer duty cycle from 90 to 105 seconds [22:49:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:55:04] fr-tech noise cancellation for qc log: https://gerrit.wikimedia.org/r/324343 [22:55:21] back soon! [23:11:21] jeez, like 5k in tge queue [23:18:40] may be abating though [23:20:36] my recollection from last year is like 10k queues taking days to catch up [23:22:21] Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Unplanned-Sprint-Work: missing utm_medium in the donation link - https://phabricator.wikimedia.org/T151951#2833503 (awight) Resolved>Invalid [23:22:25] back in the horse and buggy days [23:22:33] * awight backscrolls for that [23:22:59] haha k [23:25:21] (CR) Ejegg: [C: 2] Revert "Enable syslog on OSX" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324262 (owner: Ejegg) [23:25:23] (CR) Ejegg: [C: 2] Revert "Change package node-syslog to modern-syslog" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324263 (owner: Ejegg) [23:26:41] (Merged) jenkins-bot: Revert "Enable syslog on OSX" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324262 (owner: Ejegg) [23:27:50] (Merged) jenkins-bot: Revert "Change package node-syslog to modern-syslog" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324263 (owner: Ejegg) [23:28:10] (Merged) jenkins-bot: Bandaid for Big English board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/324261 (https://phabricator.wikimedia.org/T151820) (owner: Ejegg) [23:29:37] k, deploying that [23:29:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Regression: Banner "B1617_112919_en6C_dsk_p1_lg_bdr_prp" makes login, signup and search inaccesible - https://phabricator.wikimedia.org/T151962#2833511 (Krinkle) [23:30:13] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Regression: Banner "B1617_112919_en6C_dsk_p1_lg_bdr_prp" makes login, signup and search inaccesible - https://phabricator.wikimedia.org/T151962#2833523 (Krinkle) p:Triage>Unbreak! [23:33:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Regression: Banner "B1617_112919_en6C_dsk_p1_lg_bdr_prp" makes login, signup and search inaccesible - https://phabricator.wikimedia.org/T151962#2833566 (Krinkle) One way to solve the immediate problem is applying `overflow: hidden;` to the `#fr... [23:34:30] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/324349 [23:34:35] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/324349 (owner: Ejegg) [23:34:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Regression: Banner "B1617_112919_en6C_dsk_p1_lg_bdr_prp" makes login, signup and search inaccesible - https://phabricator.wikimedia.org/T151962#2833569 (Krinkle) [23:37:21] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/324349 (owner: Ejegg) [23:37:49] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Regression: Banner "B1617_112919_en6C_dsk_p1_lg_bdr_prp" makes login, signup and search inaccesible - https://phabricator.wikimedia.org/T151962#2833585 (Krinkle) p:Unbreak!>High This seems to happen in Chrome 57 (canary), but not in Chr... [23:40:02] ut-oh, do we have a banner wizard awake? ^^^ [23:41:34] !log updated fundraising dashboard from 43039fde037aa983d4490da08c8072bb2788e28a to 7ce4f03da78fe0469727033db8d514e9596dd9ac [23:41:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:41:57] donations queue seems to have peaked just above 5k [23:43:03] tide is high, but we're holding on [23:46:04] ejegg: woohoo! yeah I see it's leveled off :D \o/ [23:46:43] hehe, email was like half of that record hour. people really are acting as soon as they get the emails, I think! [23:47:33] gtd [23:47:39] (getting things done) [23:47:54] the future is... organized? [23:48:08] * AndyRussG spreads a bit of chaos just in case [23:48:10] or pavlovian [23:48:27] coming right off an election cycle... [23:48:38] Good thing we've got a bell then? [23:48:47] Candidate X needs your money now! [23:49:04] I was worried that would have kept donations down, infact [23:49:20] glad to see it's not! [23:49:36] woot, dash big english widget shows stuff for today now [23:49:37] though also the US election might have had a positive impact on FR for other reasons, too...... [23:49:43] banner message errors also seem fine on logstash [23:49:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank you letter from civi mangles non-$ currencies - https://phabricator.wikimedia.org/T151957#2833629 (Eileenmcnaughton) [23:51:55] now more than ever... [23:53:02] cool! [23:56:40] the-wub: fyi I'm trying to get a git repo for your stats tools [23:56:44] sorry it took... a year.