[00:00:08] (CR) Eileen: [C: 2] Attempt to get a few more blanked addresses. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343796 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [00:00:24] ejegg: What URL are you using? [00:00:39] https://mediawiki.dev/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vmad&recurring=&uselang=en&language=en¤cy_code=USD&country=US&amount=.01 [00:00:41] (Merged) jenkins-bot: Attempt to get a few more blanked addresses. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343796 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [00:00:42] I don't see that error with http://payments.dev/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vmad&payment_method=cc&recurring=&uselang=en&language=en¤cy_code=USD&amount=0.1&country=US [00:00:52] daf... [00:00:57] orly? [00:01:05] lemme open in privtab [00:01:42] same thing with your URL, and same in private mode [00:01:44] erp? [00:02:03] wtf!!! now not seeing the name fields, but red errors on street/city/state/zip [00:02:07] ummmm [00:02:27] well I broke everything, then [00:02:39] But I'll need to reproduce that locally [00:02:57] !log update civicrm from e058e8cf2377d6964eec909990e9f592275822c6 to f454f16bc68a19578ddc270bac088546dd243a27 [00:03:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:03:48] http://imgur.com/a/gFACY [00:04:43] ejegg: Why do you have a continue button rather than card radios? [00:05:04] Those errors are correct if you've clicked a card type [00:05:20] yeah, this is very odd [00:05:32] same behavior in a freshly opened other-browser though [00:05:54] and when I go back to master, the right fields show up with only the minimum message in red [00:05:55] I don't see how anything in the changes I made can be selecting a card type [00:06:09] it's not even showing the card types... [00:06:09] This is after loading the GET url, no clicks? [00:06:12] right. [00:06:13] awight: yep [00:06:19] dag [00:06:42] I'm using FF also [00:06:48] commit 676b8ab5d5102fbc273918fd9a761f71918cc034 [00:07:10] err, that's rebased on top of a bunch of other changes [00:07:18] lemme try just cherrypicking the one [00:08:02] uh [00:08:03] conflict [00:08:05] yeah [00:08:12] I wouldn't recommend that [00:08:21] I'm on the same commit, so that's good [00:10:10] i must have something screwed up locally [00:10:24] hehe yeah you have my code installed [00:11:05] haha [00:11:39] Reading through, I think you're getting an empty response from getAvailableSubmethods [00:11:48] oh snap [00:12:12] i changed something vaguely related for iDEAL [00:12:20] but... really shouldn't touch that code [00:12:36] git status says all clean [00:12:46] haven't scrambled my yaml configs [00:12:47] oh hey, I'm on a slightly different commit, my bad. [00:12:59] I'm on https://gerrit.wikimedia.org/r/343795 [00:13:14] ohh, lemme try that [00:13:36] which is... after the one I was on [00:13:40] AHA [00:13:48] cool. I have just a continue button, now. [00:13:55] oooh [00:14:14] this non-deterministic behavior is befuddling [00:14:42] (CR) jerkins-bot: [V: -1] [WIP] Perform currency fallback earlier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343795 (owner: Awight) [00:15:08] :D now I get your error with both the newer commit and the commit you're on. [00:15:13] "good" [00:15:28] jeez, now ff has name fields and chromium doesn't [00:15:45] you've obviously opened a portal to the chaos dimension [00:15:58] * ejegg greps for satanic incantations [00:16:36] oh evil: PHP is spelled the same backwards [00:16:44] haha [00:16:45] We wouldn't even know if it turned satanic [00:17:05] sneaky palindrome [00:17:57] ub... now missing name fields on master [00:18:05] O_O [00:18:05] * ejegg checks production [00:18:35] * awight checks on status of leave request [00:18:54] ah damn: https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vmad&recurring=&uselang=en&language=en¤cy_code=USD&country=US&amount=.01 [00:18:59] flee while you can! [00:19:08] We're all so fired [00:19:13] filing unbreaknow [00:19:16] ty [00:19:23] actually--let's shut it down [00:19:31] that's only for amount too low [00:19:35] ooh [00:19:40] normal donation is fine [00:19:44] thank you for not overreacting, then [00:19:55] https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vmad&recurring=&uselang=en&language=en¤cy_code=USD&country=US&amount=1 [00:20:04] hehe [00:20:06] shut it down! [00:20:08] ??? [00:20:11] iono [00:20:21] synchronize safekeys? [00:20:40] https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vmad&payment_method=cc&recurring=&uselang=en&language=en¤cy_code=GBP&country=GB&amount=2.01 [00:20:44] looks fine to me [00:20:51] I have no name fields. [00:21:01] your link worked. [00:21:01] fack. i see 'em [00:21:07] u try my link? [00:21:13] ARGH [00:21:16] yeah, it was fine too [00:21:16] name fields came back [00:21:22] oooh, session thing [00:21:30] if I hit the amount too low [00:21:32] now name fields appear even with 0.01 [00:21:39] then all subsequent loads are broken [00:21:48] not what I see [00:21:57] maybe only when the amount too low is the first thing in the session? [00:22:00] I can hit low amount and still have name fields [00:22:01] omg [00:22:11] let's check Civi for nameless [00:22:18] I can do it [00:22:42] wait, is donation.api allowing it? [00:23:25] nope 'There was an error processing your request' [00:23:34] shouldn't get further than that first page [00:23:50] yeah no evidence in civi [00:24:06] durn, MBeat knocked off ten minutes ago [00:24:17] I'll check zendesk nonetheless [00:26:10] Fundraising Sprint Far Beer, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Amount error breaks name fields - https://phabricator.wikimedia.org/T160968#3116664 (Ejegg) [00:26:31] Fundraising Sprint Far Beer, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Amount error breaks name fields - https://phabricator.wikimedia.org/T160968#3116676 (Ejegg) p:Triage>Unbreak! [00:27:48] Eek, we don't have access to the donor's initial report? [00:29:17] ah snap, freal? [00:29:34] ok, so somehow the payment_method isn't set when we do the amount correction [00:31:14] Fundraising Sprint Far Beer, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Amount error breaks name fields - https://phabricator.wikimedia.org/T160968#3116664 (awight) I don't agree with assumption that it's the amount error. I can cause missing name fields... [00:32:03] Fundraising Sprint Far Beer, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Amount error breaks name fields - https://phabricator.wikimedia.org/T160968#3116691 (Ejegg) that URL has no payment method [00:33:02] hehe [00:33:03] were we ever setting a default payment method? [00:33:10] That was the URL we've been playing with [00:33:18] good catch. That's totally the problem. [00:33:34] No, I don't think we've ever had a default payment method [00:34:03] I can't make the name fields disappear when the URL has a payment method [00:34:51] Fundraising Sprint Far Beer, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Amount error breaks name fields - https://phabricator.wikimedia.org/T160968#3116694 (awight) Good catch--now I think this is a normal priority bug, and rather than amount error, is jus... [00:35:10] yepppp, let's reprioritize [00:37:24] Fundraising Sprint Far Beer, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Missing payment_method in gateway page URLs is really confusing - https://phabricator.wikimedia.org/T160968#3116696 (Ejegg) p:Unbreak!>Normal [00:37:58] ok, lemme look at your patch again with a worky URL [00:40:03] awight: all the fields are there, but there are red errors for blanks on GET [00:40:11] ah, lemme try privtab [00:40:17] * awight rubs eyes [00:40:32] yep, still seeing red [00:40:44] URL if you would [00:43:01] https://mediawiki.dev/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vmad&payment_method=cc&recurring=&uselang=en&language=en¤cy_code=USD&country=US&amount=.01 [00:43:10] just added payment_method to the other one [00:44:25] haha I get a generic payment error with no logging [00:44:32] Maybe I should commute and take a look later [00:44:50] yeah, i'm bout to sign off too [00:45:01] see ya on the flipside! [00:45:37] I... just realized something about the fallback edge cases [00:45:45] yah? [00:45:54] If we're notifying, then it doesn't matter. [00:46:00] The donor still has to press Continue [00:46:08] At which point, the other validation will be surfaced. [00:46:26] hmm, k, just an extra step in rare cases [00:46:56] (Abandoned) Awight: [WIP] Perform currency fallback earlier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343795 (owner: Awight) [00:47:24] Tomorrow, I'll focus on encapsulating error objects [00:47:30] woohoo [00:47:44] let's not localize till the form layer [00:47:50] just message key + params [00:48:13] good call [00:48:21] mmm maybe [00:48:34] What's your motivation? [00:50:11] ejegg: We'll catch up Tues! [00:50:24] k, see ya! [00:50:45] awight: motivation was to keep smashpig independent of i18n systems [00:50:59] but i'm open to discussing simplei18n [00:51:11] kk that's a great argument [00:51:34] totally had a ticket, can't find [01:07:42] (PS1) Eileen: Further attempt to recover blank addresses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343804 (https://phabricator.wikimedia.org/T159408) [01:10:53] ejegg[m]: I just pushed up another tweak, last one got us about 1500 more addresses - this one allows us to look at addresses that went through multiple merges https://gerrit.wikimedia.org/r/#/c/343804/ [01:11:34] it is still only recovering if there is only one address. I'll do this run & then the last run can just choose the delete with the most recent timestamp [01:19:03] eileen: on a bus, but I'll review in 20 min! [01:21:48] ejegg[m]: thanks! [01:43:30] (PS1) Eileen: Blank addresses, finally deal with ones with more than one deleted. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343806 (https://phabricator.wikimedia.org/T159408) [01:50:45] (CR) Ejegg: [C: 2] "Looks legit!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343804 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [01:55:22] (Merged) jenkins-bot: Further attempt to recover blank addresses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343804 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [01:57:25] (PS1) Eileen: Further attempt to recover blank addresses. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343807 (https://phabricator.wikimedia.org/T159408) [01:57:57] (CR) Eileen: [C: 2] "merge to deploy" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343807 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [01:59:39] !log update civicrm from f454f16bc68a19578ddc270bac088546dd243a27 to 0ed1659d679d015f3f5ff223bc0684de6f249bbf [01:59:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:01:16] ejegg[m]: I'm running that now & then I think the final one will be https://gerrit.wikimedia.org/r/#/c/343806/ [02:02:28] hmm getting some enotice running that :-( [02:04:52] (PS2) Eileen: Blank addresses, finally deal with ones with more than one deleted. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343806 (https://phabricator.wikimedia.org/T159408) [02:05:27] I think the enotices don't matter [02:06:01] next round will fix, but I think they are not material [02:21:03] oh shoot, was it line 78, with the if statement followed by a semicolon [02:21:11] sorry, i was too hasty reviewing [02:24:45] ejegg: yep but fixed in here https://gerrit.wikimedia.org/r/#/c/343806/ [02:24:57] k, I see [02:25:05] & I think it's still a safe change [02:25:10] even if a little flawed [02:31:59] uff, having trouble following the array_intersect_keys bits [02:33:05] eileen: on line 158, won't the array_intersect_key return the values from $deletedAddress, not the 1s ? [02:33:32] then on line 160, array_keys($deletedAddressDetails, 1) wouldn't return anything [02:33:46] i must be missing something [02:37:24] ejegg: so on line 158 the goal is to get the values from $deletedAddress that are 'material' [02:37:31] so it works as a filter on the array [02:38:13] ok, so $deletedAddressDetails is a filtered array of fields with the address keys and address values [02:38:23] like 'city' => 'fooville' [02:39:06] but then array_keys($deletedAddressDetails, 1) will only return keys whose value is 1, right? [02:39:41] ejegg: you are right, it should be array_fill_keys [02:39:41] again [02:39:53] k [02:40:12] nope [02:40:18] should just be addressdetisl [02:40:31] ah yeah [02:40:53] (PS3) Eileen: Blank addresses, finally deal with ones with more than one deleted. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343806 (https://phabricator.wikimedia.org/T159408) [02:40:53] ejegg: just updated [02:41:00] looking [02:41:33] & just running the test again - oddly it passed - which makes me think it worked 'by accident' [02:41:47] heh, oops [02:41:48] ie. I did do something wrong but it seemed to somehow work anyway [02:42:49] tests still pass [02:43:31] ah, so the only consequence was that $deletedAddressDetails would never == $addressDetails [02:43:46] and you would always fall through to the $updates = $deletedAddressDetails [02:44:34] ah right - yeah [02:44:57] my testing was pretty minimal - it was more of a 'one last effort' check [02:46:53] k, next question is should lines 162-168 be inside the foreach ($addresses['values'] as $address) block ? [02:47:46] yeah - probably! [02:48:09] sorry for the piecemeal review... [02:48:15] (PS4) Eileen: Blank addresses, finally deal with ones with more than one deleted. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343806 (https://phabricator.wikimedia.org/T159408) [02:48:26] no - I'm just sorry I made so many mistakes in so few lines! [02:48:31] fix pushed [02:50:27] (CR) Ejegg: Blank addresses, finally deal with ones with more than one deleted. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343806 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [02:54:59] (PS5) Eileen: Blank addresses, finally deal with ones with more than one deleted. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343806 (https://phabricator.wikimedia.org/T159408) [02:55:21] (CR) Eileen: Blank addresses, finally deal with ones with more than one deleted. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343806 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [02:56:24] (CR) Ejegg: [C: 2] "Looks like the winning ticket" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343806 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [02:57:04] ejegg: thanks for hanging in there on that one! [02:57:39] no problem!.Thanks for rescuing this last batch! [03:01:03] (Merged) jenkins-bot: Blank addresses, finally deal with ones with more than one deleted. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343806 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [03:01:31] k, signing off for reals. have a good one! [03:08:54] (PS1) Eileen: Blank addresses, finally deal with ones with more than one deleted. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343811 (https://phabricator.wikimedia.org/T159408) [03:09:09] (CR) Eileen: [C: 2] Blank addresses, finally deal with ones with more than one deleted. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343811 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [03:09:47] (Merged) jenkins-bot: Blank addresses, finally deal with ones with more than one deleted. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343811 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [03:10:57] !log update civicrm from 0ed1659d679d015f3f5ff223bc0684de6f249bbf to 21afe66b621d36e285fc5a041bd26e8083287a04 [03:11:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:29:15] (PS1) Eileen: Exclude known bulk updates from blank address analysis, otherwise it will never finish [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343814 [03:33:52] (CR) Ejegg: [C: 2] Exclude known bulk updates from blank address analysis, otherwise it will never finish [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343814 (owner: Eileen) [03:36:08] (PS1) Eileen: Exclude known bulk updates from blank address analysis, otherwise it will never finish [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343815 [03:36:32] (CR) Eileen: [C: 2] Exclude known bulk updates from blank address analysis, otherwise it will never finish [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343815 (owner: Eileen) [03:38:13] !log update civicrm from 21afe66b621d36e285fc5a041bd26e8083287a04 to 92e3b850d7dbe9719ab86ba2d1c2489c60c0dcc0 [03:38:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:01:02] (PS1) Eileen: Exclude another bulk update. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343818 (https://phabricator.wikimedia.org/T159408) [15:11:54] (CR) Cdentinger: [C: 2] Create a bin dir [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343761 (owner: Awight) [15:12:23] (Merged) jenkins-bot: Create a bin dir [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343761 (owner: Awight) [15:13:24] (CR) Cdentinger: [C: 2] Only run under python3 [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343763 (owner: Awight) [15:13:52] (Merged) jenkins-bot: Only run under python3 [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343763 (owner: Awight) [15:19:18] (CR) Cdentinger: [C: 2] "Two nitpicks but not blockers." (2 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343764 (owner: Awight) [15:19:45] (Merged) jenkins-bot: House modules under a package [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343764 (owner: Awight) [15:23:36] hmm… how easy is it to lock yourself out of ssh-ing into our servers? [15:23:47] I had a couple bad yubikey hits and it won’t connect anymore :( [15:27:15] ccogdill: heh yeah it will throttle you [15:27:40] it will let you back in soon [15:28:00] actually jeff showed me how to check on bans... /me opens notes [15:51:22] ad cwd thanks! Jeff got me unblocked [15:51:41] do you know if there’s a way for me to check on my own? [15:52:54] ccogdill_: unfortunately not, it's buried in the server [15:53:03] figured as much [15:53:06] but if it's rejecting yubikey pass chances are that's what it is [15:53:22] ccogdill_: this is the mechanism https://en.wikipedia.org/wiki/Fail2ban [15:53:37] brute-force attacks! [15:53:42] yep, that’s what I was up to :P [15:54:01] heh [16:19:52] (CR) Cdentinger: [C: 2] Debian packaging [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343218 (owner: Awight) [16:24:28] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Missing payment_method in gateway page URLs is really confusing - https://phabricator.wikimedia.org/T160968#3118213 (Ejegg) [16:29:25] (CR) Ejegg: [C: 2] Exclude another bulk update. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343818 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [16:32:42] (CR) Ejegg: [C: -1] "Want to change this to use a currency that won't trigger the minimum error (and squash with the following patch so it still passes)?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341478 (owner: Awight) [16:32:57] (Merged) jenkins-bot: Debian packaging [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343218 (owner: Awight) [16:43:48] cwd no more 'crash-override' ? [16:44:03] just run-job ? [16:45:41] heh, i guess [16:45:43] didn't even notice [16:48:15] (Merged) jenkins-bot: Exclude another bulk update. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343818 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [16:59:52] :p [17:00:43] fr-tech: Penguin Trivia #46: [17:00:43] Animals who are not penguins can only wish they were. [17:00:43] -- Chicago Reader 10/15/82 [17:00:43] -- discuss. [17:05:09] So also computers that don't run Linux can only wish they did? [17:05:25] That would make more sense [17:05:27] Or at least wish they had cuter desktop backgrounds [17:05:31] * AndyRussG waddles [17:05:38] Heh [17:06:47] duck typed! [17:12:14] fr-tech: fwiw I dropped my day's fun into the etherpad. Anybody have discussion topics though? [17:14:29] awight: I'm avoiding in the hopes of getting out some banner sequence. It's going OK, I'm pretty sure of the route at this point. Hope that's OK! [17:15:02] Got some feedback on -editing yesterday about oojs-ui... [17:15:06] (PS1) Awight: Merge branch 'debian-packaging' of github.com:adamwight/process-control into debian-packaging [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343921 [17:15:26] Sounds intriguing [17:16:04] it's all just for suspense! [17:16:15] hi awight [17:16:22] and AndyRussG ! [17:16:27] * AndyRussG turns up the intrigue slider widget [17:16:37] ejegg: hey! [17:16:50] awight: about to slap up a WIP for objectified global config [17:18:20] (PS1) Ejegg: WIP config object [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 [17:18:47] (CR) jerkins-bot: [V: -1] WIP config object [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 (owner: Ejegg) [17:19:03] in a quiet library, but if others are discussing I can listen and type in the chat [17:19:21] (Abandoned) Awight: [WIP] Debian packaging [wikimedia/fundraising/process-control] (debian-packaging) - https://gerrit.wikimedia.org/r/343129 (owner: Awight) [17:20:11] (PS5) Awight: Fix flake8 typos [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343121 [17:20:20] i feel like we are on a pretty good roll w/ process-control [17:20:35] (Abandoned) Awight: Fix flake8 typos [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343121 (owner: Awight) [17:20:36] hope to deploy a job today [17:21:15] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, and 6 others: Benevity: Create an import method for matching gifts and payroll deduc... - https://phabricator.wikimedia.org/T115044#3118380 [17:23:02] awight want to let me know if https://gerrit.wikimedia.org/r/343922 is totally off-base? [17:36:35] kk [17:48:45] ahh, got stunnel working and am finally able to ssh on these damn restrictive networks! [17:52:46] (CR) Awight: "I love the direction this is headed in!" (10 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 (owner: Ejegg) [17:54:12] (CR) Awight: "Sweet! Thank you and come back often." [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343389 (owner: Cdentinger) [17:56:03] back in 30-60 [17:59:30] thanks awight|afk [18:42:02] (PS2) Ejegg: Config objects [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 [18:42:29] (CR) jerkins-bot: [V: -1] Config objects [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 (owner: Ejegg) [18:46:04] (CR) Awight: "Thanks! I didn't have time for a careful review yet, but picking a bone with the dict inheritance." (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 (owner: Ejegg) [18:57:44] (PS3) Ejegg: Config objects [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 [18:58:12] (CR) jerkins-bot: [V: -1] Config objects [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 (owner: Ejegg) [19:07:20] (PS3) XenoRyet: Recurring Message Normalization. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) [19:07:28] (PS4) Ejegg: Config objects [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 [19:17:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] Engage exclusively uses spreadsheet imports - https://phabricator.wikimedia.org/T114683#3118891 (Eileenmcnaughton) [19:17:55] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, and 6 others: Benevity: Create an import method for matching gifts and payroll deduc... - https://phabricator.wikimedia.org/T115044#3118890 [19:17:57] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, and 6 others: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#3118892 (Eileenmcnaughton) [19:21:32] (CR) Ejegg: [C: -1] "Gateway is coming out wrong, can still delete some code." (5 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) (owner: XenoRyet) [19:22:52] (CR) Ejegg: "well shucks, i like the lazy way..." [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 (owner: Ejegg) [19:30:26] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog: Update error message to ask donors for more specific information/include transaction ID - https://phabricator.wikimedia.org/T121530#3118997 (MBeat33) Open>Resolved a:MBeat33 I am marking this resolved because the Ingenico error me... [19:30:29] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Testing on Production, Fundraising Sprint Unbreaking Now, and 10 others: [Epic] Do not show donation form error message: "No processors available". Fi... - https://phabricator.wikimedia.org/T117872#3119000 [19:47:41] (PS5) Ejegg: Config objects [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 [19:48:27] (CR) jerkins-bot: [V: -1] Config objects [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 (owner: Ejegg) [19:49:28] <3 "jerkins" [19:54:53] haha when did that happen [19:55:35] (PS1) AndyRussG: [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 [19:56:15] (PS1) Awight: target python2 for now [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343954 [19:56:20] cwd: ^ [20:00:21] cool [20:00:35] i notice stdout_destination is /tmp ... do we want that somewhere more permanent? [20:01:08] (CR) jerkins-bot: [V: -1] [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (owner: AndyRussG) [20:01:20] cwd: That's just an example config [20:01:39] IIRC, the only place /tmp appears in the code is for lockfiles [20:01:48] (which yeah should be in /var unless !privs) [20:02:24] what's a good stdout location? /var/log ? [20:04:33] uh [20:04:42] maybe an /a subdir? [20:06:34] this file will basically be the replacement of the jenkins logs right? [20:07:46] yep [20:10:12] Jeff_Green: you got an opinion on where we could stick those? gonna be a lot of stuff. [20:10:55] whos' breaking frdb2001? [20:12:29] Jeff_Green: Why does that sound like codfw? [20:12:49] nvm, I see it's resolving [20:14:36] my recommendation is /dev/null :-) [20:17:25] heh [20:17:27] yolo [20:17:32] I like it, but gradually [20:21:22] (PS1) Awight: Use argparse to read the CLI; cron-generate is flaggy rather than pipey [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343960 [20:29:46] Wikimedia-Fundraising-Campaigns (FY Q3 Jan-Mar 2017), Wikimedia-CentralNotice-Administration (Q1-2017): WMF Fundraising - 2016-17 - Norway (21 Feb - 21 Mar) - https://phabricator.wikimedia.org/T157117#3119256 (Pcoombe) Open>Resolved a:Pcoombe [20:29:55] Wikimedia-Fundraising-Campaigns (FY Q3 Jan-Mar 2017), Wikimedia-CentralNotice-Administration (Q1-2017): WMF Fundraising - 2016-17 - Denmark (Feb 21 - Mar 21) - https://phabricator.wikimedia.org/T157118#3119258 (Pcoombe) Open>Resolved a:Pcoombe [20:35:17] (PS1) Awight: Fixes suggested by thcipriani [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343965 [20:35:36] (CR) Awight: "Fixes implemented in I03592650c63907ffa4e14a1a136372bff3038f79" (4 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343389 (owner: Cdentinger) [20:40:07] Fundraising-Backlog: process-control should have a mode to display all the things it's currently running - https://phabricator.wikimedia.org/T160700#3108184 (awight) Sounds like we might want a database? This would let us build inevitable features like job failure counts and history. [20:41:38] Fundraising-Backlog: process-control will need to run some jobs sequentially - https://phabricator.wikimedia.org/T161035#3119337 (awight) [20:48:02] (CR) Awight: Comments from thcipriani (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343389 (owner: Cdentinger) [20:48:53] (CR) Awight: [C: -1] "Looks abandonable?" [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343417 (owner: Ejegg) [20:49:41] (Abandoned) Awight: Merge branch 'debian-packaging' of github.com:adamwight/process-control into debian-packaging [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343921 (owner: Awight) [20:52:16] (PS1) Awight: Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 [20:55:49] fr-tech: yinz mind doing backlog grooming without me? I need some heads-down time today... [20:56:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, MediaWiki-extensions-DonationInterface, Continuous-Integration-Infrastructure (Little Steps Sprint): Disable fundraising CI jobs that are non-voting and always fail - https://phabricator.wikimedia.org/T160476#3119424 (hashar) p:... [20:57:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, MediaWiki-extensions-DonationInterface, Continuous-Integration-Infrastructure (Little Steps Sprint): Disable fundraising CI jobs that are non-voting and always fail - https://phabricator.wikimedia.org/T160476#3119428 (awight) @h... [21:01:40] fr-tech i'll be there in just a couple min! [21:02:05] (PS1) Eileen: Rewrite update to be batched [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343972 (https://phabricator.wikimedia.org/T158268) [21:07:39] AndyRussG: you around? [21:08:33] Fundraising-Backlog: process-control will need to run some jobs sequentially - https://phabricator.wikimedia.org/T161035#3119471 (ggellerman) p:Triage>High [21:09:21] dstrine: He was saying he has to miss it today [21:09:31] ok [21:10:51] Fundraising Sprint Far Beer, Fundraising-Backlog: process-control will need to run some jobs sequentially - https://phabricator.wikimedia.org/T161035#3119512 (ggellerman) [21:12:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949#3119519 (ggellerman) p:Triage>Normal [21:13:32] Fundraising-Backlog: process-control should have a mode to display all the things it's currently running - https://phabricator.wikimedia.org/T160700#3119537 (Ejegg) p:Triage>Normal [21:14:00] (PS2) Eileen: Rewrite update to be batched [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343972 (https://phabricator.wikimedia.org/T158268) [21:14:32] Fundraising-Backlog: process-control should be able to disable groups of jobs - https://phabricator.wikimedia.org/T160699#3108169 (Ejegg) p:Triage>Normal [21:15:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Errors in CiviCRM dedupe scrren - https://phabricator.wikimedia.org/T160571#3119567 (ggellerman) p:Triage>Normal [21:15:55] (CR) Cdentinger: [C: 2] target python2 for now [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343954 (owner: Awight) [21:16:12] Jeff_Green: oh *bing* ^ [21:16:23] bing? [21:16:23] Fundraising Sprint Far Beer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Errors in CiviCRM dedupe scrren - https://phabricator.wikimedia.org/T160571#3119574 (DStrine) [21:16:27] oh bing! [21:16:43] 8D [21:16:52] your toast is ready. [21:17:28] it appears to be one of those conveyor toasters, that very slowly burns one side of your toast to a crisp and then drops it on the floor [21:17:42] Fundraising-Backlog, MediaWiki-extensions-ContributionTracking, Patch-For-Review, Scap (Scap3-MediaWiki-MVP): Clean up Contribution Tracking settings in main wmf config repo - https://phabricator.wikimedia.org/T147479#3119592 (ggellerman) p:Triage>Normal [21:17:44] nothing yet, maybe they're stuck behind the other jenkins? [21:18:13] Oh hey, we have the same sandwich from an online order earlier this mornign. [21:19:44] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: [Tech Debt] Pass gateway to transformers through their constructor - https://phabricator.wikimedia.org/T159909#3119635 (ggellerman) p:Triage>Normal [21:19:49] (Abandoned) Ejegg: Global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343417 (owner: Ejegg) [21:21:24] Fundraising-Backlog, FR-Ingenico, FR-Smashpig, MediaWiki-extensions-DonationInterface, Technical-Debt: [Tech Debt] Encapsulate DonationInterface errors in SmashPig - https://phabricator.wikimedia.org/T159897#3119679 (ggellerman) p:Triage>Normal [21:21:28] (Merged) jenkins-bot: target python2 for now [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343954 (owner: Awight) [21:22:07] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Technical-Debt: Rename getData_Unstaged_Escaped to getNormalized - https://phabricator.wikimedia.org/T134548#3119684 (Ejegg) p:Triage>Normal [21:23:53] Fundraising-Backlog, FR-Adyen: Invalid something response from Adyen displays unhelpful "Previous" button in the iframe. - https://phabricator.wikimedia.org/T159275#3062565 (ggellerman) @awight Do you have steps to repro? Thanks! [21:24:43] Fundraising-Backlog, FR-Adyen: Invalid something response from Adyen displays unhelpful "Previous" button in the iframe. - https://phabricator.wikimedia.org/T159275#3119692 (awight) Pretty sure it's misconfiguration, probably bad account info. Other than that, no steps. [21:25:51] (PS3) Eileen: Rewrite update to be batched [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343972 (https://phabricator.wikimedia.org/T158268) [21:26:11] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Investigate update payments to REL1_28 - https://phabricator.wikimedia.org/T159273#3119708 (ggellerman) [21:26:26] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Spike: Investigate update payments to REL1_28 - https://phabricator.wikimedia.org/T159273#3062530 (ggellerman) [21:29:16] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Spike: Investigate update payments to REL1_28 - https://phabricator.wikimedia.org/T159273#3062530 (Ejegg) 1.29 will come out in June 2017, and 1.28 EOLs in November 2017. Maybe skip ahead to 1.29? [21:32:24] cwd: https://phabricator.wikimedia.org/T158717 [21:34:38] Fundraising-Backlog, MediaWiki-Vendor, MediaWiki-extensions-DonationInterface: DonationInterface Vendor repo double inclusions - https://phabricator.wikimedia.org/T159099#3056718 (Ejegg) It's a workaround for using DonationInterface outside of MediaWiki - we also load it under CiviCRM to do recurring... [21:42:20] (CR) Ejegg: [C: -1] "Gateway is being clobbered in Job.php line 75. Need to move that logic into the type-specific normalizations." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) (owner: XenoRyet) [21:50:39] (PS1) Eileen: Use drush function for dummy data repair due to speed issues. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/344023 (https://phabricator.wikimedia.org/T158268) [22:01:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, MediaWiki-extensions-DonationInterface, Continuous-Integration-Infrastructure (Little Steps Sprint): Disable fundraising CI jobs that are non-voting and always fail - https://phabricator.wikimedia.org/T160476#3119854 (hashar) Th... [22:14:16] (PS2) Eileen: Use drush function for dummy data repair due to speed issues. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/344023 (https://phabricator.wikimedia.org/T158268) [22:16:44] Fundraising-Backlog, MediaWiki-Vendor, MediaWiki-extensions-DonationInterface: DonationInterface Vendor repo double inclusions - https://phabricator.wikimedia.org/T159099#3119931 (Reedy) Mostly it just annoys PhpStorm... I have everything cloned, so it has multiple copies of the vendor repo, which me... [22:24:12] (PS6) Ejegg: Config objects [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 [22:25:48] * awight perks up [22:31:02] (PS1) Awight: [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 [22:36:23] (PS3) Eileen: Use drush function for dummy data repair due to speed issues. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/344023 (https://phabricator.wikimedia.org/T158268) [22:37:16] (PS1) Ejegg: Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 [22:39:02] (PS4) Eileen: Use drush function for dummy data repair due to speed issues. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/344023 (https://phabricator.wikimedia.org/T158268) [22:40:44] (CR) jerkins-bot: [V: -1] Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 (owner: Ejegg) [22:41:58] (CR) jerkins-bot: [V: -1] [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 (owner: Awight) [22:47:05] (CR) Ejegg: "SQL questions" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343972 (https://phabricator.wikimedia.org/T158268) (owner: Eileen) [22:49:25] ejegg: I wound up re-writing it to drush because it wasn't working at all batched - although per other channel, there was a runaway query https://gerrit.wikimedia.org/r/#/c/344023/ [22:50:18] eileen: oh, the drush one supercedes the SQL ? [22:50:27] maybe the missing 'ON' ? [22:51:04] (PS1) Eileen: Use drush function for dummy data repair due to speed issues. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/344048 (https://phabricator.wikimedia.org/T158268) [22:51:15] ejegg: yeah so all my sql ones were failing & I switched to drush [22:51:28] but, the reason they were failing was the run-away query :-( [22:51:43] eileen: think the SQL ones would work if you added the ON clause to the inner join? [22:51:56] or does mysql automagically match columns by name if you omit that [22:52:22] or if a foreign key is set? [22:52:51] ejegg: yeah - I think I set the rogue query going before testing the mysql ones [22:52:56] & hence they failed [22:53:43] one thought though… if we do use the drush one I can set the log_conn_id per transaction, that is a disadvantage & advantage [22:53:45] so the sql batches should work now? [22:53:59] I can try it again & see... [22:55:01] (PS2) Ejegg: Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 [22:55:40] ejegg: just got an incoming call - will be a few [22:55:48] k [22:58:13] (CR) Awight: [C: 2] "Nice, with the John Carpenter reference and everything!" (7 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 (owner: Ejegg) [22:59:25] (PS7) Ejegg: Config objects [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 [22:59:53] (PS3) Ejegg: Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 [23:00:51] awight i needed the 'from .' to make it run under python3 [23:01:19] should be 'from processcontrol' ? [23:01:40] (CR) Awight: [C: 2] "huh. Okay I'm ready to learn the place of relative imports. Should we be using:" [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 (owner: Ejegg) [23:07:06] (CR) Ejegg: "Python 3 just removed the practice of importing from the current module by default. These could be 'from processcontrol import' for a safe" (3 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 (owner: Ejegg) [23:09:53] (CR) Ejegg: [C: 2] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [23:16:35] (PS4) Eileen: Rewrite update to be batched [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343972 (https://phabricator.wikimedia.org/T158268) [23:19:32] ejegg: you were right - the missing ON was the issue [23:20:23] ah cool, should be simpler than setting up a new drush job, right? [23:21:14] (CR) Eileen: "Yep - the missing OR was the problem!" (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343972 (https://phabricator.wikimedia.org/T158268) (owner: Eileen) [23:21:24] ejegg: yeah [23:21:45] the only advantage of the drush is that it allows us to have a new log_conn_id per change if we want [23:21:46] (CR) Ejegg: [C: 2] "Bam!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343972 (https://phabricator.wikimedia.org/T158268) (owner: Eileen) [23:21:55] but, that's not such a big thing [23:22:00] (Merged) jenkins-bot: Config objects [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343922 (owner: Ejegg) [23:22:12] (Abandoned) Eileen: Use drush function for dummy data repair due to speed issues. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/344023 (https://phabricator.wikimedia.org/T158268) (owner: Eileen) [23:22:31] eileen: feels right for them all to be counted as one update, logging-wise [23:23:05] yeah, it's only a problem when you try to view the change in the UI - but we could fix that by ui fixes if it became more of an issue [23:23:23] (Abandoned) Eileen: Use drush function for dummy data repair due to speed issues. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/344048 (https://phabricator.wikimedia.org/T158268) (owner: Eileen) [23:29:44] (PS1) Eileen: Rewrite update to be batched [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/344056 (https://phabricator.wikimedia.org/T158268) [23:30:06] (CR) Eileen: [C: 2] Rewrite update to be batched [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/344056 (https://phabricator.wikimedia.org/T158268) (owner: Eileen) [23:31:15] (PS1) Ejegg: Comments and cleanup for config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344057 [23:32:25] awight: feeling some resistance to singleton for global config [23:33:04] i guess it would simplify method signatures [23:33:16] but it feels like testing would get harder [23:33:22] meh, not really [23:34:38] eh I'm easy for now [23:34:41] gawd [23:34:51] Having a terrible time with DataValidator::getErrorMessage [23:35:02] I'll make it through, but... [23:35:03] wow [23:36:03] oman [23:36:37] yeah. language/country translation of field name gets plugged into random messages depending on validation type [23:36:47] silly [23:37:08] Oh--I could just encapsulate that as a subtype of ValidationError, perhaps. [23:37:39] no, I'm still boggled. [23:38:23] hrmph. all of that seems like not-the-validator's-problem [23:38:30] agreed [23:38:34] I like this project [23:39:26] XenoRyet: any questions about the normalization comments before I head out? [23:40:35] Nope, actually just finished moving that logic out of Job.php. Was about to push another PS. [23:41:07] It'll be ready for you to take a look at in the morning, if you're willing. [23:41:55] Oh, wait, still need to map the rest of the message types. That shouldn't be long though. [23:42:53] k, cool! [23:43:02] Have a nice evening. [23:44:36] (PS2) Awight: [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 [23:46:05] (CR) Ejegg: "Huge sanity injection! Do we need to make sure validate() gets called after any data gets added post-constructor? Is the orphan slayer rea" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (https://phabricator.wikimedia.org/T160385) (owner: Awight) [23:46:57] ok fr-tech, i'mma head out for the evening. have a good one! [23:47:04] ejegg: cya! [23:51:35] (CR) jerkins-bot: [V: -1] [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 (owner: Awight) [23:53:43] (CR) Eileen: [C: 2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/344056 (https://phabricator.wikimedia.org/T158268) (owner: Eileen) [23:55:03] (PS4) XenoRyet: Recurring Message Normalization. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) [23:57:11] !log update civicrm from 92e3b850d7dbe9719ab86ba2d1c2489c60c0dcc0 to d3c439f6391b8c6d351caf61eacbcc196dac5d7a [23:57:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log