[01:57:54] (PS1) Eileen: CiviCRM composer update. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359896 [01:59:02] (PS2) Eileen: CiviCRM composer update. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359896 [02:43:57] (PS1) Eileen: Upstream mysqli change. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359897 [02:47:30] (CR) jerkins-bot: [V: -1] Upstream mysqli change. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359897 (owner: Eileen) [03:29:47] (PS1) Eileen: Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 [03:33:19] (CR) jerkins-bot: [V: -1] Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 (owner: Eileen) [03:48:29] (PS2) Eileen: Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 [03:52:10] (CR) jerkins-bot: [V: -1] Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 (owner: Eileen) [03:57:00] (PS3) Eileen: Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 [04:01:13] (CR) jerkins-bot: [V: -1] Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 (owner: Eileen) [04:46:27] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 (owner: Eileen) [04:51:05] (CR) jerkins-bot: [V: -1] Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 (owner: Eileen) [04:58:57] (PS3) Eileen: Test tidy ups, ensure data from failed run doesn not break test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352746 [04:59:44] (CR) Eileen: "ejegg - finally got back to this - moved it to the parent tear down class. Figure if it gets done more often that is good since in dev oft" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352746 (owner: Eileen) [05:00:49] (CR) jerkins-bot: [V: -1] Test tidy ups, ensure data from failed run doesn not break test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352746 (owner: Eileen) [05:04:32] (PS1) Eileen: Stop calling deprecated function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359899 [05:04:34] (PS1) Eileen: Remove deprecated function call from unit test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 [05:05:30] (CR) jerkins-bot: [V: -1] Stop calling deprecated function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359899 (owner: Eileen) [05:06:05] (CR) jerkins-bot: [V: -1] Remove deprecated function call from unit test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 (owner: Eileen) [05:07:48] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359899 (owner: Eileen) [05:09:40] (CR) jerkins-bot: [V: -1] Stop calling deprecated function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359899 (owner: Eileen) [05:12:00] (PS4) Eileen: Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 [05:16:56] (CR) jerkins-bot: [V: -1] Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 (owner: Eileen) [05:39:43] (Abandoned) Eileen: 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [05:40:52] (Abandoned) Eileen: Stock Civi 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/350353 (owner: Eileen) [05:52:24] (PS4) Eileen: Test tidy ups, ensure data from failed run doesn not break test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352746 [05:53:03] (PS2) Eileen: Stop calling deprecated function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359899 [05:53:05] (PS2) Eileen: Remove deprecated function call from unit test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 [05:54:15] (CR) jerkins-bot: [V: -1] Remove deprecated function call from unit test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 (owner: Eileen) [06:08:32] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 (owner: Eileen) [06:37:10] (PS5) Eileen: Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 [06:41:57] (CR) jerkins-bot: [V: -1] Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 (owner: Eileen) [06:47:21] (CR) Thiemo Mättig (WMDE): [C: 2] Use short array syntax in alias file [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/359766 (owner: Umherirrender) [06:48:27] (CR) Eileen: "required https://gerrit.wikimedia.org/r/#/c/359900/" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 (owner: Eileen) [07:00:58] (Merged) jenkins-bot: Use short array syntax in alias file [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/359766 (owner: Umherirrender) [07:06:57] (CR) Legoktm: [C: 2] Use short array syntax in alias file [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/359761 (owner: Umherirrender) [07:31:23] (Merged) jenkins-bot: Use short array syntax in alias file [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/359761 (owner: Umherirrender) [08:00:14] (PS6) Eileen: Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 [08:06:13] (CR) jerkins-bot: [V: -1] Upgrade CiviCRM to 4.7.21 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 (owner: Eileen) [08:08:13] (PS3) Eileen: Remove deprecated function call from unit test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 [08:12:32] (CR) jerkins-bot: [V: -1] Remove deprecated function call from unit test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 (owner: Eileen) [10:28:35] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Chinese-Sites, Patch-For-Review: Offer contentlanguage targeting for CentralNotice banners - https://phabricator.wikimedia.org/T53475#577876 (Jseddon) [10:30:36] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Privacy: Add state or city level geotargeting to CentralNotice - https://phabricator.wikimedia.org/T152297#3359711 (Jseddon) [11:58:07] Fundraising-Backlog, Continuous-Integration-Config, Gerrit, Release-Engineering-Team (Kanban): Fully retire MediaWiki "Donate" skin - https://phabricator.wikimedia.org/T124519#3360276 (hashar) Open>Resolved [12:24:57] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Privacy: Add state or city level geotargeting to CentralNotice - https://phabricator.wikimedia.org/T152297#2844220 (Bawolff) The geoip cookie already records the city (And a lat/long), so the data is already there [12:52:03] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Privacy: Add state or city level geotargeting to CentralNotice - https://phabricator.wikimedia.org/T152297#2844220 (Jseddon) Do we know how accurate the data is for different countries? What level of false positives would we be looking at? Seddon [13:25:07] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Privacy: Add state or city level geotargeting to CentralNotice - https://phabricator.wikimedia.org/T152297#3360500 (Bawolff) >>! In T152297#3360412, @Jseddon wrote: > Do we know how accurate the data is for different countries? What level of >... [13:29:51] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Privacy: Add state or city level geotargeting to CentralNotice - https://phabricator.wikimedia.org/T152297#3360509 (Bawolff) I'm not actually sure if it comes from the MaxMind db, and if so what db, but if it does - https://www.maxmind.com/en/g... [15:00:15] mepps: hey I'm on for most of the day. you are too right? [15:00:23] dstrine--yup! [15:00:36] also ejegg i think? [15:00:44] cool I think Eileen is too. I'm down for a tiny standup [15:00:50] oh cool [15:27:44] hey ejegg! [15:36:24] when you're around ejegg i'm now pretty stuck [15:37:15] i mepps! [15:37:18] *hi [15:37:31] sure, want to chat? [15:40:53] sure! [15:41:28] i'm in https://hangouts.google.com/hangouts/_/wikimedia.org/fr-tech-talk?authuser=0 [15:44:18] dstrine: aren't we off today? [15:44:42] cwd: I personally swapped last friday and today [15:44:50] oh right on [15:44:50] I heard others had done some thing similar [15:44:55] * cwd wipes brow [15:45:16] cwd: sorry! I hope this didn't ping you while you were offline [15:45:28] oh np i was just checking in [15:45:34] cool [15:45:35] did not ping me [15:46:17] aw man glibc update [15:46:29] that means updating...everything [15:46:50] probably restarting mysql et al [15:46:59] viva not contribution_tracking [15:47:52] https://www.qualys.com/2017/06/19/stack-clash/stack-clash.txt [16:15:37] (PS1) Ejegg: PayPal fixed the double space in their audit header [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/359956 [16:16:32] fr-tech trivial thing to get paypal audit working again ^^^ [16:16:48] cwd oh wow, that's the cause of the glibc update? [16:18:09] yep [16:18:33] look more like an unfixable vulnerability platform [16:18:46] than a vulnerability [16:22:08] gotta love all the Clash lyrics in the security advisory [16:52:23] fr-tech anyone have a sec to review that header WS fix? https://gerrit.wikimedia.org/r/359956 [16:52:48] I'd like to re-parse the weekend's audit files [16:53:22] (PS2) Mepps: Save contribution if duplicate invoice id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 [16:53:55] ejegg i'll take a look, and do you want to look at ^^ [16:54:10] sure thing! [16:54:13] and thanks [16:54:27] (CR) jerkins-bot: [V: -1] Save contribution if duplicate invoice id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 (owner: Mepps) [16:58:17] (CR) Mepps: [C: 2] PayPal fixed the double space in their audit header [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/359956 (owner: Ejegg) [16:59:03] oh ejegg nm looking at build fail [16:59:21] (CR) Mepps: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 (owner: Mepps) [16:59:27] (Merged) jenkins-bot: PayPal fixed the double space in their audit header [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/359956 (owner: Ejegg) [16:59:40] (CR) Ejegg: "Looks great! Few small changes suggested." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 (owner: Mepps) [17:00:19] fr-tech: He is not only dull himself, he is the cause of dullness in others. [17:00:19] -- Samuel Johnson [17:00:19] -- discuss. [17:00:42] mepps: ugh, for that particular CI fail we sometimes have to log onto the CI machines and start the mysql service [17:00:52] let's see what group you need to be in to do that [17:00:59] ejegg erg [17:01:10] yeah.... [17:01:34] I mean, you can /usually/ get someone to do it by asking in -releng [17:01:41] but i get impatient [17:03:46] mepps: want more privs? [17:04:43] (CR) jerkins-bot: [V: -1] Save contribution if duplicate invoice id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 (owner: Mepps) [17:06:37] ejegg sure [17:13:20] mepps just sent you details in privchan [17:30:16] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/359962 [17:30:24] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/359962 (owner: Ejegg) [17:30:30] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/359962 (owner: Ejegg) [17:30:45] (CR) Mepps: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 (owner: Mepps) [17:32:43] (PS3) Mepps: Save contribution if duplicate invoice id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 [17:36:54] (CR) jerkins-bot: [V: -1] Save contribution if duplicate invoice id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 (owner: Mepps) [17:42:11] (CR) Mepps: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 (owner: Mepps) [17:42:12] !log updated fundraising tools from 585f546aa0c092ccd938a9a01b4bc3eb7662804d to 457bddb843f69867f24cd072ede1f6733d59c853 [17:42:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:43:08] OK fr-tech, re-starting the paypal audit. hoping it doesn't explode noisily again! [17:43:36] cool, looking normal [17:44:15] argh, i spoke too soon [17:44:29] oh damn, it had already run? [17:44:54] well phooey [17:45:04] looks like i need to move and re-run another one [17:45:09] that was just unlucky timing [17:45:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 5289 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 35 days 2 hours - memory use is 6.76M (peak 34.49M, 0.14% of max, fragmentation 1.64%), connected_slaves is 2, donations is 21, jobs is 0, jobs-adyen is 0, jobs-paypal is 13, payments-antifraud is 9, payments-init is 26, pending is 16, refund is 1, unsubscribe is 0 [17:45:30] ok, let's acknowledge that [17:45:42] mepps let's see if you have privs to shut icing up [17:45:45] icinga [17:46:12] ejegg okay how do we do that? [17:46:15] so, you go to icinga.wikimedia.org [17:46:29] and log in with your wikitech credentials (same as gerrit) [17:46:53] are you able to do that? [17:47:36] nope [17:47:52] shoot, I'm not sure who authorizes that [17:48:00] ok, I'll ack it for now [17:48:10] can screenshare if you're curious [17:48:29] i'm in -talk again [17:49:16] (CR) jerkins-bot: [V: -1] Save contribution if duplicate invoice id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 (owner: Mepps) [17:50:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 5289 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 7 keys, up 35 days 2 hours - memory use is 6.73M (peak 34.49M, 0.12% of max, fragmentation 1.51%), connected_slaves is 2, donations is 11, jobs is 0, jobs-adyen is 0, jobs-paypal is 9, payments-antifraud is 14, payments-init is 16, pending is 0, refund is 1, unsubscribe is 0 [17:51:08] ejegg: is the goal to reduce that queue bloat or should i just raise the alert threshold? [17:51:23] cwd we should probably raise the threshold a bit [17:51:31] but it's good to know if the consumer dies! [17:51:40] maybe 3000 or 4000 ? [17:52:06] the thing is, outside of audit file batch re-processing, that queue should grow pretty slowly [17:52:09] let's say 3000 [17:52:25] it would be nice if you could tell it to ignore a spike [17:52:29] so we have a chance of catching consumer outages within a day [17:53:27] cwd do you know which privs mepps needs to sign in to icinga? [17:53:29] you're going to justifiably hate me but what if we stuck a sleep in the job to throttle it a little? [17:53:33] doesn't seem to be a labs thing [17:53:38] cwd the audit parser? [17:53:48] yeah [17:54:11] i'm half kidding but maybe there's something we can do to make it run at the same rate as the consumer [17:54:40] not that i would call this a problem with the software [17:54:52] gotta hack somethin' [17:55:16] icinga is ldap creds, should be the same as gerrit [18:01:03] hmm, maybe mepps needs to be in another ldap group? [18:06:31] whoa, I thought this was a day off! [18:06:47] awight: heh, not to worry, we're trading for other days [18:06:58] except maybe cwd [18:45:56] (PS4) Mepps: Save contribution if duplicate invoice id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 [18:52:47] (CR) Ejegg: [C: 2] "This looks great! Let's get it deployed." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 (owner: Mepps) [18:57:05] (Merged) jenkins-bot: Save contribution if duplicate invoice id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 (owner: Mepps) [19:00:27] mepps feel like a deploy? [19:16:41] ejegg, yeah! [19:17:14] rockin! [19:19:10] looks like your latest is the only thing in the queue for civicrm [19:20:19] (PS1) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/359976 [19:20:31] (PS2) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/359976 [19:20:57] (CR) Mepps: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/359976 (owner: Mepps) [19:21:13] do you want to screen share for the deploy ejegg or should i do it on my own? just did the merge [19:21:38] I'm up for a screen share if you want, but I trust you to do it right! [19:21:50] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/359976 (owner: Mepps) [19:28:58] !log updated from dfc26f058327bb6248af44ad39a9864b6c3a6581 to d558df2ca2a0218a5e4bb6e03105a14cec3f0b6d [19:29:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:29:26] ejegg cool i think i did it! will keep an eye on the logs [19:29:35] great! [19:29:47] I think I might need to re-run some of those audit files [19:30:07] I was under the impression process-control would prevent concurrent parser runs [19:30:25] but it looks like there was already one going when I started up the fixed version [19:30:47] let's look at the logs, over in /var/log/process-control [19:37:07] ok, I just have to move the latest one back [19:39:38] !log correction: updated civicrm from dfc26f058327bb6248af44ad39a9864b6c3a6581 to d558df2ca2a0218a5e4bb6e03105a14cec3f0b6d [19:39:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:10:45] (PS2) Ejegg: New black and white WMF favicon [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/347904 (https://phabricator.wikimedia.org/T141921) [20:14:48] fr-tech ^^^ is the thing to make payments match the new wmf.o logo [20:21:35] (CR) Mepps: [C: 2] New black and white WMF favicon [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/347904 (https://phabricator.wikimedia.org/T141921) (owner: Ejegg) [20:23:09] ejegg do you have a quick second for another video chat? [20:27:59] (Merged) jenkins-bot: New black and white WMF favicon [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/347904 (https://phabricator.wikimedia.org/T141921) (owner: Ejegg) [20:30:24] mepps sure! [21:03:03] sorry !log updated payments-wiki from 7a5054238169834da0336e805946c7ed73f4795b to 8bdd7061a3ceb46969050c15e723b4638e762a59 [21:19:19] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 3 others: WMF rebranding, logos and font - https://phabricator.wikimedia.org/T141921#3361611 (Ejegg) OK, lo... [21:42:55] !log updated payments-wiki from 7a5054238169834da0336e805946c7ed73f4795b to 8bdd7061a3ceb46969050c15e723b4638e762a59 [21:43:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:43:54] (PS5) Ejegg: Test tidy ups, ensure data from failed run doesn not break test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352746 (owner: Eileen) [21:44:11] (CR) Ejegg: [C: 2] Test tidy ups, ensure data from failed run doesn not break test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352746 (owner: Eileen) [21:48:27] (Merged) jenkins-bot: Test tidy ups, ensure data from failed run doesn not break test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352746 (owner: Eileen) [21:52:21] Fundraising Sprint Kickstopper, Wikimedia-Fundraising-CiviCRM, FR-Paypal, FR-WMF-Audit: Follow up with Paypal on audit regeneration, enable parser - https://phabricator.wikimedia.org/T167828#3361648 (Ejegg) I've just pinged paypal tech support on that ticket, and asked them to notify fr-tech@wiki... [21:53:26] fr-tech here's the potential fix for the paypal dead session bug: https://gerrit.wikimedia.org/r/359213 [21:55:17] I thought you guys had a holiday today? [21:56:52] (PS2) Ejegg: Remove further instance of class_api in favour of civicrm_api3 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352747 (owner: Eileen) [21:57:08] (CR) Ejegg: [C: 2] "Looks like a pretty safe translation" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352747 (owner: Eileen) [21:58:01] eileen2: i'm trading it for wednesday [21:58:18] ah ok - so was I right or wrong to skip standup? [21:58:53] well, you missed Dylan stopping in with his new baby! [21:59:05] very very wrong then! [21:59:56] ridiculously tiny/cute [22:00:19] awwww [22:01:05] (Merged) jenkins-bot: Remove further instance of class_api in favour of civicrm_api3 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352747 (owner: Eileen) [22:11:19] man I've been having some rsi probs of late so sent r out to get a keyboard. He got a windows keyboard (cheaper) which is fine, but the command key is in a diff place to the mac one - so many typos [22:12:30] (PS4) Eileen: Remove deprecated function call from unit test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 [22:13:47] rrrr [22:14:17] i'm just about used to the fn key in the bottom left corner of the thinkpad kbd. only took 3 years [22:19:44] :-) [22:36:18] (PS3) Eileen: Enable CiviCampaign. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350361 (https://phabricator.wikimedia.org/T161758) [22:36:27] (CR) jerkins-bot: [V: -1] Enable CiviCampaign. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350361 (https://phabricator.wikimedia.org/T161758) (owner: Eileen) [22:37:26] (Abandoned) Eileen: Log hack to mysqli driver. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/352743 (owner: Eileen) [22:37:59] (Abandoned) Eileen: Upstream mysqli change. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359897 (owner: Eileen) [22:41:22] (PS3) Eileen: Stop calling deprecated function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359899 [22:41:24] (PS5) Eileen: Remove deprecated function call from unit test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 [22:41:26] (PS4) Eileen: Enable CiviCampaign. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350361 (https://phabricator.wikimedia.org/T161758) [23:01:12] (CR) Ejegg: [C: 2] "Welcome back, traits!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359896 (owner: Eileen) [23:03:24] (CR) Ejegg: [C: 2] Stop calling deprecated function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359899 (owner: Eileen) [23:04:34] (CR) Ejegg: "WS slightly scrambled" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 (owner: Eileen) [23:06:08] (Merged) jenkins-bot: CiviCRM composer update. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359896 (owner: Eileen) [23:07:18] (Merged) jenkins-bot: Stop calling deprecated function. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359899 (owner: Eileen) [23:13:34] (PS6) Eileen: Remove deprecated function call from unit test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 [23:13:44] (CR) Eileen: "The tabs are back!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 (owner: Eileen) [23:16:43] (CR) Ejegg: [C: 2] "Now consistent with our inconsistency!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359900 (owner: Eileen) [23:16:55] (PS5) Ejegg: Enable CiviCampaign. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350361 (https://phabricator.wikimedia.org/T161758) (owner: Eileen) [23:18:11] (CR) Ejegg: [C: 2] "that IS weird... *shrug*" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350361 (https://phabricator.wikimedia.org/T161758) (owner: Eileen) [23:19:24] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/359898 (owner: Eileen) [23:19:57] ejegg: I'm off to github now to look at your review comments on there from the other day & clean up [23:20:19] eileen2: i owe you a bunch more github review [23:20:29] tomorrow! [23:20:34] heading out for now [23:20:47] thanks ejegg! [23:25:30] (Merged) jenkins-bot: Enable CiviCampaign. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350361 (https://phabricator.wikimedia.org/T161758) (owner: Eileen)