[08:13:58] (CR) Hashar: [C: 2] "CI updated. You will probably want to cherry pick that one for the deployment branch." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/351351 (owner: Ejegg) [08:20:27] (Merged) jenkins-bot: Resurrecting hashar's original composer json linter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/351351 (owner: Ejegg) [08:28:35] (CR) Hashar: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/363141 (owner: Hashar) [08:31:22] (CR) jerkins-bot: [V: -1] CI: install CiviCRM with a fake sendmail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/363141 (owner: Hashar) [12:33:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Allow live server to access silverpop via firewall - https://phabricator.wikimedia.org/T170883#3447678 (Jgreen) Open>Resolved a:Jgreen Done & closing task; please reopen if anything doesn't work as expected. [12:34:18] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Create new civicrm repo - https://phabricator.wikimedia.org/T114831#3447685 (hashar) [12:34:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config, Release-Engineering-Team (Kanban): Enable CI jobs on the new CiviCRM repos - https://phabricator.wikimedia.org/T118604#3447682 (hashar) Open>Resolved a:hashar This task is from November 2015. @Eileenmcn... [12:38:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config: Continuous integration for wikimedia/fundraising/civicrm-buildkit - https://phabricator.wikimedia.org/T120044#3447698 (hashar) Open>declined Seems to have been related to {T118604} The repo never had Jenkins j... [15:23:06] hi fr-tech! [15:23:29] hi ejegg! [15:23:53] almost got those DI tests passing, mepps [15:23:58] they actually pass locally [15:25:42] but a bunch of the form rendering fails in CI [15:26:00] nice! [15:26:14] well, I marked a ton of stuff skipped too [15:26:32] but that was stuff that depended on as-yet-unimplemented functions [15:26:36] yeah i was getting the tests set up this morning and noticed that [15:30:56] ejegg were you able to look at: https://gerrit.wikimedia.org/r/#/c/365667/ [15:42:15] mepps looks good so far [15:42:26] oh, for the 'what do we want from the result' question [15:42:33] we want a good deal of it [15:42:58] definitely the ingenico-side payment ID, the amount and currency, to double check, and the AVS and CVV results [15:43:06] the status code is also useful [15:50:34] fundraising-tech-ops, Operations, netops, ops-codfw: codfw: rack frack refresh equipment - https://phabricator.wikimedia.org/T169643#3448498 (Papaul) switches stacking cabling complete. [16:05:48] (PS18) Ejegg: Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) [16:11:28] (PS4) Ejegg: Use new SmashPig split configuration [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/365069 [16:13:06] mepps I got the tests passing for the additional PayPal EC / redirect / dead session patch: https://gerrit.wikimedia.org/r/365648 [16:21:05] mepps if you have a chance to review that bit I'll deploy today [16:21:30] and hopefully the PayPal folks will give us the green light on the recurring change at the meeting in 40 min [16:21:44] would be really cool if we could test 'em both tomorrow [16:21:59] (PS9) Ejegg: Unify queue message handling with SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 (https://phabricator.wikimedia.org/T95647) [16:23:43] (CR) jerkins-bot: [V: -1] Use new SmashPig split configuration [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/365069 (owner: Ejegg) [16:24:19] (CR) jerkins-bot: [V: -1] Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) (owner: Ejegg) [16:32:54] (PS19) Ejegg: Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) [16:39:22] ejegg fr-tech morning! [16:39:31] (Technically still morning here, heh!) [16:41:18] hi AndyRussG [16:49:31] (CR) jerkins-bot: [V: -1] Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) (owner: Ejegg) [17:03:44] Has slander abandoned us? [17:13:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, WMDE-Fundraising-CN: WMDE banners failing to save - Timing out on save - https://phabricator.wikimedia.org/T170591#3448811 (AndyRussG) A few more tidbits: - This still happens on production. I was able to re... [17:30:31] Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, FR-PayPal-ExpressCheckout, Patch-For-Review: Stop using kludgy workaround for PayPal EC recurring - https://phabricator.wikimedia.org/T170478#3448909 (Ejegg) Updates from a call with PayPal: The old UI is 98-99% phased out. It's completely... [17:33:34] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal: Migrate existing PayPal subscriptions to recurring payment profiles - https://phabricator.wikimedia.org/T170959#3448922 (Ejegg) [17:40:28] (PS5) Mepps: Leave form disabled while redirecting to PayPal EC [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/365648 (https://phabricator.wikimedia.org/T167923) (owner: Ejegg) [17:40:32] (CR) Mepps: [C: 2] Leave form disabled while redirecting to PayPal EC [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/365648 (https://phabricator.wikimedia.org/T167923) (owner: Ejegg) [17:42:18] ejegg with the smashpig status patch--should i just return the whole object, or should i pull the parts we want? [17:43:34] mepps let's just return the whole object for now [17:43:39] (Merged) jenkins-bot: Leave form disabled while redirecting to PayPal EC [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/365648 (https://phabricator.wikimedia.org/T167923) (owner: Ejegg) [17:44:02] at some point we should normalize it to something that could look similar across all hosted payment providers [17:44:16] but all the rest of our normalization still lives in DonationInterface [17:52:33] thanks mepps! [17:52:45] I'mma get some food, but I'll deploy that right after [17:52:56] actually, lemme start the merge up now [17:54:35] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/366013 [17:54:43] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/366013 (owner: Ejegg) [17:57:05] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/366014 [17:57:30] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/366014 (owner: Ejegg) [17:57:52] race condition right there ^^^ [17:58:36] hopefully the DI patch merges before the core tests run [18:10:52] (PS3) Mepps: Get HostedCheckout Status [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/365667 [18:10:54] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/366013 (owner: Ejegg) [18:10:57] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/366014 (owner: Ejegg) [18:11:11] ejegg okay looks like this is ready for review ^^ [18:34:30] cool! I'll look right after I get this deploy out [18:36:26] !log updated payments-wiki from bdc52265d78c55cfc6a732f14519f5f79c9d2d94 to c3be2bfd8f2b9f9eac4c80b45096713c7fdcceff [18:36:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:45:47] Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, FR-Ingenico, FR-Smashpig, Fr-Ingenico-integration_17_18: Implement Ingenico Connect API calls to get payment status - https://phabricator.wikimedia.org/T163948#3449311 (Ejegg) a:mepps [18:45:52] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, WMDE-Fundraising-CN: WMDE banners failing to save - Timing out on save - https://phabricator.wikimedia.org/T170591#3449314 (AndyRussG) T170968 is about the more general Translate extension issue... :) Thanks!... [18:50:22] Fundraising-Backlog: reevaluate legacy recurring paypal subscriptions tied to old fundraising domains - https://phabricator.wikimedia.org/T170414#3430170 (Ejegg) PayPal is working on a way to migrate old subscription payments to express checkout recurring profiles. We should take advantage of this whenever i... [18:51:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-Ingenico-integration_17_18: Store recurring tokens in Civi's payment_token table - https://phabricator.wikimedia.org/T165695#3449374 (Ejegg) [18:55:09] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972#3449395 (CCogdill_WMF) [18:56:23] Fundraising-Backlog, Fr-Ingenico-integration_17_18: Write script to charge Ingenico recurring donations - https://phabricator.wikimedia.org/T170973#3449407 (Ejegg) [18:56:47] Fundraising-Backlog, Fr-Ingenico-integration_17_18: Write script to charge Ingenico recurring donations - https://phabricator.wikimedia.org/T170973#3449407 (Ejegg) p:Triage>Normal [18:57:17] Fundraising-Backlog, Recurring-Donations: Make different monthly receipt for recurring donors - https://phabricator.wikimedia.org/T112966#1651193 (Ejegg) See also: T169364 [18:58:21] ejegg should this call: "And one to get the status of any created payment attempt: [18:58:21] GET https://{domainname}/{version}/{merchantId}/payments/{paymentId}" live in the hostedcheckoutprovider class? [18:58:37] mepps no, let's put that one in something more generic [18:58:48] since it will apply to any payments, hosted or not [18:59:06] hmm, maybe hosted should inherit from that one, though [18:59:43] would bankpayments also eventually inherit from that one? [18:59:52] it could totally go in the base IngenicoPaymentProvider [19:00:47] that's what i was wondering, cool [19:05:42] good news: the new PayPal EC redirect flow seems to work fine on production! [19:06:16] woo! [19:07:36] fundraising-tech-ops: adjust fundraising nginx->apache2 to use low ports - https://phabricator.wikimedia.org/T165804#3449470 (cwdent) Open>Resolved This is done, except for Dash, which will be left on a high port for now so as to node have to run node as root. [19:13:59] (PS20) Ejegg: Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) [19:15:16] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, FR-2016-17-Q2-Campaign-Support: CentralNotice banner sequence: adapt Special:BannerAllocation - https://phabricator.wikimedia.org/T144455#2600270 (Pcoombe) I made a note about this in https://meta.wikimedia.org/wiki/MediaWiki:Centralnotice-allo... [19:27:22] (CR) jerkins-bot: [V: -1] Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) (owner: Ejegg) [19:31:59] weird, still thinks the gateway is disabled [19:32:29] AndyRussG: meeting? [19:35:55] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972#3449638 (DStrine) [19:38:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Release-Engineering-Team: Find way to exclude php 5.4 files from vendor lint task - https://phabricator.wikimedia.org/T170641#3449655 (Ejegg) [19:41:33] Fundraising-Backlog, FR-Ingenico: Determine if we need to change anything with Ingenico authorizations - https://phabricator.wikimedia.org/T170475#3449677 (DStrine) p:Triage>High [19:42:22] Fundraising-Backlog, FR-Paypal: reevaluate legacy recurring paypal subscriptions tied to old fundraising domains - https://phabricator.wikimedia.org/T170414#3430170 (DStrine) [19:44:37] Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, WMF-NDA: Amazon (aaaaaargh!) audit report downloads failing, something about an IP address - https://phabricator.wikimedia.org/T169805#3449713 (Ejegg) Open>Resolved [19:45:02] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 7 others: retrieve the text/ html and statistics data for m... - https://phabricator.wikimedia.org/T161758#3449715 [19:45:07] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 8 others: Get CI working on Omnimail - https://phabricator.wikimedia.org/T169593#3449714 (Ejegg) Open>... [19:45:24] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 3 others: PayPal EC dead session error - https://phabricator.wikimedia.org/T167923#3449717 (Ejegg) [19:45:26] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 3 others: Resultswitchers: send straight to ty page on reload - https://phabricator.wikimedia.org/T167990#3449716 (Ejegg) Open>Resolved [19:45:42] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 3 others: Amazon IPN listener should send failmail on verification fail - https://phabricator.wikimedia.org/T166087#3449718 (Ejegg) Open>Resolved [19:50:11] Fundraising-Backlog, fundraising-tech-ops, Operations: reports.frdev.wm.o -- still in use? - https://phabricator.wikimedia.org/T170640#3449738 (Ejegg) @cwdent / @Jgreen : Is the vhost actually pointing to anything, or is this totally obsolete? [19:51:51] Fundraising Sprint Judgement Suspenders, Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, and 3 others: deal with duplicates in the 'invoice ID' column - https://phabricator.wikimedia.org/T166159#3449742 (Ejegg) Open>Resolved [19:52:34] Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising Sprint Kickstopper, and 4 others: break out Ingenico reintegration work - https://phabricator.wikimedia.org/T162840#3449744 (Ejegg) Open>Resolved [19:53:54] Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog: SQL challenge: Mailing and donation data - https://phabricator.wikimedia.org/T169591#3449747 (Ejegg) @CCogdill_WMF OK to close this one? [19:55:18] Fundraising-Backlog, fundraising-tech-ops, Operations: reports.frdev.wm.o -- still in use? - https://phabricator.wikimedia.org/T170640#3449754 (Dzahn) reports.frdev.wikimedia.org is a CNAME for frdev-eqiad.wikimedia.org frdev-eqiad.wikimedia.org has address 208.80.155.13 This shares an IP with the... [20:02:06] (PS5) Ejegg: Use new SmashPig split configuration [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/365069 [20:14:06] (PS2) Ejegg: PayPal EC recurring: initial charge is part of subscription [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364903 (https://phabricator.wikimedia.org/T170478) [20:23:59] Fundraising-Backlog, fundraising-tech-ops, Operations: reports.frdev.wm.o -- still in use? - https://phabricator.wikimedia.org/T170640#3449856 (cwdent) @Ejegg - there are functioning sites at /reports and /webfiledrop, but no real idea if they are still in use or not [20:30:32] (PS3) Ejegg: PayPal EC recurring: initial charge is part of subscription [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364903 (https://phabricator.wikimedia.org/T170478) [20:35:18] (CR) jerkins-bot: [V: -1] PayPal EC recurring: initial charge is part of subscription [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364903 (https://phabricator.wikimedia.org/T170478) (owner: Ejegg) [20:54:57] ejegg how's it going? heading out soon to pick up james [20:55:37] mepps: don't think I'll have the stuff ready, oh well! [20:57:13] opted for the bigger fix, standardizing the pending message logging across all the things that use the donation api [20:57:30] and because of that I wanted to add a bunch more tests and assertions [20:59:26] so we'll do the EC tests next week [21:27:03] (PS1) Ejegg: Move message cleaning function to base test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366158 [21:27:05] (PS1) Ejegg: Standardize pending queue message and logging in API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366159 (https://phabricator.wikimedia.org/T167923) [21:50:38] (PS2) Ejegg: Standardize pending queue message and logging in API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366159 (https://phabricator.wikimedia.org/T167923) [21:50:40] (PS1) Ejegg: Make getLogMatches static [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366161 [22:00:25] (PS6) Ejegg: Update SmashPig and DonationInterface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/365069 [22:24:24] (PS3) Ejegg: Standardize pending queue message and logging in API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366159 (https://phabricator.wikimedia.org/T167923) [22:34:14] (PS4) Ejegg: PayPal EC recurring: initial charge is part of subscription [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364903 (https://phabricator.wikimedia.org/T170478) [22:58:10] (PS1) Ejegg: WIP getHostedCheckoutStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366167 (https://phabricator.wikimedia.org/T163948) [23:00:01] (CR) jerkins-bot: [V: -1] WIP getHostedCheckoutStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366167 (https://phabricator.wikimedia.org/T163948) (owner: Ejegg)