[00:01:33] Fundraising Dash, Fundraising-Backlog, Cleanup, MediaWiki-extensions-Other, and 2 others: Archive DjangoAnalytics extension - https://phabricator.wikimedia.org/T199850 (Krinkle) > DStrine moved this task from `Analysis` to `Blocked & not fr-tech` on the `Fundraising-Backlog` board. @DStrine Does... [00:02:08] ah crap, variant=emailExplain is NOT hiding the radio buttons on prod :( [00:03:09] oh, I see why [00:05:12] (PS1) Ejegg: Update variant=emailExplain to hide opt_in buttons [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/451218 [00:05:19] (CR) Ejegg: [C: 2] Update variant=emailExplain to hide opt_in buttons [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/451218 (owner: Ejegg) [00:05:52] (CR) Ejegg: [V: 2 C: 2] Update variant=emailExplain to hide opt_in buttons [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/451218 (owner: Ejegg) [00:09:38] (PS1) Eileen: Follow up on forgetme - add caching & sort logging until last. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451219 [00:10:19] Fundraising Dash, Fundraising-Backlog, Cleanup, MediaWiki-extensions-Other, and 2 others: Archive DjangoAnalytics extension - https://phabricator.wikimedia.org/T199850 (Ejegg) Yes, please go ahead and kill this. It appears to be an obsolete (untouched by fr-tech since 2013) copy of wikimedia/fund... [00:11:37] !log updated payments-wiki from 8cb7c86b12 to d78c98cf0f [00:11:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:25:31] Fundraising Dash, Fundraising-Backlog, Cleanup, MediaWiki-extensions-Other, User-Zoranzoki21: Archive DjangoAnalytics extension - https://phabricator.wikimedia.org/T199850 (Krinkle) [00:31:23] (PS1) Ejegg: Delete dev files for Tivy [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/451221 [00:37:47] Fundraising Sprint Pluto is still a planet, Fundraising-Backlog: Amazon tcp connection timing out - https://phabricator.wikimedia.org/T201330 (Ejegg) [00:38:33] Fundraising Sprint Pluto is still a planet, Fundraising-Backlog: Amazon tcp connection timing out - https://phabricator.wikimedia.org/T201330 (Ejegg) Open>Resolved Amazon found the problem on their side and resolved it. Still TODO: get Maggie rights to edit outages.js, CN privs. [00:40:23] Fundraising Sprint Pluto is still a planet, Fundraising-Backlog: Amazon tcp connection timing out - https://phabricator.wikimedia.org/T201330 (Ejegg) Resolved>Open Aargh, I missed the error. Apparently the download is still borken, even though we can make API requests from the front-end. [00:48:07] (PS3) Ejegg: Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 [00:48:09] (PS4) Ejegg: Fix .gitmodules branch for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448607 [00:48:11] (PS3) Ejegg: Update fundraising extensions [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448784 [00:51:58] (CR) jerkins-bot: [V: -1] Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 (owner: Ejegg) [00:52:10] Fundraising Sprint Pluto is still a planet, Fundraising-Backlog: Amazon tcp connection timing out - https://phabricator.wikimedia.org/T201330 (Ejegg) Hmm, I just ran the amazon download script again and it DID work. Let's just keep an eye on this and see if it stays working. [00:52:26] (CR) jerkins-bot: [V: -1] Fix .gitmodules branch for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448607 (owner: Ejegg) [00:54:46] (CR) jerkins-bot: [V: -1] Update fundraising extensions [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448784 (owner: Ejegg) [01:06:13] Fundraising Sprint Pluto is still a planet, Fundraising-Backlog, FR-Smashpig: Failmail should always indicate which machine it comes from - https://phabricator.wikimedia.org/T200245 (Ejegg) Oh hey, the from-address default to 'smashpig-failmail@' . gethostname() if we don't include it in settings. Th... [01:28:47] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [01:43:14] (CR) jenkins-bot: Update variant=emailExplain to hide opt_in buttons [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/451218 (owner: Ejegg) [01:43:41] (CR) jerkins-bot: [V: -1] Fix .gitmodules branch for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448607 (owner: Ejegg) [01:44:03] (CR) jerkins-bot: [V: -1] Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 (owner: Ejegg) [01:44:29] (CR) jerkins-bot: [V: -1] Update fundraising extensions [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448784 (owner: Ejegg) [05:00:10] (PS1) Eileen: WIP drush to repair omnirecipient entries [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451228 [05:20:44] (PS2) Eileen: WIP drush to repair omnirecipient entries [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451228 [05:35:50] (PS3) Eileen: WIP drush to repair omnirecipient entries [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451228 [09:34:04] Fundraising Dash, Fundraising-Backlog, Cleanup, MediaWiki-extensions-Other: Archive DjangoAnalytics extension - https://phabricator.wikimedia.org/T199850 (Zoranzoki21) a:Zoranzoki21>None Removing me, because is this done. [10:57:06] (PS1) Umherirrender: Add phan-taint-check-plugin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/451285 [10:57:48] (PS1) Umherirrender: Add phan-taint-check-plugin [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/451291 [10:58:27] (CR) Umherirrender: "check experimental" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/451285 (owner: Umherirrender) [10:58:41] (CR) Umherirrender: "check experimental" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/451291 (owner: Umherirrender) [11:13:12] (CR) Thiemo Kreuz (WMDE): [C: 2] Fix return type of parser function hooks [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/450911 (owner: Umherirrender) [11:16:11] (CR) Umherirrender: [C: -2] "Needs check:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/451285 (owner: Umherirrender) [11:19:07] (Merged) jenkins-bot: Fix return type of parser function hooks [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/450911 (owner: Umherirrender) [11:20:24] (CR) Umherirrender: [C: -2] "Needs check:" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/451291 (owner: Umherirrender) [11:36:45] (PS1) Umherirrender: Explicit parse message on Special:FundraiserMaintenance [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/451300 [11:37:24] (PS2) Umherirrender: Add phan-taint-check-plugin [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/451291 [11:37:32] (CR) Umherirrender: [C: -2] "check experimental" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/451291 (owner: Umherirrender) [12:16:11] (CR) Umherirrender: "Passed" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/451291 (owner: Umherirrender) [12:24:52] (PS1) Jgleeson: Updated createHostedCheckout test to check for new flag and added quotes to the field value. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451308 [12:26:02] (PS2) Jgleeson: Updated createHostedCheckout test to check for new flag and added quotes to the field value. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451308 [13:37:12] Wikimedia-Fundraising-Banners: Mobile small - nag persists after submitting RML - https://phabricator.wikimedia.org/T201513 (Pcoombe) [14:21:08] (CR) Mepps: "Are these also updated in the README?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451191 (https://phabricator.wikimedia.org/T193663) (owner: Ejegg) [14:27:25] (PS8) Mepps: Handle no status code for Ingenico api [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440465 (https://phabricator.wikimedia.org/T194517) [14:28:49] (PS12) Mepps: Refactor of ConfirmCreditCard to handle pending flag [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444311 (https://phabricator.wikimedia.org/T194517) [14:30:11] jgleeson want to review that one too ^^ [14:30:39] just fighting with mw 1.31 [14:34:34] Wikimedia-Fundraising-Banners: Mobile small - nag persists after submitting RML - https://phabricator.wikimedia.org/T201513 (spatton) Issue w/ wrong ID being hidden after RML submission; fixed with [[ https://meta.wikimedia.org/w/index.php?title=MediaWiki%3ACentralnotice-template-mob_sm_T201513&type=revision... [14:35:23] ejegg, did you get issues with missing files in 1.31? [14:35:28] Timestamp.php [14:39:54] jgleeson: no [14:40:17] jgleeson: ohhh, that sounds like you might need to set an environment variable [14:40:31] MW_INSTALL_PATH= [14:40:50] if that's set to the install path for your 1.27 branch [14:41:00] yeah that's correct MW_INSTALL_PATH=/vagrant/mediawiki-fr [14:41:40] huh, ok, and you're using the same directory, just swapping to the 1.31 branch with git? [14:42:20] yup [14:42:32] had to force checkout vendor submodule [14:42:37] and then fresh composer install [14:43:16] but now I'm running into an issue related to an autoloaded class alias set here composer.json:93 [14:51:40] (PS2) Mepps: Update defaults for 'Ways to give' and 'Problems donating' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451191 (https://phabricator.wikimedia.org/T193663) (owner: Ejegg) [14:51:43] (CR) Mepps: [C: 2] Update defaults for 'Ways to give' and 'Problems donating' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451191 (https://phabricator.wikimedia.org/T193663) (owner: Ejegg) [14:54:10] ejegg, is this ticket in related to a monolog clash, https://phabricator.wikimedia.org/T185547 [14:55:39] Fundraising Sprint Pluto is still a planet, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Implement Ingenico Connect API call to create direct debit payment - https://phabricator.wikimedia.org/T171309 (jgleeson) a:jgleeson [14:56:45] jgleeson: it should prevent a monolog clash [14:58:12] jgleeson: does the missing file problem happen when you view the site, or in running the update script? [14:58:20] both [14:58:55] and composer update is failing due to some competing version weirdness in monolog versions [15:01:06] huh, I wonder why I didn't see that [15:01:06] (Merged) jenkins-bot: Update defaults for 'Ways to give' and 'Problems donating' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451191 (https://phabricator.wikimedia.org/T193663) (owner: Ejegg) [15:01:34] well, we should fix the version requirement in DonationInterface to work with whatever REL1.31 uses [15:04:46] ejegg, are you able to find the file the class_alias within mediawiki-fr/includes/compat/Timestamp.php refers to? [15:06:00] jgleeson: yeah, it's in vendor/wikimedia/timestamp/src/TimestampException.php [15:06:23] I think it's composer [15:06:38] I can see the package entry but it doesn't exist for me in vendor [15:06:53] It's working locally for me with the fundraising/REL1_31 branch of vendor [15:06:57] the lock file can't update because of this monolog issue [15:07:06] I'll have to work it out I think [15:07:21] The requested package monolog/monolog ~1.18.2 exists as monolog/monolog[1.22.1] but these are rejected by you [15:07:22] r constraint. [15:07:22] [15:07:27] Well, we should definitely fix the version in DonationInterface [15:07:51] that's the monolog issue, looks like the tag format might be incorrect according to stackoverflow [15:08:29] I've gotta pop out on an errand before standup so I'll pick it up when I get back [15:10:48] (PS1) Ejegg: Use caret versioning for compat with mediawiki 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451343 [15:13:20] (CR) jerkins-bot: [V: -1] Use caret versioning for compat with mediawiki 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451343 (owner: Ejegg) [15:19:42] fr-tech is anyone else watching the logs? [15:19:58] always a fun thing to do during these tests [15:23:14] (PS2) Ejegg: Use caret versioning for compat with mediawiki 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451343 [15:25:25] also https://grafana.wikimedia.org/dashboard/db/fundraising-overview?refresh=1m&orgId=1&from=now-1h&to=now [15:25:27] (CR) jerkins-bot: [V: -1] Use caret versioning for compat with mediawiki 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451343 (owner: Ejegg) [15:40:23] grr, what a jerkin [15:41:04] fr-tech I'm going to #wikimedia-releng to see if I can get someone to help fix the test config so those tests don't run on our branches [15:43:07] oh heck [15:43:11] i'm missing scrum of scrums [15:43:15] forgot it was so early [15:43:18] fr-tech any news? [15:47:06] nothing here thanks [16:00:32] oh, icingawm is missing [16:00:42] well, we're getting queue alerts [16:01:54] i'll ack it [16:10:57] Thanks cwd. The main test (including US) is over now, so queue should hopefully start to go down. UK and Ireland are still up until 18 UTC [16:14:17] pcoombe: great, looked uneventful otherwise? [16:17:21] cwd: Yeah, looks fine on our end [16:40:09] cwd: so... any chance of getting PHP7 on the payments boxen for monday's maintenance window? [16:40:46] :S [16:41:36] Fundraising-Backlog: Fix mobile orientation of radio buttons on payments.wiki opt-in - https://phabricator.wikimedia.org/T201528 (CCogdill_WMF) [16:41:59] Fundraising-Backlog: Fix mobile orientation of radio buttons on payments.wiki opt-in - https://phabricator.wikimedia.org/T201528 (CCogdill_WMF) p:Triage>Normal [16:42:00] ejegg: sounds optimistic...what for? [16:42:29] Mediawiki 1.31 [16:42:38] Somehow I didn't notice that requirement [16:42:53] sorry! [16:43:47] I'm guessing this means we need to put off that part of the maintenance [16:44:05] well changing the version doesn't seem like a big deal [16:44:13] but will payments work? [16:54:31] cwd will they work if we don't upgrade? [16:54:53] I think if we upgrade mediawiki without upgrading PHP we'll get some syntax errors [16:55:20] but mediawiki 1.31 and php7 have been working great on my dev machine [16:57:27] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising-Backlog, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review: Adyen JCB 'invalid card' errors from donation form - https://phabricator.wikimedia.org/T200610 (MBeat33) Another who sent... [16:58:34] Wikimedia-Fundraising-Banners: Mobile small - nag persists after submitting RML - https://phabricator.wikimedia.org/T201513 (Pcoombe) Open>Resolved a:spatton Confirmed that fixed it. Thanks Sam! [17:07:08] ejegg|afk: i'm fine doing it monday then [17:08:29] awesome! [17:08:44] well let's think about it, it's definitely a lot of changes at once [17:08:57] ok, cool [17:09:11] but we are running out of opportunities to make them this year [17:11:54] i just don't want to have multiple things broken at once on tuesday [17:15:13] oh, there is no candidate for jessie [17:15:15] i thought there was [17:15:49] yeah this is going to be a bigger project than we can do by monday [17:16:01] what is the urgency like on the new mw version? [17:21:46] well my purple links tell me i've stabbed at this before [17:21:50] cwd did you see the email on wiki-l about a phabricator account being banned [17:21:57] yeah sounds like php7 on jessie is a no go [17:22:23] jgleeson: i did [17:23:03] they really need to address the german text [17:23:11] or at least explain [17:25:15] yeah...we've got problems [17:25:37] jgleeson: Which one was this? They banned somebody? [17:27:01] yeah, looks like someone used 'wtf' and it was deemed a breach of the CoC, in relation to a dispute over the german text on the new wmf site being or a bug or not [17:29:44] XenoRyet, [Wikitech-l] My Phabricator account has been disabled [17:32:09] Oh, maybe I'm not subbed to that list. Which would be weird, but I don't seem to be. [17:32:55] I've forwarded the thread onto you [17:33:14] Thanks [17:34:55] Yea, that ban seems like an unwise choice, to say the least. [17:37:10] i don't subscribe to any of the public lists anymore [17:37:24] but i end up reading the archives when something like this happens [17:38:17] the whole subject is just counterintuitive [17:38:26] much like the German header [17:40:33] There's some chat about it in the staff channel too btw. I'm staying well out of it (apart from having weighed in on the task itself) [17:42:05] Ah the staff channel. I still haven't been able to get in there. [18:14:09] cwd wait, jessie has no PHP7? [18:14:23] argh [18:15:14] nope [18:15:29] sounds like it's not very backportable due to the number of deps [18:15:57] ejegg: so what is the urgency like for the new mw version? [18:17:38] cwd well, 1.27 doesn't technically EOL till June of next year [18:17:52] but it's getting pretty stale in CI [18:18:16] cwd it's PHP that's more of the issue [18:18:25] 5.6 is EOL on 31 Dec [18:18:48] I suppose we could just shut paymentswiki off as soon as the fundraiser is over :) [18:19:05] heh [18:19:38] lucky we aren't on 7.0 [18:19:43] EOL 12/3 [18:20:26] oh jeez [18:20:36] and stretch doesn't have 7.1 or 7.2 ????? [18:20:52] what a pain [18:20:57] well, there's hhvm [18:21:30] "MediaWiki 1.31 requires PHP 7.0.0 or later. Although HHVM 3.18.5 or later is supported, it is generally advised to use PHP 7.0.0 or later for long term support" [18:21:50] cwd think that'd be crazier? [18:22:54] yeah let's not use hhvm since it's being phased out [18:22:58] sounds like wasted effort [18:23:12] cwd so... what version of PHP do you see us running after Jan 1? [18:23:17] and on what version of debian? [18:23:39] well this is the first time i've heard about it so i'll have to think [18:24:03] there is after all no hhvm on stretch [18:24:42] or jessie, so i guess you have to use FB repos [18:26:01] i will ask the debian people because this would result in there being no php on debian stable [18:26:08] yah [18:26:17] seems crazy [18:35:31] Fundraising-Backlog, fundraising-tech-ops: PHP on Debian after 12/2018 - https://phabricator.wikimedia.org/T201540 (cwdent) [18:44:58] cwd these may interest you: T176370 T181208 [18:45:10] T181208: Migrate translatewiki.net to PHP7 - https://phabricator.wikimedia.org/T181208 [18:45:17] T176370: Migrate to PHP 7 in WMF production - https://phabricator.wikimedia.org/T176370 [19:43:26] ejegg|afk: if i'm reading that right they are still working w/ 7.0 [20:04:51] fr-tech: dedupe's a-failin' [20:59:31] Fundraising-Backlog, fundraising-tech-ops: PHP on Debian after 12/2018 - https://phabricator.wikimedia.org/T201540 (Reedy) Testing and unstable have 7.2 :) [22:01:11] (PS1) Eileen: Additional NYSS funded fixes to contact layout editor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451534 [22:05:42] fr-tech talk? [22:06:38] XenoRyet: tech talk? [22:06:48] This is toddler time for me [22:07:01] ah, cool [22:07:03] oh I miss toddler time [22:08:04] I don't really have anything to say today, but I'm available to listen. [22:08:33] yeah, AndyRussG is talking about the FRUEC [22:08:40] cool, joining [23:13:02] fr-tech just pushed up a version that actually inserts the aggregate CN data in the db!!!!! wheeeeeee [23:13:25] cool [23:13:37] Mmmm I'm gonna refactor db.central_notice_event_mapper to a class, maybe db.CentralNoticeEventAggregator [23:13:45] As a module it's just holding too much state [23:14:00] and anyway it works quite differently from the other db mappers [23:14:26] First gotta walk the wog [23:15:23] Thx again all for listening!!!!! :) [23:36:41] ejegg: do you want to plan a time to look at this silverpop stuff with me? [23:42:56] (CR) Eileen: [C: -1] "not looking right on Staging for me...." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451534 (owner: Eileen) [23:50:33] (PS1) Ejegg: Update fn usage for params removed in 5.4 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451544 [23:50:47] (PS4) Ejegg: CiviCRM 5.4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/444769 (owner: Eileen) [23:50:53] (CR) jerkins-bot: [V: -1] Update fn usage for params removed in 5.4 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451544 (owner: Ejegg) [23:55:01] (CR) Ejegg: [C: 2] "Looks good! Great to see the advances in the caching bits. Related patch to adapt our code to some changed method signatures is here: I6df" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/444769 (owner: Eileen)