[03:17:55] Fundraising-Backlog: New Custom Field: "Endowment Stage" on the prospect tab - https://phabricator.wikimedia.org/T218002 (NNichols) [14:30:54] Wikimedia-Fundraising-Banners, donate.wikimedia.org: Can't use comma as decimal separator for Other amount in some banners - https://phabricator.wikimedia.org/T217854 (Pcoombe) Okay, researching a bit more and my own testing found that handling of decimal points in different browsers is all over the plac... [15:03:21] hi mepps! [15:27:14] hey ejegg! just got off the call with jgleeson, but we can honor the holiday and skip our checkin :) [15:27:33] mepps oh right, holiday! [15:27:43] OK, enjoy your day off [15:27:57] I'm going to work today and take my day off later in the month [15:28:02] i am working ejegg but thought i'd try to catch up on focused work a bit [15:28:05] sounds good! [16:34:03] brb just changing from 4g to adsl [16:38:25] hi jgleeson ! [16:38:41] hey ejegg :) [16:38:48] want to take a look at this if you get a chance? [16:38:52] https://gerrit.wikimedia.org/r/495155 [16:39:00] I'm looking at your patch now, if it's that :) [16:39:06] oh, awesome! [16:39:08] thanks [16:39:31] although I must admit I've been distracted somewhat stepping closely through the api modules and donation api which has been good to understand more about [16:39:42] I should finish it soon :) [16:40:01] how easy would this type of thing be to test? [16:40:12] sorry, unit test [16:41:01] if it's ok with you, I might look at adding a quick test if it looks straightforward enough [16:42:42] actually, yeah, it should be pretty straightforward [16:42:55] need to set up a fake request [16:43:09] and then create an adapter [16:43:12] and ask for the data [16:43:44] I could add that, unless you really want to! [16:44:32] feel free, it'll likely be quicker. I was imagining most of the heavy lifting would be done by an existing test and I could just tweak the donor input :) [16:48:02] there are a couple of test helper functions that should make it pretty easy [17:06:14] heh, just trying to find some good string that actually fail on the old code, besides the real donor data [17:07:01] it looks like the Ukranian Ð is the offending char [17:07:06] ah, oops, I was testing the unstaged data, should be looking for staged [17:07:15] not exactly sure why only that one stands out [17:07:44] is that the only multibyte char maybe? [17:07:49] I blindly assumed it wasn't [17:08:25] code is working ejegg, nice! [17:08:33] want me to hold off on +2 for now? [17:10:10] ejegg, not sure if you caught my message last week re xdebug issues. It turned out that the setup was correct but is was phpstorm that wasn't working correctly. I was using an older version so I updated and everything worked as expected! [17:10:21] tricky!! [17:10:38] (the 'xdebug:' stream thingy that is [17:10:41] ) [17:14:26] jgleeson: I've got a test about ready, will try adding some of those chars till it breaks on the old code [17:14:51] also, yeah, I saw your message. Good to hear you're able to debug again! [17:17:37] (PS2) Ejegg: Stop mangling donor data on truncation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495155 (https://phabricator.wikimedia.org/T202417) [17:17:40] ok jgleeson, that seems to do it ^^ [17:18:48] looking now [17:23:59] (PS3) Ejegg: Apply drupal formatting to WmfDatabase.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494852 (owner: Eileen) [17:24:11] (CR) Ejegg: [C: +2] Apply drupal formatting to WmfDatabase.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494852 (owner: Eileen) [17:25:12] (CR) Jgleeson: [C: +2] "Looks good. UTF-8 chars preserved as expected when debugged and test passing for me!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495155 (https://phabricator.wikimedia.org/T202417) (owner: Ejegg) [17:26:16] thanks! [17:26:58] our inboxes will be grateful for that patch! [17:27:48] :) :) and your diagnostic one! [17:28:22] ah that reminds me, I guess we can revert the additional logging patches out now? [17:28:25] (Merged) jenkins-bot: Apply drupal formatting to WmfDatabase.php [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494852 (owner: Eileen) [17:31:15] jgleeson: the ones in the smashpig codebase? [17:31:31] I don't think they're hurting anything [17:32:29] guess not! [17:32:32] :) [17:36:48] (Merged) jenkins-bot: Stop mangling donor data on truncation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495155 (https://phabricator.wikimedia.org/T202417) (owner: Ejegg) [17:48:46] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops: Update fundriaising tech training matrix - https://phabricator.wikimedia.org/T217176 (mepps) @Cstone I added you but did not fill in any boxes. [17:49:30] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops: Update fundriaising tech training matrix - https://phabricator.wikimedia.org/T217176 (jgleeson) updated mine! [18:15:56] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops: Update fundriaising tech training matrix - https://phabricator.wikimedia.org/T217176 (mepps) I also updated my column! [18:37:33] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops: Update fundraising tech training matrix - https://phabricator.wikimedia.org/T217176 (Aklapper) [19:37:11] (PS2) Umherirrender: Improve param docs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495513 [19:37:28] (CR) Umherirrender: Improve param docs (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495513 (owner: Umherirrender) [20:10:00] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Patch-For-Review: Re-run omnirecipient repair to catch the few missed ones - https://phabricator.wikimedia.org/T215865 (Eileenmcnaughton) This is the generic query with variables to make it easy to re... [20:37:04] (PS1) Eileen: Reset omnirecipient clean to original 420 sec (7 hours) but without event_type=Sent [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/495755 [20:54:08] eileen, thanks for the help with the alias thingy. Just testing it out now [20:54:42] jgleeson: cool hope it takes you forwards [21:00:15] :) [21:03:24] (PS1) Eileen: Update Omnirecipient to UPDATE IGNORE so exact matches don't cause the script to fail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/495770 [21:04:33] jgleeson: any chance I can get you to +2 that one - it’s super trivial [21:06:11] sure eileen looking now [21:09:20] (PS2) Eileen: Reset omnirecipient clean to original 420 sec (7 hours) but without event_type=Sent [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/495755 [21:14:37] (CR) Jgleeson: [C: +2] "Look good to me!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/495770 (owner: Eileen) [21:15:14] sorry eileen for the delay, I'm being distracted by my family trying badly to organise a birthday meal for my brother [21:15:25] thanks for doing it [21:15:49] Fundraising-Backlog: Contacts with contributions being deleted - https://phabricator.wikimedia.org/T218061 (NNichols) [21:19:30] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/495801 [21:21:37] (PS2) Eileen: Update Omnirecipient to UPDATE IGNORE so exact matches don't cause the script to fail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/495770 [21:22:13] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/495801 (owner: Eileen) [21:22:49] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/495801 (owner: Eileen) [21:25:48] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/495770 (owner: Eileen) [21:30:33] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/495804 [21:30:46] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/495804 (owner: Eileen) [21:31:32] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/495804 (owner: Eileen) [21:52:45] (PS3) Eileen: Reset omnirecipient clean to original 420 sec (7 hours) but without event_type=Sent [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/495755 [22:00:29] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (Eileenmcnaughton) I just deployed this - it looks like you worked with @Ejegg already to resolve issues so I'm assuming a...