[04:33:04] (CR) Eileen: [C: +2] "I deployed this on staging and the issues last time are resolved. I know you are still working on a unit test but I'm OK with us proceedin" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482672 (https://phabricator.wikimedia.org/T199268) (owner: Jgleeson) [04:34:54] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for name and org name in a 'the-agnositc way' in Civi - https://phabricator.wikimedia.org/T115536 (Eileenmcnaughton) [04:38:06] (Merged) jenkins-bot: Wmffraud fredge report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482672 (https://phabricator.wikimedia.org/T199268) (owner: Jgleeson) [04:40:40] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for name and org name in a 'the-agnositc way' in Civi - https://phabricator.wikimedia.org/T115536 (Eileenmcnaughton) I've picked this up but have updated it to a narrower scope - ie. handling searchin... [04:42:34] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for name and org name in a 'the-agnositc way' in Civi - https://phabricator.wikimedia.org/T115536 (Eileenmcnaughton) Also we might want to do some culling in sort name of known suffixes for the dedupe... [04:44:05] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Activities tab- multi select option for exclude filter - https://phabricator.wikimedia.org/T203057 (Eileenmcnaughton) a:Eileenmcnaughton [04:46:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Regular CiviCRM upgrade - https://phabricator.wikimedia.org/T218754 (Eileenmcnaughton) [08:27:30] (PS4) Vedmaka Wakalaka: Banner live preview on edit screen [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [10:15:26] (PS5) Vedmaka Wakalaka: Banner live preview on edit screen [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [10:53:09] (PS6) Vedmaka Wakalaka: Banner live preview on edit screen [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [11:56:14] fundraising-tech-ops: investigate recent geoip_update failures fetching GeoLite2 databases - https://phabricator.wikimedia.org/T218773 (Jgreen) [13:12:34] AndyRussG: how easy would it be to add an exceptions for

and
tags for CN/Translate? [13:49:19] Seddon: meh it's doable [13:49:22] but why? [13:49:32] simpler = more secure in general [13:49:37] you can do anything with CSS [13:50:32] I guess I can see the reasoning for br [13:51:33] since normally you only have one, so
is significantly easier than or something [13:52:00] or [13:52:05] I guess we allow that [13:52:09] hmmmm [13:53:04] I think if you've got multiple paragraphs, they should generally be separate translation units.
would be nice to have though [14:03:10] pcoombe Seddon let's make a Fab task I guess? [15:26:28] hi fr-tech! [15:26:38] Any news for the Scrum of Scrums? [15:26:55] ejegg: hi! [15:27:00] nah nothing significant I think [15:27:09] ok ok [15:27:11] the cluster didn't die from the deploy yesterday, as far as I know [15:27:29] I guess just if anyone sees any possible side effects from the protection caching changes, would be all [15:27:33] ejegg: ^ [15:28:28] ejegg: can you see this graph? https://graphite.wikimedia.org/S/9 [15:28:49] the cache miss rate for page restrictions is now back to where it was before [15:29:08] yep, needed to log in first is all [15:29:12] looks good [15:29:22] and even that spike doesn't look too deadly [15:30:58] hmm I have no idea how sharp it'd have to be to pierce the heart of the cluster [15:31:51] AndyRussG: can we un-restrict the ticket now? [15:32:44] cool [15:44:23] Whenever Željko gives his update in Scrum of Scrums, he finishes with either a happy or a sad chord on the ukulele depending on the state of technical things with rel-eng [15:44:27] :) :) :) [15:45:01] (PS7) Vedmaka Wakalaka: Banner live preview [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [15:45:04] awesome [15:46:07] ejegg: that's amazing... He helped out some yesterday by pinging when the branch cut was done [15:46:16] I think he was up 'till midnight his time [15:46:25] tech com has 2 IRC meetings today [15:46:30] one about getting rid of QUnit [15:46:48] other is about adding some new build step for front-endy stuff [15:54:04] besides tech com we need a tech calm team [16:25:31] fr-tech, does anyone know how we typically run unit tests for civicrm extensions? I'm having a hard time running them and working out how they should be run from [16:25:45] where* [16:26:00] jgleeson: we've been adding them to the main phpunit.xml file for the crm repo [16:26:34] ah ok so we can add a new suite [16:27:00] yep! [16:27:05] thanks! I'll try that [17:30:29] XenoRyet: want to bump the version of SmashPig for the composer package, so you can use the new fns in DonationInterface? [17:31:32] I've actually got them all cherry-picked locally so I'm fine there, but probably not a bad idea to bump the version anyway. [17:31:54] (you'd also need it for CI) [17:32:05] I'm not sure I remember how to do that though. Want to show me? [17:32:15] sure! [17:32:32] I guess we've got -talk right now. Maybe show everyone? [17:32:41] fr-tech, just fighting with google auth [17:32:47] be there soon! [17:32:53] Auth monster! [17:37:06] Fundraising-Backlog, fundraising-tech-ops: RFC: Establish a privacy-forward backup strategy in fundraising - https://phabricator.wikimedia.org/T218810 (cwdent) [18:01:35] fundraising-tech-ops: investigate recent geoip_update failures fetching GeoLite2 databases - https://phabricator.wikimedia.org/T218773 (Jgreen) Open→Resolved Maxmind stopped using predictable IPs for this service, so I modified geoip_update to use the proxy on the build servers. [18:02:31] fundraising-tech-ops: make sure puppet 4.x is not logging sensitive data when changes happen - https://phabricator.wikimedia.org/T218811 (Jgreen) [18:36:51] fundraising-tech-ops: Update Maxmind IP addresses - https://phabricator.wikimedia.org/T216051 (Jgreen) Open→Resolved a:Jgreen This is done. [18:38:54] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [18:39:00] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 2 others: Adjust codfw payments servers to log to frlog1... - https://phabricator.wikimedia.org/T218661 [18:39:36] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 2 others: upgrade payments2001 & 2002 to stretch - https://phabricator.wikimedia.org/T218667 (Jgr... [18:39:40] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [18:40:02] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 2 others: Reconfigure mariadb for codfw payments cluster - https://phabricator.wikimedia.org/T218669... [18:40:20] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 2 others: Reconfigure mariadb for codfw payments cluster - https://phabricator.wikimedia.org/T218669... [18:40:23] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [18:45:52] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (MBeat33) Thanks, @LeanneS and @NNichols Leanne, re: your question about 2a (//would the default on the right side of the interface result in the older record being considere... [18:49:53] (PS8) Vedmaka Wakalaka: Banner live preview [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [18:51:13] Okay who came up with "A series of unfortunate event handlers" ? [18:52:49] jgleeson ? [18:53:09] (CR) jerkins-bot: [V: -1] Banner live preview [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [18:53:31] (PS9) Vedmaka Wakalaka: Banner live preview [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [18:54:42] (PS10) Vedmaka Wakalaka: Banner live preview [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [19:02:51] Seddon: that might have been AndyRussG - there were a couple variations of that floating around that session :) [19:03:01] I love it :D [19:09:37] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/497845 [19:10:01] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/497845 (owner: Eileen) [20:07:54] ejegg: the pun on Events was your idea :) [20:08:04] Seddon: ^ [20:36:41] so looking into this sortn_name idea - it seems it could help with deduping but that opens the question of whether we’d want to strip other things from org sort names - e.g ltd at the end [20:37:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create CiviCRM naming convention rule: In general, records should not begin with "The" - https://phabricator.wikimedia.org/T122592 (Eileenmcnaughton) [20:37:52] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for name and org name in a 'the-agnositc way' in Civi - https://phabricator.wikimedia.org/T115536 (Eileenmcnaughton) [20:41:41] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for name and org name in a 'the-agnositc way' in Civi - https://phabricator.wikimedia.org/T115536 (Eileenmcnaughton) @leannes @NNichols digging into this I see that if we strip 'The ' from the sort na... [20:42:54] (PS9) Ejegg: New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [20:43:16] PROBLEM - check_puppetrun on frpig1001 is CRITICAL: CRITICAL: Puppet has 14 failures. Last run 7 minutes ago with 14 failures. Failed resources (up to 3 shown) [20:47:26] (CR) Ejegg: [C: +2] "Thanks for the cleanup! New code ends up with the same publishing rights as old code." [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [20:48:16] RECOVERY - check_puppetrun on frpig1001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [20:49:08] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: switch fundraising cases where we use GeoIP to GeoIP2 - https://phabricator.wikimedia.org/T215425 (Ejegg) p:Triage→Normal a:Ejegg [20:55:02] (Merged) jenkins-bot: New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [21:08:34] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for name and org name in a 'the-agnositc way' in Civi - https://phabricator.wikimedia.org/T115536 (LeanneS) @Eileenmcnaughton Thanks! I love that idea of removing 'The' from the sort name and using th... [21:15:22] (PS6) Ejegg: Use GeoIP2 for local geoip lookup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/469058 (https://phabricator.wikimedia.org/T215425) [21:18:27] (PS7) Ejegg: Use GeoIP2 for local geoip lookup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/469058 (https://phabricator.wikimedia.org/T215425) [21:39:39] (PS8) Ejegg: Use GeoIP2 for local geoip lookup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/469058 (https://phabricator.wikimedia.org/T215425) [23:08:30] (PS3) XenoRyet: lWIP: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [23:09:31] (PS4) XenoRyet: lWIP: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [23:32:42] (PS1) Cstone: Add create new contact on opt-in [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497950 [23:39:01] (CR) Jforrester: "I think this broke Beta Cluster sync – https://integration.wikimedia.org/ci/job/beta-scap-eqiad/242099/console" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [23:40:18] (CR) Ejegg: "This looks like it works, but couldn't we create the contacts with 'opt_in' already set, and leave the rest of the logic the same? I think" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497950 (owner: Cstone) [23:42:48] (CR) Ejegg: [C: +2] "Oops! We should clean up the config so this extension is only installed where Translate already exists." [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [23:43:40] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for name and org name in a 'the-agnositc way' in Civi - https://phabricator.wikimedia.org/T115536 (Eileenmcnaughton) Extension now at https://github.com/eileenmcnaughton/org.wikimedia.thethe I made i... [23:48:08] (CR) Ejegg: [C: +2] "JForrester: it looks like it's a load order issue. This might fix it: I73452ae84bf598eb775" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [23:58:40] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for name and org name in a 'the-agnositc way' in Civi - https://phabricator.wikimedia.org/T115536 (Eileenmcnaughton) a:Eileenmcnaughton