[00:04:33] (PS4) Mepps: Use banner instance variable sooner and check for errors at Page Level [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) [00:06:26] (PS5) Mepps: Use banner instance variable sooner and check for errors at Page Level [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) [02:59:24] (PS1) Eileen: Start recording the payment processor id for recurring contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501128 (https://phabricator.wikimedia.org/T218616) [03:04:23] (CR) jerkins-bot: [V: -1] Start recording the payment processor id for recurring contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501128 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [03:32:53] (PS2) Eileen: Start recording the payment processor id for recurring contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501128 (https://phabricator.wikimedia.org/T218616) [03:37:52] (CR) jerkins-bot: [V: -1] Start recording the payment processor id for recurring contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501128 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [03:55:03] (PS1) Eileen: Create new recurring records with a status of Pending [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501131 (https://phabricator.wikimedia.org/T218754) [04:00:56] (CR) jerkins-bot: [V: -1] Create new recurring records with a status of Pending [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501131 (https://phabricator.wikimedia.org/T218754) (owner: Eileen) [04:02:25] (PS2) Eileen: Create new recurring records with a status of Pending [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501131 (https://phabricator.wikimedia.org/T218754) [04:02:27] (PS1) Eileen: Update existing recurring records to hold payment processor ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501132 (https://phabricator.wikimedia.org/T218616) [04:08:42] (CR) jerkins-bot: [V: -1] Create new recurring records with a status of Pending [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501131 (https://phabricator.wikimedia.org/T218754) (owner: Eileen) [04:09:37] (CR) jerkins-bot: [V: -1] Update existing recurring records to hold payment processor ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501132 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [04:13:00] (PS1) Eileen: Add cancel_reason to cancel [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501133 (https://phabricator.wikimedia.org/T218616) [04:17:56] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix data where contacts have multiple emails or addresses of the same location type (or have no location t... - https://phabricator.wikimedia.org/T152474 [04:18:07] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix data where contacts have multiple emails or addresses of the same location type (or have no location t... - https://phabricator.wikimedia.org/T152474 [04:19:31] (CR) jerkins-bot: [V: -1] Add cancel_reason to cancel [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501133 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [04:45:19] (CR) AndyRussG: "Nice work!!!!! Yay!!!!!!!!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) (owner: Mepps) [04:52:36] (CR) AndyRussG: "(Just two tiny details in the inline comments. Thanks again!!!!)" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) (owner: Mepps) [12:44:49] Maybe we should concede birth names to royals and celebrities also? https://www.bbc.co.uk/news/newsbeat-47813521 [12:45:15] I can be _Jack_ [12:45:19] Grrrr [12:54:08] fundraising-tech-ops: upgrade pay-lvs servers to stretch - https://phabricator.wikimedia.org/T220100 (Jgreen) [12:56:53] fundraising-tech-ops: upgrade pay-lvs servers to stretch - https://phabricator.wikimedia.org/T220100 (Jgreen) [12:56:56] fundraising-tech-ops: EPIC: migrate fundraising hosts to Debian Stretch - https://phabricator.wikimedia.org/T185013 (Jgreen) [13:45:48] fundraising-tech-ops: upgrade frbackup2001 jessie->stretch->buster - https://phabricator.wikimedia.org/T220108 (Jgreen) [14:55:55] fundraising-tech-ops: EPIC: migrate fundraising hosts to Debian Stretch - https://phabricator.wikimedia.org/T185013 (Jgreen) [14:55:58] fundraising-tech-ops: upgrade frbackup2001 jessie->stretch->buster - https://phabricator.wikimedia.org/T220108 (Jgreen) Open→Resolved this is done [14:59:53] (PS6) Mepps: Use banner instance variable sooner and check for errors in SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) [15:53:43] hi fr-tech! [15:54:01] are folks tuning into this staff meeting? [15:54:03] ejegg: hey howsie goesis? feeling better? [15:54:10] It seems to collide with standup [15:54:11] oh yea [15:54:18] standup's been displaced [15:54:20] AndyRussG: yeah, I got a good night's sleep last night [15:54:25] cool! [15:57:59] (PS23) Jgleeson: Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [16:00:23] (CR) jerkins-bot: [V: -1] Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [16:10:02] (PS24) Jgleeson: Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [16:12:25] (CR) jerkins-bot: [V: -1] Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [16:13:23] hmmm not sure what's going on with the civi build [16:13:35] looks like I've somehow broke the kernal :\ [16:49:47] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Rollback upgrade and create plan for shorter tests - https://phabricator.wikimedia.org/T219798 (mepps) @cwdent @Jeff_Green @Ejegg where are we on testing this? [17:07:39] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Rollback upgrade and create plan for shorter tests - https://phabricator.wikimedia.org/T219798 (Ejegg) @mepps: @DStrine and I have tested on multiple browsers on desktop and mobile, see https://etherpad.... [17:23:33] fr-tech I'm jumping off to head home, back on a little later! [17:23:34] fundraising-tech-ops: upgrade frauth servers to debian stretch - https://phabricator.wikimedia.org/T220132 (Jgreen) [17:52:49] (Abandoned) Krinkle: choiceData always checks for mw.centralNotice object [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/285674 (https://phabricator.wikimedia.org/T133765) (owner: AndyRussG) [18:49:38] (PS7) Mepps: Use banner instance variable sooner and check for errors in SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) [18:52:48] (CR) jerkins-bot: [V: -1] Use banner instance variable sooner and check for errors in SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) (owner: Mepps) [18:53:18] (PS8) Mepps: Use banner instance variable sooner and check for errors in SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) [19:25:20] (CR) Krinkle: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497644 (owner: Krinkle) [19:26:52] (CR) Krinkle: [C: +1] "This seems like a significant change as it removes something the extension once had. Usually those kinds of changes I would always recomme" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [19:27:59] (CR) Krinkle: [C: +1] "(When deploying this, there is a risk something might break. That is a risk the team needs to prepare for and have time to test and react " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [20:43:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi dedupe: make sure Mailing Events data is merged - https://phabricator.wikimedia.org/T220149 (MBeat33) [20:48:31] Fundraising-Backlog, Analytics: CentralNoticeImpression refined impressionEventSampleRate is int instead of double - https://phabricator.wikimedia.org/T217109 (AndyRussG) Hi! Thanks so much!!! Here's what Hive said about the `event` field in the `event/centralnoticeimpression` table: ` event struct<... [20:53:26] Fundraising-Backlog, Analytics: CentralNoticeImpression refined impressionEventSampleRate is int instead of double - https://phabricator.wikimedia.org/T217109 (Nuria) Let's see, this data comes from eventlogging, in order for it to be useful we need to make sure FR-tech has switched to eventlogging being... [20:57:47] cstone and jgleeson: this might be all you need for the queue settings in vagrant: https://gerrit.wikimedia.org/r/501406 [20:57:50] trying it myself just now [20:58:07] coolio, will check it out [20:58:42] yep, seems to work [21:03:56] right looking now [21:04:03] sorry was sorting travel arrangements for offsite [21:04:14] no worries. I should do that too! [21:04:39] not looking forward to the long-haul flight. I had someone recline the entire flight infront of me last time which wasn't great [21:06:54] ejegg, I also wanted to chat about the db_merge feedback. I looked up the manual page but couldn't make sense of how I could implement it to avoid the check between insert/update. Once I test our your patch it would be great if you could enlighten me on that if you have 5 minutes [21:12:28] provisioning now [21:14:31] Opt in [21:14:31] Thank you! [21:14:54] 127.0.0.1:6379> LRANGE opt-in 0 -1 [21:14:54] 1) "{\"process\":\"optin\",\"email\":\"a@b.com\",\"variant\":\"wle_001\"}" [21:15:00] looks good to me ejegg! [21:15:33] (CR) Ejegg: [C: +2] Test fix, fully delete contacts on cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500882 (owner: Eileen) [21:16:01] ejegg, is the unsubscribe queue new also? Is there a quick way to test that [21:16:54] (CR) Ejegg: [C: +2] Citibank test fix, ensure citibank contact exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500876 (owner: Eileen) [21:18:16] (CR) Ejegg: [C: +2] Make recurring test more robust when processor already exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500878 (owner: Eileen) [21:20:06] (Merged) jenkins-bot: Test fix, fully delete contacts on cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500882 (owner: Eileen) [21:22:07] (CR) Ejegg: [C: +2] Second recurring test fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500879 (owner: Eileen) [21:22:12] (Merged) jenkins-bot: Citibank test fix, ensure citibank contact exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500876 (owner: Eileen) [21:24:11] (CR) Ejegg: [C: +2] Smashpig test fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500873 (owner: Eileen) [21:24:19] (Merged) jenkins-bot: Make recurring test more robust when processor already exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500878 (owner: Eileen) [21:24:37] thanks ejegg ! [21:25:22] (CR) Ejegg: [C: +2] Smash pig - use API helper class for better errors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500874 (owner: Eileen) [21:27:20] (Merged) jenkins-bot: Second recurring test fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500879 (owner: Eileen) [21:28:26] (Merged) jenkins-bot: Smashpig test fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500873 (owner: Eileen) [21:32:24] (Merged) jenkins-bot: Smash pig - use API helper class for better errors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500874 (owner: Eileen) [21:38:14] ejegg, I couldn't find anything using the unsubscribe queue config added but the opt-in stuff works as expected for me with tests passing on the main patch so will +2 [21:38:43] (CR) Jgleeson: [C: +2] "Working for me as expected. Tests passing" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/498287 (https://phabricator.wikimedia.org/T218240) (owner: Ejegg) [21:39:01] Matilda feed o'clock :0 [21:44:30] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (https://phabricator.wikimedia.org/T218754) (owner: Eileen) [21:49:04] (CR) jerkins-bot: [V: -1] Update to civicrm 5.13 stock [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (https://phabricator.wikimedia.org/T218754) (owner: Eileen) [21:49:11] (CR) jerkins-bot: [V: -1] Fancy variant for opt-in page [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/498287 (https://phabricator.wikimedia.org/T218240) (owner: Ejegg) [21:49:38] jgleeson|away: thanks! [21:49:44] oh hey, what's up with that? [21:51:02] is it the deprecated call making it fail? [21:59:44] (PS12) Ejegg: Fancy variant for opt-in page [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/498287 (https://phabricator.wikimedia.org/T218240) [21:59:46] (PS1) Ejegg: Fix deprecated functions [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/501433 [22:24:02] Fundraising-Backlog, Analytics: CentralNoticeImpression refined impressionEventSampleRate is int instead of double - https://phabricator.wikimedia.org/T217109 (AndyRussG) >>! In T217109#5086615, @Nuria wrote: > Let's see, this data comes from eventlogging, in order for it to be useful we need to make sur... [22:29:36] fr-tech looks like the opt-in fix needs a preliminary patch for the tests to all pass: https://gerrit.wikimedia.org/r/501433 [22:38:43] ejegg, all tests passed for me [22:38:49] on the original patch [22:38:52] :S [22:39:04] jgleeson: this is a test from core [22:39:13] that goes through all the defined special pages [22:39:23] and makes sure they load without fatal errors [22:39:37] I guess in tests, the deprecation warning turn into fatal errors? [22:40:12] It was this failure: https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php70-docker/4839/console [22:40:20] ah ok, are you running the full list of paymentswiki test suites to confirm that or a specific group/filter? [22:40:39] In prod CI they run a bunch of extra tests for gate-and-submit [22:40:50] that seems to be one of the new docker ones running on PHP7 [22:46:58] ejegg, it doesn't look like I can run SpecialPageFatalTest from paymentswiki [22:47:22] would I have to installed the FundraisingUnsubscribe extension on my devwiki to then run it to confirm it works? [22:47:29] install* [22:48:24] or maybe bring it over to paymentswiki? [22:48:28] (the file) [22:52:05] Fundraising-Backlog, Analytics: CentralNoticeImpression refined impressionEventSampleRate is int instead of double - https://phabricator.wikimedia.org/T217109 (Nuria) >The events have been left on at 0.01% sample rate (hope that's OK) Yes, of course. Once you are ready to switch pipelines let us know. [22:57:56] this is confusing [22:58:11] when I try to run the specialpage tests pulled across from devwiki [22:58:24] it fails telling me it can't find a method, which was introduced in 1.32 [22:58:36] I can't see how this works on our 1.31 paymentswiki [22:58:48] or how it would work with the changes in your patch ejegg [23:00:43] the test mentioned in the jenkins log is called SpecialPageFatalTest, and this class has a dataprovider which calls a method added in 1.32 [23:00:45] https://github.com/wikimedia/mediawiki/blob/REL1_32/tests/phpunit/structure/SpecialPageFatalTest.php#L18 [23:01:46] https://github.com/wikimedia/mediawiki/blob/REL1_32/includes/MediaWikiServices.php#L854 [23:02:37] jgleeson: oh shoot, 1.32? Looking again [23:03:02] ah, I guess those tests aren't running on 1.31 [23:03:15] nope [23:04:18] jgleeson: if you can install the extension on the trunk wiki, you can try running the tests [23:06:39] or it's probably possible to get the docker image that's running it, but I don't know what kind of infrastructure it needs [23:09:54] back soon! [23:16:02] (CR) Jgleeson: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [23:19:08] (CR) jerkins-bot: [V: -1] Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [23:21:12] eileen, have you ever seen an error in civi like "PHP Fatal error: Maximum execution time of 30 seconds exceeded in /srv/jenkins-workspace/workspace/wikimedia-fundraising-civicrm/src/wikimedia/fundraising/crm/civicrm/Civi/API/Kernel.php on line 189" [23:21:42] I pushed up a drupal module schema alteration and now the build is failing with that error https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/8329/console [23:21:54] jgleeson: hmm [23:22:01] so that is in our tests? [23:22:13] here's the new code https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/498413/24/sites/all/modules/queue2civicrm/contribution_tracking/wmf_ct_qc.install [23:22:26] it could indicate slowness from a code loop? [23:22:50] maybe?! [23:22:58] but, is it consistent? [23:23:03] yep [23:23:07] oh.... [23:23:14] I'll back that file out to see if it runs [23:23:56] (PS25) Jgleeson: Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [23:25:56] jgleeson: looks like a well overdue improvement ! [23:26:40] So this is the other one in my chain that should be easy to review https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/500870/ - just adding some array vars to avoid enotice noise [23:29:03] just testing out ejegg's patch on core wiki [23:29:39] jgleeson: so yeah success without that change [23:30:01] interesting [23:30:24] You could put up just that change as a separate commit [23:30:28] I wonder if it's to do with a difference between databases [23:30:39] but you are changing? the not-null thing? [23:30:40] does civi use an inmemory db? [23:30:45] civi tests* [23:30:58] I don’t think so - there is some caching going on [23:31:01] or a specific mysql db [23:31:12] it should be pretty similar [23:31:21] BUT [23:31:28] changing the type from serial (PK auto-increment) to 'int' [23:31:29] you have a change field on an install [23:31:46] so, the update is right - but the install should be a change to where the table is created [23:32:17] ie in contribution_tracking.install [23:32:46] hmm I have found mixed docs on that. I wasn't entire sure where I should put that. There is precedent for one module to edit another modules schema apparently [23:33:13] although I didn't plugin to the hook_alter method as that only allowed me to modify the $schema var [23:33:16] (PS1) Eileen: Change CT to be int [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501448 [23:33:23] maybe that's missing? [23:33:33] jgleeson: I think that might be the change ^^ [23:33:37] for install [23:34:16] hmm I wondered if this change will break a bunch of test expecting a AI field [23:34:23] in an earlier form [23:34:41] hmm, it might. Maybe we need to split that change out? [23:34:47] hmm - but if you are planning on changing the field type then the tests have to cope don’t they? [23:34:54] yea [23:35:03] There's still a bit of work to do to update other code that touches the field [23:35:16] the problem is the civitests bomb out big time on vagrant [23:35:20] anyway that is standalone as a change so we can see what test says [23:35:36] but I'll need to check out CT specifically to make sure no regression is introduced [23:35:49] jgleeson: you mean they bomb out regardless? or related to the change? [23:36:00] (CR) jerkins-bot: [V: -1] Change CT to be int [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501448 (owner: Eileen) [23:36:09] yeah regardless, it's a longstanding thing on vagrant [23:36:41] jgleeson: ok - so just making that change leads to the same error [23:36:43] I think it's a mixture of a lack of teardown clean, missing packages locally and vagrant specific environment problems [23:36:53] so it’s the change itself - not the ‘how’ - I’ll try it locally [23:38:43] jgleeson: if your PS's tests pass without the schema change, let's leave it out for now [23:39:27] Error for me locally is PDOException : SQLSTATE[HY000]: General error: 1364 Field 'id' doesn't have a default value [23:40:09] it’s a required field & obviously not getting a value [23:40:47] eileen: that sounds right [23:41:01] existing code expects it to be autoincrement [23:41:21] it'll be a bit tricky to run tests on both before and after scenarios [23:41:30] indeed [23:41:43] thanks eileen for confirming that [23:41:58] what test was it specifically that threw that out? [23:42:08] testImportSucceedOrganizationSingleContactExists [23:42:12] thanks [23:42:32] bug comes from this line /Users/emcnaughton/buildkit/build/wmff/sites/all/modules/wmf_civicrm/wmf_civicrm.module:1962 [23:42:40] $contribution_tracking_id = wmf_civicrm_insert_contribution_tracking($tracking); [23:43:13] eileen: yeah, that code needs update as part of this ticket: https://phabricator.wikimedia.org/T215463 [23:43:34] hmmm [23:43:34] right - it’s a co-ordination of the ordering [23:43:55] sounds like I need to get my local tests working so i can be confident we haven't broken anything else [23:44:32] jgleeson: well jenkins is pretty thorough :-) [23:44:41] PS25 [23:44:44] :) [23:45:08] I've been getting by just testing locally to the change but on this instance I've been caught out [23:45:17] ejegg: wondering if we should get this https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/500871/ & the contact layout editor patch merged so I can make sure release of those 2 is co-orginated [23:45:38] jgleeson: so I kinda rely on jenkins to run the full suite for me as normal practice [23:46:00] I run the tests I’m working on locally but the fact jenkins runs them all & I only run some is a feature IMHO [23:46:19] eileen: yeah, I'll try to review and deploy a bunch more of those patches shortly! [23:46:51] ejegg: mostly I need to look more at a bunch of them [23:47:14] the data ones are just in review & the Contact Layout editor + api v4 It would be good to get out of the way [23:47:25] but then they get really intertwined [23:49:04] (Abandoned) Eileen: Change CT to be int [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501448 (owner: Eileen) [23:51:08] (PS3) Eileen: Start recording the payment processor id for recurring contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501128 (https://phabricator.wikimedia.org/T218616) [23:55:24] (CR) jerkins-bot: [V: -1] Start recording the payment processor id for recurring contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501128 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [23:56:01] (PS1) Eileen: Add test processors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501453 (https://phabricator.wikimedia.org/T218754) [23:57:25] I’ve separated this one out of the borg of changes that rely on the civi update - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/501453/