[00:00:31] (PS4) Eileen: Update existing recurring records to hold payment processor ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501132 (https://phabricator.wikimedia.org/T218616) [00:04:34] ejegg: just looking t the cancel_reason [00:05:37] in this fn importSubscriptionAccount we are doing a switch on trxn_types & I think the the trxn_type is the only info we have? [00:12:59] (PS3) Eileen: Add cancel_reason to cancel [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501133 (https://phabricator.wikimedia.org/T218616) [00:14:05] (CR) Eileen: "ejegg looking at this a bit more I think it might be the right place - the cancel fn is only reached when the trxn_type is subscr_cancel. " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501133 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [00:14:22] eileen: ahh, so we do have that [00:14:42] eileen: there's a bit more code in SmashPig [00:14:45] let me see [00:15:41] yeah in smashpig we are normalising down to some (paypal centric) types - I thnk [00:15:55] yeah, paypal centric :( [00:16:14] I’m looking in RecurringMessage::normalize [00:16:19] well, I guess that's currently the only external-recurring processor we have [00:16:26] shoot, I need to head out [00:16:35] & I think we wind up with a few things being distilled to about 4 trxn_types [00:16:36] but I'll check in again in a few hours [00:16:58] ejegg: no worries - I’m also working tomorrow so that is soon enough [00:17:24] k. see ya later! [00:26:21] (PS4) Eileen: Add cancel_reason to cancel [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501133 (https://phabricator.wikimedia.org/T218616) [00:27:02] (PS5) Eileen: Add cancel_reason to cancel [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501133 (https://phabricator.wikimedia.org/T218616) [00:31:13] !log civicrm revision changed from 88736c7c11 to 34027da7df, config revision is 2119df9495 [00:31:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:43:38] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising-Backlog, and 2 others: Search for name and org name in a 'the-agnositc way' in Civi - https://phabricator.wikimedia.org/T115536 (Eileenmcnaughton) This is now deployed -... [02:28:17] Fundraising-Backlog, MediaWiki-Vagrant, Patch-For-Review: Add mediawiki-vagrant php7.2 xdebug support - https://phabricator.wikimedia.org/T220406 (bd808) >>! In T220406#5136753, @Mainframe98 wrote: > The thing, is xdebug, and remote debugging worked just fine (as I've used it multiple times) before t... [02:31:54] (PS1) Eileen: WIP on using next sched contribution date to manage 'in progress [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506580 [02:36:28] (CR) jerkins-bot: [V: -1] WIP on using next sched contribution date to manage 'in progress [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506580 (owner: Eileen) [02:40:19] (PS1) Eileen: Test fix, ensure test processor is used (matters locally, not so much on CI) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506581 [03:21:20] (PS2) Eileen: Change processing of scheduled payments such that [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506580 [04:31:04] (PS3) Eileen: Change processing of scheduled payments such that [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506580 [04:31:06] (PS1) Eileen: Use calculated installments not a stored value [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506584 [04:35:36] (CR) jerkins-bot: [V: -1] Use calculated installments not a stored value [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506584 (owner: Eileen) [04:35:43] (CR) jerkins-bot: [V: -1] Change processing of scheduled payments such that [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506580 (owner: Eileen) [04:37:35] (PS4) Eileen: Change processing of scheduled payments such that [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506580 [04:37:41] (Abandoned) Eileen: Use calculated installments not a stored value [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506584 (owner: Eileen) [04:41:57] (CR) jerkins-bot: [V: -1] Change processing of scheduled payments such that [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506580 (owner: Eileen) [04:57:57] (PS5) Eileen: Change processing of scheduled payments such that [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506580 [06:08:12] PROBLEM - check_gcsip on payments2002 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [06:10:14] PROBLEM - check_gcsip on payments2001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [06:11:10] RECOVERY - check_gcsip on payments2002 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.241 second response time [06:13:14] RECOVERY - check_gcsip on payments2001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.248 second response time [06:25:14] PROBLEM - check_gcsip on payments2001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [06:25:14] PROBLEM - check_gcsip on payments2003 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [06:28:14] RECOVERY - check_gcsip on payments2003 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.243 second response time [06:28:14] RECOVERY - check_gcsip on payments2001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.244 second response time [08:02:31] Fundraising-Backlog, MediaWiki-Vagrant, Patch-For-Review: Add mediawiki-vagrant php7.2 xdebug support - https://phabricator.wikimedia.org/T220406 (Mainframe98) Ah, I incorrectly assumed, that because T216712 wasn't marked as resolved yet, that that hadn't happened yet. I've filed T221923 for that. Ho... [08:03:32] Fundraising-Backlog, MediaWiki-Vagrant, Patch-For-Review: Add mediawiki-vagrant php7.2 xdebug support - https://phabricator.wikimedia.org/T220406 (Mainframe98) [11:18:24] Fundraising-Backlog: donate.wiki: fix visible template for recurring link - https://phabricator.wikimedia.org/T221885 (Pcoombe) @MBeat33 Oh sorry, I didn't realise you were still using links like that. You can replace the form-countryspecific parameter with `monthly=true` instead e.g. https://donate.wikime... [13:03:58] fr-tech, dstrine, where are with the opt-in stuff that was high priority earlier in the week? I've moved the exchange rates stuff into review and now wondering whether I should move back to the employer field payments form updates or help out with the opt-in stuff? [13:07:57] jgleeson yes opt-in is highest prioroity still [13:08:00] https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/505686/ [13:08:06] ^^ that's what cstone was working on [13:08:28] there's also the review of ejegg's donationinterface redo [13:08:43] which would be good to get done this week [13:09:41] thanks mepps, will take a look [13:11:10] back a little later just heading home! [13:29:20] (CR) D3r1ck01: CentralNoticeHooks: Bundle configuration vars into JS that needs it (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [13:29:43] (PS8) D3r1ck01: CentralNoticeHooks: Bundle configuration vars into JS that needs it [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) [15:32:11] fundraising-tech-ops, Operations, netops: Network setup for frmon2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T221475 (cwdent) @ayounsi after talking to @jgreen I'm going to redo the DNS using the wildcard cert to also have the failover cname. Is there a public IP available for the cod... [15:33:15] (CR) Thiemo Kreuz (WMDE): [C: +2] Add missing use statement for Database [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/501788 (owner: Umherirrender) [15:49:13] (Merged) jenkins-bot: Add missing use statement for Database [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/501788 (owner: Umherirrender) [15:49:42] (CR) Ejegg: [C: +2] Test fix, ensure test processor is used (matters locally, not so much on CI) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506581 (owner: Eileen) [15:50:43] (CR) jenkins-bot: Add missing use statement for Database [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/501788 (owner: Umherirrender) [15:54:11] (Merged) jenkins-bot: Test fix, ensure test processor is used (matters locally, not so much on CI) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506581 (owner: Eileen) [16:00:54] ejegg, is this the only patch outstanding in the donation interface patch chain? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/499942/ [16:03:02] jgleeson: yeah, that's the last of the 3ds / redirect patches [16:17:01] thanks ejegg [16:20:45] fundraising-tech-ops, Operations, netops: Network setup for frmon2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T221475 (ayounsi) https://github.com/wikimedia/operations-dns/blob/master/templates/152.80.208.in-addr.arpa#L24 `208.80.152.235/28` is free. [16:22:22] Hi ejegg! I noticed the new Hebrew donor Thank You email is now RTL (which is should be) but when I was working on it yesterday it was still LTR (and I was trying to figure out how to make it RTL). Is there something that happened on fr-tech's side? [16:30:05] hi tskaff. Where were you working on it? [16:30:26] fr-tech only pulls down completed versions from the wiki and adds them to the CRM code [16:30:41] I was working in the translate extension: https://meta.wikimedia.org/w/index.php?title=Special:Translate&group=page-Fundraising%2FTranslation%2FThank+you+email+2018-10-01&language=he&action=page&filter= [16:31:13] tskaff: ah, ok, that seems to be a completely new page from the last he TY mail [16:31:38] Yeah exactly it's our "new" one ... "2018" [16:31:49] so whoever translated it this time may not have known how to put the RTL tags in? [16:32:17] So I added the translations yesterday, but the fields were LTR ... [16:32:27] makes things really funky when trying to add any code [16:32:57] Can you see what tags exist in the previous TY page that are missing in the new one? [16:33:34] I'll check it against last year's. [16:35:50] thehttps://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_20171019/he?action=edit [16:35:54] oops [16:35:55] https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_20171019/he?action=edit [16:36:22] huh, I don't see any rtl tags there [16:36:56] Weird [18:58:34] * cwd heading out for a bit [18:58:42] will be available on the regular channels [19:00:30] hey ejegg did your fancy opt-in page (without your most recent changes) get merged already? [19:00:43] i'm trying to figure out how to do osme end-to-end testing [19:01:39] mepps yeah, the initial version of the fancy page is in the old extension [19:54:44] ejegg so once i fill it out and see a message in the queue do i run QueueJobRunner --queue opt-in? i'm seeing an error on that [19:55:40] also i see an unsubscribe queue drush job in drupal but not an opt-in one, are they the same job? [19:56:23] okay it looks like it does run opt-in [20:05:20] mepps sorry, just saw these! [20:05:30] no worries, i'm figuring it out! [20:05:37] yeah, there's a single job that runs them both, a la the fredge queue consumer [20:05:50] I guess i was just too lazy to make two drush jobs [20:06:26] we might want a new name eventually [20:06:35] just because otherwise they're separated out so it's a little confusing [20:06:40] i mean name the job something more generic [20:06:56] anyways i got an email from form to civi so that's a good start! [20:06:58] ehh, would be better with a separate job [20:07:31] I could do that if I were writing code this week :) [20:23:42] haha :P [20:24:38] also ejegg what i'm finding with christine's patch is that it doesn't actually error out when there's a non-primary email address already in the system, instead it just adds a new contact and has an error associated with the code looking for an object when an array is returned [20:24:55] but i assume we don't want to add a new contact? [20:30:02] that seems safe.. [20:40:05] ejegg you there? [20:48:52] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/506778 (owner: L10n-bot) [20:50:02] mepps sorry! [20:50:08] trying to fix a thing [20:50:29] ahhh, so it IS adding a new contact. [20:50:41] (PS4) Mepps: WIP: Create new contact with just an email from opt-in. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/505686 (https://phabricator.wikimedia.org/T217710) (owner: Cstone) [20:50:43] (PS1) Mepps: WIP: Attempt at handling existing email, fix to opt-in new contacts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506837 (https://phabricator.wikimedia.org/T17710) [20:50:48] Hmm, so, we DO want to add a new contact when the email address is totally new [20:50:58] ejegg see my patch above [20:51:05] shoot didn't mean to take over Christine's [20:51:28] guess i just rebased [20:54:23] oh, re: the 'if not unsubscribed' comment [20:54:47] ccogdill says we should consider opting in to mean they want to undo any previous unsubscribe [20:54:56] (CR) jerkins-bot: [V: -1] WIP: Create new contact with just an email from opt-in. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/505686 (https://phabricator.wikimedia.org/T217710) (owner: Cstone) [20:55:11] ah, the patch to make that happen is still waiting for review, actually [20:55:21] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/506766 (owner: L10n-bot) [20:55:22] https://gerrit.wikimedia.org/r/504213 [20:55:48] mepps hmm, and it conflicts with the other work here. [20:55:56] but it is ready and with a test! [20:56:26] hmm ejegg [20:56:43] suppose someone puts in some else'sm email? [20:57:05] that seems rebasable [20:57:32] yay for tests! [20:57:35] yep, you can opt-in any email you want [20:58:09] I think ccogdill wants to send a confirmation, but I'm not sure what that would confirm [20:58:34] I guess this endpoint should probably rate-limit, too [20:58:50] 2025 entry level bay area tech job: email opt-inner [20:58:52] ejegg i'm about to sign off but hopefully my patch is helpful! [20:59:38] i'm not loving how many if/else loops are involved [21:02:52] mepps: the diagnosis of the error definitely helps! [21:40:59] ejegg, what was the config to add to localsettings to force 3ds again? [21:44:28] jgleeson look for 3DSRules in readme [21:45:30] thanks! [21:50:16] Fundraising-Backlog: donate.wiki: fix visible template for recurring link - https://phabricator.wikimedia.org/T221885 (MBeat33) Uff, so far it looks like all the WTG page monthly donation links point to likns that yielded this. https://donate.wikimedia.org/wiki/Ways_to_Give/it#Donazione_mensile [22:11:50] ejegg|afk: if you get back & want to look more at that recurring data stuff let me know [22:23:22] Fundraising-Backlog, fundraising-tech-ops: Outage to reload triggers - https://phabricator.wikimedia.org/T222001 (Eileenmcnaughton) [22:32:26] (CR) Jgleeson: [C: +2] "looks good! redirecting for me to ingenico checkout and then returning back to payments wiki upon completion as expected." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499942 (owner: Ejegg) [22:33:23] (Merged) jenkins-bot: Use special form variant for redirect to hosted Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499942 (owner: Ejegg) [22:47:08] eileen: so far things look good! But we should probably take care of the recurring_globalcollect module at the same time, right? [22:47:57] ejegg: sure - I’ve been thinking about this bigger picture - & have some thoughts from the IATS maintainer about different fail types [22:47:58] https://github.com/iATSPayments/com.iatspayments.civicrm [22:48:12] oho, cool [22:48:14] looking [22:48:21] I’ve been thinking core should support some different exception types [22:48:39] to reflect https://github.com/iATSPayments/com.iatspayments.civicrm/pull/273#issuecomment-487197512 [22:48:42] which I think are [22:49:33] 1) PermanentTokenPaymentException - stolen card, expired card [22:50:04] 2) TemporaryTokenPaymentException - site not responding, insufficient funds [22:50:49] yeah, those seem good to have! [22:50:56] I think the first 2 are ones where it’s not possible to throw an exception as the script has bottled [22:51:03] (in Allan’s list) [22:51:22] In fact it could be [22:51:29] So, retryable and not retryable [22:51:34] Yeah [22:51:51] possibly we should distinguish 2 into server & user [22:52:40] In face for TemporaryServerTokenPaymentException - we would retry more quickly I think [22:54:17] so, for simple connection errors, the underlying library retries 3x [22:54:46] both in the smashpig extn and the recurring_globalcollect code that uses donationInterface classes [22:58:08] that is, it immediately retries up to 3x [22:58:17] so looking at globalcollect I feel like on one hand I am in danger of making the same changes in 2 different places but on the other if I try not to the scope might be blowing up & perhaps the plan is to deprected GC in favour of SP over time anyway [22:58:33] yes, exactly [22:58:59] There's a ticket somewhere in the backlog to migrate all the existing globalcollect recurring over to the Ingenico Connect tokenized version [22:59:09] but it just hasn't been prioritized :( [22:59:18] I'd sure like to kill an integration soon! [22:59:59] OK - so I need to check on scoping because there is a bit of a tangent involved here - I guess I need to make sure we sort out the cancel_reason part as a priority - ie https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/501133/ [23:01:33] oh, interesting, so we're not actually ending the recur record on the messages that map to subscr_failed? [23:01:57] ok, I need to review that code [23:08:22] (CR) Peachey88: [C: +1] "Incorrect task number listed in commit message" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506837 (https://phabricator.wikimedia.org/T17710) (owner: Mepps) [23:08:42] (CR) Peachey88: [C: -1] "Should have been -1 sorry" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506837 (https://phabricator.wikimedia.org/T17710) (owner: Mepps) [23:10:18] (PS2) Mepps: WIP: Attempt at handling existing email, fix to opt-in new contacts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506837 (https://phabricator.wikimedia.org/T217710) [23:42:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Turn on Redis, Functional locks - https://phabricator.wikimedia.org/T222002 (Eileenmcnaughton)