[00:55:17] Fundraising-Backlog: New Custom Fields for Target Smart Import - https://phabricator.wikimedia.org/T222559 (NNichols) [07:08:00] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508208 (owner: L10n-bot) [08:06:35] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508195 (owner: L10n-bot) [08:57:00] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (jrobell) Thank... [09:22:12] (CR) Raimond Spekking: "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508208 (owner: L10n-bot) [09:28:01] (CR) Raimond Spekking: [C: +2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508208 (owner: L10n-bot) [14:27:50] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 2 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (spatton) Hey @Ej... [14:37:39] fr-tech anyone want to work on that TY page? ^^^ [14:52:09] cstone: looks like the TY letters are fixed and ready to pull down with that drush job [14:54:30] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561 (Jgreen) @bblack circling back on this, do you still see any issue now after the Silverpop SSL improvements? [14:56:44] Fundraising-Backlog, fundraising-tech-ops: add "frtech_mail" syslog filter to thulium - https://phabricator.wikimedia.org/T186018 (Jgreen) Open→Declined [16:03:17] ejegg I'm still seeing a bunch of Found 1 likely tokens "$amount" in rendered thank-you translation. [16:04:12] oh? want to list the languages that still need fixing in the ticket? [16:15:03] ejegg looking into it further I'm getting the $amount error for de but when looking at the translation page I don't see it anymore just the [amount] [16:15:37] huh, so the text we get from the API is different from the text on the page... [16:17:35] yep, I get the same result. Looking into it... [16:29:21] hmm, snagging the text via the API sandbox shows [amount] as well [16:33:41] hmm, so we're not grabbing the latest version --- because of the 'publish date' logic? [16:33:56] cstone: are you looking at the TY generator code? [16:36:08] i think so is RenderTranslatedPage the right file [16:36:16] yep yep. [16:36:30] I started with a breakpoint in get_revision_at_time [16:37:00] which showed me the revision ID we're using is 19064873 [16:37:25] while the latest revision is 19073504 [16:37:47] so, backing up into get_published_revision [16:38:03] and I see we're looking through the review logs to get the latest 'publish' event [16:41:29] cstone: ejegg how is the opt in going? do yo think it could go out today? [16:45:00] dstrine the form side has a working version I'm not sure how far XenoRyet|afk got with the civi side on Friday [16:46:50] cstone: do you want to go ahead with https://gerrit.wikimedia.org/r/507226, or do the refactor we were talking about last week? [16:48:41] ejegg i like the idea of the refactor to have tests that make sense but maybe start with that first patch? [16:48:55] ok, sure [16:50:36] (PS5) Ejegg: Add contact_id and contact_hash to opt-in form. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507226 (owner: Cstone) [16:50:50] (CR) Ejegg: [C: +2] Add contact_id and contact_hash to opt-in form. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507226 (owner: Cstone) [16:51:55] (Merged) jenkins-bot: Add contact_id and contact_hash to opt-in form. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507226 (owner: Cstone) [16:52:20] cstone: was 'de' the only language that was still giving you issues? Looks like it needs to be put in 'published' state [16:52:34] i was getting it for a bunch of thm [16:52:39] I'll email tskaff with a list of the languages that need publishing [16:54:01] en, es, fr, he, nl, pt-br were the ones that worked [16:55:02] ca, da, de, es-419, hu, it, lv, nb, pl, pt, ro, ru, sk, sv, uk were the ones that errored [16:57:21] ok, thanks! [17:07:40] cstone: want to tackle getting the opt-in fancy Thank You variant? [17:10:19] sure [17:24:13] oh hey, we should make it so the cancel button does something different from the 'Continue' button [17:24:39] what did it do on the old form? [17:26:04] ah, just sends ppl to https://wikimediafoundation.org/ [17:50:50] oh look, the fancy version doesn't have a cancel button [17:55:04] (PS1) Ejegg: Make email 'Cancel' button work like old forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508368 [17:56:38] cstone: so the optinSuccess template for the fancy version should be almost identical to the submission form [17:57:25] any thoughts on how to re-use the parts that are the same in both? [18:03:38] ejegg hmm im not 100% sure on how the templates work but can they be broken into smaller pieces and included in each other? [18:03:55] they sure can [18:06:09] so how do you want to break them up? [18:06:50] which is the parent part and which is the child part? [18:12:13] ejegg hmm one for the css and images and then the block that is changing would be the child part? [18:12:18] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Ottomata) @AndyRussG this should be do-able now, can you alter your schema? If you don't mind, I'm happy to... [18:12:38] cstone: ok, so how does the outer part switch out the child parts? [18:14:28] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Ottomata) @Niharika If you are not the right person to ping about the TemplateWizard schema, could you point... [18:14:44] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Ottomata) [18:45:03] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (Ejegg) @jrobel... [19:12:19] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (AndyRussG) @Ottomata Hi! I updated the [[ https://meta.wikimedia.org/wiki/Schema:CentralNoticeBannerHistory |... [19:15:16] cstone: here's a bit of work to make the cancel button functional: https://gerrit.wikimedia.org/r/508368 [19:16:51] XenoRyet: LMK if you want to collaborate on the Civi side of the opt-in updates [19:17:20] Yea, will do. I've actually got a patch that should work, just testing it out now. [19:17:38] cstone: I'd like to switch those parameters away from the single-char versions before deployment too [19:20:45] ejegg i was testing the non single characters but didn't put it back in. its the e t and v right? [19:23:19] (PS1) Ejegg: Spell out full param names for email prefs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508387 [19:23:30] cstone: oh yep, those are the ones [19:23:50] Sorry to duplicate the work - that patch does it too [19:25:23] no worries I think I had missed the validation parts when I was trying it cause it was giving me errors [19:27:02] (CR) jerkins-bot: [V: -1] Spell out full param names for email prefs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508387 (owner: Ejegg) [19:27:20] oops, let's see what's up there [19:27:51] oh yeah, have to update the matching test [19:29:47] (PS2) Ejegg: Spell out full param names for email prefs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508387 [19:31:07] fr-tech: I'll be 2-3 mins late to the meeting. [19:32:48] AndyRussG: you free for a meeting? [19:46:19] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: New Custom Fields for Target Smart Import - https://phabricator.wikimedia.org/T222559 (DStrine) [19:56:13] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: review live banner preview code - https://phabricator.wikimedia.org/T222658 (DStrine) [20:07:46] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Ottomata) Thank you! [20:22:31] relocating... [20:31:33] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising-CiviCRM: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445 (DStrine) [20:31:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Ask Coinbase to export CSVs in an encoding that is compatible with Excel - https://phabricator.wikimedia.org/T119913 (DStrine) Open→Declined [20:37:20] (PS1) XenoRyet: Opt-in Consumer handles contact ID and Hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) [20:42:19] (CR) jerkins-bot: [V: -1] Opt-in Consumer handles contact ID and Hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [20:51:46] (PS2) Ejegg: Add start and end dates to active campaigns API [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508089 (https://phabricator.wikimedia.org/T222513) (owner: AndyRussG) [20:51:50] (CR) Ejegg: [C: +2] Add start and end dates to active campaigns API [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508089 (https://phabricator.wikimedia.org/T222513) (owner: AndyRussG) [20:55:39] (CR) Ejegg: [C: -1] "Maybe just have the 'matches' functions return true or false? Or if you want them to mutate the message, change the name so that's clear." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [20:56:31] cstone: how do you want to split up what's left of the opt-in work? [20:58:30] ejegg i was looking at your earlier patches today, then its the thank you page thats left or is there other stuff? [20:59:13] the TY page, then there's your other patch to add a new contact with just email [20:59:47] so on that front, it looks like mepps has a follow-on patch that fixes a few things [20:59:57] maybe worth squashing those together, actually [21:00:37] hmm, and either you or XenoRyet|food will have to rebase some work [21:01:07] oh yeah ok [21:03:21] (Merged) jenkins-bot: Add start and end dates to active campaigns API [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508089 (https://phabricator.wikimedia.org/T222513) (owner: AndyRussG) [21:03:47] Fundraising-Backlog, MediaWiki-Vendor, MediaWiki-extensions-DonationInterface: DonationInterface Vendor repo double inclusions - https://phabricator.wikimedia.org/T159099 (Ejegg) Open→Resolved a:Ejegg OK, we're now using composer-merge-plugin to pull extension dependencies in to paymentsw... [21:12:59] (CR) jenkins-bot: Add start and end dates to active campaigns API [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508089 (https://phabricator.wikimedia.org/T222513) (owner: AndyRussG) [21:20:45] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: Epic: CentralNotice Banner squence - https://phabricator.wikimedia.org/T144615 (DStrine) Open→Resolved [22:20:40] (PS2) XenoRyet: Opt-in Consumer handles contact ID and Hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) [22:22:05] (CR) XenoRyet: "Mutating the message is closer to what that code block was doing before, so I want to leave it like that for a lighter touch. Renamed the" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [22:23:24] (CR) jerkins-bot: [V: -1] Opt-in Consumer handles contact ID and Hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [22:30:19] (CR) Cstone: [C: +2] Make email 'Cancel' button work like old forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508368 (owner: Ejegg) [22:37:40] thanks cstone! [22:39:53] I had a question on the other one, it was only loading the variant for me for v= and not variant= [22:40:18] ooh, I need to update one more spot, I guess [22:43:22] (PS3) Ejegg: Spell out full param names for email prefs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508387 [22:43:32] okay cstone, that should do it [22:59:52] ok cool [23:00:00] (CR) Cstone: [C: +2] Spell out full param names for email prefs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508387 (owner: Ejegg) [23:06:41] ejegg for your earlier question I can go back and look at my WIP/Maggies patch for the create new contact on opt in [23:07:20] ok, great [23:07:43] I can take a stab at getting the pretty version of the thank you [23:07:46] template [23:13:27] (Merged) jenkins-bot: Make email 'Cancel' button work like old forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508368 (owner: Ejegg) [23:14:11] (Merged) jenkins-bot: Spell out full param names for email prefs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/508387 (owner: Ejegg) [23:32:57] (CR) Krinkle: [C: +2] OutputPage::parseInline has been deprecated since 1.32 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/506044 (https://phabricator.wikimedia.org/T213978) (owner: Abijeet Patro) [23:39:10] (Merged) jenkins-bot: OutputPage::parseInline has been deprecated since 1.32 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/506044 (https://phabricator.wikimedia.org/T213978) (owner: Abijeet Patro) [23:54:26] (CR) jenkins-bot: OutputPage::parseInline has been deprecated since 1.32 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/506044 (https://phabricator.wikimedia.org/T213978) (owner: Abijeet Patro)