[00:40:07] (CR) Cstone: "This is working for me only thing is that it is creating a new line after the pulled down text. Would that cause any issues with the email" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510050 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [02:21:14] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 3 others: Civi recurring donation cancel metric request - https://phabricator.wikimedia.org/T218616 (Eileenmcnaughton) @ejegg @Jksa... [04:27:38] (CR) AndyRussG: [C: +2] "Yay!!! Thanks!!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) (owner: Mepps) [04:33:44] (Merged) jenkins-bot: Use banner instance variable sooner and check for errors in SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) (owner: Mepps) [04:40:31] (CR) jenkins-bot: Use banner instance variable sooner and check for errors in SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) (owner: Mepps) [05:00:16] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510005 (owner: L10n-bot) [05:05:45] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/510072 [05:07:55] (CR) AndyRussG: [C: +2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/510072 (owner: AndyRussG) [05:14:04] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/510072 (owner: AndyRussG) [05:20:54] (CR) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/510072 (owner: AndyRussG) [14:54:36] (PS2) Ejegg: Thank you subject comes from wiki too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510050 (https://phabricator.wikimedia.org/T167806) [14:59:32] (CR) Ejegg: "Thanks cstone, good catch! I think the files look more natural with a newline (and some editors add them automatically!), so I put in a tr" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510050 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [15:00:00] (CR) jerkins-bot: [V: -1] Thank you subject comes from wiki too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510050 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [15:01:46] (PS3) Ejegg: Thank you subject comes from wiki too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510050 (https://phabricator.wikimedia.org/T167806) [15:11:47] ejegg, how do you feel about this https://glot.io/snippets/fc7kw4uos5 [15:12:17] and then the rest of the logic works around that trinary [15:14:24] (kinda feel like false is redundant although it could be envisaged as a way to turn defaults off [15:14:26] ) [15:22:23] jgleeson: sure that works [15:22:58] if you want to do a first pass that just changes all the 'true' to 'required' it might be even more clear at the end [15:23:20] hmm, but what would the 'false' equivalent be? [15:23:37] anyway, the 'optional' bit sounds good. [15:23:49] fine to leave the rest as 'true' for now [15:23:59] yeah I considered replacing true but figured it was a can of worms [15:24:11] guess we can fix that later [15:40:59] running an errand, back soon! [15:41:34] ditto [15:41:37] back later! [16:32:07] (CR) Cstone: [C: +2] Thank you subject comes from wiki too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510050 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [16:37:28] (Merged) jenkins-bot: Thank you subject comes from wiki too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510050 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [17:38:37] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (TSkaff) @Ejegg... [17:51:24] thanks for the review cstone [18:36:23] ejegg would the thank you translations be ready to go now? [18:46:25] cstone yep! [18:46:40] and in Japanese too, it appears [18:46:54] yeah i saw that it generated the japanese text fine [18:50:35] great, so you can just check them in as a patch [18:52:02] ok cool [18:53:03] fr-tech when vagrant complains about vboxsf not being present on the guest, what's the quickest way to get it working? [18:53:34] hmm [18:53:38] mount.vboxsf: mounting failed with the error: No such device [18:53:58] ooh, wait, maybe that's just a symptom [18:54:12] > An error occurred in the underlying SSH library that Vagrant uses. [18:54:13] so I would assume the vbox file system is installed on a guest [18:54:22] > timeout during server version negotiating [18:54:31] ah, it must be trying to copy the key over [18:54:36] and not finding your shared mount [18:55:12] hmm. this library has plenty of bandwidth. I'll destroy and redo [18:55:16] try it from virtualbox [18:55:21] with the UI [18:55:26] to see if it gives you more info [18:55:31] ah yeah, good call [18:55:47] ejegg: do make sure you have the same vbox guest additions as vbox in general [18:56:02] the guest additions I usually download from the site directly, IIRC [18:58:32] ejegg: Not that exact error, but I sometimes get a very simlar one out of vagrant when etc/exports has multiple entries for vagrant in it. [19:00:40] hmm, ok [19:09:57] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (Cstone) @TSkaf... [19:10:27] (PS1) Cstone: Update translated thank you content and subject for the 2018-10-01 thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510220 (https://phabricator.wikimedia.org/T213209) [19:15:33] (CR) jerkins-bot: [V: -1] Update translated thank you content and subject for the 2018-10-01 thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510220 (https://phabricator.wikimedia.org/T213209) (owner: Cstone) [19:27:39] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (AndyRussG) [19:40:45] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding notes to an email activity in civi - https://phabricator.wikimedia.org/T218725 (DStrine) [19:46:28] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: review status of event logging - https://phabricator.wikimedia.org/T223323 (DStrine) [19:51:20] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, Patch-For-Review: 1-month update for privacy policy - https://phabricator.wikimedia.org/T220428 (DStrine) Open→Resolved [19:52:13] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Burn down FundraisingEmailUnsubscribe extension, rewrite special pages in DonationInterface - https://phabricator.wikimedia.org/T218171 (D... [19:52:23] Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: Oanda API Bug - https://phabricator.wikimedia.org/T220859 (DStrine) Open→Resolved [19:53:06] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 2 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (DStrine) Open... [19:53:27] Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, and 3 others: 3DS iFrame errors after 4/8/19 upgrade - https://phabricator.wikimedia.org/T220512 (DStrine) Open→Resolved [19:54:55] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: add new field to ds fraud query - https://phabricator.wikimedia.org/T223325 (DStrine) [19:55:26] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 6 others: Iterate on DS fredge query - https://phabricator.wikimedia.org/T219646 (DStrine) Op... [19:55:43] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, FR-Astropay, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review: RedPagos (cash) form in Uruguay fails to load with a fatal exception - https://phabricator.wikimedia.org/T222961 (DStrine) Open→Resolved [19:55:47] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, FR-Astropay, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review: Please remove "Provincia Pagos" from Argentina cash options - https://phabricator.wikimedia.org/T222977 (DStrine) Open→Resolved [19:56:03] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: adyen failmail investigation - https://phabricator.wikimedia.org/T222912 (DStrine) Open→Resolved [19:59:56] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 2 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (DStrine) Reso... [20:02:14] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, Patch-For-Review: iDEAL opt-ins not recording - https://phabricator.wikimedia.org/T221803 (DStrine) Open→Resolved [20:02:20] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 2 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (Ejegg) New link:... [20:02:40] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, and 6 others: DonationInterface should have an option to use new contribution_tracking infrastructure - https://phabricator.wikimedia.org/T215462 (... [20:05:00] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 2 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (DStrine) Open... [20:10:15] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 2 others: CRM contribution tracking writing should have a switch to use the new infrastruct... - https://phabricator.wikimedia.org/T215463 [20:16:03] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Email: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (Ejegg) [20:17:37] Fundraising-Backlog: Create checklist for civi upgrades - https://phabricator.wikimedia.org/T222733 (DStrine) Open→Resolved [20:36:22] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Nuria) [21:10:12] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Nuria) Open→Resolved [21:17:22] this should be an easy review which will knock a ticket off https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/508961/ [21:18:02] taking a peep eileen [21:18:29] (PS4) Ejegg: Alter option_group table to default to is_locked = 0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508961 (https://phabricator.wikimedia.org/T222559) (owner: Eileen) [21:19:01] oh huh, new groups were locked by default before? [21:19:08] (CR) Ejegg: [C: +2] Alter option_group table to default to is_locked = 0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508961 (https://phabricator.wikimedia.org/T222559) (owner: Eileen) [21:19:17] yeah - because we were out of sync [21:19:32] makes me wonder if we should audit our schema against a fresh install [21:19:46] hmm - could be interesting but prob a big job [21:19:52] yep [21:19:56] what do you think we should do re that cancel reason one? Or should we discuss on hangout [21:20:50] let me read up on it again, then maybe a quick chat? [21:21:21] ok cool [21:22:17] (PS2) Ejegg: Additional comments in cancel block [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508969 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [21:22:22] (CR) Ejegg: [C: +2] Additional comments in cancel block [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508969 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [21:23:46] (Merged) jenkins-bot: Alter option_group table to default to is_locked = 0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508961 (https://phabricator.wikimedia.org/T222559) (owner: Eileen) [21:28:17] (Merged) jenkins-bot: Additional comments in cancel block [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508969 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [21:31:24] eileen: want to chat a bit? [21:34:57] ejegg: yep - [21:35:47] shall we use the tech talk link? [21:35:59] ok [22:02:55] (PS8) Vedmaka Wakalaka: Banner in-page preview mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 [22:05:08] (PS11) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [22:06:32] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [22:11:09] (PS1) Eileen: Null out some backfilled cancel reasons. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510258 (https://phabricator.wikimedia.org/T218616) [22:36:46] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: review status of event logging - https://phabricator.wikimedia.org/T223323 (DStrine) [22:36:49] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog: review live banner preview code - https://phabricator.wikimedia.org/T222658 (DStrine) [22:36:50] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog: Create checklist for mediawiki upgrades - https://phabricator.wikimedia.org/T222734 (DStrine) [22:36:53] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, Patch-For-Review: New Custom Fields for Target Smart Import - https://phabricator.wikimedia.org/T222559 (DStrine) [22:36:55] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (DStrine) [22:36:57] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, FR-Ingenico: set up and test new iframe setting for ingenico - https://phabricator.wikimedia.org/T222290 (DStrine) [22:36:59] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: create 'batch mark not duplicate' button - https://phabricator.wikimedia.org/T221270 (DStrine) [22:37:01] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding notes to an email activity in civi - https://phabricator.wikimedia.org/T218725 (DStrine) [22:37:05] Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, and 2 others: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (DStrine) [22:37:07] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 4 others: Civi recurring donation cancel metric request - https://phabricator.wikimedia.org/T218616 (DStrine) [22:37:09] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: URL generator for dedupe searches - https://phabricator.wikimedia.org/T217909 (DStrine) [22:37:11] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, and 2 others: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (DStrine) [22:37:13] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, and 6 others: Update opt-in queue consumer to be able to create new donor records - https://phabricator.wikimedia.org/T217710 (DStrine) [22:37:17] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, and 7 others: New message inclusion syntax strips with more than one class - https://phabricator.wikimedia.org/T216150 (DStrine) [22:37:19] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 3 others: CRM contribution tracking writing should have a switch to use the new infrastruct... - https://phabricator.wikimedia.org/T215463 [22:37:21] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: CID range + lifetime$ possible to combine? - https://phabricator.wikimedia.org/T204878 (DStrine) [22:37:23] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog: New mobile iFrame errors - https://phabricator.wikimedia.org/T221385 (DStrine) [22:37:25] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Deprecation warning from CentralNotice: OutputPage::parseInline - https://phabricator.wikimedia.org/T213978 (DStrine) [22:37:27] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 10 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (DStrine) [22:37:29] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog: Opt-in numbers in IBM not as expected - https://phabricator.wikimedia.org/T219401 (DStrine) [22:37:32] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 3 others: Viewing Special:CentralNoticeBanners subpage can throw fatal BannerExistenceException - https://phabricator.wikimedia.org/T149240 (... [22:37:34] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, Patch-For-Review: Thank you email subject and body should be translated in same place - https://phabricator.wikimedia.org/T167806 (DStrine) [22:37:37] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, and 7 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (DStri... [22:42:47] (PS1) Eileen: Update CiviCRM apiv4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/510263 (https://phabricator.wikimedia.org/T217909) [22:56:33] (PS1) Cstone: Separate out endowment specific text from thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510265 [23:01:56] (CR) jerkins-bot: [V: -1] Separate out endowment specific text from thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510265 (owner: Cstone) [23:11:43] (PS2) Cstone: Separate out endowment specific text from thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510265 [23:29:33] hmm, that financial type dropdown on the test form seems to be broken [23:29:46] was it working before? [23:32:56] i'm sure there's a proper way to get those options via API [23:34:03] where is it broken? [23:56:49] (CR) XenoRyet: "Reposting some IRC comments here for longevity:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet)