[00:36:37] Fundraising-Analysis, Fundraising-Backlog, Analytics, MediaWiki-extensions-CentralNotice: CentralNoticeImpression occasionaly fails validation on device enum field - https://phabricator.wikimedia.org/T203597 (AndyRussG) >>! In T203597#5191530, @Ottomata wrote: > @AndyRussG ping, not sure if anyth... [16:09:41] back later fr-tech! [16:57:03] fr-tech there's a patch ready for using the minimal variant in ingenico connect: https://gerrit.wikimedia.org/r/510622 [16:57:14] any review is much appreciated! [17:09:20] Yea, I'll take a look [17:12:06] (PS1) Ejegg: Remove obsolete MX cash payment method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511458 [17:17:32] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 3 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (DStrine) Reso... [17:20:15] XenoRyet: hmm, taking a fresh look at that after the weekend, I think I want to give the config var a longer name [17:21:04] I can see that. Would be useful. [17:21:47] (PS3) Ejegg: Fix Ingenico hosted checkout variants [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510622 (https://phabricator.wikimedia.org/T222290) [17:21:56] since 'Variants' already has that other meaning [17:22:09] ok, PS3 has that updated (and is rebased) [17:22:14] Yea, that could make for confusion down the road. [17:22:21] now called 'HostedFormVariants' [19:23:35] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (AndyRussG) [19:28:27] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create Grafana graphs for CentralNotice impression rates for active campaigns - https://phabricator.wikimedia.org/T223932 (AndyRussG) [19:31:32] AndyRussG: neat ^ [19:31:36] lmk if you need help with that [19:31:51] cwd: ah ok cool! [19:32:15] thx!!! [19:34:30] cwd: yeah at this point it's just a "nice-to-have"... Just adding a few details on the task now [19:35:06] yeah i guess we'd have to somehow...export the data from meta?? [19:40:19] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create Grafana graphs for CentralNotice impression rates for active campaigns - https://phabricator.wikimedia.org/T223932 (AndyRussG) [19:43:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create Grafana graphs for CentralNotice impression rates for active campaigns - https://phabricator.wikimedia.org/T223932 (AndyRussG) Similar, though less specific, task, which we might merge in: T122589 [19:54:23] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Analysis, Fundraising-Backlog, Analytics, MediaWiki-extensions-CentralNotice: CentralNoticeImpression occasionaly fails validation on device enum field - https://phabricator.wikimedia.org/T203597 (DStrine) [19:55:17] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 6 others: Iterate on DS fredge query - https://phabricator.wikimedia.org/T219646 (DStrine) [19:55:20] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: add new field to ds fraud query - https://phabricator.wikimedia.org/T223325 (DStrine)... [19:56:36] (CR) XenoRyet: [C: +2] Remove obsolete MX cash payment method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511458 (owner: Ejegg) [19:58:05] Fundraising-Backlog, fundraising-tech-ops: Enable Content Security Policy on payments-wiki - https://phabricator.wikimedia.org/T223658 (DStrine) @Jgreen This look identical to the ticket referenced. can you give more info? [20:05:46] (Merged) jenkins-bot: Remove obsolete MX cash payment method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511458 (owner: Ejegg) [20:08:21] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, and 7 others: New message inclusion syntax strips with more than one class - https://phabricator.wikimedia.org/T216150 (AndyRussG) @Pcoom... [20:19:18] Fundraising-Backlog: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (KHaggard) p:Triage→High [20:45:50] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/511596 [20:46:12] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/511596 (owner: Ejegg) [20:46:58] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/511596 (owner: Ejegg) [20:48:37] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/511597 [20:49:16] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/511597 (owner: Ejegg) [20:49:31] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/511523 (owner: L10n-bot) [20:51:35] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/511597 (owner: Ejegg) [21:03:06] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue, Accessibility, and 2 others: Banner/CentralNotice should be child of `header` and not above it - https://phabricator.wikimedia.org/T205360 (alexhollender) @Jseddon apologies for the delay in reviewing/responding here. The links... [21:07:43] !log updated payments-wiki from 8397ccf9cc to d5ef5ad067 [21:07:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:08:18] MBeat: I just pushed an update to the D-Local Mexico form to remove the 'Banamex' cash method [21:08:37] thanks, ejegg [21:09:05] Donors trying that would have seen the errors while still on payments-wiki and never would have gotten to dlocal [21:24:24] (CR) AndyRussG: "Thanks!!! This would be OK, but it somewhat defeats the purpose of having dynamic dependencies for choiceData, since that module currently" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 (owner: Krinkle) [21:27:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Civi credential for Engage: Stacey E - https://phabricator.wikimedia.org/T223940 (LeanneS) [21:28:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Civi credential for Engage: Stacey E - https://phabricator.wikimedia.org/T223940 (DStrine) [21:36:33] (CR) Krinkle: [C: +2] Avoid local var in CampaignLog [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492513 (owner: Umherirrender) [21:37:45] (CR) Krinkle: [C: +2] "I feel confident enough with the static view of these changes, and have made similar changes elsewhere, that I think this is good to go. O" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492513 (owner: Umherirrender) [21:38:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Civi credential for Engage: Stacey E - https://phabricator.wikimedia.org/T223940 (Eileenmcnaughton) @LeanneS I think we normally need an email from Lisa authorising [21:42:16] (Merged) jenkins-bot: Avoid local var in CampaignLog [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492513 (owner: Umherirrender) [21:46:52] (PS1) Ejegg: Basic email validation for opt-in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511604 (https://phabricator.wikimedia.org/T218240) [21:49:50] (CR) jerkins-bot: [V: -1] Basic email validation for opt-in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511604 (https://phabricator.wikimedia.org/T218240) (owner: Ejegg) [21:54:06] (PS2) Ejegg: Basic email validation for opt-in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511604 (https://phabricator.wikimedia.org/T218240) [21:56:57] (CR) jerkins-bot: [V: -1] Basic email validation for opt-in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511604 (https://phabricator.wikimedia.org/T218240) (owner: Ejegg) [21:57:53] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): Reduce module registration overhead from CentralNotice - https://phabricator.wikimedia.org/T221805 (Krinkle) [21:58:11] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): Reduce module registration overhead from CentralNotice - https://phabricator.wikimedia.org/T221805 (Krinkle) [21:58:51] (PS3) Ejegg: Basic email validation for opt-in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511604 (https://phabricator.wikimedia.org/T218240) [22:28:02] (CR) jenkins-bot: Avoid local var in CampaignLog [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492513 (owner: Umherirrender) [22:42:07] Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, and 2 others: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (Ejegg) @Jksamra We wi... [23:19:56] (CR) XenoRyet: [C: +1] "Looks good to me. Initially the iframe variant wasn't working quite right, but that was just down to the 'group cards' checkbox not being" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510622 (https://phabricator.wikimedia.org/T222290) (owner: Ejegg)