[00:33:30] (PS1) Cdenes: adding all the multilingual Jan summary emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556837 [00:37:50] Fundraising-Backlog: January Summary Emails - https://phabricator.wikimedia.org/T240648 (CDenes_WMF) [01:07:14] (PS1) Eileen: Code cleanup - mostly declaring function public [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556848 [01:09:31] (PS2) Eileen: Code cleanup - mostly declaring function public [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556848 [01:17:40] (PS3) Eileen: Code cleanup - mostly declaring function public [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556848 [01:31:36] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity - make amount fields optional for USD currency - https://phabricator.wikimedia.org/T240649 (Eileenmcnaughton) [01:32:38] (PS1) Eileen: Fix Benevity form to only require amount fields if currency is not USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556851 (https://phabricator.wikimedia.org/T240649) [02:30:20] (CR) Ejegg: [C: +2] Code cleanup - mostly declaring function public [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556848 (owner: Eileen) [02:33:14] (PS1) Eileen: Code reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556855 [02:35:49] (CR) Ejegg: "Oh hey, do we only use those fields to estimate the exchange rate? We have a database of daily exchange rates that you can query with" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556851 (https://phabricator.wikimedia.org/T240649) (owner: Eileen) [02:35:54] (Merged) jenkins-bot: Code cleanup - mostly declaring function public [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556848 (owner: Eileen) [02:37:35] (CR) Ejegg: [C: +2] "Ah, right, but if they've given us a converted total, we should apply the rate they actually gave us rather than whatever OANDA says we we" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556851 (https://phabricator.wikimedia.org/T240649) (owner: Eileen) [02:37:43] (CR) Eileen: "ejegg we do only use them to calculate the exchange rate - but not OUR exchange rate - the rate used by Benevity" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556851 (https://phabricator.wikimedia.org/T240649) (owner: Eileen) [02:38:48] (CR) Ejegg: [C: +2] Code reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556855 (owner: Eileen) [02:43:52] (Merged) jenkins-bot: Fix Benevity form to only require amount fields if currency is not USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556851 (https://phabricator.wikimedia.org/T240649) (owner: Eileen) [02:43:54] (CR) jerkins-bot: [V: -1] Code reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556855 (owner: Eileen) [02:48:41] (PS1) Eileen: Declare a few exceptions, function visibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556856 [04:19:00] (PS2) Eileen: Declare a few exceptions, function visibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556856 [04:19:02] (PS1) Eileen: Adjust Benevity import code for changes made at Benevity. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556859 (https://phabricator.wikimedia.org/T239954) [04:32:33] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556855 (owner: Eileen) [04:33:05] Fundraising Sprint YAMLton, the Musical, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Benevity to change the reports we receive for Benevity import - https://phabricator.wikimedia.org/T239954 (Eileenmcnaughton) [04:56:59] (PS1) Eileen: Add message support for recovering from a borked import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556860 (https://phabricator.wikimedia.org/T236977) [05:10:07] (PS1) Eileen: Fix issue where source field was sometimes messing with imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556861 (https://phabricator.wikimedia.org/T236977) [08:08:18] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix bug where Benevity import tries & fails to validate source for contacts with one - https://phabricator.wikimedia.org/T236856 (Eileenmcnaughton) [08:24:57] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix bug where Benevity import tries & fails to validate source for contacts with one - https://phabricator.wikimedia.org/T236856 (Eileenmcnaughton) a:Eileenmcnaughton [08:29:08] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity - add date field to form fields instead of import file - https://phabricator.wikimedia.org/T240657 (Eileenmcnaughton) [08:32:58] Wikimedia-Fundraising-CiviCRM: Audit the totals for Benevity import - https://phabricator.wikimedia.org/T237341 (Eileenmcnaughton) @rlewis I think we sorted this one? [08:37:56] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising Sprint YAMLton, the Musical, and 3 others: Audit & support for benevity import - https://phabricator.wikimedia.org/T236977 (Eileenmcnaughton) after some attempts I determin... [08:39:14] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity Import - adding the date the funds were received on the import screen - https://phabricator.wikimedia.org/T236976 (Eileenmcnaughton) [08:39:49] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity - add date field to form fields instead of import file - https://phabricator.wikimedia.org/T240657 (Eileenmcnaughton) [08:39:51] Fundraising Sprint YAMLton, the Musical, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity Import - adding the date the funds were received on the import screen - https://phabricator.wikimedia.org/T236976 (Eileenmcnaughton) [08:40:45] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/556953 (owner: L10n-bot) [08:40:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Review benevity import speed - can we turn off triggers until the end? - https://phabricator.wikimedia.org/T238152 (Eileenmcnaughton) Triggers now disabled for biggest donors - probably enough [09:00:59] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/556953 (owner: L10n-bot) [09:06:05] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/556953 (owner: L10n-bot) [09:26:14] (CR) Raimond Spekking: [C: +2] "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/556953 (owner: L10n-bot) [09:27:08] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/556953 (owner: L10n-bot) [11:27:11] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 2039 2000 - REDIS 3.2.6 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 147 days 9 hours - memory use is 3.42M (peak 20.40M, 0.09% of max, fragmentation 2.05%), connected_slaves is 2, donations is 199, jobs is 0, jobs-adyen is 0, jobs-paypal is 0, payments-antifraud is 122, payments-init is 0, pending is 1, refund is 3, unsubscribe is 27 [11:32:11] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 2243 2000 - REDIS 3.2.6 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 147 days 9 hours - memory use is 3.55M (peak 20.40M, 0.08% of max, fragmentation 1.90%), connected_slaves is 2, donations is 186, jobs is 0, jobs-adyen is 0, jobs-paypal is 3, payments-antifraud is 58, payments-init is 85, pending is 1, refund is 0, unsubscribe is 29 [11:37:11] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 2448 2000 - REDIS 3.2.6 on 127.0.0.1:6379 has 1 databases (db0) with 9 keys, up 147 days 10 hours - memory use is 3.56M (peak 20.40M, 0.09% of max, fragmentation 2.00%), connected_slaves is 2, donations is 137, jobs is 0, jobs-adyen is 0, jobs-paypal is 0, payments-antifraud is 112, payments-init is 0, pending is 0, refund is 2, unsubscribe is 36 [11:42:11] RECOVERY - check_redis on frqueue1001 is OK: OK: REDIS 3.2.6 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 147 days 10 hours - memory use is 3.27M (peak 20.40M, 0.08% of max, fragmentation 2.09%), connected_slaves is 2, donations is 213, jobs is 0, jobs-adyen is 0, jobs-paypal is 1, payments-antifraud is 32, payments-init is 46, pending is 1, recurring is 1730, refund is 0, unsubscribe is 41 [15:06:26] (PS1) Ejegg: update vendor submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/557044 [15:09:51] (CR) jerkins-bot: [V: -1] update vendor submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/557044 (owner: Ejegg) [15:36:39] (CR) Ejegg: [C: +2] Declare a few exceptions, function visibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556856 (owner: Eileen) [15:42:34] (Merged) jenkins-bot: Declare a few exceptions, function visibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/556856 (owner: Eileen) [15:48:33] (PS2) Ejegg: update vendor submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/557044 [15:55:05] (CR) Ejegg: [C: +2] update vendor submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/557044 (owner: Ejegg) [16:00:12] (Merged) jenkins-bot: update vendor submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/557044 (owner: Ejegg) [16:07:12] well that's a really weird payment submethod [16:07:21] how did those get in a message? [16:25:14] pcoombe / Seddon / spatton: we're seeing some invalid payment_submethods coming in to payments-wiki, I think on the query string [16:25:20] all with utm_source B1920_121221_en6C_dsk_p2_sm_txt_hiddencbmsm.no-LP.none [16:27:38] Weird, I don't think anything in that banner touched the payment methods at all [16:28:09] yeah, it's a super long string, too [16:28:25] payment_submethod=b34832f7-8a95-47fa-9c43-bc8682562ea5 [16:28:59] Are they recent? That banner hasn't been up since 11:14 UTC [16:29:25] let's see, this one looks like 04:36 UTC [16:29:41] maybe fraud, I'll see if it's all the same IP [16:30:19] yeah fraud would be my guess, I don't see anything wrong with the banner [16:31:22] ok, thanks for looking! [20:27:04] (PS1) Umherirrender: Use IDatabase::buildLike [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/557106 [21:56:48] (PS1) Umherirrender: Remove wrong default value from WebRequest::getText call [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/557131 [23:24:44] (PS1) Cstone: Remove extra beacause of. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/557148 (https://phabricator.wikimedia.org/T240731) [23:33:52] (CR) Dwisehaupt: [C: +2] "Grammar fix looks good to me." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/557148 (https://phabricator.wikimedia.org/T240731) (owner: Cstone) [23:40:10] (Merged) jenkins-bot: Remove extra beacause of. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/557148 (https://phabricator.wikimedia.org/T240731) (owner: Cstone)