[00:26:16] <wikibugs>	 10Tool-Labs-tools-Pageviews, 06Community-Tech, 10GLAM-Tech: Massviews: bug with pagepile adding extra Wikipedia: on GLAM cultural partnership project pages - https://phabricator.wikimedia.org/T135437#2443577 (10MusikAnimal)
[00:46:13] <Krenair>	 !log deployment-prep T64835: Live-hacked some temporary swift config in
[00:46:13] <stashbot>	 Please !log in #wikimedia-releng for beta cluster SAL
[00:46:15] <stashbot>	 T64835: Setup a Swift cluster on beta-cluster to match production - https://phabricator.wikimedia.org/T64835
[00:46:16] <Krenair>	 no
[00:46:18] <labs-morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/SAL, Master
[00:46:24] <Krenair>	 !log deployment-prep T64835: `foreachwikiindblist "% all-labs.dblist - private.dblist" extensions/WikimediaMaintenance/filebackend/setZoneAccess.php --backend=local-multiwrite`
[00:46:24] <stashbot>	 Please !log in #wikimedia-releng for beta cluster SAL
[00:46:25] <stashbot>	 T64835: Setup a Swift cluster on beta-cluster to match production - https://phabricator.wikimedia.org/T64835
[00:46:28] <labs-morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/SAL, Master
[00:46:28] <Krenair>	 !log deployment-prep T64835: `mwscript extensions/WikimediaMaintenance/filebackend/setZoneAccess.php zerowiki --backend=local-multiwrite --private`
[00:46:28] <stashbot>	 Please !log in #wikimedia-releng for beta cluster SAL
[00:46:29] <stashbot>	 T64835: Setup a Swift cluster on beta-cluster to match production - https://phabricator.wikimedia.org/T64835
[00:46:32] <labs-morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/SAL, Master
[00:46:57] <mutante>	 dzahn@tools-bastion-03:~$ become lolrrit-wm
[00:46:58] <mutante>	 You are not a member of the group tools.lolrrit-wm.
[00:46:58] <mutante>	 Any existing member of the tool's group can add you to that.
[00:47:08] <mutante>	 ^ anyone in that group here
[00:47:19] <mutante>	 can you restart grrrit-wm on kubernetes please
[00:47:49] <Krenair>	 yes
[00:48:34] <Krenair>	 mutante, note that because you're in the 'ops' LDAP group you can probably sudo to it
[00:49:07] <mutante>	 thanks
[00:49:17] <mutante>	 the bot restart is needed because gerrit restarted
[00:49:28] <mutante>	 which happened automatically when we merged a config change 
[00:49:30] <Krenair>	 yeah
[01:02:50] <wikibugs>	 10Tool-Labs-tools-Pageviews, 06Community-Tech, 10GLAM-Tech: Massviews: bug with pagepile adding extra Wikipedia: on GLAM cultural partnership project pages - https://phabricator.wikimedia.org/T135437#2443641 (10MusikAnimal) I have fixed this for the **English Wikipedia only**. It's actually a fair amount of...
[04:18:14] <Matthew_>	 Random question: Did there used to be a meta_p.meta database?  Or am I barking up the wrong tree with this.
[04:20:29] <Matthew_>	 s/database/table
[04:34:20] <Krenair>	 Matthew_, there was meta_p.wiki, meta_p.legacy and meta_p.properties_anon_whitelist
[04:34:37] <Matthew_>	 Krenair: Thanks.  Hmmmmm...
[04:36:29] <Matthew_>	 For whatever reason the tool I'm debugging appears to be using a meta_p.meta database.  
[04:54:26] <Krenair>	 Matthew_, maybe that's what's now called legacy?
[04:54:42] <Krenair>	 which tool is it, how old is it?
[04:55:06] <Matthew_>	 I tried that, it doesn't work.  It's looking for... shortcut, title, title_local, infolink, and marker; fields I don't recognize.
[04:55:15] <Matthew_>	 WikiViewStats, and farily old.
[04:55:21] <Krenair>	 like pre-2013 old?
[04:56:25] <Matthew_>	 Oct 2013 is what it's dated.
[05:03:14] <Krenair>	 no idea, sorry
[05:03:43] <Matthew_>	 That's ok.  Thank you anyway.
[05:17:43] <wikibugs>	 10Tool-Labs-tools-Xtools: resurrect wikiviewstats tool - https://phabricator.wikimedia.org/T91320#2443855 (10Matthewrbowker) Further exploration has revealed the following:  On line 694 of ~/wvs_modules/Core.php, there is a query:  > Select shortcut as prefix, title, title_local, infolink, marker from meta where...
[05:22:02] <wikibugs>	 10Tool-Labs-tools-Xtools, 10Wikibugs, 13Patch-For-Review: Add wikibugs to the Wikimedia XTools IRC Channel - https://phabricator.wikimedia.org/T133364#2443860 (10Matthewrbowker) 05Resolved>03Open Project name changed, re-opening.
[05:35:16] <grrrit-wm>	 (03PS1) 10Matthewrbowker: Fix the project name for xTools, Fix for T133364 [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298121 
[05:35:37] <Matthew_>	 Gosh I hate gerrit...
[05:36:49] <Krenair>	 what's gerrit done?
[05:37:24] <Matthew_>	 Took me three tries to get a one-line fix in, it kept getting very confused and trying to re-submit half a dozen changes.
[05:39:33] <wikibugs>	 10Tool-Labs-tools-Xtools, 10Wikibugs, 13Patch-For-Review: Add wikibugs to the Wikimedia XTools IRC Channel - https://phabricator.wikimedia.org/T133364#2229415 (10Krenair) >>! In T133364#2443860, @Matthewrbowker wrote: > Project name changed, re-opening.  I'm going to just process it for you this time, but fo...
[05:40:05] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Fix the project name for xTools, Fix for T133364 [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298121 (owner: 10Matthewrbowker)
[05:40:25] <grrrit-wm>	 (03PS2) 10Alex Monk: Fix the project name for xTools [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298121 (https://phabricator.wikimedia.org/T133364) (owner: 10Matthewrbowker)
[05:40:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix the project name for xTools [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298121 (https://phabricator.wikimedia.org/T133364) (owner: 10Matthewrbowker)
[05:40:43] <grrrit-wm>	 (03CR) 10Alex Monk: Fix the project name for xTools [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298121 (https://phabricator.wikimedia.org/T133364) (owner: 10Matthewrbowker)
[05:40:48] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Fix the project name for xTools [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298121 (https://phabricator.wikimedia.org/T133364) (owner: 10Matthewrbowker)
[05:41:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix the project name for xTools [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298121 (https://phabricator.wikimedia.org/T133364) (owner: 10Matthewrbowker)
[05:41:32] <Matthew_>	 O.O
[05:41:35] <Krenair>	 Ugh.
[05:42:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix the project name for xTools [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298121 (https://phabricator.wikimedia.org/T133364) (owner: 10Matthewrbowker)
[05:42:59] <Matthew_>	 Is that a problem with my changeset?  Or Jenkins?
[05:43:27] <grrrit-wm>	 (03CR) 10Alex Monk: [V: 032] Fix the project name for xTools [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298121 (https://phabricator.wikimedia.org/T133364) (owner: 10Matthewrbowker)
[05:44:16] <Krenair>	 jenkins or the test or something
[05:44:21] <Krenair>	 definitely not your change
[05:44:35] <Matthew_>	 That's what I thought...
[05:44:55] <Krenair>	 either way I mucked around with the ACLs so I could submit this
[05:45:53] <Matthew_>	 Thank you.  
[05:46:14] <Matthew_>	 ... Do I really have to open a new bug for a one-line change that already has a bug tied to it?
[05:47:56] <Krenair>	 It's a new request
[05:48:01] <Krenair>	 It's 100% more request
[05:48:12] <Krenair>	 Requiring an extra change
[05:48:40] <Matthew_>	 Okay.  
[05:49:40] <Krenair>	 For some reason the deployment script (fab) wants access to one of my SSH keys that it's really not going to get
[05:49:56] <Matthew_>	 I thought wikibugs deployed automatically?
[05:50:03] <Matthew_>	 It did last time I made this change.
[05:51:07] <Krenair>	 Jenkins is supposed to do it.
[05:51:15] <Matthew_>	 Ah...
[05:54:22] <Matthew_>	 Is that https://integration.wikimedia.org/ci/job/labs-tools-wikibugs2-autopull/133/console ?
[05:55:05] <Krenair>	 looks like it
[05:55:18] <Krenair>	 can you test it by editing a task in that project?
[05:55:54] <wikibugs>	 !log tools.wikibugs Updated channels.yaml to: 837a3228cd3a841566bcaf89c1cd71a7682d7518 Fix the project name for xTools
[05:55:55] <wikibugs>	 10Tool-Labs-tools-Xtools, 10Wikibugs, 13Patch-For-Review: Add wikibugs to the Wikimedia XTools IRC Channel - https://phabricator.wikimedia.org/T133364#2443880 (10Matthewrbowker) 05Open>03Resolved >>! In T133364#2443876, @Krenair wrote: >>>! In T133364#2443860, @Matthewrbowker wrote: >> Project name chang...
[05:55:59] <labs-morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.wikibugs/SAL, Master
[05:56:18] <Krenair>	 there it goes
[05:56:29] <Matthew_>	 Wonderful.  Thank you!
[05:56:36] <Krenair>	 you're welcome
[05:58:19] <Krenair>	 oh jenkins did do its autopull thing
[06:00:32] <wikibugs>	 10Wikibugs: Jenkins tests fail every change - https://phabricator.wikimedia.org/T139828#2443884 (10Krenair)
[06:33:32] <wikibugs>	 10Tool-Labs-tools-Xtools: resurrect wikiviewstats tool - https://phabricator.wikimedia.org/T91320#1080054 (10zhuyifei1999) >>! In T91320#2443855, @Matthewrbowker wrote: > Further exploration has revealed the following: >  > On line 694 of ~/wvs_modules/Core.php, there is a query: >  >> Select shortcut as prefix,...
[07:57:52] <grrrit-wm>	 (03PS1) 10Legoktm: Fix/shut up flake8 errors [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298126 (https://phabricator.wikimedia.org/T139828) 
[07:58:39] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Fix/shut up flake8 errors [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298126 (https://phabricator.wikimedia.org/T139828) (owner: 10Legoktm)
[07:58:58] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Make RelEng projects sub-project proof [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/293663 (https://phabricator.wikimedia.org/T137494) (owner: 10Greg Grossmeier)
[07:59:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix/shut up flake8 errors [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298126 (https://phabricator.wikimedia.org/T139828) (owner: 10Legoktm)
[07:59:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make RelEng projects sub-project proof [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/293663 (https://phabricator.wikimedia.org/T137494) (owner: 10Greg Grossmeier)
[07:59:39] <grrrit-wm>	 (03CR) 10Legoktm: "In the future, please don't force merge :/" [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298121 (https://phabricator.wikimedia.org/T133364) (owner: 10Matthewrbowker)
[07:59:56] <wikibugs>	 10Wikibugs, 13Patch-For-Review: Jenkins tests fail every change - https://phabricator.wikimedia.org/T139828#2443964 (10Legoktm) 05Open>03Resolved a:03Legoktm
[08:00:27] <wikibugs>	 10Wikibugs, 06Release-Engineering-Team, 15User-greg: Fix up RelEng related IRC notifications from Phabricator - https://phabricator.wikimedia.org/T137494#2443966 (10Legoktm) 05Open>03Resolved a:03greg
[08:54:07] <psychoslave>	 Hi, I have working python script that I can launch on toollab, within a virtualenv where I installed the required for this tool. Now I would like to call this script from a php frontend page 
[08:55:47] <psychoslave>	 but using "$cmd = 'sh ../env/bin/python --version';
[08:55:50] <psychoslave>	 exec($cmd, $output);" won't works, any idea why ?
[08:57:07] <valhallasw`vecto>	 Psychoslave: check your error.log?
[08:58:15] <psychoslave>	 oh, great thank you :)
[08:59:39] <psychoslave>	 seems like python output it's version to stderror…
[08:59:42] <psychoslave>	 ^^
[09:54:29] <valhallasw`vecto>	 psychoslave (IRC): also, if you're going to pass user-provided information, be very careful about shell injection vulnerabilities
[09:55:39] <psychoslave>	 yes, rightly I'm making test with escapeshellarg
[09:56:27] <psychoslave>	 Would you have any other recommandation about that?
[10:00:05] <zhuyifei1999_>	 single quote everything
[10:00:29] <zhuyifei1999_>	 replace single quotes with '"'"'
[10:00:47] <psychoslave>	 escapeshellarg seems to do that 
[10:01:30] * zhuyifei1999_ is php-1 so dunno about those php built-in functions
[10:03:37] <valhallasw`cloud>	 zhuyifei1999_: uh, that's horrible advice
[10:03:56] <valhallasw`cloud>	 use the provided functions to escape things correclty
[10:04:09] <valhallasw`cloud>	 because if you try to do it manually, you're guaranteed to miss an edge case
[10:04:24] <zhuyifei1999_>	 I don't think there's an edge case
[10:04:51] <zhuyifei1999_>	 single quotes escapes everything except other single quotes
[10:05:15] <zhuyifei1999_>	 (with bash at least)
[10:06:14] <zhuyifei1999_>	 https://www.irccloud.com/pastebin/L8qjZ3RX/
[10:07:40] <psychoslave>	 feel free to try some injection http://tools.wmflabs.org/catscore/?cat=Philosophy
[10:07:55] <psychoslave>	 warning : this prototype is very slow
[10:08:34] <psychoslave>	 you have the escaped string on the top of the page
[10:09:10] <zhuyifei1999_>	 Content-Length: 0
[10:11:40] <zhuyifei1999_>	 psychoslave: if(if(isset($_GET["cat"])) <= two if-s? is if a function that I never heard of?
[10:12:02] <psychoslave>	 hmm, sorry I just made some breaking changes
[10:13:52] <psychoslave>	 It should run now
[10:15:02] <zhuyifei1999_>	 valhallasw`cloud: fyi https://hg.python.org/cpython/file/tip/Lib/shlex.py#l278
[10:15:52] <zhuyifei1999_>	 psychoslave: yes it is _slow_
[10:16:28] <psychoslave>	 sure, damn slow ^^
[10:16:29] <zhuyifei1999_>	 have you considered using uwsgi?
[10:17:28] <zhuyifei1999_>	 about the slowness https://phabricator.wikimedia.org/T136712
[10:17:50] <psychoslave>	 I don't know uwsgi yet, but why not
[10:18:28] <zhuyifei1999_>	 k
[10:19:32] <psychoslave>	 I don't think the php frontend is the performance bottleneck though
[10:19:44] <zhuyifei1999_>	 no, but venv is
[10:19:53] <zhuyifei1999_>	 see https://phabricator.wikimedia.org/T136712
[10:20:28] <psychoslave>	 my python script is slow actually
[10:21:52] <psychoslave>	 it fetches every listed pages from en.wp 
[10:22:54] <psychoslave>	 but for what I began to read, it looks like I should be able to use a local dump on labs, isn't it?
[10:23:17] <zhuyifei1999_>	 reading dumps is slower
[10:23:47] <zhuyifei1999_>	 it's like going through millions (billions?) of pages to get a single rev text
[10:28:13] <zhuyifei1999_>	 basically, when you're going to analyze millions of page texts from wikipedia, use dumps
[10:30:00] <zhuyifei1999_>	 or if you're analyzing thousands of pages and don't care about the recent-ness of the texts
[10:31:16] <psychoslave>	 ok, thank you for the information
[10:31:24] <zhuyifei1999_>	 np
[10:41:31] <zhuyifei1999_>	 psychoslave: http://tools.wmflabs.org/catscore/?cat=%3Cscript%3Ealert(%22evil%20code%20here!%22)%3C/script%3E fyi
[10:42:23] <psychoslave>	 thank you :)
[10:42:29] <zhuyifei1999_>	 lol np
[11:34:22] <wikibugs>	 06Labs, 10Labs-Infrastructure: Automatically updated list of all configured domains - https://phabricator.wikimedia.org/T45580#2444240 (10Nemo_bis) Yes, something like that, made into a sortable table with clickable links and regularly updated.
[12:12:12] <paladox>	 !log git setting up zuul
[12:12:15] <labs-morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Git/SAL, Master
[15:05:26] <wikibugs>	 06Labs, 10Tool-Labs: Delete tool 'rcm' - https://phabricator.wikimedia.org/T136216#2444461 (10Luke081515) Is deleting a tool hard? I'm just wondering, why this takes so much time.
[15:07:49] <wikibugs>	 06Labs, 10Tool-Labs: Delete tool 'rcm' - https://phabricator.wikimedia.org/T136216#2326965 (10valhallasw) It's nontrivial. Is there a reason to not just leave a redirect in place?
[15:10:29] <wikibugs>	 06Labs, 10Tool-Labs: Delete tool 'rcm' - https://phabricator.wikimedia.org/T136216#2444464 (10Luke081515) I'm just wondering, because as normal user, there is a button for deleting a tool, (which I can't use), but from outside it looks like that this is simple.
[15:20:26] <wikibugs>	 06Labs, 10Tool-Labs: Delete tool 'rcm' - https://phabricator.wikimedia.org/T136216#2326965 (10bd808) From https://wikitech.wikimedia.org/wiki/Help:Tool_Labs/FAQ#Can_I_delete_a_tool.3F > Tools cannot be deleted. However, you can make an existing web tool inaccessible by shutting down the web service (`webservic...
[15:27:36] <Luke081515>	 bd808: I wonder why there is a button at the directoy of tools then
[15:29:15] <valhallasw`cloud>	 Luke081515: do you mean the 'remove service group' button on wikitech?
[15:29:52] <Luke081515>	 yep
[15:30:09] <valhallasw`cloud>	 that does exactly what it says it does: it removes the service group. From LDAP.
[15:30:25] <valhallasw`cloud>	 but it doesn't do anything else
[15:30:38] <valhallasw`cloud>	 so what it mostly does is break things rather than clean up things
[15:30:48] <Luke081515>	 ah, ok
[15:31:03] <valhallasw`cloud>	 (running jobs on the grid stay there, crontabs probably still fire, et cetera, but you can't login anymore to fix it)
[15:31:14] <valhallasw`cloud>	 and then the next problem is that someone else can reclaim the name
[15:31:33] <valhallasw`cloud>	 so it causes more issues than it solves
[15:32:51] <zhuyifei1999_>	 do we have a list of such?
[15:33:27] <zhuyifei1999_>	 I mean things to be cleaned up when tool get deleted
[15:33:49] <valhallasw`cloud>	 We're not going to delete tools.
[15:34:02] <valhallasw`cloud>	 unless there is a good reason to do so
[15:34:14] <valhallasw`cloud>	 again, it's a lot of work for limited value
[15:34:54] <Luke081515>	 valhallasw`cloud: but I can of a tool gets created in bad faith it is at least possible?
[15:35:15] <valhallasw`cloud>	 Luke081515: in that case, it makes more sense to transfer ownership than to delete the tool
[15:36:03] <Luke081515>	 valhallasw`cloud: and if the name is the problem?
[15:36:21] <valhallasw`cloud>	 I'm not really interested in dealing with hypotheticals
[15:36:52] <valhallasw`cloud>	 if the name is offensive, it might be blocked and removed, and the same would probably happen to the person who created that tool
[15:36:59] <Luke081515>	 ok
[15:37:10] <Luke081515>	 otehrwise it would be a risk, that was that, why I asked that^^
[17:05:24] <grrrit-wm>	 (03CR) 10Alex Monk: "We tried it without doing that but Jenkins wasn't cooperating, I filed a task about the issue." [labs/tools/wikibugs2] - 10https://gerrit.wikimedia.org/r/298121 (https://phabricator.wikimedia.org/T133364) (owner: 10Matthewrbowker)
[19:28:59] <wikibugs>	 10Tool-Labs-tools-Pageviews, 06Community-Tech, 07I18n: url-structure-massviews-project is not documented and not used - https://phabricator.wikimedia.org/T139856#2444614 (10Amire80)
[19:38:02] <wikibugs>	 10Tool-Labs-tools-Pageviews, 06Community-Tech, 07I18n: url-structure-massviews-project is not documented and not used - https://phabricator.wikimedia.org/T139856#2444634 (10MusikAnimal) 05Open>03Resolved a:03MusikAnimal Thank you!! It is supposed to be used, I guess I just put in the wrong message =P F...
[21:40:58] <wikibugs>	 06Labs, 10Labs-Kubernetes, 10Tool-Labs: Issues with 'webservice' kubernetes backend - https://phabricator.wikimedia.org/T139107#2444791 (10Magog_the_Ogre) Updated, seems to be working, thanks all.
[22:49:45] <wikibugs>	 06Labs: Request creation of <Replace Me> labs project - https://phabricator.wikimedia.org/T139863#2444900 (10ellery)
[22:49:52] <wikibugs>	 06Labs: Request creation of readmore labs project - https://phabricator.wikimedia.org/T139863#2444914 (10ellery)
[22:50:48] <wikibugs>	 06Labs: Request creation of detox labs project - https://phabricator.wikimedia.org/T139864#2444915 (10ellery)
[22:52:31] <wm-bot>	 Change on 12wikitech.wikimedia.org a page Nova Resource:Tools/Access Request/Ewulczyn was modified, changed by Ewulczyn link https://wikitech.wikimedia.org/w/index.php?diff=732831 edit summary: 
[23:29:55] <wikibugs>	 06Labs, 07Tracking: New Labs project requests (tracking) - https://phabricator.wikimedia.org/T76375#2444974 (10ellery)
[23:29:57] <wikibugs>	 06Labs: Request creation of detox labs project - https://phabricator.wikimedia.org/T139864#2444973 (10ellery) 05Open>03Invalid
[23:30:10] <wikibugs>	 06Labs, 07Tracking: New Labs project requests (tracking) - https://phabricator.wikimedia.org/T76375#1455010 (10ellery)
[23:30:13] <wikibugs>	 06Labs: Request creation of readmore labs project - https://phabricator.wikimedia.org/T139863#2444975 (10ellery) 05Open>03Invalid