[00:02:41] 10Labs-project-Wikistats: Wikistats 2.2 [beta] gives internal server error 500 for all csv, ssv and xml formats - https://phabricator.wikimedia.org/T165879#3280760 (10Dzahn) @Xqt Sorry as well, not your fault since it's easy to confuse them. I appreciate you reported it and it's good to know it is actually used... [00:33:31] PROBLEM - Puppet errors on tools-exec-1436 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [01:08:32] RECOVERY - Puppet errors on tools-exec-1436 is OK: OK: Less than 1.00% above the threshold [0.0] [01:43:32] PROBLEM - Puppet errors on tools-exec-1423 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [01:46:28] 10Labs-project-Phabricator: Date problem on phab-01.wmflabs.org, comments timestamp was reset - https://phabricator.wikimedia.org/T165679#3280824 (10mmodell) phab-01 should be running the same code as production, afaik [01:58:27] (03PS2) 10Lokal Profil: Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) [02:00:05] (03CR) 10jerkins-bot: [V: 04-1] Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) (owner: 10Lokal Profil) [02:05:47] (03PS3) 10Lokal Profil: Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) [02:07:48] (03CR) 10jerkins-bot: [V: 04-1] Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) (owner: 10Lokal Profil) [02:12:06] (03PS4) 10Lokal Profil: Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) [02:13:39] (03CR) 10jerkins-bot: [V: 04-1] Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) (owner: 10Lokal Profil) [02:16:35] (03PS5) 10Lokal Profil: Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) [02:18:31] RECOVERY - Puppet errors on tools-exec-1423 is OK: OK: Less than 1.00% above the threshold [0.0] [06:52:24] PROBLEM - Puppet errors on tools-exec-1430 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [07:27:23] RECOVERY - Puppet errors on tools-exec-1430 is OK: OK: Less than 1.00% above the threshold [0.0] [07:57:28] 06Labs, 06cloud-services-team, 10wikitech.wikimedia.org: Wikitech rights for Quiddity - https://phabricator.wikimedia.org/T165939#3281008 (10bd808) [08:04:56] (03PS6) 10Lokal Profil: Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) [08:33:44] 06Labs, 06cloud-services-team, 10wikitech.wikimedia.org: Wikitech rights for Quiddity - https://phabricator.wikimedia.org/T165939#3281008 (10chasemp) p:05Triage>03Normal [08:52:52] (03PS7) 10Lokal Profil: Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) [09:16:25] (03PS1) 10Lokal Profil: [WIP]An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) [09:17:20] (03CR) 10jerkins-bot: [V: 04-1] [WIP]An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [09:17:29] (03PS2) 10Lokal Profil: An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) [09:18:37] (03CR) 10jerkins-bot: [V: 04-1] An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [09:23:04] (03PS3) 10Lokal Profil: An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) [09:24:32] (03CR) 10jerkins-bot: [V: 04-1] An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [09:29:36] (03PS8) 10Jean-Frédéric: Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) (owner: 10Lokal Profil) [09:43:09] 06Labs, 06cloud-services-team, 10wikitech.wikimedia.org: Wikitech rights for Quiddity - https://phabricator.wikimedia.org/T165939#3281439 (10Andrew) Fine with me! [09:43:48] (03PS4) 10Jean-Frédéric: An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [09:44:56] (03CR) 10jerkins-bot: [V: 04-1] An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [09:45:44] (03PS5) 10Jean-Frédéric: An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [09:46:55] (03CR) 10jerkins-bot: [V: 04-1] An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [10:12:03] (03PS1) 10Lokal Profil: Create fill monuments_all sql for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354938 (https://phabricator.wikimedia.org/T165932) [10:15:43] (03PS6) 10Jean-Frédéric: An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [10:21:52] (03CR) 10jerkins-bot: [V: 04-1] An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [10:39:56] 06Labs, 06cloud-services-team, 10wikitech.wikimedia.org, 15User-bd808: Wikitech rights for Quiddity - https://phabricator.wikimedia.org/T165939#3281593 (10bd808) 05Open>03Resolved a:03bd808 "(change visibility) 2017-05-21T10:28:38 BryanDavis (talk | contribs | block) changed group membership for Quid... [10:42:58] (03PS1) 10Lokal Profil: Re-add il_npa_he [labs/tools/heritage] - 10https://gerrit.wikimedia.org/r/354942 [10:46:11] (03CR) 10Jean-Frédéric: [C: 032] Re-add il_npa_he [labs/tools/heritage] - 10https://gerrit.wikimedia.org/r/354942 (owner: 10Lokal Profil) [10:48:05] (03Merged) 10jenkins-bot: Re-add il_npa_he [labs/tools/heritage] - 10https://gerrit.wikimedia.org/r/354942 (owner: 10Lokal Profil) [10:50:39] (03CR) 10jenkins-bot: Re-add il_npa_he [labs/tools/heritage] - 10https://gerrit.wikimedia.org/r/354942 (owner: 10Lokal Profil) [10:51:11] (03CR) 10Lokal Profil: [C: 032] "I don't care that this test isn't passing.... its a hackathon!" [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [10:54:11] (03CR) 10jerkins-bot: [V: 04-1] An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [10:54:36] 06Labs, 06Project-Admins: Request creation of wikidata-documentation labs project - https://phabricator.wikimedia.org/T165962#3281622 (10Spinster) [10:55:58] 06Labs, 06Project-Admins: Request creation of wikidata-documentation labs project - https://phabricator.wikimedia.org/T165962#3281640 (10Spinster) [11:04:28] (03PS7) 10Lokal Profil: An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) [11:10:53] (03CR) 10jerkins-bot: [V: 04-1] An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [11:13:12] (03PS8) 10Lokal Profil: An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) [11:16:30] (03CR) 10Lokal Profil: [C: 032] An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [11:18:19] (03Merged) 10jenkins-bot: An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [11:19:24] (03CR) 10jenkins-bot: An example wikidata config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354913 (https://phabricator.wikimedia.org/T165953) (owner: 10Lokal Profil) [11:21:05] (03PS9) 10Lokal Profil: Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) [11:23:03] (03PS2) 10Lokal Profil: Create fill monuments_all sql for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354938 (https://phabricator.wikimedia.org/T165932) [11:28:53] PROBLEM - Puppet errors on tools-exec-1407 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [11:47:09] 06Labs, 06Project-Admins, 15User-bd808, 06cloud-services-team (Kanban): Create wmcs-team project and kanban milestone - https://phabricator.wikimedia.org/T165703#3281994 (10Aklapper) Yesh! Thank you. (We can still have a proper fight about the alt tag if a conflict ever comes up.) [11:51:05] is there a way to pass environment variables to a kubernetes webservice? [12:03:52] RECOVERY - Puppet errors on tools-exec-1407 is OK: OK: Less than 1.00% above the threshold [0.0] [12:16:40] (03CR) 10Jean-Frédéric: [C: 032] Construct country sqls for wikidata configs (032 comments) [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) (owner: 10Lokal Profil) [12:18:11] (03Merged) 10jenkins-bot: Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) (owner: 10Lokal Profil) [12:19:03] (03CR) 10jenkins-bot: Construct country sqls for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354742 (https://phabricator.wikimedia.org/T165919) (owner: 10Lokal Profil) [12:20:40] bd808: madhuvishy: Could you approve tools/shell request for 'honeypot95' (Hackathon) [12:21:31] (03PS1) 10Jean-Frédéric: [WIP] harvest Wikidata into monuments database [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354961 [12:25:17] Krinkle: done [12:25:26] Thank you! [12:37:01] (03PS2) 10Jean-Frédéric: [WIP] harvest Wikidata into monuments database [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354961 [12:38:08] (03CR) 10Jean-Frédéric: [C: 032] Create fill monuments_all sql for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354938 (https://phabricator.wikimedia.org/T165932) (owner: 10Lokal Profil) [12:39:25] (03Merged) 10jenkins-bot: Create fill monuments_all sql for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354938 (https://phabricator.wikimedia.org/T165932) (owner: 10Lokal Profil) [12:40:46] (03PS3) 10Jean-Frédéric: Proof of concept to harvest Wikidata into monuments database [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354961 (https://phabricator.wikimedia.org/T165988) [12:41:57] (03PS4) 10Jean-Frédéric: Proof of concept to harvest Wikidata into monuments database [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354961 (https://phabricator.wikimedia.org/T165988) [12:43:02] (03CR) 10jenkins-bot: Create fill monuments_all sql for wikidata configs [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354938 (https://phabricator.wikimedia.org/T165932) (owner: 10Lokal Profil) [12:49:40] bd808: Seems we have the same problem as yesterday. The sql access doesn't work for the user account. [12:57:41] Krinkle: I'm out in the historic tour but back in 30 [12:58:06] Do the credentials exist [13:00:26] (03PS1) 10Lokal Profil: Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 [13:01:17] (03CR) 10Jean-Frédéric: [C: 032] "LGTM" [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:02:02] (03CR) 10jerkins-bot: [V: 04-1] Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:02:54] (03CR) 10jerkins-bot: [V: 04-1] Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:03:10] (03PS2) 10Lokal Profil: Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 [13:03:41] (03CR) 10Jean-Frédéric: [C: 032] Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:04:48] madhuvishy: It said "Access denied for user" - that means the user exists, right? [13:05:02] (03CR) 10jerkins-bot: [V: 04-1] Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:05:03] madhuvishy: Ah, okay, perhaps there is someone else I can ask? [13:05:41] (03CR) 10jerkins-bot: [V: 04-1] Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:07:15] (03PS3) 10Lokal Profil: Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 [13:07:52] (03CR) 10Jean-Frédéric: [C: 032] Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:08:51] (03CR) 10jerkins-bot: [V: 04-1] Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:08:53] (03CR) 10jerkins-bot: [V: 04-1] Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:10:46] (03PS4) 10Lokal Profil: Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 [13:11:04] (03CR) 10Multichill: "Everything is now at https://github.com/multichill/toollabs" [labs/tools/multichill] - 10https://gerrit.wikimedia.org/r/223670 (owner: 10Multichill) [13:11:05] (03CR) 10Jean-Frédéric: [C: 032] Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:11:09] (03Abandoned) 10Multichill: Pre wikimania backup [labs/tools/multichill] - 10https://gerrit.wikimedia.org/r/223670 (owner: 10Multichill) [13:13:14] (03Merged) 10jenkins-bot: Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:16:21] (03CR) 10jenkins-bot: Repair broken skip [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354974 (owner: 10Lokal Profil) [13:17:52] (03Abandoned) 10Multichill: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/labs/tools/multichill into prewikimania [labs/tools/multichill] - 10https://gerrit.wikimedia.org/r/223671 (owner: 10Multichill) [13:29:55] PROBLEM - Puppet errors on tools-exec-1407 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [13:32:01] (03PS1) 10Lokal Profil: fix [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354983 [13:32:44] (03CR) 10Jean-Frédéric: [C: 032] fix [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354983 (owner: 10Lokal Profil) [13:36:52] (03Merged) 10jenkins-bot: fix [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354983 (owner: 10Lokal Profil) [13:37:13] Krinkle: sorry I'm looking right now [13:42:16] 06Labs, 06Project-Admins: Request creation of wikidata-documentation labs project - https://phabricator.wikimedia.org/T165962#3282638 (10Aklapper) @Spinster: Is this a request to create a project on Labs (because in that case it should not be #Project-Admins)? Or is this a request to create a project in Phabr... [13:42:28] Krinkle: fixed [13:43:25] it's a really annoying edge case issue - i assume some old labsdb users are now signing up for tools and the script trips up trying to create users for them [13:47:27] (03PS1) 10Lokal Profil: Only strip on one side [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354987 [13:53:57] (03CR) 10jenkins-bot: fix [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354983 (owner: 10Lokal Profil) [13:59:02] 06Labs, 10Horizon, 10MediaWiki-Vagrant: Create MediaWiki Vagrant role for local devlopment of Horizon customizations - https://phabricator.wikimedia.org/T166006#3282654 (10bd808) [13:59:27] 06Labs, 06Project-Admins: Request creation of wikidata-documentation labs project - https://phabricator.wikimedia.org/T165962#3282668 (10Aklapper) I also assume there is a relation to https://www.wikidata.org/wiki/Wikidata:WikiProject_Documentation ? :) [14:01:10] 06Labs, 10Horizon, 10MediaWiki-Vagrant, 13Patch-For-Review, and 2 others: Create MediaWiki Vagrant role for local devlopment of Horizon customizations - https://phabricator.wikimedia.org/T166006#3282677 (10bd808) p:05Triage>03Normal a:03bd808 [14:04:54] RECOVERY - Puppet errors on tools-exec-1407 is OK: OK: Less than 1.00% above the threshold [0.0] [14:05:48] (03PS2) 10Lokal Profil: Only strip on one side and fix whitespace in the demo config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354987 [14:36:38] (03CR) 10Jean-Frédéric: [C: 032] Only strip on one side and fix whitespace in the demo config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354987 (owner: 10Lokal Profil) [14:39:41] (03Merged) 10jenkins-bot: Only strip on one side and fix whitespace in the demo config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354987 (owner: 10Lokal Profil) [14:49:13] (03CR) 10jenkins-bot: Only strip on one side and fix whitespace in the demo config [labs/tools/heritage] (wikidata) - 10https://gerrit.wikimedia.org/r/354987 (owner: 10Lokal Profil) [15:19:51] 06Labs, 10BetaFeatures, 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10wikitech.wikimedia.org: ERI requesting opt-in on wikitech but not available - https://phabricator.wikimedia.org/T165822#3277753 (10Etonkovidova) Confirmed - the invite guide tour for New filters beta feature appears althou... [15:22:46] 06Labs, 10Tool-Labs: Show puppet classes on instances in openstack browser - https://phabricator.wikimedia.org/T166014#3282870 (10Paladox) [15:27:53] 06Labs, 10BetaFeatures, 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10wikitech.wikimedia.org: ERI requesting opt-in on wikitech but not available - https://phabricator.wikimedia.org/T165822#3277753 (10Catrope) ```17:27:39 <+RoanKattouw> I guess "BetaFeatures is not installed" is not an edge... [21:45:54] 06Labs, 10Horizon: Provide watroles functionality in Horizon - https://phabricator.wikimedia.org/T151522#3283210 (10bd808) [21:45:56] 06Labs, 10Tool-Labs: Show puppet classes on instances in openstack browser - https://phabricator.wikimedia.org/T166014#3283212 (10bd808) [21:47:03] 06Labs, 10Horizon: Fix watroles to work with new Puppet storage backend for Labs - https://phabricator.wikimedia.org/T151522#2820072 (10bd808) [22:50:33] (03CR) 10BryanDavis: [C: 032] "Trivial cleanup" [labs/striker] - 10https://gerrit.wikimedia.org/r/353908 (owner: 10BryanDavis) [22:52:26] (03Merged) 10jenkins-bot: Make django's makemigrations happy [labs/striker] - 10https://gerrit.wikimedia.org/r/353908 (owner: 10BryanDavis)