[00:01:06] Everything's fine when changed to English, though. [00:01:30] Rancher: does the serbian wiki's about page a disambiguation page? [00:01:37] Disambiguation page: http://en.wikipedia.org/wiki/About [00:04:48] i edit mostly on my tablet. [00:04:58] yuvipanda: What do you mean? [00:05:21] Rancher: doesn't it go to http://en.wikipedia.org/wiki/Wikipedia:About [00:05:21] ? [00:05:41] preilly: amit found no issues. any reason to hold off on mailing RC2 ? [00:05:56] tfinc: not that I can think of [00:07:11] k. sent [00:08:54] No, it goes to http://en.wikipedia.org/wiki/About. Maybe because there is no Serbian article about "About:Wikipedia", only for "Wikipedia" (http://en.wikipedia.org/wiki/Wikipedia) [00:14:19] sorry, back now [00:14:26] preilly: thanks [00:14:54] philinje: np [00:14:56] Rancher: not seeing disambiguation page on my phone [00:15:01] maybe a bug? [00:15:26] Did you change it to Serbian? [00:15:34] never mind, just read your last comment [00:16:25] By the way, when I select a language in settings and exit the application, it goes back to English for some reason. [00:16:42] Steven_Zhang: we are considering various tablet approaches, especially editing or contribution related [00:16:48] Rancher: bug i'm working on [00:16:49] oh good. [00:16:57] until then i'll just use the full browser [00:17:12] if you have any ideas, please let me know [00:17:45] well, enable editing [00:17:47] we just implemented login so you should be able to login on a tablet [00:17:49] even basic editintg [00:17:57] on the mobile wikipedia app? [00:18:05] or the mobile browser version? [00:18:15] yes, but then you can browse to the regular site [00:18:58] mobile login is a specific process on any mobile device, using the browser [00:19:05] kinda defeats the purpose, no? [00:19:17] wouldnt you just use the full version anyways? [00:19:56] the reason to release mobile login was not to enable normal editing, but that is a side benefit [00:20:34] yuvipanda: OK. I changed several other languages in settings and all of them are using disambiguation page instead of Wikipedia:About. [00:20:41] we are thinking about specific workflows and certain kinds of editing for tablets [00:20:41] uh oh. [00:20:43] let me check [00:21:11] Rancher: thanks for checking - sounds like we have a general issue with many languages [00:21:19] :D [00:21:29] ah, got it [00:21:41] Checked languages: Serbian, Macedonian, Croatian, Russian. [00:21:44] we're going to Wikipedia:About in all languages [00:21:48] Bulgarian. [00:21:52] ofcourse, the title is different in each one of them [00:22:21] Rancher: can you give me the link to the 'disambiguation page' you're seeing? [00:22:28] http://en.wikipedia.org/wiki/About [00:22:58] Rancher: which languages did you see disambiguation in? [00:23:05] All of the mentioned above. [00:23:34] Russian and Bulgarian had "Wikipedia:About" article, why others didn't. [00:23:34] ok, sorry [00:24:22] philinje: can you file a bug? [00:25:04] yes [00:25:32] Polish gave me 404 error. [00:25:32] sounds like the issue is more about what languages have an article at Wikipedia:About [00:25:46] Maybe, but I don't think so. [00:26:04] philinje: no, the issue is [00:26:13] Wikipedia:About is probably called something else in other languages [00:26:28] it is http://it.wikipedia.org/wiki/Wikipedia:Sala_stampa/Wikipedia in Italian, for example [00:26:49] philinje: Rancher check interwikilinks on http://en.wikipedia.org/wiki/Wikipedia:About [00:27:45] yuvipanda: is the link hard coded, in English, in the app? [00:27:52] philinje: in the app hard coded [00:27:55] philinje: hence a bug [00:28:04] ok got it [00:28:25] philinje: can you file a bug? [00:28:37] or Rancher ? [00:29:09] i'll do it [00:29:21] philinje: thanks :) [00:29:51] probably we need to navigate the interwiki link in some automatic way, eh? [00:30:30] philinje: yes, am sure i can figure something out. [00:31:36] Oh, about Serbian main page... Can somebody add those selectors so I could automatically see the main page on Android? [00:32:25] Serbian main page is not protected, so if anyone can do it, I would be thankful. :) [00:34:49] brion: preilly can someone CR this? https://github.com/yuvipanda/WikipediaMobile/tree/sync-preferences [00:35:41] Rancher: problem is, the admin is the person who should do it, otherwise there could be issues [00:35:52] any idea who that is for Serbian Wikipedia? [00:36:58] brion: preilly it's a somewhat 'bigger' than usual change. A good look at preferences.js would also be awesome. [00:37:08] and apologies for not making the commits more atomic than just 4. [00:39:41] philinje: http://sr.wikipedia.org/wiki/%D0%9A%D0%BE%D1%80%D0%B8%D1%81%D0%BD%D0%B8%D0%BA:%D0%96%D0%B5%D1%99%D0%BA%D0%BE_%D0%A2%D0%BE%D0%B4%D0%BE%D1%80%D0%BE%D0%B2%D0%B8%D1%9B [00:39:58] Those Cyrillic characters... :D [00:40:18] philinje: so, what do we do if there is no Wikipedia:About page in that particular language's wiki? [00:40:34] philinje: and, shouldn't this be about the application, rather than about wikipedia? [00:40:45] I said the same thing, yuvipanda. [00:40:53] philinje: should we ping heather, get an about screen done? [00:43:00] sec [00:43:10] philinje: One of the administrators is Жељко Тодоровић in the link above. [00:43:55] thanks [00:44:39] yuvipanda: maybe a screen graphic is a good idea, i will include that in the bug [00:44:56] philinje: so it'll become about the app instead of about wikipedia [00:45:10] yuvipanda, the async function in defaults looks weird [00:45:42] does that work consistently? i'm not 100% sure whether the callback gets called async (later) or immediately [00:46:02] brion: i've a 'serializer' of sorts down there that actually does the calling [00:46:08] ah excellent [00:46:15] yuvipanda: one trade-off is the page has to be localized, if about the app [00:46:18] durrrr i skipped the comment that explains it yuvipanda [00:46:20] :DD [00:46:22] :D [00:48:58] +// Data storage still uses Lawnchair <- looks like it uses localStorage instead [00:49:08] brion: data storage uses lawnchair [00:49:17] brion: preferences use localStorage [00:49:24] oh i see [00:49:29] brion: should clarify [00:49:31] i thought it meant the data storage *for* preferences [00:49:35] k [00:49:54] looks workable [00:50:16] brion: nothing horrible? [00:50:28] brion: also, I realized we never actually separated Interface language from content language [00:50:52] well, for interface language we use the system locale always [00:51:05] currently at least :D [00:51:27] and then we overwrote the same variable later on to represent content language :D [00:51:37] yuck :) [00:51:38] now it's clearly separated. [00:51:41] yay [00:51:50] Would be better to use drop-down list for interface language, if you ask me. [00:52:20] perhaps. it's a tough decision to make at times [00:52:32] we certainly could though! [00:53:02] brion: good enough to merge? [00:53:11] I don't know. I like it better that way. More pros than cons. [00:53:29] Rancher, biggest pro is that we support more locales than Android doe [00:53:30] *does [00:53:51] so you can select your own language even if your phone is otherwise in english, german, russian whatever [00:54:18] Wow, that is even greater. [00:55:02] yuvipanda, looks good on a quick look! [00:55:03] And congratulations for having more locales than Android does. :) [00:55:08] :D [00:55:09] * yuvipanda goes to change his android phone back to english. [00:55:23] brion: I hope eventually to move everything into classes. [00:55:43] without one 'grand refactoring release!' [00:55:47] aka netscape 4 :P [00:56:31] hehe [00:56:52] yuvipanda, i approve [00:57:48] Looking forward to drop-down list language change. :P [00:59:02] philinje: uh, there was already a bug for the 'about' bug https://bugzilla.wikimedia.org/show_bug.cgi?id=32914 [00:59:14] brion: are you going to merge it in or wait for preilly to take a look as well? [01:00:41] yuvipanda, which branch was it again? [01:00:46] sync-preferences ? [01:00:49] brion: yes. [01:01:04] brion: i pushed a commit fixing that unclear comment just now, so pull :) [01:01:07] Rancher, i stuck a note in https://bugzilla.wikimedia.org/33528 on that so we don't forget [01:01:28] ok lemme run a quick test [01:02:41] yuvipanda: oops, should have seen that - not sure why it didn't appear [01:02:48] brion: Great. [01:02:54] philinje: i closed the other one since this had a more detailed comment [01:02:57] lookin' functional :D [01:03:15] [WikipediaMobile] brion pushed 6 new commits to master: http://git.io/9oq2vw [01:03:15] [WikipediaMobile/master] Separate preferences class created - YuviPanda [01:03:15] [WikipediaMobile/master] Move fontSize and locale to use new preferences class. - YuviPanda [01:03:15] [WikipediaMobile/master] Moved cache.js to app.js - YuviPanda [01:03:28] Project WikipediaMobile - Nightly builds build #49: SUCCESS in 6.3 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/49/ [01:03:29] * yuvipanda: Separate preferences class created [01:03:29] * yuvipanda: Move fontSize and locale to use new preferences class. [01:03:30] * yuvipanda: Moved cache.js to app.js [01:03:30] * yuvipanda: Moved all instances of currentLocale into app [01:03:31] * yuvipanda: Clarified documentation [01:04:12] philinje: can you test the current nightly? should fix https://bugzilla.wikimedia.org/show_bug.cgi?id=33289 [01:04:41] and also shouldn't regress on https://bugzilla.wikimedia.org/show_bug.cgi?id=32907 [01:05:10] and fixes https://bugzilla.wikimedia.org/show_bug.cgi?id=32005 [01:06:14] Eh [01:06:26] Wikipedia app just opened on "Execution by firing squad" [01:07:56] that's.. interesting [01:08:08] Reedy: english? Today's FA isn't that... [01:08:17] Yup [01:08:22] that's what i'm just wondering [01:08:43] Reedy: nightly? [01:08:46] Reedy: kill restart? [01:09:03] built from git [01:09:04] just doing that [01:09:14] It's done it again [01:09:15] ... [01:09:28] I went to wikipedia home page [01:09:31] home button to close app [01:09:34] killed via task manager [01:09:36] restarted [01:10:25] Also, why doesn't the app have a specific inbuilt exit function? [01:10:45] Reedy: well, you were viewing that article last time you quit ;) [01:10:56] Reedy: android apps don't have that usually [01:10:56] I wasn't [01:11:09] Reedy: check history? [01:11:11] The back arrow usually does enough for that [01:11:19] but back just goes back a page [01:12:36] Can I not wipe my history? [01:13:49] Reedy: reinstall is the only option... [01:13:52] for now [01:13:56] Pfft [01:13:57] [01:15:21] https://www.strongspace.com/reedy/public/20120105011321.png [01:16:52] that's a lot of executions [01:17:05] kerboom [01:17:31] clearing app data seems to have done it, it's just taking an age to start [01:18:35] yuvipanda: another late one for you! [01:18:48] i have the build and will test it on the way home [01:18:55] philinje: sure :) [01:19:01] it's what, only 7 AM :) [01:19:10] When I click on the 'x' button in "Saved pages" and delete a page, it doesn't disappear right away. I have to re-enter "Saved pages". [01:19:10] jeez [01:19:30] Rancher: you mean that the list of saved pages doesn't go away? [01:19:37] Rancher: or the deleted item doesn't go away? [01:19:42] Item. [01:19:42] yuvipanda: i guess this is the true meaning of "night shift" [01:20:12] philinje: :D [01:20:20] philinje: possibly. [01:20:35] philinje: and if I'm coming to San Francisco, this would definitely beat jet lag :P [01:21:57] Does the same thing happens to you, yuvipanda? [01:22:35] Rancher: checking [01:22:57] hahaha, I just hit 'save page' on 'India' article [01:23:04] the app told me 'India saved' [01:23:18] okay, this joke isn't funny if nobody here watches cricket, so nevermind [01:23:19] Hahaha. :D :D [01:23:25] lol [01:25:05] oo, i seem to have broken something [01:25:59] You mean the app won't load? [01:26:31] philinje, i think this one: https://bugzilla.wikimedia.org/show_bug.cgi?id=32319 [01:27:41] 01-05 01:27:19.530: W/KeyCharacterMap(9461): Error loading keycharmap file '/system/usr/keychars/synaptics-rmi-touchscreen.kcm.bin'. hw.keyboards.65537.devname='synaptics-rmi-touchscreen' [01:27:43] About "About" menu item, will you create about dialog or leave it as it is? (and about... : S :D) [01:27:59] Reedy: no, i seem to have broken saved pages. [01:28:15] Doesn't seem to want to load site settings etc [01:28:19] just sitting there with null menus [01:28:54] okay now that too [01:29:01] haha [01:30:24] I'm asking this because of translation. [01:31:22] i'm +1 on making it 'about app' rather than 'about wikipedia' [01:31:47] have about wikipedia link on about app [01:31:51] That's the spirit! :) [01:32:05] I heard you like about pages [01:32:10] So I put an about page on your about page... [01:32:18] :D [01:33:17] in what I call 'interesting', I seem to have hit something related to either js scoping issue or js when-is-a-definition-ready-to-use issue [01:33:34] yuvipanda: what's the issue? [01:34:24] preilly: https://github.com/wikimedia/WikipediaMobile/blob/master/assets/www/js/app.js#L118 [01:34:27] says url is undefined [01:34:32] only one place calls it ever [01:34:46] that's https://github.com/wikimedia/WikipediaMobile/blob/master/assets/www/js/app.js#L98 [01:34:49] and url is being passed in [01:35:12] So, what happened with item disappearing? :) [01:35:33] Rancher: that is there too. can you file a bug? [01:35:44] yuvipanda: what if you console.log it? [01:35:46] OK. [01:37:00] oh uh [01:37:04] damn my assumptions [01:37:08] preilly: url is 'undefined' [01:37:09] :) [01:38:07] yuvipanda: what if you console.log around this line: html = app.rewriteHtmlLightweight(data, url); [01:38:17] preilly: that's what I did [01:38:53] how does hideAndLoad: function(url) … have an undefined url? [01:39:21] yuvipanda: wait a minute [01:39:22] preilly: fixed it. [01:39:27] yuvipanda: that is in a callback [01:39:30] preilly: async issue. [01:40:00] preilly: yes, the callback in main was calling it before it knew the URL [01:40:04] whee [01:41:41] indeed [01:46:26] anybody heading out to http://www.meetup.com/BayAreaOpenSource/ tonight ? [01:47:00] okay, saved pages is still broken but atleast the app works [01:47:48] yuvipanda, anything needing a pull? [01:49:43] brion: preilly --^ [01:50:01] not me [01:50:51] brion: yes, pushing. [01:50:57] maybe [01:51:58] brion: pull req sent [01:53:16] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/5t4Alg [01:53:16] [WikipediaMobile/master] Fix initial app loading - YuviPanda [01:53:16] [WikipediaMobile/master] Merge pull request #94 from yuvipanda/fix-initialization - Brion Vibber [01:53:28] Project WikipediaMobile - Nightly builds build #50: SUCCESS in 6.4 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/50/ [01:53:29] yuvipanda: Fix initial app loading [01:53:39] poor phil with a broken build [01:53:43] atleast that rhymes [01:53:44] sortof [01:55:43] Bug reported: https://bugzilla.wikimedia.org/show_bug.cgi?id=33532 [01:57:12] ooh, looks like that has been broken for a while now :D [01:57:49] Already reported or...? [01:59:18] Rancher: no, saved pages had search bar on as ewll. [02:00:39] wait. we added a search bar to saved pages ? [02:01:00] tfinc: regression of 'two search bars' bug [02:01:03] in only saved pages. [02:01:19] i think it has been there for a while, since I don't see anything i've changed that could affect it [02:01:48] though I still don't understand why it even comes down, considering we're passing the proper header [02:01:58] i think we're missing a hideMobileLinks call [02:02:07] i'm fairly sure that header just don't work :P [02:03:05] brion: yes, we're mostly missing that. so am figuring out proper place to put that [02:03:34] One more thing. When I click on the search bar and type something, it doesn't show up there. It starts to show after I enter the second word. :S [02:03:54] Rancher: what language? [02:04:12] Rancher, consistently when you hit space? or is it just a delay? [02:04:19] Reedy: marking your stuff as dupes ;) [02:04:21] Yeah, when I hit space. [02:04:30] Pffft :p [02:04:34] curious. have not seen that before... [02:05:05] Maybe because of the unofficial keyboard layout I use. Who knows. [02:05:15] possible [02:05:30] It's called Serbian keyboard and it is available on Market. [02:05:44] I'll try with Samsung keyboard and Swype. [02:05:46] preilly: can we resolve this https://bugzilla.wikimedia.org/show_bug.cgi?id=33492 ? [02:06:53] tfinc: I believe so [02:07:54] Rancher, with 'serbian keyboard' i see your waits-until-space behaviro when typing cyrillic, but not when typing latin [02:07:55] weird :) [02:08:27] tfinc: Mid-air collision detected! [02:08:35] :) [02:08:41] Um, I was typing Latin. :S Anyway, I just tried Samsung keyboard and Swype and it works just fine. [02:08:56] Rancher, it may be something with typing non-ascii characters that have to be inserted differently, it may not be firing the key event we expect [02:09:21] But I was typing clear English, ASCII. [02:09:48] weird [02:10:04] i get the same behavior typing ascii vs non-ascii chars with the stock android keyboard [02:10:10] ascii == searches immediately [02:10:11] or it might be something with non-standard keyboards? [02:10:18] ah nevermind [02:10:18] non-ascii == doesn't search until i type another ascii char [02:11:21] ok i gotta run [02:11:25] Yeah, I have to click on Space before typing. I'll need to memorize that. :D [02:11:41] we'll see if we can resolve that, but it'll depend on what events we get :D [02:11:43] gah naming. why is the function that actually starts the search process named 'checkLength'? [02:11:45] * yuvipanda sighs [02:12:09] yuvipanda, i think they distribute a lot of crack cocaine at nitobi, they made some .... weird function name decisions ;) [02:12:16] ok laters all [02:12:18] I could see that :) [02:12:33] :D [02:13:13] Dumb question: Where's the list of all reported bugs on BugZilla? [02:13:31] all bugs for the launch of the android app ? [02:13:45] Concerning WikipediaMobile. [02:13:53] In general. [02:14:05] https://bugzilla.wikimedia.org/buglist.cgi?query_format=advanced&list_id=74837&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=android&resolution=---&resolution=LATER&resolution=DUPLICATE&product=Wikimedia%20Mobile [02:14:21] Rancher: --^ [02:14:31] Where did you find it? :D [02:14:44] i went here https://bugzilla.wikimedia.org/query.cgi?format=advanced [02:14:46] okay, am off. too late/early. 8AM [02:14:48] and selected them [02:14:51] seeya yuvipanda [02:14:52] tfinc: gnite :) [02:15:16] Good night. [02:15:39] Advanced search. I should of know it. >_> :P [02:19:47] What does Forward button in app do? :S [02:20:08] For me, it doesn't do a thing. [02:22:14] if you hit back on the app to see a previous page then it'll let you go to you original page [02:23:45] Oh, right. >.< [02:24:01] preilly: what do you want me to highlight at the metrics meeting ? [02:26:36] tfinc: zero and android [02:29:16] tfinc: and maybe iOS fixes [02:29:32] what zero links do we have to share? [02:29:42] i have the ones from our tues meeting [02:29:44] tfinc: we could show the landing page [02:29:54] tfinc: yeah, just those for now [02:29:59] k [02:30:05] tfinc: demo the images part too I suppose [02:39:42] How to delete application history? [02:56:02] See you. [07:55:04] i want a wikinews mobile app [17:40:18] yehhhah [17:47:28] yuvipanda: hi, did you get my email? [17:47:45] no, let me check. [17:48:50] philinje: heh, yeah. we fixed that about 5 minutes after you left [17:49:12] want to send a new build? [17:49:25] philinje: check the nightly? [17:49:27] in !topic [17:50:01] is it called Wikipedia_latest? [17:51:47] Wikipedia_latest points to the latest build [17:51:59] or use the date / sha1 one if you want to make sure which one you grab [17:52:18] thanks, what I meant was: is "latest" the one with the fix? [17:52:40] MaxSem: hi Max, you there? [17:52:47] philinje: should be. [17:52:48] hi, yes [17:53:04] could you re-send the public link to test the RSS feed? [17:53:14] http://mobile-feeds.wmflabs.org/w/index.php/Main_Page [17:57:24] MaxSem: thanks, looks good. How flexible is this function? Can we change which content appears easily? [17:58:04] yes, wiki's sysops can adjust the feeds themselves [17:59:01] what if we wanted "In the news" or any other article, can we create a new feed easily (internally)? [17:59:31] yes, we have a lot of presets already at http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/FeaturedFeeds/FeaturedFeedsWMF.php?view=markup [18:00:05] fantastic, thanks [18:00:25] though not In the news, because it relies on rotating URLs [18:00:29] today we have our monthly metrics meeting - do you guys know how to dial in on Webex? [18:00:47] * MaxSem googles webex [18:02:08] screensharing conferencey software [18:02:17] philinje, it's usually a weblink username/password [18:02:19] philinje, if a site wants a dynamic, changeable at any moment feed like news, they should use something like stuff used by WikiNews [18:02:39] * MaxSem doesn't have a webcam anyway [18:03:07] It's usually to see what's on the presenters machine [18:03:10] no webcam needed, you can listen to audio and see what is being presented [18:03:23] I've never attempted to join it remotely, just when in the office [18:03:42] but we have presets for FA, picture of the day, media of the day, ont this day, DYK, quote of the day [18:03:47] anyway, it's optional, the main news is the monthly report card, which is available online [18:04:05] MaxSem: awesome [18:06:32] MaxSem: sorry, dumb question but how do I subscribe to the feed? [18:07:43] the feed gets published in page , just like 'il good RC feed link. then everything depends on client - for example, in Opera there's a feed icon in address bar [18:09:09] hmm, don't see anything like that in FF or IE. lame [18:09:28] not in Safari either [18:09:37] i think we need a subscribe link [18:09:56] IE in vector sidebar... doable [18:10:30] s/IE/i.e./ [18:10:36] hahah :) [18:12:34] maybe alongside OMG I'M a FA FEED (let's change that to View Feed or something like that) [18:12:45] philinje: it's a wiki [18:12:56] philinje: you can change it... [18:13:39] right, thanks [18:14:11] ok, will share this with Global Dev folks, unless Tomasz has done that already [18:15:34] * MaxSem is open to ideas where to put it, exactly [18:16:05] sidebar could be too narrow for link descriptions [18:16:16] I vote footer towards the right side [18:16:25] with a atom feed icon [18:16:36] Content is available under Creative Commons Attribution Share Alike. [18:16:44] near it^^? [18:16:57] preilly, there could be several feeds [18:17:29] MaxSem: I would put them below the icons [18:17:44] sounds good [18:17:52] anything up with mobile-feeds.wmflabs .. its hanging for me ? [18:18:06] at least enwiki publishes 3 types of daily content suitable for FeaturedFeeds [18:18:25] tfinc: hangs for me too [18:18:38] tfinc: now it finally loaded [18:18:40] and its up [18:21:26] MaxSem: maybe above the icons is better, stacking the number of feeds? [18:21:38] we have to run to the metrics meeting shortly [18:22:17] can we poke Brandon regarding this? [18:25:32] MaxSem: probably wouldn't hurt [18:27:28] ok [18:30:21] see you guys later, today might be a bad one for communicating :( [18:34:40] Reedy: do you know the conference link and login? [18:39:53] https://wikimedia.webex.com/wikimedia/j.php?ED=167663872&UID=1237429112&RT=MiM0 [18:39:58] Nope [18:47:28] MaxSem: i briefly talked with amit about the rss feeds [18:47:51] he'd love to test featured articles alongside the other common main page content [18:48:01] lets add a couple more of them [18:48:17] like in the news, did you know, etc [18:48:36] MaxSem: any difficulty adding that ? [18:48:59] tfinc: philinje do we have a 'mobile roadmap' somewhere? people at #wikimedia-in are wondering... [18:49:29] ITN and DYK aren't supported in their enwiki incarnations. we can do on this day and featured picture [18:49:49] brion: the js fix is pushed for last section [18:49:50] https://www.mediawiki.org/wiki/Roadmap [18:49:59] http://meta.wikimedia.org/wiki/Mobile_Projects/roadmap [18:50:02] yuvipanda: --^ [18:50:13] thanks [18:50:19] yuvipanda: think of my link as the more detailed version [18:50:26] with lots of extra justification [18:52:38] thx preilly [18:56:23] MaxSem: what would en wiki have to do in order to support it ? [18:56:53] * tfinc wonders when hexmode will make up his mind about a nick [18:57:20] tfinc: sorry ... nickserv needs a longer timeout [18:57:23] they're just single pages that get updated manually [18:58:22] unlike e.g. FA where we can assume that there's [[Wikipedia:Today's featured article/]] [18:58:43] our feeds system uses URLs as unique IDs [18:59:35] and we just parse page corresponding to day's entry [19:04:42] yuvipanda: mobile roadmap is here: [19:05:03] http://meta.wikimedia.org/wiki/Mobile_Projects/roadmap [19:05:41] yuvipanda: this build looks great, nice job [19:06:35] philinje: :) something broke in saved pages, am fixing it while simultaneously moving things around. [19:06:44] i buzzed through all the language options and it seems everything is good [19:07:06] yes, i saw a bug where after a page is saved and going to a new page, "Save page" is still grayed out [19:07:39] philinje: yes, a few things are broken there. I'm on it [19:07:44] Tomasz just introduced Max and Yuvi to the group [19:08:17] philinje: I don't think whatever i did y'day broke it. Am sure it was broken from before. [19:10:11] i'm doing some experiments with loading things into a div instead of an iframe [19:10:18] good: seems to resolve the click-through issues [19:10:44] :D [19:10:56] yuvipanda: sure, it's possible [19:10:59] theoretical good: could use something like iscroll (http://cubiq.org/iscroll-4) to keep our toolbar at top and do scrolling differently [19:11:01] brion: wheeeeee! [19:11:03] good: seems to work on ICS [19:11:17] excellent [19:11:19] bad: we lose the automatic behavior of the styles & scripts [19:11:32] can possibly get it to import the styles [19:11:40] brion: inside
? [19:11:42] not sure what to do about script for the show/hide sections [19:11:54] yuvipanda, extracting bits from currently [19:12:03] and using a global to set to the original URL to fixup relative links [19:12:04] hmm [19:12:22] in theory a whole would not be legal [19:12:45] and would at least not quite work i think in terms of things like separation of styles and [19:24:10] jorm: brion : how goes testing WikipediaMobile iOS RC2 ? [19:25:12] haven't had a chance to do anything with it. [19:25:28] it's kind of weird, syncing phones to computers now. [19:25:47] i hate the apple store requirement on that [19:25:51] its ass backwards [19:26:26] philinje: check your gtalk pm [19:28:04] tfinc, i'll have to get my uuid i guess... ipod still at home i think [19:28:17] lame ... [19:28:52] he is down a screen [19:29:12] https://github.com/brion/Wikipedia/commits/refactor-iframe <- my work in progress on iframe->div conversion [19:29:29] brion: do we have an apk with it? i'll build one if we don't [19:30:12] it ain't quite pretty yet :) [19:30:14] but go ahead and try it out [19:30:21] note: saved pages won't work properly yet [19:30:28] and sections don't collapse and the styles are wrong [19:30:42] so, just small stuff [19:30:46] ;) [19:30:55] haha [19:31:07] so be wary of the make it explode button [19:31:24] that's a feature [19:31:37] we'll need a universal icon for that [19:31:44] jorm can build that [19:31:52] :) [19:32:02] heh. [19:32:07] so, i *have* built that. [19:32:11] he can make it go [19:32:22] in nexus war, one of the character types was this kind of demon. [19:32:36] and they had this power that *literally* was "run up to people and explode" [19:32:45] nice [19:32:53] it was a character death (no big deal, you just respawn) but it caused all sorts of AOE damage. [19:33:00] and the button to activate it was "Explode" [19:33:23] nerd++ [19:33:25] people used to bitch about accidentally clicking it and always wanted it moved and things. [19:33:45] but i liked the idea of these demons getting over excited and then accidentally blowing themselves up. [19:33:56] tfinc, just realised that I need to implement another, slightly different workflow, fixing [19:34:07] MaxSem: for what? RSS or GPS ? [19:34:08] so for april fool's day one year i reworked the interface so that the "Explode" button took up almost half the screen. [19:34:20] RSS [19:34:53] some featured content uses templates that look ugly if rendered w/o transclusio n [19:36:23] jorm++ [19:37:59] the power's name, by the way, was "Explosive Murder" [19:45:13] yuvipanda: do you have access to our mobile testing service? [19:45:20] perfecto mobile [19:45:30] i want us to start seeing if it'll help us with testing [19:45:42] brion: let me know if you want access to [19:45:43] o [19:46:15] tfinc: no, not yet. [19:46:38] let me forward you the username/pass [19:46:59] yuvipanda: is phone language supposed to change Wikipedia language? [19:47:15] philinje: only if you haven't changed the language yourself. [19:47:40] you separated phone and app language settings, right? [19:47:45] philinje: yes [19:47:54] philinje: but content language defaults to phone language [19:47:54] what do you mean by haven't changed language yourself? [19:48:11] ok section toggles working, styles a little better in refactor-iframe branch [19:49:28] preilly: how many hours did we get with perfecto ? [19:49:29] 30 ? [19:51:08] philinje: you didn't go to app's settings and changed the content language [19:52:39] yuvipanda: brion i forwarded you the info for perfecto [19:52:49] log in and play with the devices [19:52:51] tfinc: got it [19:53:16] i think we have 30hrs total and they bill in minute by minute increments [19:56:47] tx [20:04:08] tfinc: yes, 30 hours [20:04:12] thank philinje [20:04:41] my code is going live on the cluster. wheee! [20:04:41] that can be increased, of course - we need to see what we really need [20:05:18] yuvipanda: how do you detect whether someone changed the app language? is it when it is different from the phone language? [20:05:42] philinje: app language is: menu -> settings -> change language [20:05:55] philinje: phone language is: android settings -> locale change -> change [20:06:20] yes, i know, how do you detect that I changed the app language vs the phone language> [20:06:26] ? [20:07:58] philinje: well [20:08:10] philinje: by default app language is not set. [20:08:15] so if it isn't set, it defaults to phone language [20:08:29] btw, app language is the wrong phrase [20:08:33] 'content language' is the right one [20:08:35] so [20:08:39] by default, content language is not set [20:08:46] and when it isn't set, it defaults to phone language [20:09:02] when you set it from settings, it 'sticks' to that value, and doesn't change across phone language changes [20:09:36] how does someone "clear" the stickiness? that's really what I'm asking [20:09:40] ah [20:09:43] philinje: currently, no way. [20:11:58] maybe we need a simple check between phone and content languages? [20:12:44] philinje: why would someone do that? I'm trying to understand the usecase here. [20:12:53] don't people usually just set the language once and never bother about it? [20:13:58] not sure [20:14:20] we need more feedback from Amir and co [20:14:50] i'm just wondering about how we deal with three different language factors: phone, keyboard and content [20:15:09] keyboard - we don't deal with at all! [20:15:12] it's complex and will likely be different across platforms [20:15:24] phone is *always* used for UI [20:15:32] and by 'default' used for content, unless the user changes it [20:15:47] ok sorry, back soon [20:27:56] 30 [20:50:18] hi, back now [20:55:20] yuvipanda: just wondering if we need a convention for adjusting content language - maybe it should always follow phone language [20:55:47] philinje: well, android phones have notoriously few language options available [20:56:16] two situations I wonder about are: 1. iPhone uses a different convention - based on keyboard (I think) [20:57:15] and 2. we may want to include a feature for setting app language inside the app [20:57:40] but maybe 2 is really about making change language cover both app UI and content [20:57:41] philinje: by 'app' language you mean 'content' language? [20:58:00] no, app language is the app UI, content is the Wikipedia version [20:58:13] ah, okay. [20:58:22] philinje: brion was mentioning exactly this a few days back :P [20:58:46] yes, and someone else was chiming in, maybe Rancher [20:59:00] i think i made that bug part of 1.1 [21:00:03] it's cool that our app would support more languages than the phone itself, though one has to wonder how important that is [21:00:27] Yeah, I talked about that too. [21:02:07] philinje: true, and for something that's a one-time op, am not sure how prominent we should make it [21:11:03] it may not be a one-time op, depends [21:11:56] philinje: like how? [21:12:43] i am not a bilingual user, so I am a bad person to ask [21:12:51] heh [21:12:55] but 70% of Wikipedia readers are bilingual [21:13:14] that is why there was such a strong demand for the inter-wiki links [21:14:55] philinje: interwiki -> 'read in' [21:15:12] yes [21:17:04] anyway, if we have to change the "default language" behavior, I hope its not a big deal [21:17:27] we are trying to decide about several issues right now: [21:17:53] search bar position and focus [21:18:05] philinje: no it isn't now, after the refactor. [21:18:30] tomasz doesn't want to give up on position fixed [21:18:52] what refactor are you thinking of? [21:18:56] philinje: that problem would go away if brion's 'div' works [21:19:05] philinje: 'that' -> language difference, not position [21:19:20] philinje: brion is doing a move inside 'divs' that should hopefulyl fix the focus and search issues [21:19:30] yes [21:20:33] by refactor do you mean your big project of re-writing the whole app? [21:21:21] no no [21:21:24] not happening :) [21:21:31] philinje: don't worry we won't do that :) [21:21:46] philinje: yesterday moved out the settings handling code from various places into one location. refactors like *that* [21:21:54] i see [21:39:24] ok iscroll looks nice, but runs pretty slow on android 2.x [21:39:36] on android, its pinch-to-zoom feature works -- very cool@ [21:39:49] can live without it for now though; divs with whole-window scrolling work ok for now [21:43:41] brion: !!! had a good lunch? :D Would you mind reviewing my pull request in github? [21:43:56] https://github.com/wikimedia/WikipediaMobile/pull/92 [21:44:06] would let jenkins override the version.name in the android app [21:45:48] brion: it's erroring out for me with a error in zepto [21:46:03] file:///android_asset/www/js/zepto.min.js: Line 4 : TypeError: Result of expression 'a.querySelectorAll' [undefined] is not a function. [21:53:05] yuvipanda, where's that happening? [21:53:14] brion: on startup [21:53:29] not able to figure a traceback... [21:53:35] *figure out [21:53:43] weird [21:54:09] preilly, it looks like for the mobile app we're migrating from using an iframe to importing things into a
[21:54:37] it'll be easier if we can separate the styles between 'application styles' and 'content styles' so we can load the real live content stylesheet without affecting the app's own body, header, etc [21:54:55] would that be straightforward to do or funky? [21:55:09] nope, same thing even after reinstalling [21:56:30] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/AHiuEw [21:56:30] [WikipediaMobile/master] Merge pull request #92 from hashar/jenkins-version - Brion Vibber [21:56:45] Project WikipediaMobile - Nightly builds build #51: SUCCESS in 8 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/51/ [21:56:46] hashar: let jenkins override version name [21:56:51] \o/ [21:56:59] * hashar go grabs his phone [21:57:54] brion: you aren't getting zepto.js issues? [21:58:16] not that i'm noticing anyway [21:58:38] brion: also, en.m.wikipedia.org comes with jquery. [21:58:42] what are we doing to those? [21:58:53] removing the jquery and letting the code in m. use zepto? [21:59:14] or just load both zepto and jquery and watch them fight to death over $? [22:00:36] android get a screenshot [22:00:46] grr that was for google [22:00:52] yuvipanda, we're not importing any scripts [22:01:03] see my 'div' branch for latest [22:01:13] aha, i was still in your iframe-refactor branch [22:02:00] hmm, that's still only one extra commit. [22:02:02] * yuvipanda runs it anyway [22:02:26] hashar, 3rd party app in most cases [22:02:30] brion: still there [22:02:41] No Root Screenshot it works quite well [22:02:41] brion: nothing loads. zepto errors out [22:02:55] null null null [22:03:04] Reedy: looks like :D [22:03:21] hashar, else IIRC ICS has it inbuilt [22:03:47] ICS? [22:03:59] I have a samsung something with cyanogen mod [22:04:08] ice cream sandwhich [22:04:09] 4 [22:04:13] mind you I am a total noob when it comes to mobile devices [22:06:43] Reedy: it is in the general phone menu, next to "plane mode", "restart", "shutdown" [22:08:49] brion: uh oh. [22:08:50] works on 2.3 [22:08:51] not on 2.2 [22:09:56] ! [22:10:11] yuvipanda, can you track down which bit is failing? [22:10:16] brion: yes, doing that now [22:10:24] wheeee [22:10:57] brion: also dont forget that you can spin up 2.2.x devices on perfecto [22:12:18] o_O [22:12:23] O_o [22:12:29] it works now? :| [22:12:36] i just reproduced it both on my device *and* a 2.2 emulator [22:12:43] back on device and it works [22:15:58] jorm: any luck with the iOS app ? [22:16:15] haven't had a chance, mate. [22:16:19] i'm buried to my eyeballs. [22:17:54] k, i'm going to mail some more of the volunteers on our list [22:17:56] thanks [22:18:18] alolita: its reasons like this why we needed dedicated qa :) [22:18:35] yup:-) [22:18:54] yuvipanda: brion: preilly: philinje : i'm going to draft an rfp for mobile qa. this is getting ridiculous [22:19:27] tfinc: probably a good idea [22:19:31] brion: okay, am no longer able to reproduce it. Seems to have 'fixed itself' someway. [22:19:34] tfinc: nice :) [22:19:59] ok got saved pages to work on 'div' branch [22:21:22] can we merge it into mainline then? [22:21:32] because i smell an RC4 then [22:21:45] and i really do want RC4 to be out last RC [22:21:45] still some regressions [22:21:52] error pages stopped working [22:24:39] and font size needs reimplementation [22:26:59] ok, i shared a quick first draft of it. please add on as needed [22:29:04] ok error pages mostly working [22:29:18] they have text at least ;) [22:29:28] now to poke the font size... [22:30:04] brion: thanks for the merge :) the jenkins build date and # is now showing in the app :D [22:30:26] I just can't send the screenshot out of my phone :D [22:31:44] hrm [22:31:53] did we remove the font size settings from the settings dialog? [22:31:58] brion: no [22:32:00] i dont' see them anymore [22:32:04] just 'language' [22:34:04] i don't even get settings up. [22:34:09] and my search bar just disappeared? [22:35:27] still can't see settings... [22:36:23] ok looks like a regression in hashar's thingy :( [22:36:38] :-(( [22:37:10] I have quickly tested a version of it I manually build [22:38:23] I can change settings [22:38:23] specially the font size [22:38:49] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/u4vWgA [22:38:49] [WikipediaMobile/master] fix regression: missing version, fontsize in settings - Brion Vibber [22:38:54] with build #51 [22:39:01] Project WikipediaMobile - Nightly builds build #52: SUCCESS in 6.1 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/52/ [22:39:02] brion: fix regression: missing version, fontsize in settings [22:41:04] so both of you can't see the language / font size in settings? [22:41:26] well i can now that i reverted that merge [22:41:48] I have #51 installed and can change language and font size! [22:42:00] dunno dude. it fails for me on two separate machines [22:42:09] ok, font size setting working now on my div branch [22:42:13] any other problems with it? [22:42:17] (div branch) [22:42:20] before i go merging things [22:44:31] * yuvipanda checks [22:47:21] my setting menu (in french): http://imgur.com/qac2q [22:48:21] hashar, all i saw was the language, neither of the others [22:48:32] note also i was building from eclipse, not from 'ant' commandline [22:48:54] brion: should that make a difference? [22:48:58] have you tried the apk from jenkins ? [22:49:05] shouldn't, but dunno [22:49:06] nope [22:50:06] maybe Eclipse does not update the AndroidManifest.xml to add android:versionName [22:50:20] then in the settings menu, that could trigger an exception/ error that just break the whole menu :D [22:52:12] perhaps [22:53:31] brion: style issues aside, only issue i see is the disabling of 'save page' not happening if current page is already saved [22:53:43] hmmm [22:54:12] where is/was that done? [22:55:09] ok i see a bit in navigateToPage... [22:55:17] that shouldn't be any different as far as i can see [22:55:53] yuvipanda, works for me [22:56:22] hmm, my 'save page' is enabled and I get the dialog box saying 'already saved' [22:59:42] yuvipanda, could it be old pages from before https switch? [23:00:00] brion: doubt it. I did a uninstall/install [23:00:07] brion: and I just did that again and it works. [23:00:22] weeeeeeeeeird [23:00:27] i wonder if some sort of 'ghosting' is happening with apk's being retained .. [23:00:32] this is like the *third* time this has happened today [23:00:38] an error going away by deploying the *same* code [23:00:46] possibly there's a race condition with the code that updates the menu status [23:00:48] did a git pull brion div and got nothing [23:01:14] brion: are you fixing the style issues before merging? [23:02:47] i'm adding some padding [23:02:52] other than that, what issues do you see? [23:03:16] brion: the search suggestions are too small [23:03:19] smaller than they were [23:04:22] not sure offhand which bit might be affecting that [23:08:34] aha [23:12:49] ok got that [23:12:54] :D [23:13:22] last chance to object before i merge this branch [23:13:29] cause tomasz wants it yesterday :) [23:14:53] brion: testing [23:15:56] brion: footer too big :P [23:17:05] [23:17:40] think i can get that one [23:19:58] done [23:22:07] brion: merge, sir! [23:28:05] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/65q_mQ [23:28:05] [WikipediaMobile/master] Merge pull request #95 from brion/refactor-iframe - Brion Vibber [23:28:08] boom. merged! [23:28:18] Project WikipediaMobile - Nightly builds build #53: SUCCESS in 6.7 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/53/ [23:28:19] * brion: Consolidate a few bits that directly manipulate the iframe into 'app' [23:28:19] * brion: First pass at dropping the iframe; loading text by parsing in an innerHTML and extracting parts of it. [23:28:20] * brion: fix for frontpage [23:28:20] * brion: drop the honeycomb iframe size workaround: not needed with iframe gone [23:28:21] * brion: fix for #hashlinks -- they were loading the raw pages due to the tag, breaking the app [23:28:21] * brion: fix for links containing spans: we got the wrong click target in handler [23:28:22] * brion: drop some unneeded handlers for the iframe clickthrough workaround [23:28:22] * brion: add some JS/css from the mobile view: fixes section toggles, some layout [23:28:23] * brion: de-conflict some styles [23:28:23] * brion: abstract out stopping the current load, maybe make it sorta work (from search) [23:28:24] * brion: z-index fix for content with floating things (eg the mini table on Arsenic) [23:28:24] * brion: drop some bogus phonegap js loads -- replaced by platform-stub.js [23:28:25] * brion: use iscroll4! [23:28:25] * brion: enable pinch-to-zoom in iscroll; seems to work on ICS but not on 2.x [23:34:49] [2012-01-05 23:34:32 - Wikipedia] Installation error: INSTALL_FAILED_INSUFFICIENT_STORAGE [23:34:49] [2012-01-05 23:34:32 - Wikipedia] Please check logcat output for more details. [23:34:53] Bad eclipse [23:35:00] :P [23:35:05] ant debug install [23:35:06] :D [23:35:28] Amusingly the app still started on my phone [23:36:32] brion: btw, why is there an empty 'enableCaching' function there? [23:36:43] ah, it's overridden [23:41:05] yep [23:41:39] brion: am going to move most of the stuff in main.js into app as methods. [23:41:48] yuvipanda, excellent [23:41:57] brb [23:48:21] there is no greater joy in the world than killing code :) [23:50:49] hehe [23:53:51] brion: adjustFontSize is still doing $("#main")[0].contentDocument? [23:55:13] yuvipanda, i moved it into app.js [23:55:19] might have left an old one by mistake [23:55:21] kill it :D [23:55:24] brion: am looking at it in app.js [23:55:34] there's only one [23:55:41] and it's the 'old' one? [23:55:42] new one just sets a style on #main [23:55:55] ah i left a line [23:55:59] delete that i guess [23:56:16] hm wait what? [23:56:21] nope [23:56:38] brion: perhaps you killed the 'new' one? [23:56:42] but how did it work? o_O [23:57:24] i'm very confused right now [23:57:44] crap [23:57:47] that's the wrong branch [23:57:51] what the hell [23:57:58] grrrrr [23:58:42] :D