[00:21:58] preilly, ok i think 'BeforePageRedirect' hook will work for this as well [00:22:41] could maybe just regex every damn url in there ;) [00:23:18] brion: ha ha [00:40:15] brion: can you look at * /trunk/extensions/MobileFrontend/MobileFrontend.php: fix for Bug 33441 - Random button directing to regular website [00:43:12] lookin [00:44:01] preilly, do we do that sort of url rewriting in other places? might be wise to consolidate [00:44:34] brion: I added parsePageRedirect to consolidate it [00:44:42] brion: can can tweak further as well [00:45:21] anywhere else we produce those links? does this need to be conditional or is the condition already applied? [00:45:53] brion: well, it's only on Randompage and only when xDevice is set [00:46:21] so we can assume that $wgMobileDomain is set and in use [00:46:21] ? [00:46:44] brion: well, if it's blank that's okay too [00:51:47] philinje, got that link handy? [01:01:59] http://ar.m.wikipedia.org/wiki/%D8%A7%D9%84%D8%AF%D9%82%D9%87%D9%84%D9%8A%D8%A9 [01:03:43] that page itself looks okish [01:03:49] the image goes right up to the edge of my screen though :) [01:04:23] if you zoom in on the map it may not scroll properly [01:04:30] but it opens in an external window for me ... weird [01:04:53] in regular browser that image page is fine (since it gets the special css) [01:05:31] there's a template in a later section in the page which is too wide for the screen [01:06:13] just a case where it should be refactored, mainly [01:06:18] but it'd be nice to scroll if/when needed [01:06:25] yes [01:06:35] in the browser does it scroll horizontally? it should. [01:06:56] not my browser, and Moushira said she couldn't scroll in the app [01:07:33] ok more worrying is that on that page in my web browser, the search bar is missing [01:07:38] as is the footer [01:07:45] which may indeed indicate some cache pollution [01:07:55] brion: yeah, I think so [01:07:55] yes, i noticed that too [01:08:27] is that difficult to deal with? [01:09:42] don't know [01:10:20] well, we can make sure that the app isn't sending those headers and then flush the cache [01:10:36] philinje, ok i can't scroll horizontally in the regular web browser either on android 2.3.x, so we're pretty much just 'sorry no horizontal scrolling for RTL' [01:11:05] in theory yeah :D [01:11:35] crap! [01:13:57] i think we should try to fix the scrolling, and decide if we want to delay the release end of day tomorrow [01:14:32] we could do a point release for RTL languages after the main release [01:15:19] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/7aNKdw [01:15:19] [WikipediaMobile/master] Drop 'Application-Version' headers; don't trust em, don't need them for magic rewrites anymore. - Brion Vibber [01:15:32] Project WikipediaMobile - Nightly builds build #72: SUCCESS in 6.5 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/72/ [01:15:32] brion: Drop 'Application-Version' headers; don't trust em, don't need them for magic rewrites anymore. [01:18:42] bug 32123 [01:23:43] tfinc, http://tinyurl.com/73ql8x3 [01:23:47] last section [01:33:22] thanks brion [18:28:41] me waves at Andre_Engels [18:29:07] congratulations! [18:34:20] hey Andre_Engels ! [18:45:20] Hi [18:45:25] Sorry, didn't notice before [18:46:36] * yuvipanda waves at Andre_Engels too [18:47:30] * Andre_Engels smiles [18:51:45] yuvipanda: we had a our go/no meeting yesterday and everything looks pretty set to push to the market tomorrow [18:51:56] i'm just trying to resolve the @wikimedia.org android market issue on my end [18:52:13] tfinc: cool :D [18:52:32] tfinc: so it's going to be live on market tomorrow? [18:52:35] do you have any pending changes that need to go into the release branch ? [18:52:36] yes! [18:52:38] i'm excited [18:52:39] and 'marketing'/'outreach' will come on later? [18:52:43] yes! [18:52:45] nope, nothing :) [18:52:46] let me send you the ether pad [18:52:49] ah yes [18:53:01] http://etherpad.wikimedia.org/WikipediaMobileAndroidRelease [18:53:11] i'll mail that out to the mobile-l@ list later today [18:53:14] so that people know [18:53:16] tfinc: what about the RTL scrolling problem? granted that is on Mobile FE [18:53:46] but the plan is to launch it quietly and see what reviewers say [18:53:57] if things go well then we push to the amazon and fdroid stores next week [18:54:04] and do blog post at the end of next week [18:54:16] philinje: i think brion fixed it? [18:54:26] really, last night? [18:54:37] philinje: we'll have to talk with preilly about possible solutions there. its not an android app issue. [18:54:46] i DO have to fix tr.m today though [18:54:55] didn't get around to it it last night [18:55:03] philinje: yes. 01923397c857d9 [18:55:08] actually .. yuvipanda think you could take care of the for me ? [18:55:09] if your not too busy [18:55:14] tr.m? [18:55:26] yuvipanda: do you have a staff and/or admin wiki account ? [18:55:41] i think so [18:56:02] ok. so if you load http://tr.m.wikipedia.org/ you'll see that the main page is pretty empty [18:56:30] we need to have a better turkish main page as turkish will be one of our partner launch stores. [18:56:44] now the reason it doesn't work is because their main page doesn't have the right id's [18:56:54] wait, i don't have an admin/staff account on *wikipedia*. got it wrong. ugh. [18:57:11] you can easily see how to set them if you read this http://meta.wikimedia.org/wiki/Mobile_Projects/Mobile_Gateway#Mobile_homepage [18:57:24] if you can't do it then i'll take care of it when get into the office [18:57:26] going to commute now [18:57:29] no worries if you cant [18:57:31] tfinc: okay. [18:57:38] yuvipanda: enjoy the quiet time now ;) [18:57:41] tfinc: heh [18:57:43] i'm sure we'll get plenty of feedback on launch [18:57:49] can't edit, no rights [18:58:08] so set time aside over the weekend and next week to just respond to people [18:58:33] i'm purposefully keeping things slow so that we can monitor peoples responses [18:58:57] ok heading in. then i'm talking to rayne as i think i know whats wrong with our @wikimedia.org android account [19:01:59] hey all [19:02:31] yo [19:03:24] hey brion [19:03:48] wah, I'm a weekend away from meeting y'all :O [19:06:40] \o/ [19:08:27] so what will be Andre's task? API usage stats? [19:08:47] MaxSem: philinje can tell you all about it [19:12:40] analytics, in particular for the mobile usage [19:49:24] tfinc: know of your india travel plans? [19:49:34] i'm just looking for dates :) [19:49:37] brion: ^ [19:50:17] whatever the defaults are i think :D [19:50:35] what are the defaults? :P [19:54:23] MaxSem: let me direct you to a page [19:54:44] http://www.mediawiki.org/wiki/Analytics/Pageviews/Mobile#Mobile_Metrics [19:55:06] brion: any pending changes needing to go into the android release branch ? [19:55:56] tfinc: merge master into the release branch. [19:56:03] philinje, whee [19:56:14] tfinc: brion fixed an RTL bug and I fixed another UI issue there. Not sure if they were merged into release branch [19:58:13] how risky are they to merge? [19:58:27] i'd love to cut RC5 for us to test with in the channel [19:58:51] not big changes so i don't' see a need to mail it to everyone to test today [19:59:19] heads up that while i resolved the @wikimedia.org android market issue .. the store is still not letting me finish the registration [19:59:20] tfinc: pretty small, just one issue amir reported and one philinje reported. [19:59:23] philinje, results of my rtl scroll testing: (In reply to comment #13) [19:59:23] > Seeing the scrolling problem in Android app with Arabic pages, possibly all RTL [19:59:23] > languages. Here is an example: [19:59:23] > [19:59:23] > http://ar.m.wikipedia.org/wiki/%D8%A7%D9%84%D8%AF%D9%82%D9%87%D9%84%D9%8A%D8%A9 [19:59:23] (In reply to comment #14) [19:59:25] > Also Android browser on nexus One 2.3.6. [19:59:27] (In reply to comment #15) [19:59:29] > Last section on that page when opened has a better example of the problem. [19:59:31] bbah [19:59:33] that's the wrong paste :) [19:59:36] https://docs.google.com/spreadsheet/ccc?key=0Au4uRHcaarTrdDdMenNCSVVWUXRrakxFajdDWEk5cVE [19:59:43] ^ that's the right one [20:00:50] fun [20:00:55] but this is all in MF right ? [20:01:35] that's a minimal test page [20:01:45] Tested http://leuksman.com/misc/ltr.html and http://leuksman.com/misc/rtl.html [20:01:48] grrr grrr [20:02:06] * MaxSem is insane from return to JS [20:03:01] MaxSem: hit up trevor or teemo with js questions [20:04:18] I've no ungooglable questions. I've lack of their mad skillz [20:04:36] lolz [20:05:16] are you at least using jQuery to make your life easier? [20:05:31] * yuvipanda is young enough in web-dev to not know of the time-before-jquery [20:05:42] wah, even that's been more than 2 years o_O [20:05:49] yuvipanda: back in my day we had to code js by hand! [20:05:52] kids these days ... [20:05:58] spoiled! [20:06:04] ha ha [20:06:08] we didn't even have firebug [20:06:10] the madness! [20:06:28] * preilly read that in an old man's voice  [20:06:47] preilly: always in this voice http://www.youtube.com/watch?v=Xe1a1wHxTyo [20:08:25] ha hah [20:16:20] great! Firebug has just crashed my FF! [20:19:09] enough APISB for today, I'm already here --> http://www.youtube.com/watch?v=-EI33HTBLCg [20:29:05] ha [20:46:08] today is probably gah javascript day. sigh. [20:50:16] when was the last time anyone tried out sharing pages? [20:50:33] tfinc: philinje i've a botched build here, can you guys check if 'share' works for you? [20:50:56] sure in a bit [21:10:57] preilly: btw, even the english wiktionary's mobile site is blank (http://en.m.wiktionary.org/) [21:21:58] Hallo. [21:23:01] Today i managed to make my GPS work. While i was on a train, i entered the map view and saw myself moving. [21:23:19] But i didn't see any article markers on the map. [21:23:30] I tried it in several languages and nothing worked. [21:27:11] aharoni: hello! [21:27:15] were there articles around that place? [21:27:55] what search radius does geonames use? [21:30:18] MaxSem: doesn't seem to be documented (http://www.geonames.org/export/wikipedia-webservice.html) [21:30:48] funny [21:36:33] yuvipanda, it was near the old city of Jerusalem. There are many dozens of places with articles about them there. [21:37:49] ah wait [21:37:56] aharoni: did you hit 'redo search in this area' any time? [21:40:05] yuvipanda, yes, i tried it. [21:40:12] was it a bad mistake? [21:40:51] no, hitting 'redo search in this area' is supposed to put up a spinner till it found something [21:40:54] did it for you? [21:41:02] no. didn't find anything. [21:41:07] or did it just come up, spin for a while, and then go away with no places? [21:41:23] the location on the street was correct, but no article markers were shown. [21:42:14] aharoni: can you whip it out now and try it? [21:46:10] tried it, and no - it still doesn't show anything. [21:48:32] uh oh. [21:48:37] aharoni: menu -> my location [21:48:38] now? [21:48:44] * tfinc wants to seriously make the android market support team [21:48:47] mame* [21:48:49] :) [21:49:21] yuvipanda, i tried it, and no, it still doesn't show anything. [21:49:47] when i'm inside the house, it doesn't show the location; when i go outside, the blue dot appears but itself. [21:49:55] [by itself] [21:58:10] yuvipanda: share seems to work for me, but just noticed the URL starts with HTTPS [21:58:26] philinje: yes, our app is on https, hence... [21:58:33] I thought we decided not to use HTTPS? [21:59:03] also Brion merged in the two changes yesterday, including yours about saved pages [22:01:51] aharoni: when you say the blue dot appears by itself, do you mean the map is showing also or not? [22:01:52] philinje: okay, cool if brion merged it in. [22:02:26] philinje - when i'm in the house, the map is showing without the dot. when i go out, it appears. [22:03:27] weird, works fine for me... [22:06:00] wait .. we agreed on https by default a bit ago [22:06:18] philinje: was there a reason why you wanted not to have it? [22:06:55] yes, that's what I remember too [22:06:57] (https on by default) [22:15:27] what is the reason for not having the usual two-fingers zoom in the Wikipedia app? [22:17:07] aharoni: it broke the search box when we unlocked it [22:26:13] i wonder, we might be able to put that back when we redo the toolbars to only pop up when used [22:26:38] *should* be able to identify the visible scroll region and shrink to fit or something :D [22:26:55] brion: or iscroll? [22:27:02] and turn it on only on 4+? [22:27:04] or else do the iscroll thing... which doesn't do pinch-zoom on android 2.x but does on 3/4 and ios [22:27:07] yeah [22:27:13] 3+ [22:27:23] reminds me, i picked up a 3.x tablet to test with [22:27:32] so i'll probably start on an initial stub tablet interface mode soon [22:27:52] just put the search/history/saved/settings over on a sidebar or something maybe :) [22:30:31] updating it to 3.2 right now... sslloowwllyy unpacking the update :P [22:33:41] brion: are we going to maintain a 'unified' code base across phones, tablets (android and iOS)? [22:34:00] yuvipanda, yep! [22:34:03] cool :) [22:34:10] i've already got it partially working on ios [22:34:23] well, i was talking more along tablet and phone interfaces. [22:34:35] so then we'll just need it to smartly arrange things for small vs larger screens [22:34:36] yep [22:35:35] the platform-specific bits can still override; for instance on android we use the menu while on ios small screen we need a toolbar at bottom of screen; ios large screen (ipad) we'd probably want the buttons on the top toolbar [22:35:49] and android tablet would be some mish-mash :D [22:35:55] :D [22:35:56] cool [22:36:07] i'm objectifying everything now [22:36:11] think i've the awful bits worked out [22:36:22] excellent [22:36:54] brion: i was hoping to get it to a point where we could basically move across form factors with just a modified index.html file [22:37:30] i'm actually more inclined to keep the same index.html and let the CSS and JS do the differences [22:37:50] yuvipanda: do you still need me to test share? [22:37:53] that also means that, say a web app version of it would be able to adjust to different window sizes [22:37:56] brion: ideally we'd need to change *just* css [22:38:00] yeah [22:38:02] tfinc: nah, philinje did [22:38:32] k [22:38:35] brion: i was thinking html + css instead of css + js [22:38:45] brion: assuming the major difference we'd be doing would be layout changes [22:39:09] i think the kind of layout changes we'll need are mostly in positioning and chaning what's visible by default [22:39:20] like positioning some things in a sidebar instead of fullscreen [22:39:43] and it's easier to use a common index.html, though it's not hard to load up a separate one [22:47:05] woah, git's awesome! [22:47:26] it tracked the change where brion dropped the extra http header across a completely different file across two commits [22:47:31] and dropped it [22:47:54] \o/ [22:48:31] brion: so, i shall 'finish' the refactor and then we'll merge it in? [22:48:36] or do we keep merging it in? [22:48:42] shall take a day or so more, I hope [22:49:11] yuvipanda, go ahead and finish in branch, be easier if we need to throw any quick fixes in before release in the next couple days [22:49:18] okay [22:49:31] then we can land the branch and keep working for the next version \o/ [22:49:41] brion: it's here btw, https://github.com/yuvipanda/WikipediaMobile/tree/templating-refactor [22:49:54] in commits not atomic enough for my tastes [22:53:30] so i'm still not in for my @wikimedia.org android market account :( [22:53:40] but i'm going to stage it on my @gmail account [22:54:01] uhoh https://github.com/jdlrobson/WikipediaMobile [22:54:07] preilly: --^ :D [22:54:20] so i'm happy to announce that the mobile team is going to be growing! [22:54:45] we have our first hire for our open front end role [22:55:18] whee [22:55:20] damn [22:56:11] i'll be sending out an intro mail soon but for those that haven't talked to jon yet … here is his backround http://jonrobson.me.uk/ [22:58:08] brion: i'm not touching ios/platform.js during the refactor. will have to go there later. [22:58:10] wah [22:58:13] wheee! [22:59:56] ok [23:00:16] ok .. time to pick out what info we want in our market keystone file [23:00:34] here is what i've been signing with [23:00:35] Owner: CN=Tomasz Finc, OU=Unknown, O=Wikimedia Foundation, L=San Francisco, ST=California, C=US [23:00:44] what do we want the CN and OU to be ? [23:01:10] Wikimedia Foundation Wikimedia Foundation Engineering [23:01:19] Wikimedia Foundation, Mobile ? [23:01:45] yeah, I guess Mobile makes a bit more sense [23:06:57] close to 5 [23:07:01] crashing now. [23:07:03] gnite everyone! [23:48:58] ok back [23:49:11] so .. we like Wikimedia Foundation, Mobile ? [23:49:45] speak up now as we won't be able to change it later [23:52:09] … sold! [23:52:50] ha [23:55:02] preilly: brion : "Is CN=Wikimedia Foundation, OU=Mobile, O=Wikimedia Foundation, L=San Francisco, ST=California, C=US correct? y/n" [23:56:39] y