[00:08:43] yuvipanda: I'm still waiting to test the apk .. hows it working on your device? [00:08:54] lets get brionto test it at the hackathon today tomorrow [00:08:59] i saw we push tomorrow given the craziness today [00:11:17] LIFI! [00:21:28] tfinc: hey. [00:21:30] works fine on mine [00:21:38] am just about done forward porting them to master [00:21:39] nice [00:22:19] tfinc: doing it in a slightly more platform-independent way here in master, unlike the fix where I just realized I was plopping android specific code right into the middle of js [00:30:26] yuvipanda: so what your saying is that no one has reviewed this change that we want to get into the market [00:30:42] all changes should be reviewed [00:31:58] reviewed or tested? [00:32:25] both :D [00:32:27] hmm [00:32:28] ah [00:32:29] :) [00:33:09] tfinc: true. [00:33:22] i'll just let you take care of it then, pestering as much as I could :P [00:34:04] just get preilly or brion to review it [00:37:59] and there he is :) [00:38:01] haha [00:38:05] yuvipanda: --^ [00:38:21] tfinc: he just walked past me :) [00:38:38] [WikipediaMobile] yuvipanda pushed 1 new commit to v1.0.1: http://git.io/u9BshQ [00:38:38] [WikipediaMobile/v1.0.1] Refactored out the cache enable/disable code - YuviPanda [00:38:40] brion: can you review ^ [00:38:54] [00:39:04] lemme look [00:39:27] Amgine: wherever I go there's this constant idea that there are 'brions' [00:39:50] the office fridge, IRC nicks, to name a few [00:40:01] that's because there are. [00:40:13] Project WikipediaMobile - Nightly builds build #103: SUCCESS in 6.7 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/103/ [00:40:14] yuvipanda: Refactored out the cache enable/disable code [00:40:31] the fridge implores us to find a way to get a picture of brions [00:40:59] [00:41:10] ok looks clear enough [00:41:29] tfinc: ^ [00:41:32] :D [00:41:34] hm. yuvipanda, does that disable the bit where we switch the caching modes when going on/offline? [00:41:46] brion: yes [00:41:57] i assume that was being problematic? [00:41:57] brion: we turn it on when navigating and turn it off immediately [00:41:59] yes [00:42:02] ok [00:42:04] sensible then [00:42:15] for some reason the database was completely messed up when in the offline mode [00:42:18] make sure you mention that sort of thing in commit comments :D [00:42:25] interesting... [00:42:31] ah, yes. I left comments in the code though [00:42:40] yeah running it just around the navigation sounds like it should help [00:42:43] hmm not enough [00:42:46] comments [00:43:03] brion: true, though i'm not sure *WHY* caching behavior should even affect what databases we're getting [00:44:04] brion: phonegap sortof replaces the built in webkit-database with its own implementation, and I *think* that is what is causing us problems [00:44:16] could be... [00:44:28] using the webview's sqlite database when offline and phonegap's when online [00:44:30] or vice versa [00:45:01] spent the morning debugging through phonegap.js but couldn't narrow it down [00:45:50] yuvipanda, i'm going to refactor some of the menu stuff out of platform.js so i can use it for android tablets. any areas i should avoid while you're working? [00:46:29] not really, i'm testing forward-porting these fixes to master and then will look at the backlog and figure out what i'm going to be working on next. [00:46:35] so go ahead :) [00:46:40] great :D [00:46:45] oh good, you fixed the gps thing \o/ [00:46:47] awesome [00:47:03] :) [00:47:14] v1.0.1 had gps fix + the cache fix [00:47:36] excellent :D [00:48:31] brion: i'm trying to get tfinc to push that out hopefully tonight to the market [00:53:27] hmm, interesting [00:53:44] our way of overriding functions with platform specific ones doesn't quite work... [00:56:36] hm, how so? [01:01:21] aha, we can't use 'this' at all without some refactoring [01:01:24] using 'app' for now [01:03:41] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/ybAVrw [01:03:41] [WikipediaMobile/master] Enable caching only specifically - YuviPanda [01:05:09] Project WikipediaMobile - Nightly builds build #104: SUCCESS in 7.4 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/104/ [01:05:10] yuvipanda: Enable caching only specifically [01:43:58] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/3xUvhg [01:43:58] [WikipediaMobile/master] fix header close box for 'settings' on tablet view - Brion Vibber [01:45:12] Project WikipediaMobile - Nightly builds build #105: SUCCESS in 6.3 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/105/ [01:45:13] brion: fix header close box for 'settings' on tablet view [02:53:40] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/L0cnGw [02:53:40] [WikipediaMobile/master] Leaflet based maps now respect current language - YuviPanda [02:53:52] Project WikipediaMobile - Nightly builds build #106: SUCCESS in 6.3 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/106/ [02:53:53] yuvipanda: Leaflet based maps now respect current language [07:25:12] yuvipanda: lola .. our app and android itself doesn't surface 1.0.x [07:25:16] lolz [07:25:36] tfinc: doesn't surface as in? [07:25:40] tfinc: i did put it on the about page [07:25:48] also that was one of the commits you missed in your first build [07:26:01] check the about screen [07:26:03] you'll see [07:27:29] wait .. [07:27:30] your right [07:27:44] all better :D [07:27:46] haha [07:27:50] tfinc: :P [07:28:02] too many beers and not he right download ? [07:28:05] lolz [07:28:35] :D [07:28:37] true! [07:28:43] your spelling's taken a hit too :P [07:28:46] however [07:28:47] why did they make android:versionCode an integer and not a floating point ? [07:28:56] tfinc: it's a good idea [07:29:00] do tell [07:29:01] easy way to compare versions [07:29:04] during upgrades and stuff [07:29:20] that's what the docs say and that makes perfect sense to me [07:29:47] to me major.minor.x works just fine and is consistent with versionName [07:29:48] figuring out if 1.0.1-RC1 is greater or lesser than 1.0.1-Beta4 is complicated, but 4 < 6 is always simple [07:30:02] tfinc: well, maybe they could've named it something else [07:30:07] versionSequence perhaps [07:30:10] yeah [07:30:55] considering they picked java of all languages... [07:30:59] i'll let this one pass :) [07:31:12] i'm going to post RC1 on twitter and mobile-l for our testers [07:31:16] no issues so far [07:31:25] i'm fine to push it tomorrow when i'm more awake [07:31:38] :D [07:31:38] okay [07:34:37] 166,142 total installs (users) [07:34:57] the other metric? [07:35:23] we'll know tomorrow. i only have it for the 19th [07:35:32] 113,565 net installs (devices) [07:37:58] yuvipanda: seeing this is pretty awesome https://bugzilla.wikimedia.org/show_bug.cgi?id=31447 [07:38:21] :D [07:38:22] i know! [07:38:34] tfinc: seeing https://bugzilla.wikimedia.org/show_bug.cgi?id=31805 closed would be awesome too [07:39:06] you know that'll just get me thinking about 1.2 right? [07:39:31] in fact .. i'm going to open that right now [07:39:47] 1.2? I was thinking 2.0 [07:39:54] with editing/participatory features [07:39:59] like, a lot of them [07:40:02] we can have both [07:40:18] 1.1 should be a 'feature parity' release [07:40:25] and 1.2 should be a 'tablet' release [07:40:33] i like that! [07:40:45] feature parity -> same codebase as iOS [07:41:38] what i like about having future tracking bugs is that unless you do them .. everything gets piled onto the next releas [07:41:39] e [07:41:45] true! [07:41:47] with 1.2/2.0 .. we can schedule things easily [07:41:54] yes! [07:42:01] first we need to file a few more things that block 1.1 [07:42:52] yuvipanda: so you know my tweet about why we didn't shut down the mobile site? [07:43:03] no, I don't [07:43:28] https://twitter.com/#!/wikimediamobile? [07:43:51] https://twitter.com/#!/WikimediaMobile/status/159520329427988480 [07:44:25] so our normal tweet reach is about 3-4k [07:44:36] i did that one since twitter was exploding with questions [07:44:46] :D [07:44:59] which was good as it reached 354.7k [07:45:11] wah [07:45:12] people [07:45:20] that's something [07:45:23] you heard me .. that tweet went out to 354.7k people [07:45:30] it's still surreal, the amount of people we could reach [07:45:33] if i had know it would hit that many i'd have written it better [07:45:38] but it got the point across [07:45:46] barely scratched the surface [07:45:54] true! [07:46:38] yuvipanda: no what i'd love is to pass @Wikipeida :D [07:46:44] @Wikipedia :D [07:46:52] 50k followers there [07:47:01] :D [07:47:04] we will, we will :) [07:47:24] tfinc: when would you be there tomorrow? [07:47:30] i need to figure out a way to not get lost [07:47:35] i'm getting in @ 9:30 [07:47:44] nice @edent is retweeting us [07:47:49] i want to meet him in person some time [07:48:44] mmm, qrpedia [07:49:21] tfinc: also, I checked - this Nexus S should work in India too! [07:49:48] yuvipanda: then you have your new phone [07:49:55] \o/ [08:18:13] yuvipanda: PNQ -> DEL $83 [08:19:54] Depart 14:35 .. arrive 16:40 [08:19:54] tfinc: don't wait for me on it now, I'll decide hopefully tomorrow after figuring out how much it is going to cost me [08:20:00] k [08:20:17] or 11:35/13:40 [08:20:18] hmm [08:20:29] more time to play in delhi then [08:20:33] and take the train up on tuesday [08:20:36] :D [08:20:42] pre-book the train [08:20:43] or not [08:20:45] that's upto you ;) [08:20:53] if i can .. i'd love to pre book [08:20:56] no more cattle class :D [08:21:30] :D [08:21:35] tfinc: cleartrip.com is what I use [08:21:50] tickets should hopefully be available right now [08:22:46] 3,734.00 INR [08:23:26] tfinc: trains? [08:23:28] *train? [08:23:29] or flight? [08:23:31] flight [08:23:47] i was talking about trains [08:23:49] how long would the train take [08:23:51] you could pre-book train as well [08:23:53] oh wait [08:23:53] pune -> delhi [08:24:21] heh [08:24:23] 27 hours [08:24:24] ;) [08:24:29] screw that [08:24:30] i'm flying [08:24:41] :P [08:24:56] AC first class is 2.7k [08:25:00] so that's like just a 1k difference [08:25:07] might as well fly [08:25:16] aaand it is fully booked ;) [08:25:22] yes! [18:00:48] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/gpIefg [18:00:48] [WikipediaMobile/master] Scrolling fix for sidebar on tablet: set the width! - Brion Vibber [18:00:48] [WikipediaMobile/master] Merge branch 'master' of github.com:wikimedia/WikipediaMobile - Brion Vibber [18:01:02] Project WikipediaMobile - Nightly builds build #107: SUCCESS in 7.7 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/107/ [18:01:03] brion: Scrolling fix for sidebar on tablet: set the width! [18:16:40] awjr: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/GeoData/ [18:41:42] awjr: [19:55:45] awjr: http://en.wiktionary.org/w/api.php?action=query&list=search&srsearch=ellephant&srinfo=suggestion [19:57:09] preilly: Query: is there mobile equivalent of "did you know"? [19:57:23] sorry, did you mean? [19:58:47] amgine: there might be soon, i'm going to take a look at implementing it [19:58:56] for the android app, at least [19:59:40] Cool. It's one of our goals for the Wiktionary team. [20:06:14] amgine: yeah, you should be able to just take what awjr does [20:19:59] awjr: hasSuggestion(), getSuggestionQuery() [20:30:51] They just headed out for lunch, but the API pair have run into an issue: they're getting the pages, but not mw-collapsible/mw-collapsed. How do we get collapsed content to display collapsed? [20:38:45] amgine, by including teh proper JS! [20:41:44] Where is that js located? [21:01:28] Hi. [21:02:42] On the android app: when I use the "nearby" function and then click on a marker, then click again (expecting it to take me to that marker's article) it just leads me back to whatever Wikipedia article I was viewing previously. [21:04:00] (I'm using a tablet running android 3.2) [21:05:51] awjr: you can use "chrome --disable-web-security" to bypass the same-domain restriction and run your phonegap application. [21:07:55] Who is maintaining the mobile skin for m.wiktionary.org? [21:08:09] amgine: it's not a mobile skin [21:08:25] What is it, then? [21:08:37] amgine: it's a mediawiki extension [21:08:54] amgine: that strips content that isn't appropriate for mobile devices [21:09:08] [21:09:12] amgine: as, well as renders the content in a mobile friendly format [21:10:50] amgine: why do you ask about it? [21:11:09] There's some styling ideas the team has for that, which they think could save some screen real estate. [21:11:38] (for the wiktionary app) [21:11:47] amgine: they'd either have to use the API and parse out things, or use Mobile site and do HTML parsing/scraping [21:11:52] that's going to be the most fun part :) [21:11:53] amgine: well, you can provide custom css in the phone gap app [21:12:32] amgine: if they aren't html structural changes [21:12:50] Kk. I think they're mostly styling concepts. [21:15:18] preilly: Should I file a bug report regarding the issue I encountered? (posted about 13 min ago) [21:16:21] juancarlos: what is the issue? [21:16:35] On the android app: when I use the "nearby" function and then click on a marker, then click again (expecting it to take me to that marker's article) it just leads me back to whatever Wikipedia article I was viewing previously. [21:16:53] This could be expected behaviour but it's odd. [21:17:15] juancarlos: yeah, file a bug report [21:17:24] juancarlos: maybe talk to yuvipanda first [21:17:28] kk [21:19:44] awjr: /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --disable-web-security [21:23:09] juancarlos: is this on the market version? [21:23:16] Yes [21:24:28] awjr: you need to do it like: argu = (typeof argu == 'undefined') ? [21:24:47] so, like: [21:24:53] argu = (typeof argu == 'undefined') ? 'my argument' : argu; [21:25:11] preilly: if that's for setting up defaults [21:25:19] you can just do argu = argu || 'default'; [21:25:27] yuvipanda: that is bad [21:25:32] preilly: why? [21:25:42] okay [21:25:44] 0, false, etc [21:25:45] got it [21:25:59] null or '' for example [21:27:37] yeah, makes sense [21:28:44] http://en.m.wiktionary.org/wiki/water <- why mw-collapsible/mw-collapsed are needed. [21:34:17] for show/hide [21:36:26] for the templates. [21:49:41] could anyone point me towards where the code is that handles the button event when the wikipedia app brings up the menu grid after pressing "menu"? [21:50:28] sup suyashjoshi ! [21:50:36] hey! [21:52:05] Yuvipanda, tfinc: do you have some pointers for TonyC_? looking for the listener. [21:58:48] yuvipanda: brion : http://etherpad.wikimedia.org/WikipediaMobileAndroidV1-0-1 [21:58:53] am i missing anything? [21:59:55] hey judytuna ! [22:00:03] Amgine: sorry .. getting very distracted here [22:00:08] whats the core issue ? [22:00:15] yuvipanda: http://etherpad.wikimedia.org/WikipediaMobileAndroidV1-0-1 [22:00:39] Dev needs to modify the response to menu button; cannot figure out how it is triggered tfinc. [22:00:46] hi tfinc ! thank you for the intro to phonegap — this is really cool stuff! [22:00:52] glad to help [22:01:01] judytuna: you ready to pick up some bugs? [22:01:42] philinje can point you to some [22:02:32] TonyC_: hello! [22:03:00] hey [22:03:02] TonyC_: check in assets/www/android/platform.js [22:03:07] updateMenuState [22:03:12] that's for android [22:07:36] sorry, got disconnected [22:07:38] did I miss anything? [22:08:37] nope [22:16:07] how difficult would it be to use that code to create a simple menu? is there a reason that the usual eventListener wasn't used to just bring up a page of buttons? [22:16:20] yuvipanda: ^ [22:17:00] TonyC_: well, we didn't want to be android specific [22:17:19] TonyC_: so that basically calls src/com/phonegap/menu/AppMenu.java [22:17:31] TonyC_: 'binding' things is simple - in index.html you see the tag [22:17:36] and in chrome.js you find 'menu-handler' [22:17:43] that map from 'action' tags in index.html to a function [22:19:01] tfinc, yuvipanda: we are revisiting the idea of forking the wiktionary app off the wikipedia app code. there is clearly a lot of work that has been invested in the menu button code (and elsewhere) that we can reuse. we believe that we should be able to implement the desired custom wiktionary presentation just by applying custom css/js to the web response. thoughts? [22:20:48] pfhayes: tell me what all functionality you guys would like from here [22:20:52] [WikipediaMobile] brion pushed 3 new commits to master: http://git.io/NVhZaQ [22:20:52] [WikipediaMobile/master] allow 4.2: prep for iscroll testing - Brion Vibber [22:20:52] [WikipediaMobile/master] add iscroll library - Brion Vibber [22:20:52] [WikipediaMobile/master] Use iScroll on iOS 3 (untested) or 4 (tested 4.3 sim) - Brion Vibber [22:20:53] and I'll tell you what we could do [22:21:03] in terms of pulling them out into common libraries [22:21:07] Project WikipediaMobile - Nightly builds build #108: SUCCESS in 7.2 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/108/ [22:21:07] * brion: allow 4.2: prep for iscroll testing [22:21:08] * brion: add iscroll library [22:21:08] * brion: Use iScroll on iOS 3 (untested) or 4 (tested 4.3 sim) [22:22:16] yuvipanda, we want to use the menu bar code, the UI code, and the interface with en.m.wikipedia.org code. [22:22:30] and the search bar [22:23:08] essentially, we replaced the use of 'wikipedia' with 'wiktionary' in the code and we got almost all the functionality we wanted, with the exception of styling the page to be optimal for dictionary usage [22:23:15] we won't be needed the geolocation code [22:25:04] pfhayes: hmm, in that case it sounds like a good idea to just fork it [22:25:15] but you guys will have to keep merging in changes we make [22:25:18] to keep it up-to-date [22:25:20] agreed [22:25:37] tfinc, can you create a fork of the wikipedia repository for us? [22:25:57] pfhayes: you guys just go ahead and hit fork [22:26:16] then it will be under one of our github accounts [22:26:56] i believe we want it under github.com/wikimedia [22:32:02] pfhayes: tfinc is at the hackathon, might take a while to get to it [22:32:07] pfhayes: don't let that block you guys :) [22:32:49] okay i can make the fork under my account in the meantime [22:32:54] go ahead [22:32:59] don't let us block you on operational stuff [22:33:03] we can always fix things up [22:33:12] The wiki way... [22:33:16] +1 [22:35:09] judytuna: http://www.mediawiki.org/wiki/API:FAQ#get_the_content_of_a_page_.28HTML.29.3F [22:47:12] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/QK0J0Q [22:47:12] [WikipediaMobile/master] Fix for scroll position not being reset when navigating pages with overflow scrolling - Brion Vibber [22:50:14] Project WikipediaMobile - Nightly builds build #109: SUCCESS in 8 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/109/ [22:50:14] brion: Fix for scroll position not being reset when navigating pages with overflow scrolling [23:07:24] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/k7xoyw [23:07:24] [WikipediaMobile/master] ahem.... fix for regression on ios toolbar - Brion Vibber [23:07:36] Project WikipediaMobile - Nightly builds build #110: SUCCESS in 6.2 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/110/ [23:07:37] brion: ahem.... fix for regression on ios toolbar [23:21:17] app finally got picked up in the market [23:21:21] 1.0.1 is out :D [23:21:40] yuvipanda: are the fixes in master as well ? [23:21:50] tfinc: yes, they are [23:22:00] sweet [23:35:02] judytuna: do you have any links to the womens hacking group you were talking about? i'd love to spread the word about it [23:35:53] tfinc: http://www.meetup.com/Women-Who-Code-SF/ is the one i do a lot of stuff with. also present here is rupa, who has a group in the south bay: http://codechix.org/ [23:36:02] awesome [23:36:13] let us know if we can help host meetups [23:41:25] judytuna: dlemieux pfhayes and anyone else who's not following our twitter handle .. http://twitter.com/WikimediaMobile [23:42:05] thanks! [23:58:50]