[00:00:05] \o/ [00:23:46] philinje: did you need any other stats? [00:25:01] brion: fixed it! [00:26:50] yayyy [00:28:12] it was a sortof threading issue [00:28:53] and me being confused about their definition of async [00:29:07] aha [00:29:16] so it was just being intermittent, ugh [00:29:32] yeah, so if isSync doesn't return true, they start the plugin in a new thread [00:29:49] and that one sortof dies after a while, plus we were doing UI related stuff there [00:29:50] not cool [00:30:57] tfinc: what was the total for iPhone - Howie was asking as a point of comparison with Android [00:31:02] funky [00:31:27] philinje: like i was saying. i don't have a total and any total wouldn't make any sense to compare to as the iOS app has been out for years [00:31:38] ok [00:34:44] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/Q5GO8A [00:34:44] [WikipediaMobile/master] Tweak to tablet behavior: use full column width until we have something to put in the sidebar. - Brion Vibber [00:34:52] brion: can you look at https://bugzilla.wikimedia.org/show_bug.cgi?id=2867 and tell me if it is complete? [00:35:00] Project WikipediaMobile - Nightly builds build #136: SUCCESS in 7.3 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/136/ [00:35:01] brion: Tweak to tablet behavior: use full column width until we have something to put in the sidebar. [00:36:07] grr i really want this macbook to have a touchscreen now [00:36:14] tfinc: i want to create new tracker bugs, because at the moment the ones for 1.1 and 1.2 are "baskets" for roughly bugs (1.1) and new features (1.2), as i plow through the bug backlog [00:36:55] except that 1.1 has new features like qsb and app intents [00:37:08] i'm confused as to how these new trackers are going to be different [00:37:11] am i missing something? [00:37:36] sorry, just a by-product of my "process" [00:37:36] tfinc: i think you're missing no more 'new' features for 1.1 [00:37:58] i want to pull things out into the real version bugs, so to speak [00:37:58] new as in over what we already have in master [00:38:36] so out of 31805, we'll pull just the bugs that we actually want to handle in 1.1 - into another tracker [00:39:08] and I can re-name 31805 to something like - "Current Android bugs" [00:39:13] and whats the benefit of this ? [00:39:41] yuvipanda: if this is useful to you and brion then do let know [00:39:43] i'm just not seeing it [00:40:32] it's just because i piled a lot of things into the current trackers, and the easiest way to clean that up is to move a few things selectively into new trackers [00:40:47] tfinc: we could do this during the meeting tomorrow. it makes sense to me and will make things much more cleaner. [00:40:54] sure, but why not just move whats not part of 1.1 out ? [00:41:08] i think there are more bugs to remove that way [00:41:59] plus, i want to mention features somewhat separately [00:42:11] anyway, we should discuss this tomorrow, but i just wanted to point out that the current 1.1 tracer is a little misleading [00:42:43] philinje: if you do that then your going to have to move all the resolved bugs into the new tracker too [00:44:32] yes [00:53:54] philinje: gotcaha, we could also use bugzilla milestones [00:54:03] yuvipanda is going to see what would be best for the dev team [00:54:08] either way .. i'm eager to see this cleaned up [01:04:12] so, hey guys. [01:04:17] X buttons and Clear buttons. [01:04:23] let's talk about that for a second. [01:04:42] my understanding is that *currently*, the X button takes you back to a previous screen. Is this correct? [01:05:01] the x button stops the page from loading [01:05:08] oh wait [01:05:15] you mean under saved pages and history [01:05:20] then yes [01:05:26] yeah, the icon yuvi was talking about [01:05:53] jorm: yes, it does [01:06:04] okay. that's probably bad. [01:06:14] X almost universally means "stop" or "clear" [01:06:21] so the "clear" icon should be the X. [01:06:27] and we should have a different icon for "go back" [01:06:41] thedj: your ShareKit branch seems to work but I'm having trouble merging it to current master; also some oddity when going into the 'More' dialog: https://bugzilla.wikimedia.org/show_bug.cgi?id=33675#c3 [01:07:10] arrow? [01:07:18] jorm: i think the current UI was started with the 'window' assumption where 'close' closes the current window [01:07:18] yeah, i'm thinking an arrow. [01:07:23] and yeah, doesn't make sense [01:07:31] so feel free to give us new icons to use and we will :) [01:07:32] mobiles don't have windows. that's a trip, ain't it? [01:07:39] small left-facing arrow on the left side makes sense as close/go back on phone interface [01:07:46] whooo! the future! [01:07:57] on tablet we may still want to consider but that mostly works (eg actionbar for android uses similar convention) [01:08:44] do you have an arrow or do you need one (yuvipanda)? [01:09:19] jorm: heatherw_ if you guys think any of the other icons we use are a bad idea (https://github.com/wikimedia/WikipediaMobile/blob/master/assets/www/image/spr.png) tell us [01:09:24] heatherw_: opinion on http://thenounproject.com/noun/arrow/#icon-No34 [01:09:24] ? [01:09:35] too arrowy ;) [01:09:40] hrm. yeah. [01:09:42] too arrowy. [01:09:49] i think a triangle, maybe. [01:10:09] or a triangle with a nub like i use here: http://www.mediawiki.org/wiki/File:ArticleCreationWorkflow-Landing-Step1.png [01:10:11] to warn: there's a triangle icon on tablet view [01:10:22] as the 'back' button on the main toolbar [01:10:28] or < but less acute [01:10:33] hypothetically we could replace that toolbar in our overlays though [01:10:46] aren't we trying to make a back button? :) [01:10:52] yep :D [01:10:59] brion_: i think we could reuse that.. [01:11:14] heatherw_: jorm https://github.com/wikimedia/WikipediaMobile/blob/master/assets/www/image/ios/toolbar-back.png [01:11:17] is what brion is talking about [01:11:30] http://developer.android.com/design/patterns/actionbar.html <- see the little "<"-like arrow they have on android 4 actionbar also [01:11:33] yah, that's good. i think i made that arrow, even. [01:11:33] will probably look weird on the right top corner [01:12:10] we may wish to use some of our own conventions that differ slightly from the platforms so we don't have to be too slavish for each one [01:12:16] hmm, maybe it shouldn't be on the top right [01:12:21] universality is part of the advantage of the web :D [01:12:23] can you put it to the left side of "history"? [01:12:24] it's not a 'close' it's a 'back' and they're usually on top left [01:12:26] i like top left for this [01:12:45] +1 [01:13:03] but we should be using an icon like the back icon in http://developer.android.com/design/patterns/actionbar.html [01:13:06] as brion said [01:13:21] < but less acute, as heatherw_ said [01:15:35] heatherw_: can you make us one? I can't seem to find anything like that. [01:15:53] yup! [01:16:15] there might even be a glyph [01:16:43] mmm unicode [01:24:45] this is gonna be a big merge [01:24:46] sharekit [01:24:51] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/XTkuDw [01:24:51] [WikipediaMobile/master] Merge remote-tracking branch 'thedj/master' - Brion Vibber [01:25:07] Project WikipediaMobile - Nightly builds build #137: SUCCESS in 10 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/137/ [01:25:08] * hartman: Importing the ShareKitPlugin for PhoneGap [01:25:08] * hartman: Register ShareKitPlugin as a PhoneGap plugin. [01:25:09] * hartman: Adding ShareKit 2.0 as a submodule [01:25:09] * hartman: Register ShareKitPlugin as an iOS PhoneGap plugin [01:25:10] * hartman: Add some changes to the ShareKitPlugin to make it actually work. [01:25:10] * hartman: The new Xcode project file with all the changed ShareKit stuff. [01:25:11] * hartman: Add some setup for configuring our setup of ShareKit [01:25:11] * hartman: Disabling some of the plugins that are not likely gonna be useful in immediate future. [01:25:12] * hartman: Compile error in the launchdelegate [01:25:12] * hartman: Add the sharePage command to the iOS PhoneGap platform [01:25:13] * hartman: Add CREDITS and generator for the credits [01:25:13] * hartman: Make sure that the searchbar and menu bar are localized when first starting the app [01:25:14] * hartman: Extend jquery localize to be able to handle placeholder atributes [01:25:14] * hartman: Add placeholder to the Search field. [01:25:15] * hartman: Turn the search field into an actual type=search, know that I finally figured out how to undo all of webkit's search field styling. [01:25:15] * hartman: Make sure the Home button is recognized as a button by using role"button". [01:25:16] * hartman: Revert "Add placeholder to the Search field." [01:28:44] and a smaller push from me [01:28:46] [WikipediaMobile] yuvipanda pushed 2 new commits to master: http://git.io/ijeMVw [01:28:47] [WikipediaMobile/master] Initial commit towards fixing offline cache issues - YuviPanda [01:28:47] [WikipediaMobile/master] Make the plugin run on the UI Thread - YuviPanda [01:29:00] Project WikipediaMobile - Nightly builds build #138: SUCCESS in 7.8 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/138/ [01:29:00] * yuvipanda: Initial commit towards fixing offline cache issues [01:29:01] * yuvipanda: Make the plugin run on the UI Thread [01:31:15] #33656 fixed ^^ [01:31:37] Astagi: woot! [01:36:01] \o/ [01:36:11] ^^ [01:36:17] tfinc: we should check for requests from uk.co.exelentia.wikipedia and display a download link for our app instead of the page [01:36:27] lolz [01:36:54] would you like your Wikipedia without ads .. click here [01:36:59] * tfinc likes this idea [01:37:11] yeah, I think it's a good one [01:37:27] especially since their not giving up our trademarks [01:46:52] yuvipanda: not being able to use Wifi only in 1.0.2 is killing me [01:46:57] whats the bug on this? [01:47:26] yuvipanda: .. ? [01:55:32] tfinc: that bug still exists? [01:55:42] i just re-opened it [01:55:43] tfinc: it was on 1.0, we fixed it for 1.0.1 [01:55:46] can you repro it now? [01:55:52] all i had to do was to turn off data [01:55:59] which is really bad [01:56:23] tfinc: for 1.0.2? [01:57:15] tfinc: i test on wifi only all the time [01:57:29] tfinc: are you running market release? [01:57:33] yes [01:57:44] and were getting reports in the market [01:58:50] tfinc: i tried by being on wifi and then airplane mode, got nothing [01:59:02] tfinc: will test tomorrow when you're back in here with your phone? [01:59:14] sure [02:16:08] this callback madness has to end! [02:16:42] ok fine .. we'll call it cordova [02:16:43] haha [02:17:30] that's *another* callback madness [02:17:47] tfinc: btw, the phonegap guys told me they should release an 'RC' today [02:18:03] assuming that's not like how we ran RCs, we should push to that too :) [02:18:31] an RC of what? 1.4 ? [02:18:34] tfinc: yes [02:18:38] sweet [02:18:57] tfinc: i'm currently rewriting URLCache, the last piece needed to make iOS featurecomplete :) [02:19:04] tfinc: you stillh ave the OSM monkey on your back. [02:19:26] tfinc: and should definitely check out http://wiki.openstreetmap.org/wiki/Mapquest#MapQuest-hosted_map_tiles if you haven't already [02:22:15] yuvipanda: already moving on those threads [02:22:19] its a big monkey though [02:22:21] :D [02:22:43] thank goodness our last iOS RC's made sense [02:22:46] lets take our lesses there [02:22:51] and NOT V1.0 :D [02:22:55] that was a mistake [02:22:56] haha [02:22:59] lessons* [02:23:06] so … beta1 next week ? [02:23:08] :D [02:23:13] definitely before I leave, yes [02:24:04] lets set a date for V1.1 tomorrow [02:24:25] tfinc: alright. [02:24:31] sweet [02:24:39] i'd like Android 1.1 betas and iOS 3.0 betas to go out simultaneously [02:25:06] tfinc: ^ [02:26:26] okay, I need to move to jquery first [02:26:41] yuvipanda saw the comment ^^ I'm not sure we can disable from CSS and anyway I don't want to disable search box any time.. calls like $('#search').addClass('inProgress'); are also repeated many times, without a single function, for example showInProgress() [02:26:58] Astagi: true, and that's something I want to get rid of [02:27:05] maybe we can think about refactoring later ^^ [02:27:20] Astagi: one thing that has served me well is to refactor when we touch something [02:27:25] instead of adding to the mess with a 'refactor later' [02:27:29] because 'later' never comes :D [02:27:36] Astagi: can you think of a way to refactor all that out? [02:27:43] you understand why mixing all those in is a bad idae [02:28:59] yupanda ahah that's true :D I'll make a refactoring ok, I will finish to solve another bug and start working on it ;) [02:30:17] Astagi: :) [02:35:04] twitter fail whale .. [02:35:38] you know.. these days they really have no excuse for being down so much [02:36:10] Twitter is over capacity. [02:36:11] lame [02:44:03] i think thedj's iOS changes have messed some of the UI in the androdi version [02:46:15] thedj: --^ [02:50:44] thedj: you figured out type="search" from iOS, but it makes things suck on Android :) [03:06:10] gah [03:15:47] 498,364 total installs (users) :D [03:16:00] looks like my projection for the blog post will line up just fine [03:16:06] ok .. time to climb [03:20:34] :D nice! [03:25:35] Fixed #33573 ^^ [03:25:40] time to go bed [03:25:53] goddnight everybody! [04:13:52] bah... 10 minutes a student is in here... [07:02:03] * yuvipanda waves [07:37:18] hey [12:08:28] MaxSem, where is the featured feed supposed to appear? [12:08:28] in on main page [12:08:47] in the future, we may add it to sidebar like at http://mobile-feeds.wmflabs.org/w/index.php/Main_Page [12:09:07] it even was so accidentally during the deployment [12:09:55] ah, ok, I'll update the docs [12:10:50] MaxSem, https://it.wikiquote.org/w/index.php?action=featuredfeed&feed=qotd&feedformat=atom [12:11:11] did I do something wrong? or do I have to wait a bit? https://it.wikiquote.org/wiki/Speciale:Contributi/Nemo_bis [12:11:17] https://it.wikiquote.org/w/api.php?action=featuredfeed&feed=qotd&feedformat=atom [12:12:00] Nemo_bis, ^^ [12:12:15] heh [12:12:47] you need to translate a few messages [12:13:27] MaxSem, [[MediaWiki:Ffeed-qotd-entry]] doesn't seem to work [12:13:37] the feed might take up to an hour to update after this [12:14:01] ok [12:14:45] MaxSem, does it translate also the title on https://it.wikiquote.org/wiki/Speciale:FeedItem/qotd/20120123000000/it ? [12:16:40] the title is also cached:P [12:16:56] ok [12:17:21] hmm, now I need to play a bit with the templates to remove useless images which don't show up well in feeds [12:17:46] but that's really awesome, MaxSem, thanks! [12:20:33] MaxSem, something I really need in such feeds is to have them redirect people to the source content rather than to the feed item [12:21:16] '''[[foo|(read more...)]]''' [12:22:02] sure, but I doubt that changes the entry title link :) [12:22:09] but yes, I'm nitpicking [12:22:58] sometimes the content will be truncated (e.g. on microblogs) and it would be nice to save a click or have Facebook and such recognize the final target [12:23:43] but it's still much much better than the buggy bots we have now [12:23:44] yes, we will definitely need to tweak some stuff [12:23:52] oh, great [12:24:07] now we are in a data collection phase [12:25:07] the design with Special:FeedItem has been invented for wikis that don't have separate per-day templates and as such cannot have unique title links [12:25:47] sure, it's very nice [15:33:12] MaxSem: very nice FeaturedFeeds, thanks a lot. But just a question: [15:33:32] MaxSem: on dewiki the featured articles are on a per day base like https://de.wikipedia.org/wiki/Wikipedia:Hauptseite/Artikel_des_Tages/Donnerstag [15:34:21] MaxSem: but the feed shows text outside of ... too. [15:34:24] bug or feature? [17:20:46] Raymond_, create a page that contains a transclusion of said template and nothing else [17:21:12] then put its title into mediawiki:ffeed-featured-page [17:21:50] MaxSem: ok thanks will try [17:42:18] hi yuvipanda ^^ [17:43:50] I noticed this problem today on my wildfire, I have a screenshot http://toworktogether.eu/wikiandroidshot.png ... search input box has some graphical problem.. [17:53:02] Astagi, I reopened the bug for that issue this morning :) [17:53:21] nice Reedy ^^ [17:53:38] https://bugzilla.wikimedia.org/show_bug.cgi?id=31522 [17:53:50] brion: hey, can you take a look at bug 33628 - I think we can close it [17:55:14] philinje, doesn't look like it's in production yet so i would assume it hasn't changed [17:56:32] MaxSem: Hello, mainy wikisource have i their main pages a text of the week like fr, en (month) or it. Is-it possible to use FeaturedFeed extension ? [17:57:10] Tpt, probably - let me look [17:57:40] text of the month will not work as we have a limit of 10 days [17:58:50] Tpt, s:fr: doesn't seem to have an automatic updates system [17:58:56] it's aprerequisite [17:59:28] For fr we will create it. [18:00:16] Pages like that : Wikisource:Extraits/YEAR/NUMBER OF THE WEEK [18:00:34] A contributor is working on. [18:00:53] great [18:01:06] my instruction has an example of weekly feeds [18:02:21] I've follow them for fr wp. [18:05:11] MaxSem: Can we imagine a deployment in the next weeks ? [18:05:28] Tpt, deployment of what? [18:05:55] MaxSem: Extension:FeaturedFeeds [18:06:10] On fr wikisource [18:07:18] probably, sooner. we're currently collecting feedback and will make some changes soonish [18:08:19] it wasn't enabled on Wikisources because when I sweeped through different wikis I found no Wikisource with content ready for feeds [18:08:20] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/uAQ10A [18:08:20] [WikipediaMobile/master] Revert commit 6b0f789f1a42975db5fd112d06ec93e01fc42e76 - added type="search" on the search box. - Brion Vibber [18:08:37] Project WikipediaMobile - Nightly builds build #139: SUCCESS in 9.8 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/139/ [18:08:38] brion: Revert commit 6b0f789f1a42975db5fd112d06ec93e01fc42e76 - added type="search" on the search box. [18:09:26] MaxSem: Thanks. We will have botd (Boook of the day) like the "Quote of the day" ? [18:09:52] whatever you call 'em [18:10:23] is there a common wikisourcie terminology? [18:13:52] Featured text in en. [18:25:47] be a bit late [18:25:59] MaxSem: hi [18:26:01] cya in 20 mins or so everyone [18:26:06] ok [18:26:12] philinje, hi [18:26:25] do you have a bug for your GPS API work? [18:27:49] hmm, i thought I had one [18:28:05] MaxSem: or should I make one? maybe the one for articles with geolocation data or photos is separate? [18:28:32] photos is separate, probably [18:29:05] tfinc, hi [18:29:13] MaxSem: yo [18:29:19] congrats on getting the blog post and deployment out! [18:29:29] thanks [18:29:39] we don't have a bug for GeoData [18:29:42] ? [18:30:00] MaxSem: shame on us.. slackers [18:30:07] and in other news 528,082 total installs (users)! [18:30:20] and http://blog.wikimedia.org/2012/01/26/announcing-the-official-wikipedia-android-app/ :D [18:30:55] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/np8zYA [18:30:55] [WikipediaMobile/master] Add 'Read it later' API key for ShareKit configuration on iOS - Brion Vibber [18:31:12] Project WikipediaMobile - Nightly builds build #140: SUCCESS in 7.9 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/140/ [18:31:12] brion: Add 'Read it later' API key for ShareKit configuration on iOS [18:31:38] MaxSem: please create whatever bugs you want to create and let me know the numbers, thanks [18:31:53] okie [18:36:38] Astagi: thanks for http://4spills.blogspot.com/2012/01/wikipedia-mobile.html [18:44:04] philinje: interesting tweet https://twitter.com/#!/jacobstrom/status/162522681839857664 [18:53:22] brion_: fyi, i have single signon changes in my local repo that i'm still finishing up... [18:53:35] Facebook single sign on [18:54:03] letting you know so we don't clash in effort :D [18:55:28] :) [18:58:39] ok [19:06:17] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/4HpYFg [19:06:17] [WikipediaMobile/master] Fix regression: 'nearby' broke on iOS, web - Brion Vibber [19:06:31] Project WikipediaMobile - Nightly builds build #141: SUCCESS in 7.8 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/141/ [19:06:31] brion: Fix regression: 'nearby' broke on iOS, web [19:08:08] tfinc you're welcome ^^ [19:12:24] i'm gonna turn the close and home buttons into actual buttons now... [19:12:37] should help with their accessibility [19:13:26] \o/ [19:14:22] i wonder how you get a "top developer" standing in the android market [19:14:56] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/GA7pTg [19:14:56] [WikipediaMobile/master] Fix bug 33869: OSM/Leaflet map label overlaps toolbar - Brion Vibber [19:15:10] Project WikipediaMobile - Nightly builds build #142: SUCCESS in 8.2 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/142/ [19:15:10] brion: Fix bug 33869: OSM/Leaflet map label overlaps toolbar [19:28:03] tfinc, forwarded you a vague note from apple about our app; I suspect from the vague voicemail that we need to change the content rating from 4+ to 17+ or something [19:28:17] there's a # and email for followup [19:29:27] hmm [19:29:30] yeah. i saw [19:29:41] i'm going to mail them [19:31:34] is it intential that the home button size is smaller than then search button ? [19:31:41] intentional [19:32:25] brion: mailed the apple contact [19:32:41] whee [19:32:55] thedj, they should be about the same-ish [19:33:00] oh yeash apple actually wants us to 17+ it ? [19:33:09] brion: one is 35px high, the other 37. [19:33:32] i'll make a ticket... [19:33:35] thedj, i think for some reason i had to adjust them to actually match visually. possibly a bad style bit in there somewhere (padding? margins?) [19:37:19] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/FQlvtw [19:37:19] [WikipediaMobile/master] Fix map regression: wasn't clearing old markers before adding new ones - Brion Vibber [19:37:33] Project WikipediaMobile - Nightly builds build #143: SUCCESS in 8.4 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/143/ [19:37:34] brion: Fix map regression: wasn't clearing old markers before adding new ones [19:45:04] ugh [19:45:11] we have a description translation problem [19:45:31] brion: yuvipanda : the line "Send us your feedback on Twitter @WikimediaMobile." [19:45:32] got dropped [19:45:45] :( [19:45:49] we've been getting a good amount of feedback over twitter [19:45:51] on all of them? [19:45:56] and i'd hate to lose it in other languages [19:45:58] was this a newline issue? [19:46:03] in the messages file? [19:46:05] * yuvipanda looks [19:46:19] its not in the message file at all [19:46:29] yeah [19:46:44] yuvipanda: add it please [19:46:50] i'll continue to update the translations [19:46:52] yeah, on it [19:46:56] and we'll just add this line next week [19:46:58] when the strings come back [19:49:15] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/wY1L_Q [19:49:15] [WikipediaMobile/master] Update iOS splash images - Brion Vibber [19:49:26] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/kGMCzA [19:49:26] [WikipediaMobile/master] Updated app description message to include feedback instructions - YuviPanda [19:49:40] tfinc: ^ [19:49:46] thanks [19:49:49] Project WikipediaMobile - Nightly builds build #144: SUCCESS in 7.9 sec: http://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/144/ [19:49:49] * brion: Update iOS splash images [19:49:50] * yuvipanda: Updated app description message to include feedback instructions [19:50:55] still no hashar [19:54:48] ok .. all descriptions have been updated minus : no & zh-TW [19:55:02] anyone know how we map those two ? [19:57:29] tfinc: all the 'node.js sucks' blog posts apply to us too [19:57:39] hmm ? [19:57:40] (re: the video you sent me y'day) [19:59:02] hmm needs more context, forget it [21:00:16] brion: can you look at https://github.com/wikimedia/WikipediaMobile/pull/125 and see if it's okay on iOS? [21:06:21] brion: what to do with bug 33656? https://bugzilla.wikimedia.org/show_bug.cgi?id=33656 .. do I have to make a reverse? no problem for me... someone else have any further idea? [21:08:52] yuvipanda is the new refactoring ok? ^^ [21:14:47] Astagi: heya! [21:15:10] Astagi: better, but i want to take a closer look. [21:15:17] am moving off zepto into jquery now, will do after that? [21:15:41] Astagi: also, *why* exactly are you disabling the search box at all? [21:17:21] k. time to go... [21:17:23] ok yuvipanda ^^ well I would reduce the possibility for users to make too many operations during loading a page. If this take too long the user could cancel the operation but not be able to search anything during loading...this solves the problem of focus too ^^ that is not a problem anyway... [21:17:50] Astagi: if 'focus' is the problem you're trying to solve, shouldn't just removing the class 'active' solve it? [21:18:29] thedj: have a nice journey! [21:18:34] also, do git rebase :P [21:18:48] bye thedj! [21:19:34] yuvipanda that's true but I would also to reduce that possibility to user... next time I'll ask you what you think about, if you don't like it I'll make a reverse, no problem ^^ [21:20:03] yuvipanda with possibility I mean the possibility to search during a page loading.. [21:21:01] the user *should* be able to search somewhere else when we are loading a page, right? [21:21:06] why would you want to restrict that? [21:22:11] uhm yep that's true.. [21:22:17] my bad sorry ^^ [21:22:24] I'll make a reverse ok? [21:22:43] Astagi: sure :) [21:23:04] ^^ [21:26:56] yuvipanda do I have to remove enableSearchBox and disableSearchBox functions too or I let them for an eventually use in the future? [21:27:12] well, we can always add them back in when we want to [21:27:17] so i'd suggest we get rid of them? [21:27:36] nice ^^ [21:27:39] will do [21:41:30] yuvipanda done ^^ [21:41:43] Astagi: same branch? [21:42:16] yuvipanda: yep [21:46:07] Astagi: will take a look :) [21:46:16] do you have another bug to work on or would you like me to pick you one? [21:46:51] no one at the moment ^^ pick me bugs like there's no tomorrow! [21:46:56] Astagi: https://bugzilla.wikimedia.org/show_bug.cgi?id=33624 [21:47:00] would be awesome if fixed :) [21:47:17] you can ignore whatever is in java, and just scour the js/html for things that need to be marked translateable [21:48:01] ok nice ^^ [21:48:21] oh just a thing [21:48:26] settings are working? [21:48:34] Astagi: ? [21:48:39] didn't have a look at that part of code [21:48:56] but using the app I can't click on setting labels [21:48:56] oh yes, intermittently settings seem to be messed up but i was going to look at it after the jQuery port [21:49:10] Astagi: there's no way to trigger a