[00:15:58] brion_: http://zero-testing.wikipedia.wmflabs.org/w/index.php/Test [00:23:47] brion_: thanks, for your help [01:25:25] binasher: curl -I -A "Mozilla/5.0 (iPhone; U; CPU iPhone OS 4_1 like Mac OS X; en-us) AppleWebKit/532.9 (KHTML, like Gecko) Version/4.0.5 Mobile/8B117 Safari/6531.22.7 (compatible; Googlebot-Mobile/2.1; +http://www.google.com/bot.html)" http://en.wikipedia.org/wiki/Foobar [09:00:51] * yuvipanda waves around [11:33:30] yuvipanda are you there? [11:33:44] jdlrobson: heya [11:34:07] i managed to update xcode [11:34:11] but now I'm getting Lexical or Preprocessor issue on the line #import (file not found) [11:34:37] googling not helping but im guessing it cant locate the phonegap stuff [11:34:42] jdlrobson: did the submodule init and update twice? [11:34:47] yep [11:35:08] jdlrobson: 4.3? [11:35:23] jdlrobson: oh wait [11:35:24] 4.2 ... thats the closest i believe i can get [11:35:28] did you install PhoneGap? [11:35:55] they've a dmg from phonegap.com that you need to [11:35:57] install [11:36:05] i installed it before.. im guessing it could have broken in the upgrade? [11:36:07] let me look [11:36:13] very possibly [11:36:47] Cordova-1.5.0.dmg ? [11:37:04] we're at 1.4.1, should upgrade though [11:38:37] nope same issue after installing that :( [11:38:55] do i need to add it to the project? [11:40:14] jdlrobson: if you have it installed before starting it, no [11:47:49] still no luck [11:51:12] also fyi yuvipanda - https://bugzilla.wikimedia.org/show_bug.cgi?id=32244#c13 [11:51:46] jdlrobson: i was trying out javascripty solutiosn, let me try that one [11:58:53] gonna reboot [11:59:18] jdlrobson: ok [12:15:00] jdlrobson: poke the guys on #phonegap? [12:15:07] what's hello world bailing on you with? [12:15:34] well it builds fine [12:15:44] but the osx simulator complains about the sdk [12:16:23] "iOS Simulator could not find the SDK. The SDK may need to be reinstalled." [12:16:38] * yuvipanda wonders if it is a SnowLeapord vs Lion issue [12:17:04] i suspect so [12:17:47] ok got helloworld building [12:17:51] nice! [12:17:53] what was the issue? [12:18:15] turns out only certain simulators work [12:18:55] still got exactly the same issue with wikipedia app though :/ [12:20:46] jdlrobson: which one didn't work? [12:21:00] it complains on the line #import [12:21:13] lexical or preprocessor issue (file not found) [12:21:54] jdlrobson: expand the 'frameworks' bit and see if PhoneGap.framework is there? [12:22:29] sorry dummy question.. where do I find the frameworks bit? [12:22:42] jdlrobson: left pane in xcode [12:23:01] right next to Wikipedia-iOS [12:23:06] it's a tree view [12:23:10] ah cheers - it was hidden [12:23:14] used view menu to show it [12:23:22] yep Phonegap.framework is there [12:23:48] are you able to expand it and look at the headers? [12:24:06] interestingly there is no PGViewController but there is a PhoneGapViewController [12:24:34] jdlrobson: hmm, did you install 1.4.1? [12:25:15] jdlrobson: i have both a PGViewController and a PhoneGapViewController [12:25:35] mm I installed the latest version so I guess that was 1.5 [12:25:46] it's possible that there were some incompatible changes there [12:25:53] (There were a few when we moved from 1.3 to 1.4.1) [12:27:11] is there a way to remove a framework and add it again? [12:27:16] maybe its linked to an older install of phonegap [12:27:54] jdlrobson: right clicking it gives me 'delete' option [12:28:22] :) but not sure how to add :) [12:29:29] jdlrobson: https://developer.apple.com/library/ios/#recipes/xcode_help-project_editor/Articles/AddingaLibrarytoaTarget.html#//apple_ref/doc/uid/TP40010155-CH17-SW1 [12:29:31] i found a download for 1.4.1 [12:29:34] will install that instead [12:29:37] ok [12:31:31] there we go! [12:32:03] works? [12:32:12] yep [12:32:23] :D [12:32:34] so it seems Phonegap 1.5 will require some changes - seems to be renamed Cordova [12:32:45] i dont know what i was running before 1.5 [12:33:01] and i only managed to download 1.4.1 via google cache [12:33:13] k gonna get pulling now! [12:33:52] sigh [12:34:00] yes - it's going to be messy [12:34:00] ps. Wikipedia-iOS.xcodeproj/project.pbxproj probably shouldn't be checked in right? [12:36:23] possibly - it's been there forever. [12:36:23] will check [12:36:23] jdlrobson: according to http://stackoverflow.com/questions/6626364/is-it-save-to-ignore-pbx-files-in-version-control-of-x-code-project everything else inside .xcodeproj should be ignored [12:36:23] but the project.pbxproj shouldn't be [12:37:12] yeh cos ive made modifications to it already! [12:38:07] with your messing around in project properties? [12:38:42] yuvipanda, jdlrobson, we've got a problem: parse by section will break some stuff like . I can quickly whip up a module that would just split whole output by sections, but there will still be problems with refs [12:38:53] [WikipediaMobile] jdlrobson pushed 1 new commit to master: http://git.io/zQH6ig [12:38:53] [WikipediaMobile/master] Merge branch 'tmp' - Jon Robson [12:39:01] jdlrobson: Y U NO REBASE? [12:39:17] Project WikipediaMobile - Nightly builds build #215: SUCCESS in 13 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/215/ [12:39:18] * yuvipanda: Disable back button when there is nothing to go back to [12:39:18] * yuvipanda: Show main UI + Spinner when navigating to pages [12:39:19] * yuvipanda: Cleaner toggling actions code [12:39:19] okay, I was just about to point OuKB to MaxSem [12:39:19] * yuvipanda: Make back button disabled by default [12:39:20] gah [12:40:56] for example, initial page view: zeroth section and headings. user clicks on a reference. it will not work because its destination is not present [12:42:29] another use case: a
is opened in one sction, but closed in another. guess TIdy will fix most of problems with it, but not all [12:42:33] MaxSem: have references come in separately? [12:42:35] sorry i keep forgetting yuvipanda - will remember next time [12:42:36] ah [12:47:23] well, we can remove references. just need to do something about Joan's wrath :P [12:48:04] MaxSem: :D [12:48:14] we can get references come down by default? [12:52:12] jdlrobson: the CSS solution sortof works :) [12:53:10] the select menu? [12:53:14] which bit doesn't work? [12:53:36] im just looking at - https://github.com/yuvipanda/WikipediaMobile/commit/378777675ba366871e9722ff08bf1158f7019f61 and wondering why clicking on an overlay doesn't add something to history... [12:54:10] jdlrobson: because our code sucks :) Overlays are now just DIVs that pop up and then get out. [12:54:17] we could handle them in our history code, but we don't [12:54:39] mm [12:54:54] what we *should* be doing is have concept of 'windows' for history [12:55:01] with a contentWindow that shows contents [12:55:06] there is a lot of duplicated code among the overlays [12:55:29] maybe clicking an overlay should hide the bottom menu? [12:55:47] hmm [12:56:09] but the only way you can then get to another one is back then forward [12:56:43] * yuvipanda wonders how native iOS apps handle this [12:56:50] well if i click the back button in the top left shouldn't that reveal the menu again? [12:58:17] after all an overlay is something on top of the current thing - the current page is still there [12:58:22] so the action is more like a close then a back [12:59:13] jdlrobson: makes sense. [12:59:26] you can close that pull req with comments to that effect, i'll do that later tonight. [13:00:17] np [13:00:25] also https://github.com/wikimedia/WikipediaMobile/pull/158 back button seems to behave how i expect.. [13:00:27] i click settings [13:00:31] i click about page [13:00:36] i click back in the top left and go back to settings [13:00:46] i click back again in top left and go back to home [13:01:31] yes, that is how it is supposed to work? [13:01:58] the other pull request was for the fact that the lower back button won't be enabled if you were in an overlay at certain times (aka when there is nothing in history) [13:03:48] ah i see [13:04:33] argg closed that pull request and it lost my comment [13:04:37] :D [13:05:13] jdlrobson: https://github.com/yuvipanda/WikipediaMobile/tree/settings-overlay-fix [13:05:21] is the css based fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=32244#c13 [13:05:29] while it works, it does look quite a big ugl [13:05:29] y [13:05:32] suggestions? [13:06:17] * yuvipanda gets a screenie [13:07:33] jdlrobson: http://minus.com/mbpDF6y5KC# [13:08:23] is 'English' from the options menu ? [13:08:41] yes, that is the