[00:00:01] yes :( [00:00:30] preilly: iirc that was not a problem before, correct? it was just a problem when you'd hit 'enter' or click the search icon? [00:00:53] awjr: the links are wrong in suggestions-results [00:01:48] preilly: indeed they are [00:02:09] preilly: where do those links get generated? [00:02:22] awjr: it's in the javascript [00:02:28] ahha [00:02:46] awjr: line 130 of opensearch.js [00:02:48] ok yuvipanda sent the link to 4 of my friends :) [00:02:59] Astagi: sweeet! :D [00:03:00] thanks! [00:03:16] oh btw yuvipanda one of my friends is receiving blackberry playbook [00:03:27] oh? [00:03:30] it's possible to run android apps in that device [00:03:45] I could ask to pack wikipedia and try :) [00:03:47] Astagi: brion merged in code to let us ron on the playbook [00:03:48] *run [00:03:49] sure! [00:04:00] Astagi: we even merged in a pull request a few days ago that made it easier! [00:04:03] test it out! [00:04:16] oh nice yuvipanda didn't know it :) [00:04:22] ok :) [00:04:36] :D [00:07:52] preilly: i see so we need to add some way for the javascript to transform the url returned by opensearch to the $wgMobileUrlTemplate [00:08:14] yuvipanda: ipa sent [00:08:22] tfinc: thanks! [00:08:47] awjr: we need to convert the absolute path to relative [00:08:47] i wonder how brion is doing with the playbook code [00:09:25] preilly: even better [00:09:29] is this critical to fix now? [00:09:35] awjr: YES [00:10:00] k i need to coordinate with folks about the meeting im supposed to be in gimme a min [00:12:11] preilly: hows the zero push going? [00:12:58] awjr: we can do something like str.replace(/^(?:\/\/|[^\/]+)*\//, "") [00:13:04] tfinc: search bug [00:13:08] k [00:13:30] i read that as an issue with the MF push [00:18:23] yes [00:23:27] yuvipanda: http://phonegap.com/2012/03/06/phonegap-1-5-released/ [00:23:53] tfinc: saw that a day ago. [00:24:01] anything that were excited to pickup ? [00:24:22] am wary of upgrading this late in the release cycle [00:24:25] it's a pretty big change [00:25:06] so I'd want to not upgrade until 1.1 is out the door [00:27:54] awjr: I think I've got a fix for it [00:28:00] awjr: I just pushed it [00:28:06] preilly: awesome [00:28:19] pushed in trunk or to the cluster? [00:28:26] awjr: cluster [00:28:34] awjr: I changed it to link.setAttribute( 'href', section.value.replace( /^(?:\/\/|[^\/]+)*\//, '/' ) ); [00:28:53] yuvipanda: dont upgrade it [00:29:03] yup. not doing it. [00:29:08] we can do in the next minor release [00:29:15] awjr: can you refresh a page and try the search again [00:29:15] preilly: cool - i was trying something similar but not seeing proper results in my local instance [00:29:29] yeah trying now [00:29:40] preilly looks good [00:30:40] oh jeez i was editing the a different opensearch.js than the one in my docroot >_< [00:31:02] ok preilly, anything else? [00:32:56] awjr: I'm fixing it for beta now too [00:33:47] cool [00:33:48] awjr: okay, I think we are good [00:33:50] nice work [00:33:55] awjr: np [00:34:35] awjr: can you review these: https://www.mediawiki.org/w/index.php?path=%2Ftrunk%2Fextensions%2FMobileFrontend&title=Special%3ACode%2FMediaWiki%2Fstatus%2Fnew&limit=100 [00:37:10] preilly: done [00:38:06] awjr: thanks! [00:38:12] np [00:38:17] svn di [00:38:19] oops [00:40:03] awjr: what was that? [00:40:06] binasher: http://my.zero.wikipedia.org/wiki/%E1%80%99%E1%80%BC%E1%80%94%E1%80%BA%E1%80%99%E1%80%AC%E1%80%B7%E1%80%85%E1%80%80%E1%80%B9%E1%80%80%E1%80%B0%E1%80%94%E1%80%BE%E1%80%84%E1%80%B7%E1%80%BA%E1%80%93%E1%80%AC%E1%80%90%E1%80%AF%E1%80%97%E1%80%B1%E1%80%92%E1%80%9C%E1%80%AF%E1%80%95%E1%80%BA%E1%80%84%E1%80%94%E1%80%BA%E1%80%B8 [00:40:24] preilly: me trying to do 'svn di' on a working dir :p [00:50:15] awjr: found another bug [00:50:34] preilly: ? [00:51:01] awjr: show/hide are only in English [00:51:07] awjr: on all wikis! [00:51:16] shitsandwich [00:52:24] preilly presumably because of label = document.createTextNode( visible ? 'Show' : 'Hide' ); ? [00:52:38] in application.js [00:53:02] awjr: yeah, label = document.createTextNode( visible ? 'Show' : 'Hide' ); is the issue [00:53:03] how do you handle translations for text generated in js w/o resource loader? [00:53:27] awjr: you've got to pass it globally [00:54:07] awjr: like in ApplicationTemplate [00:54:30] oic [00:54:50] awjr: do you want to make the change or should I? [00:54:59] let me take a stab at it [00:55:13] awjr: okay [00:55:59] this menu race condition is going to take more of my life. gnite for the day. [00:56:25] awjr: you should add the data in the getApplicationTemplate method in MobileFrontend.body [00:56:41] ah thanks was just chasing that down [00:56:56] awjr: with these two keys 'mobile-frontend-show-button', 'mobile-frontend-hide-button', [00:57:38] awjr: do you have the yuicompressor-2.4.6.jar file locally? [00:57:44] i do not [00:57:54] awjr: you will need that to run make [00:58:05] awjr: to create the minified version [00:58:39] awjr: you can get it from http://www.java2s.com/Code/JarDownload/yuicompressor/yuicompressor-2.4.6.jar.zip [00:59:09] awjr: place the unzip'ed file in phase3/extensions/MobileFrontend$ (or, whatever your trunk copy of MobileFrontend is) [00:59:23] awjr: then run make after your JS changes are complete [01:04:24] preilly: semi off-topic is MF mobile view rendering slow for you locally? it's slow as hell for me which makes testing take forever [01:04:49] awjr: do you have memcache installed and configured locally? [01:04:53] preilly: no [01:04:59] awjr: well that is the issue [01:05:09] awjr: are you running Ubuntu? [01:05:20] preilly: more on topic, how do i get the section buttons to show? i have sections set up on an article, but i take it there's more i need to do [01:05:21] i am [01:05:57] awjr: sudo apt-get install memcached [01:06:05] awjr: then in LocalSettings.php [01:06:15] awjr: $wgMemCachedPersistent = true; [01:06:15] $wgUseMemCached = true; [01:06:17] $wgMainCacheType = CACHE_MEMCACHED; [01:06:18] $wgMemCachedTimeout = 500000; [01:06:19] $wgMemCachedInstanceSize = 2000; [01:06:20] $wgMemCachedServers = array('127.0.0.1:11211'); [01:06:53] awjr: the sections buttons should show on a page with sections and is greater than 4000 characters [01:07:02] k thnx [01:11:19] awjr: how's it coming along? [01:12:50] preilly: good - just realized wasn't working because it's looking for minified js [01:13:24] awjr: did you grab the http://www.java2s.com/Code/JarDownload/yuicompressor/yuicompressor-2.4.6.jar.zip and unzip and run make to create a new minified file? [01:13:41] ok it's working [01:13:49] preilly: doing that now [01:17:30] preilly: ok i have minified application.js [01:17:37] i presume i need to make the same change for beta? [01:17:50] awjr: yes [01:18:34] preilly: beta_application.js gets loaded by the same ApplicationTemplate.php right? so all i need to do is fix javascript in beta_application.js? [01:19:04] awjr: that is correct [01:22:02] preilly: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113442 [01:24:09] awjr: one possible issue [01:24:14] ? [01:24:21] awjr: what about escaping? [01:24:40] i believe wfMessage() is safe [01:25:16] awjr: Never use wfMessage like that [01:25:17] awjr: okay, well — let's get this pushed [01:25:21] It returns an object, not a string [01:25:41] It looks like you want wfMessage( 'foo' )->text() here [01:25:46] awjr: actually you shouldn't use wfMessage( 'mobile-frontend-show-button' ), [01:25:53] RoanKattouw: interesting, seems to work [01:25:55] Escaping should be handled by whatever processes that array into JSON [01:26:04] Yeah, probably because there's nothing weird in there [01:26:17] awjr: it should be self::$messages['mobile-frontend-show-button'] [01:26:42] ->plain() does no processing, ->text() does magic word expansion (plural etc), ->escaped() does text but HTML-escaped, and ->parse() parses it and returns HTML [01:26:49] One of those is the default but I forget which one [01:26:55] interesting ok [01:26:57] ah ok preilly: is that escaped already? [01:27:08] (default as in __toString() calls one of those) [01:27:24] awjr: that is where we store all the messages [01:27:40] awjr: after the getMsg method call [01:28:16] preilly: ok cool - do i need to htmlspecialchars that? [01:28:29] awjr: I would to be extra safe [01:29:08] awjr: or, htmlentities( $this->data['messages']['mobile-frontend-show-button'], ENT_QUOTES ); [01:29:17] awjr: or whatever [01:32:33] awjr: how's the fix coming along? [01:33:04] preilly: r113444 [01:33:26] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113444 [01:33:30] zomg [01:33:30] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113444 [01:33:31] awjr: ok'ed [01:33:43] awjr: why zomg? [01:33:52] accidental double paste [01:34:10] awjr: okay, can you get it merged and pushed [01:34:21] awjr: then we need binasher to flush the cache [01:34:21] preilly doing it now [01:36:30] k pushing now [01:39:28] awjr: I'm still getting the old JS [01:39:36] preilly try now [01:39:58] awjr: still [01:40:26] oh, cache flush? [01:40:29] awjr: I see var showText = "Anzeigen"; var hideText = "Ausblenden"; [01:40:39] awjr: but, the JS is the old one [01:40:47] awjr: did you up the version number on the JS? [01:41:18] preilly, i did [01:41:33] awjr: try it again [01:41:37] does the js get cached in the varnish cache? [01:41:45] awjr: no it's cached in bits [01:42:16] awjr: did you sync ApplicationTemplate before the JS file? [01:42:32] i scap'd [01:42:43] awjr: yeah, that is the issue [01:42:52] ah ok one sec [01:42:58] awjr: you need to push the js file before the application template [01:43:07] awjr: you will need to up the version number again [01:43:24] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113447 [01:43:42] preilly ^ [01:43:54] awjr: ok'ed it [01:45:18] ok sync'd [01:45:30] looks good to me [01:45:34] preilly ^ [01:47:02] awjr: okay, looks good [01:47:09] phew [01:47:11] binasher: can you flush the cache [01:47:38] awjr: thanks, for getting that fixed so quickly [01:47:38] you know it's been a while since i've done extension development when i forget the right function to use for fetching MW messages... [01:47:43] np [01:47:59] awjr: ha ha [01:49:25] awjr: so, did your use format change get pushed as well? [01:49:35] i hope not [01:49:43] preilly: shouldn't have, i cherry-picked the changes [01:49:59] awjr: okay, cool — just making sure [01:50:54] preilly: yeah, it didnt make it in [01:50:55] awjr: should we update the mobile deployment page that you created to show that it's all pushed live? [01:51:07] preilly: sure i can do that [01:51:41] done [01:51:58] preilly: do you guys normally update the software deployment page also after a deploy? [01:52:19] awjr: not really but, it probably wouldn't hurt [01:56:41] preilly: thanks for all the guidance. nothing like things going wrong during a deployment to help understand the codebase better :p [01:56:56] awjr: ha ha np [01:57:54] ok im gonna go afk for a while but i'll be close by. call me if something explodes [01:58:06] awjr: sounds good [01:58:14] awjr: thanks, again for doing the deployment [01:58:22] preilly no problem [02:13:44] * tfinc checks back in [02:13:49] how'd it go? [02:21:43] preilly just gave me the update [09:49:19] [PageImages] MaxSem pushed 1 new commit to master: http://git.io/BYZAaA [09:49:19] [PageImages/master] bump limit to match the number of search results - Max Semenik [11:28:43] MaxSem, I have a problem with https://it.wikiquote.org/w/api.php?action=featuredfeed&feed=qotd&feedformat=atom [11:29:05] yes? [11:29:11] When I try to import the feed elsewhere, some parts, namely the heading letter (image put via math), is dropped [11:29:26] (I think it was reported for Facebook feeds) [11:30:15] besides dropping the \mathfrak, what can I do for the image to be recognized as text? [11:30:18] it's due to protocol-relative URLs [11:30:48] oh [11:31:00] otherwise the image would be included? [11:31:04] yes [11:31:15] sane cleients work just fine [11:31:22] *clients [11:31:31] even with math images? [11:31:51] does an alt= text help? and if yes how to add it to math? [11:37:58] yes, I see the images in FF and Opera [11:38:09] not sure about alt [11:38:43] alt for math images is their LaTeX formula [11:52:56] MaxSem, https://www.facebook.com/pages/Wikimedia-Italia/123039357707507 for what I mean [12:26:31] Nemo_bis, report it to Facebook [12:27:31] MaxSem, ok, but where is the error exactly? that they don't handle protocol-relative URLs? [12:28:06] yes [12:28:37] ok, thank you! [15:34:08] [WikipediaMobile] jdlrobson pushed 1 new commit to master: http://git.io/lL6zUw [15:34:08] [WikipediaMobile/master] Remove hard to hit close button from popup - YuviPanda [15:34:32] Project WikipediaMobile - Nightly builds build #225: SUCCESS in 13 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/225/ [15:34:33] jdlrobson: Remove hard to hit close button from popup [16:50:19] hallo. [16:50:53] something is badly broken in the mobile Hebrew Wikipedia: http://he.m.wikipedia.org/wiki/ASCII [16:51:00] see the expand buttons [16:54:03] preilly? buehler? [17:00:49] MaxSem, jdlrobson (why not...) [17:00:54] ^ [17:01:48] * jdlrobson looks [17:02:02] mm [17:05:28] something strange is happening with passing the translated label [17:12:06] okk i've identified the bug aharoni.. [17:12:30] cool. [17:12:33] thanks. [17:12:39] lots of people reported it. [17:12:47] can it affect other languages? [17:13:37] possibly... i'm not a php expert but there is a function htmlentities that doesn't seem to be able to handle non western alphabets so it's very possible [17:14:27] same problem here :S http://ja.wikipedia.org/w/index.php?title=ASCII&useformat=mobile [17:15:52] jdlrobson: fileabug? that sounds like a clearly MW one. [17:16:02] yep i am as we speak [17:16:10] hoping we can fix it when SF wakes up [17:16:37] [17:17:19] on it [17:18:35] https://bugzilla.wikimedia.org/show_bug.cgi?id=35086 [17:18:56] thanks MaxSem [17:19:03] and thanks aharoni for bringing it to our attention! [17:19:16] http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/MobileFrontend/templates/ApplicationTemplate.php?r1=113443&r2=113444& < MaxSem [17:20:33] cool, thank you all [17:31:26] hahaha MaxSem you beat me to fixing that issue [17:31:34] :P [17:31:54] we need a real skin [17:32:28] what's weird is i thought that htmlspecialchars handled utf8 correctly by default. perhaps it was being double encoded [17:34:04] is it going to be deployed any time soon? [17:34:43] aharoni: lemme double check the deployment calendar and get the revision reviewed - i might be able to get it out in the next 15 minutes or so [17:34:48] MaxSem also ^ [17:39:33] aharoni, MaxSem: i'm going to push out the change in a minute [17:40:45] tnanks [17:41:27] aharoni, MaxSem: fix deployed [17:42:33] whee [17:47:01] \o/ [17:47:24] what have we decided about mobile QA? :P [17:54:10] MaxSem, awjr - i still don't see it. caching? [17:54:29] hold shift and refresh [17:54:46] likely to be caching aharoni [17:57:56] any luck aharoni ? [17:58:17] aharoni: likely caching. we might need to wait for asher to get in to get the varnish cache cleared [17:58:52] greetings all [17:59:03] hi [17:59:32] Greetings human [17:59:34] MaxSem: yuvipanda jdlrobson awjr : ready for the stand up ? [17:59:35] hehe [17:59:39] yup [17:59:50] yes [17:59:56] yessir [18:00:11] no sign of preilly .. hopefully he'll join mid way [18:02:07] those funky &usethis=that URLs don't get purged [18:07:37] tfinc did you want to chat about the designs now? [18:07:50] preilly: good idea though, let me see if I can do trains on monday :P [18:08:17] yuvipanda, you could add RSS of your travels) [18:08:31] MaxSem: should [18:08:58] MaxSem: all photosharing sites suck, so waiting to figure one out [18:09:03] jdlrobson: sure [18:09:10] have notes in a truecrypt volume though [18:09:29] * tfinc pulls up the list of designs [18:09:56] tfinc: also, would those designs be coming to the app too? [18:10:07] we should be able to reuse jon's work... [18:10:10] yuvipanda: well you do screen scare our site ;) [18:10:17] srcape* [18:10:24] although i do like the term screen scare [18:10:35] jdlrobson: so Full-screen_search [18:10:45] that'll be the first thing to go for 1.2 :) [18:10:47] you'll see that there are two kinds of mockups for search [18:11:14] one is a cleanup for the search results screen [18:11:28] two is a new feature that allows you to see previews of search results when you tap on an item [18:11:35] yep [18:11:52] lets do #1 for now [18:11:57] get it out onto the beta [18:11:59] and see how it does [18:12:08] k [18:12:27] we can hold on #2 for now. not that i don't want to do it (it looks really interesting to test) but i want to break this up into small chunks [18:12:43] the previews are already provided by the api though and available -we could show those under the items without needing a touch... [18:13:29] jdlrobson: yes, i can see that. we also don't know if its worth making our users tap twice. sometimes it'll be great because their answer will be right there. other times its going to be annoying [18:13:41] thus we need to test [18:13:44] it doesn't feel like it would be very discoverable.. [18:14:02] jdlrobson: exactly. which is why i don't want to put it into this push yet [18:14:09] i lied. there is a third mockups on those designs [18:14:10] did you mean [18:14:20] oh yes i did see that too [18:14:23] mockup* [18:14:33] and am I right in thinking we will be abandoning the complete search button? [18:14:40] (the existing +) [18:15:04] its holding for now. i doubt that it'll make it out of beta any time soon due to our data set [18:15:14] i still really like it but we need better full text search for it to be truly awesome [18:15:35] true [18:16:07] so thats full screen search. a cleanup of our existing beta that will go into testing. i think its the best experience yet <-- gets into steve jobs mode :D [18:16:08] haha [18:16:09] so i should probably remove it for the time being [18:16:18] sure [18:16:24] np [18:17:10] ok next design [18:17:30] contact us [18:17:47] now this one is going to be interesting as it replaces an existing wiki page [18:18:09] yes [18:18:23] the mock-ups are in transition on that [18:18:25] jdlrobson: i don't know if you've seen our current contact page on mobile but i think its god awful. http://en.wikipedia.org/w/index.php?title=Wikipedia:Contact_us&useformat=mobile [18:18:41] a little delayed because of Philippe and Heather [18:19:04] the idea is to make it mobile friendly and provide our users with an actual communication path to us from a mobile device [18:19:06] thats the push [18:19:14] it seems like this could be a separate page no? [18:19:33] jdlrobson: yes, it is a separate page [18:19:36] now these mockups aren't 100% ready as phil said. the select drop downs don't make much sense in their latest rev as most mobile os use the full screen for a listing [18:19:42] there is no option for sub menus like this [18:20:00] we will make it one list [18:20:20] the way that i look at it is that we will streamline this for mobile .. and then the desktop will want it [18:20:27] but we can't make that decision for them [18:20:46] now one really important point about this feature is that you'll notice it has a nav at the top [18:20:53] don't implement the nav yet [18:21:09] ignore it for now. its there for us to think about it but were not 100% sure whats its going to look like [18:21:38] i'm happy with trying out the contact form as wiki page but not he nav yet [18:21:45] we still have to rev that a couple more times [18:21:53] jdlrobson: does that make sense ? [18:22:13] by the nav you mean the search box and wikipedia icon? [18:22:20] yes [18:22:24] so its basically Contact us downwards [18:22:28] yes [18:22:48] great [18:22:58] and to me it mostly looks like just wikitext editing rather then MF work. what we need to figure out is how to trigger the mobile version for our users [18:23:08] ok next design [18:23:10] the footer [18:23:24] our current footer is ugly and useless as hell [18:23:36] we can clean this up really easily [18:23:37] tfinc: and to me it mostly looks like just wikitext editing rather then MF work. what we need to figure out is how to trigger the mobile version for our users < i'm not sure I follow.. could this not be a special page ? [18:23:52] jdlrobson: yup, it could be [18:23:54] with configuration options in the MobileFrontend extension (e.g. email address, options) [18:24:04] yes [18:24:07] k great [18:24:19] back to the footer [18:24:25] sorry just butting in here, I tried to access test.wikipedia.org on my iPhone [18:24:33] and it can't find the page [18:24:37] its been totally redesigned and cleanup up [18:24:40] something wrong with the mobile access there? [18:24:55] awjr: preilly .. can you help out Thehelpfulone [18:25:20] jdlrobson: it'll sit at the bottom and be expandable [18:25:23] meh, I liked back to the footer II best [18:25:25] okay [18:25:46] jdlrobson: the footer will now link to the same destinations as the desktop site [18:25:55] including our new contact page [18:26:01] preilly: I get a "Cannot Open Page" error [18:26:04] Thehelpfulone, preilly I think I know what the problem is - test is being redirected to test.m.wikipedia.org, which does not exist [18:26:12] "Safari cannot open the page because the server cannot be found" [18:26:13] i can probably fix it with a config change [18:26:15] ah [18:26:21] lemme take a look [18:26:25] Thehelpfulone: yeah, you need to add a hosts entry for now for that [18:26:26] jdlrobson: privacy, about, disclaimer already exist and or decent in their mobile rendering [18:26:26] if you could please :) [18:26:36] tfinc what powers the footer as on my local copy I only have 'Contact us' [18:26:51] preilly: do you know which of our properties actually has a .m domain? [18:26:53] thus I'm assuming you can add as many links here as possible [18:27:14] jdlrobson: yes. its just a mediawiki:blah blah [18:27:30] i really think the new styling will work better for our users [18:27:44] and it builds on the same look and feel we have with our overall design [18:28:03] does the new footer make sense? [18:28:40] jdlrobson: --^ [18:28:42]