[00:00:01] yes :( [00:00:30] preilly: iirc that was not a problem before, correct? it was just a problem when you'd hit 'enter' or click the search icon? [00:00:53] awjr: the links are wrong in suggestions-results [00:01:48] preilly: indeed they are [00:02:09] preilly: where do those links get generated? [00:02:22] awjr: it's in the javascript [00:02:28] ahha [00:02:46] awjr: line 130 of opensearch.js [00:02:48] ok yuvipanda sent the link to 4 of my friends :) [00:02:59] Astagi: sweeet! :D [00:03:00] thanks! [00:03:16] oh btw yuvipanda one of my friends is receiving blackberry playbook [00:03:27] oh? [00:03:30] it's possible to run android apps in that device [00:03:45] I could ask to pack wikipedia and try :) [00:03:47] Astagi: brion merged in code to let us ron on the playbook [00:03:48] *run [00:03:49] sure! [00:04:00] Astagi: we even merged in a pull request a few days ago that made it easier! [00:04:03] test it out! [00:04:16] oh nice yuvipanda didn't know it :) [00:04:22] ok :) [00:04:36] :D [00:07:52] preilly: i see so we need to add some way for the javascript to transform the url returned by opensearch to the $wgMobileUrlTemplate [00:08:14] yuvipanda: ipa sent [00:08:22] tfinc: thanks! [00:08:47] awjr: we need to convert the absolute path to relative [00:08:47] i wonder how brion is doing with the playbook code [00:09:25] preilly: even better [00:09:29] is this critical to fix now? [00:09:35] awjr: YES [00:10:00] k i need to coordinate with folks about the meeting im supposed to be in gimme a min [00:12:11] preilly: hows the zero push going? [00:12:58] awjr: we can do something like str.replace(/^(?:\/\/|[^\/]+)*\//, "") [00:13:04] tfinc: search bug [00:13:08] k [00:13:30] i read that as an issue with the MF push [00:18:23] yes [00:23:27] yuvipanda: http://phonegap.com/2012/03/06/phonegap-1-5-released/ [00:23:53] tfinc: saw that a day ago. [00:24:01] anything that were excited to pickup ? [00:24:22] am wary of upgrading this late in the release cycle [00:24:25] it's a pretty big change [00:25:06] so I'd want to not upgrade until 1.1 is out the door [00:27:54] awjr: I think I've got a fix for it [00:28:00] awjr: I just pushed it [00:28:06] preilly: awesome [00:28:19] pushed in trunk or to the cluster? [00:28:26] awjr: cluster [00:28:34] awjr: I changed it to link.setAttribute( 'href', section.value.replace( /^(?:\/\/|[^\/]+)*\//, '/' ) ); [00:28:53] yuvipanda: dont upgrade it [00:29:03] yup. not doing it. [00:29:08] we can do in the next minor release [00:29:15] awjr: can you refresh a page and try the search again [00:29:15] preilly: cool - i was trying something similar but not seeing proper results in my local instance [00:29:29] yeah trying now [00:29:40] preilly looks good [00:30:40] oh jeez i was editing the a different opensearch.js than the one in my docroot >_< [00:31:02] ok preilly, anything else? [00:32:56] awjr: I'm fixing it for beta now too [00:33:47] cool [00:33:48] awjr: okay, I think we are good [00:33:50] nice work [00:33:55] awjr: np [00:34:35] awjr: can you review these: https://www.mediawiki.org/w/index.php?path=%2Ftrunk%2Fextensions%2FMobileFrontend&title=Special%3ACode%2FMediaWiki%2Fstatus%2Fnew&limit=100 [00:37:10] preilly: done [00:38:06] awjr: thanks! [00:38:12] np [00:38:17] svn di [00:38:19] oops [00:40:03] awjr: what was that? [00:40:06] binasher: http://my.zero.wikipedia.org/wiki/%E1%80%99%E1%80%BC%E1%80%94%E1%80%BA%E1%80%99%E1%80%AC%E1%80%B7%E1%80%85%E1%80%80%E1%80%B9%E1%80%80%E1%80%B0%E1%80%94%E1%80%BE%E1%80%84%E1%80%B7%E1%80%BA%E1%80%93%E1%80%AC%E1%80%90%E1%80%AF%E1%80%97%E1%80%B1%E1%80%92%E1%80%9C%E1%80%AF%E1%80%95%E1%80%BA%E1%80%84%E1%80%94%E1%80%BA%E1%80%B8 [00:40:24] preilly: me trying to do 'svn di' on a working dir :p [00:50:15] awjr: found another bug [00:50:34] preilly: ? [00:51:01] awjr: show/hide are only in English [00:51:07] awjr: on all wikis! [00:51:16] shitsandwich [00:52:24] preilly presumably because of label = document.createTextNode( visible ? 'Show' : 'Hide' ); ? [00:52:38] in application.js [00:53:02] awjr: yeah, label = document.createTextNode( visible ? 'Show' : 'Hide' ); is the issue [00:53:03] how do you handle translations for text generated in js w/o resource loader? [00:53:27] awjr: you've got to pass it globally [00:54:07] awjr: like in ApplicationTemplate [00:54:30] oic [00:54:50] awjr: do you want to make the change or should I? [00:54:59] let me take a stab at it [00:55:13] awjr: okay [00:55:59] this menu race condition is going to take more of my life. gnite for the day. [00:56:25] awjr: you should add the data in the getApplicationTemplate method in MobileFrontend.body [00:56:41] ah thanks was just chasing that down [00:56:56] awjr: with these two keys 'mobile-frontend-show-button', 'mobile-frontend-hide-button', [00:57:38] awjr: do you have the yuicompressor-2.4.6.jar file locally? [00:57:44] i do not [00:57:54] awjr: you will need that to run make [00:58:05] awjr: to create the minified version [00:58:39] awjr: you can get it from http://www.java2s.com/Code/JarDownload/yuicompressor/yuicompressor-2.4.6.jar.zip [00:59:09] awjr: place the unzip'ed file in phase3/extensions/MobileFrontend$ (or, whatever your trunk copy of MobileFrontend is) [00:59:23] awjr: then run make after your JS changes are complete [01:04:24] preilly: semi off-topic is MF mobile view rendering slow for you locally? it's slow as hell for me which makes testing take forever [01:04:49] awjr: do you have memcache installed and configured locally? [01:04:53] preilly: no [01:04:59] awjr: well that is the issue [01:05:09] awjr: are you running Ubuntu? [01:05:20] preilly: more on topic, how do i get the section buttons to show? i have sections set up on an article, but i take it there's more i need to do [01:05:21] i am [01:05:57] awjr: sudo apt-get install memcached [01:06:05] awjr: then in LocalSettings.php [01:06:15] awjr: $wgMemCachedPersistent = true; [01:06:15] $wgUseMemCached = true; [01:06:17] $wgMainCacheType = CACHE_MEMCACHED; [01:06:18] $wgMemCachedTimeout = 500000; [01:06:19] $wgMemCachedInstanceSize = 2000; [01:06:20] $wgMemCachedServers = array('127.0.0.1:11211'); [01:06:53] awjr: the sections buttons should show on a page with sections and is greater than 4000 characters [01:07:02] k thnx [01:11:19] awjr: how's it coming along? [01:12:50] preilly: good - just realized wasn't working because it's looking for minified js [01:13:24] awjr: did you grab the http://www.java2s.com/Code/JarDownload/yuicompressor/yuicompressor-2.4.6.jar.zip and unzip and run make to create a new minified file? [01:13:41] ok it's working [01:13:49] preilly: doing that now [01:17:30] preilly: ok i have minified application.js [01:17:37] i presume i need to make the same change for beta? [01:17:50] awjr: yes [01:18:34] preilly: beta_application.js gets loaded by the same ApplicationTemplate.php right? so all i need to do is fix javascript in beta_application.js? [01:19:04] awjr: that is correct [01:22:02] preilly: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113442 [01:24:09] awjr: one possible issue [01:24:14] ? [01:24:21] awjr: what about escaping? [01:24:40] i believe wfMessage() is safe [01:25:16] awjr: Never use wfMessage like that [01:25:17] awjr: okay, well — let's get this pushed [01:25:21] It returns an object, not a string [01:25:41] It looks like you want wfMessage( 'foo' )->text() here [01:25:46] awjr: actually you shouldn't use wfMessage( 'mobile-frontend-show-button' ), [01:25:53] RoanKattouw: interesting, seems to work [01:25:55] Escaping should be handled by whatever processes that array into JSON [01:26:04] Yeah, probably because there's nothing weird in there [01:26:17] awjr: it should be self::$messages['mobile-frontend-show-button'] [01:26:42] ->plain() does no processing, ->text() does magic word expansion (plural etc), ->escaped() does text but HTML-escaped, and ->parse() parses it and returns HTML [01:26:49] One of those is the default but I forget which one [01:26:55] interesting ok [01:26:57] ah ok preilly: is that escaped already? [01:27:08] (default as in __toString() calls one of those) [01:27:24] awjr: that is where we store all the messages [01:27:40] awjr: after the getMsg method call [01:28:16] preilly: ok cool - do i need to htmlspecialchars that? [01:28:29] awjr: I would to be extra safe [01:29:08] awjr: or, htmlentities( $this->data['messages']['mobile-frontend-show-button'], ENT_QUOTES ); [01:29:17] awjr: or whatever [01:32:33] awjr: how's the fix coming along? [01:33:04] preilly: r113444 [01:33:26] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113444 [01:33:30] zomg [01:33:30] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113444 [01:33:31] awjr: ok'ed [01:33:43] awjr: why zomg? [01:33:52] accidental double paste [01:34:10] awjr: okay, can you get it merged and pushed [01:34:21] awjr: then we need binasher to flush the cache [01:34:21] preilly doing it now [01:36:30] k pushing now [01:39:28] awjr: I'm still getting the old JS [01:39:36] preilly try now [01:39:58] awjr: still [01:40:26] oh, cache flush? [01:40:29] awjr: I see var showText = "Anzeigen"; var hideText = "Ausblenden"; [01:40:39] awjr: but, the JS is the old one [01:40:47] awjr: did you up the version number on the JS? [01:41:18] preilly, i did [01:41:33] awjr: try it again [01:41:37] does the js get cached in the varnish cache? [01:41:45] awjr: no it's cached in bits [01:42:16] awjr: did you sync ApplicationTemplate before the JS file? [01:42:32] i scap'd [01:42:43] awjr: yeah, that is the issue [01:42:52] ah ok one sec [01:42:58] awjr: you need to push the js file before the application template [01:43:07] awjr: you will need to up the version number again [01:43:24] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113447 [01:43:42] preilly ^ [01:43:54] awjr: ok'ed it [01:45:18] ok sync'd [01:45:30] looks good to me [01:45:34] preilly ^ [01:47:02] awjr: okay, looks good [01:47:09] phew [01:47:11] binasher: can you flush the cache [01:47:38] awjr: thanks, for getting that fixed so quickly [01:47:38] you know it's been a while since i've done extension development when i forget the right function to use for fetching MW messages... [01:47:43] np [01:47:59] awjr: ha ha [01:49:25] awjr: so, did your use format change get pushed as well? [01:49:35] i hope not [01:49:43] preilly: shouldn't have, i cherry-picked the changes [01:49:59] awjr: okay, cool — just making sure [01:50:54] preilly: yeah, it didnt make it in [01:50:55] awjr: should we update the mobile deployment page that you created to show that it's all pushed live? [01:51:07] preilly: sure i can do that [01:51:41] done [01:51:58] preilly: do you guys normally update the software deployment page also after a deploy? [01:52:19] awjr: not really but, it probably wouldn't hurt [01:56:41] preilly: thanks for all the guidance. nothing like things going wrong during a deployment to help understand the codebase better :p [01:56:56] awjr: ha ha np [01:57:54] ok im gonna go afk for a while but i'll be close by. call me if something explodes [01:58:06] awjr: sounds good [01:58:14] awjr: thanks, again for doing the deployment [01:58:22] preilly no problem [02:13:44] * tfinc checks back in [02:13:49] how'd it go? [02:21:43] preilly just gave me the update [09:49:19] [PageImages] MaxSem pushed 1 new commit to master: http://git.io/BYZAaA [09:49:19] [PageImages/master] bump limit to match the number of search results - Max Semenik [11:28:43] MaxSem, I have a problem with https://it.wikiquote.org/w/api.php?action=featuredfeed&feed=qotd&feedformat=atom [11:29:05] yes? [11:29:11] When I try to import the feed elsewhere, some parts, namely the heading letter (image put via math), is dropped [11:29:26] (I think it was reported for Facebook feeds) [11:30:15] besides dropping the \mathfrak, what can I do for the image to be recognized as text? [11:30:18] it's due to protocol-relative URLs [11:30:48] oh [11:31:00] otherwise the image would be included? [11:31:04] yes [11:31:15] sane cleients work just fine [11:31:22] *clients [11:31:31] even with math images? [11:31:51] does an alt= text help? and if yes how to add it to math? [11:37:58] yes, I see the images in FF and Opera [11:38:09] not sure about alt [11:38:43] alt for math images is their LaTeX formula [11:52:56] MaxSem, https://www.facebook.com/pages/Wikimedia-Italia/123039357707507 for what I mean [12:26:31] Nemo_bis, report it to Facebook [12:27:31] MaxSem, ok, but where is the error exactly? that they don't handle protocol-relative URLs? [12:28:06] yes [12:28:37] ok, thank you! [15:34:08] [WikipediaMobile] jdlrobson pushed 1 new commit to master: http://git.io/lL6zUw [15:34:08] [WikipediaMobile/master] Remove hard to hit close button from popup - YuviPanda [15:34:32] Project WikipediaMobile - Nightly builds build #225: SUCCESS in 13 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/225/ [15:34:33] jdlrobson: Remove hard to hit close button from popup [16:50:19] hallo. [16:50:53] something is badly broken in the mobile Hebrew Wikipedia: http://he.m.wikipedia.org/wiki/ASCII [16:51:00] see the expand buttons [16:54:03] preilly? buehler? [17:00:49] MaxSem, jdlrobson (why not...) [17:00:54] ^ [17:01:48] * jdlrobson looks [17:02:02] mm [17:05:28] something strange is happening with passing the translated label [17:12:06] okk i've identified the bug aharoni.. [17:12:30] cool. [17:12:33] thanks. [17:12:39] lots of people reported it. [17:12:47] can it affect other languages? [17:13:37] possibly... i'm not a php expert but there is a function htmlentities that doesn't seem to be able to handle non western alphabets so it's very possible [17:14:27] same problem here :S http://ja.wikipedia.org/w/index.php?title=ASCII&useformat=mobile [17:15:52] jdlrobson: fileabug? that sounds like a clearly MW one. [17:16:02] yep i am as we speak [17:16:10] hoping we can fix it when SF wakes up [17:16:37] [17:17:19] on it [17:18:35] https://bugzilla.wikimedia.org/show_bug.cgi?id=35086 [17:18:56] thanks MaxSem [17:19:03] and thanks aharoni for bringing it to our attention! [17:19:16] http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/MobileFrontend/templates/ApplicationTemplate.php?r1=113443&r2=113444& < MaxSem [17:20:33] cool, thank you all [17:31:26] hahaha MaxSem you beat me to fixing that issue [17:31:34] :P [17:31:54] we need a real skin [17:32:28] what's weird is i thought that htmlspecialchars handled utf8 correctly by default. perhaps it was being double encoded [17:34:04] is it going to be deployed any time soon? [17:34:43] aharoni: lemme double check the deployment calendar and get the revision reviewed - i might be able to get it out in the next 15 minutes or so [17:34:48] MaxSem also ^ [17:39:33] aharoni, MaxSem: i'm going to push out the change in a minute [17:40:45] tnanks [17:41:27] aharoni, MaxSem: fix deployed [17:42:33] whee [17:47:01] \o/ [17:47:24] what have we decided about mobile QA? :P [17:54:10] MaxSem, awjr - i still don't see it. caching? [17:54:29] hold shift and refresh [17:54:46] likely to be caching aharoni [17:57:56] any luck aharoni ? [17:58:17] aharoni: likely caching. we might need to wait for asher to get in to get the varnish cache cleared [17:58:52] greetings all [17:59:03] hi [17:59:32] Greetings human [17:59:34] MaxSem: yuvipanda jdlrobson awjr : ready for the stand up ? [17:59:35] hehe [17:59:39] yup [17:59:50] yes [17:59:56] yessir [18:00:11] no sign of preilly .. hopefully he'll join mid way [18:02:07] those funky &usethis=that URLs don't get purged [18:07:37] tfinc did you want to chat about the designs now? [18:07:50] preilly: good idea though, let me see if I can do trains on monday :P [18:08:17] yuvipanda, you could add RSS of your travels) [18:08:31] MaxSem: should [18:08:58] MaxSem: all photosharing sites suck, so waiting to figure one out [18:09:03] jdlrobson: sure [18:09:10] have notes in a truecrypt volume though [18:09:29] * tfinc pulls up the list of designs [18:09:56] tfinc: also, would those designs be coming to the app too? [18:10:07] we should be able to reuse jon's work... [18:10:10] yuvipanda: well you do screen scare our site ;) [18:10:17] srcape* [18:10:24] although i do like the term screen scare [18:10:35] jdlrobson: so Full-screen_search [18:10:45] that'll be the first thing to go for 1.2 :) [18:10:47] you'll see that there are two kinds of mockups for search [18:11:14] one is a cleanup for the search results screen [18:11:28] two is a new feature that allows you to see previews of search results when you tap on an item [18:11:35] yep [18:11:52] lets do #1 for now [18:11:57] get it out onto the beta [18:11:59] and see how it does [18:12:08] k [18:12:27] we can hold on #2 for now. not that i don't want to do it (it looks really interesting to test) but i want to break this up into small chunks [18:12:43] the previews are already provided by the api though and available -we could show those under the items without needing a touch... [18:13:29] jdlrobson: yes, i can see that. we also don't know if its worth making our users tap twice. sometimes it'll be great because their answer will be right there. other times its going to be annoying [18:13:41] thus we need to test [18:13:44] it doesn't feel like it would be very discoverable.. [18:14:02] jdlrobson: exactly. which is why i don't want to put it into this push yet [18:14:09] i lied. there is a third mockups on those designs [18:14:10] did you mean [18:14:20] oh yes i did see that too [18:14:23] mockup* [18:14:33] and am I right in thinking we will be abandoning the complete search button? [18:14:40] (the existing +) [18:15:04] its holding for now. i doubt that it'll make it out of beta any time soon due to our data set [18:15:14] i still really like it but we need better full text search for it to be truly awesome [18:15:35] true [18:16:07] so thats full screen search. a cleanup of our existing beta that will go into testing. i think its the best experience yet <-- gets into steve jobs mode :D [18:16:08] haha [18:16:09] so i should probably remove it for the time being [18:16:18] sure [18:16:24] np [18:17:10] ok next design [18:17:30] contact us [18:17:47] now this one is going to be interesting as it replaces an existing wiki page [18:18:09] yes [18:18:23] the mock-ups are in transition on that [18:18:25] jdlrobson: i don't know if you've seen our current contact page on mobile but i think its god awful. http://en.wikipedia.org/w/index.php?title=Wikipedia:Contact_us&useformat=mobile [18:18:41] a little delayed because of Philippe and Heather [18:19:04] the idea is to make it mobile friendly and provide our users with an actual communication path to us from a mobile device [18:19:06] thats the push [18:19:14] it seems like this could be a separate page no? [18:19:33] jdlrobson: yes, it is a separate page [18:19:36] now these mockups aren't 100% ready as phil said. the select drop downs don't make much sense in their latest rev as most mobile os use the full screen for a listing [18:19:42] there is no option for sub menus like this [18:20:00] we will make it one list [18:20:20] the way that i look at it is that we will streamline this for mobile .. and then the desktop will want it [18:20:27] but we can't make that decision for them [18:20:46] now one really important point about this feature is that you'll notice it has a nav at the top [18:20:53] don't implement the nav yet [18:21:09] ignore it for now. its there for us to think about it but were not 100% sure whats its going to look like [18:21:38] i'm happy with trying out the contact form as wiki page but not he nav yet [18:21:45] we still have to rev that a couple more times [18:21:53] jdlrobson: does that make sense ? [18:22:13] by the nav you mean the search box and wikipedia icon? [18:22:20] yes [18:22:24] so its basically Contact us downwards [18:22:28] yes [18:22:48] great [18:22:58] and to me it mostly looks like just wikitext editing rather then MF work. what we need to figure out is how to trigger the mobile version for our users [18:23:08] ok next design [18:23:10] the footer [18:23:24] our current footer is ugly and useless as hell [18:23:36] we can clean this up really easily [18:23:37] tfinc: and to me it mostly looks like just wikitext editing rather then MF work. what we need to figure out is how to trigger the mobile version for our users < i'm not sure I follow.. could this not be a special page ? [18:23:52] jdlrobson: yup, it could be [18:23:54] with configuration options in the MobileFrontend extension (e.g. email address, options) [18:24:04] yes [18:24:07] k great [18:24:19] back to the footer [18:24:25] sorry just butting in here, I tried to access test.wikipedia.org on my iPhone [18:24:33] and it can't find the page [18:24:37] its been totally redesigned and cleanup up [18:24:40] something wrong with the mobile access there? [18:24:55] awjr: preilly .. can you help out Thehelpfulone [18:25:20] jdlrobson: it'll sit at the bottom and be expandable [18:25:23] meh, I liked back to the footer II best [18:25:25] okay [18:25:46] jdlrobson: the footer will now link to the same destinations as the desktop site [18:25:55] including our new contact page [18:26:01] preilly: I get a "Cannot Open Page" error [18:26:04] Thehelpfulone, preilly I think I know what the problem is - test is being redirected to test.m.wikipedia.org, which does not exist [18:26:12] "Safari cannot open the page because the server cannot be found" [18:26:13] i can probably fix it with a config change [18:26:15] ah [18:26:21] lemme take a look [18:26:25] Thehelpfulone: yeah, you need to add a hosts entry for now for that [18:26:26] jdlrobson: privacy, about, disclaimer already exist and or decent in their mobile rendering [18:26:26] if you could please :) [18:26:36] tfinc what powers the footer as on my local copy I only have 'Contact us' [18:26:51] preilly: do you know which of our properties actually has a .m domain? [18:26:53] thus I'm assuming you can add as many links here as possible [18:27:14] jdlrobson: yes. its just a mediawiki:blah blah [18:27:30] i really think the new styling will work better for our users [18:27:44] and it builds on the same look and feel we have with our overall design [18:28:03] does the new footer make sense? [18:28:40] jdlrobson: --^ [18:28:42] yep i guess i just need to understand how the customisations work here [18:28:55] yup [18:29:02] anyone on the team should be able to help you with that [18:29:16] and that takes us to the last design in the email .. reference reveal [18:29:26] the idea from this came from an app from appture (google bought them) [18:29:49] they made references on wikipedia not horrible [18:29:57] yeh i like this idea [18:30:01] it's very nice [18:30:09] tap ref number and the ref pops at the bottom. tap the x and it goes away [18:30:15] yep [18:30:18] its so simple [18:30:25] now you'll see lots of options from the renderings [18:30:56] my fav are rendering #1 and #3 [18:31:02] but to me they both have a problem [18:31:17] were wasting space on saying "Reference #1" for no good reason [18:31:41] until we have a reason i say we just … show the reference [18:31:51] and then we'll see what our users say [18:32:16] mm [18:32:21] once we get it wired and working then it'll become clear pretty quickly [18:32:42] just as with contact us .. don't worry about the nav bar here [18:32:46] its not done yet [18:33:01] i'm more of a fan of the design 4 to be honest [18:33:04] were going to do one .. but … were all still discussing it [18:33:19] haha [18:33:24] #4 has all the changes that i just said [18:33:42] with a small #5 [18:33:43] sold [18:33:47] yep [18:33:53] maybe even [5] [18:34:00] since you click on a [5] [18:34:02] to reveal it [18:34:21] so focus on #4 and leave it open for other designs [18:34:26] will do [18:34:33] http://www.mediawiki.org/wiki/File:Mobile_references_C1.png [18:34:46] yes that one [18:34:54] now there is one more design that isn't highlighted in my email but is central to all of is [18:35:27] which is that? [18:35:49] the new collapsable sections [18:35:50] http://www.mediawiki.org/wiki/File:Mobile_article_expand.png [18:35:57] its in all of the designs [18:36:21] and it allows us to trim how much page real estate we lose by saying "expand/collapse" [18:36:28] let alone when we have to translate all that ext [18:36:45] text* [18:36:57] would have helped us today with that bug :) [18:37:12] exactly … this will make our lives easier [18:37:15] it'll clean up the page [18:37:19] and is a general win [18:37:26] agreed [18:37:28] that rounds up all of the new designs [18:37:30] now [18:37:36] jdlrobson: the collapsible arrowhead is a little undecided in terms of which direction it should point in the expanded ad collapsed states [18:37:42] we want to get this into the beta [18:37:52] and we'll want lots of users to tinker and play with it [18:37:58] beta opt in? [18:38:02] the'll love some things and hate others [18:38:03] preilly: ping [18:38:19] beta opt-in is waiting until we have a menu design [18:38:22] thus .. some small things as philinje mentions may change [18:38:27] np [18:38:30] but as a front end dev i'm sure your used to that [18:38:36] so keep the door open for small changes [18:38:39] yep :) [18:38:52] jdlrobson: your opinion on the arrowhead direction would be helpful [18:38:53] but as long as you know the story of WHY were doing it then i'm sure you can anticipate what people might say [18:39:00] thats why i wanted to explain why were doing it [18:39:04] rather then just telling you what were doing [18:39:25] +1 on philinje comment. we want to get you and anyone else involved in these discussions [18:39:37] but before we dive into feedback [18:39:46] any question on the existing 4 designs ? [18:39:49] awjr: pong [18:40:27] jdlrobson: --^ [18:40:33] preilly: which of our properties are actually configured to use a .m. domain? [18:40:38] tfinc no questions at the current time [18:40:43] just pondering the arrow question [18:40:46] jdlrobson: then i've done my job well [18:41:00] awjr: I believe that most are [18:41:21] tfinc: did I forward this conversation? http://en.wiktionary.org/wiki/Wiktionary:Grease_pit#Collapsible_templates.2C_especially_.7B.7Btrans-top.7D.7D [18:41:22] awjr said that he'd be happy to help on the thread. so do let him know where you can use an extra pair of hands [18:41:31] i'm thinking that the contact us special page could be a good one [18:41:39] Amgine: nope [18:41:57] grr... sorry, meant for that to be there. [18:41:59] preilly: but presumably not all that have mobilefrontend enabled, right, such as test? we need to make exceptions for those in the cluster configuration [18:42:05] don't wait on me to schedule anything [18:42:21] awjr: I believe that Wikipedia, Wiktionary, Wikiquote, Wikibooks, Wikisource, Wikispecies, Wikinews, Wikiversity have it enabled [18:43:11] awjr: test has mobilefrontend enabled it just doesn't have the x-device header set because it isn't behind varnish [18:43:37] preilly: right so test.m.wikipedia.org will not work, right? [18:43:47] awjr: test also needs a .m. dns entry [18:43:56] yes tfinc awjr agreed - will let you know when i plan to work on that [18:44:02] jdlrobson: I'm really excited about these changes as it'll be our first dedicated push to polish the look of the site [18:44:05] great [18:44:13] yeh same [18:44:13] awjr: if you ping Ryan_Lane he can create the one off DNS entry pretty easily I think [18:44:19] excited about next week :) [18:44:34] jdlrobson: i'm especially curious to see what our pace is when it comes to change like this [18:44:35] * jdlrobson wonders if a right and down arrow would work best for show/hide toggling [18:44:47] preilly: ok perhaps that's even better than excepting it in the configuration of $wgMobileUrlTemplate [18:45:34] awjr: I just asked Ryan_Lane to look at it and he is checking to see how hard it will be [18:45:44] heatherw: if philinje hasn't asked yet can you forward jdlrobson your graphic assets for full screen search, refs, contactt us, and ref reveal ? [18:45:47] ha ok i asked in #operations as well [18:45:58] awjr: it seems better than adding exclusions to $wgMobileUrlTemplate checks [18:46:31] preilly: for sure, although that is not hard to do either [18:47:29] jdlrobson: how do you want the assets - size, jpg, PhotoShop file? [18:47:37] awjr: just seems a bit hack'ish [18:48:28] preilly: i dunno, i disagree - it's not uncommon to have configuration variables be set differently for the different wikis [18:48:51] good question... i guess psd would be the most flexible? [18:48:52] but, i think we should have test.m.wikipedia.org and ultimately do the varnish magic for it [18:49:09] jdlrobson: let lindsey know what ever you decide on for the assets [18:49:18] she just came up to me asking the same quesiton [18:49:24] question* [18:49:54] linSmith - could you forward me a psd for one of the designs ? [18:51:10] jdlrobson: heather had an accident a couple days ago so I am checking if she is working right now [18:51:44] jdlrobson: since this is our first real big product, design, implantation lets plan on syncing up after two weeks to find out what worked, what didn't, and what we have to change [18:51:49] jdlrobson: so keep notes on the side [18:52:10] k will do [18:53:04] jdlrobson I don't actually have any of the psd files for the designs. So far Heather has worked on all of them. [18:54:24] ahh ok no worries linSmith :) [18:54:26] so let's see if Heather is active today [18:54:31] i won't need them till monday anyway [18:54:38] as i'm just wrapping up here for the day [18:54:51] also remember i'm working SF hours monday [18:54:51] jorm: any news on how heatherw is doing? [18:54:53] so that will help [18:54:56] woot! [18:55:09] i might even work uk hours too ;-) [18:55:10] heather? heather's fine. [18:55:15] didd you mean stacey? [18:55:21] jorm: think she'll be in today? [18:55:33] Thehelpfulone: Ryan_Lane added a dns entry for test.m.wikipedia.org so it should be working. if not, it should be working as soon as the dns changes propagate [18:55:39] i figure if anyone knows it might be you [18:55:50] heather? no. she's taking the day off; it's her birthday. but you can email her. [18:55:53] she was on email yesterday so chances are she will reply soon [18:55:55] so.... [18:56:01] I made the DNS entry, but it goes through squid [18:56:09] does apache even know anything about that domain? [18:56:26] sorry, Heather replied [18:56:37] because it's going to get the host header, and will likely give you back something unexpected [18:57:01] like how it's currently redirecting to incubator [18:57:04] Ryan_Lane: haha like incubator.wikimedia.org, for instance? [18:57:07] yes. [18:57:30] can we get it pointing to test.wikipedia.org? [18:57:35] I dunno [18:57:49] jdlrobson: Heather will reply by email soon [18:57:50] brion: hows the playbook hacking going ? [18:58:00] suuuuuuuck [18:58:08] i'm either almost there or miles away :) [18:58:21] lemme modify squid for you guys [18:58:24] a device from RIM that sucks? You don't say... [18:59:41] awjr: yes the entry seems to be there [18:59:49] but now it will redirect to test.m.wikipedia.org/ [18:59:55] then say page not found ;) [19:00:05] brion: whats exploding? [19:00:21] did you reach out to gtanner ? [19:01:00] brion: did you get your debug tokens? [19:01:13] i got my debug tokens yeah [19:01:23] awjr: were waiting on you in the Pune post mortem meeting [19:01:25] i'm not 100% sure the app is getting marked with the token though, so i'll try hammering at that some more [19:01:25] anyone need anything from me before i stick rebecca black on? [19:01:29] x2005 [19:01:48] * yuvipanda hands jdlrobson a giant cockroach [19:01:56] wow yuvipanda .. wow [19:02:11] * jdlrobson actually loling rather than just writing it [19:02:19] tfinc: yeah the phone system sometimes behaves weidrly with skype... [19:02:56] :D [19:08:01] tfinc, it's a miracle! i got the app installed [19:08:14] so, I have no clue why it redirects to incubator and regular test does not [19:08:19] I don't see apache config for test [19:08:20] doesn't work though ;) [19:08:21] brion: woot! [19:08:24] brion: aww [19:09:16] lemme try a cleaner build [19:10:53] ok that looks better [19:11:12] okay, I've deployed PageImages on mobile-geo [19:11:40] currently running refreshLinks, gonna be super slow:D [19:12:15] did you hear me, API users? :evilgrin: [19:12:23] yes master! [19:12:29] tfinc: philinje 1.2 planning? [19:17:19] yuvipanda: i'm happy to actually wait on 1.2 [19:17:43] and instead focus on zero, sms/ussd, and the mobile web work [19:18:02] the language selection workflow is still being actively discussed [19:18:22] and the last time that i looked the backlog language selection was that the core of 1.2 [19:18:39] the biggest one, yes. [19:20:35] tfinc: the other option is to switch to a bi-weekly ship cycle, where we ship *something* every other week. [19:20:38] The chrome model of sorts [19:20:47] but yes, we'd first have to figure out priorities [19:23:21] tfinc, ok i got a few bugses: https://bugzilla.wikimedia.org/showdependencytree.cgi?id=31976&hide_resolved=1 [19:27:32] so, yeah, I have no clue how to make this test.m crap work [19:28:51] Ryan_Lane: :( [19:29:00] should i open an RT ticket? [19:29:08] yes. I did most of the work [19:29:13] but I don't see how apache is handling this [19:29:15] Ryan_Lane: I've gone ahead and set up a meeting with HR for you [19:29:18] our apache configuration is *so* fucked up [19:29:19] kk thanks for taking a stab at it [19:29:47] tfinc, ok and gtanner says he'll take a look at some of the bugs i found :D \o/ winnnn [19:30:06] Ryan_Lane: can you setup a maps project on labs now? [19:30:09] or today or this weekend [19:30:27] yes! now that we have storage, openstreetmaps can start work! [19:30:33] Ryan_Lane: awesome! [19:30:47] did you need to be added to the project? [19:30:53] let's discuss this in #wikimedia-labs [19:30:56] and then we can use a couple instances i think [19:31:13] awjr: were looking for you on the call [19:31:27] tfinc: i am here... [19:31:38] ok [19:33:05] preilly: http://dumps.wikimedia.org/iOS/Wikipedia-3.1beta2.ipa [19:33:56] preilly, awjr: seems it isn't apache, but it's mediawiki [19:34:01] so, with that, I leave this to you guys! :) [19:34:14] muahahahaha [19:41:34] yuvipanda: is it a big deal to open the current iOS app project in Xcode? [19:42:12] philinje: not really. it does take some setup though [19:42:27] philinje: http://www.mediawiki.org/wiki/Mobile/PhoneGap/iOS_build_instructions [19:43:01] thanks [19:48:16] jdlrobson: you around? [19:48:29] jdlrobson: can you look at: http://my.zero.wikipedia.org/wiki/Special:ZeroRatedMobileAccess?country=MY the second search looks weird [19:48:40] sort of [19:48:47] you mean the search button? [19:48:55] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/eiaXPg [19:48:55] [WikipediaMobile/master] Add README for playbook/blackberry build with hard-won instructions - Brion Vibber [19:49:22] Project WikipediaMobile - Nightly builds build #226: SUCCESS in 16 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/226/ [19:49:23] brion: Add README for playbook/blackberry build with hard-won instructions [19:54:22] yuvipanda: pune hackathon question [19:54:32] tfinc: yes? [19:54:33] yuvipanda: what video did you end up recording ? [19:54:46] preilly done > https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113512 [19:54:59] tfinc: first ~11 minutes of siebrand. Not particularly usable. [19:55:24] my camera didn't like doing that for a long time, so it turned itself off. I didn't start it after tha [19:55:24] t [19:55:28] woot! http://blog.wikimedia.org/2012/03/09/transfer-of-wikipedia-sites-from-godaddy-complete/ [19:55:49] k [19:57:20] :D [19:57:24] :) [20:01:14] jdlrobson: thanks! [20:07:43] jdlrobson: why did you do this: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113466 [20:19:01] should we consider that a page needs photos if it has other images, eg PNG? [20:24:54] probably [20:25:05] Project WiktionaryMobile - Nightly builds build #21: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/21/ [20:25:05] * gtanner: added in support for building to the PlayBook [20:25:06] * gtanner: removed permissions that didn't appear needed, updated viewport to fix scaling issue on PlayBook 2.0 and added build instructions for PlayBook [20:25:06] * stagi.andrea: Now search uses network [20:25:07] * stagi.andrea: Removed console log calls used during debug [20:25:07] * stagi.andrea: Stop the current request if performSearch is fired [20:25:08] * gtanner: added ability to build for handsets, some scaling issue (tested on P9981) [20:25:08] * gtanner: added platform switch and phonegap.js file for blackberry handsets [20:25:09] * tomasz: Fixing build settings [20:25:09] * kshdeo: Custom User Agent WikipediaMobile/1.1 prepended to existing UA [20:25:10] * jdlrobson: update readme file to explain how to get setup without eclipse [20:25:10] * jdlrobson: use MobileFrontend application.js instead of custom toggle.js [20:25:11] * jdlrobson: remove trailing whitespace [20:25:11] * jdlrobson: html cleanup [20:25:12] * jdlrobson: add some styling guidelines linked from README [20:25:12] * yuvipanda: Moved share page icon up into main menu. Added icon [20:25:13] * stagi.andrea: Added GET as default type of a request and removed whitespaces [20:25:13] * yuvipanda: Disable back button when there is nothing to go back to [20:25:25] * brion: Fix for menu toolbar in web: update to iOS platform current version [20:25:25] * 123.shravan: Bug 33198 fixed. Added CSS to spin the spinner. [20:25:26] * jdlrobson: Remove hard to hit close button from popup [20:25:26] * brion: Add README for playbook/blackberry build with hard-won instructions [20:27:44] Project WiktionaryMobile - Nightly builds build #22: SUCCESS in 8.8 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/22/ [21:08:38] has anyone else found that Show/Hide buttons are broken? it seems to be caused by this update to MobileFrontend: http://svn.wikimedia.org/viewvc/mediawiki?view=revision&revision=113442 [21:09:22] pfhayes: what is the issue? [21:09:38] pfhayes: have you updated from master? [21:09:53] pfhayes: you should be able to run 'make remotes' to make that work once you've rebased on top of our new commits. [21:09:56] Show/Hide buttons are not being created. there is a js error: file:///android_asset/www/js/application.js: Line 27 : ReferenceError: Can't find variable: showText [21:10:12] yuvipanda: i did a pull from master and a make [21:10:33] pfhayes: hmm [21:10:37] even after the make remotes? [21:10:40] yes [21:11:03] the problem appears to be in the revision posted above - the mobile fronted application.js was updated, and seems to assume that a parameter showText is filled in from some php code [21:12:53] pfhayes: hmm, yes, I see the problem [21:13:05] Project WiktionaryMobile - Nightly builds build #23: SUCCESS in 9.4 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/23/ [21:13:05] * tomasz: Updating for market release key [21:13:06] * brion: bug 33710 - fix Hebrew app title, needs to be available under Java-style 'iw' locale [21:13:06] * brion: start on ios-specific toolbar icons [21:13:07] * brion: fancy up the ios-style menu on web view [21:13:07] * brion: Add ActionSheet plugin for iOS native popup menus, used in iOS provisional toolbar [21:13:08] * niklas.laxstrom: Translation updates from translatewiki.net [21:13:08] * brion: Put iOS-style toolbar at top of screen on iPad, other larger screens. Works in web view too. [21:13:09] * brion: Let overlays live side-by-side with content... for iPad, wide view on web. [21:13:09] * brion: try using 'proper' scrolling for tablet view -- seems ok on iOS 5 and Android 3+, but Android 2.x tablets will need a fallback [21:13:10] * brion: iOS: position popup menus (activity sheets) from the toolbar point as callouts on iPad [21:13:10] * brion: *ahem* remove stray debug line [21:13:11] * brion: Fix regression in search on small screens (was hiding header by mistake) [21:13:11] * brion: Add Leaflet map library [21:13:12] * brion: Use Leaflet library & OpenStreetMap tiles as default "Nearby" view (except on Android where we still use the native view) [21:13:12] * brion: tidy up ios/web icons a bit more [21:13:13] * yuvipanda: Moved special pages partly to Templates [21:13:13] * yuvipanda: Added separate class to maintain templates and compile them [21:13:24] * brion: Fix bundle display name, name to 'Wikipedia', 'Wikipedia Mobile' instead of 'Wikipedia-iOS' [21:13:25] * yuvipanda: About page fixes in tablet view [21:13:25] * yuvipanda: Removed long undetected stray " [21:13:26] * yuvipanda: Removed a redundant function [21:13:26] * brion: fix regression in language links [21:13:27] * yuvipanda: Moved twoColumnView function into chrome.js [21:13:27] * jsoby: Adding app description message for localization [21:13:28] * jsoby: try wrapping " [21:13:28] * jsoby: Using HTML for line break [21:13:29] * jsoby: backslashes, per brion [21:13:29] * brion: set deployment target to iOS 5.0 for now since scrolling is badly messed up on earlier versions [21:13:30] * brion: Attempting to rework things for cleaner scrolling on non-Android [21:13:30] * brion: disable tablet mode on android 2.x tablets -- bad scrolling means it doesn't work right on them. only 3+ is happy [21:13:31] * brion: temporary hack for android 3+ tablets: make the search bar full with until menu/action bar gets added [21:13:31] * pfhayes: First commit [21:13:32] * pfhayes: Adding phonegap [21:13:32] * pfhayes: Adding phonegap jar [21:13:33] * pfhayes: Adding gitignore [21:13:44] * pfhayes: Leaflet based maps now respect current language [21:13:44] wow jenkinsbot is busy :) [21:13:45] * pfhayes: allow 4.2: prep for iscroll testing [21:13:45] * pfhayes: add iscroll library [21:13:46] * pfhayes: Use iScroll on iOS 3 (untested) or 4 (tested 4.3 sim) [21:13:46] * pfhayes: Renaming Wikipedia -> Wiktionary [21:13:47] * pfhayes: Fix for scroll position not being reset when navigating pages with overflow scrolling [21:13:47] * pfhayes: ahem.... fix for regression on ios toolbar [21:13:48] * pfhayes: Adding 'did you mean' functionality to search' [21:13:48] * pfhayes: Fix for opening external links in external browser on iOS [21:13:49] * jeroendedauw: change coordinate links to toolserver pages to point to the "nearby articles" map [21:13:49] * jeroendedauw: rem tutorial function [21:13:50] * suyash: Added support for About US list item in Settings Menu and added a css style for dimming the forward and backward menu item, the style is not implemented currenty [21:13:50] * suyash: Phone Gap Weinre removed from the source [21:13:51] * jeroendedauw: added gitignore so aptana projects get ignored [21:13:51] * jeroendedauw: ignore symlink to en-us i18n file [21:13:52] * jeroendedauw: cleanup dms to float coord function [21:13:52] * brion: partial fix for about screen view on iOS (needs scrolling fix still) [21:13:53] * pfhayes: Unruining the repo [21:14:04] * hartman: Adding ShareKit 2.0 as a submodule [21:14:05] * yuvipanda: Initial work on WebIntents support [21:14:05] * yuvipanda: Supports both singleTask and standard launch modes [21:14:06] * hartman: Register ShareKitPlugin as an iOS PhoneGap plugin [21:14:06] * hartman: Add some changes to the ShareKitPlugin to make it actually work. [21:14:07] * hartman: The new Xcode project file with all the changed ShareKit stuff. [21:14:07] * hartman: Add some setup for configuring our setup of ShareKit [21:14:08] * hartman: Disabling some of the plugins that are not likely gonna be useful in immediate future. [21:14:08] * hartman: Compile error in the launchdelegate [21:14:09] * hartman: Add the sharePage command to the iOS PhoneGap platform [21:14:09] * yuvipanda: A beggining of search suggestion content provider for integrete Wikipedia app in the global search system. [21:14:10] * yuvipanda: Properly handle search intents (not just suggestions) [21:14:10] * gtanner: added in support for building to the PlayBook [21:14:11] * hartman: Add CREDITS and generator for the credits [21:14:11] * hartman: Make sure that the searchbar and menu bar are localized when first starting the app [21:14:12] * hartman: Extend jquery localize to be able to handle placeholder atributes [21:14:12] * hartman: Add placeholder to the Search field. [21:14:13] * hartman: Turn the search field into an actual type=search, know that I finally figured out how to undo all of webkit's search field styling. [21:14:15] yuvipanda, i'm braindead and heading home for now but will do some more poking at the playbook on the weekend. this may involve retooling the ios and web menu code [21:14:17] well, that was quite some unruining :) [21:14:24] parmesan. [21:14:24] * yuvipanda: Minor style modifications for clear history [21:14:25] * yuvipanda: Unbind functions before binding them again [21:14:25] * brion: Tweak to tablet behavior: use full column width until we have something to put in the sidebar. [21:14:26] * yuvipanda: Initial commit towards fixing offline cache issues [21:14:26] * yuvipanda: Make the plugin run on the UI Thread [21:14:27] * dale.lemieux: Now url encodes the words from other apps properly when attempting to define in Wiktionary [21:14:27] * dale.lemieux: Fixing issue with loading the app [21:14:28] * dale.lemieux: Removing whitespace [21:14:28] * stagi.andrea: Fixes #33573 [21:14:29] * stagi.andrea: Initial refactoring for spinner [21:14:29] * gtanner: removed permissions that didn't appear needed, updated viewport to fix scaling issue on PlayBook 2.0 and added build instructions for PlayBook [21:14:30] * pfhayes: Making more Wikipedia -> Wiktionary changes [21:14:30] * brion: Revert commit 6b0f789f1a42975db5fd112d06ec93e01fc42e76 - added type="search" on the search box. [21:14:31] * brion: Add 'Read it later' API key for ShareKit configuration on iOS [21:14:31] * brion: Fix regression: 'nearby' broke on iOS, web [21:14:32] * brion: Fix bug 33869: OSM/Leaflet map label overlaps toolbar [21:14:32] * hartman: Fix typo in placeholder param [21:14:33] * hartman: Turn the Home button into an actual button and add a title for it as well. Accessibility !!!! [21:14:35] brion: to be used on the playbook too? [21:14:38] and there it comes again wheee [21:14:41] yuvipanda, yeah [21:14:44] * stagi.andrea: Removed console log calls used during debug [21:14:45] * stagi.andrea: Stop the current request if performSearch is fired [21:14:45] * shealen.clare: Create Word of the Day menu item [21:14:46] * stagi.andrea: Added COPYING file with GPLv2 [21:14:46] * pfhayes: Removing leftover conflict marker [21:14:47] * gtanner: added ability to build for handsets, some scaling issue (tested on P9981) [21:14:47] * gtanner: added platform switch and phonegap.js file for blackberry handsets [21:14:48] * yuvipanda: Removed needless features of saved pages [21:14:48] * yuvipanda: Set user agenet properly [21:14:49] * pfhayes: First commit [21:14:49] * pfhayes: Adding phonegap [21:14:50] * pfhayes: Adding phonegap jar [21:14:50] * pfhayes: Adding build.xml [21:14:51] * pfhayes: Removing binary files [21:14:51] * pfhayes: Adding jquery [21:14:52] * pfhayes: Renaming Wikipedia -> Wiktionary [21:14:52] * pfhayes: Adding custom wiktionary styling [21:14:53] * pfhayes: Adding todo [21:14:54] rioght now it loads up the web code which uses the ios-like menus, looks nice but needs some integration work [21:15:00] brion: http://meta.wikimedia.org/wiki/Mobile_Projects/WikipediaMobileiOSFeedback [21:15:04] * pfhayes: First commit [21:15:04] kaldari complaining about scrolling [21:15:05] * pfhayes: Adding phonegap [21:15:05] * pfhayes: Adding phonegap jar [21:15:06] * pfhayes: Adding build.xml [21:15:06] * pfhayes: Removing binary files [21:15:07] * pfhayes: Adding jquery [21:15:07] * pfhayes: Renaming Wikipedia -> Wiktionary [21:15:08] * pfhayes: Adding custom wiktionary styling [21:15:08] * pfhayes: Adding todo [21:15:09] * pfhayes: Use iScroll on iOS 3 (untested) or 4 (tested 4.3 sim) [21:15:09] * pfhayes: Renaming Wikipedia -> Wiktionary [21:15:10] * pfhayes: removing near-me...again [21:15:10] * pfhayes: continuing to tear out geolocation, previous commit was only disabling the UI [21:15:11] * pfhayes: Updating README [21:15:11] * pfhayes: Removing some more location stuff [21:15:12] * pfhayes: Added feature to define words from outside of app [21:15:12] * pfhayes: Making more Wikipedia -> Wiktionary updates [21:15:12] i think we probably want to use the ios-like menus as a fallback for all non-android-handset [21:15:13] * pfhayes: Getting rid of unused location file [21:15:18] brion: anything at all we can do about that? [21:15:24] * pfhayes: Adding jquery [21:15:25] * pfhayes: Renaming Wikipedia -> Wiktionary [21:15:25] * pfhayes: Adding custom wiktionary styling [21:15:26] * pfhayes: Adding todo [21:15:26] * pfhayes: Use iScroll on iOS 3 (untested) or 4 (tested 4.3 sim) [21:15:27] * pfhayes: Renaming Wikipedia -> Wiktionary [21:15:27] * pfhayes: removing near-me...again [21:15:28] * pfhayes: continuing to tear out geolocation, previous commit was only disabling the UI [21:15:28] * pfhayes: Updating README [21:15:29] * pfhayes: Removing some more location stuff [21:15:29] * pfhayes: Added feature to define words from outside of app [21:15:30] * pfhayes: Making more Wikipedia -> Wiktionary updates [21:15:30] * pfhayes: Getting rid of unused location file [21:15:31] * pfhayes: Now url encodes the words from other apps properly when attempting to define in Wiktionary [21:15:31] * pfhayes: Fixing issue with loading the app [21:15:32] * pfhayes: Removing whitespace [21:15:32] * pfhayes: Making more Wikipedia -> Wiktionary changes [21:15:32] just a heads-up that i'll be moving some code around in there :) [21:15:33] * pfhayes: Create Word of the Day menu item [21:15:39] brion: sure! [21:15:44] * yuvipanda: Bumped version to v1.1beta1 [21:15:45] * pfhayes: Fixing undefined error in toggle [21:15:45] * yuvipanda: Bug fixed for onTouch events [21:15:46] * yuvipanda: Added items to change log and actually bump version number [21:15:46] * yuvipanda: Closes bug #32903 [21:15:47] * hy.cheng: Listen menu now clears when pressing back or going to blank page, audio files are now in correct order to what is shown on menu, changed where audio information is loaded [21:15:47] * yuvipanda: Refactored out mention of wikipedia URL [21:15:48] * pfhayes: Making changes to use app.baseurl [21:15:48] * pfhayes: Changing base url for wiktionary [21:15:49] * pfhayes: Fixing base url for sister projects [21:15:49] spiffy. see ya online later man [21:15:49] * pfhayes: Styling error page for wiktionary [21:15:50] * yuvipanda: Added credits to About Page [21:15:50] * yuvipanda: Fixed About page in Tablets [21:15:51] * yuvipanda: Upgraded version of leaflet.js [21:15:51] * yuvipanda: Upgraded to PhoneGap 1.4 for Android [21:15:52] * yuvipanda: Added missing phonegap 1.4 jar [21:15:52] * brion: update path for new phonegap [21:15:53] * brion: hack leaflet map library to disable webkit 3d transformations, which are all flicker in phonegap for some reason on android 4 [21:16:04] pfhayes: what happened to the repo? :) [21:16:04] * yuvipanda: Stop using 'deprecated' #content div container for scraping [21:16:05] * yuvipanda: External links open in browser in iOS [21:16:05] * yuvipanda: Messes up display rendering. Will have to wait till we move to API [21:16:05] mw-jerkingsbot [21:16:06] * yuvipanda: Fixed hack. Menus on Android should now work [21:16:06] * yuvipanda: Different about screens for different versions [21:16:07] * sheaclare: Cutting dead code from WiktionaryActivity.java [21:16:07] * tomasz: Fixing build settings [21:16:08] * dale.lemieux: Removing dead code from WiktionaryActivity and manifest [21:16:08] * hy.cheng: re-added listen-in to the menu [21:16:09] * kshdeo: Custom User Agent WikipediaMobile/1.1 prepended to existing UA [21:16:09] * jdlrobson: update readme file to explain how to get setup without eclipse [21:16:10] * jdlrobson: use MobileFrontend application.js instead of custom toggle.js [21:16:10] * jdlrobson: remove trailing whitespace [21:16:11] * jdlrobson: html cleanup [21:16:11] * jdlrobson: add some styling guidelines linked from README [21:16:12] * yuvipanda: Moved share page icon up into main menu. Added icon [21:16:12] * dale.lemieux: Added the new app icon (red W) [21:16:13] * sheaclare: Fixing WordoftheDay button [21:16:23] yuvipanda: it's reverse ordering back to 0. [21:16:24] * jdlrobson: Removed unnecessary code setting current language [21:16:25] * yuvipanda: Bumped version and updated CHANGELOG [21:16:25] * brion: Update Playbook PhoneGap JS from 1.3 to 1.4.1 [21:16:26] * brion: Fix for menu toolbar in web: update to iOS platform current version [21:16:26] * 123.shravan: Bug 33198 fixed. Added CSS to spin the spinner. [21:16:27] * jdlrobson: Remove hard to hit close button from popup [21:16:27] * brion: Add README for playbook/blackberry build with hard-won instructions [21:16:28] * pfhayes: Setting version numbers for v1.0.1b [21:16:30] Amgine: pfhayes force push? [21:16:36] nope, it's done [21:16:37] i think [21:16:40] me too [21:16:51] dunno; pfhayes is the guru on git. [21:17:10] yuvipanda: I did a rebase a while ago but it should have already been pushed? I don't really know what happened there [21:17:30] yuvipanda: do you have any suggestions for the MobileFrontend problem? [21:17:40] pfhayes: yes! [21:17:46] 1. file a bug :D [21:17:55] 2. use a prior version of the js files until then [21:18:20] okay [21:20:57] awjr: ^^ [21:21:21] pfhayes: can you poke awjr once you've filed the bug? [21:21:31] sure thing [21:24:36] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=35098 [21:25:53] pfhayes: just read backscroll [21:26:06] awjr: all of the botspam too? :) [21:26:28] yuvipanda: aye, makes for good lunchtime reading [21:26:42] pfhayes: we had to make that change in application.js so that show/hide button text could be translated [21:26:44] american lunchtimes must be very boring :P [21:26:53] :p [21:27:13] pfhayes: so, i dont see that as a 'bug' in MobileFrontend [21:27:54] unless you or yuvipanda can convince me otherwies [21:28:04] awjr: looking at that diff, give me a minute [21:28:47] awjr:what is the method to showText internationalized? [21:29:11] Amgine: we set global javascript variables in ApplicationTemplate.php with the appropriately translated text [21:30:12] awjr: do you see a way to set those in js itself (without resorting to echoing from PHP) currently? [21:30:36] Amgine, yuvipanda, pfhayes: see https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113444 and associated followup revs [21:31:02] yuvipanda: since we can't use resource loader, no. we have to fetch the translations in PHP [21:31:39] i suppose they could be fetched via API but... [21:31:46] that has obvious drawbacks [21:32:32] awjr: hmm, okay. [21:33:02] pfhayes: i'll need to talk to Jon about how he wants the app to track changes from MF [21:33:09] always keep a verbatim copy or modify our own [21:33:12] yuvipanda: how do you handle translations in the app? or do you? [21:33:22] awjr: we do [21:33:54] yuvipanda: is there a way you can also globally set those variables with the appropriate translated strings for show/hide? [21:33:57] we've mw.message and jquery localize infrastructure setup [21:34:03] awjr: we can, so that's the simple fix. [21:34:13] however, what I want to know is how Jon wants us to track changes from MF [21:34:15] yah [21:34:20] if we're going to just take one version and keep it [21:34:24] i see [21:34:26] and modify it to suit the app's needs [21:34:30] or to keep tracking current MF [21:34:44] and the solution would have to depend on that. [21:35:21] makes sense [21:36:04] Also awjr, 35096 [21:36:22] Someone mentioned that might fall toward you. [21:38:47] Amgine: it's actually an issue for operations. it looks like sam reed opened an rt ticket for ops to deal with the issue. It was given to one of our ops engineers on 2/29 who has been sick. not sure if he's back to work yet, but i can prod him [21:39:41] no worries; not urgent yet. [21:42:50] Project WiktionaryMobile - Nightly builds build #24: SUCCESS in 8.4 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/24/ [21:42:50] * pfhayes: Adding mobile frontend resources [21:42:51] * pfhayes: Using old version of application.js [21:42:51] * pfhayes: Removing unused method [21:42:52] * pfhayes: Turning off toggling first section [21:43:05] Project WiktionaryMobile - Nightly builds build #25: SUCCESS in 8.1 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/25/ [21:43:05] * pfhayes: Adding mobile frontend resources [21:43:06] * pfhayes: Using old version of application.js [21:43:06] * pfhayes: Removing unused method [21:43:07] * pfhayes: Turning off toggling first section [21:45:23] Great job, pfhayes. Fast. [21:46:12] tfinc: philinje linSmith thoughts on the second bit of feedback at http://meta.wikimedia.org/wiki/Mobile_Projects/WikipediaMobileiOSFeedback#v3.1Beta2 [21:46:13] ? [21:46:21] copy pasting: [21:46:21] When I tap on a bubble in the Nearby screen to load the full article, the screen flashes to whatever article I was on previously momentarily then starts loading the new article. It's odd when I'm looking at nearby related articles to be looking at the popup for, say Chez Panisse and tap it, but flash up the article for the Cheese Board momentarily - it makes me think I missed the target (since they're nearby). The blank white screen tha [21:46:21] popped up before wasn't good either, but I think this might be worse. Can we just have a 'loading' screen or something instead of either the full blank or the previous article? [21:46:26] from maplebed ^ [21:46:37] I don't think adding a modal dialog is a good idea, but it is a very valid point... [21:47:28] (I actually don't care how the symptom is resolved; current behavior just feels weird. feel free to ignore my suggested solutions) [21:48:44] hmm, I could blank out the content and just display the spinner where it is [21:48:59] so it won't be a fully white screen, but you'll not be seeing the old text either [21:49:01] * yuvipanda tries i tout [21:49:12] that would work. [21:49:27] iTrout. [21:50:43] * yuvipanda hits Amgine on the head with an iTrout [21:51:02] o_O [21:53:43] yuvipanda: which bit of feedback are you talking about? [21:54:01] the loading of a new article ? [21:54:08] yes. [21:54:15] i think the solution i suggested seems workable. [21:54:20] so nevermind, unless you think that's a bad idea [21:54:36] i don't see another solution on the feedback page [21:54:40] is it somewhere else? [21:55:49] i just typed it out on IRC [21:58:23] * tfinc scrolls up [21:59:00] so one way the browser solves this on android is that it shows both a modal that something is happening and a progress bar of how much we've loaded [21:59:31] tfinc: true but a modal would be inconsistent with the rest of our page loads [21:59:49] this would be an app wide change if we did it [21:59:54] now in this case hmm .. [21:59:59] but just blanking out the content [22:00:04] of the old article [22:00:08] seems to be a workable compromise [22:00:41] i'm going to have to think about this [22:00:51] low priority though [22:01:01] okay [22:01:08] i'll implement this and see how this goes [22:01:30] tfinc: we have to sit and figure out what comes after 1.1. Do we block a time on the calendar? [22:03:36] * tfinc steps into meetings [22:29:18] yuvipanda: you just need to expose the show and hide variables into the global javascript scope [22:29:39] preilly: yes, that particular bit is an easy fix (I have it fixed in my local) [22:35:32] alright I'm out. Will finish the rest of this bit tomorrow [22:35:34] gnite everyone [22:37:45] meh who am I kidding. Lemme finish this [22:39:20] yuvipanda: i hope by 'tomorrow' you meant monday [22:39:48] considering it is Saturday 4:10 AM, I don't really know :D [22:39:59] go to bed! [22:40:04] you're making me tired [22:40:25] ha ha [22:40:26] but I woke up at 3:30PM! [22:40:32] also, waking up any earlier is pointless [22:40:35] wow [22:40:45] there is a 'scheduled' powercut from 2PM to 4PM [22:40:49] so I'd rather sleep through most of that [22:41:02] than suffer in this hot and humid fanless place [22:41:17] i have to admite that is logical. [22:41:21] s/admite/admit [22:41:57] :D [22:42:19] atleast it is a scheduled powercut so I can work around it. It used to be much worse, with power going off whenever [22:42:43] and it is also 'only' 2 hours - there are places with 4-6 hours every day [22:42:49] * yuvipanda cringes [22:43:25] jeez [22:44:09] philinje: hi! sorry i've been away. my car died. this has been a very interesting week. [22:44:34] i thought i had it bad in oakland - we had fairly regular but unscheduled power cuts, at least a couple times during the week, usually during the workweek [22:44:48] heatherw: are you sure you weren't away crimefighting with your band of mutants? [22:44:58] awjr: close to 30C. Power cuts. [22:45:05] >_< [22:45:17] hi heatherw [22:45:20] that sucks [22:45:31] awjr: ~7 years ago, powercuts *and* very limited water supply [22:45:34] boy was *that* fun [22:46:33] a truck load of water would come in, and people would queue in to get a limited amount of potable water. [22:46:44] I hope I never go through *that* again [22:47:13] oh man [22:47:44] heatherw: if you have a minute (and maybe willing to give a little time later today or whenever), i want to ask something [23:38:31] alright [23:38:36] gnite [23:52:34] * MaxSem stops banging the SQL wall with his head and falls asleep [23:58:23] heatherw: did you see our request to get the graphics assets to jon?