[02:19:14] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/idItjg [02:19:14] [WikipediaMobile/master] Merge iOS & web app menu code to common default - Brion Vibber [02:19:34] Project WikipediaMobile - Nightly builds build #228: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/228/ [02:19:35] brion: Merge iOS & web app menu code to common default [12:54:31] [PageImages] MaxSem pushed 1 new commit to master: http://git.io/JKCxqA [12:54:31] [PageImages/master] Let other extensions know that we're installed - Max Semenik [16:26:10] [WikipediaMobile] jdlrobson pushed 2 new commits to master: http://git.io/O7FVdQ [16:26:10] [WikipediaMobile/master] Fix race condition occurring sometimes in menus in Android - YuviPanda [16:26:10] [WikipediaMobile/master] Formatting fixes for all Java code - YuviPanda [16:26:31] Project WikipediaMobile - Nightly builds build #229: SUCCESS in 13 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/229/ [16:26:32] * jdlrobson: Fix race condition occurring sometimes in menus in Android [16:26:32] * jdlrobson: Formatting fixes for all Java code [16:42:30] [WikipediaMobile] jdlrobson pushed 1 new commit to master: http://git.io/cWaoxA [16:42:30] [WikipediaMobile/master] Hide content when navigating from Nearby View - YuviPanda [16:42:44] Project WikipediaMobile - Nightly builds build #230: SUCCESS in 8.4 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/230/ [16:42:45] jdlrobson: Hide content when navigating from Nearby View [16:49:16] heya jdlrobson [16:49:34] yuvipanda: hello! [16:51:29] jdlrobson: replied inline to your latest comment [16:51:35] yep just seen [16:51:41] i'm having oddness with my emulator today [16:51:44] seems very very slow [16:51:51] and the spinner doesn't seem to ever clear [16:53:20] jdlrobson: not very clear as in? [16:53:31] as in it never disappears [16:53:35] it just spins spins spins [16:53:42] jdlrobson: that means you've a js error [16:53:44] check log? [16:53:48] ahh [16:54:02] i did make remotes and that's fixed now.. [16:54:13] interesting i'll bear that in mind! [16:54:54] jdlrobson: :) [16:55:42] sooo with the show/hide buttons - I want to do two things - i want to separate all the toggling code from application.js since application.js contains a few extra bits that are unnecessary [16:55:51] and I'd like us to stop using global variables for the labels [16:56:37] jdlrobson: yes, so does MF have an 'app level namespace' of sorts? [16:56:53] the MobileFrontend variable [16:56:53] I can use mw.message in the app [16:57:16] jdlrobson: i'd prefer it if we could move the toggle code to a separate file/'module' first? [16:57:19] mw being the mediawiki.js library which MobileFrontend doesn't have [16:57:24] agreed [16:57:28] looking into that now [16:57:45] jdlrobson: do you expect a fix today? [16:57:56] i don't see why not [16:57:57] if not i'd like you to merge the pull requests in [16:57:59] so master is not broken [16:57:59] ah [16:58:01] okat [16:58:01] *okay [16:59:54] what do you do in your 20% time, guys? [17:00:23] MaxSem: I mostly do code review right now [17:00:31] MaxSem: it has totally depended for me, but typically code review/bug fixing [17:01:09] MaxSem: been helping out / 'mentoring' the Wikt app guys, but I should start transitioning into bug fixing/CR soonish, I think [17:02:01] ah, so DST so our standups are a hour earlier? [17:02:03] heya shravan [17:02:34] oh heh [17:03:08] greetings all [17:03:38] MaxSem: yuvipanda awjr jdlrobson : ready for the stand up ? [17:03:48] arizona is a weird state in many ways, but particularly because there is no DST here. but yesterday, my phone thought it was it in regular mountain time (not AZ mountain time), meaning it jumped ahead an hour, which i didnt realized until about halfway through the day [17:03:50] tfinc yes [17:04:14] tfinc: yes [17:04:23] awjr: the US has weird states? You don't say... [17:06:01] :p [17:09:47] tfinc: do you have a time/date in mind for sync up over post 1.1 work? [17:09:59] yuvipanda: let me see [17:10:08] this week should be far less insane then last week [17:11:01] this morning isn't horrible [17:11:31] so tfinc, preilly - should i be working on special page-ifying MobileFrontend or … ? [17:12:03] tfinc: okay! [17:12:08] tfinc: poke me whenever? [17:12:21] jdlrobson: are you at a point where awjr could work with you in those designs ? if not then it would make sense for him to look at special pages [17:12:29] yuvipanda: sure thing [17:12:50] awjr: you still have your MF push tomorrow right ? [17:12:58] tfinc: yes [17:13:13] mmm - I'm starting with the full screen search but I don't forsee many places where I can get help there [17:13:31] the contact page would be a good place to start [17:13:32] tfinc: right now all that's scheduled to go out is the cookie setting for useformat=mobile (http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments) [17:14:12] awjr: so i'd say you put special pages and contact us on your backlog [17:14:13] as in awjr could get a basic form setup that does emailing etc [17:15:39] awjr: the product spec for it is here http://www.mediawiki.org/wiki/Mobile_design/Contact [17:16:12] * awjr takes a look [17:16:47] philinje: where are the mockups that don't have the weird multi tiered menus ? [17:17:33] inbox(127) .. seriously .. how do i get so much new email through just this weekend [17:20:11] tfinc, phillinje: a couple of questions rearding the contact form for MobileFrontend 1) is there any validation that should happen on that page and what should its behavior be? 2) what actually is supposed to happen when a user has filled out the form and clicks send? [17:20:35] 1) what kind of validation does mw do on its own ? [17:20:43] preilly - just realised application.js is exactly the same as beta_application.js - so going to remove the latter and make them use the same file regardless of what mode is turned on [17:21:28] yuvipanda: side note. beta internationalization for the show/collapse is broken until your fix on master comes out [17:21:50] tfinc: jdlrobson wants to fix that in MobileFrontend [17:22:40] so, what shal I doooo nowwww? [17:22:40] 2) you mean as in a thank you message or page ? [17:22:48] MaxSem: ! [17:22:49] :D [17:22:57] has yuvipanda gotten back to you the API ? [17:23:11] about* [17:23:13] nope, everytime I start on the API I get a new wave of feedback! [17:23:24] kill feedback! [17:23:27] haha [17:23:32] this is a good problem to have [17:24:15] so I'll shoot the second round of emails to the iOS testers, fix 'one last bug' and hopefully get back to the action=parse based API [17:24:40] tfinc: MediaWiki doesn't do any validation by default [17:25:11] tfinc: i believe there are a handful of form extensions that are probably worth looking at that i imagine provide their own frameworks/mechanisms for validation [17:25:31] so… we can do whatever. but there should probably be mock-ups for validation/error states as well [17:25:39] awjr: i'm sure MaxSem could guide you along as well [17:25:43] email validation, what else? [17:25:55] awjr: its not like your not unfamiliar with validation with donation pages ;) [17:26:00] for* [17:26:29] tfinc: heh for sure :p but that was all custom done and we had pretty specific guidelines on look and feel [17:27:11] for email validation in core, there's overkillishly detailed Sanitizer::validateEmail() [17:27:35] I think we have something for email validation in JS, but it depends on RL [17:27:36] does mw give us any generic validation error pages that we can build off of ? [17:28:25] umm, no? the response to invalid input should be to show the form with a request to fill this and that field [17:28:50] tfinc: as for #2 - i mean, what is supposed to happen when 'send' is clicked in terms of what the user sees and anything else that's supposed to happen eg how does someone actually see the information a user entered in the contact form? via an email? via some interface/wiki page? does the data need to be stored in a database for future use? [17:28:51] awjr: is this now resolved https://bugzilla.wikimedia.org/show_bug.cgi?id=34144 ? [17:29:55] awjr, the spec says email it to OTRS [17:30:19] tfinc: depends but i think with some explanation we can mark it as resolved and potentially open a separate bug. the hostname handling is resolved, but path and query string handling will require more work and probably some core changes [17:30:39] k, then note it in the ticket [17:30:52] core is in frrreezzze now [17:30:57] i want to see what else we have to get done there [17:30:59] brrrrrr [17:31:00] :D [17:31:30] tfinc: sorry, the spec is a bit ambiguous to me "To direct comments to the appropriate destination, such as a wiki page, email alias or OTRS email address" - so should each of those things be supported? [17:32:15] tfinc: this is also ambiguous - what is actually valuable to capture? "To capture some information automatically, such as platform, browser/app and device" [17:32:59] awjr: good questions [17:33:08] philinje: --^ [17:33:30] its all email as far as i can see philinje [17:33:54] looking at categories 1-4 .. it all seems like email [17:34:05] we need to pick where were going to direct #1 [17:35:24] awjr: can we talk on Skype? [17:35:36] or I am happy to call your phone [17:37:25] yuvipanda: Randy sent over this through our twitter handle https://github.com/RandyMcMillan/MediaBrowser#readme [17:37:26] philinje: sure skype is fine [17:37:52] tfinc: checking [17:38:06] tfinc: i checked in with @firt, i had apparently discovered a bug in iWebInspector. he's gotten me a fix, need to test [17:38:25] hmm, let me check on that [17:39:55] philinje: my skype username is awjrichards [17:40:56] ok, one sec [17:41:10] preilly: it would be good to get some more hands on sms/ussd/zero . could MaxSem take on some of the bugs for you ? [17:41:46] yuvipanda: so 1.2 [17:41:51] i see no strong need to move to 1.2 at this time [17:42:02] the language selection discussion is still on going [17:42:13] and these releases have been taking a lot of your time [17:42:41] tfinc: do you have something else you want me to focus on instead? [17:42:43] awjr: sent the contact request [17:43:11] pchang: cool, accepted. ready when you are [17:43:18] yuvipanda: so your main push should still be to get 1.1 iOS and Android to the market [17:43:37] how many more betas are you looking at before we go to market ? [17:43:49] 1 more beta and 1 (hopefully) RC [17:43:52] i was anticipating getting it into the market this month [17:44:56] tfinc: should happen easily enough. [17:46:25] tfinc: we should set a set release date and make sure that is hit. [17:46:33] * tfinc looks at calendar [17:47:38] we have three weeks left in the moth [17:47:42] month* [17:47:55] 21? [17:48:03] sold [17:48:50] actually, it depends on how much of my time you would kneed [17:48:52] need* [17:48:57] i have a budget review all day on the 21st [17:49:04] the 22nd is wide open [17:49:19] okay, 22nd then [17:52:08] yuvipanda: release invite sent [17:52:21] cool :) [17:52:34] tfinc: i'll 'prepare the translators' once jdlrobson okays my patch [17:54:30] yuvipanda: https://github.com/jdlrobson/WikipediaMobile/tree/toggling [17:54:44] * yuvipanda checks [17:54:49] if this looks okay to you - I will push the necessary changes to MobileFrontend and github for you to pull [17:54:59] jdlrobson: checking [17:55:42] preilly: thoughts on MaxSem working with you on zero/sms/ussd ? [17:55:50] jdlrobson: looks good to me, though i'll have to double check the syntax for the messages [17:55:54] message descriptions, rather [17:55:55] sure [17:56:00] i can always edit [17:56:08] ok so ill push svn stuff - dont run make remotes in the meantime! :) [17:56:11] tfinc: that's fine [17:56:12] :D [17:56:21] brion: how goes playbook hacking ? [17:56:42] preilly: whats next on your todo list for zero/sms/ussd ? [17:56:59] just tell me wyhat/where to do [17:57:09] brb goof [17:57:10] err [17:57:11] food [17:57:49] tfinc: I'm working on zero and adding more personalization for carriers [17:58:14] tfinc, coming along. started on moving around the common menu code to make it easier to work with [17:58:45] tfinc: ussd/sms I was just looking at the message splitting code [17:58:51] kernel demands reboot. brb [17:59:14] MaxSem: the ussd/sms code is located here: https://github.com/praekelt/vumi-wikipedia/ [17:59:17] what makes sense for MaxSem to jump into ? [17:59:40] Python? [17:59:47] tfinc: does MaxSem know Python well? [17:59:49] fsssss my fire alarm has just gone off... bad timing [17:59:50] but brb [17:59:59] jdlrobson: stay safe [18:00:00] will take some time for me to grok it:) [18:00:14] would definitely be fun though [18:00:39] tfinc: well, MaxSem could take a look at the message splitting [18:01:03] e.g., don't break inside of words and try to complete whole sentences…., etc. [18:01:04] * MaxSem takes his regexp katana [18:01:17] MaxSem: the code is running in labs [18:02:05] MaxSem: instance name vumi-gw1 [18:03:53] MaxSem: I just added you to the mobile-sms project [18:04:07] txh, was typing a request for it:) [18:07:46] back [18:07:52] just someone having too hot a shower... [18:07:58] jdlrobson: nice [18:08:05] * jdlrobson tries to get back to his chain of thought [18:10:53] jdlrobson: wow, steam sets off your smoke detector? [18:10:59] apparently [18:11:01] i was surprised too [18:11:24] bizarrely in my building of 4 flats only 2 of the residents came out [18:11:36] even though the other 2 turned out to be in [18:11:56] * preilly TIL steam or high humidity can lead to condensation on the circuit board and sensor of a smoke detector, causing the alarm to sound [18:11:57] cloning... what to do with that vumi-wikipedia? [18:12:44] jdlrobson: Contact form mock-ups need significant changes, fyi [18:12:49] MaxSem: well, the SMS messages need to be split in a reasonable way also you could take a look at the API calls too [18:12:58] brb [18:15:50] jdlrobson: where you able to get the assets in a file format you can use? [18:16:08] i havent asked yet.. .still dealing with the toggling stuff [18:16:11] then will move straight on to that [18:16:30] heatherw: greetings [18:16:55] hi tfinc, answering jon right now :) [18:16:57] heatherw: jdlrobson doesn't have illustrator :( can you guys work out a file format that works for both of you? [18:16:59] excellent [18:17:05] yup! [18:29:34] heatherw: hi, how are you feeling? [18:29:54] much better, thanks. my eye is magenta but not swollen :) [18:30:09] good to hear [18:30:17] are you going to come in today? [18:30:44] i answered your email, i planned to take friday and monday off for my birthday [18:30:52] that doesn't seem to be working very well :) [18:31:13] oh, sorry, i don't see that [18:31:26] no worries, see you tomorrow, enjoy! [18:32:09] is there some announcement process that i'm not aware of? i thought i told people but i might not have done a great job. [18:32:58] heatherw: if you log off of IRC it might work better ;0 [18:33:04] heh [18:33:05] yeah [18:33:16] usually just an email to engineering, or just people you work with [18:33:22] i came on because i got so many emails :) [18:37:12] heatherw: makes sense [18:37:31] heatherw: oh, yeah — and Happy Birthday! [18:41:40] that library is funny - explodes on Unicode [18:41:55] thanks! [18:42:39] heatherw your welcome — now log off and enjoy it! ;) [18:42:54] s/your/you're [18:42:55] :) [18:43:24] MaxSem: where is it breaking? [18:44:07] or I'm just a Python noob:) [18:47:55] 2,026,492 total installs (users) !!! [18:48:01] brion: yuvipanda jdlrobson --^ [18:48:09] mmm, not exactly. it fails to digest Obama [18:48:14] :D [18:48:22] i'm going to mail mobile-l about that later today [18:48:26] its time they got some updated stats [18:48:29] perhaps a blog post too [18:48:37] in prep for the 1.1 release [18:49:05] +1 [18:49:50] :) [18:51:26] MaxSem: where does it error out for you? [18:52:10] [18:52:12] hmm, python's idiocy with output encoding [18:52:31] and I thought PHP is fucked up:) [18:52:51] haha [18:54:41] heatherw happy birthday btw if you want/need to rush off i can sort out the images with linSmith [18:57:31] mmm, I could port parts of MobileFormatter to Python [18:58:33] MaxSem: that would be cool [18:58:38] * preilly I think [18:59:12] or we could give 'em text extracts [18:59:50] and this API will be available for everyone [18:59:59] thoughts? [19:00:40] MaxSem: I've got no strong opinion either way [19:00:54] MaxSem: I think you should just do what you think is best [19:02:55] what their text transformation is currently able to do: http://toolserver.org/~maxsem/obama.txt [19:03:24] MaxSem: this is from vumi? [19:03:29] yes [19:03:35] too messy [19:04:20] MaxSem: yeah, how would that look with Mobile Formatter? [19:04:48] preilly - any thoughts on http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113644#c32088 [19:07:08] jdlrobson: well, he makes a point [19:07:13] sure [19:07:19] I've left a comment [19:07:34] awjr: i aded the stuff we talked about to the Contact page, including a requirement about validating the email adress [19:07:46] philinje: awesome thanks! [19:07:50] do you still have a question about validating the page? [19:08:41] jdlrobson: well, couldn't we just namespace the strings…. with something super unique? [19:08:45] philinje: not at the moment. i'll let you know though if i come across any more questions [19:08:55] well we could bake these configuration options into an html attribute e.g. data-script-path="/api.php" [19:09:04] we could also bake it as a json in a script tag [19:09:05] t [19:09:26] e.g. [19:09:47] * jdlrobson checks support for JSON across mobile browsers [19:10:07] * preilly thinks we should be good with JSON across most mobile browsers [19:10:27] nope http://caniuse.com/json [19:10:44] just ios safari 3.2 [19:10:45] http://caniuse.com/json [19:10:51] preilly, MF can do anything you can tell it to. currently, we have a text extraction API only for the first section. it's easier, as it doesn't need to deal with section titles (everyone has their own ideas how they should look in plain text!) and metadata at the bottom hidden with CSS [19:10:52] and i guess noka etc [19:12:14] and it's quite important code so needs to be cross browser [19:12:52] jdlrobson: yeah [19:12:54] always https://github.com/douglascrockford/JSON-js/blob/master/json2.js [19:13:20] but seems we should go native as much as possible for basic functionality [19:14:31] [WikipediaMobile] brion pushed 3 new commits to master: http://git.io/-xthcg [19:14:31] [WikipediaMobile/master] Followup to menu merging: commit the other files. :P - Brion Vibber [19:14:31] [WikipediaMobile/master] update platform files for playbook - Brion Vibber [19:14:31] [WikipediaMobile/master] Fix for PlayBook files & external link opening (bug 35093) - Brion Vibber [19:14:37] jdlrobson: yeah, [19:14:40] ok playbook can now open external links in the browser app [19:14:48] Project WikipediaMobile - Nightly builds build #231: SUCCESS in 9.2 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/231/ [19:14:49] * brion: Followup to menu merging: commit the other files. :P [19:14:49] * brion: update platform files for playbook [19:14:50] * brion: Fix for PlayBook files & external link opening (bug 35093) [19:15:13] ill think about it a bit more and make a suggested fix [19:15:14] jdlrobson: what about it just being a totally unique variable name and a array [19:17:48] ideally we don't want to be generating any javascript imo [19:19:43] jdlrobson: can you send the AI files to Lindsey - we never got them [19:19:51] sure no worries [19:20:13] linSmith what's your email? [19:20:31] jdlrobson: no worries! i'll get those to you right now :) [19:20:50] lsmith@wikimedia.org [19:21:00] thanks [19:22:29] sent philinje [19:22:52] tfinc, what's your opinion on the above discussion about extracts? does it make sense to add this functionality to the API? [19:28:04] MaxSem: he is currently at lunch [19:30:06] MaxSem: how are you testing: https://github.com/praekelt/vumi-wikipedia/blob/develop/vumi_wikipedia/wikipedia.py [19:30:28] import sys, text_manglers [19:30:28] str = open('test.txt').read() [19:30:28] print text_manglers.strip_html(str) [19:30:35] ;) [19:31:18] so far I'm just looking at text transforms [19:32:46] MaxSem: okay, makes sense [19:38:07] heatherw: still on IRC? [19:54:12] tfinc - > https://bugzilla.wikimedia.org/show_bug.cgi?id=31891#c4 - no one is taking care of this right? [19:54:22] let me take a look [19:54:37] jdlrobson: we have both 1) a patch for it [19:54:52] 2) we load new points as you move the map [19:55:06] yuvipanda can point you to the patch [19:55:15] that we got from the pune hackathon [19:55:16] Ewwwwwwwwwwwwwwwwwww [19:55:18] the patch from the hack event in pune? [19:55:22] it wasn't really suitable.. [19:55:25] Why does the android app show underlined internal links? [19:55:27] * Reedy barfs [19:55:59] tfinc: jdlrobson is right, and we didn't really accept that patch. [19:56:13] it was bumped off 1.1 as well [19:56:17] did we give the submitter some feedback ? [19:56:35] tfinc: yes, we did [19:56:46] not very specific though - we told him it needs more work and is being bumped off [19:57:22] if i remember correctly the problem was it was showing 1 result for zoom level X, 2 results for zoom level X-1, 3 results for zoom level X-2 etc etc... [19:57:28] doesn't sound like we gave him some clear next steups [19:57:30] steps* [19:57:40] so rather simplistic and I didn't feel it actually resolved the problem that the bug was describing [19:58:51] * jdlrobson cannot find pull request in question [19:59:34] * Reedy blames yuvipanda [19:59:46] fine, blame the Indian! [19:59:47] :D [19:59:49] * yuvipanda looks for it [19:59:51] WFM [19:59:52] ;) [20:00:13] jdlrobson: https://github.com/wikimedia/WikipediaMobile/pull/137 [20:00:27] I'll cover this [20:00:32] I'll give some feedback [20:03:03] does the search api limit results in any way btw - relevance maybe? [20:04:16] jdlrobson, what search API, action=opensearch? it has a limit parameter [20:04:27] sorry context would be useful [20:04:35] in the nearby part of the mobile app [20:04:42] (as well as action=query&list=search) [20:04:47] it returns results based on location [20:05:02] i wondered if that was sorting them by proximity [20:06:34] geonames seem to sort by distance [20:07:17] my API will sort by it, too as it's the only reasonable way :P [20:08:38] tfinc, around? [20:09:47] tfinc yuvipanda : https://github.com/wikimedia/WikipediaMobile/pull/137#issuecomment-4460527 [20:09:51] feel free to add [20:14:54] jdlrobson: k [20:17:55] tfinc is it okay for me to source a copy of illustrator tomorrow if i can find one? [20:18:03] also can you let me know how to expense it? [20:21:47] jdlrobson: https://office.wikimedia.org/wiki/Finance_Corner#Expense_reports [20:22:02] jdlrobson: check to see where lindesy got her copy [20:22:07] k thx [20:22:08] as we might have extra [20:32:38] jdlrobson: I could "source" you a copy ;) [20:35:22] * yuvipanda adds obligatory 'if you know what I mean' [20:35:38] tfinc: just to update - that plugin he pointed out to is not exactly useful for us. [20:36:37] yuvipanda: on a call [20:36:40] okay [20:36:47] just a fyi, no action needed. [20:36:52] k [20:39:16] philinje: i'm back [20:58:52] [WikipediaMobile] yuvipanda pushed 4 new commits to master: http://git.io/aMyV2g [20:58:52] [WikipediaMobile/master] pull in toggle code from known revision and provide translation - Jon Robson [20:58:52] [WikipediaMobile/master] fix Makefile clean - Jon Robson [20:58:52] [WikipediaMobile/master] pin common.css to same revision - Jon Robson [20:59:19] Project WikipediaMobile - Nightly builds build #232: SUCCESS in 15 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/232/ [20:59:20] * yuvipanda: pull in toggle code from known revision and provide translation [20:59:20] * yuvipanda: fix Makefile clean [20:59:21] * yuvipanda: pin common.css to same revision [20:59:21] * yuvipanda: Removed a wild newline [21:19:04] yuvipanda: can you take https://bugzilla.wikimedia.org/show_bug.cgi?id=35105 [21:19:13] since your already working on it [21:19:30] tfinc: yes, just merged it in. [21:19:32] and/or have jdlrobson depending on who's attacking it now [21:19:34] sweet [21:21:13] awjr: how difficult will 35178 be ? [21:21:23] i hate leaving the de-wikimedia project halfway done [21:22:03] tfinc, what's your opinion on the (much) above discussion about extracts for SMS/USSD? does it make sense to add this functionality to the MW API as opposed to porting our text extraction code to Python for vumi? [21:22:17] Reedy: poke [21:22:36] Reedy: so, i'm assuming that the spinner also never stopped spinning for you? [21:22:37] MaxSem: id say so. i'm always in favor of more support in MF/core [21:22:47] okay [21:22:55] with would keep the python implementation really simple [21:22:55] Reedy: did you run make before building/deploying to your phone? [21:22:58] dumb client essentially [21:23:28] Reedy: I think that's the problem. [21:23:54] tfinc: i think it would be of medium difficulty with the challenge being coming up with a sensible way of modifying how MediaWIki handles paths (perhaps expose a hook?) [21:23:59] yuvipanda: which spinner where when why how? [21:24:16] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=35177 [21:24:17] Oh, int eh search bar [21:24:17] yes [21:24:25] so, you need to run make [21:24:28] awjr: sounds like a brion level conversation ;) [21:24:50] I'd guess that's not going to work well on windows [21:25:01] Reedy: people still use that ? [21:25:03] * tfinc ducks [21:25:05] Reedy: yes, so that's an intermediate solution until we figure out how to do that in Ant [21:25:12] because programming in XML ugh [21:25:31] I'll need to factor out a basic MobileFormatter functionalty, will start a RFC regarding its merging to core [21:25:37] Reedy: come to think of it, alternatively I could just convert it to a bash script + a powershell script (for windows) [21:25:43] tfinc: but i dont think adding mobile path support is necessary for 'de wikimiediafication'. you can now use MF without having to exclusively rely on X-Device headers, and can now maintain the mobile view from page-to-page when using useformat=mobile in the query string [21:26:31] tfinc: i talked with brion about it a bit a couple weeks back and he was the one who first gave me the impression the path stuff would be not be feasible without core modification [21:26:59] woot [21:27:07] makes sense [21:27:16] tfinc: anyway, i think MF is actually pretty well usable by someone other than the WMF but there is a lot we can do to make it friendlier for non-WMF [21:27:17] \o/ [21:27:20] i for one would like a /m on my wiki :D [21:27:24] but we can tackle it later [21:27:37] aye [21:27:45] awjr: can you reach out on that thread or a new one about your changes .. and lets get people testing [21:27:48] feedback! [21:28:03] change/update docs as needed too [21:28:04] tfinc: sorry, which thread about which changes? [21:28:15] i for one like having the same url to the same resource, with auto-adjustment for device compatibility [21:28:24] makes it easier to pass links around :) [21:28:42] in an ideal world... [21:28:43] awjr: http://lists.wikimedia.org/pipermail/wikitech-l/2012-February/057936.html [21:28:57] tfinc: np [21:29:19] getting to inbox(0) is quite the fearsome battle today [21:30:13] tfinc, brion: it would be cool to get WURFL working in MobileFrontend so anyone could rely on auto-device detection [21:30:20] * Reedy installs more stuff into cygwin [21:30:45] *nod* [21:30:48] awjr: what our current support level for WURFL within MF now ? [21:31:00] how much does the cache do for us compared to mf ? [21:31:30] Reedy: wah you are on Windows? o_O O_o [21:31:30] okay [21:31:37] Gaming [21:31:42] ah [21:31:51] * yuvipanda looks at his mostly unplayed library in Steam [21:31:52] yay, install make + curl [21:31:52] done [21:32:11] tfinc: im not entirely sure, actually. MF isn't really taking advantage of WURFL at the moment. preilly mentioned something on that same thread with a link to a sample code change to make it go: https://raw.github.com/gist/1590648/86abdf93a99876c609862b28f8dae1b488bded03/MobileFrontend.php [21:32:34] and with some of the changes i've added over the last couple of weeks, i think it would be trivial to integrate that logic [21:33:14] welcome Krinkle ! [21:33:16] so RL [21:34:01] we've talked about RL a number of times internally and id like to move if its feasible. [21:34:17] currently were tackling some feature based work but i can see some time in april to tackle it [21:34:21] maybe before if things move faster [21:34:32] its a nice to have not a need to have right now [21:35:21] k [21:35:36] MaxSem: jdlrobson awjr preilly .. feel free to jump in with more [21:35:42] since i know you've been active on cr and bugs about it [21:35:49] Is there gonna be a deployment of MobileFrontend between current HEAD and port to RL ? [21:36:17] Krinkle: probably yes [21:36:42] Krinkle: also, it is our understanding the RL requires jQuery to work. (Is this true) [21:36:43] yuvipanda, is the save/load code for ios ios-specific or is it really "anything but android"? [21:37:04] preilly: Yes [21:37:07] brion: well, depends on support for Canvas toDataUri [21:37:18] brion: technically I should use it for Android 4.0 too [21:37:20] Krinkle: not all phones support jQuery [21:37:25] whoa [21:37:38] preilly: that's a dealt-with issue afaik [21:37:38] yuvipanda, are you saving images that way? [21:37:44] brion: yes. [21:37:52] Krinkle: dealt with by what? [21:37:53] preilly: full-js to capable browsers, no-js to incapable browser [21:37:54] that might eat extra space for photos; it'll resave them as png i suspect [21:38:06] Krinkle: for RL? [21:38:12] no way to get the original files? [21:38:23] the flip-point is not "can do basic JS" but the flip-point will be "can do RL-level JS" [21:38:24] yes, it does - no mobile browsers support jpeg [21:38:28] last time I checked [21:38:35] fun ! [21:38:42] yes! [21:39:04] Krinkle: so, are you saying if jQuery capable phone use RL if not don't use it? [21:39:21] the few bits saved by not loading jQuery are marginal compared to gains by using it for loading everything together with strong caching [21:39:36] preilly: Yes, that's what I heard from tfinc [21:40:06] Krinkle: it's not about saving bits — it's about jQuery just not working on most lower end phones that do indeed support JS [21:40:08] brion: good that you reminded me, I have a FIXME in that code that I found out how to fix. [21:40:09] * yuvipanda gets on it [21:40:30] whee [21:41:50] preilly: maybe maybe not, I have done 0 research in that area [21:42:02] meh, was afk [21:42:36] All I know is that I'm seeing inefficient stuff happening and general patterns that are coded ad hoc due to what is basically a lack of having ResourceLoader available. [21:43:15] so make RL work on cheap phones that 90% of worlwide users have [21:43:23] Krinkle: so, what does ResourceLoader do to prevent global JS variables for example? [21:43:31] nothing [21:43:35] how is that related? [21:43:53] if you want to create a global variable, you're free to do so. [21:44:05] Krinkle: well, it is the most recent comment I saw on a bug where you stated to use RL [21:44:07] but the only global you need is 'mw', there shouldn't be any other at any point in time. [21:44:25] .. if you're using resource loader [21:44:42] r113644 cr is not about resource loader and not about global variables being prevented [21:45:23] Krinkle: what? [21:45:50] Krinkle: that is what you say in the comment?!? Isn't it? [21:45:57] no [21:46:13] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/KZt0jw [21:46:13] [WikipediaMobile/master] Add geolocation permission for Blackberry Playbook - fixes GPS in nearby view (bug 35179) - Brion Vibber [21:46:28] Project WikipediaMobile - Nightly builds build #233: SUCCESS in 9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/233/ [21:46:29] brion: Add geolocation permission for Blackberry Playbook - fixes GPS in nearby view (bug 35179) [21:46:40] I'm talking about a script (the script being changed in the diff) adding global variables into the window object by names like title, scriptPath, showText, hideText, locale. Which is very likely to break or in practice is already broken. [21:48:13] contrary to PHP, the global scope in javascript is much broader. There's a whole load of stuff in the global scope already by default. There's a reason MediaWiki core builds it's entire tree under 1 global variable (MediaWiki). [21:48:35] Krinkle: but, you say, "My advice would be to either drop all front-end development temporarily and port to ResourceLoader asap, or spend more time on this."… so, how is that not a pitch for RL? [21:48:38] have an

and that variable will be a no-op. [21:49:11] Krinkle: I understand that point you are making about those variables [21:49:26] What I meant is: Either don't fix this script and instead use ResourceLoader (in which you can use existing modules like mw.config), or fix this script. [21:49:55] okay, I understand what you're saying now [21:50:09] Krinkle: but, not all mobile browsers even support JSON [21:50:12] I misread your earlier comment, making sense now too [21:50:18] preilly: that's not relevant [21:50:29] Krinkle: well, it is to c32093 [21:50:39] c32093? [21:50:51] Krinkle: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113644#c32093 [21:51:15] I was responding to jdlrobson's comment 1 line above [21:52:07] JSON stands for JavaScript Object Notation. It is a specification Crockford came up with because he liked javascript and made it a stand-alone standard, separate from javascript [21:52:33] JSON is only JSON when it is transferred as a script (e.g in a server response or database field). [21:52:47] When a literal it is just a javascript object, which we use in javascript every day [21:52:58] var a = { "key": "value" }; [21:53:09] that's a javascript object [21:53:13] or JSON, if you will. [21:53:24] transferred as a string* [21:53:56] that works in every browser supporting javascript that has ever shipped any time. [21:53:57] but, JSON.stringify() and JSON.parse() aren't available in all browsers [21:54:04] those methods aren't relevant in any way [21:54:39] var a = { "key": "value" };