[00:00:07] preilly: just noticed binasher signed off - did he leave for the day? [00:01:03] awjr: yes [00:01:15] preilly: will someone else be able to flush the varnish cache? [00:01:50] awjr: can Ryan_Lane do it? [00:01:57] awjr: also, do we need it? [00:02:26] * Ryan_Lane groans [00:02:26] preilly: im not entirely sure if we do - the footer links have changed [00:02:31] is that enough to require it? [00:02:33] I can do it... [00:02:40] it would be nice if I didn't have to :) [00:02:56] get to work on that :D [00:02:56] Ryan_Lane: ok thanks - hang on a minute [00:03:14] once this scap is done we can dbl check if it's necessary [00:03:25] this is like.. the longest running scap ever [00:04:48] Ryan_Lane: NOTED [00:04:56] :) [00:05:08] hold on, let me open a bug for that, and set the priority to highest [00:06:31] ok preilly, i am enabling zero rated everywhere now [00:06:39] awjr: okay, coolio [00:06:48] 'wmgZeroRatedMobileAccess' => array( [00:06:48] - 'default' => false, [00:06:48] - 'enwiki' => false, [00:06:48] - 'testwiki' => true, [00:06:48] - 'mswiki' => true, [00:06:48] + 'default' => true, [00:06:49] ), [00:07:15] awjr: yeaper [00:07:32] done [00:07:40] awjr: coolio [00:07:47] awjr: it seems to be working [00:07:54] awjr: THANKS! [00:08:02] preilly jdlrobson MobileFrontend deployments are done, please dbl check things are working right [00:08:08] and whether or not we need the varnish cache flushage [00:08:08] yep noticed [00:08:10] looks good to me [00:08:21] had a bit of weirdness with caching but seems to be gone now [00:09:56] it doesnt seem like the squid acl asher set is working right [00:09:57] preilly [00:10:25] o [00:10:53] i wonder if it's because the cookie the ACL is looking for is literally mf_useformat not {$wgCookiePrefix}mf_useformat [00:11:01] awjr: yeah [00:11:02] but you can see the problem on en.m.wikipedia.org in mobiel view [00:11:04] awjr: that is the issue [00:11:05] clicking desktop view [00:11:11] ok yeah you see it. [00:11:29] so preilly, better to change the cookie in code to be just 'mf_useformat'? [00:11:43] awjr: probably the safest route [00:11:47] doing it now [00:13:26] awjr: I'm leaving [00:13:36] awjr: need anything else from preilly before he runs ? [00:13:38] awjr: but, you can text me at (415) 894-2393 if you need me [00:13:49] preilly: one sec [00:14:02] preilly: can you wait til i get this fix out? [00:14:15] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114220 [00:15:40] ok'ed it [00:15:51] preilly: just pushed it [00:16:03] awjr: how does it look [00:16:25] preilly: broken. [00:16:31] the ACL does not appear to be working right [00:17:40] awjr: hmm [00:18:17] also i must've missed something when renaming the cookie because cookie handling is wonky [00:19:13] probably because $wgRequest->getCookie() is looking for $wgCookiePrefix . 'mf_useformat' [00:19:30] awjr: yeah [00:19:32] preilly: should i revert the cookie changes from prod and coordinate with asher tomorrow? [00:19:45] awjr: I think so [00:19:57] awjr: just the cookie stuff? [00:19:58] ok this is going to take a bit to track down all the revs [00:20:11] tfinc: just so you know http://en.m.wikipedia.org/wiki/Wikipedia#refanimation:slide%20refspeed:4000 on the beta turns slide animation on with speed 4000ms, http://en.m.wikipedia.org/wiki/Wikipedia#refanimation:none%20refspeed:1000 turns off animations [00:20:15] awjr: can you just roll back [00:20:22] preilly yeah [00:20:29] feel free to roll the whole change back [00:20:35] its better to get back to a known state [00:20:37] we can try again tomorrow [00:20:40] yeah that's the easiest and quickets [00:20:44] *quickest [00:20:44] and include johns last set of changes [00:20:47] no worries [00:20:52] we'll get it done tomorrow [00:21:40] jdlrobson this way we can get your changes in too [00:22:01] ok scap'ing back to r113973 [00:22:07] k [00:22:08] ok ill push those first thing tomo then sleep now [00:22:18] sorry jdlrobson, thanks for your help today! [00:28:11] ok, scap is still going on. but meanwhile, i've reverted all the MFT revs for the deployment and i'll update the RT ticket with the issue [00:28:18] thanks for your help preilly [00:28:18] k [00:28:44] tomorrow looks wide open for deployments [00:29:36] tfinc: i'll schedule for same time tomorrow [00:29:48] i can't do any earlier on account of fundraising office hours [00:31:21] scap seems to take longer and longer every time i deploy [00:32:17] im off to bed [00:32:18] night guys [00:36:05] awjr: i'm sure preilly can help you out [00:36:33] tfinc: you mean with the deployment tomorrow? [00:36:41] yeah [00:37:04] for sure, i suppose we can coordinate when he's back online tomorrow [00:38:34] in the meantime im gonna schedule for same time tomorrow so we ahve the spot blocked out [00:38:43] good thinking [00:40:23] i'm tinkering around with the latest changes on jons site .. this looks really nice guys [00:45:28] +1 [00:45:30] :D [00:45:42] i can't wait to push out 1.1 so I can start moving/reusing those things in the app [00:46:11] tfinc: Unless any major new issues turn up, I think we should be good for our scheduled thursday afternoon deadline :) [00:48:19] and an RC on Tuesday evening [00:58:59] YuviPanda: woot! [00:59:07] we'll fix a lot of bad reviews in the markets then [00:59:21] also .. our next release needs to be way smaller [00:59:25] this one was too big [00:59:28] too many features [00:59:31] we need to cut back [00:59:37] +1 [00:59:44] but more than way too many features [00:59:51] I think it was the fact that we're syncing iOS + Android [00:59:58] we also fixed a lot of bugs [00:59:59] we need to be able to release in under a two week period [01:00:04] but I'd suggest a 2 week release [01:00:05] oh for sure [01:00:07] and cut features to make it [01:00:08] i'm happy that we did it [01:00:09] +1 [01:00:17] cut cut cut until you do it in 2 weeks [01:00:18] thankfully we have no rush for 1.2 [01:00:30] as the language debate is still raging [01:01:08] tfinc: well, if we go to 2 week release cycles, we'll have much smaller things going out per relaes [01:01:15] I don't see language selection going out with 1.2 [01:01:29] YuviPanda: what do you see in 1.2 tentatively ? [01:01:37] more of Max's API changes + some of Jon's new UI (Reference reveal + collapsible sections) [01:01:47] the former is super important for mobilefrontend [01:02:04] it means that they can change the non beta html, etc to their liking without having to worry about breaking the App [01:02:13] YuviPanda: yes. max has been blocked on any future work by out testing [01:02:27] thats another reason why i don't want to move to any new features for 1.2 [01:02:40] yes, so these wouldn't really be new features as such [01:02:47] exactly [01:02:51] Infact, I think 1.2 should be just those two [01:02:58] so my plan for your dev is to spend it on testing the new api [01:03:01] and tiny fixes [01:03:15] sounds about right! [01:03:22] that way you can also start helping out with mobile front end work [01:03:45] plus id also like you to find some time to do the community testing for jessie [01:04:09] ah yes, that as well. [01:04:15] need to deploy on labs [01:05:33] tfinc: also, we still haven't figured out whose account the fb app is going to be registered in [01:05:40] am testing things around with mine [01:05:48] but obviously that's not ideal [01:06:02] YuviPanda: i'll do it on mine [01:06:18] you'll just have to tell me what to setup [01:06:25] tfinc: yes, that I can do :) [01:09:51] almost time for me to head out [01:09:58] anyone need anything from me before i do? [01:10:47] tfinc: enjoy your evening :) [01:10:58] awjr: need anything before i go ? [01:11:12] tfinc no im good [01:11:16] have a good one [01:11:38] seeya gents [07:40:46] preilly: you around ? [07:43:33] hmm .. this is no good https://bugzilla.wikimedia.org/show_bug.cgi?id=35352 [07:43:54] anyone around who can handle it ? [08:01:11] tfinc i think i know how to fix it but i dont know how to deploy [08:01:27] how complicated is the change? [08:02:52] https://bugzilla.wikimedia.org/attachment.cgi?id=10287&action=diff [08:03:00] but i dont know the code that well [08:03:34] deploying that would be pretty easy [08:03:37] and i have access [08:03:41] but whether it has any side effects i dont know [08:03:46] yeah [08:04:41] but i think any side effects this might cause would be better than not showing this banner [08:05:12] i thought we rolled back yesterday? [08:05:28] * tfinc takes a look at the extension to see if he can see any side effects [08:06:13] i dont think there are [08:06:44] this should only happen when X-CARRIER header is set correct? [08:06:57] yes [08:07:27] and acceptBilling is for when you hit yes [08:08:42] arthur rolled back all the MF changes but kept all the Zero changes as they weren't showing issues [08:08:52] notes here http://wikitech.wikimedia.org/view/Server_admin_log [08:10:03] lets see if i can get my svn trees current enough to push this update [08:10:03] ok thanks [08:13:56] ugh .. my trees are still updating. i'm going to update it right on fenari and see what tests look like [08:14:09] test link : http://test.wikipedia.org/w/index.php?title=File:Die_Wiesem%C3%BCndung_Stich_von_Matth%C3%A4us_Merian_d._%C3%84..jpg&useformat=mobile [08:14:13] * tfinc goes to change it [08:17:20] take a look at http://bit.ly/GAxQiJ and let me know if you still see it [08:18:41] that link sends me to a non-file page [08:18:58] expand the Geschichte section [08:19:01] you'll images there [08:19:09] it takes me to the desktop site :S [08:19:18] but the mobile view doesn't show the banner.. [08:19:36] good. that means your patch is working on test [08:21:27] if you check in your change then i can pick it up on the deployment branch and properly deploy this [08:22:00] ok commit [08:23:36] arghh ive got a readonly version [08:23:36] 1s [08:26:21] k [08:26:31] let me know when you have it and i'll merge [08:26:55] thankfully things have changed much since i did this last http://wikitech.wikimedia.org/view/How_to_deploy_code [08:28:43] arrggh i dont have permission [08:29:04] tfinc: ^ [08:29:15] lame [08:29:17] do you? [08:29:21] let me see [08:29:29] ill pm you what my commit message was going to be [08:38:33] hey preilly you about? [08:45:16] since preilly is responding lets give this a couple of minutes [08:45:38] but baring him saying that this will break things .. all i have to do is run sync-file to push this out [08:47:58] preilly responded. he's ok with the change [08:53:05] pushed? [08:53:23] done [08:54:27] im still getting it.. is there some caching going on? [08:54:28] i'm not seeing the warning anymore [08:54:46] nope [08:54:57] yep [08:55:01] caching related [08:55:07] http://en.m.wikipedia.org/wiki/File:T_C_Derrick_141308.JPG i see it [08:55:10] but http://en.m.wikipedia.org/wiki/File:T_C_Derrick_141308.JPG?r=4 not [08:55:33] agreed. it may take a couple of minutes for the caches to clear on this [08:55:43] so the core issue looks patched [08:55:53] preilly can review it tomorrow and adjust as needed [08:58:09] i resolved the bug [08:58:24] now i can get back to what i was really planning on doing [08:58:48] * tfinc notices that its 2am [08:59:24] awesome.. go sleep :) [08:59:46] i wish that i could … i need to write up some more notes for our budgeting process [09:00:15] since this blew up i likely won't get a chance to draft up the blog post [09:00:25] feel free to start it jdlrobson [09:00:36] you should get your first tech blog post :) [09:00:46] once we deploy tomorrow we can take some good screenshots [09:03:58] ok will start something later today [09:04:06] im gonna go take a shower now :) [10:29:37] MaxSem you there? [10:29:43] yup [10:30:28] ive messed up and im trying to revert a commit [10:30:30] i thought it was svn merge -r 114245:114240 [10:30:36] but it doesn't seem to be working for me [10:30:45] been a while since ive done this [10:30:50] I use TortoiseSVN ;) [10:31:12] doh [10:31:28] could you revert commit 114245 if that's easy for you? [10:31:35] :P [10:31:39] i dont know what's going on here and i have to pop out in a bit [10:33:35] * MaxSem had never understood the need of command-line tools in presence of appropriate GUI tools [10:34:23] thanks MaxSem [13:46:42] jdlrobson: because we're scheduled to release on thursday :) [13:46:48] don't want to introduce new features this late [13:46:58] ok . that makes sense :) [13:47:04] ill pull that a bit later [13:47:08] im on a train at the moment [13:47:09] sure! [13:47:48] feel free to merge https://github.com/wikimedia/WikipediaMobile/pull/180 as I have no idea what's going on there and would only be taking your word for it :) [13:48:01] also the QT stuff - care to explain it to me? [13:48:11] jdlrobson: ah, so that's porting our code to qt based platforms [13:48:16] which right now is only the Nokia N9 [13:48:45] jdlrobson: ah, okay :) that pull req also has some js parts you might want to look over for style. Will merge [13:49:33] the only line i dont like is if(!window.plugins) window.plugins = {}; [13:49:44] in TwitterPlugin.js [13:49:56] well, that seems to be standard on most pg plugins? [13:49:59] what would you suggest? [13:50:01] I'd prefer if(!window.plugins) { \nwindow.plugins = {};\n} [13:50:05] ah [13:50:07] in terms of style [13:50:08] the lack of braces [13:50:08] yes [13:50:15] let me change/fix that. [13:51:28] tunnel! [15:55:24] greetings all [15:56:58] nice write up http://bradfrostweb.com/blog/web/responsive-web-design-missing-the-point/ [15:57:00] jdlrobson: --^ [16:00:31] jdlrobson: ready to meet? [16:01:03] yes [16:03:07] Hello all ! I am a beginner android developer and would like to develop an app for wiki for the GSOC. I read the project ideas on the GSOC page but did not understand the app fully [16:03:13] maybe someone can help? [16:03:32] hello arkiver [16:04:09] yuvipanda, hello ! [16:05:02] have you seen our current app? [16:05:04] muppet.wikia.com [16:05:44] arkiver: have you checked out the current app? [16:06:45] I wasn't aware of the current app. but i came to know about it when i was surfing on the ideas page. [16:07:40] jdlrobson: http://blog.wikimedia.org/2011/12/02/mobile-full-screen-search/ [16:08:13] jdlrobson: http://blog.wikimedia.org/2011/10/27/wikimedia-mobile-opt-in-beta/ [16:08:14] arkiver: you should try it out :) [16:08:55] yuvipanda, doing it now! Maybe i can extend it to add functionality!? [16:09:12] arkiver: not a bad idea! [16:11:05] yuvipanda, i'll play around with it maybe [16:11:22] arkiver: yes! [16:11:28] also talk to sumanah on #mediawiki - she's our GSoC admin [16:12:56] yuvipanda, Maybe i can add a feature to open tabbed windows in the app on long pressing a hyperlink? [16:13:11] yuvipanda, yep ill ping her :) thanks alot :) [16:14:09] sumanah doesn't seems to be online. Ill catch her after a while maybe :) [16:15:06] arkiver: yes! [16:15:12] arkiver: and i'd suggest first checking out the current app [16:15:35] hi, tfinc I just saw the ad for the Series40 app http://hire.jobvite.com/Jobvite/job.aspx?j=ohAhWfwO&b=nqtsKhwR [16:15:50] question: is Nokia involved in the financing of this? [16:16:00] actually the question is: [16:16:25] Can I help in any way finding funds for this activity or is it all setllet already? [16:16:38] settled [16:16:48] yuvipanda, yes i am looking at the current app just now and i noticed it dint have a feature for opening in tabs (i'm used to opening everything in tabs) [16:16:51] so thought of it! [16:17:58] Actually I wanted an opinion whether it would be a desirable extension to the app.. ? [16:18:12] arkiver: :) well, personally not. [16:18:45] arkiver: there are plenty of other things we've on the mobile roadmap though. [16:19:04] yuvipanda, oh... [16:19:17] really? can you suggest me something ? [16:19:44] arkiver: tfinc or philinje would be the best people for that, once they're out of their calls [16:19:46] I'm still in the learning phase of android dev [16:19:58] arkiver: in the meantime, i suggest you dig around our app and solve a few bugs to get yourself familiar with the code [16:20:20] yuvipanda, alright :) [16:20:45] yuvipanda, your blog is pretty neat :) [16:20:52] arkiver: oooh, thanks :D [16:22:49] welcome arkiver ! [16:23:30] tfinc, :) [16:23:46] qgil: we did talk to nokia about supporting this but that proved the be more difficult to manage then expected [16:24:42] tfinc: hum, lemme check here. I'll let you know if there is some progress. [16:24:51] k [16:25:07] tfinc: was the problem the usual NDA-based Nokia process or something else? [16:25:27] if you can give me the names of the people you talked to it will save me time [16:25:45] yuvipanda: i've noticed that the latest betas W and X icon become really pixelated while were loading a page [16:25:49] yuvipanda: do you see the same thing ? [16:25:56] qgil: kul would know [16:26:03] tfinc: hmm, no? [16:26:10] when loading a page as in only when loading a page? [16:26:25] btw tfinc & co: congratilations for the large list if idlers in this channel! If you remember, a year ago... :) [16:26:32] haha [16:26:35] yes [16:26:38] we've grown [16:26:38] ok, I'll email kul [16:27:19] so tfinc the muppet wiki fixed positioning behaves the same as far as i'm concerned unless i've misunderstood you (a touch start event doesn't make the banner move) [16:27:23] hey qgil [16:27:50] Hi kul - you here! [16:28:31] kul: if you give me the names of your Nokia contacts ref Series40 app I might be able to help moving some funding forward - if you want that funding of course [16:28:50] how goes it? hey…I had an intern here try to find me more info on the worldwide S40 and S60 breakdown. I met with him this morning and Nokia won't tell him anything. Where can I get this data? [16:28:51] yuvipanda: yeah, its right when an article is loading [16:29:06] yuvipanda: suddenly both icons get slightly pixelated [16:29:18] "Nokia won't tell" doesn't help me. Give me names, please [16:29:30] tfinc: hmm, let me poke at it [16:29:39] tfinc yuvipanda : I migrated the existing bug report for the pixelated X icon to Wikipeda App [16:29:43] yuvipanda: let me take a screenshot [16:29:51] qgil: recently we've been dealing with Nokia India. I've gotta get to a meeting. I'll follow-up with you [16:29:55] pfhayes: yeah, i saw. thanks [16:30:14] kul Nokia India, when the people that can give you all the info (and funding) are in Sunnyvale??? [16:30:26] Jeffrey Rufus [16:30:44] kul, you have my email please explain what you need [16:31:27] will do. catch up w/ you soon [16:33:24] ok kul, no idea how you got to Jeffrey - you had Houman Forood as Nokia contact for Series40, I could also have helped... Anyway, not too late if we can still find a budget to cover that job request for a contractor [16:33:29] yuvipanda: http://bug-attachment.wikimedia.org/attachment.cgi?id=10290 [16:33:33] notice the W and the X [16:33:52] wah [16:33:53] i do [16:33:56] the problem goes away after the page finishes loading [16:34:06] but it looks fugly as its happening [16:34:16] hmm, points to our switch from animated gif to css animation for loading spinner causing issues [16:34:23] let me poke at it right after i am done with fb [16:34:50] yuvipanda: k. the animation is really nice so hopefully we can keep it :) [16:35:22] :D [16:39:27] tfinc: what's the correct name for the ID you need to get someone's phone to run the iphone beta app? a friend of mine is interested in trying it out. [16:39:35] UDID [16:40:13] and here are some easy ways at finding it http://www.innerfence.com/howto/find-iphone-unique-device-identifier-udid [16:40:23] sweet. [16:41:51] rootin also helps, no? :P [16:43:18] :D [17:02:42] tfinc: do you have a second [17:02:59] preilly: doing a phone screen so i'll be distracted [17:03:02] preilly: whats up? [17:03:50] tfinc: oh, just stop by after [17:15:56] preilly, does vumi split content to messages automatically? cause sms_content = content[:250] looks wrong [17:30:29] OuKB: I think it's only that way for testing on the jabber instance [17:45:10] preilly is there any way aboutLink() can generate the text 'About' rather than 'About Wikipedia' as a label..? context = http://mobile-geo.wmflabs.org/w/index.php/San_Francisco?useformat=mobile&mobileaction=opt_in_mobile_site (footer) [17:46:25] tfinc: http://www.flickr.com/photos/yuvi/6854322464/in/set-72157629263654614 thought you might like [17:46:41] yuvipanda: awesome [17:46:55] i heart #6 [17:46:58] :D [17:47:07] morse code? [17:47:20] but i don't see base64 .. where is it? [17:47:20] there'ah [17:47:22] base 64 [17:47:22] yes [17:47:27] from the bottom [17:47:28] centerish [17:47:35] Z3Nhd.. [17:47:37] ends in == [17:47:58] ahh i see it now [17:48:15] jdlrobson: where is aboutLink()? [17:48:30] in FooterTemplate [17:48:32] from the skin [17:48:33] $aboutLink = $skin->aboutLink(); [17:49:06] tfinc: :) [17:49:19] there's also greek there - one of the tawiki contributors was learning greek alphabets in his spare time [17:50:16] jdlrobson: it's return $this->footerLink( 'aboutsite', 'aboutpage' ); [17:50:24] quite the WebM/Theora/H.264 debating raging on wikitech [17:50:35] jdlrobson: and private function footerLink ( $desc, $page ) {... [17:50:48] tfinc: was sad to see moz 'give in' [17:51:23] jdlrobson: so, without parsing the site name out I've got no idea [17:51:28] mm [17:51:30] that's annoying [17:51:41] jdlrobson: you could str_replace $wgSiteName with '' [17:51:46] also anyway to make http://mobile-geo.wmflabs.org/w/index.php/Bridal_Veil_Falls faster? [17:51:53] very slow server for me [17:52:09] preilly that could work but there is a danger i'll change the href as well no? [17:53:43] jdlrobson: does mobile geo have memcached installed and configured? [17:54:04] nope not installed so that would be a good starting point :) [17:54:19] jdlrobson: you would need to probably use a regular expression instead of a straight str replace [17:54:32] that sounds horrible [17:54:39] awjr: preilly feel free to increase the window for the mobile deployment today so that we don't have to stay super late [17:54:49] surely it would be better to change the function footerLink to take an argument for the label? [17:56:44] preilly, tfinc: the earliest i could realistically start actually deploying is probably 2pm PDT due to a combination of my fundraising office hours and needing time to work out the squid/cookie stuff. but preilly, if you want to get a jump on it, that's cool too [17:58:11] awjr, btw - you can deploy my latest fixes this time [18:00:36] awjr: we will probably need to wait until 2 anyways with the squid stuff etc [18:01:17] sure OuKB i think that should be fine [18:01:28] cool [18:01:41] preilly: yeah sounds good. i'll go ahead and adjust the deployment window on the calendar to 2pm-4pm PDT today [18:30:51] yuvipanda, did the wikipedia app ever not register touch events on android 4/ICS? [18:31:06] tonyc_: no, brion tests it on ICS. seems to do okay... [18:31:33] awjr or OuKB can you please review http://www.mediawiki.org/w/index.php?path=%2Ftrunk%2Fextensions%2FZeroRatedMobileAccess&title=Special%3ACode%2FMediaWiki&limit=500 [18:31:44] on it [18:32:38] yuvipanda: so far three people with ICS has tested wiktionary and they all say they can not touch anything in the main screen, but the menu and search bar works fine [18:33:22] blaaargh, why ssh-add asks for a password for a password-free key? [18:33:45] I have ICS [18:33:46] can ttest [18:33:50] tonyc_: ^ [18:34:12] lifeeth: can you also double test the wikipedia beta to make sure that's not occuring here? [18:34:30] current beta? [18:35:20] I have an older build from about 2 weeks [18:35:32] which works fine [18:35:36] lifeeth: let me link you to it. [18:35:44] Okai [18:35:45] lifeeth: you aren't subscribed to mobile-l? [18:35:48] bad lifeeth bad :P [18:35:54] I am I thought [18:35:56] tonyc_: can you link lifeeth to a wikt apk? [18:36:10] lifeeth: http://lists.wikimedia.org/pipermail/mobile-l/2012-March/005436.html [18:36:16] Traveling - so not actively checking m-ls [18:36:25] preilly, why all your variables in a class are static? [18:36:50] umm i can email it to him [18:37:04] lifeeth: ok [18:37:58] OuKB: for mild performance reasons but, no other real reason [18:38:33] I don't see any heavy meber function usage that would justify this [18:39:31] OuKB: there isn't [18:39:52] preilly, in https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113743 - shouldn't it stop outputting after $wgRequest->response()->header( 'Location: ' . $redirect ); ? [18:40:13] s/meber function/class variable/ [18:41:53] OuKB: yeah, it probably should [18:42:02] yuvipanda : tonyc_ I can touch stuff on the main screen [18:42:20] theFeatured article shows up [18:42:22] and the links work [18:42:28] so does the scrolling [18:42:31] on CM9 ICS though [18:42:34] SGS2 [18:42:36] lifeteeth: can i email you a recent apk? [18:42:43] Sure [18:42:48] @gmail [18:42:58] tonyc_ : its lifeeth no et :) [18:43:06] haha oops [18:43:14] OuKB: Mobile Frontend doesn't exit after redirects either [18:44:07] OuKB: which is probably not good [18:44:18] ok, marking todo + ok. looks kinda sub-optimal to serve lods of HTML with HTTP redirects [18:44:41] OuKB: yeah, totally [18:45:04] OuKB: do we typically call exit() after the redirect or is there a better MW way to do it? [18:45:43] hmm, exit sounds too rough [18:45:47] * OuKB greps [18:46:41] lifeeth : okay, sent [18:46:53] On edge.. will take about 5 min :) [18:47:29] [WikipediaMobile] yuvipanda pushed 6 new commits to master: http://git.io/3kI57Q [18:47:29] [WikipediaMobile/master] Get rid of ShareKit - YuviPanda [18:47:29] [WikipediaMobile/master] Ripped out ShareKit plugin - YuviPanda [18:47:29] [WikipediaMobile/master] Ripped out ShareKit integration with XCode - YuviPanda [18:48:03] Project WikipediaMobile - Nightly builds build #243: SUCCESS in 15 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/243/ [18:48:03] * yuvipanda: Get rid of ShareKit [18:48:04] * yuvipanda: Ripped out ShareKit plugin [18:48:04] * yuvipanda: Ripped out ShareKit integration with XCode [18:48:05] * yuvipanda: Added Share via Twitter functionality [18:48:05] * yuvipanda: Check for twitter being available [18:48:06] * yuvipanda: Added RIL integration [18:48:21] preilly, OutputPage::redirect() [18:50:23] OuKB: so, what are you saying? [18:51:04] $wgOut->redirect( $redirect ); [18:51:09] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/QDlmhQ [18:51:09] [WikipediaMobile/master] Fixed minor js style issues - YuviPanda [18:51:09] return; [18:51:20] or something like that [18:51:23] Project WikipediaMobile - Nightly builds build #244: SUCCESS in 8.1 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/244/ [18:51:24] yuvipanda: Fixed minor js style issues [18:51:33] this way MW will deinitialize properly [18:51:43] OuKB: okay [18:55:53] lifeeth: thanks! [18:56:05] tonyc_ : Anytime [18:59:08] OuKB: it's not working [18:59:12] $out->redirect( $redirect ); [18:59:34] I'll look to it later [18:59:50] pfhayes: wikipedia doesnt have our problem in ICS, so i have to look into our own code [19:01:13] tonyc_: okay, that's good to know. once i send you the build instructions, though, it would be a good idea to build both the wiktionary and wikipedia code to see if maybe it's something on your end. if you only see it in wiktionary then we have a serious issue [19:02:58] pfhayes: the weird part is that it works fine in the emulator :( [19:03:08] tonyc_: hmm [19:03:26] it might be a build issue then. i have class soon but i'll send you the build instructions after [19:03:38] pfhayes: cool [19:04:17] preilly, reviewed [19:04:33] OuKB: thanks! [19:12:26] what would make $out->redirect( $redirect ); not work correctly? [19:17:32] preilly: what is the behavior you're seeing? any errors? [19:28:21] * tfinc is excited to see todays new beta features  [19:31:13] awjr_lunch: it no workie [19:32:08] awjr_lunch: trying to replace $wgRequest->response()->header( 'Location: ' . $redirect ); with $out->redirect( $redirect ); [19:32:19] awjr_lunch: but, the later doesn't work [19:32:39] on line 164 of ZeroRatedMobileAccess.body [19:58:11] preilly: hmm [19:58:21] no output before the redirect, i assume? [20:01:10] anything else needed before the deployment? [20:01:23] besides update log, which I'll update [20:02:24] OuKB: i think we' re ok - code review backlog looks good [20:02:52] OuKB: if you've got some time, testing changes you see on the deployment list locally would be great [20:05:33] * yuvipanda mumble mumbles facbook apple sucks etc [20:07:50] so to figure out which line this thing is throwing up, I have to keep putting console.logs at various places till I find ou [20:07:50] t [20:07:55] how wonderful [20:10:47] Single greatest PITA with PhoneGap debugging [20:11:21] yuvipanda: still going badly? [20:11:27] devgeeks: yup [20:11:37] single greatest PITA with PhoneGap debugging is that it doesn't exist? :P [20:12:44] basically [20:12:57] actually... if there were just LINE NUMBERS [20:13:29] in stead of the classic "undefined undefined did a undefined thing with undefined's mother on line undefined" [20:15:43] devgeeks: sigh [20:15:43] yes [20:15:58] [INFO] Error in error callback: ActionSheet2 = TypeError: 'undefined' is not an object [20:15:59] gives me nothing [20:16:12] ActionSheet2 *very descriptive* [20:16:23] fancy: http://jhollingworth.github.com/bootstrap-wysihtml5/ [20:16:33] At least it isn't taunting you like the ones that TRY to give you a line number but the LINE NUMBER is undefined [20:16:55] devgeeks: haven't had those yet, though i've had a javascritp error in line 1 of index.html [20:17:03] *javascript [20:17:08] tfinc: very! [20:17:14] hah [20:17:25] i wouldnt call that wsiwyg [20:18:07] * yuvipanda continues manually placing log statements to figure out line number [20:19:04] do try/catches help? [20:19:13] * OuKB headbangs [20:19:17] devgeeks: not really. [20:19:24] OuKB: listenint to metal much? :P [20:20:15] devgeeks: i think i'm going to give up on the phonegap plugin [20:20:21] and just directly interface with the facebook ios sdk [20:20:41] means it will work only for people who have facebook installed, but that's okay [20:21:23] I would like to see some stats on it, but I would imagine that would be fairly safe on iOS [20:21:52] devgeeks: already twitter sharing is restricted to 5.0 devices [20:21:59] yeah [20:22:04] so I think this is fine [20:22:09] but we've seen stats on THAT [20:22:23] iOS 5 has like 97% or something [20:22:34] Even Instapaper left iOS 4 behind [20:22:37] :) [20:26:12] devgeeks: also, the README has been modified 2 hours ago, but the 'SKIP' stuff is still there: https://github.com/davejohnson/phonegap-plugin-facebook-connect/commit/36c4c4c1e8d0088a3874c65adbef2922a7a17084 [20:27:29] heh [20:28:28] steve is in Singapore at the moment, but you *could* just see if he'll respond? Maybe poke him on Twitter? [20:28:39] phewww, noticed a bug at the last moment :] [20:29:02] @stevesgill [20:30:15] BBIAB [20:30:22] devgeeks: not sure if that's a significant enough bit to poke people in s'proe with [20:30:25] i do have a pull req there [20:30:25] k [20:42:02] preilly: can you take a look at https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114306 and make sure it's not stupid? i think this will solve the cookie/squid problem [20:42:41] ooo, fb share works finally. [20:43:03] it basically reverse-engineers the desktop view URL (Eg non .m domain) from the current URL and mobile URL template. [20:43:31] this way we can display the non- .m URL for the Desktop view link, which will ensure the rquest gets directed to the squids rather than varnish, so the ACL can do its magic [20:47:20] yuvipanda: \o/ [20:47:54] still weird though, I need to figure out a way to not ask for authentication every single time [20:48:16] also, the solution was to simply ignore half the docs from the phonegap plugin and read the source code :D [20:53:07] preilly, how do I run vumi tests? [20:56:53] jdlrobson: review/pull https://github.com/wikimedia/WikipediaMobile/pull/179 [20:56:53] ? [20:57:01] sure [21:01:17] wooh, facebook works (mostly!) [21:04:04] preilly: you there? [21:04:47] devgeeks: directly using the sdk via the plugin instead of trying to use the fb js sdk (why?!0 works [21:07:01] awjr: that looks okay [21:09:55] preilly: ok thanks. im going to start merging and get things up on test wiki now. i wish test.m.wikipedia.org worked so we could test the cookie stuff better [21:10:05] nothing like testing in production! [21:10:37] awjr: http://blogs.msdn.com/cfs-file.ashx/__key/CommunityServer-Blogs-Components-WeblogFiles/00-00-01-32-02-metablogapi/7317.image_5F00_0F65063B.png [21:10:50] damn right. [21:10:56] you should print that out and put it on your wall [21:10:57] :D [21:11:11] hahaha now i wish i had bought the color printer instead of the b&w [21:11:22] print it out on your next visit to the office [21:11:30] yes! [21:11:36] which is next week [21:11:44] that's a swell URL [21:12:17] tfinc: facebook sharing integrated :) [21:12:25] woot [21:12:41] tfinc: jon raised a minor js style issue + the jagged icons. Think we could do an RC after those [21:12:50] hmm, there's an RTL bug. damn [21:12:54] tfinc: that is a fitting URL for that image [21:13:17] it was the first google image result [21:15:28] wow [21:16:00] awjr, you don't work at 149 New Monty ? [21:16:24] OuKB: currently no. i'm in the middle of the desert in arizona [21:16:31] neat [21:16:39] :D [21:16:55] i had been working in the office up until a month ago when i moved out here to be with my fiance [21:17:05] how's connectivity in the desert? [21:17:30] here at my home office it's a hell of a lot better than the WMF office :p [21:17:52] fiancé, you mean :P [21:18:03] you and your fancy accents [21:18:13] that's racist! :P [21:18:46] yuvipanda: you need to link the gif to say that [21:18:55] ! [21:19:11] http://dancingczars.files.wordpress.com/2011/11/thats-racist.gif [21:19:49] preilly: my gif collection is pretty empty now, sadly. [21:20:59] lol at 'this video has been blocked by viacom' on http://knowyourmeme.com/memes/thats-racist [21:21:22] preilly, OuKB, jdlrobson: deployment changes are up on testwiki [21:21:31] k thx [21:21:48] k thx [21:21:56] * preilly sounds british now [21:23:07] i thought that was more hipster key saving sms-speakers [21:23:14] though I guess that's just 'k tx' [21:24:02] jdlrobson: i don't see name='' tags there [21:24:20] ok just wanted to check yuvipanda [21:24:28] looks fine to me apart from those 2 comments i made [21:24:47] jdlrobson: will remove that false. shouldn't affect anything. [21:25:10] k [21:25:32] jdlrobson: i'm going to push another commit directly to master (facebook integration). is that fine? [21:28:18] so awjr - http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/MobileFrontend/MobileFrontend.i18n.php has 'mobile-frontend-regular-site' => 'Desktop view', [21:28:29] but test has the translation as 'View this page on regular Wikipedia' [21:28:33] bit confused with what's going on there [21:28:46] jdlrobson: message cache [21:28:51] jdlrobson: that is a message cache issue more than likely [21:28:54] ok [21:28:55] im not sure how to refresh it directly on testwiki [21:29:08] but when i run scap, it rebuilds all the message caches [21:29:30] * OuKB WTFs at libxml [21:30:02] I'm fucking tired of this crap behaving differently with every version and platform [21:34:30] OuKB: yeah [21:34:59] things look ok to me on test. preilly, OuKB, jdlrobson - any reason not to push to production? [21:35:17] awjr: from my stand point it looks okay [21:35:53] not that i can see [21:36:15] go for it. I have a pending fix, but since it's a new API I guess it can live for a few minutes slightly broken [21:36:33] OuKB: well, we should wait for that fix don't you think? [21:36:39] OuKB: i can wait a few minutes if you want [21:36:41] no big deal [21:36:48] one sec [21:38:08] awjr, 114313 [21:38:32] jdlrobson: fixed the return false. [21:38:38] seen yuvipanda [21:38:58] awjr: have you pushed yet? [21:39:06] jdlrobson: no [21:39:15] might have found some weirdness.. 1s [21:39:18] OuKB: ok'd [21:39:19] k [21:39:24] yuvipanda: is there an easy way that we an opt our apps into the beta ? [21:39:27] can* [21:39:33] so that we can pick up the new ui changes today [21:39:48] yep some firefox weirdness. [21:40:07] tfinc: there is no 'easy' way as such. [21:40:45] if you want me to do that (reference reveal + new expanders) - it is easy enough to do. A day or so, I guess [21:41:03] but i'd ideally want to push that to 1.2 [21:41:16] OuKB: your fix is live on testwiki [21:41:29] yuvipanda: just scrolled up... serious ?!? [21:41:36] yuvipanda: so were going to move these features out of beta before 1.2 [21:41:50] yuvipanda: so it'll hit the app [21:41:56] and it would be good to test beforehand [21:41:58] tfinc: i was assuming 1.2 would be a 2 week release. [21:42:22] tfinc: and unless the html has changed drastically (I'll check) it should still not affect 1.1 [21:42:29] yuvipanda: we should test [21:42:51] tfinc: wait a second. [21:42:54] do you mean 'we' should test [21:43:07] or do you mean we should test and put this in 1.1? [21:43:14] if you mean 'we' shoudl test, fully aggree. That I can rig it up [21:43:19] awjr: r114315 [21:44:19] i want to see what the app (v1.1 with its current features set) will look like when we move our changes out of beta testing and into default [21:44:33] to see who our new changes match the app chrome [21:44:43] yes, that I can do [21:45:04] looks good [21:45:12] [WikipediaMobile] jdlrobson pushed 2 new commits to master: http://git.io/cdo-Ww [21:45:12] [WikipediaMobile/master] Fix scrolling when tapping references - YuviPanda [21:45:12] [WikipediaMobile/master] Removed unneccessary return false - YuviPanda [21:45:20] tfinc: am hunting down final few bugs before an RC (RTL + your bug). will do once this goes out :) [21:45:20] s/who/that [21:45:24] sure [21:45:26] Project WikipediaMobile - Nightly builds build #245: SUCCESS in 8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/245/ [21:45:27] * jdlrobson: Fix scrolling when tapping references [21:45:27] * jdlrobson: Removed unneccessary return false [21:45:28] no rush [21:45:45] i predict at least a week or two of testing the new ui changes [21:46:46] jdlrobson: your change should be live on test [21:47:07] perfect [21:47:38] looks good to me [21:47:48] tfinc: jdlrobson when do you guess the new changes will go out of beta and as 'default'? [21:48:03] yuvipanda: like i said. at least a week or two [21:48:07] but not much more then that [21:48:13] hmmm [21:48:25] it depends on the feedback that we get [21:48:28] but i want to move quick on it [21:48:34] in that case 1.1 itself must be prepared to work properly with the changes [21:48:54] yuvipanda: yes. thats why i want to test [21:48:56] OuKB, jdlrobson: everything OK for deployment? [21:49:01] yes [21:49:02] i think so awjr [21:49:04] so that we don't get the same surprise that we got last week between mobile app and mobile web [21:49:08] ok here goes. [21:49:38] tfinc: ok [21:50:23] yuvipanda: now eventually we'll want to properly decouple the app so that were not impacted by these kinds of changes [21:50:31] but this is what happens when you screen scrape [21:50:34] and were guilt of it [21:50:37] guilty* [21:50:39] yes, that's the plan for the 2 week 1.2 release. [21:52:39] \o/ [21:52:52] yuvipanda: should I find and reopen the not scrolling to the top bug? [21:53:12] Reedy: it *just* got fixed, and I think I mentioned it in the bug as well [21:53:31] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=33913 [21:53:33] just? [21:53:46] No, not that one [21:53:51] Reedy: as in, fixed yesterday + merged today [21:53:59] Reedy: oh? [21:54:03] there's another one? [21:54:08] Ya [21:54:09] Start on a page, scroll down [21:54:16] Select a link [21:54:23] you stay at the same amount of scroll on the new page [21:54:40] ICS [21:55:41] Reedy: that's a new one [21:55:47] was there a bug filed for this? [21:55:53] No [21:55:56] I seem to recall it happening before [21:56:11] Reedy: please file one, let me boot up a 4.0 emulator to look at it [21:56:18] ook [21:58:36] 35369 [21:58:44] Reedy: thanks [21:59:07] tfinc: it is caused by move to CSS animations :( (moving back to gif fixes it) [21:59:13] i'd want to keep the css animation too, so let me look around [22:00:59] * jdlrobson has a mouse fail [22:01:13] grr [22:01:33] * jdlrobson will have to reboot [22:05:39] sheesh, no more fatal @Obama article [22:06:00] OuKB sync is still going [22:06:11] but… almost done [22:06:11] i think [22:06:21] I already see the new code:) [22:06:25] :D [22:07:18] tfinc: sent you a first draft [22:07:24] jdlrobson: k [22:07:32] jdlrobson: poke [22:07:35] preilly, jdlrobson, OuKB: push complete [22:07:35] hey yuvipanda [22:07:44] i think im caching awjr [22:07:54] cacheing? [22:07:54] :) [22:08:01] old css been applied [22:08:10] ah, nvm [22:08:13] jdlrobson one sec [22:08:14] jdlrobson: feel free to throw this on google docs so that we can edit it together [22:08:32] jdlrobson: when do you think you'll have time to look at a css aliasing bug? [22:08:51] tfinc: shared [22:09:08] css aliasing bug yuvipanda? [22:09:13] link? [22:09:17] jdlrobson: commit 009be9a949c5b5dc1a398777a8e73f9b095f201d. [22:09:20] let me find the bug link [22:09:47] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=35231 [22:09:53] jdlrobson try now [22:10:14] reverting that commit (and going back to animated gif) fixes the issue [22:10:25] im not seeing any open pull requests yuvipanda [22:10:42] okay, let me rephrase. [22:10:58] that bug is being caused by that commit, and I've no idea why. was wondering when you'd have time to look at it. [22:11:02] jdlrobson: can you confirm things look ok now? [22:12:35] it looks ok to me awjr [22:12:39] great [22:12:43] ok i see yuvipanda [22:12:46] ill look at it tomorrow [22:12:50] jdlrobson: okay [22:12:54] wasn't on my radar [22:12:56] binasher: just pushed the changes and things generally look ok but i think the varnish cache needs to be purged [22:13:08] im still seeing old stuff on some pages [22:13:10] jdlrobson: tfinc just bought it up. [22:13:13] jdlrobson: thanks! [22:13:20] oh binasher is not on anymore [22:13:28] awjr: binasher left the chat room. (Quit: binasher) [3:00pm] [22:13:40] he has a nack of leaving right before i need him [22:13:44] preilly: is he in the office? [22:13:59] damn, i'm not able to find the bug i'm looking for. grr [22:14:01] awjr: no [22:14:07] awjr: he left to go to Kiva [22:14:08] * awjr grumbles [22:14:22] awjr: ping Ryan_Lane [22:14:28] Ryan_Lane: if you flush the varnish cache i'll buy you a drink when im in town next week [22:14:41] awjr: see that is how it's done [22:14:53] :p [22:14:57] I would have offered hookers and blow [22:15:12] but, they both serve the same purpose I suppose [22:15:24] preilly: you gotta start low, i probably would'v gotten there if he had refused [22:15:40] awjr: duly noted [22:16:04] preilly can you reach across the cube and poke Ryan_Lane? [22:16:19] awjr: actually he is in a meeting with legal ATM [22:16:26] sigh. [22:16:47] awjr: maybe maplebed can do it? [22:17:16] maplebed: any chance you can flush the varnish cache for mobile? the usual suspects are unavailable [22:17:19] huh? [22:17:20] no. [22:17:21] sorry. [22:17:23] :( [22:17:30] unless you point me at documentation. [22:17:31] not even for a drink? [22:17:39] ... [22:17:42] what's that? [22:17:47] precisely. [22:17:59] maplebed: it is documented [22:18:05] mapelbed: http://wikitech.wikimedia.org/view/Varnish#One-off_purges [22:18:19] at least - i assume that's it [22:18:23] preilly does that look right? [22:18:32] doesn't look right to me. [22:18:51] that'll purge one specific file [22:19:00] awjr: that's for bits [22:19:03] awjr: not mobile [22:19:16] preilly: do you have any idea where varnish for mobile is documented? [22:19:24] * OuKB points maplebed at powercycling [22:19:27] awjr: dsh -g mobile "varnishadm ban.url . ; varnishadm -n frontend ban.url ." [22:19:36] awjr: from http://wikitech.wikimedia.org/view/MobileFrontend [22:19:50] binasher: you should hide now [22:20:25] ah, maplebed: http://wikitech.wikimedia.org/view/MobileFrontend#Cache_purging [22:20:27] * OuKB plays a good henchman and holds binasher for preilly [22:20:36] [WikipediaMobile] yuvipanda pushed 2 new commits to master: http://git.io/1RbJig [22:20:36] [WikipediaMobile/master] Facebook sharing works - YuviPanda [22:20:36] [WikipediaMobile/master] Causes aliasing of other images in the header - YuviPanda [22:20:39] although now that binasher's here... [22:20:50] Project WikipediaMobile - Nightly builds build #246: SUCCESS in 7.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/246/ [22:20:50] * yuvipanda: Facebook sharing works [22:20:51] * yuvipanda: Causes aliasing of other images in the header [22:20:56] binasher: well, he is at ACC-KIVA MICROFUNDS [22:21:07] it's probably good to have other opsen knowing how to do this though for time like when binasher is not here [22:21:36] * preilly sends missile to 37.77493, -122.419416 (37°46'30"S -122°25'10"E) [22:22:03] ah mapelebed sorry sent link for purging, we need flush: http://wikitech.wikimedia.org/view/MobileFrontend#Flushing_the_cache [22:22:29] preilly, SF? [22:23:56] awjr: those look decent. [22:24:15] OuKB: 875 Howard Street Suite #340 San Francisco, CA 94103 USA [22:24:29] maplebed: cool mind taking a crack at it? [22:24:31] and, to confirm, unlike the rest of our environment, flushing the mobile cache completely won't destroy us? [22:24:39] ah [22:24:41] preilly ^ [22:24:44] maplebed: nope [22:24:50] awjr: see above [22:25:03] noted [22:26:05] * maplebed checks the dsh group to see if it's up to date. [22:26:35] looks ok... [22:26:37] tfinc: thoughts on doing a RC early tomorrow? [22:26:52] yuvipanda: sure [22:26:56] yuvipanda: http://i.imgur.com/k0yJx.jpg [22:27:08] i need a reverse of that [22:27:11] ok, preilly, awjr - running the flush now. if everything comes crashing down, blame the documentation. [22:27:23] done. [22:27:31] maplebed \o. [22:27:32] er [22:27:34] \o/ [22:27:42] one-armed hooray! [22:27:47] are you sure it worked? [22:28:05] maplebed: it appears to have [22:28:55] and preilly, binasher, tfinc: the sticky cookies appear to be working [22:29:27] awjr: your now required to blog about our sticky cookies [22:29:28] :D [22:29:38] you said it enough times [22:30:18] hahaha as long as i can call them that [22:31:32] wow [22:32:27] make a video blog [22:32:45] say sticky cookies 10 times [22:33:11] awjr, also please deploy https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114319 [22:33:33] hahaha OuKB: no problem [22:35:36] so preilly… what wasn't sticky about your old cookie? [22:35:38] thanks [22:36:56] OuKB: should be good to go [22:37:09] that is, your change has been pushed [22:40:00] * jdlrobson is going to catch some zzz - will be up in morning to fix any bugs that appear [22:43:17] * tfinc goes to test the beta [22:43:19] hmm [22:43:30] the text on the production footer is super long [22:43:33] we'll want to trim that [22:54:59] along with cleaning up the footer links [22:55:04] their too small and too wordy [22:55:14] i'll mail out [22:55:19] philinje: --^ [22:55:59] ohh .. you guys put the desktop view under the W [22:56:01] interesting [22:56:05] that's going to be tough for people to find [22:56:41] awjr: why did we call it desktop view ? .. instead of just "Desktop" [22:57:24] tfinc: following… someone's suggestion i don't remember who. although, i think just 'Desktop' could very easily be misleading [22:57:56] so if you write it as " Desktop | Mobile | etc" then its really easy [22:58:03] google mobile does a really nice job with this [22:58:55] tfinc: but google mobile prefaces the view options with "View Google in:" [22:59:03] so it's clear that what you're doing is going to change the view [22:59:04] yeah, we'd have to do that [22:59:09] definitely [22:59:12] also .. i'm not seeing the sticky cookie work [22:59:31] tfinc: what are you seeing? [22:59:35] i used it in Safari but going to en.wiki still shows me the desktop [22:59:50] my understanding is that once i tap mobile [22:59:58] all links should show up as the mobile view [23:00:02] they should [23:00:04] so if i load http://en.wikipedia.org/wiki/Medindie,_South_Australia [23:00:11] i wonder... [23:00:21] tfinc can you check the cookies you have set in safari? [23:00:49] you should see one called 'enwikimf_useformat' [23:02:16] but you probably dont [23:03:24] tfinc: the URL for the 'Mobile view' link should actually point to the .m domain [23:04:18] that fact that it is not suggests to me that that page in the desktop view is stale in the cache [23:04:33] let me see [23:05:10] i just logged in and it is now displaying the correct url [23:05:13] to the .m domain [23:15:05] awjr: so, is it just a caching issue? [23:15:35] preilly: yeah, stale pages in the squid cache won't show the updated 'Mobile view' link [23:16:56] awjr: i am see the cookie in firefox [23:17:07] preilly: what that means is when the user clicks a link to the 'Mobile view', they'll get sent to en.wikipedia.org/wiki/Article?useformat=mobile [23:17:20] but i'm still seeing the desktop interface [23:17:26] so something is funky [23:17:34] tfinc: which article? [23:17:50] http://en.wikipedia.org/wiki/New_Guinea [23:17:55] preilly: they should still get a cookie set i believe for mf_useformat=mobile [23:18:11] oh wait [23:18:13] and because we have Vary: Cookie i dont think that should cause any cache pollution [23:18:15] its my browser cache [23:18:19] ahha [23:18:20] http://en.wikipedia.org/wiki/New_Guinea?1232 works [23:18:38] ok so tfinc is an example of the problem im talking about [23:18:54] so tfinc you are now seeing the mobile view but from en.wikipedia.org [23:19:05] whereas you should be seeing the mobile view from en.m.wikipedia.org [23:19:23] hmm [23:19:25] is all API down? [23:19:29] preilly: do you think this could cause any issues? [23:19:30] * yuvipanda checks [23:20:02] awjr: well, cache fragmentation [23:20:02] thats bad. it'll screwup caching [23:20:16] preilly, tfinc: Even with Vary:Cookie/ [23:20:17] ? [23:20:54] yuvipanda, ??? [23:21:12] nevermind, just slow on my end [23:21:34] OuKB: action=sitematrix was taking a super-long time. [23:21:55] likely, cache was empty due to scap [23:24:21] tfinc, preilly ? [23:24:48] anyone know why we lost the beta icon over the W ? [23:29:30] awjr: ^^ [23:29:37] no clue [23:30:36] awjr: you refactored setDefaultLogo didn't you? [23:30:50] preilly not that i recall but it is possible [23:31:28] svn blaming... [23:31:52] looks like REedy was the last to touch it [23:32:05] awjr: but, you did the array stuff [23:32:17] oh not helpful [23:32:20] the array stuff? [23:32:33] to de wikimedia that [23:32:35] preilly: sorry not ringing any bells [23:32:45] im not sure that i did [23:33:32] awjr: let me know when your ready [23:33:59] awjr: to remove the wikipedia specific stuff [23:34:12] tfinc: ok - im ready unless i should keep digging into the logo issue [23:36:08] yeah preilly pretty sure that wasn't me unless i failed to mention it in a commit message: https://www.mediawiki.org/w/index.php?path=%2Ftrunk%2Fextensions%2FMobileFrontend&title=Special%3ACode%2FMediaWiki&author=awjrichards [23:40:34] Reedy: ping [23:42:42] Hi [23:45:43] Reedy: can you try accessing the settings page in the android app, if you have your phone handy? [23:45:58] i'm trying to figure out if we have a bug or just me having a shitty connection [23:47:08] yeah, I can [23:50:07] Reedy: okay! [23:51:29] * yuvipanda is down to two known bugs before hitting RC [23:57:00] awjr: ping [23:57:08] preilly: in a mtg [23:57:30] awjr: are there changes in trunks mobilefrontend.body that can't be merged to deployment branch?