[00:00:40] tfinc: cool. modifying [00:01:20] tfinc: we have a blocker (an ICS bug that i'm unable to debug since i've not been able to get ICS emulator running). [00:01:27] This should not block our iOS RC/Release [00:01:30] but should block our Android one [00:01:31] yuvipanda: what happens when you load ICS ? [00:01:47] tfinc: my emulator crashes [00:01:58] seems to be a known issue on os x with no apparent fixes [00:01:59] what version of dev tools are you running? [00:02:07] http://code.google.com/p/android/issues/detail?id=724 [00:02:10] tfinc: updated today [00:02:24] rev 1 [00:02:24] 5 [00:02:39] tfinc: brion poked at it for a small while, but couldn't figure out what's causing it. [00:06:01] lame [00:07:27] tfinc: very. [00:07:33] tfinc: closed that tracking bug [00:07:36] instead we have https://bugzilla.wikimedia.org/buglist.cgi?query_format=advanced&list_id=101809&resolution=---&resolution=LATER&resolution=DUPLICATE&target_milestone=1.2%20release&product=Wikipedia%20App [00:07:45] not sure what I feel about replacing a single tracking bug number with that [00:08:23] it also means we can't comment on the tracking bug itself, so no place to put release-based comments... [00:08:49] philinje: ^ [00:09:50] tfinc: what do you feel about doing an RC with that issue marked as 'known issue' in Android? [00:10:01] i think that's okay for an RC... [00:10:20] though then it technically isn't an RC [00:18:44] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/A6wc5g [00:18:44] [WikipediaMobile/master] Added patch file that lets you add API keys - YuviPanda [00:19:10] Project WikipediaMobile - Nightly builds build #247: SUCCESS in 14 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/247/ [00:19:11] yuvipanda: Added patch file that lets you add API keys [00:26:39] ooho, finally got ics emu to work! [00:27:56] ough, http://code.google.com/p/android/issues/detail?id=19625 [00:29:05] spoke too soon, that just crashed by itself while I was in vim [00:29:06] gah [00:39:29] lame [00:39:34] oddly it spins up ok for me [00:39:38] if you need help testing let me know [00:41:19] tfinc: i'm trying to get it up. me making a change, getting it to you, then you testing sounds unworkable [00:41:26] nope [00:41:32] also if you saw the code.google.com link I sent you, that's basically this exact same bug [00:41:35] reported for 3.x and 4.0 [00:41:53] without any response on it [00:42:05] tfinc: can you load up our mobile site and see if scrolling related functions work? [00:42:15] specifically, clicking references and the 'jump to top' funcitonalit [00:42:15] y [00:42:19] in the non-beta [00:43:19] sure [00:44:21] android is booting ... [00:44:39] tfinc: do you want me to run you through the process for adding keys? [00:44:42] it's super simple. [00:44:44] sure [00:44:49] tfinc: do a pull [00:45:15] you'll find a api-keys.patch file. edit it to add keys, and do a 'git apply api-keys.patch'. You're done :) [00:46:55] yuvipanda: nothing is happening within the ICS browser when i tap a ref [00:47:20] tfinc: expanding sections works? [00:47:26] yes [00:47:31] tfinc: this is in our current site, right? [00:47:37] yes [00:47:40] ough [00:47:56] tfinc: can you try the 'scroll to top' functionality? [00:48:12] err [00:48:19] the 'jump one section' functionality, i mean [00:48:27] 'jump up one section' [00:48:35] testing [00:49:08] i think something was weird on the first article i was on [00:49:16] this new article works correctly when i tap on a ref [00:49:30] jump back works fine too [00:49:30] that's better news :) [00:49:52] cool, so this is fixable. let me get to it. [00:49:56] ok [00:50:13] * tfinc watches is battery disappear  [00:50:28] heh [00:50:40] did you checkout the api-keys.patch bits? [00:50:48] inbox(107) .. thats what happens after two days of budget meetings [00:50:52] no [00:50:53] :D [00:50:55] okay [00:50:58] let me do that before email eats my time [00:52:54] yuvipanda: that looks easy enough [00:53:00] tfinc: cool :) [00:53:03] now how easy is it to setup a new app in Facebook? [00:53:23] do you need me to do that now ? [00:53:42] tfinc: it's a one time thing for you, and it should take you less than 2 minutes. [00:53:55] tfinc: it needs to be done before the RC, so now is as good :) [00:54:55] ok .. let me take a look [00:58:22] yuvipanda: the Wiki Pedia account is back on line :) [00:58:36] well, does it let you create apps? :) [00:58:49] the account came online last time too, and then it went offline when i tried to create an app [00:59:09] uh oh, the mobile site uses window.scrollTo. we can't use that. [01:00:33] aww .. "You can no longer create apps because our systems indicated that your account may not be authentic. " [01:00:49] Blame domas [01:00:58] :D [01:01:09] Reedy: i usually try to [01:01:18] Just making sure [01:01:31] Reedy: there's this teeny little part of me that's telling me in a sad voice 'That bug is unfixable' [01:01:37] :( [01:01:39] goddamn android [01:02:22] let me see if there's another bug in android i can exploit to fix this bug [01:03:02] i'll just use my account [01:03:24] yuvipanda: did you set an app namespace ? [01:03:34] same question about app domain [01:04:01] Category:Education .. i'd put reference if they had it [01:04:23] tfinc: i left it blank, IIRC [01:05:06] besides Native iOS App and and Native Android app .. did you want any other permissions turned on? [01:05:31] yuvipanda: now i see why you needed the bundle id [01:05:42] tfinc: just iOS [01:05:48] android we don't use this [01:05:54] right [01:05:59] wow .. you can't un check .. thats dumb [01:06:26] Facebook doing something dumb? You don't say... [01:06:57] do we need SSO ? [01:07:05] do we need deep linking ? [01:07:41] tfinc: no deeplinking [01:07:45] and IIRC no sso [01:07:57] url scheme suffix [01:08:30] ? [01:08:50] i don't think we need it [01:08:55] greetings Astagi [01:09:06] tfinc: we don't. [01:09:06] hey tfinc [01:09:11] hi yuvipanda [01:09:12] * tfinc hits save [01:09:15] heya Astagi [01:09:17] I'm still alive :D [01:09:27] sorry was busy at work [01:09:31] :D [01:09:44] how you doing tfinc yuvipanda? [01:10:07] Astagi: i'm doing great! tfinc is sadly stuck up in meetings every day :) [01:10:20] yuvipanda: did you set anything besides Basic ? [01:10:25] tfinc: nope. [01:10:27] :) [01:10:31] Astagi: yes. it sucks. budget meetings [01:10:33] for our mobile group [01:10:35] as in, wait. let me double check [01:10:39] i'd rather be here working on tech [01:11:01] oh I see tfinc... well every work has it's annoying side :P [01:11:11] i mean its important work [01:11:28] i'm arguing for our mobile team getting more resources for the next fiscal year [01:11:32] but every dept wants more [01:11:37] so its a tough balancing act [01:12:01] App Type : Web or Native ? [01:12:08] Native/Desktop [01:12:11] tfinc: one second. [01:12:14] I see.. [01:12:20] * tfinc goes to get snacks [01:12:33] tfinc: just native iOS [01:12:44] app domain, app namespace all empty [01:13:09] Astagi: you have an ICS device, right? [01:13:16] tfinc yuvipanda I'm doing some fix now, let you know when finished ;) [01:13:23] yep yuvipanda [01:13:24] ah [01:13:25] okay [01:13:30] it's on Ttransformer [01:13:34] you need something? [01:14:01] i'm unable to boot an ICS emulator, and have a fix for a nasty bug i'd like you to test. [01:14:05] when do you think you can do that? [01:14:13] yuvipanda: i can hop on Skype and we screen share if you want to see the settings [01:14:34] pass me the apk will test it soon [01:14:43] tfinc: you can check if it works right after you build, so I guess i'm good? [01:15:59] let me try it now [01:16:36] tfinc: note that you would have to enter the fb app id in two places in the patch [01:16:51] yuvipanda: why don't i just send you both over otr [01:17:03] which is the bug yuvipanda? [01:17:25] tfinc: otr? [01:17:25] then you can just build [01:17:32] sign into gmail [01:17:33] xcode, I can't :P [01:17:33] ;) [01:17:35] off the records [01:17:38] ah [01:17:41] record* [01:17:56] tfinc: sure, actually. I can test [01:17:56] but your right .. i'll have to do this to build [01:18:04] but you can test the settings faster then me [01:18:15] Astagi: https://bugzilla.wikimedia.org/show_bug.cgi?id=35369 [01:18:17] tfinc: true [01:18:20] let me come on chat [01:18:47] Astagi: http://dl.dropbox.com/u/8768784/WikipediaActivity-debug.apk [01:19:01] Reedy: can you test http://dl.dropbox.com/u/8768784/WikipediaActivity-debug.apk for the scroll bug? [01:19:22] I can [01:19:39] nice thanks :) will finish to write a mail and will test it yuvipanda :) [01:19:54] Astagi: thanks [01:20:06] tfinc: apparently i 'don't have support for otr'? [01:20:17] yuvipanda: are you using gmail ? [01:20:18] tfinc: despite the fact I took the conversation OTR just as i pinged [01:20:20] tfinc: yes [01:20:30] haha [01:20:31] so [01:20:33] just to know yuvipanda, I'm adjusting about page, I just fixed the problem with licence.. I think that links should result active, what do you think? [01:20:34] were fine [01:20:41] i have both the web client and adium open [01:20:51] ah [01:21:05] Astagi: the GPL links? [01:21:09] yep [01:21:14] i think we already made them active a while back, IIRC [01:21:24] tfinc: got it [01:21:27] k [01:21:29] uhm nope [01:21:37] stupid android [01:21:48] they aren't yuvipanda [01:22:09] I've a bug logged aobut htat [01:22:19] well I can fix that if you need, is requires just a regexp ;) [01:22:34] wow, I remember fixing it and pulling in changes... [01:22:43] Astagi: not necessary. you can add raw html to messages-en [01:23:14] uhm ok yuvipanda but in that case every language have to be modified :) [01:23:31] the translators will/should take care of that (ideally) [01:23:32] why's that matter? [01:23:40] you want to point to a localised version of the license most likely [01:23:45] +1 on that [01:23:56] but to begin with i could just run them through sed [01:24:03] Reedy: bug still exists? [01:24:11] moment [01:24:20] Android is stupid and won't let you install apps over apps [01:24:23] ah [01:24:25] right [01:24:29] yup, still there [01:24:37] sigh [01:24:41] nice idea Reedy thanks :) let's go for raw html so.. [01:28:50] Reedy: can you try http://dl.dropbox.com/u/8768784/WikipediaActivity-debug.apk [01:28:58] shouldn't have problems installign over your previous install [01:29:59] Astagi: while you're at it.. ;) [01:30:14] All the licenses for the 3rd party list should be linked [01:30:52] yuvipanda: how'd the app id's work out? [01:31:07] tfinc: debugging scroll with Reedy's help, will check them out in a bit [01:31:14] k [01:31:36] ok Reedy ;) [01:32:03] * Reedy installs sdk updates [01:33:39] yuvipanda: was that link supposed to be exactly the same? [01:33:43] yuvipanda did you try to reset scroll position every time a page is loaded using javascript? [01:34:08] Reedy uh, i just copied the file over in dropbox [01:34:11] i guess it might be the same [01:34:24] ok [01:34:30] Astagi: we do, check https://bugzilla.wikimedia.org/show_bug.cgi?id=35369 [01:34:45] http://code.google.com/p/android/issues/detail?id=19625 is possibly the issue [01:35:46] yuvipanda: no different [01:36:02] blaubh [01:36:37] * Reedy watches Weebl and Bob [01:37:11] tested yuvipanda :( same here [01:37:17] damn. [01:37:38] last os update last night.. [01:38:55] Anyone know when the galaxy nexus is going to get 4.0.3? [01:39:45] nope sorry, don't know anyone with that device.. [01:41:11] tfinc: app id works fine :) [01:42:12] "Android 4.0.5 coming to Galaxy Nexus early next month" [01:42:13] or;y [01:42:35] tfinc: Looks like we'll have to push RC tomorrow and release to Monday :( [01:44:20] wtb faster internets [01:46:34] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/zpA92w [01:46:34] [WikipediaMobile/master] Fixed missing extra dot in shared URL - YuviPanda [01:46:48] Project WikipediaMobile - Nightly builds build #248: SUCCESS in 7.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/248/ [01:46:48] yuvipanda: Fixed missing extra dot in shared URL [01:47:11] Reedy: so that brings ICS up to what .. 3 phones out of the many hundreds that want it ? [01:47:24] :D [01:51:26] yuvipanda is normal that tag give me a plain text instead of formatting it in html? [01:51:51] Astagi: it shouldn't do that [01:52:19] yep I think the same :\ [01:52:38] but we don't use a similar thing seems [01:52:58] oh yes.. in attribution osm [01:53:28] will have a look at these :P [01:53:46] Astagi: i'm guessing it is difference in behavior of vs mw.message [01:54:41] uhm probably yuvipanda :\ ok easy to verify, thanks :) [01:55:20] :) [02:04:04] tfinc: RCs tomorrow, and release on Monday. I'll grab some jdlrobson time and see if there's a way to fix this. [02:04:21] k [02:04:50] since phil is out next week i prepped howie that we might slip [02:05:08] sigh. [02:05:21] this sucks. [02:05:34] tfinc: facebook also pulls out a nice exerpt for us by default: https://www.facebook.com/yuvipanda/posts/274369722642400 [02:06:18] * yuvipanda continues trying to get ICS emu on [02:21:24] yuvipanda do I have to put "here" instead of long urls like http://www.gnu.org/licenses/old-licenses/gpl-2.0.html ? [02:23:40] Astagi: enter the full URLs [02:23:53] go ;) [02:24:07] Astagi: oh c'mon, no question is silly! [02:25:21] gnite yuvipanda [02:25:25] :) [02:25:34] Astagi: thanks for contributing :D [02:25:37] :) :) [02:25:40] see you soon! [02:25:45] it's a pleasure :) [02:25:49] cya yuvipanda! [02:27:49] tfinc I found two twitter profiles about you.. which is the main one? ^^ [02:31:23] sigh, my git account can't write to the repot [02:31:24] lame [02:31:37] @flyingclimber [02:31:40] its the one i actually use :D [02:31:50] @tomasz_fi is long dead [02:32:02] Astagi: --^ [02:32:02] nice thanks tfinc :) [02:34:40] just to learn special signs tfinc, what is --^ ? :) I don't know it sorry :P [02:38:28] an arrow up [02:38:31] heh [02:42:54] oh thanks devgeeks :) :) my fantasy is getting low :P :P [02:46:39] :) [03:02:20] tfinc Reedy do you have particular site where to get MIT License and 2-Clause BSD License? [03:02:34] Astagi: nope [03:04:03] tfinc do you think that a link like this is ok? http://opensource.org/licenses/mit-license.php [03:04:52] it's the link that wikipedia give to me [03:10:47] http://imgur.com/a/6vdzW :D [03:10:59] ok .. its 8pm .. maybe i should go home now [03:11:19] brion: check out my link above [03:11:35] boot2gecko+wikipedia [03:22:32] pull requests sent ;) now we have a completed about page for the next release [03:23:58] it's time to go [03:23:58] gnite all!! [08:00:03] tfinc: what user account are you trying? [08:00:07] have you logged into gerrit yet? [08:00:12] hey Ryan_Lane [08:00:25] i use Tfinc for labs console [08:00:42] its what i've been standardizing everywhere [08:00:43] your shell account name is tomasz [08:00:53] for ssh you need to always use tomasz [08:00:58] the only thing that was left with tomasz was my svn account [08:01:13] so, it's still your ssh name [08:01:13] I've tried both and they both fail the checkout [08:01:19] s/checkout/clone [08:01:26] have you logged into gerrit yet? [08:01:31] Tfinc/tfinc/tomasz all come back with permission denied [08:01:36] i've logged in with Tfinc just fine [08:01:53] all web credentials = labsconsole wiki name [08:02:02] all shell credentials == shell account name [08:02:03] for labs console & gerrit [08:02:08] in fact i'm logged into gerrit right now [08:02:16] no issues for web log in [08:02:31] web works, shell works, git does not [08:02:34] can you try to do a checkout? [08:02:44] sure [08:03:01] also, can you try this: ssh -p 29418 tomasz@gerrit.wikimedia.org [08:03:07] same permission denied message [08:03:12] ah [08:03:14] same [08:03:17] did you add your key in gerrit? [08:03:31] not in gerrit just in labs [08:03:45] gerrit and labsconsole don't share the same keystore. it's an open bug with gerrit to pull it from ldap [08:03:57] you need to also add your key to gerrit [08:04:50] ugh. lame. i hope we can centralize this better. seems silly to keep keys all over the place [08:04:55] not to mention updating them [08:04:59] works now though [08:05:18] http://code.google.com/p/gerrit/issues/detail?id=1124 [08:05:40] open since 9/2011 [08:05:47] I opened it ;) [08:06:56] how likely are they to pick it up? [08:06:59] and/or can we do it? [08:07:37] just sent an email response :) [08:07:38] heh [08:07:42] we'll need to do it [08:07:50] it should be fairly easy for someone who knows Java [08:08:20] Gerrit is already syncing other things. It's just one more thing it needs to sync. [08:08:39] * tfinc notices that git has 99% of his cpu [08:08:43] heh [08:22:37] Ryan_Lane: nice mail to entice a volunteer to add the missing feature ;) [08:22:45] heh [08:22:48] that's what I was aiming for :) [08:39:58] greetings jdlrobson [08:40:06] hey tfinc [08:40:56] given how much trouble your having with perfecto i'm open to sending you some phones [08:41:01] so that you have more devices to test with [08:41:10] that would be useful [08:41:32] here is what i have in the office : https://office.wikimedia.org/wiki/Technical/Mobile/Testing_Devices [08:42:08] it's mostly nokias and blackberrys i struggle to test [08:42:18] and we can get more if their not covered by what we have [08:42:25] and annoyingly I guess some of these don't have wifi so would need a mobile sim? [08:42:26] put together a list and send it to me [08:42:36] jdlrobson: i only buy ponies that have wifi [08:42:39] phones* [08:42:44] i preferred ponies lol [08:42:47] me too! [08:43:02] ok cool [08:43:20] it would be good to know what the most popular phones used to access the site are im sure that exists somewhere [08:43:26] i do have some super old nokias that aren't wifi of cours [08:43:27] e [08:43:33] but i hope you never have to touch those [08:43:45] ask phil for the stats [08:43:56] he can point you to them [08:44:01] and/or get them if we don't have it yet [08:45:30] jdlrobson: i just sent out an email plotting out the next steps for the beta [08:45:35] let me know what your thoughts are [08:45:40] yep i saw that [08:45:41] it sounds good to me [08:45:48] im just surprised with the firefox problems [08:45:52] i'm not [08:46:04] firefox mobile is still early in its life cycle [08:46:08] its given us tons of problems [08:46:23] but we know the team over there [08:46:31] and love to send them bugs :D [08:47:32] but ive already fixed the keyboard issue [08:47:39] strangely it seems to be caused by adjusting the viewport [08:48:03] fixed and waiting to be deployed ? [08:48:33] no fixed and waiting for me to get setup with git so i can commit [08:48:36] and then deploy [08:48:37] :) [08:48:40] hehe i see [08:48:46] welcome to the new world of git! [08:48:52] i'm actually pretty excited about it [08:48:59] i've loved using it for our apps [08:50:15] yeh me too [08:50:22] im looking forward to using branches straight away [08:52:23] * jdlrobson starts a git clone [08:55:36] ok .. its almost 2AM here and i have meetings starting @ 8:30 .. its nap time [08:55:44] jdlrobson: need anything from me before i crash [08:55:45] ? [08:55:53] i dont think so :) [08:56:01] sleep is a good idea for you I think :) [08:56:07] yes .. yes it is [08:56:19] we'll chat in a couple of hours about where you've gotten the beta [08:56:27] and pick a communication date [08:56:34] i want to set that so that we can get to other work [09:02:22] jdlrobson: also check this out https://www.dropbox.com/sh/32u1rok22hr9wu9/aJm3OprKrK/smartphone.mp4 [09:02:31] i really like the ideas in this [09:02:51] ok .. time to crash [09:02:53] you'll be up in 2hours now? [09:03:06] haha [09:03:09] its 2am [09:03:17] and i'll have to wake up around 7:30am [09:03:20] so thats 5hours [09:03:29] just below my average [09:03:33] i like working on this stuff too much [09:03:37] its a good problem to have [09:03:46] do take a look at the video [09:03:52] its a design students take on mobile wikipedia [09:05:09] just you said a couple of hours :) [09:05:11] yeh videos nice [09:05:18] ive been thinking about the menu opening from the right [09:05:25] also swiping to the right to reveal it [09:05:32] (anywhere on screen) [10:42:39] * yuvipanda pokes jdlrobson  [10:42:46] hello [10:42:58] that bug... im wondering if window.location.hash = "#" might force a scroll to top [10:43:10] (im also just merging https://github.com/wikimedia/WikipediaMobile/pull/183/commits) [10:43:28] jdlrobson: so that bug on code.google. is, as suspected, 'valid'? [10:43:39] i was surprised about how such a possibly awful bug had so little dev interest [10:49:26] [WikipediaMobile] jdlrobson pushed 4 new commits to master: http://git.io/r6Dgtg [10:49:26] [WikipediaMobile/master] Add links to licenses - 4ndreaSt4gi [10:49:26] [WikipediaMobile/master] Fixed About title position - 4ndreaSt4gi [10:49:26] [WikipediaMobile/master] remove whitespace added in bd1655552537cafbfc0902ee1f72b3ab17182670 - Jon Robson [10:49:42] Project WikipediaMobile - Nightly builds build #249: SUCCESS in 7.8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/249/ [10:49:42] * jdlrobson: Add links to licenses [10:49:43] * jdlrobson: Fixed About title position [10:49:43] * jdlrobson: remove whitespace added in bd1655552537cafbfc0902ee1f72b3ab17182670 [10:49:43] * jdlrobson: correct typo Query->jQuery [10:50:13] jdlrobson: are you able to create a ICS Emulator? [10:50:27] i'm unable to despite a day of trying :| [10:50:46] i haven't tried [10:51:34] jdlrobson: could you? [10:52:26] what's the problem? you can't install or you can't run it? [10:53:23] jdlrobson: i can't run it [10:53:25] keeps crashing [10:53:33] is apparently another 'known issue' with no solutions [10:53:38] are you running with launch from snapshot? [10:53:48] http://code.google.com/p/android/issues/detail?id=724 [10:54:00] jdlrobson: tried with it on and off [10:54:40] without audio as well? [10:54:41] -noaudio -no-snapshot-load [10:56:15] yes [10:56:22] i have that in my config [10:56:44] * jdlrobson installing lots of new emulators [10:57:39] i cant replicate https://bugzilla.wikimedia.org/show_bug.cgi?id=35369 at moment yuvipanda as i need to install the correct emulator [10:57:53] if you can do you want to try doing window.location.hash = "#" instead of scrollTop ? [10:58:07] jdlrobson: i don't have a working emulator either, which is the problem. [10:58:13] i'm unable to start it - it just crashes on startup [10:58:51] still trying though. [10:59:05] jdlrobson: do poke me when you've the emulator installed. [11:01:41] k [11:02:23] currently cant even install SDK platform-tools rev 11 [11:02:51] ah [11:02:55] okay [11:05:11] * jdlrobson tries to launch 4.0.3 [11:12:19] i think it's working yuvipanda just having issues installing the app to it.. [11:12:35] im on snow leopard so that might be helping [11:12:47] issues installing the app how? [11:13:16] well it was saying device not found [11:13:23] ive rebooted it to see if it has made a difference [11:14:20] and yes it has [11:16:05] * jdlrobson begins troubleshooting bug 35369 [11:17:47] awesome! [11:23:09] so yuvipanda i have a fix [11:23:12] but its verrryyy hacky [11:23:16] are you ready to hear it? [11:23:24] * yuvipanda sits down [11:23:31] tell me, sir! [11:23:43] let me just double confirm [11:24:04] (Add some suspense in the process ;-)) [11:24:41] :D [11:26:03] argghh so hacky [11:26:04] $(element).hide(); [11:26:04] $(element)[0].scrollTop = 0; [11:26:04] $(element).show(); [11:26:24] o_O [11:26:30] making the element invisible resets the scroll it seems [11:26:32] does the scrollTop actually have any effect? [11:26:41] well it does on my emulator [11:26:56] im trying to work that out [11:27:04] i tried $(element).hide().show() but that had no effect [11:27:38] * jdlrobson wishes building and deploying to emulators was a quicker proces [11:27:42] sigh [11:27:47] jdlrobson: how long is that taking you? [11:27:58] 23 sec [11:28:09] hmm, slightly worse than mine (15) [11:28:27] i should at some point take the time and do the small things needed to let this run standalone [11:28:32] so yes [11:28:36] without the --disable-web-security hack [11:28:36] it seems that the scrollTop is needed [11:28:41] ah [11:28:43] okay [11:28:51] i don't know why this works [11:29:02] as i said... very hacky :) [11:29:02] yay for jdlrobson :D [11:29:02] does it 'flash'? [11:29:05] not for me at least [11:29:18] is there a way you can try it on other devices for me? [11:29:27] if i send a pull? [11:30:24] yes [11:30:30] jdlrobson: i can test it out on 2.2 and 2.3 and iOS [11:30:39] jdlrobson: just push it to your repo i can pull from there [11:33:20] awesome [11:33:28] \o/ [11:33:31] sent [11:36:47] * yuvipanda runs git fetch jdlrobson  [11:36:52] for some reason I find that very funny [11:37:23] i sometimes run git git fetch yuvipanda by accident [11:37:28] git git doesn't make it any faster [11:37:31] btw [11:37:36] $("#content").hide(); window.setTimeout(function() { $("#content").show() }, 0) forces scrolling to top [11:37:45] but $("#content").hide(); $("#content").show(); doesn't [11:37:55] ah yes, the magical setTimeOut [11:38:14] so i'm guessing any intermediate line between show and hide would work? [11:38:18] (that's if we wanted to drop scrollTop but i guess we don't as it gives us more chances [11:38:24] nope it seems not [11:38:27] ah [11:38:34] for instance $("#content").hide(); var x = true; $("#content").show(); [11:38:36] no effect [11:38:52] wouldn't that var x = true; be optimized out? [11:39:08] try doing an unrelated dom op? [11:39:22] damn this feels so dirty! [11:40:01] yeh i've tried several dom ops [11:40:04] nothing [11:40:06] ah [11:40:08] okay [11:40:36] jdlrobson: am testing on 2.3 now [11:40:48] jdlrobson: also, would appreciate a longer inline comment rather than just a bug ref :) [11:41:10] well i thought it would make more sense [11:41:19] as you can look up the bug and get all the context [11:41:20] jdlrobson: also, shoudn't we just do .scrollTop(0) to be jquery consistent? [11:41:27] and yes probably yuvipanda [11:41:58] the important thing to know imo in the code is that it's there to address a bug [11:42:18] hmm, my thinking is that it adds an extra context switch [11:43:07] let me just merge some more pull requests [11:43:41] okay! [11:54:13] jdlrobson: verified to work on 2.3 2.2 and iOS :) [11:54:22] :-X [11:54:33] :-X~~~~ [11:54:40] (pukey emoticons) [11:54:40] isn't :-X -> 'angry'? [11:54:42] ah [11:54:45] yes [11:54:48] i could see that [11:54:49] :D [11:55:18] jdlrobson: do you want me to make that a .scrollTop() before merging? [11:55:33] as long as it has the same effect :) [11:55:57] you'd have to test on ICS :) I can do so on 2.x and iOS [11:56:13] need to figure out a way to make the emulator work though. this cannot be a workable long term solution [11:56:19] or I could move my phone to ICS [11:56:46] oh btw is it just me.. [11:56:52] or when I scroll down on android [11:56:57] the wikipedia icon and search icon go anti-aliased [11:57:43] also im unable to replicate https://bugzilla.wikimedia.org/show_bug.cgi?id=34170 [11:58:00] jdlrobson: anti aliased or aliased? [11:58:07] i get confused.. probably aliased [11:58:30] yes aliased [11:58:33] jdlrobson: not on 2.3 [11:58:34] hmm [11:58:37] mm [11:58:41] not on 2.2 either [11:58:51] so yeh keen to pull https://github.com/wikimedia/WikipediaMobile/pull/182/files [11:58:57] but i cant replicate bug 34170 [11:59:04] so I'm not sure if it fixes it or not [11:59:08] and if it is a suitable fix [12:00:38] let me check [12:05:19] jdlrobson: i'm able to reproduce the about page bug [12:05:25] jdlrobson: the last line is cut off [12:05:40] it ends at 'see while there are atleast two more lines there [12:05:49] i'm not sure that's the right fix however [12:06:14] mmm is this on android or iphone? [12:06:19] jdlrobson: android [12:06:23] which version? [12:06:23] let me check iphone [12:06:26] jdlrobson: 2.3 [12:06:31] * jdlrobson boots up 2.3 [12:07:03] jdlrobson: seems fine on iOS [12:17:08] [WikipediaMobile] yuvipanda pushed 2 new commits to master: http://git.io/K2XKHQ [12:17:08] [WikipediaMobile/master] add horrible hack to fix bug 35369 - Jon Robson [12:17:08] [WikipediaMobile/master] Make code jQuery consistent - use .scrollTop - YuviPanda [12:17:23] Project WikipediaMobile - Nightly builds build #250: SUCCESS in 8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/250/ [12:17:24] * yuvipanda: add horrible hack to fix bug 35369 [12:17:24] * yuvipanda: Make code jQuery consistent - use .scrollTop [12:17:38] jdlrobson: the .scrollTop works on 2.3. would like you to test on 4.x though [12:18:17] k 1s im gonna go out for some lunch very soon and still looking into the license text cut off issue [12:19:10] jdlrobson: cool! [12:19:17] i'll followup on the rtl issues [12:19:26] cool [12:19:28] ill commit those later [12:19:37] hi yuvipanda hi jdlrobson [12:19:40] hey Astagi [12:19:51] yuvipanda will take a look to it.. [12:19:51] heya Astagi [12:19:57] thanks for the commits :) [12:19:59] reviewing as we speak [12:20:05] is it on master, isn't it? [12:20:55] Astagi: https://github.com/wikimedia/WikipediaMobile/pull/184 [12:21:04] i'm wondering if it will break things on Windows [12:21:20] jdlrobson you're welcome :) I moved the margin bottom as requested ;) now should work fine [12:22:37] yuvipanda why? [12:22:48] Astagi I'm actually thinking now it should be removed all together... i dont think it's the right fix [12:22:54] there's something weird going on and this masks it [12:23:02] (the margin-bottom that is) [12:23:15] Astagi: windows has no 'make'. [12:24:10] that's true yuvipanda , so the only thing remaining is to download files into build.xml [12:24:22] yes. [12:24:30] the actual solution is to make another git repo with those things [12:24:32] and add a submodule [12:24:39] will need tfinc to create a new repo when he's around [12:24:58] Astagi: that's what the current deal is for people building on windows [12:25:09] Astagi: if we add this make step into ant, ant will break for them. [12:25:25] jdlrobson but works ok.. seems that requires a margin-bottom to avoid to cut the page [12:25:38] yeh but do we know why it works? [12:25:53] i suspect what's happening is the height of the header (52px) is being removed from the bottom [12:26:01] but im yet to confirm [12:26:48] uhm probably jdlrobson [12:27:08] ok yuvipanda will download files into ant :) [12:27:30] Astagi: i think a git submodule is the best solution here. [12:27:44] Astagi: don't you agree? [12:27:47] works across all platforms [12:27:51] git submodule update [12:28:00] do you think you could resubmit your pull request without the app.css change? (just so a merge is clean) [12:28:19] im going to have another look at this margin-bottom stuff after some lunch but something sinister seems to be happening :) [12:29:42] yuvipanda a git submodule for two files? [12:29:50] Astagi: yes :) [12:29:54] plus that list will grow [12:30:01] we're going to be sharing more code with MF as time goes on [12:30:20] ok jdlrobson will do it [12:30:56] ok yuvipanda will try ;) [12:31:14] Astagi: :) [12:43:09] yuvipanda I have a doubr [12:43:38] I have to submodule something like this http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/MobileFrontend/javascripts/toggle.js?view=co&revision=$(REVISION)&content-type=text%2Fplain&pathrev=$(REVISION) [12:44:03] so just fetch a file and save on the local machine [12:44:22] Astagi: i've the git repo all setup from a while ago [12:44:22] do you think is it possible with submodule? [12:44:25] let me push and show you [12:45:21] I'm not a great expert of submodules, I just know how to add another git repo [12:46:25] ok [12:47:59] Astagi: https://github.com/yuvipanda/MFToApp [12:48:12] will set this up once tfinc creates a proper repo. all taken care of :) [12:50:28] nice yuvipanda thanks :) [12:50:37] Astagi: :) [12:50:46] I think that toggle.js should stay in a folder called js, what about? [12:51:26] Astagi: yes, that'll be taken care of with proper links once I setup the repo under wikimedia/ [12:51:38] they will live under a folder called submodules and linked into assets/ww/js [12:51:42] *www [12:51:55] Astagi: this bug is just an administrative thing now :) [12:52:18] Astagi: i think what we need right now is a lot of testing - RC today and release on monday [12:52:27] Astagi: do you think you can also find people who will be able to help us with testing? [12:53:43] ok yuvipanda, so will we take care lately? [12:53:48] yep I have some friend using wikipedia app :) [12:54:14] Astagi: the official app? [12:54:19] err [12:54:20] the nightly? [12:54:22] or the market release? [12:55:11] the market release, but I ask them to try the nightly np ;) [12:55:29] Astagi: the nightly is broken right now [12:55:56] oh I didn't know [12:56:13] jdlrobson: btw, you should make a comment http://code.google.com/p/android/issues/detail?id=19625 for people :) [12:57:27] so yuvipanda what version I have to ask them to try? [12:57:39] Astagi: let me make a build :) [12:57:49] Astagi: we're going to have an RC version out tonight [12:57:56] ok [12:57:58] for people to try. [12:59:46] will wait the RC if you want, np ;) [13:00:07] Astagi: :D It would also be awesome if you could test it on your tablet now :) [13:00:14] stress it [13:00:18] do anything you could imagine [13:00:20] and see if it breaks [13:00:21] :) [13:00:24] also try out the share functionality [13:00:30] ahah :D ok pass the link [13:09:18] jdlrobson pull request sent ;) [13:09:37] Astagi: http://dl.dropbox.com/u/8768784/WikipediaActivity-debug.apk [13:10:12] thanks perfect! :) [13:10:18] yuvipanda is this containing the bad hack? [13:10:31] which one? [13:10:34] the fix for the scroll? [13:10:34] yes [13:10:41] Reedy: http://dl.dropbox.com/u/8768784/WikipediaActivity-debug.apk should fix your scroll issues [13:10:52] yep :) [13:14:51] yep I can confirm that bug is fixed for Transformer with ICS too ;) [13:14:58] \o/ [13:20:48] :-) [13:22:19] [WikipediaMobile] jdlrobson pushed 1 new commit to master: http://git.io/tt_jJw [13:22:19] [WikipediaMobile/master] Links on license. Fixes #34030 - 4ndreaSt4gi [13:22:34] Project WikipediaMobile - Nightly builds build #251: SUCCESS in 7.8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/251/ [13:22:34] stagi.andrea: Links on license. Fixes #34030 [13:41:25] yuvipanda: still there? [13:41:32] jdlrobson: yup! [13:41:42] how do i force hebrew mode to test your pull? [13:41:49] jdlrobson: in android? [13:41:51] it doesn't seem to set the dir attribute [13:41:52] yep [13:41:54] android settings [13:41:59] change locale [13:42:02] erggh [13:42:02] ok [13:42:11] i think ill just add a line in chrome.js to force it :) [13:42:47] jdlrobson: :D [13:44:27] [WikipediaMobile] jdlrobson pushed 3 new commits to master: http://git.io/UcCMRQ [13:44:27] [WikipediaMobile/master] Normalize hebrew properly - YuviPanda [13:44:27] [WikipediaMobile/master] Fixed RTL bugs for settings page - YuviPanda [13:44:27] [WikipediaMobile/master] Removed extraneous classes and empty css declarations - YuviPanda [13:44:35] \o/ [13:44:48] Project WikipediaMobile - Nightly builds build #252: SUCCESS in 7.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/252/ [13:44:48] zero known blockers :) [13:44:48] * jdlrobson: Normalize hebrew properly [13:44:49] * jdlrobson: Fixed RTL bugs for settings page [13:44:49] * jdlrobson: Removed extraneous classes and empty css declarations [13:45:12] now to test with the new beta :P [13:45:22] jdlrobson: do you have instructions on how to opt in handy? [13:45:43] append mobileaction=opt_in_mobile_site [13:45:45] to querystring [13:46:01] or alternatively [13:46:10] use beta_common.css instead of common.js [13:46:25] common.css [13:47:02] jdlrobson: i take it that there's been no changes to the html structure? [13:47:08] just js and css? [13:47:17] just the css actually [13:47:22] application.js the same [13:47:39] the only html that changed is in footer and search box but they dont effect app right? [13:47:46] no [13:47:47] shouldn't [13:47:59] i should double check anyawy :) [13:51:45] jdlrobson I found the cause of the cut off: in .scroller wer have overflow-y: auto; that cut off our licence text cause we have an element with absolute position, the header ( your supposition was right :) ). This seems a common problem looking around forums, we can change overflow-y value, remove it or do the margin-bottom hack [13:52:08] awesome... have you got a link? [13:53:09] a moment I closed the browser :P [13:57:10] I haven' found a problem similar, anyway look here for example: http://stackoverflow.com/questions/5427537/absolute-positioned-element-gets-cut-off they're talking about absolute positioning and the overflow influence,... from this I started to have a look at how we use overflow :) [14:00:15] seems that 52px of header are treated like an overflow.. [14:00:25] we let it "auto" [14:00:42] and for some reason it's hidden [14:01:11] if we add the margin it's not considered as overflow [14:01:31] alternatively we can specify an height of that element [14:01:46] this force scroll to not hide that element [14:01:56] mm [14:03:37] let the scroll overflow visible every time / add an height / add a margin-bottom ... from one to 3 solutions.. progresses :P [14:04:33] I also think that let the overflow auto could be a risk for wiki pages too... [14:13:36] jdlrobson http://stackoverflow.com/questions/616074/avoid-an-element-from-being-cut-off-when-they-are-inside-a-overflow-hidden-el [14:14:17] damn history [14:16:41] Yay Astagi. Minor thing, should the GPL2/source code links at the bottom have shorter display text? [14:18:16] sorry Astagi just tackling another issue at the moment :/ [14:19:07] I accorded this with yuvipanda yesterday Reedy, I proposed "here" linked [14:19:16] np jdlrobson ;) [15:16:37] ping pong anyone ? :) [15:17:02] I have met someone at a hacker place willing to hack the mobile app :) [15:17:06] I have sent him to you [15:43:47] * tfinc yawns [15:43:52] greetings all [15:46:08] hi tfinc! [15:48:00] greetings Astagi [15:49:03] greetings :) back from another boring meeting tfinc? [15:49:18] Astagi: its 8am and i've just started them [15:49:21] this call is actually interesting [15:49:35] its about our partnering with another non profit to develop Wikipedia over SMS & USSD [15:49:50] oh that's true :P I moved you in my timezone :D [15:49:56] we think about smart phones a lot these days [15:50:07] but a huge portion of the world has phones that are even less then feature phones [15:50:11] we have to reach those peopel [15:50:16] so we have to be creative about how we do it [15:50:37] really interesting [15:51:10] anyone around with an ICS device ? [15:51:15] who is the other non profit? [15:51:17] * tfinc needs to order some galaxy nexus [15:51:34] Astagi: http://praekeltfoundation.org/ [15:52:43] Astagi: don't you have a device with ICS ? [15:53:13] Interesting goals :) [15:53:18] yep tfinc [15:53:28] I have an Asus Transformer with ICS [15:53:34] i need to verify a tweet we got about Chrome Beta on Android not allowing users to disable the mobile site [15:53:45] it came from a galaxy nexus user [15:53:52] awjr_away could test it but i bet he's still asleep [15:54:53] brion: you around yet? [15:55:01] uhm I don't understand the problem :) what does the chrome beta do? [15:55:11] google released the chrome browser for android [15:55:18] https://play.google.com/store/apps/details?id=com.android.chrome [15:55:26] its pretty nice [15:55:31] yep :) [15:55:45] we got a report that a user wasn't able to use the disable mobile link [15:55:52] and since we pushed changes to it last week [15:56:01] i wouldn't be surprised if ICS is being somewhat finicky [15:56:46] ok will have a look :) [15:56:55] I'm downloading chrome now [15:57:17] I usually use open source stuff [15:57:43] thanks! [15:58:26] np :) [16:00:22] MaxSem: i'm delayed by about 5-10min [16:01:49] ok [16:05:41] tfinc I'm able to use the desktop version, look https://p.twimg.com/AommgezCMAAMpLk.png [16:09:02] tfinc are you in? [16:09:07] yes [16:09:10] :) [16:09:12] i was just switching floors [16:09:18] well I'm able to use the desktop version, look https://p.twimg.com/AommgezCMAAMpLk.png [16:10:02] oh. your on a tablet [16:10:09] which will default to desktop [16:10:33] which won't allow you to default to mobile [16:10:35] uhm the default was mobile :\ [16:10:40] ORLY [16:10:40] I switched to desktop [16:10:51] and is it a persistent change? [16:11:10] lemme try :) [16:11:44] yes tfinc [16:11:54] ok. so this isn't an ICS issue [16:12:02] its more then likely something funky with the galaxy nexus on ICS [16:12:18] we'll be able to confirm once awjr_away or brion show up [16:12:25] as their using the same phone [16:12:26] ok :) [16:12:35] i only have Nexus S and Nexus Ones around me [16:12:37] thanks for testing! [16:12:46] MaxSem: ok .. im ready [16:12:51] me too [16:13:06] :) you're welcome tfinc [16:23:18] * yuvipanda wakes up from a nice 8pm-10pm mid day(?) sleep [16:23:25] * yuvipanda waves [16:23:40] tfinc: we're at zero known bugs! [16:24:46] * yuvipanda starts doing release notes [16:36:34] yuvipanda: woot! [16:36:50] yuvipanda we do have a weird ICS mobile web issue [16:36:56] but that won't impact you yuvipanda [16:36:57] another one? [16:36:59] ah [16:37:19] i have one user reporting that the desktop switch cookies aren't' getting set correctly on a galaxy nexus [16:37:34] messy sticky cookies [16:37:51] wow a freudian slip almost made me write something other than cookies. [16:39:33] hashar: where is the new volunteer you found? :) [16:43:45] yuvipanda: he is in France [16:43:48] might connect tonight [16:43:55] oooh, cool! [16:44:00] hashar: also, our nightlies are broken :P [16:44:15] I have met him at a local hacker place and he was playing with his android [16:44:21] hashar: https://bugzilla.wikimedia.org/show_bug.cgi?id=35405 :P [16:44:23] nice! [16:44:56] I thus introduced him to the Wikimedia mobile page on github [16:45:06] the first thing he said was oh you are using PhoneGap, great! [16:45:17] tfinc: :D [16:45:18] the second thing I said : we are looking for people, come see us :-] [16:45:59] yuvipanda: make remotes ? Jenkins uses: ant debug [16:46:55] hashar: yes, make remotes. [16:47:03] we're moving to a submodule though [16:47:10] so it'll have to be git submodule update [16:47:14] but definitely one command [16:48:15] tfinc: i'd need you to create new repos in our wikimedia/ account to fix the nightlies. [16:48:16] no rush [16:49:33] hashar: more volunteers … woot! [16:49:45] yuvipanda: why? [16:49:55] tfinc: to host our 'shared' MF and App code [16:50:02] yuvipanda: you will have to describe that to me on the bug report [16:50:02] the easiest way to make sure that works across platforms [16:50:09] yuvipanda: and ping me about it tomorrow :P [16:50:12] hashar: yes! [16:50:29] tfinc: yeah. Might even be interested for work. He seems to be a freelancer already. [16:55:11] coffee break$ [16:59:28] did someone say something about a galaxy nexus? [16:59:58] tfinc: did [17:00:29] awjr: yes! [17:00:51] can you check the disable mobile cookie when your not opted into the beta [17:00:56] we have one users reporting that it doesn't work [17:01:00] ! [17:01:05] on en.wikipedia? [17:01:07] yes [17:01:15] any particular browser? [17:01:19] yes [17:01:21] chrome beta [17:01:32] chrome beta eh [17:01:33] ok [17:01:49] awjr: Astagi already checked chrome beta on his asus transformer (tablet) and it doesn't show the problem [17:02:03] making me think this is isolated to a) phones or b) the galaxy nexus [17:02:10] either way i want to verify before we freak out [17:02:16] lemme just download chrome beta [17:02:53] tfinc: is there a bugzilla bug for this? [17:04:01] oh wow indeed [17:04:05] i have the same problem :( [17:05:33] interesting there seems to be a way you can remotely use chrome developer tools [17:06:17] yes [17:06:21] i call that 'awesomely' [17:06:22] :D [17:06:30] yeah this looks cool [17:06:31] awjr: you can do that in iOS too :) [17:06:36] * awjr goes in search of microusb cable [17:07:28] i could really use like 12 more usb ports [17:09:12] awjr: not yet. i couldn't duplicate it [17:09:18] was going to file after someone confirmed [17:09:37] it is confirmed [17:09:47] ok .. i'll open a bug [17:10:03] * yuvipanda goes to get food, then RC time. [17:10:39] awjr: is it just google chrome ? does the native browser work correctly ? [17:11:29] tfinc: last time i checked native and dolphin hd work fine - lemme double check [17:11:45] make sure to try it out in NON beta mode [17:12:00] aye [17:12:20] i'm also curious to find google chrome works correctly WITHIN beta mode [17:12:28] aren't low level ops changes fun :D [17:14:37] tfinc: native and dolphin hd work fine, as expected [17:14:49] now what about chrome beta IN beta mode [17:15:01] lessseee [17:15:05] that should round out our test cases [17:16:34] blargh manually typing in the optin url is a pita [17:16:44] awjr: thats why its going to go into the new nav [17:16:52] no more manual then! [17:17:11] bit.ly/wmoptin [17:17:20] awjr: --^ [17:17:41] much better thanks! [17:18:21] jebus [17:18:24] beta seems to work fine [17:18:38] the mystery gets more interesting [17:18:45] this is why we test :) [17:18:49] so .. why is that? [17:20:02] bug filed: https://bugzilla.wikimedia.org/show_bug.cgi?id=35413 [17:20:46] cool thanks [17:22:15] oh wtf [17:22:20] now it appears to be working fine in non-beta [17:22:24] >_< [17:22:59] tfinc: i've got my fundraising office hours this am so i'm going to tend to that for a bit iand then i'll come back and poke this [17:23:08] sure [17:24:15] Project WiktionaryMobile - Nightly builds build #32: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/32/ [17:28:16] wow https://developer.mozilla.org/fr/demos/detail/the-box/launch [17:29:43] wow [17:29:46] and that's not even webgl [17:30:13] exactly [17:35:24] meeting marathon time [17:40:15] greetings jdlrobson [17:40:20] sup jorm [17:40:23] hello tfinc [17:40:43] jdlrobson: how did hacking on reported beta issues go? [17:40:49] are we closer to a go? [17:40:59] ive committed locally to git but had issues pushing [17:41:02] looking at firefox mobile at the moment [17:41:07] and all the weirdness that comes with it [17:41:08] brion: --^ [17:41:15] brion loves to test firefox for us [17:41:18] :) [17:41:30] for some reason the input box is appearing over the address bar [17:41:35] i didn't even realise that was possible ;-) [17:41:50] i didn't realize blackberrys would redirect to random pages when we expanded sections [17:41:56] old bug [17:41:57] i've spent lots of time in phonegap land today as well due to the release today [17:42:01] but it happened ... [17:42:35] jdlrobson: how are you finding your time in the mobile web beta vs the app .. i want to make sure your not dividing your time to much [17:43:07] it's hard at the moment tbh because the environments are quite different [17:43:19] i find if i start phonegap stuff its hard to build up momentum in mfe [17:43:21] and vice versa [17:43:59] * yuvipanda pokes jdlrobson about https://github.com/wikimedia/WikipediaMobile/pull/187/files  [17:44:15] it looks okay to me, but since you were dealing with it... [17:44:22] yeh already on it yuvipanda [17:44:26] ah cool :) [17:44:31] it looks fine to me also [17:45:16] the only problem is when viewed in safari there is now a gap between footer and bottom of scroll region [17:45:33] ow [17:45:46] i guess that's how it'll be in browsers without the bug [17:45:50] including ics and ios [17:46:56] guys, we need to decide upon our team's merging policies [17:47:15] who can merge on wich extension and things like that [17:49:25] MaxSem or awjr: can you review this please? [17:50:55] yuvipanda it seems if I remove bottom: 52px with bottom: 0px on scroller then the gap goes [17:50:58] AND it works on android [17:51:06] can u sanity check me? [17:51:33] sanity? on mobile webkit? :D [17:51:35] jdlrobson: checking [17:51:43] if so ill commit on this branch and merge [17:52:39] gave +1, can't merge [17:52:57] MaxSem: can you do +2 [17:53:42] no [17:53:59] that's why I offered to discuss out merging policies [17:54:18] s/out/our/ [17:54:52] MaxSem: you don't see +2 Looks good to me, approved [17:54:59] MaxSem: on https://gerrit.wikimedia.org/r/#change,publish,3387,1 [17:55:25] no, I don't see [17:55:29] MaxSem: lame [17:55:45] poke ^demon :evilgrin: [17:56:02] jdlrobson: bottom:0px has no effect on me [17:56:09] no? [17:56:15] oh wait, that + the margin-bottom? [17:56:26] yes [17:56:26] :) [17:56:27] sorry [17:56:32] okay [17:56:35] testing [17:56:59] preilly MaxSem i only see +1 as well [17:57:08] jdlrobson: lame [17:57:08] ' Looks good to me, but someone else must approve' [17:57:23] jdlrobson: looks good to me [17:57:30] super yuvipanda [17:57:31] pushing.. [17:57:33] preilly: can you work with the team to sort out any weird gerrit/perms/git issues ? [17:57:33] yuvipanda: [17:58:31] [WikipediaMobile] jdlrobson pushed 2 new commits to master: http://git.io/0AFcGw [17:58:31] [WikipediaMobile/master] Fixes #34170 and overflow issue in pages - 4ndreaSt4gi [17:58:31] [WikipediaMobile/master] drop bottom property now margin-bottom present - Jon Robson [17:58:32] tfinc: yes [17:58:43] thanks [17:58:45] Project WikipediaMobile - Nightly builds build #253: SUCCESS in 7.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/253/ [17:58:45] * stagi.andrea: Fixes #34170 and overflow issue in pages [17:58:46] * jdlrobson: drop bottom property now margin-bottom present [17:59:11] ! [remote rejected] master -> master (prohibited by Gerrit) :( [17:59:23] jdlrobson: did you try to push? [18:00:07] jdlrobson: you need to push your change to Gerrit with git review [18:01:20] yeh i just did git push [18:08:33] jdlrobson: that's wrong [18:08:49] jdlrobson: have you looked at: http://www.mediawiki.org/wiki/Git/Workflow#Commit_a_change [18:08:51] yeh i'm just reading up on documentation and installing git review [18:11:21] jdlrobson: coolio [18:13:01] preilly: if i run git review will it push all my branches or just master? [18:13:50] jdlrobson: it only pushes from the local branch [18:14:01] ok lets give this a go then [18:14:14] jdlrobson: all it does is a git push basically with a change id etc [18:14:16] arggh git stash? really? [18:14:36] jdlrobson: is it complaining? [18:14:55] well 2 problems [18:15:11] first i had to stash my local changes that i'd made to MobileFrontend.body.php to allow me to force the beta on [18:15:13] that's rather annoying [18:15:17] then ! [remote rejected] HEAD -> refs/for/master/master (invalid committer) [18:15:28] who's it calling an invalid commiter!! :) [18:15:35] haha [18:15:55] awjr: your fundraising office hours end after this month right? [18:16:29] ugh, i don't have pip installed .. time to build that and then git-review [18:16:42] tfinc: correct. after today i have next tuesday and next thursday and that's it [18:16:46] k [18:18:52] jdlrobson: ask sumana about that in #wikimedia-dev [18:19:19] jdlrobson: are you sure that you are using your shell account name? [18:19:34] i believe so [18:20:00] how would i check preilly ? [18:20:02] woot .. gerrit is all set up now [18:20:19] jdlrobson: can you try again [18:20:41] yep 1s [18:20:59] jdlrobson: have you logged into gerrit yet? [18:21:07] yeh i logged in np [18:21:11] To ssh://jdlrobson@gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend.git [18:21:11] ! [remote rejected] HEAD -> refs/for/master/master (invalid committer) [18:21:11] error: failed to push some refs to 'ssh://jdlrobson@gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend.git' [18:21:31] jdlrobson: Ryan_Lane is looking into it [18:21:35] jdlrobson thanks for merging :) need to go now! [18:21:39] cya soon [18:21:41] bye all! [18:22:55] last i heard yesterday was that would not be able to push to extensions until they went and added some gerrit config file or something like that to all of the extensions in git [18:23:00] but i dunno where things are at now [18:23:07] jdlrobson: you need to change your email address in either git set-up [18:23:21] jdlrobson: or in gerrit [18:23:31] jdlrobson: it's jrobson in LDAP right now [18:23:47] you can add a second email address in gerrit if you want [18:23:56] but, your email address in your local repo must exist in gerrit [18:24:25] similarly with your git username in your local repo [18:24:36] if it doesn't match, gerrit will complain [18:25:37] jdlrobson: after fixing your name and email, you'll need to amend your commits [18:25:50] * jdlrobson confused - my email address? what does that have to do with things? [18:25:51] w [18:25:51] he [18:26:04] when i login to gerrit it says my email is jrobson@wikimedia.org which is correct [18:26:14] what does your local repo say? [18:26:17] ahhh [18:26:21] of course... github [18:26:21] i see [18:26:28] you can set this per repo [18:26:41] git review -s can do it for you [18:33:38] can i change my full name in gerrit? [18:33:43] my commits show Author: Jon Robson [18:34:03] and under gerrit I am jdlrobson / jdlrobson@gmail.com but full name is Jdlrobson [18:34:11] guessing the full name is the issue Ryan_Lane ? [18:39:26] ahh im getting missing Change-Id in commit message that's different [18:40:06] jdlrobson: what does git log show? [18:40:14] do you see the change-id? [18:40:46] no dont see any change-id's so this is the issue [18:40:47] also, do you have the hook in your .git/hooks directory and is it executable? [18:41:06] Ryan_Lane: can you help jdlrobson a little more [18:41:50] ok got them now [18:41:55] i didnt have the hook when i did these commits [18:42:01] so i need to manually edit them all i guess [18:42:34] jdlrobson: just squash them [18:43:17] Ryan_Lane: disregard [18:43:43] squashing will give me just one commit no? [18:43:59] jdlrobson: yeah [18:44:22] jdlrobson: with references to the original commit messages and the correct change-id [18:44:30] jdlrobson: it should be fine [18:44:32] yeh i dont really want to do that.. [18:44:42] ahh ok [18:44:44] jdlrobson: well, then amend them all [18:45:13] ill squash this one time then [18:50:23] ping [18:50:29] preilly: they are pushed [18:51:29] gerrit-wm: New patchset: Jdlrobson; "merge toggling css, smooth out transitions" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3412 [18:51:30] gerrit-wm: New patchset: Jdlrobson; "adjust footer for RTL reading" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3413 [18:51:31] gerrit-wm: New patchset: Jdlrobson; "adjust padding for references" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3414 [18:51:33] gerrit-wm: New patchset: Jdlrobson; "minor: add comment marker to css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3415 [18:51:33] Project WiktionaryMobile - Nightly builds build #33: SUCCESS in 6.8 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/33/ [18:51:34] gerrit-wm: New patchset: Jdlrobson; "throw away viewport modification" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3416 [18:51:35] gerrit-wm: New patchset: Jdlrobson; "address problem with invisible search results on iphone" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3417 [18:51:36] gerrit-wm: New patchset: Jdlrobson; "merge outline css rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3418 [18:58:07] one of our changes today broke the about page in iOS [18:58:08] sigh [19:02:19] jdlrobson: the ugly hack has broken iOS about page scrolling :| [19:02:28] noooo [19:02:30] doesn't seem to have broken anything else [19:02:33] all other scrolls work [19:02:34] how?! why!? [19:02:35] except for about page [19:02:37] not sure [19:02:48] reverting that makes it work, so does going to the commit just before that [19:02:50] investigating [19:03:08] so no scroll bar appears? [19:03:13] jdlrobson: no [19:03:15] and no scrolling happens [19:03:18] only on the about page [19:03:25] other pages that use it (main, saved pages, history) work [19:03:53] mm [19:06:42] jdlrobson: sooooo [19:06:48] commenting out the .hide makes the scrolling work [19:07:41] mm [19:10:11] try giving about-page-content height 100% [19:10:56] jdlrobson: no dice. [19:11:03] mm [19:11:07] this is most weird [19:11:12] what's so special about this about page [19:12:48] Project WiktionaryMobile - Nightly builds build #34: SUCCESS in 6.6 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/34/ [19:12:48] pfhayes: Adding toggle and removing old files [19:12:48] jdlrobson: nothing I could think of... [19:13:09] [WikipediaMobile] yuvipanda pushed 2 new commits to master: http://git.io/8wQIjg [19:13:09] [WikipediaMobile/master] Updated deduplicated AUTHORS list - YuviPanda [19:13:09] [WikipediaMobile/master] Added full CREDITS for iOS and Android. - YuviPanda [19:13:23] Project WikipediaMobile - Nightly builds build #254: SUCCESS in 8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/254/ [19:13:24] * yuvipanda: Updated deduplicated AUTHORS list [19:13:24] * yuvipanda: Added full CREDITS for iOS and Android. [19:14:17] jdlrobson: want something even more weird? [19:14:30] go on then.. [19:14:33] jdlrobson: commenting out the doFocusHack call -> still doesn't scroll! [19:14:39] but commenting out just the hide -> scrolls [19:15:34] commenting out just the scrollTop -> scrolls! [19:16:02] commenting out them both -> scrolls [19:16:54] jdlrobson: comment out all three lines -> doesn't scroll :| [19:17:51] jdlrobson: replacing the doFocusHack with a single 'show' call works [19:17:55] but i've no idea why [19:18:00] THIS IS KILLING ME [19:18:41] grrr python [19:19:14] jerith, around? [19:23:12] are Show/Hide buttons supposed to be working in trunk right now? i am currently finding they don't work, even after running 'make remotes' [19:23:35] pfhayes: they are... [19:23:43] athat is very wierd yuvipanda [19:25:05] pfhayes: ouch, you're right. doesn't seem to work :| [19:25:09] was working yesterday. [19:25:12] hm [19:29:42] oooh [19:29:49] jdlrobson: the hack broke expand/show sections too :| [19:29:59] show what?! arhhaaa [19:30:28] something really weird is happening here [19:30:41] indeeed! [19:30:54] pfhayes: 86ed7486ffb25ca1f3acf356aaafe9aafac378af is the commit causing problems, was introduced to fix issues in android 3.x and 4.0 [19:31:28] yuvipanda: what kind of issues was this fixing? we were having some 4.0 issues in wiktionary as well, sounds related [19:31:33] can the hack be applied to just android? [19:31:38] since i dont think ios had the problem? [19:31:56] jdlrobson: easily, but show/hide won't work on android 3.x... [19:32:05] no? [19:33:42] jdlrobson: well, it doesn't work on iOS or android 2.x [19:34:30] * jdlrobson doesn't understand why/how this could have happened [19:34:40] just because we do a show and then a hide?! [19:35:42] aooaretly [19:35:43] err [19:35:44] apparently [19:37:01] jdlrobson: btw [19:37:10] getting rid of the scrollTop 'fixes' this issue as well! [19:37:24] also isn't a jquery problem - just tried with [0].scrollTop [19:37:46] ok [19:37:50] i have a theory [19:37:53] element is undefined [19:37:55] jdlrobson: removing hide *or* scrolltop fixes it [19:39:03] jdlrobson: neither element or $(element) is undefined [19:39:07] boo [19:39:11] consistent across android and iOS [19:39:17] s/or/nor/ [19:39:44] jdlrobson: can you check in 4.0 if commenting out the 'show' still causes the issue? [19:40:01] i know this is a voodoo hack on top of a voodoo hack, and very pukey.... [19:40:45] vooodooo voodooo [19:41:25] interestingly [19:41:30] the toggle buttons are triggering the right event [19:42:42] jdlrobson: :| [19:42:49] and just not toggling? [19:43:04] * jdlrobson must eat soon [19:44:53] wow [19:45:02] putting an alert("!") inside toggle makes toggling work [19:45:05] shame that's not useful [19:45:29] o_O [19:45:30] O_o [19:45:39] i for sure hope that we're missing something here [19:45:44] rather than 'webkit, powered by voodoo!' [19:45:58] ohh... only if there are more than 1 alerts [19:46:10] o_O [19:46:13] O_o [19:46:17] Project WiktionaryMobile - Nightly builds build #35: SUCCESS in 6.7 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/35/ [19:46:18] pfhayes: Removing unused application.js [19:46:46] jdlrobson: does removing the .hide() 'fix' the issue? [19:51:27] sigghhh [19:51:35] $(el).hide(); // HACK: for bug 35369 [19:51:35] $(el).scrollTop(0); [19:51:35] window.setTimeout(function() { [19:51:35] $(el).show(); [19:51:36] }, 0); [19:51:40] that solves it :S [19:51:49] our good old friend setTimeout [19:52:08] jdlrobson: both the hide show *and* the previous 'scroll' issue? [19:52:40] fixes toggling [19:53:03] jdlrobson: do you have a 4.0 emulator still up? [19:53:21] i can boot but then after that i reeeallly must eat my stomach is shouting at me [19:53:49] damn wikibugs [19:54:03] jdlrobson: fix the stomach :) [19:54:05] * yuvipanda tries booting them [19:54:16] yuvipanda: I have answered about "make builds" on https://bugzilla.wikimedia.org/35405 [19:54:27] hashar: yes, that's mostly what we'll be doing. [19:54:37] hashar: though i'm not sure if we'd just put MF itself as a submodule [19:54:39] yuvipanda: short story: makes the MobileFrontend git repo a submodule of the github Wikipedia app repo [19:54:43] or have a version of it. [19:55:00] the way submodule works, you have to specify a sha1 commit [19:55:08] hashar: the previous idea was to make something like https://github.com/yuvipanda/MFToApp [19:55:14] but i think pinning directly is a much better idea [19:55:16] so you both point to an URL and a commit [19:55:30] yes [19:55:32] that'd work [19:55:52] or you could have a local shell script which fetch the .css, git add them in the wikipedia app git, and git commit -m 'update mobilefrontend CSS from upstream' [19:56:45] yeah what you did on MFToApp [19:56:53] but I don't think you need to have it done by Jenkins [19:57:19] yuvipanda: if this works this is the most horrible hack yet [19:57:27] did you guys had any issue with using gerrit for MobileFrontend ? [19:59:33] looks like i've a workign 4.0 emulator! [19:59:54] I never managed to get a usable emulator :D [20:00:09] always been awesomely slow :/ [20:00:31] jdlrobson: haha, commenting out 'hide' also fixes toggle [20:00:47] it does not, however, fix oru scroll issue [20:01:05] * jdlrobson now struggling to deploy app to ics [20:02:52] setTimeout seems to 'fix' both issues [20:05:58] yuk http://pastebin.com/V6mt8fv6 [20:06:09] yuvipanda: that seems to work on ICS, IOS and android 2.2 [20:06:14] in that toggling works, the about page scrolls [20:06:22] horrible [20:06:24] i need some food [20:07:16] jdlrobson: please do get food :) [20:07:26] jdlrobson: http://pastebin.com/Z1HS9PQe seems to work on ICS, iOS and (/me goes to test 2.3) [20:47:49] jdlrobson: poke when finished nom-noming [20:47:55] jdlrobson you 'round? [20:48:10] yuvipanda: http://www.omnomnomnom.com/ [20:48:13] yuvipanda: poke awjr : yup lets havk [20:49:22] jdlrobson: re the footer links, i just responded to your email but in short, i think the quickest and easiest thing to do to get this stuff resolved immediately is to just add our own link generation method in the parent template class [20:49:29] yep i saw awjr [20:49:30] uh [20:49:33] sounds good to me [20:49:34] cool [20:49:40] hi kul - ping [20:49:45] shall i just go ahead and do that? [20:49:49] jdlrobson ^ [20:50:00] yep that would be perfect [20:50:14] cool let me just wrap up what im doing and i'll get on it [20:50:24] how much longer are you around? [20:50:33] hi, question: has anybody played with Wikipedia app working with Cordova + Windows Phone? [20:51:08] next 2 hours at least awjr [20:51:23] jdlrobson ok i imagine i'll have it done before then. [20:51:35] if i can make git do what i want :p [20:51:52] hey qgil [20:52:05] somebody from Nokia contacted me. let's discuss offline [20:52:27] oook kul, this is what I wanted to talk about [20:54:13] * awjr curses android emulator [20:54:59] actually, tfinc or anyone else curious about https://bugzilla.wikimedia.org/show_bug.cgi?id=35413 who has an android device /other/ than a galaxy nexus… can you try and reproduce the issue with a fresh installation of chrome beta? [20:55:12] qgil: there was also someone from Microsoft working on that, but that stalled with some license issues. tfinc would know more [20:55:45] yuvipanda: do you ever actually use the android emulator? [20:55:52] i am, right now [20:55:57] im sorry :( [20:55:58] it's a complete pain [20:56:02] it's horrible [20:56:04] awjr: just use perfecto if no one can pull up a device [20:56:18] heatherw: hi [20:56:20] i am unfamiliar with perfecto [20:56:25] hi philinje [20:56:27] awjr: i'll send you the info [20:56:31] thanks tfinc [20:56:49] awjr: sent [20:57:39] heatherw: let's talk soon, i will be out of this meeting soon [20:57:54] sure! i'll be here [21:00:58] yuvipanda tfinc thanks - I wonder if Nokia could help on the Windows Phone side since Nokia wants a Wikipedia app in all its devices... Please inform kul about the situation, maybe we can move it forward [21:01:25] so its really simple. we have the initial work in place [21:01:40] microsoft refuses to do any more work until we re-license it [21:01:49] i asked for their justification as to why [21:01:53] and we've received no response [21:01:58] ? re-license to what, and for what reason? [21:02:12] that was my exact question to microsfot [21:02:14] blobaugh: ^ [21:02:21] ok, maybe I'm wrong but sounds like on of those misunderstandings big-cors vs non-profit [21:03:02] big-corp, I mean. Nokia has gone through all the OSS learning so perhaps the people chasing apps here don't have such problem? [21:03:51] if you can pass me the name of your MS contact(s) that will help [21:04:29] what license is the Wikipedia app now, anyway? [21:04:39] is it possible to install an app from the market on an android device in perfecto without having to use my own login? [21:05:06] im trying to test a fresh chrome beta install on a non-galaxy nexus [21:05:32] qgil: it's currently GPL, but that might be running into issues too [21:05:48] qgil: blobaugh is the person to poke about Microsoft and this [21:07:54] yuvipanda: must be the same as http://arstechnica.com/microsoft/news/2011/02/windows-phone-marketplace-bans-the-gpl-and-the-app-store-should-too.ars [21:08:15] possibly. [21:08:31] that's also one of the things we're currently wrestling with license wise [21:08:40] but Microsoft didn't make itclear what was the issue [21:08:47] ok, let me stir inside Nokia and see what happens. Nokia Store has been accepting GPL apps since forever [21:09:04] :D [21:09:24] Project WiktionaryMobile - Nightly builds build #36: SUCCESS in 8.7 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/36/ [21:09:25] hy.cheng: removed duplicate div in index.html and code in chrome.js [21:10:16] Project WiktionaryMobile - Nightly builds build #37: SUCCESS in 7.9 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/37/ [21:10:16] hy.cheng: removed duplicate div in index.html and code in chrome.js [21:10:32] Project WiktionaryMobile - Nightly builds build #38: SUCCESS in 7.6 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/38/ [21:10:32] hy.cheng: removed duplicate div in index.html and code in chrome.js [21:17:57] jdlrobson: you wanted to change 'Privacy policy' -> 'Privacy' and 'About Mobile Dev' -> 'About', right? anything else? [21:18:21] exactly [21:18:26] * jdlrobson checks [21:19:07] I don't think so at the current time [21:20:33] jdlrobson: is what i currently have [21:20:37] http://pastebin.com/wZfr2r9W [21:20:54] heatherw linSmith philinje - what are your thoughts on dropping the 'more information', 'less information' text altogether from the footer [21:21:27] and what remains? leaving it all open? [21:21:30] dirty yuvipanda dirty [21:21:47] well heatherw i figured that since the toggle buttons dont need labels saying show/hide [21:21:49] why does the footer? [21:22:18] jdlrobson: but, it seems to work for the most part… :( [21:22:19] the toggle buttons *do* relate to section headings [21:22:30] ah true [21:22:31] and i like the explanation [21:22:45] but i am not attached to that in particular [21:23:00] phil suggested shortening the text to more/less [21:23:14] jdlrobson: i'll also note that i was previously wrong - our margin-bottom does seem to produce a consistent white bar everywhere :| [21:23:16] fine with me :) [21:26:28] jdlrobson: https://github.com/wikimedia/WikipediaMobile/pull/188 [21:26:30] testing it some more... [21:27:12] jdlrobson: https://gerrit.wikimedia.org/r/3495 [21:27:41] boy is jdlrobson in demand :) [21:27:58] awjr: is that approved? [21:28:20] jdlrobson not yet [21:28:41] ah preilly, MaxSem can you take a look at https://gerrit.wikimedia.org/r/3495 [21:28:59] :) yuvipanda [21:30:27] opera mobile is horrible it makes me want to cry [21:31:27] the life of a frontend developer seems to be horrible [21:31:35] * yuvipanda offers jdlrobson http://kidbleach.com/ [21:33:46] there goes my afternoon [21:33:58] * awjr gets lost in a world of cuteness [21:34:09] as solace from the world of gitness [21:34:12] #sorry [21:34:41] actually i have to stop looking or might vomit [21:34:48] too much cuteness [21:35:31] how does one find a picture of a rabbit with 12 just hatched chicks? [21:36:12] aww yuvipanda http://kidbleach.com/images/15.png [21:36:15] why you do this to me! [21:36:28] don't worry it runs out of images pretty fast [21:36:44] zomg [21:36:57] i keep expecting it to show me that scary face with a scream [21:37:07] :D you've been on the internet for long enough :) [21:37:51] jdlrobson: so, that pull request :) [21:38:02] jdlrobson: do you have the ability to do code review in gerrit? you can probably do the final approval for that commit [21:38:18] i think there were issues earlier with code review [21:38:21] MaxSem has +1 ed [21:38:31] but i dont think anyone is capable of +2ing at the moment [21:38:31] doesn't it need a +2? [21:38:36] >_< [21:38:48] jdlrobson & philinje : i filed an rt ops bug for you guys to get blog access http://rt.wikimedia.org/Ticket/Display.html?id=2688 [21:38:53] awjr, apparently, you should be able to +2 it [21:39:04] i can +2 my own commit? [21:39:13] crazy [21:39:20] tfinc: k [21:39:27] I didn't say that Gerrit makes sense:D [21:39:44] wow [21:39:47] ok i just +2'd it [21:39:48] now what? [21:40:02] is it automagically in master? [21:40:52] oh wait it still need' verified'? [21:41:15] oh wow i can verify it also [21:41:17] you can do it, too;) [21:41:24] just... [21:41:26] wow. [21:41:53] awjr, that's why I proposed to discuss our team's merging policies [21:41:55] how is that ok [21:42:04] who should be able to verify and merge? [21:42:04] ah yes [21:42:32] oh interesting, that is up to the specific project to decide? [21:43:14] i dont think we should be allowed to review our own code, but i think anyone should be able to merge reviewed code master [21:43:29] there's already Analytics group, for example [21:43:48] anyone who wants that ability, anyway, and demonstrated themselves not to be a total dumbass [21:44:25] is the idea then, that we keep 'master' in a deployable state? [21:44:39] or just a stable state? [21:44:47] or semi-stable state like trunk in svn? [21:44:52] since most people don't look much at our code anyway... [21:45:37] i guess it would be cool if we kept master in a deployable state [21:46:35] as long as you could still fetch other people's yet-to-be-merged changes that your code might be dependent on, which i gather is doable [21:48:18] but keeping master deployable would make deployments a hell of a lot easier [21:48:24] and i think that's the ultimate goal for core [21:52:51] awjr: i would like to go soon. Is this likely to be +2ed any time soon? [21:53:09] jdlrobson i think it's ready to go? [21:53:16] jdlrobson: could you merge that pull request in before leaving? [21:53:42] awjr: i cant pull it... [21:53:51] jdlrboson: sorry im not sure what else needs to be done [21:53:57] yuvipanda: i take your word on that hack [21:54:18] jdlrobson: it works, and i'm continuing testing. [21:54:33] ahh awjr being sleepy [21:54:38] obviously the code is outside MFE [21:54:59] yuvipanda: feel free to merge, i cant bring myself to go back to phonegap today i have my MFE hat on now [21:54:59] jdlrobson: i'm also going to revert the about page fix astagi made. there *is* a white bar on some platforms (iPad and android 4.0) and okay on some others. [21:55:03] :) [21:55:05] jdlrobson: sure [21:55:08] ok np [21:55:47] actually awjr im still being sleepy.. it is in MobileFrontend [21:55:53] so i havent picked it up [21:56:23] jdlrobson: so i think it's been thoroughly 'reviewed', how does it get into master? [21:56:33] i have no idea [21:56:43] preilly, any idea? ^ [21:59:05] well jdlrobson i think you can check out my changes from gerrit to try them out [21:59:17] under the 'patch set' section there are links for download [21:59:30] im not sure of the different implications of checkout/pull/cherry-pick/patch [22:00:13] oh jdlrobson [22:00:14] actually [22:00:20] i think i might have just done it [22:00:22] try doing a git pull [22:00:28] from master [22:01:38] jdlrobson did it work? [22:02:07] +1 awjr [22:02:23] worked [22:02:28] perfect [22:02:31] woohoo! [22:02:44] it was an even easier solution that i initially thought [22:02:52] i mean, to the link text problem [22:04:49] that's cool [22:05:13] ok git review confuses me [22:05:33] i ran it for the 2nd time again and it sent all my old commits as well [22:05:41] what am i doing wrong? [22:06:29] binasher i am confused about https://gerrit.wikimedia.org/r/#change,3498,patchset=1 as that change already appears to be in master? [22:06:40] i am too [22:06:46] heh ok [22:07:01] gerrit shows it as a new file with no history [22:07:09] but says the author is preilly@php.net [22:07:19] and the committer is me [22:07:27] yeah [22:07:29] i just ran git-review in my new checkout [22:07:32] did you actually commit it? [22:08:16] Status Merged [22:08:16] i wonder if preilly did something funky [22:08:24] awjr: I did [22:08:49] preilly what did you do? [22:09:07] it looks like my running git-review resulted in an amend to patrick's [22:09:24] awjr: I pushed it directly to master [22:09:36] jdlrobson before you take off for the night - is the new contact us stuff supposed to be for beta or to replace the regular feedback page? [22:09:45] oic [22:10:11] preilly how did you do that? i tried pushing to master but got yelled at by svn [22:10:13] er git [22:10:13] i think to replace the regular feedback page for mobile [22:10:23] and before i take off for the night can someone check what im doing with git review [22:11:40] awjr preilly ? [22:12:33] for instance ive just accidently sent this https://gerrit.wikimedia.org/r/#change,3500 to git review as i was expecting it to ask me to confirm and it didnt [22:13:11] jdlrobson: is this what you wanted reviewed? https://gerrit.wikimedia.org/r/#patch,unified,3499,1,templates/FooterTemplate.php [22:13:28] yes awjr but for some reason it sent everything else as well :( [22:13:37] jdlrobson: well you can abandon that change [22:14:32] [WikipediaMobile] yuvipanda pushed 2 new commits to master: http://git.io/ACwohA [22:14:32] [WikipediaMobile/master] Horrible hack to follow up on 86ed7486ffb25ca1f3acf356aaafe9aafac378af - YuviPanda [22:14:32] [WikipediaMobile/master] Fix extra space appearing at bottom of screen in ICS and iPad - YuviPanda [22:14:32] ok so done that preilly [22:14:46] Project WikipediaMobile - Nightly builds build #255: SUCCESS in 7.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/255/ [22:14:47] * yuvipanda: Horrible hack to follow up on 86ed7486ffb25ca1f3acf356aaafe9aafac378af [22:14:47] * yuvipanda: Fix extra space appearing at bottom of screen in ICS and iPad [22:15:46] so awjr i want all the stuff reviewed im just a bit confused to why it's showing as sent now rather than sent earlier when i did actually send it [22:16:18] jdlrobson: i reviewed 3499 and submitted the patch set, apparently the merge is pending. i dunno if the merge happens automatically or someone else needs to review or / [22:17:04] sorry i think my tiredness is not making me clear. So earlier today (about 4pm) I did a git review and it sent various commits to gerrit [22:17:09] including I8f6dc529 and I31e3a30a [22:17:20] i just ran git review now and expected it to only send I8a2e0009 [22:17:24] oh i thiink the merge is pending because that rev has dependencies [22:17:24] but it sent all of the others as well [22:17:46] jdlrobson is probably pushed all of your local commits in your branch? [22:17:53] s/is/it [22:18:08] i guess [22:18:13] but shouldn't only push ones that have changed? [22:18:16] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/fkkPkw [22:18:16] [WikipediaMobile/master] Bumped version number and updated CHANGELOG - YuviPanda [22:18:18] tfinc: we're ready to roll out RC! (finally) [22:18:30] Project WikipediaMobile - Nightly builds build #256: SUCCESS in 7.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/256/ [22:18:31] yuvipanda: Bumped version number and updated CHANGELOG [22:18:34] tfinc: make iOS build with keys? [22:18:36] argh ill deal with it tomorrow as right now I'm no use to anyone [22:18:38] * yuvipanda goes to make Android build [22:18:46] heh ok jdlrobson [22:18:47] jdlrobson: sleep, sir! [22:18:53] * jdlrobson nods [22:19:07] night all [22:19:10] jdlrobson goodnight [22:27:29] MaxSem: I'm here now, but not for long. [22:28:19] jerith, I'll ask you tomorrow [22:29:38] MaxSem: "not for long" is probably about half an hour. [22:30:04] Need to let supper settle before I go brush teeth and stuff. [22:30:06] too late for me [22:30:17] Ah, cool. [22:30:28] Should be around earlier tomorrow. [22:44:56] tfinc: you'd have to build iOS ipa and then move the android build to dumps (http://dl.dropbox.com/u/8768784/Wikipedia-v1.1RC1.apk) [22:50:00] yuvipanda: just got back [22:50:08] let me do android first [22:50:11] meetings must be fun :) [22:52:08] yuvipanda: http://dumps.wikimedia.org/android/Wikipedia-v1.1RC1.apk [22:52:14] tfinc: use the api key we got in mobile-feedback-l for RIL [22:52:28] RIL ? [22:52:56] tfinc: ReadItLater? [22:53:09] you'd notice that the patch has a bit for ReadItLater key as well? [22:53:24] now acronym [22:53:26] new* [22:53:35] :) [22:55:42] yuvipanda: does it need the [ ] ? [22:56:03] nope [22:56:16] k [22:56:24] struct sockaddr_storage *client_ip_ss = VRT_r_client_ip(sp); [22:56:25] struct sockaddr_in *client_ip_si = (struct sockaddr_in *) client_ip_ss; [22:56:25] struct in_addr *client_ip_ia = &(client_ip_si->sin_addr); [22:56:48] damn, sorry — wrong window :( [22:57:18] o_0 [22:57:47] yuvipanda: what did you use for our own app id … i only have a Facebook id [22:57:58] tfinc: ? [22:58:08] you have [22:58:09] fbyour-own-app-id [22:58:16] fb[YOUR-FB-APP-ID] [22:58:19] it's the facebook id [22:58:21] are those the same? [22:58:24] yes [22:58:27] oh wait [22:58:29] i'm dumb [22:58:30] haha [22:58:39] should name them a bit more consistently :) [22:58:51] sure [22:59:04] does it need the fb at the beginning ? [22:59:42] yes [22:59:43] it does [23:01:02] meeting time … will try and finish up when i have a second again [23:02:11] hah sure [23:02:27] tfinc: release notes/email. read when you can steal another second. [23:02:27] http://etherpad.wikimedia.org/android-1-1rc1-release-notes [23:02:34] and remember you need to update a few UDID [23:02:34] s [23:32:46] Can we do something to fix the dupe names in the credits? [23:34:10] and isn't ShareKit gone? [23:34:26] Reedy: i did [23:34:33] Oh :) [23:34:42] philinje: just added a note to the discussion page for Mobile design/Contact re 'saving email' feature (http://www.mediawiki.org/wiki/Talk:Mobile_design/Contact#Saving_email_-_verbiage_and_necessity_of_feature.3F) [23:34:46] devgeeks: it is [23:35:04] I must be looking at an old CREDITS, nvm.. [23:35:10] cause I see dupes as well [23:35:15] devgeeks: ah yes, the CREDITS file hasn't been updated yet [23:35:24] need to rerun that script [23:35:26] ignore me then [23:35:28] I fixed it for the about page [23:35:53] * Reedy fixes yuvipanda [23:36:13] sorry, I'm DRM'd :P [23:45:27] heya yuvipanda! [23:45:35] testing completed! :D [23:45:45] no crashes [23:47:38] Astagi: nice! [23:47:43] we just built the RC [23:47:53] waiting for tfinc to build the iOS version before mailing it out [23:48:00] nice :) [23:48:04] http://dumps.wikimedia.org/android/Wikipedia-v1.1RC1.apk [23:48:08] just a question yuvipanda [23:48:12] Astagi: sure [23:48:59] why when you save pages reload them? I lost something in this time I has been busy :P [23:53:02] by the way, how much larger is Galaxy Nexus if compared to Galaxy S II, subjectively? I understand that it's just slightly wider, but hell - GSII is already huge enough [23:53:43] http://cl.ly/2z3b312K1G191y0a0A3M [23:53:50] :) [23:53:55] for MaxSem [23:54:15] I know [23:54:30] "We're gonna need a bigger pants!" [23:54:33] was playing around with my friend's GSII a few days ago [23:54:38] big, but not huge [23:54:40] HOWEVER [23:54:41] I'm interested in subjective impressions of someone who held them both [23:54:53] i don't understand people using the Galaxy Note [23:54:54] as a phone [23:54:56] ah, doesn't feel that much bigger than aa SGSII [23:55:07] yeahm the ote however is a joke [23:55:11] note [23:55:15] MaxSem: i have not held them both but i have a galaxy nexus. it's big, but it actually fits better in my pockets better than my old motorola droid [23:55:16] yuvipanda, Nexus, not Note [23:55:27] i know, am blabbering unrelatedly :) [23:55:31] it's sometimes a little challenging to use one-handed, but i really don't mind it [23:55:45] in fact, i am totally in love with my phone. [23:55:52] yuvipanda, Note is unquestionably non-phonish:) [23:55:59] though my reaction to the galaxy note has been 'who would want to use that as a phone?' [23:56:08] I really like my SGSII, though yeah, sometimes one handed... [23:56:09] i've encountered more Galaxy Notes than iPhones in India [23:56:10] but then again, my previous phone was an original motorola droid [23:56:58] yuvipanda, lemme guess - because freaking apples cost much more? [23:57:08] they cost about the same [23:57:15] ~35k INR [23:57:26] i've seen way more Notes 'on the road' than iPhones [23:57:32] more like ~44k INR [23:58:04] hmm, so it's apple's pecularity in Russia that iPhone is ~30% more expensive than SGSII [23:58:26] wow, yes [23:58:34] the IPhone is ~10k more expensive than the galaxy note [23:58:49] but hey, I'm pretty sure apple doesn't care [23:58:51] Astagi: heya! [23:59:04] it's because that's the way urlcache works right now. [23:59:13] it's a hacky implementation, one ethat i'd want to replace with something saner soon [23:59:20] I wanted to go shopping on my last day in SF, including probably buying something like Droid, but I was suddenly called for interview:) [23:59:29] hey yuvipanda :D I opened a private chat, I seemed out of topic :P [23:59:35] not really :) [23:59:42] nice thanks :)