[00:00:08] Astagi: we're moving to the action=parse API for 1.2, and save pages should become simpler once the migration is complete [00:00:54] I would like to add something to scroll on the previous position, it's really annoyng in that case to see the scroll on the top, maybe I was in the middle of the page :P what about? [00:01:18] oh I see yuvipanda [00:02:04] Astagi: i don't understand that feature. Can you elaborate? [00:02:15] oh sorry yuvipanda [00:02:17] yes [00:02:33] suppose I'm reading the page and I'm in the middle of a long page [00:02:44] I click "save page" [00:02:51] in-page bookmarks? [00:03:11] then app reload the page and scroll on the top... really annoying.. :\ [00:03:21] no MaxSem in a normal page [00:03:34] ah yes. that is indeed an annoying bug. [00:03:42] Astagi: file a bug in bugzilla? [00:04:02] I can work on it now if you want yuvipanda [00:04:04] i think that should be simple enough to implement (grab scrollTop before and after save) [00:04:14] Astagi: you should still file a bug so we can track it :) [00:04:16] yep exactly ;) [00:04:35] Astagi: and I'm not sure i'd want to push this into 1.1, but definitely 1.2 [00:04:50] Astagi: file a bug and work on it :) [00:05:46] no problem, but I have time now , so I must take advantage :D [00:05:54] heh [00:05:56] ok yuvipanda will file a bug [00:06:06] :) [00:18:26] ok finally done [00:18:37] yuvipanda: still awake? [00:18:52] tfinc: is that even a question? :P [00:18:58] haha [00:19:15] * tfinc goes to build the ipa [00:19:26] tfinc: i believe you've a few UDIDs to add too [00:19:42] check the spreadsheet [00:19:57] all the udid in the spreadsheet are in [00:20:05] * yuvipanda checks [00:20:16] tfinc, you certainly know the answer: 03:53:04] by the way, how much larger is Galaxy Nexus if compared to Galaxy S II, subjectively? I understand that it's just slightly wider, but hell - GSII is already huge enough [00:20:32] haha [00:20:53] tfinc: we got one right now, I think. [00:21:14] tfinc: harry burt? [00:21:28] MaxSem: the galaxy nexus is slightly bigger [00:21:36] http://i-cdn.phonearena.com/images/review/2921-image/Samsung-Galaxy-Nexus-vs-Samsung-Galaxy-S-II.jpg [00:21:38] he also helped us with super-thorough android testing a while back. [00:21:47] http://www.phonearena.com/reviews/Samsung-Galaxy-Nexus-vs-Samsung-Galaxy-S-II_id2921 [00:23:00] hmmm, it's almost morning out there [00:23:07] good night [00:23:11] :zzzzzzz: [00:23:12] MaxSem: good night :) [00:23:13] gnite [00:23:24] * yuvipanda has a bus at 9, so will be up until that [00:23:30] might have to resort to coffee :| [00:26:05] hmm .. patch failed on iOS .. /me goes to check why [00:27:30] yuvipanda: i was doing a git apply --check [00:27:55] yuvipanda seems that jdlrobson scroll hack is disappeared [00:27:59] is this normal? [00:28:01] tfinc: hmm, let me make you a new patch template. [00:28:03] Astagi: ? [00:28:22] Astagi: disappeared as in? [00:28:27] yep yuvipanda I can't find his hack in chrome.js [00:28:44] yuvipanda: i can just use 'patch' i guess [00:28:46] Astagi: yes, it's android only so we moved it to android/platform.js [00:28:49] was trying to stay inside git [00:29:24] i'm guessing that'd complain too [00:29:39] yeah, make a new patch [00:29:43] nice :) thanks yuvipanda [00:29:44] as it does [00:29:52] holy motherof god [00:29:52] i'm a fricking idiot [00:29:53] * yuvipanda shoots [00:29:53] self [00:30:02] guess who committed the ids to the repo? [00:30:11] * tfinc sighs [00:30:20] * yuvipanda hangs head in shame. [00:30:51] only the fb one though. but still [00:30:52] sigh [00:30:59] explains why the patch doesn't apply [00:31:40] tfinc: you'll have to create a new app. sorry. [00:40:58] [WikipediaMobile] yuvipanda pushed 2 new commits to master: http://git.io/92keLg [00:40:58] [WikipediaMobile/master] Undo shameful act - YuviPanda [00:40:58] [WikipediaMobile/master] Added new api-keys patch - YuviPanda [00:41:02] tfinc: ^ new proper patchfile + removed current id. [00:41:14] Project WikipediaMobile - Nightly builds build #257: SUCCESS in 8.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/257/ [00:41:14] * yuvipanda: Undo shameful act [00:41:15] * yuvipanda: Added new api-keys patch [00:41:16] will check if it's purgeable, but i'm guessing we'll delete the app which will make the id useless [00:41:38] http://my.opera.com/ODIN/blog/2012/03/22/opera-mobile-emulator-12-update [00:41:50] Opera Mobile Emulator --^ [00:42:01] preilly: --^ [00:43:13] * tfinc goes to pull from master and sighs at yuvipanda's shameful act [00:43:14] :D [00:43:24] it was bound to happen [00:43:34] indeed [00:46:30] tfinc: am afk for a bit, update http://etherpad.wikimedia.org/android-1-1rc1-release-notes with link when ipa is done? [00:46:35] * yuvipanda goes packing [00:46:37] ok [00:59:12] new patch applies clean with git apply -check [00:59:35] yuvipanda: can you verify your Facebook account [00:59:40] then i can make you an admin for the app [01:02:05] tfinc: with a cc? [01:02:07] * yuvipanda checks [01:02:18] tfinc: don't let that block your ipa building [01:14:39] yuvipanda: i wont [01:20:04] relocates to see ryan lanes talk [01:21:46] hmm why do i see this "previous rebase directory /Users/tfinc/Developer/wikipedia-android-master/.git/rebase-apply still exists but mbox given." [01:21:57] after running git am --signoff < api-keys.patch [01:24:14] * tfinc goes to try patch [01:25:58] patch works [01:26:48] share shows me a log in screen [01:27:25] tfinc: the first time [01:27:55] it worked! [01:28:19] do you have any other udids for me? [01:29:25] i have 81 unread messages so its hard to know if any are pending [01:32:13] i'm picking 2 new udids (staff) and one update [01:33:37] app validates [01:36:27] ether pad is now up to date with a fresh ipa [01:36:53] ugh .. i need to add harry's [01:39:18] tfinc: harry's [01:39:54] rebuilding now [01:48:00] new build validates [01:48:21] \o/ [01:49:06] ok updated 683e644d2fd7b09c91c44d324a197707 [01:49:13] same name [01:49:16] try it first [01:54:20] yuvipanda|afk: let me know after you verify it [01:55:49] okay! [01:56:04] that might take a bit, am setting off for the bus now. will verify before i push out though [01:57:27] brb [03:22:52] yuvipanda: yo [03:23:05] tfinc: yo [03:23:06] starting up xcode [03:23:15] this is the first time that i've seen this happen [03:23:58] tfinc: works for me? [03:24:03] hmm [03:24:15] let me try a clean build [03:27:24] it finally loaded [03:27:32] tfinc: 'finally'? [03:27:37] tfinc: what article are you testing it on? [03:27:37] but it took a lot of spinny beach ball of death [03:27:40] mine loaded instantly [03:27:43] tropical cyclone [03:27:48] * yuvipanda loads that [03:28:00] yuvipanda: let me try this on another machien [03:28:45] * flyingclimber rebuilds app [03:29:01] flyingclimber: it is slower, due to the huge debug spew it is emitting [03:29:20] and is that debugging turned on device ? [03:29:22] that could do it [03:30:32] we need to update this http://www.mediawiki.org/wiki/Mobile/PhoneGap/iOS_build_instructions after we release [03:30:40] as its not longer special [03:31:05] yes [03:31:28] flyingclimber: pull? [03:31:42] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/LT518g [03:31:42] [WikipediaMobile/master] Removed debug spew from iOS save page code - YuviPanda [03:31:50] * flyingclimber waits for Xcode to load on this box [03:32:00] there's a power socket under my foot in the bus! [03:32:04] nice [03:32:08] where are you heading to? [03:32:12] there's also a grown man in the seat behind me with justin bieber ring tone [03:32:13] and yuvipanda when do you actually sleep ? [03:32:14] Project WikipediaMobile - Nightly builds build #258: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/258/ [03:32:15] yuvipanda: Removed debug spew from iOS save page code [03:32:17] so i guess that evens out [03:32:19] flyingclimber: good question [03:32:31] one of the things i need to write is an app that tells me what my current timezone is [03:32:42] i like this sleep cycle better than my usual one [03:32:54] wake up at 1pm, work for a bit with jon until 5-6 [03:32:57] sleep for 2-3 hours [03:33:03] wake up at 10 and presto! you guys are there :P [03:33:41] also now that there's a power outlet here, i'm super tempted to just stay up [03:33:49] ugh .. old version of Xcode on this box [03:34:01] going back to my original box so that i can try it with your debug change [03:34:11] yes [03:34:17] that debug spew was villianous [03:34:24] noticed that my machine was heating up [03:34:25] this is why we test [03:34:34] turns out it had pegged my machine at 99 [03:34:36] god we need qa [03:34:50] yes, i saw that with the beach ball of death [03:34:52] * yuvipanda adds 'test on larger articles, not just home page' to 'list of things to do' [03:35:35] tfinc: also, is the app always going to stay on github? [03:35:49] or is there a chance of us moving to gerrit once the dust there settles? [03:35:51] yuvipanda: now that mw is on git/gerrit we can think about a switch over [03:35:59] yes [03:36:02] lets give git/gerrit a month to settle [03:36:06] then we can move [03:36:09] git makes this easy [03:36:12] sounds like a plan [03:36:14] indeed [03:36:22] single remotes change [03:37:27] perfect . now it works like its supposed to [03:37:35] i'm glad we caught this [03:38:10] me too [03:38:20] the more the chances of us having only one RC, the better [03:40:37] another bug [03:40:45] i can't change anything in settings the first time i load it [03:40:50] the second time everything is fine [03:41:31] tfinc: can't change -> ? [03:41:55] i try and select language / font size / about [03:41:59] and nothing happens [03:42:07] i go back to the article [03:42:09] and come back [03:42:10] and it works [03:42:13] hmm [03:42:14] going to do a clean build to verify [03:42:17] i don't see it [03:43:07] not happening this time [03:43:17] must be some weird edge case [03:43:22] this shouldn't be a blocker [03:43:59] yes [03:44:03] i retried it again [03:44:04] i can't find any other blocking issues [03:44:05] couldn't reproduce [03:44:18] i do have one annoyance [03:44:28] having to dismiss a dialog that tells you've saved a page is dumb [03:44:43] are there no dialogs that we can use that just fade away like on android ? [03:44:45] iOS has no equivalent of android's toast IIRC [03:44:49] FAIL [03:44:50] we can build one simply enough though [03:44:51] 1.2 [03:44:52] :) [03:44:53] iOS FAIL [03:44:58] ok [03:45:04] thats not our fault then [03:45:22] let me upload this new ipa [03:46:32] wheee! [03:46:56] its up [03:46:57] 1f7502ac6bc69d5dfe98531de673f6c5 [03:47:05] pull and verify please [03:47:14] yes [03:47:19] i'm only sending you the md5's so that you can be sure you have the latest [03:47:28] yes [03:47:51] you know what'd be awesome? [03:47:58] if apple actually rejects us for being GPL [03:48:06] :D [03:49:35] 14:44 < tfinc> are there no dialogs that we can use that just fade away like on android ? [03:49:40] ^^^^ blockUI [03:49:50] http://jquery.malsup.com/block/ [03:50:11] :) [03:50:27] devgeeks: is there something iOS native? [03:50:37] yuvipanda: that would be interesting [03:50:41] native? [03:50:45] * yuvipanda waits for it to load [03:50:58] you could pop something up and then dismiss it after a set time [03:51:27] yeah that's why i mentioned we could do this in js [03:51:35] and we would - possibly 1.2 [03:52:35] is this just a kinda "yay, you did something" poop up ? [03:52:43] pop, even ;) [03:52:59] devgeeks: yup! [03:53:04] 'yay your page got saved!' [03:53:07] I use blockUI for that [03:54:12] and setTimeout [03:54:17] hmmm [03:54:46] i was looking for something that's more in tune with toast api in Android [03:54:51] which is *not* blocking [03:55:01] basically it just shows up, lets you do whatever you want to do, and gets off [03:55:08] yeah [03:55:16] Be better of writing your own [03:55:27] you don't use jQuery either, yeah? [03:56:00] tfinc: i'm thinking of picking up 1.2 stuff on a branch for today (tomorrow? (wfriday)) when not dealing with feedback. sounds good? [03:56:22] just fade a div in with your message and fade it back out after setTimeout [03:56:43] pretty much [03:56:44] simple enough [03:56:52] yeah [03:57:12] yuvipanda: grabbing dinner .. bbiab .. need anything? [03:57:45] tfinc: nope! [03:57:48] will send out the email! [03:58:06] tfinc: I need caffeinated beer :P Doubt you can get that to me now :P [03:59:34] * devgeeks wishes you could send food via IRC [04:01:34] :D [04:01:39] ah, this is more like the india I know! [04:01:45] ofcourse there's a power socket under my seat [04:01:49] and ofcourse it doesn't work! [04:01:53] hahah [04:02:22] e:D [04:02:34] so that might finally force me to sleep [04:03:09] where are you? [04:04:07] not at home, I assume [04:06:06] devgeeks: philosophically speaking, I'm looking for home :P [04:06:18] physically, i'm on a bus from one city in southern india (chennai) to another (bangalore) [04:06:24] ah [04:06:25] haha [04:06:40] where the primary differences are a better climate + the fact that I can source vodka :) [04:06:41] i was having trouble reconciling "seat" and "sleep" [04:06:46] travelling makes sense [04:08:25] devgeeks: :D [04:08:39] devgeeks: so 3 years of college (so far) [04:08:48] 1 hour commute to and one hour commute from [04:08:54] made useful how? [04:08:55] sleep :D [04:09:08] completely useless classes where the professors get every concept in the book wrong [04:09:10] made useful how? [04:09:11] sleep :D [04:09:16] you get used to sleeping in odd positions [04:09:24] though it does mean your left shoulder gets fucked up [04:31:59] haha [04:33:39] alright [04:33:41] rcs mailed out [04:33:48] 22 hours awake [04:33:50] i should crash [04:33:53] gnite everyone! [04:33:56] tfinc: good night :) [05:30:40] i'm glad that yuvi finally went to bed [05:30:47] it was time for him to rest [05:34:57] he's a machine [05:39:10] even bender needs to sleep [05:39:29] awjr_out: --^ [05:40:50] hahaha [09:51:42] To run wikipediaapp in eclispe i follwed the following tutorial - https://github.com/vivekkuamrbagaria/WikipediaMobile/blob/master/README.md [09:51:56] but there are no generated files in the project [09:52:26] I am getting error - Project has no default.properties file! [10:03:38] MaxSem: could you please help me out [10:03:58] no idea, I don't develop it [10:04:10] I told you when to ask;) [10:13:56] MaxSem: ok. [15:08:45] tfinc: morning. About the Windows Phone marketplace licensing terms [15:08:51] tfinc: "“Excluded License” means any license requiring, as a condition of use, modification and/or distribution of the software subject to the license, that the software or other software combined and/or distributed with it be (i) disclosed or distributed in source code form; (ii) licensed for the purpose of making derivative works; or (iii) redistributable at no charge. Notwithstanding the foregoing, the following softwa [15:09:43] "the following software licenses are not considered Excluded Licenses: CDDL 1.0 (Common Development and Distribution License); CPL 1.0 (Common Public License); Eclipse Public License; Microsoft Reciprocal License (MS-RL); and MPL 1.1 (Mozilla Public License). The GNU General Public License version 3, the GNU Affero General Public License version 3, the GNU Lesser General Public License version 3, and any equivalents to the fo [15:11:13] the reasoning about blocking copyleft licenses seems to be "if the store are pushing out signed binaries containing some variants of GPL, the result may be a violation of the app license terms. Assuming our terms with app publishers also prohibit licenses that would be violated through a signing or encryption process, then it turns into the question who takes the hit when the conflict is discovered? The app store or the app p [15:11:45] (tha latter is not a quote from Microsoft, but by a colleague) [15:13:13] In other words, chossing Mozilla / Eclipse (Apache? / BSD?) license for the Wikipedia app version for Wundows Phone should suffice. No ideawhether the WMF has an opinion about this, of course. [15:13:52] And I'm only a(n unofficial) messenger, these are not my opinions :) [15:15:30] funny, the ~~Android Market~~ Google Play doesn't seem to have any problem with copyleft licenses, and not even Apple's App Store [15:15:45] Nokia Store has no problems either [15:16:15] It will be interesting to see whether this is just anecdotical or triggers something in the permissive vs copyleft quest [15:18:14] qgil, relicensing is such a PITA... [15:18:28] I know [15:18:53] and not always possible, imagine if someone who contributed a patch aeons ago refused to license change or is impossible to contact [15:19:24] having been in the GNOME or Qt projects long enough, I know well :) [15:19:57] anyway, at least in this case the development of the Cordova/Phonegap app is quite recent and easy to track (or so it seems, I'm not involved) [15:20:38] too early for Tomasz [15:20:49] I copypasted everything in an email for him :) [16:07:20] greetings all! [16:07:26] * tfinc starts another day full of meetings [16:13:08] will they ever end? [16:16:10] hi tfinc! [16:24:03] MaxSem: they never end! [16:24:11] i miss coding [16:26:25] hey tfinc [16:26:36] greetings jdlrobson [17:01:17] hi tfinc kul - I asked around for reasons and alternatives ref Windows Phone apps licensing - see my email or IRC log. Summary: copyleft not ok - permissive OK [17:01:22] finishing up a call [17:03:00] MaxSem: I'm here for the next few hours, if you want anything. [17:05:19] ok .. lets do our stand up [17:16:06] preilly: when a user opts into the mobile site could they be redirected back to where they came from or do they have to be redirected to the homepage? [17:16:15] MaxSem: what were you saying about whitelisting a SpecialPage? [17:16:31] first of all: does MF break them that badly? [17:17:10] MaxSem the problem is the form [17:17:22] the formatter strips out forms [17:17:49] second: for the time being, we could make is not to transform a specific special page [17:18:05] well we still want the page transformed for the mobile view [17:18:06] strips out forms? eh, lemme look at it [17:18:52] indeed [17:18:57] jdlrobson: they could be redirected to anywhere as long as it's on the same domain [17:19:13] so it seemed the quickest thing to do would be to implement the form over the existing feedback page so we can get it out faster without making significant changes in MF, and then later move it over to a SpecialPage once we start putting a framework for special pages in place [17:19:46] ok cool preilly just seems a bit odd in the current situation to redirect to homepage. I wanted people to be redirected to kermit the frog for purposes of blog announcement [17:20:05] awjr, makes sense [17:20:08] jdlrobson: hmm, okay [17:20:19] MaxSem: but otherwise, MF treats special pages just fine, so long as they dont have necessary elements that get stripped out by the formatter :p [17:20:31] like… forms ;) [17:21:01] awjr: I would just gate the formatter with a check for it being a special page and override elements that you don't want to strip [17:21:19] awjr, even quicker idea: assign that

a unique id, then whitelist it with one simple call [17:22:06] MaxSem that sounds more straighfroward than preilly's suggestion - where/how would the id get whitelisted? [17:22:31] MobileFormatter::whitelistIds() [17:22:52] preilly i assume is stripped for a good reason and i imagine that reason would pertain to special pages with forms on them as well [17:23:40] MaxSem: that sounds good i'll give that a try on monday [17:24:13] if it's that simple, it'll be faster for me to do this with a special page anyway than having to fully write custom form handling stuff [17:24:14] awjr, MobileFrontend.body.php, line 981 [17:24:20] awjr: it is done that way on the zero search $formatter->whitelistIds( 'zero-language-search' ); [17:24:38] MaxSem, preilly awesome that sounds like it should work [17:24:44] $formatter->whitelistIds( 'zero-language-search' ); --> $formatter->whitelistIds( 'zero-language-search', 'mobile-contactus-form' ); [17:24:45] thanks for the direction :) [17:29:41] MaxSem: but, isn't it still best like I said to gate the formatter with a check for that page like "$wgOut->getTitle()->isSpecial( 'MobileContactUsForm' )" before the "$formatter->whitelistIds( 'zero-language-search' );" call in case the id is used in other pages or contexts? [17:30:37] well, 'zero-language-search' can be abused, too:P [17:31:05] preilly: we could do if( $wgOut->getTitle()->isSpecial( 'MobileContactUsForm' ) { $formatter->whitelistids( 'mobile-contact-form' ) } [17:33:29] awjr: okay [17:34:02] shouldn't $wgOut be destroyed by then? [17:34:14] okok $out-> [17:38:04] jdlrobson: is your personal site up to date with beta changes ? [17:38:19] umm i dont think so [17:38:25] ive lost track because of the git move [17:38:41] if someone can merge my recent changes i can update it [17:38:57] preilly: --^ [17:39:04] i'd love to show erik the updated version [17:41:10] i need to head off soons [17:42:14] awjr: could you do the review for jdlrobson ? [17:42:31] or brion or MaxSem [17:42:36] i'm sure we can find someone [17:43:42] jdlrobson: did you make any progress on keeping the reference section at the bottom of the screen even WHILE scrolling ? [17:43:54] well [17:44:16] so when scrolling on an iphone i found no way of doing that [17:44:22] but [17:44:37] i made a slight change so when you start scrolling down it hides it and then reveals it again when you finish scrolling [17:44:42] tfinc, jdlrobson im happy to take a look but let me wrap up what im working on [17:44:42] i felt it was less confusing [17:44:47] awjr: k [17:45:21] jdlrobson: using the simulator muppet wiki seems to keep their advertisement sticky at the bottom of the screen [17:45:23] how do they do it? [17:45:46] i tried the muppet wiki on my simulator and no scrolling [17:45:56] so i was a bit confused by what you meant [17:46:22] when i open up muppet wiki i see their add. i scroll .. an it always follows [17:46:29] what version of iphone? [17:46:45] 5.0 [17:46:48] ahh [17:46:48] ok [17:47:18] * jdlrobson knows what you mean now [17:56:56] for reviewing changesets in gerrit.. is it better to use 'git fetch' or 'git pull' to test out code? im not entirely clear on the difference/implications [18:03:56] hello gentlemen [18:05:06] wassup yuvipanda [18:05:09] how did the standup go? [18:05:20] awjr: some logistical + connection issues in new city [18:05:29] yuvipanda: where are you? [18:05:32] awjr: bangalore [18:05:41] right on [18:07:11] should update yuvi.in/where [18:07:15] awjr: how did the standup go? [18:07:32] heh yuvipanda that 404's for me :( [18:07:40] the standup went just fine [18:07:40] yuvi.in/where.html [18:07:46] hehe so it says 'not found' eh? [18:07:54] lol [18:15:39] jerith, hi -- I've moved on to another VM with a clean state and it works so far :] [18:15:48]