[19:22:54] MaxSem: New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3696 [19:22:55] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3696 [19:23:27] thx [19:23:36] can you deploy it? [19:24:50] MaxSem: maybe I'm diff'ing it right now [19:27:38] MaxSem: well, I think it might be better if you modified the deployment branch directly with this change [19:28:13] MaxSem: svn+ssh://maxsem@svn.wikimedia.org/svnroot/mediawiki/branches/wmf/1.19wmf1/extensions/MobileFrontend [19:28:47] preilly, I don't have commit rights to it [19:28:58] MaxSem: hmm [19:29:03] I can make a patch [19:29:19] MaxSem: can you make a patch against it and I'll apply it and deploy right now [19:30:28] hmm, we're still have WURFL deployed [19:30:41] MaxSem: against this version https://svn.wikimedia.org/viewvc/mediawiki/branches/wmf/1.19wmf1/extensions/MobileFrontend/MobileFrontend.body.php?revision=114476&view=co [19:37:45] preilly, http://dpaste.com/720945/ [19:40:26] MaxSem: please review http://dpaste.com/720946/plain/ [19:41:38] preilly, they're the same [19:41:46] MaxSem: I know [19:41:54] looks good [19:41:56] MaxSem: I just want to make sure that it looks good [19:42:51] yeah, you can deploy it [19:44:43] MaxSem: can you ok this revision: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114477 [19:45:18] preilly, done [19:47:10] MaxSem: logmsgbot: !log preilly synchronized php-1.19/extensions/MobileFrontend/MobileFrontend.body.php 'Following a performance regression reported on wikitech-l, added merciless profiling to ExtMobileFrontend::DOMParse()' [19:47:24] great, thanks [19:47:55] I guess we'll have to wait for half an hour to have a clear graph [19:52:10] MaxSem: okay, so I'm going to go now [19:52:31] have a nice weekend [20:51:26] MaxSem: you too