[02:26:15] * tomaszf sits down to the more budget work [09:51:41] MaxSem: That setup.py branch is merged. :-) [09:54:19] whee [10:05:34] MaxSem: Would you like commit access to the main vumi-wikipedia repo? [10:05:59] It would probably be easier than working in your own fork. [10:10:00] jerith, I'm currenty not feeling comfortable about my Python skills [10:10:28] though if you're using gated trunk, I guess I can't inflict much damage:} [10:10:45] MaxSem: That's fine. Our workflow is based heavily on code reviews. [10:11:04] We use "git flow" for our repos. [10:11:49] All work happens in feature branches, we submit pull requests when we want reviews and then it gets merged to "develop" (which is basically "trunk") when everyone's happy. [10:12:21] okay [10:14:05] MaxSem: There are often people around in #vumi who can help you out if I'm not available. [10:14:26] And you have commit access to the repo now. [10:14:31] thanks [16:16:22] * ajerith contemplates SMS-only vumi-wikipedia. [16:58:33] greetings all [16:58:44] Hey tfinc. [16:59:30] hey ajerith [16:59:45] jdlrobson: do you have a fix for: https://gerrit.wikimedia.org/r/#change,3693 [16:59:48] looks like we have everyone but yuvi on [17:00:16] preilly: yes see latest comment [17:00:31] all right .. lets do our standup [17:05:39] * YuviPanda waves [17:05:43] standup started? [17:05:55] * YuviPanda pokes tfinc  [17:06:20] * YuviPanda pokes MaxSem awjr  [17:06:36] yup, call tfinc [17:08:08] hmm, did I get disconnected? [17:08:24] FAIL [17:08:48] just me or everyone? [17:10:39] * YuviPanda looks around [17:10:56] Just you. [17:12:34] sigh [17:12:49] * YuviPanda pokes MaxSem awjr tfinc again [17:13:12] * ajerith heads to band practice for the evening. [17:13:25] doctor, help - everyone keeps ignoring me! [17:13:32] next patient! [17:13:51] MaxSem: me too, i'm not even on the call [17:13:56] i don't even know if there's a call [17:13:59] wait [17:14:00] MaxSem: I may be online sporadically from band. I'll be home about three and a half hours from now and at your disposal then. [17:14:04] that's a joke, i didn't get it. [17:14:06] gah [17:14:07] well, there used to be call [17:14:08] * YuviPanda facepalms [17:14:27] did it end prematurely? [17:14:34] ajerith, okay [17:15:13] MaxSem: +1 on splitting the API code out into its own module, by the way. :-) [17:15:23] :) [17:16:13] * YuviPanda pokes maplebed  [17:16:15] preilly sanity check this RegEx for me? /AppleWebKit\/(53[456789]|5[456789]|[6789])/) should match any version over 534 [17:16:21] teehee! [17:16:33] YuviPanda: ! [17:16:43] lets do you standup over irc [17:16:46] your* [17:17:01] tfinc: okay. [17:17:10] i dialed you a number of times but never got a response [17:17:14] Friday was spent poking people and getting lots of feedback, most of it which has been fine [17:17:22] how is RC1 looking ? [17:17:23] tfinc: i got it a bit late, and was in the call for about a minute [17:17:25] then got disconnected [17:17:35] eh it happens [17:17:37] no [17:17:38] sorry about that [17:17:58] heard something about brion and windows marketplace :) [17:17:58] anyway [17:18:05] yes [17:18:19] jdlrobson: looking at that regex; is it the case that the only 3 digit version numbers always start 53? [17:18:20] there are some ui/ux people coming from microsoft on ewd [17:18:23] wed* [17:18:24] tfinc: i think there's one thing we should fix, which is the facebook share behavior. [17:18:30] what do you mean? [17:18:35] that all highe numbers (54, 6, etc.) are 1 or two digits? [17:18:38] also. i'm worried about the amount of change happening today [17:18:40] both beta+apps [17:18:44] i think it may be too much [17:18:57] tfinc: first time you hit share, you see only login. you need to hit share again tos hare [17:18:59] *to share [17:19:09] jdlrobson: if what you're looking for is 3 digit numbers larger than 534, that regex isn't what you want. [17:19:19] jdlrobson, use ranges insted of lists, i.e. /AppleWebKit\/(53[4-9]|5[4-9]\d|[6789]\d\d)/ [17:19:27] jdlrobson: /AppleWebKit\/(534| 5[456789][\d])/ [17:19:33] YuviPanda: you mean that the first time you hit share, it only lets you log in. then you have to tap it again to really share something ? [17:19:34] tfinc: i talked with jdlrobson, beta -> main should not kill app. i'll do more vigorous testing now. [17:19:39] tfinc: yes. [17:19:49] tfinc: that's unless you're already logged in. [17:19:53] first time ever, that is. [17:20:01] YuviPanda: yes. and remember you need to test it with both 1.1 AND 1.03 [17:20:04] maplebed: it depends how webkit version numbers work but I think it should also match AppleWebKit/54 [17:20:04] +1 MaxSem [17:20:13] it takes up to a week for our users to upgrade to a newer version [17:20:14] it just shouldn't match anything under 534.. [17:20:15] tfinc: yes! [17:20:24] that's our final thing we do before we 'release' [17:20:27] yes ranges make much more sense [17:20:36] I'm writing a test framework and would like to use your wiki mobile as an example on how we can run the same test cases on Android and iOS. Would that be ok? [17:20:58] YuviPanda: so. are you still on track to get the app out today? [17:21:07] YuviPanda: we also need to draft a blog post for it [17:21:11] i can help with that [17:21:15] tfinc: yes. [17:21:51] tfinc: awesome. [17:22:14] maturana: awesome! [17:22:25] maturana, it's open source:P [17:22:27] maturana: that sounds interesting. lets us know more. [17:22:28] MaxSem: maplebed /AppleWebKit\/(53[4-9]|5[4-9]|[6-9])/ is what i want I think [17:23:00] jdlrobson: that won't match 546. [17:23:09] you want what MaxSem wrote but with a ? after the final \d. [17:23:29] yes it will.. [17:23:37] maplebed, we need unit tests! [17:23:41] /AppleWebKit\/(53[4-9]|5[4-9]\d?|[6789]\d?\d?)/ [17:23:51] preilly: awjr : do we have any non beta changes going out today that could affect the app push? [17:23:55] "AppleWebKit/546".match(/AppleWebKit\/(53[4-9]|5[4-9]|[6-9])/) does indeed match [17:24:02] i'm debating about doing the app push tomorrow to lessen the amount of moving parts today [17:24:05] jdlrobson: because the match is anchored with a / on the right, you're expressing a strict limit on the number of digits. [17:24:20] oh. [17:24:24] but im not doing a full reg expression test here [17:24:24] The frameworks are open source calabash-ios and calabash-android. We're just building support for hybrid apps now and would like to make a promotion video and that kind of things with a "real" app. We be using it for live demos at workshops and conferences as well. [17:24:26] the / is not part of your regex but the delimiter. [17:24:44] yeh sorry my bad - that was confusing [17:25:26] I would still add in the optional \ds to make it clear what you're going for rather than implicitly accepting them because the string isn't bounded on either side. [17:26:52] tfinc: hmmm [17:26:55] * jdlrobson nods [17:27:14] tfinc: we could do that too, if you want. [17:27:52] YuviPanda: do we have any launch blockers ? [17:28:43] for the app? [17:28:52] no [17:29:13] * YuviPanda starts more testing with the beta [17:29:31] YuviPanda: yes [17:30:07] heads up that yet again i'll be in budget meetings for the whole day [17:30:14] this should be the last one for a bit [17:32:28] Got disconnected :( [17:32:31] The frameworks are open source calabash-ios and calabash-android. We're just building support for hybrid apps now and would like to make a promotion video and that kind of things with a "real" app. We be using it for live demos at workshops and conferences as well. [17:32:49] jdlrobson: do you have any changes for the blog post you'd like to get in before i stake it on techblog ? [17:33:15] nope [17:33:23] it's all good to go as far as i'm concerned tfinc [17:33:59] maturana: that'd be nice [17:34:54] MaxSem: what's our tracking bug for these new perf issues ? [17:35:09] * jdlrobson gets to work on footer changes [17:35:42] jdlrobson: i think we hit a decent compromise for the footer. good enough for the beta. [17:35:52] how will it look in under languages ? [17:36:10] tfinc, nowhere:) they are already resolved [17:36:14] other* [17:36:30] we haven't resolved the 15ms -> 150ms performance drop that patrick was talking about [17:36:38] just to be clear... im working to these designs: http://www.mediawiki.org/wiki/File:Mobile_footer_B.png http://www.mediawiki.org/wiki/File:Mobile_footer_B_expand.png [17:36:38] YuviPanda: If we get some nice tests written we could try to run your nightly build against our device cloud at LessPainful. I don't know how much automated ui test you have already. [17:36:57] maturana: none so far, but we'd like to change that [17:37:10] maturana: we NEED to change that :) [17:37:47] we need to and we also want to [17:37:58] Cool ;) [17:38:30] * tfinc tries to find the tracking bug for the nav bar  [17:38:40] philinje: greetings [17:39:33] tfinc, it was caused by regression in profiling code, ie there's no performance regression [17:39:42] We might be able to help with that. Can't promise how much time we can put into writing the tests, but we could let you run testing at no charge. [17:40:08] maturana: that would be really helpful [17:40:25] were currently have an open RFP for someone to come and do these QA builds outs for us [17:41:13] maturana: http://hire.jobvite.com/Jobvite/Job.aspx?j=ogRaWfwX&c=qSa9VfwQ <-- do you know anyone who would be a good fit for this? [17:41:28] hmm .. i can't seem to find our nav bar bug [17:41:33] need to mark some bugs as blocked by it [17:42:05] here we go 32117 [17:44:17] awjr: two new otrs tickets in the queue about disabling not working [17:45:06] tfinc: Are you looking for someone who can write the test for *all* your supported platforms? [17:45:26] maturana: i'm looking for someone who will come in and create our qa pipeline [17:45:37] and creating tests will be part of their job [17:47:00] tfinc: can you forward them to me? [17:47:04] sure [17:47:45] awjr: sent [17:47:53] thnx [17:48:01] were getting too many reports about it for it to be isolated [17:49:18] tfinc: is there a way i can communicate with the people filing the otrs tickets? [17:49:34] tfinc: I'm not sure I know anyone with experience on all platforms but i'll think about it. [17:49:44] awjr: do you have an otrs account? [17:49:51] maturana: thanks [17:50:08] tfinc: possibly but i dont think so [17:50:20] if i do i don't think i've ever used it [17:50:28] tfinc: Does it make sense that we write test for Android and iOS if you're looking for someome to write it yourself? [17:50:40] maturana: yes [17:50:55] awjr: get an account then you can just respond to these directly [17:51:06] tfinc: is there documentation somewhere? [17:52:02] tfinc: or can you jsut tell me how to get an account? [17:52:26] awjr: hmm..i got mine ages ago [17:52:37] either from phillipe, casey, or james [17:52:47] tfinc: The calabash projects are under EPL would that be a problem. It explicitly says GPLv2 in the RFP [17:53:12] tfinc: from the language of both of those tickets i think the submitters might not have clicked 'Desktop view' but i'd like to confirm with them. i think they're missing the old, verbose 'permanantly disable the mobile version of this site' [17:53:16] maturana: i'm not familiar with the EPL so i'd have to send it to the lawyers [17:53:27] awjr: lets hope its just that [17:53:45] yeah, im going to try and confirm with them [17:55:22] tfinc: Alright. We'll write some tests and then get back to you. Then we can figure out what to do. [17:55:30] maturana: thanks! [17:57:12] YuviPanda: have you had a chance/ability to test going from the current iOS app -> 3.1 ? [17:57:58] jdlrobson: how goes crafting a list of test phones ? [17:58:10] greetings Jarry1250 [17:58:12] busy day here [17:58:46] Hey hey. [17:59:14] o/ [18:00:45] tfinc my list so far is basically all the blackberrys and symbians you own. :) these are the ones i have the most headaches teting [18:01:13] jdlrobson: k. if thats the case send me an email and i'll make you a care package :) [18:07:07] awjr: we are looking good in https://gerrit.wikimedia.org/r/#q,extensions/MobileFrontend+status:+open,n,z code review [18:07:20] awjr: so, I think we should be fine deploying from trunk today [18:07:24] preilly that is absolutely baller. [18:07:29] awjr: which is totally nice [18:07:38] hellz yeah that will be a lot easier [18:08:07] awjr: should be able to just update your repo and diff the git and svn directories to get all the changes [18:08:26] awjr: also, WURFL will be gone as well [18:08:38] awjr: so, we should become a bit faster as well [18:08:45] preilly yeah should be pretty straightforward. although i guess i won't be able to easily pick up all the revision ids [18:08:55] * preilly really seems to use the term, "as well"… [18:09:18] i do as well [18:09:27] awjr: well, you can based on Change Id [18:09:42] awjr: the older imported from SVN doesn't have them does it? [18:09:57] preilly not sure i'll have to poke [18:14:28] YuviPanda: i think we should block the app release on beta and wait till tomorrow. thoughts ? [18:14:42] fine by me. [18:14:52] YuviPanda: i don't think that changes anything for you [18:15:00] YuviPanda: just makes today a bit less insane for us [18:15:05] +1 [18:15:19] i'll just test until i'm confident then pick off 1.2 [18:15:21] for future weeks lets offset mobile web and app by a week [18:15:31] YuviPanda: start on the blog post [18:15:38] we want that ready to go [18:15:39] right. [18:15:50] YuviPanda: we have lots of other mobile blog posts on tech blog [18:15:54] awjr: it looks fairly straight forward — http://pastebin.mozilla.org/1535260 [18:15:56] test then blog post. [18:16:07] and i'll share the beta post were doing for beta with you [18:16:09] tfinc: we're doing a 'what's new + iOS!' blog post, right? [18:16:13] not a 'nuts and bolts' one [18:16:22] YuviPanda: yes [18:16:30] YuviPanda: also include android uptake stats [18:16:30] cool [18:16:33] i can export you a csv [18:16:36] super! [18:16:37] do that [18:17:02] YuviPanda: shared [18:17:58] cool [18:19:26] we should also make sure that the opt-in beta link in the blog post actually works correctly and use bit.ly for the stats collection [18:19:47] I think the old link for beta opt-in is broken [18:20:09] tfinc: I think you missed me saying, "we should also make sure that the opt-in beta link in the blog post actually works correctly and use bit.ly for the stats collection". [18:21:02] preilly: what broke with it ? [18:22:14] heatherw: footer changes -> http://jonrobson.me.uk/wikipedia/footer.html let me know what you think [18:23:22] tfinc: let me check again [18:23:26] jdlrobson: how many languages do we have the Wikipedia ® image for ? [18:23:42] also .. any chance we can do that with text rather then an image ? [18:23:51] tfinc: it points to http://en.wikipedia.org/wiki/?mobileaction=opt_in_mobile_site [18:23:52] ah... good question. Only 1 at the moment [18:23:56] jdlrobson: thats bad [18:23:59] lets do it as text [18:24:07] then we can pick up / re-use translations [18:25:34] jdlrobson: looks good to me! [18:26:01] how can we do it as text? not use the word mark? [18:26:04] well the alt text will get translated tfinc but the image at the current time won't [18:26:10] my local git repo for MobileFrontend seems to have … disappeared. [18:26:12] is that still R? tfinc [18:26:23] the 'MobileFrontend' directory is there, but it is completely empty [18:26:47] awjr: well, that's not good [18:26:51] no, it's not [18:27:02] i had done a bunch of contact us work in a local branch [18:27:02] awjr: did you do some sleep "rm -rf''ing [18:27:17] preilly it's possible i have a pultergeist [18:27:26] What does git status say? [18:27:50] jeroid the dir is completely empty so git doesnt even say it's a repository [18:28:06] Ah. ;_; [18:28:09] awjr: wrong folder? [18:28:11] these are dirs in a VM that i use for development [18:28:22] YuviPanda that's what i thought at first but it's not [18:28:29] it's right next to my clone of core [18:28:48] argh [18:29:31] awjr: heads that phillipe is flying back today [18:29:34] my inclination is to blame the vm or vm manager. it's really weird though, the MobileFrontend directory wouldn't even exist where it is now without a git clone [18:29:41] awjr: hopefully that email will catch him at the airport [18:29:49] tfinc: ok thanks [18:30:24] tfinc: that might be a reason to go back to legal? the word itself, is it registered? (i have no idea how that stuff works) [18:31:04] heatherw: do you mean if we have it registered in other languages ? [18:31:22] did we not render these in other languages ? [18:31:54] i mean, if legal wanted to switch to the marks, not just the word. [18:32:20] we do have "wikipedia" in other languages, i don't know if adding an ® to them is correct. [18:32:47] heatherw: right … hmm [18:32:58] tfinc: the wikipedia logo could point to logo_copyright_.png and use an alt text [18:33:10] although that would lead to a lot of 404s [18:33:17] jdlrobson: that would be full of fail :( [18:33:23] (i could also revert to text where it's not english) [18:33:26] thats a launch block then [18:33:34] awjr: There isn't done kind of strange overlay filesystem involved, is there? [18:33:43] :/ [18:34:14] jeroid well i use fuse to locally mount my dev directories from the VM to my local machine [18:34:25] i wonder if that caused some serious weirdness [18:34:34] but i'd never had issues in the past [18:34:56] Maybe something got unmounted somewhere? [18:35:16] * jeroid had that happen once. [18:35:28] jeroid im in the VM now directly and … well it's just not making sense [18:36:04] what's weird is i had one other extension checked out form git, and its dir is totally empty also [18:37:43] i wonder if something went horribly wrong with fuse/sshfs [18:38:03] but i dont know why it would happen to only those directories which were sub-sub directories of the mountpoint [18:38:19] jdlrobson: heatherw talking with kelly about non english text now [18:38:20] i had probably a day's worth of work only committed locally :( [18:38:25] awjr: :( [18:38:27] k tfinc keep me updated! [18:39:54] * awjr enables auto-snapshotting in vmware [18:40:54] That's one of the reasons I push regularly. [18:41:16] jeroid yeah but this stuff was not pushable - experimental and unfinished [18:42:45] awjr: http://zero-testing.wikipedia.wmflabs.org/xhprof_html/callgraph.php?run=4f70b887534df&source=mobile_frontend_extension&all=1 [18:44:16] jdlrobson: kelly is punting to our trademark lawyer michelle who's not in yet. i just txt'd michelle so hopefully well get a response [18:45:16] awjr: and http://zero-testing.wikipedia.wmflabs.org/xhprof_html/?run=4f70b887534df&source=mobile_frontend_extension&all=1 [18:46:55] jdlrobson: worse case though. lets think about our options [18:47:07] awjr: try apt-get install scalpel [18:47:23] awjr: then scalpel /dev/sda1 -o output [18:47:27] jdlrobson: we could use the image or (ideally) text with ® on en and just the localized text for Wikipedia on the others [18:48:01] preilly what's it do? [18:48:02] preilly: i never knew about scalpel .. awesome [18:48:18] awjr: essentially undelete [18:48:20] ! [18:48:47] but it seems to work at the device level [18:48:59] awjr: just do a sudo scalpel "device name/Directoryname/file name" -o "output directory" [18:49:19] where name/Directoryname/file name is the file you're looking for? [18:49:31] jdlrobson: i mean its not as if we show our marks anywhere now on the desktop :) [18:49:53] correct tfinc that would be the simplest option, alternatively we could throw the label altogether [18:49:54] awjr: yeah [18:50:16] the marks aren't even on the logos anywhere http://wikimediafoundation.org/wiki/Wikimedia_official_marks/About_the_official_Marks [18:50:17] we might also encode the url of the image in the localized string to allow contributors where applicable to provide an alternative logo for their given language [18:51:00] jdlrobson: do we have access to the localized string for wikipedia in the footer? or will we have to wait for a round of translate wiki ? [18:51:02] awjr: also, you'll need to configure the program to recover file types by uncommenting the respective file types you need to recover in the config file. For those who may not be familiar with commenting and uncommenting, here is a brief explanation: Commenting a line of code means placing a '#' at the beginning of the line so that the compiler/interpretor will ignore this particular line during program execution. In order for the recovery be [18:51:02] productive, you MUST uncomment the file types you wish to recover in the configuration file. The config file is located in the /etc directory, as shown below: [18:51:20] a round of translation tfinc [18:51:23] tfinc: you'll have to wait [18:51:42] tfinc: also, we need to insure that the translate folks translate it correctly ;) [18:52:09] tfinc: as, some of ours aren't actually correct — but, more agreed upon in nature [18:53:01] preilly: seriously ? [18:53:02] wow [18:53:05] thats scary [18:53:14] no MW:message we can pull from ? [18:53:47] tfinc: brion says NOPE [18:54:06] * tfinc signs with dismay  [18:54:08] tfinc: because it comes from the config not the message cache [18:54:21] * preilly didn't know tfinc knew sign language  [18:54:36] my experience in just working on indic languages, my computer couldn't read half of them so they all turned out wrong, svg should have been reliable but was not always. [18:54:41] * brion speaks fluent sigh language [18:54:44] *SIGHHHHHH* [18:54:48] :) [18:54:52] * tfinc didn't know that tfinc could both do a budget meeting and stay active in here  [18:55:01] * heatherw is impressed [18:55:09] * preilly paralinguistic respiration FTW [18:55:20] :) [18:55:21] way to be nerdy brion [18:55:22] :D [18:55:30] haha [18:55:42] paralinguistic .. wow … nice [18:56:13] * preilly — thinks that it's 5 dollar word Monday... [18:56:38] yes! [18:56:55] any iterm2 users in here ? [18:57:01] i stumbled on to it over the weekend [18:57:09] Used it a while ago [18:57:13] but now on the default term [18:57:15] pretty nice it is [18:57:24] * preilly is glad that he didn't say, "pharyngeal fricative"... [18:57:31] tfinc: nope [18:57:50] Terminal.app for me [18:58:01] way to be old school preilly [18:58:31] tfinc: iterm2 ftw. [18:59:00] * tfinc shakes fist at kids these days spoiled with their color terminals. yells .. "back in my day we could count all of our terminal colors on one hand … and we were thankful for all the shades of green" [18:59:24] tfinc: Amber for me. [18:59:39] None of this fancy green stuff. [19:00:01] MaxSem: take a look at: http://zero-testing.wikipedia.wmflabs.org/xhprof_html/?run=4f70bc8f1cb81&source=mobile_frontend_extension&all=1&symbol=ExtMobileFrontend%3A%3ADOMParse [19:00:02] Apple ][C for me [19:00:10] tfinc: i've been using iTerm since i got OS X [19:00:15] *iTerm2 [19:00:55] YuviPanda is spoiled. he's growing up in the iterm2/git/github world [19:00:57] :D [19:01:15] indeed. my first open source 'patch' went into git [19:01:28] though I was using svn like git for a few years before that (local server :P) [19:01:36] MaxSem: and http://zero-testing.wikipedia.wmflabs.org/xhprof_html/?run=4f70bc8f1cb81&symbol=HtmlFormatter%3A%3AfilterContent&source=mobile_frontend_extension&all=1 [19:02:01] oh apple ][ [19:02:12] preilly, onwhich page was it recorded? [19:02:37] MaxSem: http://zero-testing.wikipedia.wmflabs.org/w/index.php/Quark [19:02:42] C64 for me. [19:02:53] MaxSem: click, "Profiler output" on the bottom of the page [19:02:58] awjr: ^^ [19:03:17] oo [19:03:24] awjr: you can now see profile information on any request to http://zero-testing.wikipedia.wmflabs.org/w/index.php/Main_Page [19:03:31] nice preilly [19:03:34] heatherw: i loved the old ][C :D [19:03:35] awjr: just click on, "Profiler output" on the bottom of the page [19:04:13] tfinc: <3 [19:04:39] I wrote my first code in the 80s. [19:04:58] MaxSem: I think http://zero-testing.wikipedia.wmflabs.org/xhprof_html/?run=4f70bc8f1cb81&symbol=DOMXPath%3A%3Aquery&source=mobile_frontend_extension&all=1 sucks! [19:04:59] <- 70s> [19:05:10] preilly, doesn't look like it's slow: this page is larger than average, I've seen up to 400ms on [[Barack Obama]] [19:05:10] Managed to miss CVS, at least. [19:05:15] this needs unicorns http://craig.is/making/rainbows [19:05:20] for all rainbows need unicorns [19:05:20] i was too busy not being born in the 80s to be able to write code [19:05:27] tfinc: kidbleach.com [19:05:38] it's not even nearly 500ms average reported on graphite [19:07:19] Amgine: I wasn't around back then. [19:07:26] MaxSem: we should import Barack_Obama to http://zero-testing.wikipedia.wmflabs.org/w/index.php/ [19:08:39] preilly, the high reported times are caused by mismatching profiler calls, see bottom of http://noc.wikimedia.org/cgi-bin/report.py?db=all&sort=real&limit=5000 "Profiling error: in(ExtMobileFrontend::DOMParse-filter), out(HtmlFormatter::filterContent)" [19:10:27] http://www.cpm.z80.de/source.html [19:11:10] MaxSem: I understand, but it's still slower than it was [19:11:49] preilly: can we see the same metric in graphite ? [19:12:58] preilly: do we have an m. for all of these http://meta.wikimedia.org/wiki/List_of_Wikipedias [19:12:59] ? [19:13:02] tfinc: vs, the "count cpu% cpu/c real% real/c" view in report.py? [19:13:51] tfinc: yes [19:14:23] hmm, can't connect to zero-testing anymore [19:14:34] MaxSem: why not? [19:14:55] preilly: just a perf graph that shows our decrease in performance post last push [19:15:04] MaxSem: do you mean by SSH "ssh -A mobile-feeds" [19:15:15] no, http [19:15:22] ssh works [19:16:20] jdlrobson: ® for EN ™for all others [19:17:10] arghh ok [19:17:16] are we gonna go for the image still for just english? [19:17:19] or text for all? [19:17:25] tfinc: https://graphite.wikimedia.org/dashboard/temporary-13 [19:17:42] preilly: can we have something better then temp-13 on these links ? [19:17:54] jdlrobson: do we have a good reason to use the image over just plain text ? [19:18:13] only sexiness as far as i'm aware :-) [19:18:31] tfinc, https://graphite.wikimedia.org/dashboard/MobileFrontend-DOMParse [19:18:39] Plaintext is sexier. [19:19:01] jeroid: +1 [19:19:22] tfinc: https://graphite.wikimedia.org/dashboard/PRETTY_STUFF [19:19:31] i must point out beauty is in the eye of the beholder jeroid and tfinc ;-) heatherw that ok with you? [19:19:43] awjr: phillippe just let me know that your otrs account is on the way [19:19:51] jdlrobson: lets mock it up and then we can make a judgement call [19:19:52] thanks for the udpate tfinc [19:19:59] sure doing so as we speak tfinc [19:20:42] * jeroid hugs MaxSem again for the plaintext APIs. [19:21:09] tfinc: just use the, "save as" option to name the share [19:21:24] preilly im not sure how useful scalpel actually is going to be :( it seems i can only search for specific file types on a block device or stdin, so searching for deleted php files gives me like bagillions of hits [19:21:52] awjr: you can pinpoint a folder [19:22:08] i find it a bit bizarre that we would be writing wikipedia in plain text at the bottom of a wikipedia page, but it is not up to me :) jdlrobson [19:22:59] preilly that doesnt seem to be giving me back any results [19:23:00] Maybe look for git metadata files? [19:24:04] * jeroid is a console jockey and mistrusts all this newfangled graphical folderol. [19:24:30] awjr: okay, try this: sudo apt-get install foremost [19:24:31] jeroid: CLI forever ! [19:24:51] granted thats why i like gmail .. beautiful blend of cli + gui [19:25:00] so they don't have to be mutually exclusive [19:25:27] * jeroid used pine for mail for years. [19:25:47] jdlrobson: after we test it with text I'm curious to see the payload difference, and if will make our lives easier for the other 282 languages [19:25:50] grr grrr, our Unicode sanitizer replaces \1\2 in output with \xfffd\xfffd [19:25:54] awjr: actually try PhotoRec [19:26:10] preilly yeah foremost looks pretty similar to scalpel [19:26:38] awjr: sudo apt-get install testdisk [19:26:38] sudo photorec [19:28:11] preilly all of these need device images, can't specify a directory [19:28:31] awjr: photorec doesn't [19:28:36] which is pretty slick but is generating way too much noise to be useful [19:30:51] * jeroid switches from 20s swing to 70s show tunes. [19:31:36] preilly yeah same thing with photorec unless im missing something [19:31:57] awjr: grep the output? [19:32:54] Or is it newfangled GUI stuff instead of good old CLI happiness? [19:33:12] jeroid the output is actually kind of meaningless as it's just file data with no other file informaiton [19:33:28] awjr: reclone? [19:33:31] i suppose i can try to remember the last things i changed in a couple of files [19:33:42] yuvipanda: trying to recover about a days worth of local commits [19:33:53] damn :| [19:33:59] awjr: can I see it [19:34:03] preilly sure [19:34:38] preilly easiest if you come over here [19:37:23] jeroid, action=parse&prop=wikitext sounds fun :) [19:37:56] MaxSem: It's quite horrible. [19:38:24] Even the HTML is more fun. [19:38:38] jeroid, I hope I will not make Redis explode if I cache extracts of every requested page in it? [19:39:20] MaxSem: You can put an expiry time on it. [19:39:33] tfinc: just a headsup. Testing with beta enabled doesn't break anything [19:39:35] I can? [19:39:40] yuvipanda: woot! [19:39:43] the copyright text is gone though :( [19:39:45] * MaxSem looks deeper into its API [19:39:59] Yes. I don't remember how offhand, though. [19:40:00] jdlrobson: we need to carve out some time to talk candidate homework AFTER the beta goes out [19:40:11] k np [19:40:14] tfinc: now testing with 1.0.3 [19:40:16] k [19:41:34] * jeroid is packing up his trombone and heading home now. Back online from not-my-phone in about 45 minutes. [19:42:50] http://jonrobson.me.uk/wikipedia/footer.html < tfinc heatherw as text [19:43:10] so tiny [19:43:18] let me pull it up on the simulator [19:44:44] hmm .. my simulator is not picking up the new changes bizarre [19:45:27] * yuvipanda goes to find an electric outlet that works [19:45:36] jdlrobson: agreed that this is nowhere near as nice [19:45:48] jdlrobson: how big is the image asset ? [19:46:42] 1946kb http://jonrobson.me.uk/wikipedia/images/logo-copyright.png - but i've not made any attempt to smush it [19:46:57] awjr: try find . -iname '*php' | xargs grep 'string' -sl [19:47:20] that should read 1.946kb [19:47:28] can get it down to 1.32 KB with http://www.smushit.com/ysmush.it/ [19:47:57] what is going to happen on devices with higher resolution? [19:48:54] jdlrobson: that is pretty tiny [19:49:45] * preilly sings Smush.it — Smush.it, really good... [19:49:45] jdlrobson: how would you want to do the rest of the 282 languages that need a ™ if we did the image for EN ? [19:50:25] wow preilly … way to throw it back to salt-n-pepa [19:50:30] at moment nothing heatherw [19:50:40] tfinc currently Wikipedia is a translateable string and $wgLanguageCode === 'en' ? '®': '™', [19:50:46] gets the correct TM [19:51:13] i can either do an if en img tag if not text [19:51:43] i designed it tiny http://www.mediawiki.org/wiki/Mobile_design/Footer_and_Sections don't blame jdlrobson ;D [19:52:02] OR we can construct a url to the image e.g. footer_logo_en.png [19:52:04] which redirects on a 404 (not sure how we would do that yet but guessing via htaccess) [19:52:14] and feel free to make it bigger, of course [19:52:21] * preilly — can't decide if he's feeling more like DJ Spinderella or Pepa today [19:52:27] although im not sure what it would redirect to [19:52:53] * jdlrobson will brb [19:56:56] heatherw: i meant it looks tiny and not as nice in text as it does in the image [19:57:15] :) [19:57:44] tfinc: 1.0.3 looks good. copyright text missing, otherwise works [19:58:00] tfinc: should be able to work with jdlrobson to get that back in before beta goes to 'native' [19:58:05] yuvipanda: k [19:58:15] should i file a bug? [19:58:18] hmm [19:58:18] yes please [19:58:22] okay [20:10:47] tfinc: so are we okay with having text for non-english version? [20:11:11] yes. mock it up so that i can see it [20:17:33] preilly i managed to recoup a few of the changes but not all, but it's enough that i should be able to reconstruct what's missing pretty quickly. thanks for your help [20:18:31] well the non-english version will look like this: jonrobson.me.uk/wikipedia/footer.html and the english will look like jonrobson.me.uk/wikipedia/footer2.html tfinc [20:20:56] awjr: np [20:21:48] jdlrobson: werd [20:21:54] werd? [20:22:02] jdlrobson: like werd, G [20:22:16] it's 'merican for 'word' [20:22:30] rapper speak? [20:22:34] jdlrobson: an endorsement; "to go ahead" [20:22:58] well, to be fair I told you guys that I can't decide if I'm DJ Spinderella or Pepa today! [20:23:40] * preilly — should have probably just said, "Booyakasha" to keep it real for jdlrobson  [20:23:52] jdlrobson: thats fine [20:23:54] for the beta [20:24:01] k im pushing [20:29:28] really hard? [20:30:37] * tfinc hands preilly an early 90's pamphlet  [20:30:57] ha ha [20:31:18] jdlrobson: any reason that you use http://jonrobson.me.uk instead of a VM for these tests? [20:32:07] just convenience for the time being preilly... im assuming i can somehow push a git local branch and access on mobile-geo.wmflabs but i've not had the time to work out how yet [20:32:40] jdlrobson: okay, makes sense for now [20:32:45] jdlrobson: I was just curious [20:33:01] jdlrobson: as a shared host might make it easier for other to tinker too [20:33:09] * jdlrobson nods [20:34:15] my git review has gone weird [20:34:22] Errors running git rebase -i remotes/gerrit/master [20:34:22] Interactive rebase already started [20:34:27] jdlrobson: in what way? [20:34:40] jdlrobson: oh, that's easy to fix [20:35:08] jdlrobson: try a git rebase --abort [20:35:13] jdlrobson: and try again [20:35:51] jerith, what's wrong here: http://dpaste.com/721698/ ? [20:36:50] MaxSem: This error is telling you that when you use a yield inside of a function making it a generator, you can only use return with no arguments. [20:37:03] ok that's weird [20:37:04] (missing Change-Id in commit message) [20:37:37] * jdlrobson hopes that worked [20:38:09] jdlrobson: it worked https://gerrit.wikimedia.org/r/#change,3757 [20:38:31] * jerith returns. [20:39:02] MaxSem: Ah, right. inlineCallbacks and generators and stuff. [20:39:26] * jdlrobson dons asbestos suit to enter perfecto mobile land [20:40:08] MaxSem: Short answer: You can use "returnValue(extract)" to return a value from an @inlineCallbacks-decorated function. [20:40:22] thanks [20:40:56] jerith: seems dirty [20:41:09] preilly: It's a nasty hack. :-/ [20:41:09] jdlrobson: ha ha [20:41:34] jerith: wouldn't a yield be better? [20:42:06] preilly: returnValue() actually throws an exception under the hood and the decorator catches it and extracts the value. [20:42:42] It's already using yield to handle async breakpoints. [20:43:16] jerith: ah, okay — so, this is Twisted [20:43:21] MaxSem: Long answer: Read all about deferreds at http://twistedmatrix.com/documents/current/core/howto/defer.html [20:44:43] preilly: @inlineCallbacks is a horrible abuse of generators to write event-driven async code in a way that looks more like traditional blocking code. [20:46:03] jerith: but, that's mostly a Twisted'ism right? [20:46:12] Yes. [20:48:05] What happens is that inlineCallbacks calls the generator which runs until it yields. The yielded value is wrapped in a deferred (if it isn't already a deferred, which it usually is) and the wrapper adds itself to the deferred as a callback. [20:48:40] * preilly — New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3757 [20:48:40] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3757 [20:49:05] When the callback fires (with the result of an async HTTP call, for example), the value is shoved back into the generator for the next iteration. [20:49:39] ugh [20:49:49] I don't miss Twisted [20:49:57] but, I do love it (just a little) [20:51:18] I really like Twisted, but you have to bend your brain into funny shapes to grok it. [20:53:24] is all that fun due to Python's lack of multithreading? [20:53:36] Python has multithreading. [20:54:05] Twisted's async event-driven model is better for a lot of stff. [20:54:09] *stuff [20:55:08] It's basically just a different concurrency model. [20:55:24] Cooperative multitasking rather than preemptive multitasking. [20:57:38] MaxSem: What Python can't do is take advantage of multiple cores. (Unless you write C extensions that release the global interpreter lock, but then you get to keep all the pieces when stuff breaks.) [21:00:01] jerith: have you ever played with Python's multiprocessing module [21:00:36] preilly: Not really. I've never needed to. [21:01:00] jerith: I was just curious [21:01:45] I'm almost always I/O bound in my Python code, so multiprocess stuff is seldom useful. [21:02:28] (The times when I'm not I/O bound, the problem generally doesn't lend itself well to being split up into parallel tasks. [21:02:28] MaxSem: you can take a look at http://wiki.python.org/moin/ParallelProcessing for examples [21:02:48] jerith: yeah, I hear you [21:03:01] eww, unholy MoinMoin [21:03:02] ) [21:03:20] MoinMoin used to make me sad. Then I stopped using it. [21:03:32] It has decidedly poor spam management tools. [21:06:09] ha [21:08:54] hey gents. how are we looking for our beta deployment ? [21:09:19] awjr: any news on the persistent cookies issues ? [21:10:15] tfinc no news yet - just got an email from otrs saying my account's been set up but i've been dealing with losing my git repos and am now starting to prep for deployment [21:11:00] k [21:11:09] jerith, why do you show only top-level sections? they could be huge [21:12:28] tfinc: btw i never received credentials for the wordpress blog site [21:12:30] was i meant to? [21:12:58] jdlrobson: http://blog.wikimedia.org/wp-admin/ [21:13:01] you can just register [21:13:09] MaxSem: I didn't have a good way short of lots of nested subsection menus to dive into subsections. [21:13:18] turns out you only need an admin to gain extra privileges [21:13:48] MaxSem: Also, having played with the app, I don't think displaying section extracts is that useful. [21:14:23] The first paragraph of an article is usually a summary. The first paragraph of a section usually isn't. [21:14:47] grrr [21:14:58] k im registered tfinc but obviously can't add posts [21:15:07] I don't fully understand how it currently works, then [21:15:16] (until i get the admin stuff) [21:15:17] jdlrobson: can you even write a post? [21:15:39] nope tfinc [21:15:52] are you using jdlrobson as your username ? [21:15:55] yes [21:15:56] jerith, how can I play around with what's currently installed on Labs? [21:15:57] i'd be worried if i could (since all i did was register) :) [21:15:59] MaxSem: The first incoming message is a session start. That triggers the "what would you like to search for?" messgae. [21:16:24] MaxSem: Let me update and restart the labs installation quick. [21:16:53] are you using jdlrobson as your username ? [21:16:59] yes tfinc [21:17:01] k [21:17:14] * MaxSem fears that this interface will be usable only by programmers:) [21:17:39] MaxSem: It's definitely usable by muggles as well. [21:18:23] :) [21:18:48] MaxSem, jdlrobson, preilly: i dont see any changes listed on the deployment page - please add your updaets: http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments#26_March.2C_2012 [21:18:59] * jdlrobson nods [21:18:59] MaxSem: I've seen non-programmers use it very successfully over USSD. It's more confusing over gtalk, though. [21:19:49] awjr, mine are changes not user-visible, should I list them too? [21:20:16] MaxSem yes please [21:20:36] jdlrobson: you now have perms to edit/publish your own blog posts on tech blog [21:21:14] * jdlrobson gives tfinc a thumbs up and gets going with a draft [21:21:46] thank RobH.. i was wrangling him to do it [21:21:47] :D [21:22:08] jdlrobson: remember NO British English [21:22:20] hehe [21:22:25] flavour [21:22:28] NEVER! there will be photos of me drinking tea as well! [21:22:32] ROFL [21:22:33] yay! [21:23:34] * jdlrobson jots down an idea for this years fundraiser - pictures of me drinking tea at the top of wikipedia pages [21:24:04] jdlrobson: please see the third row in this table — http://en.wikipedia.org/wiki/American_and_British_English_spelling_differences#Different_spellings_for_different_pronunciations [21:24:49] "though understood by some." [21:25:09] heh heh heh [21:25:49] hi, I would like to configure gu.m.wikipedia.org homepage [21:26:02] preilly: this language is poppycock i tell ye! [21:26:23] can someone tell me where to do so? sorry to ask this nut question [21:28:05] Dhaval: http://gu.wikipedia.org/wiki/%E0%AA%9A%E0%AA%B0%E0%AB%8D%E0%AA%9A%E0%AA%BE:%E0%AA%AE%E0%AB%81%E0%AA%96%E0%AA%AA%E0%AB%83%E0%AA%B7%E0%AB%8D%E0%AA%A0#Mobile_homepage_--_changes_required. [21:28:22] preilly: why don't we add a blurb to any un configured mobile page [21:28:25] Dhaval: see http://meta.wikimedia.org/wiki/Mobile_Projects/Mobile_Gateway#Mobile_homepage [21:28:28] please go "here" to find out how to adda new plage [21:28:31] page* [21:28:33] * jdlrobson goes to get a cup of tea [21:28:50] * preilly dumps the tea in the ocean  [21:28:52] * tfinc prepares to throw jdlrobson tea into the bay [21:29:02] too soon ? [21:29:04] ;) [21:29:09] * jerith suddenly remembers his beer. [21:29:12] NEVER [21:29:13] I m dumb, been on there (here) a few times, but couldn't find where to go from there [21:29:16] NEVER FORGET! [21:29:23] hah [21:29:28] OMG [21:29:51] seriously though .. preilly how about we add a blurb to an empty main page… "Please read blah blah" to add a main page [21:30:07] that way great users like Dhaval don't have to hope to find us in here :D [21:30:17] preilly: how hard is it to detect that? [21:30:46] tfinc: not too hard [21:30:47] u r absolutely right tfinc [21:31:05] MaxSem: I've restarted the labs setup. "wikipediavumi" for USSD, "wikipediavumites" for SMS. [21:31:05] adding a bug now [21:31:22] tfinc: jdlrobson could even do it in Javascript as well [21:31:47] tfinc: well, if he wasn't drinking tea that is... [21:32:11] https://bugzilla.wikimedia.org/show_bug.cgi?id=35507 [21:32:36] tfinc: Display please configure main page message if non found [21:32:44] s/non/none [21:33:00] i have my tea [21:33:17] preilly: you guys were serious [21:33:39] I am completely non-technical person, so u hv full right to laugh on me [21:34:07] Dhaval: its an important feature to add [21:34:08] we don [21:34:09] t [21:34:17] we don't want to be a bottle neck for this [21:34:20] Dhaval: I would never laugh at you [21:34:27] all it has to be is a one liner pointing to our docs [21:34:29] pretty easy [21:34:53] * jerith never laughs at people who are trying to do the right thing. [21:35:57] jerith: nor, do I [21:36:04] preilly tfinc we want this in for this beta? [21:36:11] jerith: unless, of course they are British and drinking tea [21:37:06] jdlrobson: no need to rush it for the beta [21:37:09] jdlrobson: well, it would be a pretty easy change if done in JS [21:37:10] we can pick it up next week [21:37:46] preilly: What about colonials sipping gin and tonics on the verandah? [21:38:01] jerith: that's totally fine [21:38:24] if(document.getElementById("content").childNodes.length === 0) { document.getElementById('content').innerHTML = 'Please configure this homepage';} [21:38:44] jdlrobson: plus translation of course [21:38:47] * jerith sadly lacks both gin and tonic, but has a verandah and is situated in the Colonies. [21:38:48] of course [21:39:01] also.. does there need to be a check that it is indeed on the homepage [21:39:06] can any other page ever be empty? [21:39:42] jerith: do I count as being in the Colonies too? [21:39:55] jdlrobson: well, you could check if it's the main page [21:40:04] yuvipanda: Are you in India? [21:40:08] jerith: yup [21:40:16] If so, definitely the Colonies. [21:40:21] o/ [21:40:36] * preilly is pretty yuvipanda has never actually been to India  [21:40:49] s/pretty/pretty sure that/ [21:41:06] I've the ID Card from my college as proof :P [21:41:32] ok guys, bye [21:41:33] that is totally photographic proof of me being here when i was 17 [21:42:03] preilly: can you quickly dbl check this looks sane - https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114497s [21:42:04] er [21:42:05] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114497 [21:42:13] Dhaval: bye [21:42:16] Wild beasts roaming the streets, exciting tropical diseases that must be fended off with medicated booze, etc. [21:42:55] being british, I must rush to my Kettle [21:43:15] for a tea [21:43:18] awjr: are you missing a delete [21:43:21] Dhaval: ha ha [21:43:34] * awjr checks [21:44:01] preilly: ah 'library'? [21:44:13] awjr: MobileFrontend/library [21:44:20] yah [21:44:22] thanks [21:44:50] awjr: also, missing minified JS right? [21:46:28] preilly: what's currently in the deployment branch matches what's at head in git [21:46:45] so i presume js hasn't been minified in git [21:46:46] ? [21:47:24] awjr: yeah, that's correct [21:47:35] awjr: that's usually a deployment only step [21:47:36] preilly: so i just need to minify beta_opensearch.js and references.js? [21:47:45] awjr: as, otherwise jdlrobson would have to do it all the time [21:48:04] awjr: yeaper [21:48:05] awjr: you need me to do that now? [21:48:15] jdlrobson it's ok i can take care of it [21:48:20] * jdlrobson nods [21:50:56] awjr, jdlrobson, MaxSem, tfinc: Does it make sense to put the beta opt-in link on this page: http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments#26_March.2C_2012 [21:51:05] sure [21:51:23] sure. but the link that we really need is the one in the nav that linSmith is working on [21:51:24] tfinc: do we have a new one that works? [21:51:39] is this page actively watched by users? [21:51:44] http://bit.ly/wmoptin [21:51:51] MaxSem: nope [21:52:06] which is why i saw that no link will be that good until we have our new nav [21:52:17] MaxSem i link to it in deployment logs [21:52:25] preilly: https://gerrit.wikimedia.org/r/#change,3770 [21:52:27] tfinc: oh, so the blog has http://bit.ly/woptin [21:52:37] tfinc: should that be fixed? [21:53:21] my link gives them a disclaimer and it takes them to the mobile site [21:53:30] i think it works fine [21:53:57] tfinc: the blog links to this: http://bit.ly/woptin [21:54:03] tfinc: which is broken [21:54:10] preilly: yes. that is the old link .. way old [21:54:23] tfinc: but, that is on the blog post [21:54:33] tfinc: so, I was asking if the blog post should be updated [21:54:37] sure [21:54:43] do you have access / [21:54:43] ? [21:54:51] if not whats the blog post title [21:55:25] tfinc: http://blog.wikimedia.org/2011/10/27/wikimedia-mobile-opt-in-beta/ [21:56:52] awjr: Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3770 [21:57:13] preilly: updated [21:57:29] tfinc: thanks! [21:57:38] preilly thanks [21:57:55] tfinc: I was only worried as it's a top Google result for beta Wikipedia mobile [21:58:02] preilly: good point [21:59:38] preilly: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114500 [22:00:27] awjr: need to update version numbers as well [22:00:40] preilly: that's config now [22:00:41] awjr: but, that should probably happen after the initial SCAP [22:00:44] which link should i be using? [22:00:46] new blog post links to http://bit.ly/GGzDVv [22:00:52] preilly: yeah [22:01:00] * tfinc is a little taken a back that yuvipanda is not chatting. wonders if yuvipanda is actually sleeping while the sun is down [22:01:11] yeah, like that's happening [22:01:16] haha [22:01:18] thought so [22:01:18] lulz [22:01:42] phrasing [22:02:08] * preilly — watches http://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=4&ved=0CFAQtwIwAw&url=http%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DVS4QGEQaclk&ei=UOdwT7KcHOWhiQLO75nQDA&usg=AFQjCNFd7I_m_l6cyEw52q8am28fQ4A9Bw&sig2=Lm6rwcms_9X4sCyUknvPNg [22:02:09] timing [22:02:12] alt tabbing between the facebook fix, blog post and reproing some of the things on meta [22:03:33] and occassionally making fun of Ironholds. [22:03:55] oo im getting a fatal locally with 1.19wmf1 [22:04:01] Fatal error: Call to undefined method Language::fetchLanguageName() in /home/awjrichards/Dev/wikimedia_git/extensions/MobileFrontend/MobileFrontend.body.php on line 275 Call Stack: 0.0002 645264 1. {main}() /home/awjrichards/Dev/1.19wmf1/index.php:0 0.0589 13976872 2. MediaWiki->run() /home/awjrichards/Dev/1.19wmf1/index.php:58 0.0590 13976872 3. MediaWiki->main() /home/awjrichards/Dev/1.19wmf1/includes/Wiki.php:503 0.1757 29906472 4. MediaWiki [22:06:40] awjr: that's in 1.20, use fetchLanguageName() [22:06:51] ouch [22:07:00] awjr: it's Language::getLanguageName [22:07:12] in 1.19 [22:09:22] * jerith goes to sleep now. [22:09:36] night jerith [22:09:58] MaxSem: I'll be up in about 9 hours to start my workday. You can leave messages for me here if you need anything. [22:11:36] MaxSem: Oh, one other thing. I see you're using pickle in that snippet you pastebinned earlier. It's probably better to serialise to JSON instead. [22:11:42] G'night all. [22:19:17] awjr: are you changing that call? [22:19:22] preilly yep [22:24:27] preilly: https://gerrit.wikimedia.org/r/3772 [22:26:07] awjr: that was a Max Semenik bug [22:27:14] awjr: you are missing a space in if ( method_exists( "Language", "fetchLanguageName" )) { [22:27:27] awjr: also, should that be single quotes [22:28:08] eh single quotes? does it matter? [22:28:23] preilly: single quotes here: method_exists( "Language", "fetchLanguageName" ? [22:29:16] it wont make a difference - is that something in our code conventions? i generally use whichever without giving it much thought unless i need variable expansion [22:31:23] preilly i amended the patchset [22:31:53] awjr: also, why not use is_callable? [22:32:11] preilly that works to - is that preferable in this case? [22:32:47] awjr: well, I'm fine with this usage [22:33:05] awjr: it's just that it would return TRUE if it was private and not actually callable [22:33:53] preilly: good point [22:33:53] awjr: do we typically use single quotes in this sort of case? [22:34:14] preilly: i don't know, it's not mentioend in the conventions. i dont typically think about it [22:35:57] awjr: well, you only use double quotes if you want to use string interpolation (with variables, math, etc.) [22:36:29] awjr: single quote are generally faster, and everything quoted inside treated as just plain string... [22:36:32] awjr: but, BLAH [22:36:57] preilly wow i never gave it that much thought and generally use " and ' interchangably except when i want the string interpolation [22:37:01] Semantic history in iterm2 … awesome ... [22:37:32] tfinc iterm2 is my hero but iirc preilly disagrees [22:37:42] it's about a 15µs difference [22:38:12] preilly ok ok ok [22:38:16] i amended the change set again [22:38:19] awjr: maybe I've just NOT seen the light yet [22:39:08] * preilly Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3772 [22:39:11] far out [22:39:47] i like that you can amend changesets [22:40:48] awjr: yeah, much better than the old code review in that regard for sure [22:42:26] aww what happened to svn.wikimedia.org/doc [22:44:09] awjr: well, it's on trunk(r114481) [22:45:02] awjr: what is wrong with it? [22:45:25] oh whoa i was getting a 404 a minute ago [22:45:57] hmm [22:46:00] that's weird [22:46:41] preilly: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114502 [22:46:45] im going to push things out to test now [22:47:52] jdlrobson, preilly: changes live on test.wikipedia.org [22:47:58] cool cool cool [22:48:08] oh i need to update the version # one sec [22:49:51] ok jdlrobson should be good now [22:50:18] mm [22:50:23] Our servers are currently experiencing a technical problem. This is probably temporary and should be fixed soon. Please try again in a few minutes. [22:50:24] oops getting a fatal [22:50:30] PHP fatal error in /home/wikipedia/common/php-1.19/extensions/MobileFrontend/MobileFrontend.body.php line 300: [22:50:30] Class 'Lanuage' not found [22:50:36] typo [22:50:38] one sec [22:52:15] jdlrobson: https://gerrit.wikimedia.org/r/3774 [22:52:58] i cant seem to code review :( [22:53:09] blech [22:53:14] ok well i'll just push it. [22:53:40] assuming you dont see anything horribly wrong with my 1 char fix :p [22:54:52] ok jdlrobson, fixed [22:54:53] nope looked fine to me [22:54:57] and deployed to test? [22:55:05] aye [22:56:41] it is horrible that i'm spending this much time on tiny things :| [22:56:43] goddamn phonegap [22:56:51] i wonder if i can refresh the language cache just on test [22:58:09] jdlrobson the footer looks totally whack on test but i think it's because of language cache + some funky configuraiton [22:58:29] yeh that's weird [22:58:39] and the image is missing [22:59:06] is there an logo-copyright-en.png in stylesheets/images/ ? [22:59:24] * awjr checks [22:59:42] jdlrobson: no [22:59:53] mm [22:59:56] i might have missed it in the merge to deployment [22:59:57] something weird going on [23:00:19] jdlrobson yeah i missed it [23:03:45] jdlrobson: try now [23:04:09] yeh got the logo now but still getting the language weirdness [23:04:26] yeah i cant figure out how to update language cache only on test [23:04:37] i have no idea i'm afraid [23:05:53] sign post just came out [23:05:57] http://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/2012-03-26/Technology_report [23:06:01] and it mentions our beta :D [23:06:04] jdlrobson are you seeing anything aside from not having messages in the footer? [23:06:08] Jarry1250: [23:06:14] no awjr [23:06:14] now were on the hook for getting this out [23:06:24] hows the deployment going ? [23:06:25] but i have been distracted by the footer [23:07:05] tfinc: so far so good, some minor issues that i think are sorted now [23:07:13] awjr: k [23:07:21] im trying to figure out how i can update the language cache *just* on test so we can make sure the footer is totally right [23:07:25] are we still merging in prep to deploy ? [23:08:04] tfinc: Yeah, sorry about that :P [23:08:11] Jarry1250: no need [23:08:35] you gave us a "going live to beta users imminently" [23:08:43] thanks for that [23:09:07] tfinc no we're testing on test.wikipedia.org [23:09:11] nice [23:10:52] jdlrobson there is apparently no sane way to refresh the message cache on test without doing it everywhere [23:11:14] but it looks/works correctly locally [23:11:40] jdlrobson if you dont see any other issues i'm going to scap [23:11:54] * tfinc preps the deployment drums  [23:11:56] awjr the only other thing i notice is the footer looks borked if there are not 4 links (e.g. test does not have a privacy or about link) [23:12:07] we can probably live with this? [23:12:10] jdlrobson: it's because of the message cache [23:12:13] ok [23:12:29] so it should be OK [23:13:39] ok lets do this [23:14:03] http://blog.wikimedia.org/wp-admin/post.php?post=11190&action=edit&message=10 tfinc this is prepped [23:14:19] jdlrobson: line up the images [23:14:24] jdlrobson: scapping [23:14:28] it looks crapping on my desktop [23:14:33] crappy* [23:14:45] and feel free to change the title [23:14:55] we might want to change Wikimedia to Wikipedia [23:15:18] add some categories [23:15:20] and tags [23:15:23] jdlrobson: --^ [23:15:29] yep [23:15:33] trying to line up at the moment [23:16:21] i do love how our screenshot is of kermit [23:17:34] tfinc: is there an easy way to get two screen shots side by side? [23:17:45] jdlrobson the scap is not complete but it finished updating the message cache so the footer looks right on test now :) [23:17:49] i did it by switching in html mode [23:17:57] and just doing it by hand [23:21:31] looks good to me awjr [23:24:39] * tfinc watches his machine start to compile perl and dies a little  [23:25:14] any better tfinc [23:25:18] checking [23:25:22] http://blog.wikimedia.org/?p=11190&preview=true [23:25:44] probably need to increase the width of the images? [23:25:46] why have the space between them ? [23:26:41] try now [23:26:58] [WikipediaMobile] yuvipanda pushed 2 new commits to master: http://git.io/0ImrZA [23:26:58] [WikipediaMobile/master] Fix login behavior for Facebook sharing - YuviPanda [23:26:58] [WikipediaMobile/master] Removed my name from the AUTHORS list - YuviPanda [23:27:24] Project WikipediaMobile - Nightly builds build #259: SUCCESS in 13 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/259/ [23:27:25] * yuvipanda: Fix login behavior for Facebook sharing [23:27:25] * yuvipanda: Removed my name from the AUTHORS list [23:27:57] jdlrobson: center them [23:30:13] tfinc: just trying to work what magic is needed in wordpress to do that :) [23:30:29] jdlrobson: screw wp magic. just do it by hand in html :D [23:30:42] that's what im doing but its a mix of wordpress wikitext and html [23:32:01] jdlrobson, preilly, tfinc: scap complete [23:32:08] awjr: woot! [23:32:11] * tfinc goes to test [23:32:32] * jdlrobson thinks hes got it [23:33:14] awjr: thanks, for SCAPing [23:33:41] * jdlrobson did have it but saving resets all the css hes [23:33:42] added [23:33:52] preilly my pleasure [23:33:59] things are looking good for me so far in and out of beta [23:34:03] the beta is sexy [23:34:19] * tfinc curses his nexus s native browser [23:34:48] i can't actually tap the more until the magnifying +/- from the native browser go away [23:34:49] stupid browser [23:35:06] in other news .. htop on osx ftw [23:35:37] can contact/privacy/about be bigger? [23:36:13] jdlrobson: what causes full screen search to turn the text from black to gray ? [23:36:18] i'm seeing it flicker as i type [23:36:22] ajax searches [23:36:23] and does "more" have to be blue? [23:37:09] lets increase the size of the text in the footer links [23:37:11] we have the space [23:37:54] lets resize the input boxes following the contact us link [23:37:57] their super tiny [23:38:41] tfinc: in the future should we get stylistic review and signoff of changes before we push for deployment? [23:39:05] awjr: so the problem with that is that i need to test it on real content [23:39:20] we really need a better testing infrastructure [23:39:35] i see the designs, see jons design, but it isn't until i see it against real prod [23:39:38] that i notice everything [23:40:00] preilly: why do i fall out of beta mode when i tap contact in the footer ? [23:40:16] tfinc yeah, but that's a bummer. we ahve the same problem with significant changes for i18n messages [23:40:48] awjr: agreed [23:41:03] labs+replicated db == win [23:41:07] thats what we need [23:41:15] anything else is a waste of time [23:41:56] i must confess i didn't pay much attention to the contact page due to the pending contact form changes [23:42:06] jdlrobson: it happens [23:42:11] so two issues there [23:42:18] 1) size of input box - this should be easy to fix [23:42:18] Text is available under the Creative Commons Attribution-ShareAlike License; additional terms may apply. See Terms of use for details. [23:42:18] Wikipedia® is a registered trademark of the Wikimedia Foundation, Inc., a non-profit organization. [23:42:19] Contact us [23:42:24] is missing from the main page [23:42:31] 2) issue with dropping out of the beta [23:42:35] causing Nagios to freak out [23:43:01] preilly could that be a cahing issue? i see the footer here: http://en.m.wikipedia.org/wiki/Challenger_Deep [23:43:21] jdlrobson: the blog post needs an update [23:43:24] we moved the desktop view link [23:43:27] and need to tell people [23:43:36] awjr: nope [23:43:36] k k and k [23:43:40] :D [23:43:42] awjr: it's not on the main page at all [23:45:33] tfinc: im not sure why it jumps out of the beta on the contact page [23:46:23] preilly can help you with that [23:46:26] awjr: do you see the issue? [23:46:33] preilly not yet still following the code [23:46:40] awjr: okay [23:46:41] i havent messed with main page stuff before [23:47:47] omg, we've got performance un-regression! :P https://graphite.wikimedia.org/render?width=500&from=-1hours&until=now&height=380&target=ExtMobileFrontend.DOMParse.tavg&uniq=0.3153700059067407&title=ExtMobileFrontend.DOMParse.tavg [23:48:17] mwhaha [23:48:26] awjr: [Mon Mar 26 16:48:13 2012] [error] [client 192.168.63.1] PHP Notice: Undefined index: mobile-frontend-footer-copyright in /home/preilly/core/extensions/MobileFrontend/templates/FooterTemplate.php on line 12 [23:48:48] well that could do it. [23:48:59] MaxSem: still a bit hi [23:49:01] high [23:49:56] preilly, https://graphite.wikimedia.org/render?width=500&from=-2weeks&until=now&height=380&target=ExtMobileFrontend.DOMParse.tavg&uniq=0.13666253972694042&title=ExtMobileFrontend.DOMParse.tavg [23:50:25] what changes went out today to drop that graph ? [23:50:29] it might be slower than before, but just a tiny bit [23:50:45] tfinc, profiling fixed [23:50:57] MaxSem: it hurts preilly sensibilities to ever see the graph go up [23:51:11] so we were just measuring incorrectly [23:51:50] tfinc: well, sort of [23:51:57] tfinc: it's still higher than it was before [23:52:19] right but the large increase was due to incorrect profiling [23:52:23] tfinc: but, not terribly [23:52:24] the small increase is TBD [23:52:27] right [23:52:42] jdlrobson: don't use Usability initiative [23:52:45] tfinc: but, yeah — your understanding is basically correct [23:52:50] * jdlrobson nods [23:52:51] why thank you preilly [23:52:52] :D [23:52:58] tfinc: ha ha [23:54:23] jdlrobson: what's up with: 4ff6fa4e templates/FooterTemplate.php (Jon Robson 2012-03-26 21:25:50 +0100 12) $copyright = $this->data['messages']['mobile-frontend-footer-copyright']; [23:54:37] * MaxSem falls asleep confident that he'll have nightmares with asynchronous pythons in them [23:54:45] MaxSem: seeya [23:54:56] what about it preilly ? [23:55:10] MaxSem: Twisted inlineCallbacks and deferredGenerator dreams are the worst [23:55:17] MaxSem: at least they won't be blocking [23:55:29] it's for the non-beta [23:55:39] jdlrobson: [Mon Mar 26 16:51:10 2012] [error] [client 192.168.63.1] PHP Notice: Undefined index: mobile-frontend-footer-copyright in /core/extensions/MobileFrontend/templates/FooterTemplate.php on line 12 [23:56:01] mm it should be undefined [23:56:35] Reedy: ha ha [23:57:26] jdlrobson: what? [23:57:46] i don't know im confused preilly [23:57:57] i think that used to point to $skin->getCopyright() [23:57:58] this is wacky. [23:58:11] it should __not__ be undefined [23:58:16] sorry was missing a keyword there [23:58:18] jdlrobson: yeah, it did [23:58:27] how do i do git blame here [23:58:27] jdlrobson: I still parsed it sort of [23:58:47] git blame templates/FooterTemplate.php | grep mobile-frontend-footer-copyright