[00:00:50] preilly i think that line can be replaced with $copyright = $skin->getCopyright(); [00:00:52] just double checking [00:00:54] awjr: so, self::$messages['mobile-frontend-copyright'] = $copyright; [00:01:18] awjr: line 252 of MobileFrontend.body.php [00:01:58] awjr: should probably be mobile-frontend-footer-copyright right? [00:02:13] oh i see [00:02:46] awjr: that seems to fix it for me [00:02:58] preilly i dont think so, i think we should actually change how that happens. cramming that into $messages is confusing since that's not actually an i18n message [00:03:03] sp $copyright = $this->data['messages']['mobile-frontend-copyright']; shuld do it [00:03:37] but for the sake of the fix.. [00:03:48] awjr: well, we can argue that later [00:03:53] yeah for srue [00:06:35] preilly: https://gerrit.wikimedia.org/r/3779 [00:06:36] jdlrobson: so, what's the other issue? [00:06:41] sorry got lost in git-land there for a second [00:06:52] the contact form - when you click contact in the form it jumps out of beta [00:07:24] * preilly — Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3779 [00:08:32] we have gerrit in channel notifications !?! [00:08:43] or did you just paste the tin ? [00:08:47] that in* [00:08:50] preilly: --^ [00:08:51] tfinc: I'm working on it [00:08:54] nice [00:09:12] preilly jdlrobson, footer fix pushed [00:09:19] +1 [00:09:43] preilly i think we need to flush varnish cache though for it to be picked up universally [00:09:54] awjr: ask maplebed to do it [00:10:05] awjr: he should be able to DSH it [00:10:13] maplebed: would you mind flushing the varnish cache for us? [00:10:15] is this still for the nagios alert? [00:10:16] i wait for the day where we can deploy and not have to flush the varnish cache [00:10:24] maplebed: it should resolve it [00:11:26] jdlrobson: so, http://en.wikipedia.org/w/index.php?title=Main_Page&mobileaction=leave_feedback is non beta? [00:12:03] I just got a page that m. is recovered. [00:12:08] do you still want me to clear the cache? [00:12:13] yes [00:12:13] maplebed please [00:12:21] preilly and it shouldn't be... [00:12:58] maplebed: you don't need to do it [00:13:11] preilly: the footer is not always showing up [00:13:17] presumably because of the cache [00:13:19] awjr: really? [00:13:22] truly [00:13:26] maplebed: okay, do it [00:13:29] maplebed: sorry [00:14:21] jdlrobson: okay, I know why [00:14:45] cool [00:15:13] preilly: awjr: http://chzgifs.files.wordpress.com/2012/03/funny-gifs-toilet-foode.gif [00:15:23] \o/ [00:15:28] jdlrobson: renderLeaveFeedbackXHTML happens before the call to checkUserStatus [00:15:30] thanks maplebed [00:15:32] * awjr goes to vomit [00:15:41] can you fix that? [00:15:43] (I shoulda used a shortner. ::sigh::) [00:15:52] i can push the rest of the changes tfinc requested [00:15:55] they are sitting locally [00:15:56] jdlrobson: so, self::$isBetaGroupMember = true; doesn't get set until after [00:16:13] is that an easy fix? [00:19:33] jdlrobson, preilly: looking at the code it should not be a problem to move the checkUserStatus call to happen earlier [00:19:44] great [00:19:52] preilly unless there's something im missing? [00:20:01] awjr: I was in the middle of doing it [00:20:08] preilly carry on [00:20:09] awjr: are you doing it instead? [00:20:22] no [00:20:31] * jdlrobson pushed a patch set [00:20:39] but didnt see you respond to jdlrobson so thought you might not've seen it go by [00:20:49] tfinc > http://mobile-geo.wmflabs.org/w/index.php?title=Main_Page&useformat=mobile&mobileaction=leave_feedback [00:21:29] awjr: https://gerrit.wikimedia.org/r/#patch,sidebyside,3785,1,MobileFrontend.body.php [00:21:50] oowpps 1 sec tfinc thats not up to date [00:22:15] awjr, jdlrobson: can you review https://gerrit.wikimedia.org/r/#change,3785 [00:22:50] awjr: also, after that is merged can you cherry-pick to the deployment branch [00:23:24] so preilly i cant review [00:23:26] but i can look [00:23:32] preilly reviewed [00:23:34] and merged [00:23:35] tfinc now check http://mobile-geo.wmflabs.org/w/index.php?title=Main_Page&useformat=mobile&mobileaction=leave_feedback [00:24:31] checking [00:24:37] is the beta_common.css supposed to go out now as well preilly? [00:25:07] jdlrobson: ^^ [00:25:15] yes [00:25:24] jdlrobson: should he width be fixed ? [00:25:34] no tfinc i just noticed that [00:25:37] i can fix quickly [00:25:37] for beta AND non beta ? [00:25:39] k [00:26:16] jdlrobson: why don't we make the whole footer tappable [00:26:28] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3785 [00:26:29] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3782 [00:26:30] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3785 [00:26:32] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3782 [00:26:33] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3783 [00:26:34] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3783 [00:26:35] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3784 [00:26:36] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3784 [00:26:49] tfinc: it would require a rewrite of the toggle code which im not ready to do yet [00:28:18] jdlrobson, preilly: changes live on test wiki [00:28:48] awjr: https://gerrit.wikimedia.org/r/3788 there was this too [00:28:51] contact looks good now [00:29:19] on test awjr? [00:29:27] i cant see new beta_common.css changes [00:29:31] jdlrobson yes but missing that last change [00:29:52] * preilly New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3788 [00:29:52] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3788 [00:30:58] preilly: has anything been done/discussed regarding project-specific js in frontend? [00:31:39] Amgine: not yet but we are working on it in the near future [00:31:55] Amgine: as we know that it's needed for sure [00:32:52] Thanks. I believe the current wtMobile will have no translations, which makes it rather less than useful compared to other dictionary apps. [00:32:52] jdlrobson try now [00:33:17] * preilly thinks the jdlrobson is pretty damn responsive for it being 1:32am Tuesday (BST) in London [00:33:22] looks good to me [00:33:41] ok gonna push [00:34:04] preilly: it's all in the tea [00:34:19] no wonder they charges us extra taxes for it [00:34:20] :D [00:35:24] yuvipanda: any 1.03/1.1 regressions as a result of todays beta? [00:36:26] tfinc: will check now, had checked a few hours ago. [00:36:35] yuvipanda: hows the app blog post going ? [00:36:56] i think 3rd time i've cleared it all and started it again. [00:36:56] eek awjr regression :S [00:38:16] jdlrobson what is it? [00:38:26] huge buttons under the nav menu [00:38:32] which you open when you click the icon [00:39:14] jdlrobson: what's in deployment is what's at head of origin/master [00:39:27] ohw ow they are large. [00:39:37] New patchset: member:Jdlrobson; "follow up to 48ac88f17922ee7aaa9141c17688d31d4a07208d" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/3789 [00:39:45] that solves it [00:39:50] * jdlrobson curses his tired brain [00:40:32] jdlrobson: no worries! [00:40:34] merged [00:40:38] tfinc: i think i now have an outline http://etherpad.wikimedia.org/wp-app-1-1-release-post [00:42:13] tfinc: it'd also be awesome if we could get stats on pageviews from the mobile app [00:42:25] tfinc: *also*, this blog post can't go out until Apple approves our app :) [00:42:50] ok jdlrobson, changes live [00:43:36] jdlrobson: changes are live [00:43:41] sorry crashed [00:44:03] my laptop doesn't like it when it falls off my lap [00:44:05] sigh we need a varnish flush for the new contact page [00:44:33] and no one really around to do it. [00:45:47] http://bit.ly/GGzDVv < is that the right link to the beta preilly tfinc ? [00:48:52] jdlrobson: yeah, but you don't end up on kermit the frog [00:49:06] people will survive [00:49:07] i hope [00:49:29] preilly leslie's doing it [00:49:47] awjr: sweet [00:50:16] jdlrobson: we've got another link that collects metrics [00:51:05] jdlrobson: it's bit.ly/woptin [00:51:44] was that updated to the new link? [00:51:57] preilly jdlrobson, how does the contact page look for you in beta? [00:52:01] leslie just flushed the cache [00:52:10] awjr: good [00:52:23] ok i dont know why the hell it still looks like the old contact form for me [00:52:24] like a non-beta version [00:52:30] same awjr [00:52:39] hmmm [00:54:49] huh Leslie re-flushed but im still seeing the old form... [00:56:42] zomg [00:56:46] it would help if i pushed the right file [00:56:58] ok now try [00:57:01] awjr: http://en.wikipedia.org/w/index.php?title=Main_Page&mobileaction=leave_feedback&a=1 [00:58:48] jdlrobson, preilly all look right to you now? [00:59:02] yup [00:59:10] yuvipanda: looking at blog post now [00:59:24] it's just an outline, the previous drafts were awful [00:59:32] tfinc: but i think it has all the points we want to say [00:59:40] hehe .. ok .. draft in in google docs so that we can add images [00:59:47] and have some more control over layout [00:59:48] ah, yes [00:59:57] preilly: tfinc I should use http://bit.ly/woptin for the opt in link? [01:00:02] yuvipanda: i don't want to block on apple approving the app [01:00:10] say its live in android and under review by apple [01:00:16] tfinc: then we have a blog post announcing an iOS app that people can not download [01:00:51] let's get everything done, and hit publish when it's live on the app store. [01:01:10] i'm not convinced yet. but that shouldn't stop us from pushing it for review [01:01:18] to apple [01:01:31] ofcourse not. [01:01:35] we should do that asap :) [01:01:37] tfinc: https://bugzilla.wikimedia.org/show_bug.cgi?id=35511 [01:01:47] jdlrobson: yes [01:01:52] preilly: nice [01:02:07] tfinc: all i'm saying is that this blog post should go out when our app is available on iTunes. Otherwise iOS users have no action item [01:02:39] http://blog.wikimedia.org/?p=11190&preview=true < please review changes [01:02:52] jdlrobson: much better layout [01:03:24] tfinc: also, do you think we can get stats on how many page views we got via the app? [01:03:28] jdlrobson: remove uncategorized from the categories list [01:03:36] yuvipanda: we have that [01:03:41] yuvipanda: let me get it for you [01:03:46] awsome [01:03:49] tfinc: done [01:03:55] i've been working with Phil to get these http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm [01:03:58] and we finally have them [01:04:00] tfinc: plus you were going to share the csv of stats from market [01:04:04] treat that as the lower bound [01:04:10] Android: WikipediaMobile (WMF) [01:04:18] and DONT trust the iOS numbers [01:04:49] people search a lot [01:04:51] ! [01:05:43] i'm guessing Android: Dalvik is all other wiki apps? [01:05:46] yuvipanda: 2,252,079 total user installs [01:05:51] + earlier vrsion of our app [01:05:53] 1,713,501 active device installs [01:05:58] Reedy: e.g., we should have the string Википедия in the [01:05:58] {"code":"ru","name":"\u0420\u0443\u0441\u0441\u043a\u0438\u0439","site":[{"url":"http:\/\/ru.wikipedia.org","dbname":"ruwiki","code":"wiki"}, [01:05:59] entry of http://en.wikipedia.org/w/api.php?action=sitematrix&format=json [01:06:02] yuvipanda: yes [01:06:08] i'm really happy that we finally have these stats [01:06:17] its the first month so don't lean too heavily on them [01:06:33] i've been pushing the analytics team to clean up anything that looks weird [01:07:25] yeah [01:07:38] do we trust these enough to use them on the blog post? [01:08:05] tfinc: shared the doc with you [01:08:18] yuvipanda: i just sent you the latest csv stats [01:08:29] AFTER this rollout we'll switch the account [01:08:33] so that you can just access it directly [01:08:36] I wonder how/from where we can pull that data... [01:08:48] Reedy: want a copy? [01:08:51] tfinc: awesome [01:09:00] I was meaning what preilly was after :) [01:09:03] ahh ok [01:09:43] The IE6 share is still too high! :( [01:10:09] we should serve them JS that tells them to upgrade [01:10:42] yuvipanda: msg me when you have a bit more prose in [01:10:45] yeah [01:10:53] if your having trouble writing it just let me know and i'll help [01:11:11] i snuck out out it for a while and fixed one of the 1.2 bugs. [01:11:13] will get back [01:11:17] There was IE9 adverts in the cinema yesterday, that was quite suprising [01:11:28] tfinc: yes, will do if I suck at it again [01:12:11] Reedy: would we need to parse http://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php for things like, " 'ruwiki' => 'Википедия'," [01:12:23] so... i would like to go to bed soon what do i need to do before i do that? [01:12:27] I hope not! [01:12:33] im assuming blog post is one of them tfinc ? [01:12:37] yes [01:12:40] please publish [01:12:49] and tweet through @WikimediaMobile [01:13:01] http://blog.wikimedia.org/2012/03/26/wikipedia-mobile-gets-a-face-lift/ [01:13:02] posted [01:13:05] woot! [01:13:06] congrats [01:13:18] Reedy: I mean the 'wgSitename' => array(… section [01:13:22] Yeah [01:13:27] * tfinc starts a round of applause for jdlrobson first blog post [01:13:35] I think $wgConf should give it via osme method [01:13:47] jdlrobson: you can find the @WikimediaMobile info on office wiki [01:14:03] * jdlrobson is looking up [01:14:36] jdlrobson: preilly why did we use the old beta opt in link ? [01:14:43] i'm fixing it [01:14:55] * jdlrobson notices http://wikimediafoundation.org/wiki/Home mobile site has no icon [01:15:28] ok opt in link fixed [01:15:56] wow does this layout look better [01:17:13] bug filed about making the footer tappable anywhere https://bugzilla.wikimedia.org/show_bug.cgi?id=35512 [01:17:31] heatherw: http://blog.wikimedia.org/2012/03/26/wikipedia-mobile-gets-a-face-lift/ [01:17:59] "Wikipedia Mobile gets a facelift. Find out more and give it a test drive http://blog.wikimedia.org/2012/03/26/wikipedia-mobile-gets-a-face-lift/" [01:18:07] happy with that tweet? [01:18:14] jdlrobson: go for it [01:18:16] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/7GcblA [01:18:16] [WikipediaMobile/master] Load sitematrix from a local file. - YuviPanda [01:18:16] [WikipediaMobile/master] Merge pull request #189 from yuvipanda/bz35397 - Patrick Reilly [01:18:32] Project WikipediaMobile - Nightly builds build #260: SUCCESS in 8.4 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/260/ [01:18:32] yuvipanda: Load sitematrix from a local file. [01:18:49] preilly: thanks! [01:18:52] cool! [01:19:01] https://twitter.com/#!/WikimediaMobile/status/184449318927867905 [01:19:07] yuvipanda: full of win for that check in [01:19:10] i've hated that for a while [01:19:17] unnecessary block [01:19:18] tfinc: do you want to ship that in 1.1? [01:19:30] its its low risk [01:19:32] if* [01:19:40] its a pretty simple change [01:19:43] it is. [01:19:46] yuvipanda: np [01:20:01] alright then :) [01:20:33] sweet [01:22:03] well done everyone getting the beta out [01:22:27] congrats! [01:24:40] preilly: [01:24:44] > $wgConf->loadFullData(); [01:24:44] > echo $wgConf->get( 'wgSitename', 'ruwiki' ); [01:24:44] Википедия [01:25:25] lol [01:25:30] preilly: did you get that? [01:26:27] Reedy: got it [01:27:12] tfinc: bug for tracking app scraping breakages. [01:27:46] err [01:27:47] Reedy: so, now we need just need to get that into the Site Martrix extension [01:27:47] https://bugzilla.wikimedia.org/show_bug.cgi?id=35513 [01:28:16] Reedy: s/Site Martrix/Site Matrix [01:30:12] Reedy: also, why in the world are you awake? [01:30:26] lol [01:30:33] I often am around this time [01:30:42] Also, I've had to clean up dog sick twice tonight... [01:30:50] yuck [01:30:53] and [01:30:54] yuck [01:31:09] Indeed. It also smells of tuna.. [01:31:10] https://bugzilla.wikimedia.org/attachment.cgi?id=10333&action=diff [01:31:25] OMG [01:32:43] The only thing I'm not sure about, is whether we need some of the extra parameters setting [01:32:45] return $wgConf->get( $canonical ? 'wgCanonicalServer' : 'wgServer', $dbname, $major, array( 'lang' => $minor, 'site' => $major ) [01:33:44] hmm [01:36:27] > echo $wgConf->get( 'wgSitename', 'ruwiki' ); [01:36:27] Википедия [01:36:27] > echo $wgConf->get( 'wgSitename', 'ruwiki', 'wikipedia', array( 'lang' => 'ru', 'site' => 'wikipedia' ) ); [01:36:27] Википедия [01:37:13] * jdlrobson is off to catch some sleep [01:37:20] see you tomorrow [01:37:30] jdlrobson: take care [01:37:32] > echo $wgConf->get( 'wgServer', 'ruwiki' ); [01:37:32] /$lang.wikipedia.org [01:37:32] > echo $wgConf->get( 'wgServer', 'ruwiki', 'wikipedia', array( 'lang' => 'ru', 'site' => 'wikipedia' ) ); [01:37:32] /ru.wikipedia.org [01:38:25] Reedy: I've got to run [01:38:33] preilly: hoping the bogeyman won't come tonight... but take care i will [01:38:33] Reedy: but, I appreciate you looking into this [01:38:40] jdlrobson: ha ha [01:41:31] tfinc: just noticed that one of the canned responses in OTRS for 'don't want to use the mobile site' is out of date (it refers to 'permanantly disable mobile site') [01:41:45] awjr: i wonder if i have perms to fix that [01:41:50] * tfinc has no idea where to check it [01:41:52] * tfinc hates otrs [01:41:57] yeah it is… awful. [01:45:55] i'll be around for about 15min more min [01:46:16] msg if you need anything [01:47:07] tfinc: i've responded to the otrs tickets you forwarded me this AM [01:47:17] thanks [01:47:43] yuvipanda: 35513 lola thanks for opening that [01:47:45] lolz* [01:55:25] tfinc: :) [06:31:42] o/ [06:33:02] \o [06:33:59] Amgine: gnite, canadian :) [06:34:37] [16:08:08] MaxSem: I have been experimenting with your api today -> http://mobile-geo.wmflabs.org/w/index.php/San_Felipe,_Texas [16:08:50] jdlrobson, unfortunately, my connection is barely alive so I can't even check this out :( [16:09:15] this server is also slow [16:09:22] but basically all the sections are dynamically loaded [16:09:30] as are all pages and search results [16:59:03] * YuviPanda checks logs [17:18:30] MaxSem: do you have docs available for your API changes? [17:20:50] preilly, https://www.mediawiki.org/wiki/Extension:MobileFrontend#prop.3Dextracts [17:21:16] MaxSem: okay, coo — thanks! [17:21:21] s/coo/cool [17:27:59] pfhayes: 3.5 hours? [17:28:34] Amgine:until what? [17:28:47] Standups. [17:28:51] 0.5 hours [17:29:08] damn I hate schedules. [17:29:16] [17:29:28] * YuviPanda pokes Amgine [17:29:37] .5 hour warning. [17:32:08] Heatherw: Will you be able to sit in on the WTMobile standups? [17:32:43] Amgine: probably, if i knew anything about them :) [17:33:07] In half an hour in #Wiktionary-mobile [17:34:24] heatherw: I know DLemieux was annoyed I missed the last meeting because he wants me to look at the current logo. [17:34:39] heh [17:35:00] [17:36:22] Amgine: standups are at 2:00 EST [17:36:56] [17:37:08] I'm collecting people. [17:49:17] greetings all [17:49:21] snooze fest on the feedback page [17:50:16] preilly: what do our opt in stats look like ? [17:51:36] YuviPanda: how is RC1 looking ? [17:51:49] we're ready to roll releases :) [17:52:03] jdlrobson: do we have any reported issues with the beta? [17:52:06] YuviPanda: woot! [17:52:11] RC1 got good feedback, and we fixed the biggest thing y'day. [17:52:17] any blockers ? [17:52:20] tfinc: i'm making screenshots. [17:52:28] tfinc: nope. [17:54:08] tfinc: btw, i had to spend some time earlier today to convince some tech conference organizers that a t shirt with 'not just the tip' in huge words isn't the best idea for a tech UX conference. That archer clip helped :) [17:54:21] wow [17:54:22] thats special [17:54:25] woo! [17:54:59] hehe, indeed! [17:55:18] it would be quite something if they still went on with it though :D [17:55:22] a thousand tee shirts that way [17:55:50] Yah, there was an amusing "long tail" tee-shirt a couple years ago... [17:56:31] wooooww [17:56:51] the mind boggles, doesn't it? [17:56:58] the image was also funny [17:57:16] oh dear... linky or it didn't happen! [17:57:16] it was a suggestively shaped ice berg's side view [17:57:27] no link, saw psd on the screens. [17:57:40] i hope i've convinced them enough :) [17:57:51] 3 minutes, YuviPanda. [17:58:06] Amgine: i'm already there [18:02:50] YuviPanda: i have another meeting rich day so let me know what you need from me [18:03:20] tfinc: i'll get you the android signed apk, you'll need to update it in Android Market ('google play') [18:03:22] some modest twitter traffic about he beta [18:03:36] and also push out the iOS app to Apple [18:03:54] actually .. there is way more if i just search for the term "wikipedia mobile" [18:04:28] YuviPanda: did you branch both? [18:04:48] tfinc: yes, there's a v1.1 branch. [18:04:58] tfinc: i'll have to remove the 'RC' moniker. [18:06:08] preilly: whats our opt in rate? [18:06:13] and do we have stats on just beta traffic [18:08:19] tfinc: checking [18:08:58] tfinc: ping re the Wiktionary template stuff [18:09:37] Sumanah: I asked preilly about it yesterday: it's officially "soon". [18:09:44] aha, thanks Amgine [18:14:10] tfinc: 187 [18:14:22] 187 opt ins over the lat 24 hrs? [18:15:55] tfinc: 111 opt ins over last 24 hours [18:16:06] tfinc: 187 opt ins in last month [18:16:13] sumanah: now that budget meetings are done i should have some time for that :) [18:16:21] https://graphite.wikimedia.org/render?target=stats.mobile_opt_in_cookie_set.count&rawData=true&from=-1days [18:16:47] $o = 0; [18:16:47]