[14:22:50] <mw-jenkinsbot>	 Project WiktionaryMobile - Nightly builds build #45: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/45/
[14:22:50] <mw-jenkinsbot>	 sheaclare: Removing more dead code for Near Me feature
[16:22:12] <pfhayes>	 YuviPanda: do you have admin rights on the WIktionaryMobile repo? we need to add siebrand and Nikerabbit for translations
[16:22:24] <YuviPanda>	 pfhayes: let me check, but i doubt it.
[16:23:17] <Amgine>	 pfhayes: *You* have admin rights.
[16:23:26] <pfhayes>	 Amgine: I don't believe I do
[16:23:45] <YuviPanda>	 I don't
[16:23:46] <Amgine>	 Tfinc was planning on making sure you do. Check?
[16:24:00] <pfhayes>	 Amgine: i just checked and I don't. i'll email tfinc
[16:24:05] <pfhayes>	 thanks YuviPanda
[16:24:07] <Amgine>	 kk.
[16:33:18] <MaxSem>	 jdlrobson, hi
[16:33:22] <MaxSem>	 YuviPanda, ^^
[16:33:26] <YuviPanda>	 MaxSem: hi
[16:33:29] <YuviPanda>	 jdlrobson: hi!
[16:33:35] <jdlrobson>	 yo YuviPanda MaxSem
[16:33:53] <YuviPanda>	 jdlrobson: so, the HTML returned by action=parse&mobileformat=html is quite different in structure than the one that MF uses
[16:34:05] <jdlrobson>	 how so?
[16:34:20] <YuviPanda>	 jdlrobson: specifically, sections aren't in divs, so that means that sectioning code won't work
[16:34:24] <YuviPanda>	 as won't quite a lot of other stuff
[16:34:43] <jdlrobson>	 is this in reference to the history api stuff i was experimenting with?
[16:34:46] <MaxSem>	 we need to standardise on this
[16:35:10] <MaxSem>	 app and MF should use the same calls
[16:35:44] <YuviPanda>	 jdlrobson: this is in reference to moving the app to action=parse&mobileformat=html
[16:35:54] <YuviPanda>	 which does *not* do per-section ajax requests
[16:36:01] <jdlrobson>	 ok
[16:36:33] * jdlrobson  refamiliarises himself with api

[16:37:02] <MaxSem>	 YuviPanda, I still think that extra stage "using the API, but not per-section" is wrong
[16:37:33] <YuviPanda>	 MaxSem: i think that both should be available.
[16:37:40] <YuviPanda>	 high latency + multiple requests -> ugh
[16:39:05] <MaxSem>	 YuviPanda, jdlrobson, can you unify your requirements to the format sections are being served in?
[16:39:17] <MaxSem>	 should we always wrp them in divs?
[16:39:23] <MaxSem>	 s/wrp/wrap/
[16:39:25] <YuviPanda>	 I think so.
[16:39:26] <Amgine>	 bandwidth usage vs. latency + multiple requests; shouldn't we fault to lower bandwidth?
[16:41:00] <jdlrobson>	 so YuviPanda forgive me but can you start from the beginning about what you are trying to achieve. This is rewriting loadPage to use the api yet?
[16:41:15] <YuviPanda>	 jdlrobson: yes.
[16:41:17] <jdlrobson>	 so given a title of a page you go to the api and essentially you want to ask for all the sections for that page
[16:41:31] <YuviPanda>	 jdlrobson: no, given the title of a page you go to the API and ask for the contents of the page
[16:41:40] <jdlrobson>	 or better still ask for anything at the beginning plus the section names (1 level down)
[16:41:42] * preilly  — review https://gerrit.wikimedia.org/r/4105

[16:41:53] <YuviPanda>	 jdlrobson: wait, let me show you the exact API call
[16:42:27] <YuviPanda>	 jdlrobson: http://en.wikipedia.org/w/api.php?action=parse&format=json&page=Mumbai&prop=text&mobileformat=html
[16:42:42] <YuviPanda>	 compare that to html from http://en.m.wikipedia.org/wiki/Mumbai
[16:44:39] <preilly>	 and this: preilly * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114654> /branches/wmf/1.19wmf1/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php: 1.19wmf: MFG Change-Id: I8eea04193a9fa3c7361e3124981bf55704988030
[16:45:30] <jdlrobson>	 so YuviPanda at the moment MFE parses the html and adds the sections itself
[16:45:50] <jdlrobson>	 so what would be better in my opinion is rather than requesting the entire html requesting all the sections
[16:48:10] <YuviPanda>	 jdlrobson: hmm, so you're in favor of moving to multiple requests per page too?
[16:48:47] <jdlrobson>	 well for the time being all im suggesting is calling the api to get a more structured response from which we can build the sections
[16:49:07] <jdlrobson>	 it also means later we could just request the summary at the top of the article and load sections on demand
[16:50:01] <YuviPanda>	 i'm confused.
[16:50:39] <jdlrobson>	 well so essentially you'd do something like http://en.wikipedia.org/w/api.php?action=mobileview&format=json&page=Mumbai&sections=all&mobileformat=json
[16:51:31] <jdlrobson>	 which would return you an array of all the sections, then you'd iterate through putting each section into containers so the output is like in MFE (<div class='section'></div>)
[16:52:06] <jdlrobson>	 going forward you'd do something like ...sections=0... which would just load the initial summary and then load sections 1...n when the user clicks a show button
[16:52:37] <YuviPanda>	 jdlrobson: that request does not give me entire page's contents
[16:52:56] <YuviPanda>	 just the lead section
[16:53:00] <jdlrobson>	 i know but it could
[16:53:05] <jdlrobson>	 MaxSem: ^ ?
[16:53:32] <YuviPanda>	 jdlrobson: but http://en.wikipedia.org/w/api.php?action=parse&format=json&page=Mumbai&prop=text%7Csections
[16:53:35] <YuviPanda>	 already has section info
[16:55:07] <jdlrobson>	 but the text is all in one big block
[16:55:17] <MaxSem>	 jdlrobson, I'll implement sections=all
[16:55:40] <jdlrobson>	 i'd like to see {"toclevel":3,"level":"4","line":"Monorail","number":"7.3.3","index":"17","fromtitle":"Mumbai","byteoffset":80204,"anchor":"Monorail", text: ''},
[16:55:43] <jdlrobson>	 where text is not an empty string
[16:55:49] <YuviPanda>	 ah
[16:55:50] <YuviPanda>	 +1
[16:55:55] <jdlrobson>	 but is the html currently in json.sections['*']
[16:56:29] <MaxSem>	 you don't need to see byteoffset, young jedi
[16:56:52] <tfinc>	 greetings all
[16:57:58] <jdlrobson>	 yep, ideally i should just be able to just loop through the api appending line and text of each section (using toclevel to work out what level headings to use)
[16:58:02] <jdlrobson>	 greetings tfinc
[16:58:12] <tfinc>	 hey jdlrobson
[16:58:59] <tfinc>	 jdlrobson: linSmith is going to change to a once a week check in
[16:59:00] <YuviPanda>	 +1 on jdlrobson
[16:59:48] <tfinc>	 she'll just be checking in with us on mondays
[17:00:13] <pfhayes>	 tfinc: I sent you an email about adding siebrand and Nikerabbit as collabs on the WiktionaryMobile repo
[17:00:13] <jdlrobson>	 ok cool
[17:00:17] <MaxSem>	 jdlrobson, text belongs to sections because this whole API is oriented towards per-section retrieval
[17:00:18] <tfinc>	 pfhayes: i saw it
[17:00:21] <pfhayes>	 tfinc: cool
[17:00:50] <MaxSem>	 you can request sections=1,2,3,100 and should receive them in a sensible manner
[17:01:17] <jdlrobson>	 YuviPanda: i think to mimic what MFE does you would just have to do something like if(toclevel === 1) add special markup to headings and wrap content in a section and then run MobileFrontend.toggle.init() after the loop to get toggling working
[17:01:36] <tfinc>	 ok. lets do our stand up
[17:07:39] <awjr>	 preilly what is the problem you're experiencing with cookies?
[17:08:04] <jdlrobson>	 MaxSem: but i would need to know how many sections there are?
[17:08:59] <tfinc>	 YuviPanda: how are our reviews looking ?
[17:09:32] <YuviPanda>	 tfinc: good, they bumped up to 4.5 after a small dip to 4.4
[17:09:35] <MaxSem>	 jdlrobson, my planned API workflow was: prop=sections|text&section=0 on first view then just request needed sections with prop=text&sections=foo
[17:10:00] <MaxSem>	 this way you can just count the number of sections in the array returned by the first request
[17:10:15] <YuviPanda>	 tfinc: i see a bunch of issues that i've not been able to replicate - possibly network related ones
[17:10:20] <tfinc>	 YuviPanda: excellent. just as i predicted
[17:10:30] <tfinc>	 YuviPanda: i saw some issues related to small fonts
[17:10:47] <YuviPanda>	 tfinc: i think they're on the galaxy nexus, where possibly our 'largest' size is still not large enough
[17:10:50] <YuviPanda>	 (DPI issues)
[17:10:58] <tfinc>	 YuviPanda: iOS is still under review :(
[17:11:04] <YuviPanda>	 tfinc: no feedback whatsoever?
[17:11:13] <tfinc>	 YuviPanda: apple doesn't give you any feedback
[17:11:20] <tfinc>	 its other approved, waiting, or rejected
[17:11:22] <tfinc>	 thats all
[17:11:57] <YuviPanda>	 mumble grumble sigh
[17:12:21] <MaxSem>	 I had 2 Skype interruptions during the standup - did anyone else have them?
[17:12:28] <tfinc>	 YuviPanda: 1.1.1 has over taken 1.0.3 :D
[17:12:29] <YuviPanda>	 MaxSem: jdlrobson i think section=all would be a feature that'd make a lot of sense.
[17:12:30] <jdlrobson>	 MaxSem: so yes but i think the first smallest step that would get us some momentum is to just load the entire content as we are now but do so via the api via screen scraping
[17:12:52] <YuviPanda>	 +1
[17:12:54] <jdlrobson>	 i worry if we go straight to the load from api step we might run into lots of problems and it will be a slower process
[17:12:59] <jdlrobson>	 as MFE doesn't do this yet either
[17:13:48] <YuviPanda>	 +1
[17:13:51] * MaxSem  goes to implement sections=all

[17:14:06] <YuviPanda>	 tfinc: am looking through the errors being reported. A few don't make sense to me.
[17:14:09] <tfinc>	 YuviPanda: i love how we can have a five star and one start review from the exact same phone
[17:14:12] <YuviPanda>	 17 reports of 'WikipediaApp not found'
[17:14:13] <tfinc>	 star*
[17:14:27] <tfinc>	 with one person saying it doesn't work and the other loving it
[17:14:38] <YuviPanda>	 that makes no sense to me - WikipediaApp crashes because WikipediaApp is not found.
[17:14:51] <YuviPanda>	 tfinc: hehe, I'm guessing network + what you have on it makes a lot of difference
[17:15:26] <jdlrobson>	 so YuviPanda untested code but i was imagining something like this - http://pastebin.com/LW5dEHnx
[17:16:07] <YuviPanda>	 jdlrobson: yes, I understand how things would work once we have section=all
[17:16:09] * MaxSem  notices that he starts typing some weird pythonish PHP

[17:16:18] <YuviPanda>	 hehe
[17:16:21] <jdlrobson>	 sure... just checking we are on the same wavelength :)
[17:16:37] <YuviPanda>	 i was writing python over the weekend and started by writing 'function' instead of 'def' and wondering 'why no syntax highlight?'
[17:17:09] <tfinc>	 YuviPanda: we need to clean up the error reports in the play market
[17:17:31] <YuviPanda>	 clean up -> ?
[17:21:50] <YuviPanda>	 tfinc: ^
[17:27:31] <tfinc>	 YuviPanda: mark them as old
[17:27:36] <tfinc>	 as that we can focus on any new issues
[17:27:47] <YuviPanda>	 right
[17:31:28] <jdlrobson>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=31591 < YuviPanda / tfinc this is a MobileFrontend bug yes?
[17:31:43] <YuviPanda>	 yes
[17:31:48] <jdlrobson>	 will change
[17:32:02] <gerrit-wm>	 New patchset: awjrichards; "Set 'contact us' title in the special page, add corresponding i18n message" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3964
[17:33:24] * jdlrobson  needs to pop out for 30 mins back in a jiffy

[17:37:12] * tfinc  starts on email backlog

[17:37:59] <tfinc>	 who's a vim user in here ?
[17:38:05] <awjr>	 i am
[17:38:25] <tfinc>	 awjr: which vim plugins do you use ?
[17:38:27] <awjr>	 tfinc: vim ftw
[17:38:42] <awjr>	 tfinc good question - whatever comes with apt-get install vim-full
[17:40:13] <YuviPanda>	 i've quite a collection
[17:40:14] <YuviPanda>	 wait
[17:40:33] <YuviPanda>	 tfinc: awjr https://dl.dropbox.com/u/8768784/vimrc
[17:40:48] <tfinc>	 fancy
[17:40:50] <YuviPanda>	 22 plugins
[17:41:13] <YuviPanda>	 though 4 of them are color schemes I switch around
[17:41:49] <awjr>	 wow
[17:41:57] <awjr>	 i mostly just take advantage of syntax highlighting
[17:42:29] <tfinc>	 YuviPanda: what does extradite do on top of fugitive ?
[17:42:47] <YuviPanda>	 tfinc: given a file, i can see all commits that touched *just* that file
[17:43:11] <YuviPanda>	 err
[17:43:16] <YuviPanda>	 *just* the commits that touched that file
[17:43:38] <tfinc>	 nerdcommenter .. nice
[17:43:41] <YuviPanda>	 awjr: this accumulated over 2 years.
[17:44:01] <YuviPanda>	 tfinc: command-T is pretty damn awesome as well
[17:44:33] <tfinc>	 YuviPanda: how does it compare to NERDTree ?
[17:44:45] <YuviPanda>	 tfinc: it is quite different, actually.
[17:44:46] <awjr>	 YuviPanda i've some how managed to not accumulate much over years of vim use, i guess i've always kept it simple and when wanting something more robust, opted for an IDE
[17:44:59] <YuviPanda>	 nerdtree is more 'exploratory'
[17:45:09] <YuviPanda>	 this is 'i remember part of a file name, let's open it!'
[17:45:26] <YuviPanda>	 + it takes up no space
[17:45:44] <YuviPanda>	 awjr: ah, right. The only IDE I actually like is 2005+ versions of Visual Studio, so no luck.
[17:45:51] <awjr>	 hahaha
[17:45:56] <YuviPanda>	 awjr: :)
[17:45:59] <tfinc>	 VS . haha
[17:46:02] <tfinc>	 i remember that
[17:46:07] <YuviPanda>	 awjr: plus i spent about two years writing code on an atom netbook
[17:46:10] <YuviPanda>	 :D
[17:46:17] <YuviPanda>	 that was when I switched from 8 months of emacs to vim
[17:46:27] <YuviPanda>	 and have been here since :D
[17:46:35] <YuviPanda>	 tfinc: it *is* better than every other IDE out there.
[17:46:46] <YuviPanda>	 that's more a commentary on how every other IDE I used sucked
[17:46:55] <YuviPanda>	 it is also perhaps because C# is a nicer language than Jav
[17:46:56] <YuviPanda>	 a
[17:55:05] <awjr>	 preilly: you mentioned on the checkin call that you were seeing issues with cookies still?
[17:55:22] <YuviPanda>	 tfinc: are you 'moving' to vim?
[17:55:39] <tfinc>	 YuviPanda: lola.. i've been on vim for years
[17:55:43] <tfinc>	 lolz
[17:55:59] <tfinc>	 every couple of years i reassess whats out there and see if something new has come out that i should use
[17:56:01] <YuviPanda>	 ah, then why the sudden plugin love?
[17:56:02] <YuviPanda>	 ah
[17:57:12] <gerrit-wm>	 New patchset: preilly; "Remove dismiss zero banner code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4112
[17:57:47] <preilly>	 awjr: can you approve this change ^^
[17:58:02] <preilly>	 awjr: yeah, I'm seeing some weird cookie stuff
[17:58:16] <preilly>	 awjr: but, I've not really investigated in too much
[17:58:40] <YuviPanda>	 tfinc: that's why I had 'moving' in quotes :)
[17:58:44] <YuviPanda>	 tfinc: do you have a vimrc somewhere?
[17:59:52] <awjr>	 preilly: can you open a bug with the issues you're seeing? i can take a look later.
[18:00:18] <preilly>	 awjr: I want to investigate a bit more before I do, but sure
[18:00:43] <gerrit-wm>	 New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4112
[18:00:45] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4112
[18:00:52] <awjr>	 preilly ok thanks
[18:00:58] <MaxSem>	 what the fuck, git
[18:01:02] <awjr>	 it's nice we have gerrit notifications in here ow
[18:01:03] <awjr>	 *now
[18:01:28] <preilly>	 awjr: yeah, I set that up on Friday
[18:01:52] <awjr>	 baller.
[18:02:02] <tfinc>	 preilly: Ryan_Lane : this was my last delivery of kitkats http://sphotos.xx.fbcdn.net/hphotos-ash4/317841_10150337427318344_585593343_7984472_1964213197_n.jpg
[18:02:21] <preilly>	 awjr: can you release https://gerrit.wikimedia.org/r/4112 today?
[18:02:43] <awjr>	 preilly sure put it on the deployment page
[18:02:57] <preilly>	 awjr: what is the link to that page?
[18:03:09] <awjr>	 http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments#2_April.2C_2012
[18:06:57] <preilly>	 awjr: is this sufficient, "http://www.mediawiki.org/w/index.php?title=Extension:MobileFrontend/Deployments&stable=0&shownotice=1&fromsection=2_April%252C_2012#2_April.2C_2012" ?
[18:07:16] <awjr>	 preilly that's great
[18:07:54] <preilly>	 awjr: okay, thanks!
[18:08:35] <gerrit-wm>	 New patchset: MaxSem; "Support for action=mobileview&sections=all" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4113
[18:09:13] <tfinc>	 YuviPanda: is it just me or is QSB always in english ?
[18:09:40] <YuviPanda>	 we merged in code that made QSB respect settings
[18:09:46] <YuviPanda>	 tfinc: what language are you in?
[18:09:49] <tfinc>	 Polish
[18:09:58] <tfinc>	 and i have a report of the same thing not working in Swedish
[18:11:03] <MaxSem>	 jdlrobson, YuviPanda sections=all ^^^
[18:11:09] <YuviPanda>	 tfinc: hmm, question.
[18:11:27] <MaxSem>	 anything else?
[18:11:42] <YuviPanda>	 tfinc: can you set it to english in the app, and set it back to polish and try?
[18:11:58] <tfinc>	 sure
[18:12:21] <jdlrobson>	 MaxSem: will have a play
[18:14:08] <tfinc>	 YuviPanda: that seems to fix it *except* for terms you've already searched for
[18:14:12] <tfinc>	 those seem cached in QSB
[18:14:32] <YuviPanda>	 tfinc: yeah, I think the bug is that you need to set it in the app. It doesn't pick the default locale
[18:14:33] <YuviPanda>	 hmm
[18:14:50] <tfinc>	 bug filed: https://bugzilla.wikimedia.org/show_bug.cgi?id=35650
[18:14:54] <jdlrobson>	 MaxSem: YuviPanda is there any way http://localhost/w/api.php?action=mobileview&sections=all&page=History%20of%20China could not including the headings (class mw-headline) in the response - I'd rather we got this from line
[18:15:09] <tfinc>	 i'm going to respond to the user who reported it and see if the sw->en->sw fixes it
[18:15:16] <tfinc>	 so that they can at least have the correct seeting
[18:15:18] <tfinc>	 setting*
[18:16:18] <YuviPanda>	 jdlrobson: can you pastebin the response, I don't have a MF install
[18:16:24] <jdlrobson>	 sure 1 s
[18:17:04] <jdlrobson>	 http://pastebin.com/pd8gMHAE
[18:18:46] <Ryan_Lane>	 tfinc: wow
[18:19:52] <MaxSem>	 jdlrobson, "I'd rather we got this from line"?
[18:20:14] <jdlrobson>	 so for example in ... http://localhost/w/api.php?action=mobileview&sections=all&page=History%20of%20China&format=json if you grep for line":"Prehistory"
[18:20:23] <jdlrobson>	 text begins with '<h2> <span class=\"mw-headline\" id=\"Prehistory\">Prehistory<\/span><\/h2>'
[18:20:40] <jdlrobson>	 yet i can work out that h2 by using toclevel and line keys
[18:20:51] <YuviPanda>	 ah
[18:21:06] <jdlrobson>	 (or grep http://pastebin.com/pd8gMHAE)
[18:21:27] <MaxSem>	 YuviPanda, what do you think^^^
[18:21:35] <YuviPanda>	 reading through it
[18:21:39] <jdlrobson>	 it gives me more flexibility MaxSem - for example i might want to do 2 articles on a page (for some unknown reason) - in which case h2's might become h3s
[18:21:42] <jdlrobson>	 etc
[18:21:57] <srikanthlogic>	 search suggestions in mobile frontend show redirected pages on the list differing from desktop version
[18:21:59] <YuviPanda>	 +1 it's duplicated data.
[18:22:00] <srikanthlogic>	 is this intended ?
[18:22:29] <jdlrobson>	 srikanthlogic: can you give an example?
[18:22:45] <srikanthlogic>	 jdlrobson: type "Madras" on enwp , en.m.wp
[18:23:02] <srikanthlogic>	 Madras redirects to Chennai and many other redirects are present as well
[18:23:39] <srikanthlogic>	 becomes an "issue" more so with new beta which shows more suggestions
[18:23:49] <srikanthlogic>	 because people might think there is a relevancy issue
[18:24:38] <jdlrobson>	 srikanthlogic: do you mean that in the search suggestions the 1st option says 'Chennai' rather than Madras and thus it is not clear it is related?
[18:24:48] <srikanthlogic>	 jdlrobson: yes
[18:25:16] * jdlrobson  looks closer

[18:25:19] <srikanthlogic>	 desktop version shows Madras btw
[18:25:49] <srikanthlogic>	 I tried setting up opensearch and auto-suggest working on local (both for mobile / desktop) but I couldnt try to get it working :(
[18:25:57] <jdlrobson>	 this seems like an oversight - MaxSem  - is there any reason http://en.m.wikipedia.org/w/api.php?action=opensearch&limit=15&namespace=0&format=xml&search=Madr provides the redirected name?
[18:26:33] <jdlrobson>	 It looks like a bug to me srikanthlogic - thanks for pointing it out I hadn't noticed..
[18:27:24] <srikanthlogic>	 :) and its even more strange in those language wikis where they redirect foreign names crazily :D
[18:28:19] <jdlrobson>	 it would be good MaxSem  (maybe its possible already) to also be able to provide the original title that matched the search term in the api response
[18:28:43] <srikanthlogic>	 jdlrobson: how does the desktop one work ?
[18:29:06] <MaxSem>	 mhm
[18:29:08] <jdlrobson>	 good thinking :)
[18:29:27] <MaxSem>	 "Madrid (, ) is the capital and largest city of Spain."
[18:29:50] <jdlrobson>	 it uses json rather than xml
[18:29:56] <jdlrobson>	 (on desktop site)
[18:30:19] <MaxSem>	 jdlrobson, that would break users relying on OpenSearch conformance
[18:31:10] <jdlrobson>	 you mean if we added another element to Item in the xml response?
[18:31:38] <tfinc>	 heads up that ops is adding search servers in EQIAD today … shouldn't impact us since its load balanced service but i'm told we've never ran search from there
[18:32:56] <jdlrobson>	 srikanthlogic: in terms of your local instance what isn't working?
[18:33:23] <srikanthlogic>	 jdlrobson: I tried installing OpenSearchXml and run updateSearch.php
[18:33:31] <srikanthlogic>	 it couldnt write to the pos file
[18:34:06] <MaxSem>	 pdateSearch.php is for incremental updates
[18:34:32] <srikanthlogic>	 oh, so is there a place where I know steps to perform after installation ?
[18:34:33] <MaxSem>	 are you sure it's needed?
[18:34:39] <MaxSem>	 none
[18:34:54] <MaxSem>	 if you have ordinary search set up
[18:35:05] <srikanthlogic>	 I dont know, I just thought I might need to create an Index , updateSearch seemed like a match
[18:35:07] <MaxSem>	 which should work by default
[18:35:11] <jdlrobson>	 you mean http://www.mediawiki.org/wiki/Extension:OpenSearchXml or are you trying to do something else?
[18:35:18] <srikanthlogic>	 yes, same
[18:35:37] <jdlrobson>	 mine worked without doing anything more than the above
[18:38:23] <jdlrobson>	 srikanthlogic: MaxSem https://bugzilla.wikimedia.org/show_bug.cgi?id=35651
[18:39:19] <MaxSem>	 grr
[18:39:34] <MaxSem>	 I don't understand: http://en.wikipedia.org/w/api.php?action=opensearch&limit=15&namespace=0&format=xml&search=Madr vs. http://en.m.wikipedia.org/w/api.php?action=opensearch&limit=15&namespace=0&format=xml&search=Madr
[18:40:06] <MaxSem>	 no difference
[18:40:33] <jdlrobson>	 http://en.m.wikipedia.org/w/api.php?action=opensearch&limit=15&namespace=0&format=xml&search=Madras MaxSem
[18:40:39] <tfinc>	 brion: you around?
[18:40:48] <brion>	 tfinc: yo
[18:40:49] <jdlrobson>	 top result is <Text xml:space="preserve">Chennai</Text> rather than <Text xml:space="preserve">Madras</Text>
[18:41:03] <tfinc>	 brion: can you respond to Gord please
[18:41:08] <srikanthlogic>	 jdlrobson: thanks, but I wonder how API can return such ways
[18:41:22] <srikanthlogic>	 where it should just change the format of response
[18:42:13] <awjr>	 MaxSem is the problem related to the 'Madras' article being a redirect?
[18:42:22] <brion>	 tfinc: looks like it was failing to init the section toggle because he hadn't  run the magic command to fetch the .js files for it
[18:42:35] <brion>	 did we fix it so that's not needed anymore yet or is that makefile still needed?
[18:42:39] <tfinc>	 YuviPanda: --^
[18:42:45] <srikanthlogic>	 awjr: yes
[18:42:48] <awjr>	 perhaps there's something different on the desktop site that's aware that the 'Madras' article exists as a redirect even though it's not coming back in the opensearch respsonse
[18:42:53] <preilly>	 brion: got to love, "magic commands".
[18:42:59] <MaxSem>	 eh, I was looking for differences in API while report was about differences in overall UI behaviour
[18:43:01] <MaxSem>	 got it
[18:43:02] <brion>	 heh
[18:43:20] <YuviPanda>	 brion: nope.
[18:43:44] <YuviPanda>	 brion: working on it - have a submodule that submodules MF from gerrit, should push it up when it is actually directly being used
[18:43:51] <brion>	 funkay
[18:45:15] <tfinc>	 YuviPanda: let me know when you have a free minute to talk about the mozilla marketplace
[18:45:54] <YuviPanda>	 tfinc: we can do it now
[18:46:14] <tfinc>	 thanks brion
[18:47:05] <brion>	 whee
[18:48:59] <preilly>	 MaxSem: pm
[18:50:06] <tfinc>	 YuviPanda: let me add you to the email chain with mozilla and then we can chat
[18:50:12] <YuviPanda>	 tfinc: cool
[18:50:14] <Astagi>	 hi all
[18:50:27] <Astagi>	 YuviPanda have a question for you :)
[18:50:33] <YuviPanda>	 Astagi: sure!
[18:50:33] <YuviPanda>	 heya
[18:50:47] <Astagi>	 I'm trying fixing the scrolltop issue when you save a page
[18:51:31] <Astagi>	 the only problem I have is that I can modify the scrolltop property only using document.body.scrolltop YuviPanda
[18:51:36] <Astagi>	 is it ok?
[18:52:00] <tfinc>	 YuviPanda: ok .. cc'd
[18:52:26] <tfinc>	 YuviPanda: so their store is really simple
[18:52:31] <YuviPanda>	 Astagi: what's wrong with $("#content").scrollTop()
[18:52:54] <Astagi>	 I don't know seems to not working YuviPanda :(
[18:53:08] <YuviPanda>	 jdlrobson: i think we had a discussion about this, IIRC?
[18:53:12] <tfinc>	 YuviPanda: apps in the mozilla marketplace are nothing more then manifests that point to somewhere on the web
[18:53:13] <YuviPanda>	 scrollTop?
[18:53:17] <YuviPanda>	 tfinc: ah!
[18:53:22] <tfinc>	 making versioning almost non existent
[18:53:23] <tfinc>	 which i like
[18:53:26] <tfinc>	 now
[18:53:36] <tfinc>	 that doesn't mean that you don't want to leverage offlien
[18:53:54] <tfinc>	 in fact i think these kinds of apps will really push their os to do HTML5 offline in really interesting ways
[18:55:10] <Astagi>	 yep YuviPanda I tried $("#content").scrollTop() but is not working :) I read something similar here http://stackoverflow.com/questions/4809106/webkit-scroll-bar-overflow-jquery-scrolltop-returns-always-zero
[18:55:10] <jdlrobson>	 scrollTop YuviPanda ? I think one of the android versions didnt like scrollTop on anything other than the body?
[18:55:14] <tfinc>	 i wish gmail had custom keyboard commands
[18:55:32] <tfinc>	 for instance .. i use this all the time "in:inbox is:unread" and build off of it
[18:55:35] <YuviPanda>	 jdlrobson: what was our fix? we showed and hid it, right?
[18:55:45] <YuviPanda>	 Astagi: lookat doScrollHack in android/platform.js
[18:56:50] <YuviPanda>	 tfinc: yes!
[18:57:05] <jdlrobson>	 yep YuviPanda that we did
[18:57:09] <YuviPanda>	 tfinc: infact, once we push to the API, it should be simple to do saved pages without having to use PhoneGap apis
[18:57:12] <jdlrobson>	 that was the horrible hack that we must never speak of
[18:57:17] <YuviPanda>	 jdlrobson: this is why I prefer comments inline with the code
[18:57:19] <tfinc>	 haha
[18:57:19] <YuviPanda>	 rather than elsewhere
[18:57:27] <jdlrobson>	 it will be on the commit though no?
[18:57:40] <Astagi>	 ok YuviPanda jdlrobson but I need to get the current position too :)
[18:57:40] <jdlrobson>	 if you do a git blame on that line you can remember the context
[18:57:49] <Astagi>	 not only set it..
[18:57:53] <YuviPanda>	 jdlrobson: ^
[18:58:10] <YuviPanda>	 jdlrobson: i can, you can. Astagi can't because he wasn't involved in the discussion :)
[18:59:37] <jdlrobson>	 yuvipanda but that's what commits are for no? https://github.com/wikimedia/WikipediaMobile/commit/86ed7486ffb25ca1f3acf356aaafe9aafac378af
[18:59:40] <YuviPanda>	 tfinc: just saw that. It looks very doable
[18:59:54] <jdlrobson>	 and https://bugzilla.wikimedia.org/show_bug.cgi?id=35369
[19:00:56] <YuviPanda>	 jdlrobson: yes, but still...
[19:00:56] <Astagi>	 no jdlrobson :) I'm fixing another bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=35431
[19:00:59] <YuviPanda>	 less context switches
[19:01:24] <Astagi>	 and for do that I need to save the scroll position and set it after page is saved
[19:01:49] <YuviPanda>	 Astagi: jdlrobson is the best person to talk about that hack :)
[19:02:47] <jdlrobson>	 so with that bug surely we just don't run the hack? (i guess it must be running somewhere)
[19:02:47] <Astagi>	 nice :)
[19:03:14] <YuviPanda>	 jdlrobson: ah, yes. that makes a lot of sense
[19:03:42] <jdlrobson>	 i guess clicking savePage triggers it somewhere.
[19:04:35] <Astagi>	 oh I see jdlrobson, so this is causing the scrolltop to 0 right?
[19:05:11] <jdlrobson>	 yep the show hide trick is forcing a scroll to top
[19:05:13] <Astagi>	 this make sense, I'll check where you call it, I didn't remember about this hack :)
[19:05:23] <jdlrobson>	 So I guess somewhere in the code when you do a save it is running the code hack
[19:05:38] * jdlrobson  does a git blame

[19:05:52] <Astagi>	 I see, thanks for showing me up jdlrobson YuviPanda :)
[19:07:13] <jdlrobson>	 actually
[19:07:24] <jdlrobson>	 if you are doing a hide of the content I think that is going to force the scrolling to the top
[19:07:33] <jdlrobson>	 regardless of whether you are doing the scroll hack
[19:07:40] <jdlrobson>	 so clicking saved pages will hide content
[19:07:59] <jdlrobson>	 which will reset scrolling :-S
[19:09:11] <jdlrobson>	 ive got a few MobileFrontend things to do but will be around till late if you have any issues :) plenty of things it **could** be cas
[19:09:14] <jdlrobson>	 ..caused by
[19:10:14] <Astagi>	 I have to avoid both behaviour so :) thanks jdlrobson :) later will work on it, thanks for now!
[19:10:32] <jdlrobson>	 good luck
[19:10:35] <jdlrobson>	 the scrolling stuff is horrible
[19:10:56] * jdlrobson  needs to sit down and understand the scrolling issues on ios sometime soon

[19:11:34] <Astagi>	 I see :) thanks!
[19:20:59] <YuviPanda>	 tfinc: are we committed to making the moz launch?
[19:21:12] <tfinc>	 we haven't committed to anything
[19:21:25] <tfinc>	 i wanted to discuss what it would take first
[19:23:39] <tfinc>	 we would have to *host* the app somewhere
[19:25:13] <YuviPanda>	 tfinc: yes
[19:25:21] <YuviPanda>	 tfinc: and there are CORS problems there.
[19:25:28] <YuviPanda>	 *especially* because of the way we do subdomains
[19:25:40] <YuviPanda>	 can be proxied, but then the proxy becomes a bottleneck
[19:25:59] <preilly>	 jerith: ping
[19:26:30] <tfinc>	 CORS ?
[19:27:33] <YuviPanda>	 tfinc: cross domain requests
[19:27:57] <YuviPanda>	 tfinc: so, if the app is at en.m.wikipedia.org, it *usually* cannot access de.m.wikipedia.org
[19:28:06] <tfinc>	 right
[19:28:11] <YuviPanda>	 tfinc: i guess the 'app' store has ways of getting around this though
[19:29:10] <tfinc>	 we should ask and find out
[19:29:28] <YuviPanda>	 tfinc: yes, i'm sure they have technical documentation up ther somewhere
[19:29:45] <tfinc>	 YuviPanda: lets build our question list and send it out
[19:30:02] <YuviPanda>	 tfinc: alright.
[19:30:17] <tfinc>	 that way it doesn't distract us from 1.2
[19:32:33] <YuviPanda>	 tfinc: okay
[19:33:54] <preilly>	 Do we have a, "Access-Control-Allow-Origin" header right now?
[19:37:47] <YuviPanda>	 preilly: nope
[19:37:53] <jerith>	 preilly: Pong.
[19:38:01] <YuviPanda>	 preilly: hmm, so we don't need proxies if we can set that
[19:38:09] <YuviPanda>	 anyway, will add it to list of questions to send moz
[19:38:22] <tfinc>	 YuviPanda: thanks
[19:39:24] <preilly>	 YuviPanda: yeah, we just need to set that
[19:39:29] <preilly>	 YuviPanda: no, need for proxies
[19:40:02] <YuviPanda>	 preilly: too used to doing requests against stuff I don't control :)
[19:40:10] <YuviPanda>	 nobody does Access-Control-Allow-Origin: *
[19:40:11] <YuviPanda>	 :D
[19:55:47] <gerrit-wm>	 New patchset: Jdlrobson; "update footer template to mimic desktop site html" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4122
[19:56:48] <jdlrobson>	 srikanthlogic: did you see update on https://bugzilla.wikimedia.org/show_bug.cgi?id=35651 ?
[19:56:52] <jdlrobson>	 makes a bit more sense now
[19:59:40] <tfinc>	 time for food
[20:00:50] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4122
[20:00:52] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4122
[20:07:42] <preilly>	 jerith: any status on making a deb
[20:08:36] <jerith>	 preilly: Sadly not. Life got in the way a bit. ;_;
[20:08:55] <preilly>	 jerith: do you know when that might be done?
[20:09:07] <preilly>	 jerith: I've got to get this stuff installed on these boxes
[20:09:37] <jerith>	 preilly: I can't make any guarantees, unfortunately.
[20:09:54] <jerith>	 But I'll try get it started tomorrow evening, at least.
[20:09:57] <preilly>	 jerith: hmm, well I guess I'll need to figure something else out
[20:10:56] <jerith>	 preilly: Can you puppet-deploy stuff straight from git repos?
[20:11:19] <jerith>	 I don't think setting up a virtualenv full of dependencies is easy to puppet. :-/
[20:11:41] <preilly>	 jerith: we should be able to
[20:12:31] <preilly>	 jerith: well, I'd like to use a deb, but that doesn't look like it will work out in the short term
[20:12:46] <preilly>	 jerith: unless, you really think you'll be able to make progress tomorrow
[20:13:14] <jerith>	 I won't really know until tomorrow. :-/
[20:13:42] <jerith>	 (I'm really sorry about this. It's just that we have more tight deadlines than manpower at the moment.)
[20:15:26] <srikanthlogic>	 jdlrobson: yes.
[20:15:47] <srikanthlogic>	 jdlrobson: when is the new UI supposed to be live?
[20:16:09] <srikanthlogic>	 also that would be just for app, what about the mobileweb site?
[20:18:15] <preilly>	 jerith: I understand
[20:18:25] <gerrit-wm>	 New review: awjrichards; "Line 42 of api/ApiMobileView.php:" [mediawiki/extensions/MobileFrontend] (master); V: -1 C: -1;  - https://gerrit.wikimedia.org/r/4113
[20:19:41] <awjr>	 is MaxSem out for the day?
[20:19:54] <OuKB>	 ?
[20:19:58] <awjr>	 nm :)
[20:20:08] <awjr>	 i can't keep all your nicks straight :p
[20:20:37] <MaxSem>	 this time it wasn't intentional, simply got disconnected
[20:20:59] <awjr>	 no worries
[20:21:03] <MaxSem>	 awjr, you wanted something?
[20:21:12] <awjr>	 i just −1'd one of your changests
[20:21:29] <awjr>	 just wanted to let you know in case it's something you wanted to have go out today
[20:22:40] <MaxSem>	 thx
[20:22:47] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: -1 C: -2;  - https://gerrit.wikimedia.org/r/4113
[20:22:54] <jdlrobson>	 awjr: any idea why when i do git review contact-us-redesign it tries to send all my commits so far rather than the first
[20:22:55] <jdlrobson>	 is that a problem?
[20:23:24] <YuviPanda>	 MaxSem: do you know when sections=all might hit production?
[20:23:25] <awjr>	 jdlrobson: i'm not sure i follow
[20:23:27] <YuviPanda>	 an approximate timeframe?
[20:23:38] <preilly>	 YuviPanda: probably once it works
[20:23:47] <preilly>	 ;_;
[20:23:47] <YuviPanda>	 ah :)
[20:23:56] <YuviPanda>	 is that a crying cat smiley?
[20:24:08] <jdlrobson>	 well when i type git review contact-us-redesign im told that it is going to send a commit that has already been merged
[20:24:11] <jdlrobson>	 has left me a little confused
[20:24:28] <jdlrobson>	 as i thought if i did a git pull it would update itself
[20:24:38] <preilly>	 (@_@)
[20:24:50] <awjr>	 jdlrobson: i think i experienced the same thing and it all just sort of worked out
[20:24:58] <jdlrobson>	 ok ill try it
[20:25:01] <YuviPanda>	 preilly: that looks like puking-rainbow-guy sans the rainbow
[20:25:09] <awjr>	 it seemed like git-review was going to send a bunch of new commits, but the only ones that showed up as new in gerrit were the actual new changes
[20:25:11] <jdlrobson>	 ahh remote rejected
[20:25:16] <awjr>	 >_<
[20:25:21] <jdlrobson>	 change 3924 closed
[20:25:25] * YuviPanda  heads back to Javaland

[20:25:47] <gerrit-wm>	 New patchset: MaxSem; "Support for action=mobileview&sections=all" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4124
[20:26:55] <preilly>	 So, are we not amending changes now?
[20:26:58] <gerrit-wm>	 New review: MaxSem; "Amend with TortoiseGit didn't work:/" [mediawiki/extensions/MobileFrontend] (master) C: 0;  - https://gerrit.wikimedia.org/r/4124
[20:27:40] <MaxSem>	 awjr, ^^
[20:28:06] <preilly>	 MaxSem: can you abandon your old change
[20:28:44] <gerrit-wm>	 Change abandoned: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4113
[20:29:59] <preilly>	 MaxSem: thanks
[20:31:35] <gerrit-wm>	 New patchset: Jdlrobson; "additional styling" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4126
[20:32:12] <jdlrobson>	 awjr: deleted branch and tried again - hoping that worked! seems to have..
[20:33:20] <awjr>	 hehehe ok jdlrobson
[20:33:35] <awjr>	 jdlrobson looks like it
[20:33:41] <jdlrobson>	 awjr: what time are we deploying today?
[20:33:46] <jdlrobson>	 sorry if you said already
[20:33:49] <awjr>	 jdlrobson 3pm PDT
[20:33:50] <awjr>	 no worries
[20:34:02] <jdlrobson>	 k thx..
[20:34:04] <awjr>	 jdlrobson: http://wikitech.wikimedia.org/view/Software_deployments
[20:34:57] <jdlrobson>	 thanks :D
[20:36:39] <preilly>	 do we want to try to get the RL for CSS work in today?
[20:38:23] <gerrit-wm>	 New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4124
[20:38:26] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4124
[20:39:03] <awjr>	 jdlrobson: do you have a few minutes to chat about contact us?
[20:39:37] <jdlrobson>	 ummm i can do
[20:39:49] <jdlrobson>	 i was just looking at resource loader and seeing if we could get common.css in before this deployment
[20:39:56] <awjr>	 ok let's talk later
[20:40:16] <jdlrobson>	 i'm here for a while so no rush :)
[20:40:37] <gerrit-wm>	 New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4126
[20:40:40] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4126
[20:44:57] <MaxSem>	 YuviPanda, sections=all has been merged - I think awjr can deploy it today
[20:45:02] <YuviPanda>	 woo
[20:45:04] <YuviPanda>	 hoo
[20:45:17] <preilly>	 wee
[20:58:33] <awjr>	 MaxSem, jdlrobson, preilly - do you guys have all your changes for the deployment merged to master?
[20:58:58] * MaxSem  checks

[20:59:10] <preilly>	 I do
[21:00:36] <MaxSem>	 looks ok
[21:02:05] <jdlrobson>	 awjr: i have one more commit
[21:02:10] <jdlrobson>	 give me 5 mins
[21:02:14] <awjr>	 jdlrobson: no problem.
[21:02:19] <jdlrobson>	 minor styling change
[21:03:55] <tfinc>	 YuviPanda: you used a milestone !
[21:04:08] <YuviPanda>	 tfinc: i've been using them for a while, no?
[21:04:19] <tfinc>	 how do you like them vs tracking bugs ?
[21:04:30] <YuviPanda>	 tfinc: https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&namedcmd=1.2&list_id=104508
[21:04:34] <YuviPanda>	 tfinc: well, am mixed.
[21:04:42] <tfinc>	 There is no saved search named '1.2'.
[21:04:45] <YuviPanda>	 I like the display, but I'm missing the ability to comment on the release itself
[21:04:53] <YuviPanda>	 damn, that is just for me?
[21:04:57] <YuviPanda>	 so this also sucks
[21:04:59] <YuviPanda>	 harder to share
[21:05:05] <YuviPanda>	 and the URL to actually share is huge
[21:05:12] <tfinc>	 yeah, this is a personal search
[21:05:17] <YuviPanda>	 so while semantically cleaner, I see no obvious advantages + a few disadvantages
[21:05:40] <YuviPanda>	 unless someone tells me 'you have been missing these!', i think we should move back to tracking bugs for the next release
[21:05:44] <tfinc>	 k, if it doesn't work out when can always let mark know and then revert back
[21:05:46] <YuviPanda>	 let's use this for this cycle so we give it time
[21:05:47] <YuviPanda>	 yeah
[21:13:19] <Astagi>	 YuviPanda am I free to use window variable in my code? look here: https://github.com/wikimedia/WikipediaMobile/blob/master/assets/www/js/chrome.js#L320
[21:13:27] <YuviPanda>	 tfinc: strong feelings on https://bugzilla.wikimedia.org/show_bug.cgi?id=34673
[21:13:29] <jdlrobson>	 actually awjr i dont think i need to commit anything (unless i magically get resource loader working)
[21:13:30] <YuviPanda>	 Astagi: checking
[21:13:49] <awjr>	 jdlrobson ok in that case im going to start merging to the deployment branch
[21:14:09] <Astagi>	 I was talking with jdlrobson and he suggested to use chrome.doScrollHack(window)
[21:14:13] <YuviPanda>	 Astagi: I think this particular fix I'll defer to jdlrobson.
[21:14:17] <Astagi>	 in plase of that line
[21:14:37] <Astagi>	 *place
[21:14:50] <YuviPanda>	 Astagi: he'll also be the one who'll be reviewing this pull request, so convincing him would be enough in this case :)
[21:15:21] <Astagi>	 ahaha he just said me to ask you YuviPanda :D
[21:15:29] <Astagi>	 jdlrobson you're the boss now
[21:15:35] <jdlrobson>	 YuviPanda: I'm still not confident I understand all the hackery going on with scrolling - i wanted a 2nd opinion
[21:15:36] <YuviPanda>	 i'll defer to jdlrobson's decision on scrolling :)
[21:15:49] <YuviPanda>	 jdlrobson: I don't either. brion was the one who first did our scrolling work
[21:16:02] * YuviPanda  looks for the spell to summon brion

[21:17:31] <YuviPanda>	 jdlrobson: from what I understand, doScrollHack simply resets page scroll to top
[21:17:41] <YuviPanda>	 jdlrobson: unless you're on iOS 4.3, in which case it uses iScroll4 to do the same thing
[21:17:49] <jdlrobson>	 yes we should maybe rename to scrollToTop or something similar
[21:18:05] <YuviPanda>	 yes
[21:18:12] <Astagi>	 will do in my patch coming jdlrobson
[21:18:13] <YuviPanda>	 also need to figure out if we still need doFocusHack
[21:19:25] <Astagi>	 I meant not the rename, but using scroll hack in place of window.scroll
[21:22:18] <Astagi>	 ok fixed :)
[21:23:42] <Astagi>	 YuviPanda did you read about shortner url for wikipedia?
[21:24:02] <YuviPanda>	 Astagi: Extension:ShortUrl would hopefully be deployed soon and 'fix' that issue
[21:24:11] <YuviPanda>	 atleast the biggest part of that issue
[21:24:13] <YuviPanda>	 (url encoding )
[21:24:51] <Astagi>	 nice :) would be great to encode any url we share in the app
[21:27:44] <gerrit-wm>	 New patchset: MaxSem; "Added an option to return sections without <h*> tags" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4133
[21:28:05] <MaxSem>	 YuviPanda, jdlrobson ^^^
[21:33:54] <gerrit-wm>	 New review: Demon; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/3963
[21:43:37] <tfinc>	 preilly: how are the zero styling changes going ?
[21:43:54] <preilly>	 tfinc: they're all done
[21:43:58] <tfinc>	 anything else pending before we can announce a launch ?
[21:44:04] <tfinc>	 baring all the opera mobile bits
[21:44:08] <preilly>	 tfinc: for zero?
[21:44:16] <tfinc>	 yeah
[21:44:23] <preilly>	 tfinc: well, we need to figure out the fonts issue
[21:44:36] <preilly>	 tfinc: I've asked Dan to talk to Amit and the carrier and figure it out
[21:48:33] <jdlrobson>	 MaxSem: \o/
[21:49:03] <MaxSem>	 jdlrobson, moar regexes, unfortunately
[21:49:17] <jdlrobson>	 :/ are those getting expensive yet?
[21:49:52] <YuviPanda>	 heatherw_: https://minus.com/mbrpnLZKWy/
[21:49:57] <YuviPanda>	 both the new imagery
[21:50:13] <YuviPanda>	 heatherw_: not sure if the 'beta' is too blocking
[21:50:23] <YuviPanda>	 also, to open another can of worms, 'beta' is always in english :P
[21:50:23] <MaxSem>	 no, but it's bad practice :|
[21:50:41] <YuviPanda>	 regexing through html? what could possibly go wrong...
[21:50:53] <gerrit-wm>	 New patchset: awjrichards; "Fixing language handling in MobileFrontend.body.php to use appropriate language fetching method depending on mw 1.19 or mw 1.20 - previously threw strict errors" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4138
[21:51:07] <awjr>	 preilly, MaxSem can you please take a look at ^
[21:51:30] <awjr>	 it fixes something i fixed last week in a better way so it doesnt throw strict errors
[21:53:50] <MaxSem>	 awjr, static call of a member function
[21:54:50] <MaxSem>	 no, my bads
[21:57:02] <awjr>	 MaxSem: that was the problem before
[21:57:51] <gerrit-wm>	 New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 0;  - https://gerrit.wikimedia.org/r/4138
[21:58:13] <gerrit-wm>	 New review: Jdlrobson; "mf-feedback.js needs to be updated as it depends on this id (more a todo note than a complaint)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) C: -1;  - https://gerrit.wikimedia.org/r/3963
[22:00:11] <awjr>	 MaxSem $wgContLang will do the trick there?
[22:00:31] <awjr>	 also how do you lea an inline comment?
[22:01:11] <brion>	 YuviPanda: scrolling questions?
[22:01:50] <YuviPanda>	 brion: if me and jdlrobson have it right, the *only* reason doScrollHack exists is to 'scroll to the top' with an appropriate method, right?
[22:01:57] <YuviPanda>	 i.e. natively everywhere, iScroll on iOS 4
[22:02:16] <awjr>	 MaxSem: which is better to use, $wgContLng or $wgLang?
[22:02:26] <brion>	 YuviPanda: iirc it's primarily to set up scrolling with iscroll, and also to scroll to the top :)
[22:02:47] <YuviPanda>	 ah, okay.
[22:03:07] <YuviPanda>	 brion: same thing :)
[22:03:12] <brion>	 :D
[22:04:07] <MaxSem>	 awjr, 1) double click on a line in diff
[22:04:28] <MaxSem>	 2) both seem to do static stuff in 1.19 anyway
[22:05:43] <awjr>	 MaxSem getLanguageName is not a static method though in the Language class in 1.19
[22:05:52] <tfinc>	 preilly: whats the official launch date for digi malaysia sans indic languages on the main page ?
[22:06:20] <gerrit-wm>	 New patchset: awjrichards; "Fixing language handling in MobileFrontend.body.php to use appropriate language fetching method depending on mw 1.19 or mw 1.20 - previously threw strict errors" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4138
[22:06:45] <awjr>	 MaxSem i made the change to use $wgContLang ^
[22:10:08] <tfinc>	 jdlrobson: what ux changes are going out today?
[22:10:18] <tfinc>	 "UX improvements to beta"
[22:10:32] <jdlrobson>	 tfinc: hitting enter on search goes to first result
[22:10:39] <tfinc>	 gotcha
[22:10:41] <jdlrobson>	 the footer expands no matter where you click
[22:10:50] <MaxSem>	 awjr, getLanguageName() doesn't seem to throw wfDeprecated() on 1.20 - maybe it can be called indiscriminately for simplicity?
[22:10:50] <jdlrobson>	 I think it scrolls into view better as well
[22:11:06] <jdlrobson>	 sorry should have been more clear on deployment notes
[22:11:31] <jdlrobson>	 tfinc: i was planning to review the coding exercises tomorrow... hope that's okay.. wanted to make most of time with team today
[22:11:37] <tfinc>	 totally fine
[22:11:44] <tfinc>	 monday is deployment day
[22:11:52] <tfinc>	 and since  your overlapping with us on hours it makes a lot of sense
[22:12:07] <jdlrobson>	 have also just had an enquiry about Berlin and have cc'ed you
[22:12:15] <awjr>	 MaxSem you are right - in 1.20 getLanguageName() just makes the call of Language::fetchLanguageName
[22:12:24] <tfinc>	 were good to go on that. i just need to mail our travel coordinator
[22:12:35] <tfinc>	 err
[22:12:37] <tfinc>	 as in you going
[22:13:47] <gerrit-wm>	 New patchset: awjrichards; "Fixing language handling in MobileFrontend.body.php to use appropriate language fetching method depending on mw 1.19 or mw 1.20 - previously threw strict errors" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4138
[22:13:55] <awjr>	 MaxSem ^
[22:14:37] <gerrit-wm>	 New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1;  - https://gerrit.wikimedia.org/r/4138
[22:14:57] <jdlrobson>	 YuviPanda: how goes the api rewrite? anything to share?
[22:15:10] <jdlrobson>	 ie. the rewrite to make app use the api
[22:15:18] <YuviPanda>	 jdlrobson: blocked myself on the new stuff to go to production and worked on a few other bugs
[22:15:31] <jdlrobson>	 k what hours are you working tomorrow?
[22:15:36] <jdlrobson>	 would be good to overlap again
[22:15:45] <YuviPanda>	 jdlrobson: I can do that.
[22:15:47] <YuviPanda>	 what hours are you on?
[22:15:51] <awjr>	 preilly can you look at this real quick: https://gerrit.wikimedia.org/r/#change,4138
[22:16:36] <tfinc>	 preilly: jerith: how is the puppetization going ?
[22:16:38] <jdlrobson>	 i'm on BST right now YuviPanda and tomo I was hoping to do something more sane... <when i wake up> -> 7pm-ish
[22:16:51] <YuviPanda>	 7PM BST?
[22:16:54] <jdlrobson>	 (when i wake up should be about 8/9am based on current experience)
[22:16:59] <jdlrobson>	 it's like GMT but it's summerfied
[22:17:05] <jdlrobson>	 ie. GMT+1
[22:17:06] <YuviPanda>	 i…m confused
[22:17:09] <YuviPanda>	 okay
[22:17:18] <jerith>	 tfinc: Not very, at the moment.
[22:17:24] <YuviPanda>	 so you're going to be up at 7 'PM' UTC?
[22:17:40] * jerith  gazes into his schedule. "My god, it's full of deadlines."

[22:17:43] <jdlrobson>	 well right now it is 23:17 GMT+1
[22:18:05] <jdlrobson>	 i'll be working till 7PM GMT+1 tomorrow.. if all goes to plan
[22:18:08] <awjr>	 MaxSem: are you ableto approve and submit that? it's blocking getting code up on test
[22:18:09] <YuviPanda>	 ah
[22:18:10] <YuviPanda>	 got it
[22:18:25] <YuviPanda>	 jdlrobson: i can come up by about 2PM GMT+1
[22:18:40] <MaxSem>	 awjr, I can't +2
[22:18:57] <jdlrobson>	 perfect YuviPanda
[22:19:03] <awjr>	 MaxSem ok - I can do it but I always feel weird doing it to myself
[22:19:10] <YuviPanda>	 jdlrobson: cool!
[22:19:37] * MaxSem  gives awjr his blessings

[22:19:47] <gerrit-wm>	 New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4138
[22:19:47] <awjr>	 :D
[22:19:50] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4138
[22:20:48] <YuviPanda>	 MaxSem: sections=all going to prod today, I guess?
[22:22:57] <MaxSem>	 ask the deploying guy;)
[22:23:11] <MaxSem>	 why do you need it so urgently?
[22:23:33] <jdlrobson>	 because otherwise he has to wait a week!
[22:23:41] <YuviPanda>	 :)
[22:23:55] <YuviPanda>	 or write things with action=parse, and then rewrite it
[22:23:56] <YuviPanda>	 again
[22:24:06] <MaxSem>	 we have staging servers for this
[22:24:35] <YuviPanda>	 or modify the wikipedia app so that it is not a complete pain to talk to other servers.
[22:24:36] <YuviPanda>	 hmm
[22:24:38] <YuviPanda>	 i think i already did that
[22:24:40] <YuviPanda>	 let me check
[22:24:46] <MaxSem>	 I don't like quick deployments of API because they should be tested by you the users first
[22:25:00] <MaxSem>	 good API === stable API
[22:25:33] <awjr>	 preilly, jdlrobson, MaxSem: today's deployment changes are live on testwiki
[22:25:39] <awjr>	 tfinc also ^
[22:25:41] <jdlrobson>	 \o/
[22:25:47] <tfinc>	 woot!
[22:25:52] <tfinc>	 did he resource loader changes make it in?
[22:26:02] <awjr>	 please test and let me know if you see issues
[22:26:41] <jdlrobson>	 errrorrr awjr
[22:26:47] <YuviPanda>	 MaxSem: the fact that the app expects domains to be in a particular form messes up me testing elsewhere. Will fix
[22:26:55] <awjr>	 aw crap
[22:27:20] <jdlrobson>	 nope tfinc turns out that can't turn off skins with resource loader - preilly was exploring it earlier but it sounds like string replacing is the only way to do it :-S
[22:28:55] <tfinc>	 k
[22:29:16] <gerrit-wm>	 New patchset: awjrichards; "Finishing fix in previous commit to get all cases of getLanguageName()" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4140
[22:29:23] <awjr>	 MaxSem, jdlrobson ^
[22:30:01] <jdlrobson>	 awjr: i'm getting 'ur servers are currently experiencing a technical problem'
[22:30:16] <jdlrobson>	 also on my android it's redirecting to incubator.wikimedia.org - is that normal?
[22:30:17] <awjr>	 jdlrobson yeah, the commit above should fix it
[22:30:23] <jdlrobson>	 k
[22:30:25] <awjr>	 jdlrobson: yes it is normal
[22:30:30] <jdlrobson>	 cool :)
[22:30:31] <awjr>	 jdlrobson but it sucks
[22:30:40] <awjr>	 incubator != test
[22:30:48] <awjr>	 we have an RT ticket open to get that fixed
[22:31:03] <tfinc>	 awjr: whats the rt ticket on it?
[22:31:37] <awjr>	 tfinc one se
[22:31:38] <awjr>	 c
[22:32:22] <awjr>	 tfinc oh wow maybe that ticket didn't actually get made - that or rt search sucks.
[22:32:38] <tfinc>	 i couldn't find it searching
[22:32:42] <awjr>	 yeah me neither
[22:32:56] <awjr>	 i'll make one - if it's a dupe they can deal.
[22:34:53] <awjr>	 tfinc: #2756
[22:35:21] <awjr>	 MaxSem can you double check this: https://gerrit.wikimedia.org/r/#change,4140,patchset=1
[22:37:26] <MaxSem>	 awjr, no warnings for me
[22:37:46] <gerrit-wm>	 New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4140
[22:37:48] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4140
[22:38:18] <jdlrobson>	 awjr: when this is done let me know when you want to talk contact form
[22:38:47] <awjr>	 jdlrobson definitely
[22:39:38] <awjr>	 jdlrobson, MaxSem, preilly please test changes on test
[22:39:52] * jdlrobson  nods

[22:40:09] <jdlrobson>	 now im getting language issues
[22:40:16] <awjr>	 you may see weird wfMsg() related things on test - it's just because we can't easily refresh the language cache until we actually deploy
[22:40:21] <jdlrobson>	 k
[22:43:10] <awjr>	 MaxSem, preilly, jdlrobson: let me know when you are satisfied things work correctly
[22:43:14] <awjr>	 then i'll push to production
[22:43:34] <jdlrobson>	 it looks fine just can't test on my android due to the incubator redirect :/
[22:43:53] <awjr>	 grr
[22:44:04] <MaxSem>	 my part looks ok
[22:44:26] <awjr>	 ok then just waiting on preilly
[22:46:35] <jdlrobson>	 he said bbiab at 23:05 and haven't seen him since
[22:46:51] <awjr>	 hmm
[22:47:08] <awjr>	 he made some zero-rated changes but im not sure how to test them
[22:52:14] <jdlrobson>	 mm
[22:53:30] <tfinc>	 need me to find him?
[22:53:45] <awjr>	 tfinc i just sent him a text - is he in the office?
[22:53:53] <tfinc>	 he's in today just not at his desk
[22:54:05] <tfinc>	 right now
[22:54:29] <awjr>	 ok he hasnt responded to me yet so i think i might just revert his changes and deploy everything else
[22:55:42] <awjr>	 i'll give him another minute or two
[22:55:58] <tfinc>	 i took a quick stroll and didn't see him
[22:56:04] <tfinc>	 bet he's grabbing coffee
[22:56:34] <tfinc>	 don't wait on him. he can deploy it after
[22:59:39] <awjr>	 ok i reverted his change in the deployment branch
[22:59:41] <awjr>	 running scap
[23:01:26] <Astagi>	 time to go bed.. gnite all :)
[23:09:53] <heatherw>	 YuviPanda: you here?
[23:10:13] <YuviPanda>	 heatherw: yup
[23:11:01] <heatherw>	 so, i don't know who made the beta W for the mobile beta, but i matched that (regarding covering too much W, etc)
[23:11:23] <tfinc>	 heatherw: norm made it
[23:11:25] <tfinc>	 jorm*
[23:11:29] <heatherw>	 hah
[23:11:32] <heatherw>	 norm
[23:11:34] <tfinc>	 :D
[23:11:43] <heatherw>	 colloquy does that to me all the time
[23:11:57] <heatherw>	 tfinc:
[23:11:59] <heatherw>	 oops
[23:12:11] <tfinc>	 but yeah, he's the one who made it
[23:12:13] <heatherw>	 tfinc: what do you think of the W's YuviPanda is referring to?
[23:12:22] <tfinc>	 i have no clue what your talking about
[23:12:24] <tfinc>	 whats the background
[23:12:32] <heatherw>	 looking for the bug one sec
[23:12:56] <heatherw>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=35577
[23:13:06] <tfinc>	 ahh .. this
[23:13:10] <YuviPanda>	 tfinc: https://minus.com/mbrpnLZKWy/
[23:13:12] <heatherw>	 Beta W for the Android app
[23:13:12] <YuviPanda>	 is how it looks in the app
[23:13:14] <YuviPanda>	 and the screen
[23:13:21] <YuviPanda>	 (there are two images there)
[23:13:55] <tfinc>	 all of those look like we have a censor bar
[23:14:02] <heatherw>	 i see that i *did* end up giving you the smaller launcher, too
[23:14:03] <heatherw>	 yeah
[23:14:30] <heatherw>	 maybe i will go with a light bar on the darker search bar icon
[23:14:49] <tfinc>	 heatherw: mozilla does a nice job of this https://play.google.com/store/apps/details?id=org.mozilla.firefox_beta
[23:14:57] <tfinc>	 by just making it off centered
[23:15:09] <heatherw>	 ahh cool
[23:15:21] <heatherw>	 i was trying to match, but i can try something else, too
[23:15:42] <tfinc>	 i think our current W beta icon breaks down when you magnify it for an icon
[23:19:34] <tfinc>	 awjr: preilly is back
[23:19:38] <awjr>	 ok scap just finished
[23:19:46] <preilly>	 I was at lunch
[23:19:50] <awjr>	 all changes (except for preilly's) are live
[23:20:02] <preilly>	 awjr: why not mine?
[23:20:22] <awjr>	 preilly: didnt know how to test them and you weren't here to say they whether or not they were ok
[23:21:10] <preilly>	 awjr: what change?
[23:21:32] <awjr>	 preilly: https://gerrit.wikimedia.org/r/#change,4112
[23:21:47] <Amgine>	 (thinks a nice red β for the beta)
[23:22:06] <preilly>	 awjr: please push that change
[23:23:45] <awjr>	 preilly im getting the change back on test now
[23:24:04] <heatherw>	 what do tfinc and YuviPanda think of a β?
[23:24:33] <tfinc>	 heatherw: i'd have to see it on icon form. how universal will that be ?
[23:24:38] <preilly>	 tfinc: The puppet work is stalled for the moment
[23:24:52] <preilly>	 tfinc: jerith is going to try to work on the deb tomorrow night
[23:24:58] <heatherw>	 that is something i do not know
[23:25:54] <preilly>	 tfinc: I'm also working on creating the puppet configuration around the new deb
[23:26:19] <awjr>	 preilly: that change is live on testwiki
[23:26:28] <awjr>	 lemme know if it looks ok and i'll sync-file it
[23:26:50] <YuviPanda>	 heatherw: do note that the app will also be named 'Beta', so that might help.
[23:27:58] <preilly>	 awjr: it looks okay — please sync it
[23:30:03] <awjr>	 preilly syncing now
[23:30:58] <tfinc>	 heatherw: how would you feel about presenting the mobile redesign during the monthly metrics and analytics meeting ?
[23:31:22] <heatherw>	 ooh! scary and fun!
[23:31:29] <tfinc>	 a short coupe of minutes would do
[23:31:39] <tfinc>	 i think it would be great to have you showcase it
[23:31:55] <tfinc>	 were trimming down the engineering portion of the meeting to 3-4 short presentations
[23:32:07] <heatherw>	 i am good at being short :)
[23:32:14] <awjr>	 preilly done
[23:32:15] <tfinc>	 and i think the mobile re-design is the best one for us
[23:32:19] <tfinc>	 heatherw: you in?
[23:32:23] <heatherw>	 yup!
[23:32:36] <preilly>	 tfinc: yay!
[23:32:45] <heatherw>	 want to talk about the whole thing including parts that aren't implemented?
[23:33:00] <tfinc>	 lets sync up about it later today
[23:33:06] <preilly>	 awjr: cool — http://en.zero.wikipedia.org/ looks right
[23:33:15] <heatherw>	 okay tfinc perfect, thanks
[23:33:16] <awjr>	 preilly: bitchin
[23:33:53] <preilly>	 awjr: are you going to have someone clear the varnish cache?
[23:34:03] <awjr>	 preilly is it necessary?
[23:34:13] <preilly>	 awjr: I think we at least need it for the zero related changes this week
[23:34:24] <preilly>	 maplebed: do you mind clearing the varnish cache?
[23:34:32] <preilly>	 awjr: I'm asking maplebed to do it
[23:34:32] <awjr>	 preilly ok - i wonder if we should wait til the deployment funkiness gets resolved
[23:34:37] <awjr>	 a lot of hosts are out of diskspace
[23:34:44] <preilly>	 awjr: hmm
[23:34:49] <awjr>	 LeslieCarr and tim are coping with it in #wikimedia-tech
[23:34:53] <gerrit-wm>	 New patchset: Jdlrobson; "adapt select menu font size for smaller devices" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4146
[23:34:55] <maplebed>	 swish swash "clear varnish kaboom!"
[23:36:18] <maplebed>	 preilly: the varnish cache is cleared.
[23:36:32] <maplebed>	 !log cleared the varnish cache
[23:37:01] <awjr>	 tim's re-running scap now - it looks like they might have resolved the issue
[23:39:21] <awjr>	 tfinc jdlrobson: shall we talk about contact us?
[23:40:50] <jdlrobson>	 from my perspective all that is left to do is get the form saving the new fields and doing error handling/success handling in the same form rather than redirecting
[23:41:07] <jdlrobson>	 than adding some ajax enhancements to do the same error/success handling
[23:41:22] <awjr>	 jdlrobson: cool - i still need to build out the logic for mail routing and whatnot
[23:41:24] <jdlrobson>	 (then probably some extra work to remove any jquery dependancy)
[23:41:52] <awjr>	 and am curious how we should handle the page redirection for the category that doesn't display the form
[23:42:01] <jdlrobson>	 how does it currently work? does it save to a database?
[23:42:12] <jdlrobson>	 which category was that?
[23:42:13] <awjr>	 jdlrobson currently it does nothing
[23:42:30] <awjr>	 well, it just blindly sends you to a success page
[23:42:35] <jdlrobson>	 really? eek
[23:42:49] <jdlrobson>	 so people on wikipedia mobile might be using the feedback form without saving anything?
[23:42:57] <awjr>	 jdlrobson: did you mean the existing feedback form or where i'm at in building the backend for the new one?
[23:43:03] <jdlrobson>	 both
[23:43:11] <awjr>	 right now, on the current feedback form, it writes the mssage to a wiki page
[23:43:17] <jdlrobson>	 ok cool
[23:43:17] <jdlrobson>	 w
[23:43:25] <jdlrobson>	 well can't we still do that for a first release of contact us
[23:43:32] <jdlrobson>	 we can do fancy email routing later on
[23:43:51] <jdlrobson>	 better to start capturing more useful information and storing it on wiki pages
[23:43:58] <awjr>	 that's fine with me, pending tfinc/phillinje
[23:44:32] <Reedy>	 Yay
[23:44:36] <awjr>	 jdlrobson: the one category that is weird is 'article feedback - factual error'
[23:44:40] <Reedy>	 Android 4.0.4 for Galaxy Nexus
[23:44:56] <awjr>	 that's the one that is supposed to redirect to a wiki page rather than show the form
[23:45:17] <jdlrobson>	 yeh that is a bit odd
[23:46:01] <jdlrobson>	 we still capture things on the wiki page though right?
[23:46:04] <awjr>	 no
[23:46:14] <jdlrobson>	 well that doesn't seem very usable
[23:46:54] * jdlrobson  notices the contact page has changed some more

[23:47:24] <preilly>	 so what does it need to email?
[23:47:35] <awjr>	 jdlrobson the specs are still not very clear on the design page, but i think philinje had said that when you select that category, it should auto-redirect you after 5s or something and also display a notification to the user with the link. if, before redirect, the user selects a different category, then the redirect would get cancelled
[23:47:37] <jdlrobson>	 this section form has changed a lot
[23:47:40] <heatherw>	 basically it tells people that they are complaining to the wrong place
[23:47:57] <jdlrobson>	 so as i understand it now we are now dealing with several forms
[23:48:01] <jdlrobson>	 inside sections
[23:48:24] <awjr>	 jdlrobson one of the problems with that particular feature is that i dont think we know whether or not every wiki project has a similar page, let alone what the URL is for that page on all projects
[23:48:31] <heatherw>	 it is no longer a button with a menu
[23:48:39] <heatherw>	 it's just a list of choices
[23:48:53] <awjr>	 preilly: http://www.mediawiki.org/wiki/Mobile_design/Contact
[23:49:19] <jdlrobson>	 we need to think in terms of non-javascript browsers as well
[23:49:32] <awjr>	 preilly: when the form is supposed to email someone the comment, it's supposed to send the user's email address, their comment, and user-agent
[23:49:42] <Amgine>	 ++ jdlrobson
[23:49:43] <awjr>	 jdlrobson: agreed
[23:49:52] <jdlrobson>	 my preference would be to serve all the forms on one page under separate headings
[23:50:03] <jdlrobson>	 and then using the toggling code from the rest of the mobile site
[23:50:11] <jdlrobson>	 http://www.mediawiki.org/wiki/File:Mobile_Contact_A1.png
[23:50:16] <jdlrobson>	 which i think is what that is doing
[23:51:06] <heatherw>	 mostly. it changes the page+title from Contact us to whatever is chosen
[23:51:14] <jdlrobson>	 and if I click technical problem i get a form which sets an input 'subject' to 'technicalproblem' general I get a form which sets an input 'subject' to 'general', article feedback I just get text with links
[23:51:44] <awjr>	 jdlrobson: we could set it up so that the what happens when a particular category selected is configurable with one of two possible actions - redirect or send email
[23:52:14] <awjr>	 that will keep behavior flexible for us depending on which wiki project plus keep the extension usable by other people
[23:52:32] <heatherw>	 philinje: they are discussing the mechanics of the contact us page
[23:53:53] <jdlrobson>	 if I submit a form I'd expect to either be redirected back to the form or back to the page I was on
[23:54:10] <jdlrobson>	 If I got redirected to the factual error page that would be a bit confusing
[23:54:24] <jdlrobson>	 I'd prefer to click contact us > report factual error and be told there that I need to go elsewhere
[23:54:32] <awjr>	 jdlrobson: agreed
[23:55:27] <jdlrobson>	 i think if we did a first iteration that just saved any contents of a form to a wiki page we can update that to do other actions instead e.g. mail someone
[23:56:25] <awjr>	 jdlrobson so in essence replicate existing functionality but with categories? we would need to take out the email address submission box - or just do nothing with that particular data
[23:56:27] <heatherw>	 you don't get a form when you select factual error
[23:56:46] <jdlrobson>	 yes awjr exactly
[23:56:56] <awjr>	 heatherw: according to the specs you still get a form
[23:57:00] <jdlrobson>	 heatherw: so with factual error I'd expect clicking on the heading I get some copy text explaining the situation
[23:57:47] <heatherw>	 right now (in theory) you go straight to this, yeah?  http://www.mediawiki.org/wiki/File:Mobile_Contact_F2.png
[23:57:54] <heatherw>	 no form first
[23:57:54] <Reedy>	 jdlrobson: where abouts are you based?
[23:58:11] <jdlrobson>	 london Reedy
[23:58:23] <heatherw>	 do you mean you want to change that text, jdlrobson ?
[23:58:42] <jdlrobson>	 so heatherw how do I get to this page?
[23:58:43] <awjr>	 heatherw: according to the specs "Article feedback - factual error - reveals a link in the comment box: http://en.wikipedia.org/wiki/Wikipedia:Contact_us/Article_problem/Factual_error in the language versions listed below, and if the language does not correspond to one of these pages, to this email address: info-XX@wikimedia.org, where XX is one of the language codes listed below, or EN if none of those languages provides a match"
[23:59:00] <heatherw>	 well, that is wrong! :P
[23:59:04] <heatherw>	 sorry
[23:59:08] <heatherw>	 thought it had been updated
[23:59:09] <awjr>	 no worries
[23:59:11] <heatherw>	 i will fix it
[23:59:44] <jdlrobson>	 heatherw: so in terms of http://www.mediawiki.org/wiki/File:Mobile_Contact_F2.png I'm puzzled by 2 things 1) how do I get to this page in the first place - is it via a link in the contact page?