[00:00:02] second I'm saying that I think this should be part of the contact page rather than a separate screen [00:00:06] jdlrobson: also, it looks phil commented on the discussion page about the 'factual errors' thing: http://www.mediawiki.org/wiki/Talk:Mobile_design/Contact#Factual_Errors [00:00:07] e.g. a heading saying Article feedback [00:01:07] okay [00:01:34] that's more about the emailing though awjr - my main worry is the redirect [00:01:35] all of the sections lead to a "new page" or a it looks like it, as the title changes to what they selected. [00:02:21] unless we change it now based on what you are saying [00:02:56] let me know something up quickly [00:03:03] *knock [00:03:11] i.e. you choose article feedback you get http://www.mediawiki.org/wiki/File:Mobile_Contact_F2.png you choose technical problem you get http://www.mediawiki.org/wiki/File:Mobile_Contact_I1.png [00:03:21] awjr: let me know when your ready to talk about contact us [00:03:31] tfinc: we're already talking about it :) [00:04:07] spiffy [00:04:19] then grab me after you guys finish hashing things out [00:04:25] i want to get an idea of the scope [00:04:37] so that we understand how much time its going to take and wether its worth to do it now [00:04:54] tfinc: jdlrobson was proposing a significant scoping back for an initial release [00:05:47] rather than release with the emailing functionality, just release with the form writing to a wiki page (like it does now), but re-styled, being newly handled by a SpecialPage, and offering the different categories [00:06:56] awjr: i think the email functionality was pretty important for Philippe [00:07:04] he is the one who dictated most of the requirements here [00:07:42] philinje: for sure - we were just talking about an initial release. we would build the rest of the functionality in later/as we go [00:08:17] awjr has a good point and it fits nicely into what i've been saying. understanding how many iterations it'll take to get to our first release [00:08:20] ok, but how much later is later? [00:09:31] philinje: we'll be able to do an initial release much faster if we scope it back - it may take just as long to do an initial release with the functionality as it would to do a secondary release with it if we do an intial one that is scoped back. plus i think we'll have a better chance of getting it right and mitigating any other weirdness we discover as we build out these changes [00:10:12] if by release we are talking about a beta, and the final release is with the full functionality, that's fine [00:10:22] part of the problem here is that there is still ambiguity and uncertainty about some of the features in the spec [00:10:47] which we're getting hung up on and is slowing down getting this out, but if we can do it more piecemeal, i think we'll get something of value out quicker [00:10:52] in my experience the smaller chunks you do at a time the quicker you get to the end result [00:10:59] and usually the result is better [00:11:04] +1 [00:11:07] as it gets more feedback from earlier exposure [00:11:27] and i know heatherw will have lots of feedback when it goes live ;-) [00:11:48] i still have some from what is up there now :) [00:11:57] again, if we are talking about betas, that's ok - in fact, it might be better for another reason - we don't trigger the email workflow with errors [00:13:05] jdlrobson: was there a question about keeping things on one page, like expanding a form underneath each item? [00:13:35] awjr: I was thinking a little bit about the email handling [00:14:19] yes philinje just knocking something up [00:14:21] awjr: I think it might make sense to write it to a local database as a queue and have a job that pulls the messages and emails them in bulk [00:15:23] preilly makes sense [00:15:32] please email me any other questions as I have to go offline for a while, or let me know if we should have a Skype call tomorrow [00:16:19] i like the idea of keeping things on one page [00:17:02] preilly i think that's a good idea and potentially even necessary depending on the volume [00:17:18] awjr: yeah [00:17:23] but will definitely take more dev time [00:19:06] tfinc now's probably a good time to talk about scope - esp since phil just left im not sure how much more we'll be able to get hashed out [00:19:13] ok [00:19:24] so heatherw awjr this is what i meant - > http://mobile-geo.wmflabs.org/w/index.php?title=Main_Page&mobileaction=leave_feedback#section_1 [00:19:30] irc/voice/other ? [00:19:40] tfinc: semaphore? [00:19:57] LOLSpeak? [00:20:08] irc or voice is fine with me, jdlrobson do you have a preference? [00:20:31] nope [00:20:38] New patchset: preilly; "Remove temporary hack to allow for testing on localhost" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/4147 [00:20:49] lets do Skype then [00:21:07] k [00:24:27] jdlrobson: i am not sure i am seeing what i am supposed to see at your link [00:36:54] tfinc: http://en.wikipedia.org/wiki/Wikipedia:Mobile_Extension_Feedback [00:37:07] http://es.wikipedia.org/wiki/Wikipedia:Mobile_Extension_Feedback [00:52:06] * tfinc looks over the contact us page to see what needs to be modified [00:53:14] heads up - i will be heading to bed soon [00:53:18] jdlrobson: k [00:54:15] jdlrobson: wimp [00:54:21] jdlrobson: it's 1:53am Tuesday (BST) - Time in London, UK [00:54:39] I need to be up for 9am to work some more... what's wimpish about that :P [00:55:27] so tfinc awjr i think this is what you need from me -> http://mobile-geo.wmflabs.org/w/index.php?title=Main_Page&mobileaction=leave_feedback&r=313&useformat=mobile - I'll work with heatherw, lindsey and anyone else interested to deal with styling, copy text and error handling (for which I'll need some server side changes from awjr) [00:55:27] jdlrobson: ha ha [00:55:34] jdlrobson: YuviPanda would make it work [00:55:46] YuviPanda: is like a duck he always seems to be awake [00:55:54] TIL that ducks are always awake [00:56:02] hah [00:56:08] (citation needed) [00:56:40] why is mobile-geo sooo slow ? [00:56:52] also, apparently ducks sleep with only half their brains - other half is awake (http://www.straightdope.com/columns/read/1333/can-one-side-of-a-ducks-brain-sleep-while-the-other-half-is-awake) [00:56:58] i donnnn'tt know tfinc - I thought I setup memcached [00:57:04] asked preilly to look at it [00:57:14] preilly: what can we do to make it faster? [00:57:22] tfinc: MAGIC [00:57:29] yep and YuviPanda ducks trust no one - always one eye open [00:57:32] ah [00:57:40] tfinc: I'll look at it again [00:57:41] i know its a virt so i'm not expecting to benchmark anything but its slow as hell as is [00:57:41] ducks have lunch and dinner, I guess? :D [00:57:42] jdlrobson: https://gist.github.com/5cfb8084bf35633a96d1 [00:57:44] is what i've [00:57:55] jdlrobson: it essentially converts sections into a tree [00:58:04] jdlrobson: how will "Please enter an email address." look on a mobile device? [00:58:06] sweet YuviPanda [00:58:11] jdlrobson: my plan now is to use a template to turn this Page object into html [00:58:19] beautiful preilly with unicorns and rainbows [00:58:21] like, an actual js template :) [00:58:41] unicorns! [00:58:55] 'Would you be kind enough to bequeath us with your electronic mailing address, sir?' [00:59:13] jdlrobson: think it'll be usable for MFE at any point? [00:59:14] preilly: i didn't know "This homepage needs to be configured. Read more here" was going out .. nice [00:59:26] when can we have English (RP) as a recognised wikipedia language? [00:59:49] jdlrobson: https://ang.wikipedia.org/wiki/H%C4%93afods%C4%ABde [01:00:07] too old, perhaps :) [01:01:04] so YuviPanda the main use case I have for that code at the moment is my html5 history experiments [01:01:08] trying to create a mobile page for http://ms.wikipedia.org/wiki/Laman_Utama is no fun [01:01:23] jdlrobson: ah [01:02:14] eek tfinc what happened to the create page link that was there before :-( [01:02:33] jdlrobson: what do you mean ? [01:02:49] well when I go to that page I see the configure homepage message [01:03:34] jdlrobson: which makes sense as ms wiki doesn't have a configured mobile main page [01:03:43] but that should only show on the home page [01:04:00] or is that the homepage? [01:04:04] * jdlrobson confused [01:04:08] that is the homepage [01:04:33] ok phew i thought i was losing it:-) [01:04:39] jdlrobson: go to bed [01:04:43] lol [01:05:01] Laman Utama === Home Page [01:05:16] in Malay [01:06:14] yep I've got that now preilly. my brain was just a bit slow to catch up and I misread tfinc's 'is no fun' and YuviPanda's 'ah' [01:06:28] got it [01:06:36] also, I got scared a bit too [01:06:37] see i didn't even get the sarcasm there [01:07:30] ha ha heh heh [01:07:38] GO TO BED <- jdlrobson [01:08:17] okk... [01:08:20] SLEEP(100) [01:08:25] that's usually the line for me [01:12:24] heatherw: ok … lets chat [01:23:02] I thought that jdlrobson was a javascript guy so I wonder why he didn't use setTimeout [01:23:41] preilly: setTimeout doesn't block [01:51:03] New patchset: preilly; "Stylize file and remove unused code" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/4148 [01:51:14] http://ms.m.wikipedia.org/ exists now [01:51:36] * tfinc debates about cleaning up the styling [01:51:45] eh .. we can do it later [02:05:25] New review: Demon; "Needs rebasing anyway to make this merge, so might as well fix mf-feedback.js while we're at it." [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 0 C: -2; - https://gerrit.wikimedia.org/r/3963 [02:07:21] New review: Demon; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4133 [02:07:24] Change merged: Demon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4133 [02:09:05] okay, a nice small chunk of API work done [02:09:08] good night everyone [02:11:02] New review: Demon; "One minor bit of trailing w/s still. Is also going to need rebasing once the parent is fixed." [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 0 C: -1; - https://gerrit.wikimedia.org/r/3964 [02:32:31] open /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Applications/iPhone\ Simulator.app/ [03:04:47] can someone test the speed of http://mobile-geo.wmflabs.org/w/index.php/Special:Random [11:20:18] New patchset: Jdlrobson; "separate select menu into sections, using mailto links for article feedback" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4156 [12:01:38] New patchset: Jdlrobson; "removed minified javascript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4158 [13:12:14] [WikipediaMobile] jdlrobson pushed 4 new commits to master: http://git.io/byp05g [13:12:14] [WikipediaMobile/master] Added migration code for PhoneGap database issues - YuviPanda [13:12:14] [WikipediaMobile/master] Updated CHANGELOG and bumped version number - YuviPanda [13:12:14] [WikipediaMobile/master] Added comments clarifiying data migration - YuviPanda [13:12:37] Project WikipediaMobile - Nightly builds build #268: SUCCESS in 9.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/268/ [13:12:38] * yuvipanda: Added migration code for PhoneGap database issues [13:12:38] * yuvipanda: Updated CHANGELOG and bumped version number [13:12:39] * yuvipanda: Added comments clarifiying data migration [13:51:13] jdlrobson: heya [13:54:44] hey YuviPanda [13:54:47] just commenting on 192 [13:56:19] done [13:57:02] so YuviPanda https://github.com/wikimedia/WikipediaMobile/pull/193 looks fine apart from one comment and the fact I just trust you on java related stuff [13:57:27] jdlrobson: yes, will clarify that [13:57:34] also what is the state of https://github.com/wikimedia/WikipediaMobile/pull/173 [13:57:45] i'm wary it's quite an old pull request [13:57:52] jdlrobson: I did make a comment above (fixing languages to confirm to wikipedia's language codes) [13:57:53] and there has been no feedback [13:58:02] jdlrobson: hmm, let me poke kelson on it and see if he wants to take a look [13:58:20] i'm weary of pulling support for qt in and letting it rot [13:58:22] ahh yes I see [13:58:32] is it possible we can link to an article that explains wikipedia language codes [13:58:34] like how we have winphone bits but they don't work [13:58:40] jdlrobson: yeah, will clarify [13:58:45] great [13:59:04] brb just got to knock up some lunch [13:59:13] k [14:12:57] back btw [14:24:25] hey guys, any API feedback? [14:35:25] MaxSem: is 'prop' disregarded with section=all [14:35:27] or am I missing something [14:38:02] prop=sections means whether to return information about not requested sections [14:38:46] with sections=all you're requesting information about all sections [14:38:50] MaxSem: hmm, essentially prop=normalizedtitle doesn't seem to do anything [14:39:43] it is returned only if you provided a non-canonical title [14:40:24] ah! [14:40:24] i thought it handled redirects, etc too [14:40:44] MaxSem: also, mobileview doesn't seem to do anything for Main_Page [14:41:14] should it? [14:41:56] now there's two of you [14:42:31] i'm real [14:42:36] the other one is the network ghost [14:42:52] it is returned only if you provided a non-canonical title [14:42:53] [20:09:59] ah! [14:42:53] [20:10:15] i thought it handled redirects, etc too [14:42:54] [20:10:35] MaxSem: also, mobileview doesn't seem to do anything for Main_Page [14:43:03] [18:41:16] should it? [14:43:13] good question. [15:08:23] [18:40:26] i thought it handled redirects, etc too [15:08:43] MaxSem: that was in reference to 'normalizedtitle' [15:09:15] it actually handles redirects now, unless you've provided redirect=no [15:09:39] MaxSem: hmm, so if it was a redirect, i'd get a normalizedtitle back? [15:09:55] MaxSem: wouldn't it be consistent to always send back a title if prop includes normalizedtitle [15:09:56] ? [15:10:00] you'll get "redirectedfrom" [15:10:52] I get "redirected": "Chennai", [15:10:53] I thought it would be a waste of bandwidth. a small waste but stil.. [15:11:23] right, "redirected" [15:11:42] MaxSem: hmm, in what cases would normalizedtitle actually turn up? [15:11:46] can you give me an example? [15:12:27] api.php?action=mobileview&format=json&page=foo [15:12:28] vs. [15:12:31] api.php?action=mobileview&format=json&page=Foo [15:13:02] also Unicode normalisation, etc [15:13:18] aah [15:13:49] damn, I'm even more determined that we should deploy new APIs on labs first [15:20:16] New patchset: Jdlrobson; "increase size of wikipedia logo in footer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4171 [15:20:17] New patchset: Jdlrobson; "increase font size of links at bottom of footer and color of more/less" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4172 [15:20:38] MaxSem: I'm reworking the code a bit to make pointing to random domains easier. [15:20:49] sehr gut [15:24:31] [WikipediaMobile] jdlrobson pushed 2 new commits to master: http://git.io/n5GRSw [15:24:31] [WikipediaMobile/master] Added clarification on language fix - YuviPanda [15:24:31] [WikipediaMobile/master] Merge pull request #193 from yuvipanda/bug35650 - Jon Robson [15:24:44] Project WikipediaMobile - Nightly builds build #269: SUCCESS in 6.7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/269/ [15:24:44] * yuvipanda: Make default language for search be the system's default locale [15:24:45] * yuvipanda: Added clarification on language fix [15:41:12] jdlrobson: mobilefrontend.init does a bunch of stuff I don't seem to need [15:41:23] * jdlrobson looks [15:41:26] like the desktop view and language stuff [15:41:37] i'm thinking i should just use individual toggles? [15:42:18] https://github.com/wikimedia/WikipediaMobile/blob/master/assets/www/js/mobilefrontend.js [15:42:31] you're not using the default MobileFrontend code you're using that stub ^ [15:43:14] jdlrobson: aaah, right. I changed it to default in a commit :D [15:43:16] will change back [15:44:29] jdlrobson: thoughts on making *all* sections expandable? [15:44:32] rather than just h2s? [15:44:59] it looks ugly [15:45:09] check my mail about the use of history api [15:45:42] (subject HTML history interface / api use for MobileFrontend) [15:46:07] i think the useful line was "It enables sub section expansion for which the existing design doesn't really seem to work" [15:48:39] jdlrobson: hmm [15:49:56] do you see what i mean? [15:51:11] jdlrobson: yes, it was quite ugly on my phone [15:51:18] so i like the idea [15:51:25] but i don't think it's worth it right now [15:51:39] jdlrobson: 'threading' on mobile phones itself is quite something [15:51:39] to be fair most sections tend to be small enough anyway [15:53:11] YuviPanda: this bug is for the app right not MobileFrontend ? https://bugzilla.wikimedia.org/show_bug.cgi?id=35616 [15:53:31] jdlrobson: it's actually for both [15:53:48] i find the discussion very confusing [15:53:56] but as phil said, mobile web allows a way to switch to desktop view and see history [15:53:58] while the app doesn't [15:54:29] true [15:54:34] ok [15:54:42] so it's not so critical [15:55:23] jdlrobson: depends on whom you ask :) [15:56:14] sure ok i understand this now anyway [16:03:52] jdlrobson: also, #search in app.css conflicts with #search in beta_common.css [16:03:57] should i just change order [16:04:02] or do we want to do something else? [16:04:24] hmm, even changing order might not fix this [16:04:36] it has properties that aren't redefined in app.css, so we will have issues [16:04:44] jdlrobson: how do we deal with such conflicts? [16:04:48] make the css more specific? [16:23:36] jdlrobson: ^ [16:35:29] hmm, looks like i need to do nesting myself anywy [16:35:53] New review: Reedy; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4158 [16:35:55] Change merged: Reedy; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4158 [16:36:58] dinner [16:37:01] or something resembling it [16:37:02] brb [16:54:56] YuviPanda: "This version has been approved and is being held by the developer" :D [16:55:03] 3.1 is apple approved [16:56:18] SWEET [16:56:46] i'll release it once i get into the office [16:57:06] k, commuting in [17:13:49] flyingclimber: preilly are you guys about? [17:14:50] and/or MaxSem and jdlrobson? [17:14:56] * MaxSem [17:15:19] wassup? [17:16:05] Just CC'd you on a bug, see emails [17:16:30] on it [17:19:27] Cheers [17:22:47] tf:) [17:22:51] tfdamn [17:23:38] jdlrobson: thoughts on CS overrides? [17:24:31] you mean CSS !important ? [17:24:51] jdlrobson: well, more like conflicts between app's UI elements and beta ui elements [17:24:55] jdlrobson: in this case, #search [17:25:18] jdlrobson: beta_common.css has a left property for it, while app.css doesn't. [17:25:30] jdlrobson: other properties cancel out (overriden by app.css), but left isn't [17:25:36] jdlrobson: ideally, i'd want them to have different IDs [17:25:42] or the CSS rules to be more specific [17:25:46] so this problem doesn't happen [17:25:58] can't you do left: auto ? [17:26:03] * MaxSem runs blame [17:26:10] jdlrobson: I *can*, but I think I shouldn't. [17:26:15] can't we make the selectors more specific? [17:26:21] .mf-container #search [17:26:25] for example? [17:26:32] #mf-container #search even [17:26:33] well ideally we should have the same css file for both app and MFE :) [17:26:35] s/even/rather/ [17:26:39] same look and feel etc [17:26:45] jdlrobson: ah [17:27:03] I agree that the web beta looks sweeter than the app :) [17:27:12] but i guess we are some time off that [17:27:19] (we need new nav at least I guess) [17:28:05] I think we discussed separating the css [17:28:12] Reedy, will you be able to sync it once I commit a fix into Git? [17:28:26] Sure [17:28:31] so section related css goes into a separate css file and search into another [17:28:51] MaxSem: you could attach a patch to the bug, I can fix the site and then we can commit it etc.. [17:28:57] jdlrobson: right. [17:29:04] jdlrobson: when do you think that 'separation' can happen? [17:29:11] as soon as we have ResourceLoader [17:29:29] ah [17:29:37] annd… how soon is that? :D [17:29:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=34325 [17:30:00] is it beta_ only that needs this separation or both? [17:30:12] jdlrobson: i'm currently using beta_common [17:30:17] k [17:30:42] i'm hoping I can get ResourceLoader for css in by end of week, then hopefully things can move quickly (you may need to poke me again to remind me) [17:31:00] jdlrobson: so, right now I simply hack around whatever conflicts I find? [17:31:09] * YuviPanda doesn't like this :( [17:31:13] ergg yeh that sucks [17:32:01] send me a patch of the changes you'd like and I'll see what i can do [17:32:08] is it just search? [17:32:25] jdlrobson: currently just search [17:32:27] (you can assume MFE will have a class mfe on body [17:32:43] jdlrobson: so [17:32:55] #search to .mfe #search should do the trick [17:32:57] for me [17:33:00] yeh that sort of thing [17:33:03] jdlrobson: do you want a full patch? [17:33:03] ok [17:33:20] if you send me a patch with all the bad definitions i'll make it happen tomorrow [17:33:30] I've got to run now but will leave my laptop on and come back later for anything urgent [17:33:35] jdlrobson: cool [17:35:18] greetings all [17:35:20] YuviPanda: you around? [17:35:24] tfinc: yes [17:35:26] saw the approval [17:35:28] \o/ [17:35:30] :D [17:35:37] just make sure that people *know* they will lose saved pages [17:35:56] i'm adding this to the release notes: "NOTE: This is a brand new codebase and will delete your old history and bookmarks. If you do not want this to happen please do not upgrade. We apologize for any inconvenience." [17:36:15] good enough for me [17:37:00] YuviPanda: k. i'm going to look over the copy and release this [17:37:07] \o/ [17:37:12] YuviPanda: lets schedule the blog post for the afternoon [17:37:19] coool [17:37:20] after we get a review or two :D [17:37:47] granted i should check the communications calendar before i saw were going to test today [17:37:55] also while it's on my mind - could we make MobileFrontend have special urls for the beta - it makes it easier to test e.g. http://en.m.wikipedia.org/wiki/beta/San_Francisco or even http://en.m.wikipedia.org/wiki/San_Francisco?usebeta=yes [17:38:01] comment: I believe there's UCOSP standups today, though I am not certain if it's in 20 minutes or 3:20 minutes. [17:38:42] oh wow .. the blog is busy today [17:38:43] tfinc: yes [17:38:44] YuviPanda: https://office.wikimedia.org/wiki/Communications/Calendar [17:38:56] s/today/this week/ [17:39:09] but its far too light on tech [17:39:13] it's busy this week [17:39:13] yeah [17:39:15] we can fix this [17:39:17] i see 0 tech [17:39:30] :) [17:42:19] YuviPanda: go ahead and it to the calendar [17:42:54] today is the third. [17:42:55] right [17:43:19] * YuviPanda looks up the title [17:43:27] Reedy, patch attached [17:43:57] YuviPanda: http://etherpad.wikimedia.org/Wikipedia-iOS [17:44:03] lets update the description [17:44:48] i could just use the same copy as android [17:45:34] i like how the iOS app has a line for developers [17:46:29] tfinc: updated calendar [17:46:32] thanks [17:47:50] i hate that we can't change the name [17:48:18] YuviPanda: what do you think about the dev line in the description ? [17:48:35] the github line? [17:48:41] that whole line in general [17:48:44] we don't have it here https://github.com/wikimedia/WikipediaMobile [17:49:51] for the love of ... "Good but Great app but it needs some improvements like: 1- An option to save articles to read them offline." .. do people just not read the features ?!? [17:50:35] :D [17:50:41] people don't read, news at 11 [17:51:02] people still watch news @ 11 ? [17:51:20] not sure, it's been a few years since I've watched any TV [17:51:30] i haven't watched broadcast tv in years [17:51:36] MaxSem: In Soviet Russia the news watches you at 11 [17:51:50] it's amazing how people are able to put up with Ads [17:51:54] and crappy ones at that [17:52:28] YuviPanda, my brother sells "Turn on your brain, throw your TV away" T-shirts [17:52:40] I bought one from him [17:53:13] :D [17:53:18] it assumes you have a TV [17:53:48] anyone who has a computer can watch IPTV [17:54:55] YuviPanda: android app listing has been updated with dev line [17:55:06] woohoo [17:55:13] it'll take a couple of minutes for the market to pick it up [17:55:21] MaxSem: is "Bug 35673 - XSS vulnerability in mobile search" fixed now? [17:55:43] plugged on live site, going to push a git fix [17:55:44] YuviPanda: any last changes to the text for iOS ? [17:55:52] i'm going to send it to amit as well [17:55:54] tfinc: checking one last time [17:57:26] okay, so just switching to Sanitizer::encodeAttribute is the fix? [17:57:31] MaxSem Reedy [17:57:34] ^^ [17:58:01] preilly, you have to take into acoount what will you use escaped text for [17:58:26] New patchset: MaxSem; "Revert and redo r114191 aka 3f791ab2 - introduces XSS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4191 [17:59:09] MaxSem, Reedy: Is Sanitizer::encodeAttribute multibyte character safe? [17:59:25] escapeJsString() is for escaping data to be included in JS, it's not suitable for HTML [17:59:29] should be [17:59:58] Reedy, can you unhide the bug now? [18:00:10]