[00:00:02] YuviPanda: does anybody in #phonegap have any ideas? [00:00:21] YuviPanda: or, at least UI anomalies? [00:00:23] preilly: yes, am talking with devgeeks there to see if I could debug it [00:00:34] * tfinc wonders when we'll see arizona bot in here censoring what awjr says [00:00:43] preilly: UI anomalies *might* be caused by https://issues.apache.org/jira/browse/CB-330 [00:00:44] or not [00:00:48] don't know yet [00:00:49] tfinc: don't tempt me [00:00:55] http://www.technolog.msnbc.msn.com/technology/technolog/arizona-law-would-censor-internet-631407 [00:01:45] tfinc: I feel like awjr always tries to, "terrify, intimidate, threaten, harass, annoy or offend" me. [00:02:13] perhaps preilly should be the new AZbot [00:02:42] awjr: did you see ArcherBot? [00:02:51] preilly: ! no [00:03:11] New patchset: awjrichards; "(bug 35425) Respect " [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4235 [00:03:12] New patchset: awjrichards; "don't assume existence of #content" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4236 [00:03:13] New patchset: awjrichards; "action=mobileview improvements * Optionally follow redirects * Optionally return normalized page title" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4237 [00:03:13] New patchset: awjrichards; "Remove dismiss zero banner code" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4238 [00:03:14] New patchset: awjrichards; "update footer template to mimic desktop site html" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4239 [00:03:15] New patchset: awjrichards; "Support for action=mobileview§ions=all" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4240 [00:03:16] New patchset: awjrichards; "Fixing language handling in MobileFrontend.body.php to use appropriate language fetching method depending on mw 1.19 or mw 1.20 - previously threw strict errors" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4241 [00:03:16] New patchset: awjrichards; "Finishing fix in previous commit to get all cases of getLanguageName()" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4242 [00:03:17] New patchset: awjrichards; "Added an option to return sections without tags" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4243 [00:03:18] New patchset: awjrichards; "removed minified javascript" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4244 [00:03:19] New patchset: awjrichards; "Revert and redo r114191 aka 3f791ab2 - introduces XSS" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4245 [00:03:19] New patchset: awjrichards; "Remove dependency on output buffering and replace with rudimentary skin" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4246 [00:03:46] archer [00:03:46] : I'm gonna pain you dearly Woodhouse, when I peel all your skin off with a flencing knife, sew it into Woodhouse-pajamas, and then set those pajamas on fire! [00:03:54] hhahaahah [00:04:19] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4235 [00:04:22] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4235 [00:04:42] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4236 [00:04:44] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4236 [00:05:01] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4237 [00:05:05] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4237 [00:05:13] archer [00:05:14] : Sterling: How do you say "The Hulk" in Spanish?Ramone: "El Hulk."Sterling: Gay.Ramone: What? We don't have a word for "Hulk."Sterling: Do you have a word for gay?Ramone: "Gay."Sterling: Gayer. [00:05:31] archer [00:05:32] : Malory: Have I made myself clear?Sterling: You're looking for the word yes.Malory: Yes.Sterling: Then, yes. [00:05:40] lulz [00:05:51] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4238 [00:05:54] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4238 [00:06:17] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4239 [00:06:20] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4239 [00:06:38] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4240 [00:06:41] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4240 [00:07:04] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4241 [00:07:06] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4241 [00:07:47] terry chay [00:07:48] Fact: Dreamworks added those scenes to Shrek in hopes that Terry Chay would one day use them in a talk [00:07:58] hahaha [00:08:10] terry chay [00:08:11] Fact: Terry Chay beat the Internet... with only one quarter [00:08:16] tychay [00:08:16] Fact: Security is low priority for Terry Chay because he knows the internet's got his back[ups] [00:08:28] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4242 [00:08:30] sterling archer [00:08:30] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4242 [00:08:31] : Sterling: Do you not see me rocking this chiseled slab of hard man body? I mean, come on! Are you gay or not?Ramone: I am, but you—you are so not my type.Sterling: Hey, I am everybody's type. [00:08:55] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4243 [00:08:58] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4243 [00:09:02] archer [00:09:02] : Sterling: Conway! What the shit, man?!Conway: What? Schmeck was a traitor.Sterling: Yeah, now he's all over my $400 custom shirt.Conway: Well, I'll buy you a new one. Now grab the plans before it's too late!Sterling: It's already too late. Because it's already soaked into the fibers, dumbass! This is linen! [00:09:32] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4244 [00:09:34] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4244 [00:09:39] terry chay [00:09:39] Fact: When recruiters call Terry Chay, he ends up hiring THEM [00:09:53] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4245 [00:09:55] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4245 [00:10:27] archer [00:10:28] : Cyril, I paid her, I get to carry her corpse. [00:10:50] New review: awjrichards; "Sync'ing from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4246 [00:10:53] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4246 [00:11:04] awjr: channel spammer! [00:11:31] gerrit made me do it [00:12:12] office wifi fail? [00:22:04] awjr: http://www.foxnews.com/us/2012/04/02/federal-agents-raid-california-marijuana-university/ [00:22:22] preilly yeah i heard about that yesterday [00:22:46] i used to know a guy who claimed to be valedictorian of oaksterdam u [00:23:37] strange guy. bit of a burnout... [00:24:02] tfinc: slightly closer. Now the app on my iPod fucks up in the same way as the one from the App Store! [00:24:06] so I can actually debug [00:24:26] YuviPanda: well, that's good news! [00:24:48] a perfectly preilly voiced 'well, that's good news' automatically popped into my head. [00:24:49] wow [00:26:21] YuviPanda: ha ha ha [00:28:53] New patchset: awjrichards; "Adds rudimentary meta-validation logic; populates MobileFeedbackForm properties with form input values on submit;" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3975 [00:28:54] New patchset: awjrichards; "Updating feedback form id to 'mf-feedback-from' for clarity" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3963 [00:28:55] New patchset: awjrichards; "Make validate method return true for now" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3965 [00:28:56] New patchset: awjrichards; "Follow up to Change-Id: Ia065e1f2, fixing static call to non-static method" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3948 [00:28:56] New patchset: awjrichards; "Set 'contact us' title in the special page, add corresponding i18n message" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3964 [00:28:57] New patchset: awjrichards; "Added stub 'on success' handling for successful form submissions; Added LeaveFeedbackScuccessTemplate for displaying HTML on success;" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3966 [00:28:58] New patchset: awjrichards; "Added basic validate method" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4224 [00:28:58] New patchset: awjrichards; "Added todoto make 'execute' method of special page behave in a safer manner" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4222 [00:28:59] New patchset: awjrichards; "Added method and property documentation for MobileFeedbackForm class" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4225 [00:29:00] New patchset: awjrichards; "move from singular form fields as properties to a single property containing an array of form field metadata; update setFormFieldValuesByArray to reflect change" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4223 [00:29:01] New patchset: awjrichards; "POC for using form field properties to hold meta-information about form fields (eg required, validation callback, error message, value)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4221 [00:29:05] holy god [00:29:11] not what i meant to do >_< [00:29:24] git confuses me. [00:30:36] actually maybe it is what i meant to do. [00:35:26] New patchset: awjrichards; "Added stub 'on success' handling for successful form submissions; Added LeaveFeedbackScuccessTemplate for displaying HTML on success;" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3966 [00:38:10] tfinc: fixed :) [00:38:32] YuviPanda: what was it? [00:39:00] tfinc: so, it was the exact same thing as what broke android (paths being changed) [00:39:07] except that with Android, it was the PhoneGap devs who changed the path [00:39:11] while here, it is Apple that changed the path [00:39:51] so, app was trying to read the settings from older path [00:39:58] (and write as well) [00:40:01] and getting permission denieds [00:40:41] tfinc: and the crashing was apparently because the way you test it is not from XCode, but you archive -> export -> rename to have the same name -> use iTunes [00:40:54] lovely [00:46:41] let me know when your ready to build [00:47:02] * tfinc is in a meeting about mobile nav  [00:49:09] tfinc: ok [01:00:51] New patchset: awjrichards; "Added validation for edittoken handling; added method to write form data to specified wiki page; integrated method with onSuccess()" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4249 [01:00:52] New patchset: awjrichards; "Adds rudimentary meta-validation logic; populates MobileFeedbackForm properties with form input values on submit;" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3975 [01:00:53] New patchset: awjrichards; "Updating feedback form id to 'mf-feedback-from' for clarity" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3963 [01:00:54] New patchset: awjrichards; "Make validate method return true for now" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3965 [01:00:54] New patchset: awjrichards; "Set 'contact us' title in the special page, add corresponding i18n message" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3964 [01:00:55] New patchset: awjrichards; "Added stub 'on success' handling for successful form submissions; Added LeaveFeedbackScuccessTemplate for displaying HTML on success;" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3966 [01:00:56] New patchset: awjrichards; "Added basic validate method" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4224 [01:00:56] New patchset: awjrichards; "Added todoto make 'execute' method of special page behave in a safer manner" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4222 [01:00:57] New patchset: awjrichards; "Added method and property documentation for MobileFeedbackForm class" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4225 [01:00:58] New patchset: awjrichards; "move from singular form fields as properties to a single property containing an array of form field metadata; update setFormFieldValuesByArray to reflect change" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4223 [01:00:59] New patchset: awjrichards; "POC for using form field properties to hold meta-information about form fields (eg required, validation callback, error message, value)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4221 [01:14:07] tfinc: false dawn. That just appeared to fix it, didn't actually fix it [01:14:14] k [01:14:23] i'm changing location, will be back online in ~30 mins [01:14:26] cya on the other side [01:50:53] * YuviPanda checks logs [01:51:10] nothing. [01:51:21] yup [01:51:33] this has been the most expensive bus ticket i've bought [01:51:40] coding from a bus after a while [01:51:41] wheee [01:51:51] * YuviPanda goes back to fixing iOS [01:52:03] 'fixing' [01:52:08] err [01:52:14] Fixing the Wikipedia App for iOS [01:53:02] [01:59:52] fellow nerd on the bus! [01:59:54] has an iPad3 [02:00:01] and a kickass pair of headphones [02:00:02] nice [02:04:56] hmm [02:04:58] http://bm.m.wikipedia.org/wiki/Ny%C9%9B_f%C9%94l%C9%94 [02:05:02] try to switch to the desktop view [02:05:05] it won't work [02:05:13] as it tries to go to bwikipedia.org [02:05:23] aha [02:05:25] regex fail [02:05:25] :D [02:05:40] it's removing the first m. it comes across :) [02:05:57] same thing happens with http://am.wikipedia.org/wiki/ዋናው_ገጽ [02:06:21] awjr_away: ^^ [02:07:18] filing a bug [02:10:26] ok filed: https://bugzilla.wikimedia.org/35686 [02:10:33] i noticed while setting up a new zero main page [02:11:00] these persistent cookies are driving me insane [02:11:45] * YuviPanda notes that sticky cookies are driving tfinc insane [02:23:29] tfinc_: i've a fix [02:23:32] that works [02:23:38] pushing [02:23:54] thats better then the last fix that didn't work ;) [02:23:59] what did you find ? [02:24:21] tfinc_: slight modification to the fix somsone else on #phonegap did [02:24:28] due to the fact that we modify the UserAgent [02:25:55] tfinc: ^ [02:25:57] err [02:25:59] k [02:26:02] pushing [02:26:12] [WikipediaMobile] yuvipanda created v3.1.1-iOS (+1 new commit): http://git.io/oNQm1w [02:26:12] [WikipediaMobile/v3.1.1-iOS] Move WebKit settings to proper location. - YuviPanda [02:26:15] tfinc: ^ [02:26:25] Project WikipediaMobile - Nightly builds build #270: SUCCESS in 6.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/270/ [02:26:25] tfinc: do you want to test and make a release? [02:26:35] sure [02:26:51] tfinc: okay, so first you need to build our *older* iOS app [02:27:06] archive it, sign it, make it into an IPA [02:27:15] make sure it is named 'Wikipedia Mobile.ipa' [02:27:28] next, pull this branch (v3.1.1-iOS) [02:27:35] build, archive, make into IPA [02:27:41] it also *must* be named Wikipedia Mobile.ipa [02:27:51] the file name is the only important thing [02:28:00] tfinc: then, you first sync the older iOS app to the device [02:28:03] open it, etc [02:28:10] then sync the newer IPA [02:28:14] this will simulate an 'upgrade' [02:28:19] and you can figure out how that is like [02:29:10] i've also pushed a branch v3.1-iOS if you want to test v2.x -> v3.1 -> v3.1.1 [02:29:36] tfinc: ^ [02:30:30] thats quite the list [02:30:35] let me start on that [02:30:56] yeah [02:30:56] figuring that out took me longer than actually fixing it [02:31:07] esp. the 'name them the same' bit [02:31:12] sigh [02:31:51] tfinc: will attempt to be fully connected and awake, but might encounter intermittent issues with both. Just a fyi [02:32:29] k [02:35:07] tfinc: do let me know how the testing goes [02:37:06] preilly: this is the router that i use : http://www.buffalotech.com/products/wireless/wireless-n-routers-access-points/airstation-highpower-n600-gigabit-dual-band-wireless-router-wzr-hp-ag300h/ [02:37:25] tfinc: thanks! [02:39:00] YuviPanda: it's 8:08am Wednesday (IST) - in Mumbai, Maharashtra, India [02:39:17] 8:09 [02:39:21] ok. first ipa is ready [02:40:13] sorry [02:40:19] 8:10am Wednesday (IST) - in Bengaluru, Karnataka, India [02:40:29] :D [02:40:36] and I'm on a bus [02:40:49] I think I'll be forced to sleep when the bus goes out of 3G range. [02:40:58] hoping tfinc can verify before that :) [02:41:48] tfinc: if I don't seem to be responding, send me an email (to @gmail). That should work even if IRC doesn't. [02:43:10] second ipa is ready [02:46:42] okay, connection too spotty. [02:46:45] ah [02:46:50] tfinc: test! [02:46:54] :) [02:47:00] first ipa is installed [02:47:02] [08:11:46] tfinc: if I don't seem to be responding, send me an email (to @gmail). That should work even if IRC doesn't. [02:47:25] tfinc: cool [02:47:27] k [02:47:33] that's just too meta [02:47:56] yo dawn I heard you like YuviPanda so I put some YuviPanda in your YuviPanda [02:48:04] tfinc: [08:11:46] tfinc: if I don't seem to be responding, send me an email (to @gmail). That should work even if IRC doesn't. [02:48:06] ^ more meta [02:48:55] * tfinc head exposed from the meta [02:49:02] YuviPanda: seems like it works ok [02:49:08] i didn't see any errors [02:49:15] tfinc: check saved pages [02:49:28] tfinc: you might also want to do v2.x -> v3.1 -> v3.1.1 to be sure [02:49:40] v3.1 is from branch v3.1-iOS [02:49:55] tfinc: https://developer.apple.com/appstore/contact/appreviewteam/index.html [02:50:10] saving pages works fine [02:50:35] tfinc: so to test the second thing (v2.x -> v3.1 -> v3..1.1) [02:50:37] uninstall the app [02:50:41] then sync v2.x ipa [02:50:47] open [02:50:50] then sync v3.1 ppa [02:50:51] err [02:50:52] ipa [02:50:53] YuviPanda: i actually want to simulate the failure too [02:50:55] then v3.1.1 iPA [02:51:00] yeah [02:51:01] so [02:51:04] v2.x -> v3.1 [02:51:04] to be certain that this would catch it [02:51:09] will simualate the failure [02:53:30] yeah, i'll just pickup branch v1.1 [02:53:40] tfinc: not v1.1 [02:53:41] oh wait [02:53:46] branch v3.1-iOS [02:54:07] branch v1.1 is actually v1.1.1 [02:54:08] i only see [02:54:09] v3.1.1-iOS [02:54:09] because i'm an idiot [02:54:12] i'll fix that soonish [02:54:19] tfinc: i pushed it a while ago [02:54:36] tfinc: you could do a fetch [02:54:44] wait .. but i built from [02:54:45] v3.1.1-iOS for the first test [02:54:56] where is v3.1 for iOS ? [02:55:04] why can't i just use v1.1 ? [02:55:05] v3.1-iOS [02:55:10] there is such a branch [02:55:25] github was hiding it [02:55:29] because I pushed v1.1.1 (Android) fixes into v1.1 by mistake and haven't fixed that yet [02:55:43] ahh [02:55:46] lets clean that up [02:56:08] tfinc: yeah, will do [02:56:14] tfinc: https://github.com/wikimedia/WikipediaMobile/tree/v3.1.1-iOS [02:56:21] err [02:56:34] https://github.com/wikimedia/WikipediaMobile/tree/v3.1-iOS [02:56:36] tfinc: ^ [02:57:30] [WikipediaMobile] yuvipanda created v1.1.1-Android (+1 new commit): http://git.io/Xpxxvg [02:57:30] [WikipediaMobile/v1.1.1-Android] Added comments clarifiying data migration - YuviPanda [02:57:43] Project WikipediaMobile - Nightly builds build #271: SUCCESS in 6.3 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/271/ [02:59:06] tfinc: branches have beenf fixed. [03:00:20] thanks [03:00:33] so i used your workflow for 2.2.2->3.1 and it DIDN"T break [03:01:15] are you sure you got 3.1? [03:01:16] well [03:01:19] actualy [03:01:20] are saved pages working? [03:01:23] the nav is busted [03:01:26] ah [03:01:27] :D [03:01:30] did the spinner stop? [03:01:34] this is a good thing! [03:01:35] yup [03:01:43] hmm, less broken than usual. [03:01:49] err [03:01:50] no [03:01:52] spinner is not going away [03:01:55] ah [03:01:55] :D [03:01:56] see [03:01:58] just as broken [03:02:07] yup [03:02:10] now let me sync 3.1.1 [03:02:31] ok [03:05:11] random shitty Indian Movie playing in the bus [03:05:14] with loud music. [03:05:15] sigh [03:05:43] no tv b gone ? [03:05:58] unfortunately no [03:06:26] there are about 30 dudes in vests scratching at guitars theey have no idea how to play [03:06:46] this is what I don't like about day buses. they assume people can't sleep and do stupid shit like this [03:07:37] YuviPanda: did you update the app version number in v3.1.1-iOS ? [03:07:45] iTunes is not upgrade it [03:07:50] and detail shows them both as 3.1 [03:08:03] tfinc: nope, let me do that [03:08:54] thanks. i was going crazy trying to figure out why it wasn't updating it [03:09:01] that version bump should do it [03:10:19] tfinc: pushing [03:10:21] latency [03:10:45] pushed [03:10:51] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.1-iOS: http://git.io/yS3d4w [03:10:51] [WikipediaMobile/v3.1.1-iOS] Bumped version number for iOS - YuviPanda [03:11:04] Project WikipediaMobile - Nightly builds build #272: SUCCESS in 6.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/272/ [03:11:04] yuvipanda: Bumped version number for iOS [03:12:42] building [03:13:50] perfect [03:15:01] saved pages seem really slow [03:15:18] tfinc: what device? [03:15:21] tfinc: plus, do they work? :) [03:15:24] iPad2 [03:15:27] they do work [03:15:48] not as bad as when we had debugging enabled but slightly slower [03:16:03] they take 4-5 second to load [03:16:09] hmm [03:16:16] tfinc: file a bug. [03:16:23] while a new page shows up in about a second [03:16:24] sure [03:16:46] tfinc: pushing this to app store? [03:16:53] yes [03:17:01] and then i'm going to fill out the link that preilly sent out [03:17:05] also, can you tweet as well? I don't think DNS likes me now. [03:17:05] to expedite this [03:17:08] k [03:17:17] awesome [03:17:30] YuviPanda: good job figuring this out [03:17:54] :) [03:18:48] do you have a change log for me? [03:18:57] * Fix app so that it actually works [03:18:58] :D [03:19:15] * New Feature: DOES NOT CRASH (this time for real!) [03:19:17] :) [03:19:37] 'We said it wouldn't crash. We lied!' [03:20:00] i'm wondering if we should put in a note that *IF* they see any other issues to uninstall and re-install [03:20:06] so that we can catch any upgrade edge cases [03:20:16] yes [03:20:31] i remember quite a few apps in Android market having such a note [03:20:44] http://etherpad.wikimedia.org/Wikipedia-iOS-3-1-1 [03:22:07] that looks good [03:22:40] brb [03:25:08] tfinc: don't forget to put in keys [03:25:46] thats the beauty of git stash [03:26:49] * tfinc goes to validate the app [03:26:52] it validates! [03:27:21] i do love the line "No issues were found with Wikipedia" <-- as if that was true with our project [03:31:53] tfinc: not sure if you got my message [03:32:00] was asking you to not forget to put in keys [03:32:13] i saw it [03:32:24] i just do that with a git stash apply [03:32:29] ah [03:32:30] cool [03:32:40] YuviPanda: can you verify your Facebook account so that i can add you as a dev [03:32:49] tfinc: will do when not travelling. [03:32:52] k [03:33:08] this bus actuallly has a working power supply. Now I can't justify sleeping. [03:33:23] i need a 16x16 pixel W for facebook [03:33:31] YuviPanda: app has been submitted! [03:33:40] now i just need to fill out the expedited form [03:33:46] :) [03:34:06] do we have a small W laying around anywhere? [03:34:22] no 16x16 usable ones afaik [03:34:40] you might find a 24x24 though, in res/drawable-ldpi [03:35:23] https://github.com/wikimedia/WikipediaMobile/blob/master/res/drawable-ldpi/icon.png [03:36:28] what about 75x75 [03:36:36] i'll pull from mdpi [03:36:44] :) [03:37:33] it looks a bit weird but at least we have an icon [03:38:36] now to write up our sob story to apple [03:44:02] ok .. I've submitted the request [03:47:14] 13:38 < tfinc> now to write up our sob story to apple [03:47:14] 13:38 < tfinc> now to write up our sob story to apple [03:47:17] :( [03:47:22] hey devgeeks [03:47:27] hey [03:47:34] * devgeeks stabs 5.1 for you [03:48:57] thanks devgeeks [03:49:08] we appreciate the directed stabbings [03:49:28] tfinc: You can make one using the svg on commons. [03:49:37] (the 16x16 w) [03:49:42] heh [03:49:57] Amgine: link me to a good one .. one that would work well as a Facebook icon [03:50:08] the app one works but has a black background [03:50:10] [03:56:04] Tfinc: http://upload.wikimedia.org/wikipedia/commons/thumb/5/5a/Wikipedia%27s_W.svg/16px-Wikipedia%27s_W.svg.png [03:56:21] thanks! [03:56:29] can you render a 75x75 while your there [03:56:48] That is actually slightly wrong - it's the Hoeffler version, not the latest Board-approved Libertine version. [03:56:52] Sure, just a moment. [03:57:32] http://upload.wikimedia.org/wikipedia/commons/thumb/5/5a/Wikipedia%27s_W.svg/75px-Wikipedia%27s_W.svg.png [03:58:13] These are slightly shorter than 75px, but they are 75px wide [03:58:48] that works [03:58:49] thanks! [03:58:59] yw [03:59:23] having you generate these made it so that i could respond to contractors wanting to build an S40 app for us [03:59:26] which is really important [03:59:41] all this iOS buzz post release ate up all my free time [03:59:46] now its 9PM and i'm still at work [03:59:53] so anything that i can get help with is much appreicated [04:01:03] hmm .. i don't know what filters Facebook is using but the icons looks like it has no aliasing whatsoever [04:02:06] ugh. [04:05:03] I found the right W, if you want it. Only a few typographic geeks will know. [04:05:42] hehe [04:06:00] sure [04:06:32] moment [04:07:27] http://upload.wikimedia.org/wikipedia/commons/thumb/0/05/Wikipedia%27s_W_%28Linux_Libertine%29.svg/16px-Wikipedia%27s_W_%28Linux_Libertine%29.svg.png [04:07:58] http://upload.wikimedia.org/wikipedia/commons/thumb/0/05/Wikipedia%27s_W_%28Linux_Libertine%29.svg/75px-Wikipedia%27s_W_%28Linux_Libertine%29.svg.png [04:13:41] sadly still looks bad on the Facebook dev site [04:13:43] i'll deal with it later [04:13:49] not important enough for us to spend more time on it [04:14:28] kk [04:14:46] too bad facebook doesn't take svg. [04:19:45] s/facebook/* [04:20:31] tfinc isn't on diaspora... [04:20:53] how is it these days? [04:21:47] awful and getting worse, but then I generally loath SN sites. [04:26:30] then i'll stay away [05:29:59] tfinc: sadness with the desktop URL generation :( i'll dig deeper tomorrow am. [05:30:16] yes, your cookies are too sticky [05:30:20] wow .. did i just say that [05:30:30] ! [05:30:34] :D [05:30:42] someone get this guy a pamphlet [05:31:01] we need them to *only* trigger when someone tabs mobile|deskstop [05:31:04] and not any other time [05:31:18] currently any time i see a m. view it'll set it [05:31:18] what other time are they triggering? [05:31:24] if i click on a m. url [05:31:50] hmm that shouldn't set a cookie, however you will be forced into the mobile view for a .m. domain because of varnish etc [05:33:11] right but I've had cases where it continuously shows me the mobile view even though i haven't switched to it [05:33:28] tfinc because you're looking at a .m. domain? [05:33:33] yes [05:34:07] if you go to a .m. domain, you will *always* see the mobile site, regardless of your cookie. or at least, you should. [05:35:16] sure [05:35:37] but the i'll navigate to a desktop (non m) url and will be forced to see the mobile layout again [05:35:41] even though i haven't asked for [05:35:50] oh i see, that is weird. [05:36:07] awjr_away: in other news .. this one is fun too https://bugzilla.wikimedia.org/show_bug.cgi?id=35686 [05:36:28] i should really go home soon [05:37:02] unless.. well, we're setting cookies for *.whatever.com. so if you set the mobile view on en.wikipedia.org, your cookie domain will be .wikipedia.org, meaning you would also see the mobile view on es.wikipedia.org [05:37:22] tfinc yeah that's the one that caught my attention :( [05:38:00] no es bueno [05:38:08] no that's way shitty. [05:38:19] i thought i tested the regex well but i guess not well enough [05:38:33] i'll dig into it in the am. [05:39:06] sure [05:44:10] ok im going to stop paying attention to my computer again. tfinc, you should probably do the same.. [05:44:23] indeed [05:44:37] I've spent enough time in the office today [05:44:40] need to head home [05:44:50] ! you're still at the office?! [05:44:58] not for long [05:45:03] ok good [05:45:06] go home! [05:45:25] good night - i'll talk to you tomorrow [09:19:31] New patchset: Jdlrobson; "resize image for android devices that do not support background-size" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4253 [10:04:47] hi jdlrobson :) bug seems fixed on 2.3 devices now.. check it out! [10:05:05] thanks Astagi ! what was the issue? [10:06:07] I don't know jdlrobson, I just tried an hack: hide and show as a sort of refresh :D and works on 2.3.. I had the same issue before, didn't notice it yesterday.. [10:06:26] ok will take a look in a bit - just reviewing some code on the mobile site [10:06:42] nice thanks :) [10:13:37] New review: Jdlrobson; "Looks fine and seems to cover what https://gerrit.wikimedia.org/r/#change,4156 was trying to do. The..." [mediawiki/extensions/MobileFrontend] (contact-us-redesign) C: 1; - https://gerrit.wikimedia.org/r/4233 [10:14:03] Change abandoned: Jdlrobson; "@awjrichards has got my back so this is no longer needed." [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4156 [10:14:52] New review: Jdlrobson; "also could you amend the commit message to include" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) C: 0; - https://gerrit.wikimedia.org/r/4233 [10:22:46] New review: Jdlrobson; "The changes to mf-feedback.js seem to have disappeared?" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) C: -1; - https://gerrit.wikimedia.org/r/3963 [12:51:41] MaxSem: Since preilly isn't here, I'll tell you. We seem to have a working vumi deb package built. \o/ [13:01:10] wheee [13:03:54] And having done a real test, we now /actually/ have deb packages. [13:04:16] Still in a crappy test PPA, and I still need to package the wikipedia app. [13:04:51] And there's still some manual rabbitmq setup. [13:05:37] I'll fiddle with that stuff later tonight, though. [13:19:25] New patchset: Jdlrobson; "error handling for form submission" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4265 [15:49:14] [WikipediaMobile] jdlrobson pushed 3 new commits to master: http://git.io/7BEdbA [15:49:14] [WikipediaMobile/master] Fixed #35431 - 4ndreaSt4gi [15:49:14] [WikipediaMobile/master] Fixed sections bug - 4ndreaSt4gi [15:49:14] [WikipediaMobile/master] Some style fix according with styling guidelines - 4ndreaSt4gi [15:49:29] Project WikipediaMobile - Nightly builds build #273: SUCCESS in 7.3 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/273/ [15:49:29] * jdlrobson: Fixed #35431 [15:49:30] * jdlrobson: Fixed sections bug [15:49:30] * jdlrobson: Some style fix according with styling guidelines [16:30:20] New patchset: awjrichards; "following design in http://www.mediawiki.org/wiki/File:Mobile_Contact_A1.png for time being ignoring general section as not clear what it should contain - Moved semi-hard-coded email addresses in feedback template to variable href links, added method to g" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4233 [16:31:55] New review: awjrichards; "wtf. something must've got lost in a rebase or whatever :(" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 0 C: 0; - https://gerrit.wikimedia.org/r/3963 [16:33:45] New patchset: awjrichards; "Updating feedback form id to 'mf-feedback-from' for clarity" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3963 [16:35:03] hey awjr [16:35:09] hi jdlrobson [16:35:25] im nervous that some of my changesets have mutated in unexpected ways [16:35:37] like the one where my change to mf-feedback.js disappeared [16:35:55] i've probably been doing something weird in my git workflow [16:36:00] yeh its been strange [16:36:06] i keep getting the same notifications [16:36:22] and everytime i go to edit it I end up having to delete the branch and checking it out again and cherry picking [16:36:38] yeah i think there's something peculiar with the remote branches [16:36:43] probably [16:36:54] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4265 [16:36:57] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4265 [16:37:11] im going to go through my pending changesets and try to see if everything looks OK [16:40:37] awjr: were you happy with the suggested json format in https://gerrit.wikimedia.org/r/#change,4265 ? [16:41:14] jdlrobson for now, definitely [16:41:33] we can change up if we need to, but i think it will be sufficient [16:42:12] jdlrobson: are you able to submit code to be merged in gerrit? [16:42:30] i can't merge no [16:44:22] jdlrobson: once i go through my changesets to make sure they're ok, would you mind reviewing what you can? then i'll get patrick to take a look and try to get them merged into the branch [16:44:38] sure [16:45:05] any chance you could get some basic error handling in as well so I can test the form submission with real data? [16:45:17] (so I can work on that tomorrow) [16:45:20] New patchset: awjrichards; "Updating feedback form id to 'mf-feedback-from' for clarity" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3963 [16:45:21] New patchset: awjrichards; "Follow up to Change-Id: Ia065e1f2, fixing static call to non-static method" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3948 [16:45:22] New patchset: awjrichards; "Set 'contact us' title in the special page, add corresponding i18n message" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3964 [16:45:30] jdlrobson i can definitely get that in today. [16:45:46] awesome [16:46:10] wtf why is amending one commit causing changes to other commits [16:47:04] New review: awjrichards; "sorry for all the changesets and probably any resulting spam. im struggling to get the branching/ame..." [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 0 C: 0; - https://gerrit.wikimedia.org/r/3964 [16:48:33] New patchset: awjrichards; "Updating feedback form id to 'mf-feedback-from' for clarity" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3963 [16:51:53] I'm not sure awjr are you doing anything with rebasing? [16:52:49] jdlrobson well i think git-review rebases automatically, which i wonder if is the problem. you can do 'git review -R' which will cause it NOT to rebase first, which seems to be working [16:52:55] New patchset: awjrichards; "Added stub 'on success' handling for successful form submissions; Added LeaveFeedbackScuccessTemplate for displaying HTML on success;" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3966 [16:54:22] gmail: filter messages > has the words 'list:"" cookies OR brunch' > create filter with this search > mark as read (this is getting too painful for me knowing I'm missing out) [16:54:36] lol [16:54:49] jdlrobson im surprised you're on the wmfsf list - it's supposed to be for people in… sf [16:54:56] i'm special [16:55:02] :D [16:57:44] philinje: are you happy with me applying the patch in https://bugzilla.wikimedia.org/show_bug.cgi?id=35616 ? [16:59:17] also awjr is there any issues with allowing the beta to be accessed via a querystring? e.g. http://bug-attachment.wikimedia.org/attachment.cgi?id=10375 [16:59:33] would make development and sharing a *heck* of a lot easier [17:00:05] New patchset: awjrichards; "Added method and property documentation for MobileFeedbackForm class" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4225 [17:00:27] jdlrobson: re: patches to beta_common.css [17:00:35] i think i'll spend some time getting upto speed on gerrit [17:00:38] and submit them myself [17:00:55] jdlrobson is that intended just for debugging or for production use? [17:01:39] both [17:01:57] I'd like to be able to point people at beta pages without forcing them to opt in permanently [17:03:22] ok YuviPanda sounds cool [17:03:27] greetings all .. lets do our stand up [17:04:02] * YuviPanda starts skype [17:04:12] YuviPanda I've posted a commit for review which would enable RL meaning we can do the refactoring [17:04:26] awjr: can't seem to get you on skype [17:04:40] tfinc sorry didnt have it open [17:04:45] for shame [17:06:31] hello? [17:06:35] did i lose you guys? [17:07:29] I *was* on mute! [17:08:45] we really need to find a new name for sticky cookies [17:08:58] what's wrong with cookies being sticky? [17:09:04] jdlrobson: sticky biscuits? [17:09:07] :D [17:09:11] yehhh [17:14:52] mmm, so I wasn't the only one who got disconnected? [17:15:17] MaxSem I think it was the folks in the office who got disconnected because the wifi is crap there. [17:15:51] yes, it's quite something to have worse internet than me :D [17:15:59] awjr, I actually bought myself a Wi-Fi router now now wondering if it's my end that bugged [17:16:14] jdlrobson: persistent cookies [17:16:34] "persistent" is booring [17:16:44] sticky cookies yay! [17:16:44] sticky is way more entertaining [17:17:27] hey brion [17:17:32] yo [17:17:53] the wifi has just been horrible lately [17:18:02] just as well i'm at home today :D [17:18:38] preilly: can you review/submit these when you get the chance? https://gerrit.wikimedia.org/r/#q,is:watched+status:open+branch:contact-us-redesign,n,z [17:18:38] just in case anyone is getting confused by branches in git I can recommend this -> http://pastebin.com/4ACcNrA9 [17:19:01] they're all just for the contact-us-redesign branch, which is partially why i presume they've been left alone, but jon can't submit [17:19:33] jdlrobson thats handy [17:19:49] awjr: so thinking about centralizing forms [17:20:15] you said that the current behavior is that any feedback is saved to the wiki [17:20:59] current behavior is that form submissions get saved to the same wiki from which the user submitted the form [17:22:39] so we wouldn't be changing any end behavior preilly if we kept it as is [17:23:25] correct [17:26:06] so really the only way to consolidate feedback would be to direct all technical feedback to mobile-feedback-l@ [17:26:37] tfinc or write to a particular wiki [17:26:44] but your suggestion would be easier to implement [17:26:53] actually [17:27:27] tfinc we'd probably need to think about setting up an email queue for that if we want to still be able to capture user agents [17:27:38] we have to be able to capture ua's [17:27:49] i need to rush off soon [17:27:53] jdlrobson: k [17:28:01] tfinc: another possibility is that the 'contact us' links just points to one wiki [17:28:17] awjr: could we just direct it at mw.org ? [17:28:21] eg the contact us link could always point to mw.org [17:28:22] yeah [17:28:31] i think so [17:29:22] that is probably the easiest solution to resolve the issue of things being spread out without having to build in mail queuing functionality [17:30:32] i'm fine with that [17:31:38] * YuviPanda looks up gerrit docs [17:34:17] linSmith and heatherw - I could do with some guidance/mockups for how errors should be handled on the contact us page - if you go here- http://mobile-geo.wmflabs.org/w/index.php?title=Main_Page&useformat=mobile&mobileaction=leave_feedback#mf-feedback-message and open the technical problem and click send it should trigger the error handling [17:35:20] that does seem a bit extreme :) [17:35:59] we did have this: http://www.mediawiki.org/wiki/File:Mobile_Contact_I3.png [17:36:08] awjr: https://gerrit.wikimedia.org/r/#q,is:watched+status:open+branch:contact-us-redesign,n,z is empty [17:36:25] obviously go back is not needed (which is awesome) jdlrobson [17:36:29] preilly: not for me [17:36:43] oh perhaps because of is:watched [17:36:55] preilly try https://gerrit.wikimedia.org/r/#q,status:open+branch:contact-us-redesign,n,z [17:37:45] New review: Jdlrobson; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) C: 1; - https://gerrit.wikimedia.org/r/3963 [17:37:49] awjr: not empty [17:38:15] awjr: probably want to separate commit message on https://gerrit.wikimedia.org/r/#change,4233 into several lines but never mind [17:39:02] right must go! [17:39:06] awjr: would you be available for a 3-4pm git workflow discussion ? [17:39:13] drop me an email if you need anything! [17:39:17] awjr: its the meeting i mentioned earlier [17:39:22] tfinc: yes [17:39:34] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3963 [17:39:35] tfinc can you calendar invite me? [17:40:30] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4233 [17:40:33] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4233 [17:40:41] awjr: your on it now [17:40:44] ZOMG why is the LIFI so bad [17:40:53] lifi? [17:41:23] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3948 [17:41:25] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3948 [17:42:23] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3964 [17:42:55] awjr: Change cannot be merged due to unsatisfiable dependencies. [17:42:56] The following dependency errors were found: [17:42:57] Depends on patch set 8 of I65015e35, however the current patch set is 9. [17:42:57] Please rebase the change and upload a replacement commit. [17:43:04] awjr: on https://gerrit.wikimedia.org/r/#change,3964 [17:43:25] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3966 [17:43:44] awjr: Change cannot be merged due to unsatisfiable dependencies. [17:43:44] The following dependency errors were found: [17:43:46] Depends on patch set 5 of Ic8cdce6b, however the current patch set is 5. [17:43:47] Depends on patch set 7 of Ie3028e06, however the current patch set is 8. [17:43:49] Depends on commit 8faac3903d4daee832393569f0fa3c08a3ae1271 which has no change associated with it. [17:43:50] Depends on commit ace5100c2c92094fe1c64ffed781f222313b8913 which has no change associated with it. [17:43:50] Please rebase the change and upload a replacement commit. [17:43:55] awjr: on https://gerrit.wikimedia.org/r/#change,3966 [17:44:11] hmm that sounds complicated. [17:44:28] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4225 [17:45:20] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3963 [17:45:39] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3963 [17:47:37] YuviPanda: i'm out of meetings at 12:30 PDT [17:47:39] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3963 [17:47:56] tfinc: ok. [17:49:26] maplebed: i have all my gear in the office. what time do you want to head over ? [17:49:58] awjr: so, all of these changes need to be rebased https://gerrit.wikimedia.org/r/#q,status:open+project:mediawiki/extensions/MobileFrontend+branch:contact-us-redesign+topic:contact-us-redesign,n,z [17:50:08] tfinc: I'm WFH today so can meet you whenever. I figure if you leave around 6 I can meet you at ashby at 6:45ish. [17:50:35] which bart stop ? [17:50:36] awjr: Roan can walk you through what you need to do it's sort of a little trick to get them all to work correctly [17:50:40] i'm soon going to start rock climbing on horizontal walls [17:50:45] tfinc: ashby. [17:50:45] awjr: he is available at 11:15 PDT [17:52:48] preilly awesome thanks [17:55:38] YuviPanda: http://www.ipodnn.com/articles/12/04/04/wikipedia.update.promised.native.ipad.interface/ [17:56:13] i'm guessing they'll like it and hate it once it goes back online [17:56:18] just like everything else :) [17:56:25] tfinc: do we know when it's expected to go back up? [17:56:33] just like we would with anything else [17:56:41] taking it down took less then an hour [17:56:46] i hope putting it back up is the same [18:00:45] awjr: /j #wikimedia-gerrit [18:01:56] philinje: whats the bug # for the new nav ? [18:02:13] awjr: /j #wikimedia-gerrit [18:02:13] i can't ever seem to find it [18:02:33] not sure there is a bug yet [18:02:45] there is [18:03:11] https://bugzilla.wikimedia.org/show_bug.cgi?id=32117 [18:03:12] ok, I didn't file it, but i can take a look [18:03:30] thanks [18:04:00] i changed the description so that i can find it easier [18:04:23] mobile nab is a good phrase [18:04:31] is Jon offline? [18:04:39] philinje: yes [18:04:59] philinje: he left at 10:39am [18:05:07] thanks [18:05:45] adding the bug to the mobile nab project page [18:20:03] YuviPanda: have you ever used this http://socketbug.com/ ? [18:20:17] hmm nope [18:20:25] preilly: We have test debs! [18:20:39] (Except for vumi-wikipedia.) [18:21:28] ajerith: sweet mother of __________ [18:21:48] ajerith: I need vumi-wikipedia debs too [18:22:29] New patchset: Catrope; "Updating feedback form id to 'mf-feedback-from' for clarity" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3963 [18:22:37] preilly: I know. I'm doing that now. vumi was the hard one, so vumi-wikipedia should be straightforward. [18:23:13] YuviPanda: really nice looking tool using web sockets for mobile testing [18:23:15] New patchset: Catrope; "Updating feedback form id to 'mf-feedback-from' for clarity" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3963 [18:23:27] yes, and with proper sockets might actually work! [18:23:30] (unlike weinre) [18:23:36] YuviPanda: i got it from https://docs.google.com/presentation/d/1CCD9U50auA8UqRIRzLY2KefEBRhmx6sYXWz3PsRadk0/edit#slide=id.gae9f59d_0_69 [18:23:39] tfinc: will give it a go. [18:23:42] which was a presentation from one of our sf hackathon attendees [18:23:46] aah [18:24:02] My VM was misbehaving until I kicked it in shins, so the vumi-wikipedia deb should be done within the hour. (Modulo launchpad build delays.) [18:24:16] tfinc: cool [18:24:37] hmmm, I just realized my Gerrit changes aren't going to be useful. Jon mentioned we could actually move to RL now. [18:24:40] sigh [18:24:47] * YuviPanda stashes them and goes back to API work [18:25:06] YuviPanda: we have a talk with Roan about RL tomorrow [18:25:31] yes [18:25:34] and i got this from jon a while back [18:25:35] [22:34:13] YuviPanda I've posted a commit for review which would enable RL meaning we can do the refactoring [18:25:47] YuviPanda: my meeting ended early. i'm going to go through my email backlog and then i'll look at the iOS app release [18:25:52] tfinc: cool [18:31:24] tfinc: does that email mean we're back on or does it mean that we're back on in the process of getting back on? [18:34:35] YuviPanda: i'll know when i'm done with my backlog ;) [18:34:38] email* [18:34:40] okay :) [18:35:00] @ inbox(10) … need inbox(0) [18:38:17] inbox(0) [18:38:18] :D [18:38:38] * tfinc doesn't look at all the starred messages that need further followup [18:39:13] MaxSem: are you doing 'one extra day at Berlin'? [18:39:47] I stay there 3 days after the conference [18:40:02] YuviPanda: 3.1.1 is pending review [18:40:07] tfinc: cool! [18:40:12] MaxSem: pm? [18:40:18] sure [18:40:20] i'll check on it again in the afternoon [18:43:53] awjr: http://www.thoughtworks-studios.com/mingle/3.5/help/project_settings_page.html .. "Enable anonymous access" :) [18:44:16] awjr: did you guys ever try that? [18:45:02] woot http://www.youtube.com/watch?v=U_ay0U5FIts ! [18:45:19] tfinc: no - we were using an earlier version of mingle [18:45:52] tfinc: i didn't realize they'd added anonymous access. they must've done that after we harassed them about it :) [18:46:20] exactly [18:47:57] actually tfinc it looks like our instance still doesn't support it [18:48:02] it might be a licensing thing [18:48:05] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3963 [18:48:08] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3963 [18:54:11] New patchset: awjrichards; "Fixes bug 35686 - when looking for the 'mobile token' in the hostname, the str_replace now wraps the mobile token in '.'s and then replaces matches with a '.' (eg if 'm' is the mobile token [a la en.m.wikipedia.org], it will run a str_replace on '.m.', re" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4291 [18:55:07] New patchset: Catrope; "Set 'contact us' title in the special page, add corresponding i18n message" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3964 [18:55:34] preilly, MaxSem - can you take a look at https://gerrit.wikimedia.org/r/#change,4291 - it resolves a bug we have in production [18:56:17] awjr: so, ".m." is replaced with "." [18:56:35] awjr: or, is it, ".m" is replaced with "."? [18:56:40] preilly yes whereas before "m." was replaced with "" [18:57:02] preilly: .m. replaced with . [18:57:09] the regex will match "m." [18:58:35] so, $mobileToken === 'm.'? [19:00:24] preilly yeah [19:00:27] awjr, tests don't seem to test for the bug fixed [19:00:43] [WikipediaMobile] Nikerabbit pushed 1 new commit to master: http://git.io/op7dHw [19:00:43] [WikipediaMobile/master] Translation updates from translatewiki.net - Niklas Laxström [19:00:56] Project WikipediaMobile - Nightly builds build #274: SUCCESS in 6.5 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/274/ [19:00:56] niklas.laxstrom: Translation updates from translatewiki.net [19:01:03] MaxSem yes they do [19:01:42] MaxSem the test checks if "http://bm.m.wikipedia.org/wiki/Nyɛ_fɔlɔ" will properly get converted to "http://bm.wikipedia.org/wiki/Nyɛ_fɔlɔ" [19:02:50] New patchset: awjrichards; "Fixes bug 35686 - when looking for the 'mobile token' in the hostname, the str_replace now wraps the mobile token in '.'s and then replaces matches with a '.' (eg if 'm' is the mobile token [a la en.m.wikipedia.org], it will run a str_replace on '.m.', re" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4291 [19:02:58] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3964 [19:03:01] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3964 [19:03:05] that last patchset just removes some trailing whitespace [19:03:07] I thought the lack of dots resulted in URLs being mangled [19:03:27] MaxSem i do not follow [19:03:44] never mind, stupid /me [19:03:50] :p [19:04:24] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/4291 [19:04:36] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4291 [19:04:38] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4291 [19:05:11] awjr: can you get https://gerrit.wikimedia.org/r/4291 merged to deployment and sync file it out to production [19:05:25] preilly yes [19:05:38] awjr, Gerrit gang may attack you due to summary not wrapped at 72 chars [19:06:10] thanks for the heads up MaxSem [19:06:45] i guess i either need to figure out how to put line breaks in messages when using commit -m or stop using -m [19:09:58] * MaxSem uses TortoiseGit [19:10:29] awjr: just use vim yo [19:16:00] tfinc: https://bugzilla.wikimedia.org/show_bug.cgi?id=35686 is fixed in production now [19:16:45] New patchset: Catrope; "Make validate method return true for now" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3965 [19:17:12] tfinc dunno if you saw since it looks like you got booted but: [19:17:12] tfinc: https://bugzilla.wikimedia.org/show_bug.cgi?id=35686 is fixed in production now [19:18:00] New patchset: Catrope; "Adds rudimentary meta-validation logic; populates MobileFeedbackForm properties with form input values on submit;" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3975 [19:18:01] New patchset: Catrope; "Added stub 'on success' handling for successful form submissions; Added LeaveFeedbackScuccessTemplate for displaying HTML on success;" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3966 [19:18:02] New patchset: Catrope; "Added basic validate method" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4224 [19:18:02] New patchset: Catrope; "Added todoto make 'execute' method of special page behave in a safer manner" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4222 [19:18:03] New patchset: Catrope; "Added method and property documentation for MobileFeedbackForm class" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4225 [19:18:04] New patchset: Catrope; "move from singular form fields as properties to a single property containing an array of form field metadata; update setFormFieldValuesByArray to reflect change" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4223 [19:18:05] New patchset: Catrope; "POC for using form field properties to hold meta-information about form fields (eg required, validation callback, error message, value)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4221 [19:18:26] There [19:18:27] awjr: woot! [19:18:31] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3966 [19:18:36] awjr: did you put it on the deployments page ? [19:18:45] i look at that to update our roadmap/status [19:19:01] preilly perhaps, although the example tomasz gave appears to be working w/o a cache flush [19:19:15] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4225 [19:19:18] tfinc i did not [19:19:20] but i will now [19:19:33] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4224 [19:19:40] tfinc i dont normally put one-off fixes in production on the deployment page - shall i do that in the future? [19:19:44] please add. it won't help us from a coordination stand point. but will help us to know what changed when [19:19:49] which is very useful to all of us [19:19:52] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4223 [19:19:57] especially if we see any regressions [19:20:12] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4222 [19:20:15] its food time [19:20:27] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4221 [19:20:35] New review: Catrope; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 0 C: 0; - https://gerrit.wikimedia.org/r/4225 [19:20:43] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3975 [19:20:48] New review: Catrope; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4225 [19:21:04] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3965 [19:21:07] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3966 [19:21:08] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4224 [19:21:09] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4223 [19:21:11] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4222 [19:21:12] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4221 [19:21:13] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3975 [19:21:15] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4225 [19:21:16] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/3965 [19:22:49] tfinc: should i add it on the wikitch deployment page or on the MobileFrontend deployment page? there's a lot of stratification around deployment stuff… perhaps we could figure out a way to just tap into the server admin log for deployment changes rther than try to manually keep up [19:23:23] awjr: tfinc is out to lunch [19:23:46] preilly: in the "he's getting food now" sense or in the "he's totally spaced out and crazy right now" sense? [19:24:08] [19:24:14] Both? ;-) [19:25:11] ajerith: "out to lunch" === GETTING_FOOD [19:25:52] Is that the Ruby "===" operator? [19:26:08] * ajerith always liked that operator, but was terrified by it. [19:26:47] ha ha ha [19:27:55] * YuviPanda imagines ajerith running away from a rampaging === [19:28:07] throwing "", 0, [] and {} at it, and seeing nothing affecting it [19:28:08] ajerith: I like the 1...10 syntax in Ruby [19:28:37] tfinc: you missed this, "awjr: tfinc: should i add it on the wikitch deployment page or on the MobileFrontend deployment page? there's a lot of stratification around deployment stuff… perhaps we could figure out a way to just tap into the server admin log for deployment changes rther than try to manually keep up" while you were out [19:29:05] tfinc i wound up adding it to the MF deployment page, it seemed more sensible. [19:29:16] "Your app Wikipedia Mobile has been reviewed, but we are unable to post this version. For details, or to directly contact the App Review team, visit the Resolution Center in iTunes Connect. Do not reply to this email." [19:29:22] how delightful [19:29:40] brion: what the what? [19:29:45] preilly: Ruby's "===" means "go to extravagant lengths to test something vaguely similar to equality". [19:29:58] mail from itunes connect [19:30:54] :( [19:31:00] brion: is that sort of ~= "no, you can't post this fix to your not-quite-working app" ? [19:31:06] For example, '"foo" === /f.o$/' will do a regex match. '37 === someproc' will call the proc object with 37 as the param. [19:31:07] quite possibly [19:31:10] lolz [19:31:14] awjr: thats a good question [19:31:33] what i need at the end of the day is a simple asynchronous view of the changes that have gone out [19:31:53] so that i can update a)the roadmap and b) update project status [19:32:27] tfinc: do you hate apostrophes? [19:32:36] generally i'm against them [19:32:53] just not in the above case [19:32:59] exactly [19:34:03] so, what does that, "Resolution Center" have to say about the rejection? [19:34:15] tfinc then the MF deployment page is the most sensible [19:34:20] i think [19:34:37] the wikitech page tends to be way more high level with specific fixes not listed [19:34:54] tfinc: is it really just the application description page? [19:35:00] … yes [19:35:04] tfinc: OMG [19:35:06] It would be appropriate to remove the following content: [19:35:07] 'NOTE: if the update fails please uninstall and then reinstall the application.' [19:35:36] ... [19:35:38] 'appropriate' [19:35:39] ... [19:36:21] 'it would be appropriate to' [19:36:24] passive aggressive douchebags [19:37:21] rofl [19:38:25] ha ha ha [19:38:42] * ajerith resolves never to try navigate the byzantine politics of the appstore. [19:38:51] this is why i like the web [19:38:58] nobody but yourself to stop you pushing updates :P [19:39:19] brion: this is why i like the android store [19:39:34] it's handy too yes -- instant push [19:39:36] [19:40:00] I prefer to download the apk myself, and run it. [19:40:27] Amgine: or use one of the many alternative app stores. [19:40:36] Amgine: there are a few 'purely open source' android app stores [19:40:47] (which we should get on) [19:41:48] http://f-droid.org/ [19:42:14] http://f-droid.org/repository/browse/?fdfilter=wikipedia&fdid=org.wikipedia&fdpage=1 :D [19:42:27] No, the reason I hate the google android store is it requires you have a google account hooked up to your phone. If your google account does not have google talk enabled, it beeps at you every hour to tell you google talk is not enabled. If you delete the account after having enabled it, it deletes all of your contacts. [19:42:44] heh [19:42:55] Even if none of those contacts were connected to the google account. [19:43:02] f-droid is keeping up with everyone of our releases [19:43:03] [19:43:07] and it doesn't require any account [19:43:12] they link directly to apks [19:43:16] Amgine: do you use it? [19:43:17] tfinc: oh, so they're picking us up themselves? [19:43:23] Not yet. [19:43:27] [19:43:35] YuviPanda: yes [19:43:38] sweet [19:43:40] their awesome that way [19:43:45] we had a bug for that that should be closed [19:44:26] [19:44:31] i'm going to remove the 'note' line [19:46:15] here is the full message for anyone who wants to read it [19:46:18] http://etherpad.wikimedia.org/Wikipedia-iOS-Rejection-Message [19:47:18] … how is that not relevant to application functionality :P [19:47:44] brion: when we mentioned 'Google Maps' it automatically told us 'it might be rejected' [19:47:47] i don't even begin to understand their line of thinking [19:47:57] wtf... [19:48:07] your app should work perfectly, so you shouldn't have to give workarounds [19:48:16] jerks [19:48:54] 'bugs? what? nothing associated with apple ever has bugs!' [19:50:20] just a couple of worms [19:52:15] speaking of failures … itunesconnect is a failure in all ways [19:52:34] you can only hit the back button a handful of times [19:52:37] WTF [19:53:28] ok. the note is gone. since were meta data rejected we won't have to submit a new binary [19:53:49] tfinc: you really hate the apostrophe don't you? [19:53:52] what has it ever done to you? [19:54:04] simple. its existence. [19:59:05] how do people opt-in to the mobile beta, aside from running across posts about it and getting the link? [20:03:49] heatherw: they don't. Last time I remember we had smallish opt in rates :( [20:04:02] it's not easy to find [20:04:32] i thought we were okay with that for now, until things are more developed [20:11:58] heatherw: the new new will offer up easy opt in [20:11:59] it has to [20:12:14] our opt in rates are in the low hundreds when we blog post / tweet [20:12:16] we can get a lot more [20:12:31] preilly suggested to automatically opt in some people to reach a broader audience [20:12:40] sounds like a good idea [20:13:48] i liked it too. once we have a better contact us i think we should do that [20:13:59] i was looking to see if i could find some "before" comparison images but i'm not sure how to opt-out. [20:17:03] opt-out of the beta? [20:17:20] yes [20:17:25] heatherw: http://en.m.wikipedia.org/?mobileaction=opt_out_mobile_site [20:17:52] opt-out doesn't seem to work on my phone [20:18:00] heatherw: or, http://bit.ly/HLQqun [20:18:20] philinje: what does it do? [20:18:32] philinje: when is the last time you tested it? [20:18:44] it asks to use the browser or app twice, then returns to the beta site [20:18:47] this morning [20:19:08] philinje: hmm [20:19:08] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/4253 [20:19:09] didn't work for me just now [20:20:25] heatherw: you need to refresh the page after it redirects [20:20:51] heatherw: can you try to refresh the home page after clicking yes in the opt out [20:21:05] yes! it worked, thanks preilly [20:21:15] philinje: does that work for you too? [20:21:40] awjr: we should probably add some randomness to the redirect after the user clicks, "yes" on the opt out page [20:21:58] eh? [20:21:59] awjr: otherwise their browser will just show the cached copy in most cases [20:22:02] what is the opt-out page? [20:22:11] awjr: http://en.wikipedia.org/?mobileaction=opt_out_mobile_site [20:22:26] awjr: it's the page used to opt out of the mobile beta [20:22:47] oh i see [20:23:57] so, maybe just add a &t=1333570995 where '1333570995' is the current unix timestamp or something [20:24:05] preilly are you suggestig adding some ?random=2349uafj to the query string? [20:24:07] oh [20:24:08] yeah [20:24:13] good point, i tried refreshing but that didn't clear the cache, apparently [20:24:59] philinje: can you add linSmith nav design workflows to http://www.mediawiki.org/wiki/Mobile_design [20:27:37] I wonder if it makes sense to make a local cache busting method that just adds a timestamp to any valid url that you pass it? [20:31:10] preilly: yes [20:31:23] tfinc: they will be added to the Wikipedia Nav project page (will ask again) [20:37:09] interesting. I'm now on m though the url is not. [20:37:29] (on my laptop, not my phone) [20:37:36] Amgine: are you a victim of the cookie [20:37:39] awjr: ^^ [20:37:51] evil cookies. We should never use them. [20:37:54] the sticky cookie strikes again? [20:38:20] preilly my guess is it's because the cookie gets set for the top domain rather than sub-domain [20:38:39] awjr: well, that's one issue [20:38:44] what is the other? [20:38:49] or are the others? [20:39:09] just the aggressiveness of it being set [20:39:25] preilly what do you mean? [20:40:02] awjr: I just mean that you sometimes end up at a URL with use format mobile in it [20:40:14] awjr: and from that point on you are stuck in mobile view [20:40:41] brb phone [20:41:20] preilly: does the desktop view link resolve the issue? [20:41:48] Amgine: sort of [20:42:47] That is going to be the first response of most people hit with this. Perhaps that should be altered so the answer is "yes"? [20:45:01] Amgine: we should talk to awjr when he is off the phone [20:45:27] [20:47:04] * preilly nods  [20:47:32] ok im off [20:47:57] so preilly, Amgine what you're suggestiong is that useformat=mobile should NOT trigger the cookies [20:48:02] is that correct? [20:48:15] Nope. [20:48:17] k [20:48:34] then i misunderstood - can you explain again? [20:48:51] awjr: I think the cookie should only be set if you click the link directly [20:49:03] awjr: not based on any URL query string parameters [20:49:10] My opinion is make it easy to recover from: I don't care *why* I'm in the mobile mode, I want to quickly and completely get out of it if I want to. [20:49:21] Amgine: click 'Desktop view' [20:49:36] awjr: but, then mobile is in desktop mode too [20:49:49] preilly: right, because the cookies are universal for a parent domain [20:50:10] actually, mobile will not be in desktop mode [20:50:22] she should not even GET to the mobile site if the desktop cookie is set [20:51:04] awjr: that's not true [20:51:22] preilly isn't that what was configured in squid/varnish? [20:51:37] awjr: well, that's just the automatic redirect [20:51:50] awjr: you can still navigate directly to it [20:51:56] preilly oh i see so if you're on a mobile device that would normally get sent to m domain but have cookie set [20:52:00] right [20:52:43] mf_useformat desktop [20:52:51] cookie does nothing in this case [20:52:55] preilly im not sure how to resolve that particular issue then without making the cookies sub-domain specific [20:54:18] YuviPanda: "This version has been approved and is being held by the developer. The developer must release this version before it will appear on the App Store." [20:54:22] :D [20:54:24] :D [20:54:26] preilly changing the 'agressiveness' of how cookies are set is not too big of a deal but will require some more workflow thought [20:54:31] let's hope things 'work out' this timie [20:54:32] YuviPanda: :) [20:54:37] tfinc: ;) [20:54:41] awjr: :( [20:54:50] :| [20:54:59] v: [20:55:08] awjr: can you just make it only set the cookie on a direct click to the link? [20:55:36] preilly yes, that part is not a big deal. [20:55:41] YuviPanda: any reason to not release this version ? [20:55:50] none that I can see... [20:55:50] but what happens if the user has mobile cookie set but they use a link that says useformat=desktop? [20:55:56] k, releasing [20:56:16] Status Processing for App Store [20:56:56] personally i prefer the globalness of the cookies - it is simple and unambiguous. but i can see how, particularly when we're doing testing etc it could be a pita [20:58:35] so preilly you are sugesting that useformat=mobile or useformat=desktop will only invoke that view for that request, not subsequent requests? [20:58:56] preilly_ ^ [21:00:24] preilly ^ [21:02:28] [13:55] but what happens if the user has mobile cookie set but they use a link that says useformat=desktop? [21:02:28] [13:56] personally i prefer the globalness of the cookies - it is simple and unambiguous. but i can see how, particularly when we're doing testing etc it could be a pita [21:02:28] [13:58] so preilly you are sugesting that useformat=mobile or useformat=desktop will only invoke that view for that request, not subsequent requests? [21:02:43] Amgine our friendly loggerbot [21:02:51] heh. [21:02:52] awjr: no [21:04:19] preilly then what are you suggesting? [21:04:32] awjr: only set the cookie when the user clicks [21:04:43] awjr: not when it's just in the URL [21:05:05] afk [21:05:28] preilly: yes i get that part but what is ambiguous then is the behavior of ?useformat= [21:05:49] that should be per session [21:06:00] per session or per request? [21:06:08] per session means we'll have to set another cookie [21:06:08] not sure [21:06:42] i think per session is not intuitive and would be confused with the 'Desktop view'/'Mobile view' behavior [21:08:44] preilly i think ?useformat= makes more sense on a per-request basis [21:10:17] preilly and i think we should move the sticky cookie handling stuff to a special page to ensure that cookies can still be set by users w/o javascript enabled (or, i guess, we could come up with YAQS [yet another query string]) [21:14:21] preilly, tfinc: what is the priority of changing cookie behavior compared to getting contact us done? [21:14:48] its higher as it affects current users. [21:14:57] if you can't take it on then we can get preilly to take a look [21:15:15] tfinc i can take it on but it means contact us will take longer [21:15:23] thats fine [21:15:27] ok [21:15:41] so preilly before i dig into this, can we finish hamemring out expected behavior? [21:17:46] "The following app has been approved. The status has changed to Ready for Sale." [21:17:48] \o/ [21:17:56] :D [21:18:00] * YuviPanda looks for his iPod [21:20:22] ok. the app has been approved. now i need to add it back to the store. [21:20:46] added [21:21:36] its not yet showing up in search [21:22:00] * YuviPanda gropes around in the dark for his iPod [21:22:45] * tfinc chuckles [21:22:55] preilly ping me when you're back around, i'd like to finish hammering out the expected behavior for cookies [21:24:05] awjr: okay [21:24:41] awjr: sorry, I'm in a Zero Rated meeting [21:24:45] preilly no sweat [21:24:54] heatherw: let me know if you need any help with the simulator for tomorrow [21:25:05] preilly: Do you usually get billed for your meetings? [21:25:11] heatherw: you can open it if you run "open /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Applications/iPhone\ Simulator.app/" <-- then just keep it in the dock [21:25:15] ajerith: ha ha [21:25:15] i do tfinc! i just installed xcode [21:25:25] okay [21:26:42] ahh they hide it inside the Xcode app now, i was wondering where it had gotten to [21:27:19] brion: yeah, I found it the other day [21:27:32] brion: total PITA [21:27:39] they also moved the command-line compilers and stuff around [21:27:48] which luckily doesn't break anything i care about so far [21:27:53] but seems annoying [21:29:12] totally [21:29:26] and you've got to download the tools separately [21:34:55] SUCCESS [21:37:50] New review: Brion VIBBER; "This feels wrong; seems to be changing the high-resolution image without changing the styles which s..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/4253 [21:44:09] wow .. this actually doesn't look horrible Wikipedia Mobile.ipa alias [21:44:11] err [21:44:19] http://europe.nokia.com/belle#new [21:44:30] i love how symbian finally seems to not suck when its about to be retired [21:44:50] :D [21:45:07] this makes me want to get an N8 to test on [21:45:41] Nokia … you make absolutely no sense [21:46:26] :D [21:46:54] and were back up http://itunes.apple.com/us/app/wikipedia-mobile/id324715238?mt=8 [21:46:56] YuviPanda: --^ [21:47:00] \o/ [21:47:08] * YuviPanda renews iPod grope search [21:47:17] * YuviPanda renews iPod TSA search, rather [21:50:28] tfinc: still not showing up on search [21:55:03] YuviPanda: you can probably find it under 'purchased' tho [21:55:41] brion: http://itunes.apple.com/us/app/wikipedia-mobile/id324715238?mt=8 url works [21:58:03] https://twitter.com/#!/contactmzn/status/187660113769807872 [21:58:34] tfinc: that's just the update not going through to everyone yet [21:58:41] that's what I got yesterday trying to install after you pulled [21:58:46] k [21:59:00] that tweet just came in though [21:59:04] which is why i'm skiddish [21:59:08] lifeeth is downloading it to his iPhone and iPad [21:59:16] On the iPad [21:59:18] works fine [21:59:19] :) [21:59:27] lifeeth: 5.1? [21:59:37] ipad is 5.0.1 [21:59:46] getting it on the iPhone thats 5.1 [22:00:15] ok [22:01:04] i'm testing on my old & new ipads now….. OH GOD THE PIXELS ARE SO HUGE on the old one ;) [22:01:09] :) [22:01:20] ok i saw the same error "The item you tried to buy is no longer available" on the old ipad [22:01:48] both on 5.1…. odd [22:02:37] ok now it's gone through on both [22:02:58] YuviPanda : tiny issue when hitting the settings button [22:03:08] it would be nice if hitting it again would close the settings [22:04:37] history and saved pages aren't working for me on either ipad :( [22:04:40] wtf [22:04:55] Saved pages is working for me on iPad 2 [22:05:07] So does history [22:05:18] weird [22:05:30] brion: your presence on x2005 is requested for git convo [22:05:32] YuviPanda : works on the iPhone 4s on 5.1 as well [22:05:35] brion: can you join us for the deployment discussion on x2005 ? [22:06:16] ok [22:06:48] thanks [22:06:57] awjr: i'm in [22:07:04] w00t! [22:07:16] brion: http://etherpad.wikimedia.org/GitWorkflow [22:51:26] YuviPanda: just saw your tweet [22:51:39] YuviPanda: make sure to hit publish on the blog post [22:52:05] tfinc: thought you wanted someone to look at it? [22:52:11] someone from comm [22:52:17] matt already looked at it [22:52:20] ah [22:52:22] cool [22:52:29] he mesg'd me saying it looked grat [22:52:32] great [22:52:36] cool [22:52:41] will hit publish [22:52:41] and gave us praise for crafting really good blog posts [22:53:02] wooo [22:53:04] :D [22:53:32] tfinc: we're looking good for a beta on friday. [22:53:55] API Move + Jon's sexier section expansion [22:56:06] YuviPanda: did you see my response to jons email about section loading ? [22:56:14] i did [22:56:18] we're not doing that in 1.2 [22:56:28] i only like it if we can asynchronoously load all sections [22:56:41] yes, we can. [22:56:42] 1.3 [22:56:51] and i don't want to deploy it till then [22:57:05] oh [22:57:09] by jon's sexier section expansion [22:57:15] i meant that we're now using the styles in the beta [22:57:18] rather than older styles [22:57:21] *not* his API code [22:59:06] thats fine then [22:59:15] just wanted to make sure you hadn't jumped the gun there [23:00:00] nope :) [23:00:11] tfinc: 1.2 will have new styles + new reference reveal [23:00:18] + no more scraping Mobile site [23:00:39] i care about the decoupling … anything else is icing on the cake :D [23:00:50] :P [23:01:00] tfinc: we also need to make a decision about the home page. [23:01:08] tfinc: currently, Max's API doesn't do any home page transforms. [23:01:10] thats easy [23:01:14] should we take it from MF? [23:01:18] oh [23:01:28] the current 'mobile homepage' code is in MF [23:01:29] why can't we get the main page through the api ? [23:01:33] not accessible through the API [23:01:34] ohh [23:01:35] right [23:01:36] shit [23:01:45] YuviPanda: i need you to watch the tweets coming in [23:01:55] i'm tackling the ones about the changelog [23:02:08] YuviPanda: spin up tweet deck so that you can monitor [23:02:13] i can send you the old version if you need it [23:02:17] i have it open on safari. [23:02:20] k [23:02:23] air apps don't like my air [23:03:25] mwhaha … YuviPanda you'll like this [23:03:37] i can edit the metadata post push and change whatever i want [23:03:41] aha! [23:03:53] does apple have to approve that too? :P [23:04:10] http://www.guardian.co.uk/news/datablog/interactive/2012/apr/04/wikipedia-world-language-map [23:04:46] very cool [23:04:50] YuviPanda: nope :D [23:04:57] they might pull it of course [23:05:06] so i'm just going to add our old release notes [23:05:09] :) [23:06:14] and we can have more fun with it AFTER we know this upgrade actually worked for people [23:06:32] we need to get this over with … with no more drama [23:06:36] :) [23:08:55] metadata changes made. the app store should pick them up in a couple of minutes [23:10:20] tfinc: is there a way to poke apple about 'this item is no longer available'? [23:10:35] YuviPanda: https://twitter.com/#!/swat671/status/187678282601340929/photo/1 [23:10:41] whats the core issue ? [23:10:41] yes saw that [23:11:14] http://i.tuaw.com/2011/04/13/sudden-spike-in-itunes-the-item-you-tried-to-buy-is-no-longer-a/ says 'transient glitch' [23:12:39] tfinc: apparently a bug in App Store that happens if you pull an app and push it back up :( [23:12:39] http://forums.macrumors.com/showthread.php?t=1031693 [23:13:36] lame [23:15:27] http://www.minecraftforum.net/topic/1037076-minecraft-pocket-edition-ios-update-020-problem-fixed/ has a 'solution' [23:15:32] and an annoying gif [23:16:21] 'if an item says it is not available from the correct store and it is listed, it may just be getting worked on or it is in the process of removal. It is not available and you can try again later to see if it becomes available.' is what people got back from iTunes support [23:16:30] YuviPanda: tweet about it [23:16:37] tfinc: that MineCraft link? [23:16:44] i don't consider that a reliable source [23:16:59] actually .. try that out with the @swat671 [23:17:04] or whatever else you find [23:17:17] http://www.iphonedevsdk.com/forum/business-legal-app-store/98847-item-you-tried-buy-no-longer-available.html [23:17:57] tfinc: So, I would advise you to at least check out your contracts in the "Contracts, Tax and Banking" section of iTunes Connect. [23:17:58] from that post [23:18:21] thanks apple, now we're following steps from random posts on the internet by scrawny teenagers [23:26:06] tfinc: i'm trying one method with Kenny Stone [23:26:54] we're still not up on search [23:29:00] The Wikipedia iPhone app is listed as an update being available but when I go to download the update it says "The item you tried to buy is no longer available." Would y'all happen to know what's up with that? [23:29:02] lets give that index 24hrs [23:29:17] greetings Ks0stm [23:29:20] YuviPanda: --^ [23:29:35] hello Ks0stm [23:30:08] Ks0stm: are you updating from iTunes or from your device? [23:30:44] Ks0stm: i got that on my iPad, but a second upgrade attempt worked. give 'er a whirl and see what happens… allegedly a temp glitch [23:31:39] From my device, but I'm also asking because of OTRS ticket #2012040410015312 [23:31:57] And I'm still getting the error...just tried again [23:32:44] Ks0stm: do you see a 'cloud' icon to the right of the app in your device? [23:33:44] YuviPanda: Where do I look for that? I don't seem to recall ever having seen anything like that... [23:33:54] Ks0stm: updates -> purchased [23:34:24] on device: App Store -> Updates -> Purchased [23:35:42] YuviPanda: No, I see a blue box that says "UPDATE" with a little plus in the top left [23:35:59] Ks0stm: even inside the 'purchased' section? [23:36:08] Yes [23:36:54] Ks0stm: and hitting update tells you the app no longer exists? [23:38:10] When I hit update I get a notification saying "The item you tried to buy is no longer available." [23:39:11] brion: what did you do to get it to work [23:39:13] ? [23:39:23] YuviPanda: i just did it a second time, was ok :( [23:39:43] well except that i've got the 'db stuff doesn't work' bug again :( [23:40:39] brion: woah?! [23:40:43] brion: what? [23:40:51] brion: can you check the 'about' section for a version? [23:41:02] says 3.1 [23:41:21] wow, that's the older version [23:41:22] :| [23:41:30] whafu, ok that's just odd then :D [23:41:38] oho, app store offers me another update now [23:41:46] Mine says "3.1.1 04/04/12" [23:41:55] On the update screen, anyway [23:42:29] brion: try it [23:42:39] hmm [23:42:47] YuviPanda: about screen still says 3.1 after that update [23:43:01] app store shows 3.1.1 though [23:43:26] and it's…. offering me the same update again [23:43:26] wtf [23:43:45] o_O [23:43:56] that's… interesting. [23:44:28] tried 'update all', got a 'sorry the item you bought is no longer available' [23:44:46] tfinc: can we contact apple developer support? [23:44:48] aaaaaaaaaaaaaaaaaahhhhhhhhhhhhhh [23:45:00] brion: ? [23:45:57] so if i click 'update' from within the app store 'page' for just wikipedia, it installs 3.1 again [23:46:11] if i click 'free'/update or 'update all' from the list of updates, i get 'the item you are buying is no longer available' [23:46:39] brion: can you go to app store -> updates -> purchased [23:46:40] ok so that explains why it "worked", it has two exciting different failure modes [23:46:42] When I click update from the Wikipedia app page it gives me the error anyway [23:46:57] and see if there's a cloud icon next to the app? [23:47:04] this seems to be a somewhat common problem [23:47:09] (hit minecraft a while ago, apparently) [23:47:15] without any publicized solutions :| [23:47:25] except for http://www.minecraftforum.net/topic/1037076-minecraft-pocket-edition-ios-update-020-problem-fixed/ [23:48:37] so if i follow those directions, it installs 3.1 [23:48:52] * YuviPanda pokes tfinc  [23:49:07] i can't get 3.1.1 no way no how [23:49:19] brion: uninstall? [23:49:24] let's try [23:49:28] brion: wait [23:49:34] first can you try updating from iTune? [23:49:38] *iTunes? [23:50:06] 3.1 [23:50:45] find my cable... [23:51:33] YuviPanda: When I try from iTunes it says 3.1.1 and when I click "Get update" it pops up a box saying "This item is temporarily unavailable. Please try again later." [23:52:42] Ks0stm: ugh. uninstall + reinstall? [23:53:21] apps don't appear to be synced to itunes on this ipad. hmm. [23:53:51] try re-syncing.... [23:54:28] YuviPanda: Uninstalled it from my iPhone and when I went to reinstall it gave me the same error [23:54:50] * YuviPanda pokes tfinc some more to email apple dev support [23:55:46] it installed/works fine on my iPod without issues. [23:55:46] gah [23:55:51] Ks0stm: what version are you on? [23:56:09] im back [23:56:15] YuviPanda: Now that I uninstalled it I can't even find it in the app store at all, even when searching for it [23:56:34] Ks0stm: use this link? http://t.co/GLq1ddxP [23:56:35] Ks0stm: http://itunes.apple.com/us/app/wikipedia-mobile/id324715238?mt=8 [23:56:58] http://itunes.apple.com/us/app/wikipedia-mobile/id324715238?mt=8 [23:57:02] tfinc: ha ha [23:57:24] click, "View in iTunes". [23:57:53] YuviPanda: what's their contact info? did you send it in the back scroll ? [23:58:00] preilly are you available to chat about changing cookie functionality? [23:58:09] no, I assumed it was something that you see in the portal? [23:58:14] i remember seeing 'you have two support tickets' [23:58:43] awjr: sure [23:59:30] preilly so right now cookie handling and useformat are very much intertwined. i've got a pretty good game plan figured out on how to get them untangled [23:59:41] but i've got three big questions that i'm not sure how to deal with [23:59:47] YuviPanda: That link found it and I was able to download it again, but it's still saying the 3.1.1 update is available