[00:00:29] tfinc: pushed [00:00:40] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/KQq_HQ [00:00:40] [WikipediaMobile/v3.1.2-iOS] Kill all !important declarations - YuviPanda [00:00:52] pulling [00:00:54] Project WikipediaMobile - Nightly builds build #283: SUCCESS in 6.7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/283/ [00:00:54] yuvipanda: Kill all !important declarations [00:01:45] in your mail mention wesley and note that jon should prep himself well ;) [00:02:24] hehe. [00:02:30] i'm not seeing this change make any better [00:02:39] doing a clean just to make sure i don't have an old binary [00:03:47] ok [00:04:09] this actually makes it worse [00:04:26] the article is *not* centered and scrolling is jerky [00:04:33] ok [00:04:38] making another commit [00:04:43] are we playing battleship with css now ? [00:04:44] :D [00:04:52] or .. minesweeper! [00:04:58] :D [00:05:10] this commit, I copy pasted wesley's gist into common.css [00:05:11] :D [00:05:12] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/DYY3Ig [00:05:12] [WikipediaMobile/v3.1.2-iOS] Directly stealin wesley's modified CSS - YuviPanda [00:05:15] rather than make modifications one by one [00:05:20] pulling [00:05:25] Project WikipediaMobile - Nightly builds build #284: SUCCESS in 7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/284/ [00:05:26] yuvipanda: Directly stealin wesley's modified CSS [00:06:10] building [00:07:00] much better [00:07:41] :) [00:08:45] tfinc: i shall update bugs first [00:11:29] hmm [00:11:44] tfinc: something broken? [00:12:04] i'm loading the San Francisco article and expanding sections [00:12:37] expanding the first section works [00:12:39] *but* [00:12:48] i can't get past the their paragraph of it [00:13:01] refresh issue. [00:13:06] effectively the app things its already at the bottom of the article [00:13:59] scrolling past large images is a little jerky too .. let me try that in safari [00:14:17] tfinc: ^ [00:14:21] damn [00:14:23] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/XmdY6w [00:14:23] [WikipediaMobile/v3.1.2-iOS] Added toggle.js with calls to doScrollHack - YuviPanda [00:14:24] slow bot [00:14:26] tfinc: ^ [00:14:35] Project WikipediaMobile - Nightly builds build #285: SUCCESS in 6.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/285/ [00:14:36] yuvipanda: Added toggle.js with calls to doScrollHack [00:14:45] k .. let me build with that [00:15:24] hmm .. error: The following untracked working tree files would be overwritten by merge: [00:15:25] assets/www/js/toggle.js [00:15:44] yet git diff shows nothing [00:16:31] yes [00:16:34] rm toggle.js [00:16:40] similar slowdown in safari when i scroll over large images [00:16:42] ahh [00:16:43] ok [00:19:11] that fixed it *but* causes the page to scroll to the top of the page when you expand *any* section [00:20:27] ah [00:20:29] right [00:20:31] let me fix *that* [00:21:47] pushed [00:22:10] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/XqymYw [00:22:10] [WikipediaMobile/v3.1.2-iOS] Don't scroll to top after every expansion - YuviPanda [00:22:18] pulling [00:22:23] Project WikipediaMobile - Nightly builds build #286: SUCCESS in 6.8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/286/ [00:22:24] yuvipanda: Don't scroll to top after every expansion [00:23:01] And that's an order. [00:23:29] haha [00:23:40] good one :) [00:23:48] * YuviPanda stops scrolling to the top after every expansion [00:23:59] though considering my eating habits, next expansion doesn't seem likely in a while [00:24:06] that fixed it :D [00:28:51] [WikipediaMobile] reedy pushed 2 new commits to master: http://git.io/d737eQ [00:28:51] [WikipediaMobile/master] Format README.md to make it pretty (no content changes) - Jan Piotrowski [00:28:51] [WikipediaMobile/master] Merge pull request #203 from piotrowski/master - Sam Reed [00:29:04] Project WikipediaMobile - Nightly builds build #287: SUCCESS in 6.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/287/ [00:29:04] piotrowski: Format README.md to make it pretty (no content changes) [00:35:53] i wonder what speeds ups we can make scrolling past images [00:36:01] safari tends to be better at it [00:38:08] hmm [00:38:14] make the images smaller? [00:38:28] tfinc: at some point, a few releases down, we should be able to do specific things much better [00:38:34] like open up images in lightboxes [00:38:52] well .. in this case using safari on 4.2 works really well [00:38:57] our app is slower to move past them [00:39:03] hmmm [00:39:08] so you do ok scrolling past text [00:39:17] it is possible that iScroll 4 does something funny to them [00:39:22] and then you slow down with a slight jerk over an image [00:39:25] likely [00:40:05] another pain is scrolling within the references section [00:40:15] tfinc: does clicking on references work? [00:41:21] let me try [00:43:00] YuviPanda: they work [00:43:05] cool [00:43:23] but scrolling through the list is slower then just text [00:43:38] our css changes should also break some infoboxes [00:43:39] tfinc: stuttery or slower? [00:44:04] slight stutter [00:44:28] possibly some of the styles being used there [00:45:24] tfinc: drafting email [00:45:40] great [00:45:49] i'm going to have put down this laptop in about 5min [00:46:02] tfinc: thanks for doing this :) [00:46:20] :) [00:48:24] i'm going to sign off and check in again in a couple of hours [00:48:30] then we can pick this up tomorrow [00:48:38] YuviPanda: make sure to put the laptop down and get some rest [00:48:58] will try [00:48:59] :) [09:23:45] * YuviPanda checks logs [09:24:09] I downloaded 1.5.0 phone gap , and copied cordova.jar to libs and cordova.js to www , even I got errors in my project [09:24:29] bharath: you need to get 1.4.1 [09:24:32] not 1.5.0 [09:24:51] YuviPanda: ok [09:25:05] enough time spent awake, should go sleep [09:25:07] gnite :) [09:25:15] bharath: you can also ask on #phonegap for phonegap related help [09:25:25] bharath: are you on mobile-tech-l? [09:25:46] YuviPanda: mo [09:25:55] bharath: https://lists.wikimedia.org/mailman/listinfo/mobile-l [09:26:01] you can use that to post questions too [09:36:07] YuviPanda: I can't find link for 1.4.1 .. [09:36:42] bharath: IIRC you don't actually need it unless you are developing for iOS [09:36:48] Android everything is included [09:36:51] ignore the README [09:37:13] there's a doc on mediawiki.org [09:37:15] let me find that [09:38:10] YuviPanda: do I need to copy cordova,jar to libs? [09:38:25] bharath: http://www.mediawiki.org/wiki/Mobile/PhoneGap/Tutorial [09:39:24] that should have clearer instructions :) [09:40:42] bharath: got the link? [09:40:47] * YuviPanda is on an intermittent connection [09:41:00] YuviPanda: yeah [09:41:04] :) [09:41:08] * YuviPanda heads to sleep [13:26:31] when I entered the cmd /tools/android update project -p . , it gives the following error "Error: The project either has no target set or the target is invalid. [13:26:33] Please provide a --target to the 'android update' command. [13:26:35] " [19:43:04] YuviPanda: heya [19:43:14] flyingclimber: heya [19:43:25] i'm back home and ready to move on thigns [19:43:30] * flyingclimber pulls up email [19:43:54] cool [19:44:56] YuviPanda: aww .. did you see the mail from Abdul on the feedback list? [19:45:02] yes :) [19:45:23] i'm betting iOS reviews will improve much better once we have a version that actually works on all versions of iOS [19:46:44] yes. this is why we have to fix #1 and #2 on my list [19:46:47] #3 can wait [19:47:30] yes [19:50:22] * yuvipanda goes back to his terminal IRC client [19:50:29] yuvipanda: just read through your last mail [19:50:30] w [19:50:35] what would you like me test? [19:50:53] flyingclimber: first, we need to figure out which of the infoboxes break [19:51:05] can you brwose around and see where the styles look odd? [19:51:09] sure [19:51:14] i expect things to break in any geography related article [19:51:16] * flyingclimber gets his devices ready [19:51:22] so pick cities, rivers, mountains, etc [19:53:21] are there any branch changes i should pick up ? [19:55:28] * flyingclimber pulls in latest changes [19:56:05] flyingclimber: no [19:56:35] am unsure of what to do with the styles until Jon's back. [19:56:50] also, my sleep cycle today made me wake up about 3 hours ago, so got nothing done :) [19:57:03] so you actually slept [19:57:07] thats good [19:57:08] ; [19:57:10] ;) [19:58:08] :D [20:02:29] missed anything? [20:02:32] yuvipanda: do you have an ether pad started for this? [20:02:41] no, i had to get this phone onto my wifi after resting it [20:02:47] i think we can reuse the one we had [20:02:50] * yuvipanda2 pokes for it [20:03:03] hmm [20:03:13] can't find it, we can just as well create a new one :) [20:03:17] flyingclimber: go ahead and create one [20:03:54] i'll also note that i'm able to click things just fine on first load itself [20:03:57] on the 4.3 sim [20:05:03] ok .. putting my notes here http://etherpad.wikimedia.org/WikipediaMobile-3-1-1-scratchpad [20:06:49] ok [20:07:23] flyingclimber: are you still seeing the 'can not click' issue? [20:07:42] yes [20:07:55] the only way i can pull up an article on the configured language wiki is to search for it [20:08:17] hmm [20:08:30] i'm not seeing that behavior in 4.3 sim [20:08:33] which sucks [20:16:05] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/Vu2RiQ [20:16:05] [WikipediaMobile/v3.1.2-iOS] Hide keyboard once search item has been clicked - YuviPanda [20:16:07] flyingclimber: ^ [20:16:15] pulling [20:16:18] Project WikipediaMobile - Nightly builds build #288: SUCCESS in 7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/288/ [20:16:19] yuvipanda: Hide keyboard once search item has been clicked [20:19:49] flyingclimber: is scrolling past images slower than on yuvi.in/iscroll [20:19:52] ? [20:19:54] yuvi.in/iscroll.html [20:19:57] that is [20:20:24] will check after i test the search fix [20:21:34] ok [20:21:58] keyboard dismissal looks good now [20:23:32] ok [20:23:57] your iscroll demo isn't as smooth as before [20:24:21] so i can't compare [20:24:30] text in app is much better [20:27:07] hmm [20:27:09] right [20:27:14] let me replace the css with what's in the app [20:36:45] flyingclimber: try now? [20:37:55] iscroll.html that is [20:38:00] sure [20:39:07] much better [20:39:19] images? [20:39:35] also check if you have click issues there? They might 404, but do they register? [20:39:37] (clear cache) [20:40:05] clearing cache [20:42:15] unceratain [20:42:45] when i tap expand all i see for content is a grey background [20:42:57] hmmmm [20:43:04] flyingclimber: no links before expansion? [20:43:16] oh wait, you are telling [20:43:22] me that links don't work only on the main page? [20:43:29] of the default language? [20:43:46] i haven't tried links … was just trying to replicate the image issue [20:44:11] ok [20:44:17] let me get rid of the collapsing [20:44:23] the links work fine in the demo [20:44:55] ok [20:44:58] refresh now [20:45:03] i've removed the sectioning related code [20:45:08] inside the app links *never* work in the default language [20:45:21] flyingclimber: even after you navigate via search? [20:45:29] correct [20:45:34] i can search, tap, and load [20:45:42] but none of the article links work [20:45:45] expanding sections works? [20:45:50] citation links? [20:46:24] * flyingclimber expanded demo with images performs better [20:46:44] hmm so that issue is not in iscroll [20:47:28] section expansion and references work fine [20:49:48] hmm [20:49:55] flyingclimber: can you check the xcode log? [20:49:58] *console [20:50:36] i will after i debug a weird issue with reference tapping [20:50:57] which causes you to no be able to scroll past an info box and clears the whole page if you scroll past the footer [20:51:46] uh [20:51:49] ok [20:54:36] confirmed. tapping any reference and scrolling to the bottom of the screen leaves with you just a white article page [20:55:12] i added it to the etherpad [20:55:22] flyingclimber: can replicate this in the sim [20:55:30] k [20:57:27] i'm going to have to add some console.log to see if we ever catch the tap [20:57:35] ok [20:57:41] look around in chrome.js for the links handler [21:12:54] yuvipanda: which function would touch the links ? [21:13:11] its not initContentWithLinkHandlers [21:13:19] it is [21:13:52] that's where we're setting up handlers for a inside main [21:14:13] though i'm not sure why brion used 'delegate' instead of simpler methods [21:17:06] mwhaha .. i may have found it the issue [21:17:09] stay tuned [21:17:25] callin chrome.loadFirstPage before initContentHandlers? [21:17:49] no … far simpler [21:18:08] give me a minute to remove the fix so that i can be sure [21:18:13] ok [21:25:29] [WikipediaMobile] flyingclimber pushed 1 new commit to v3.1.2-iOS: http://git.io/pHAGOw [21:25:29] [WikipediaMobile/v3.1.2-iOS] UIWebView doesn't like upper case HTTP. Needs lower case - Tomasz Finc [21:25:42] Project WikipediaMobile - Nightly builds build #289: SUCCESS in 6.8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/289/ [21:25:43] tomasz: UIWebView doesn't like upper case HTTP. Needs lower case [21:26:25] yuvipanda: i kid you not --^ [21:26:50] ... [21:26:55] i noticed something was up when tapping on an image crashed the app saying HTTP url handling was not supported [21:26:56] an [21:27:02] and it opened up safari instead [21:27:08] brb need to find wall [21:27:15] hehe [21:27:18] back [21:27:35] that also explains the saved pages issue [21:27:41] the regex didn't have an 'i' flag [21:29:40] i think i've isolated the other bug as well [21:30:04] yuvipanda: hmm .. i broke section expansion [21:30:17] with HTTP? [21:30:31] oh wait .. maybe it was just slow [21:30:48] so slow that you thought it was broken :| [21:30:50] ? [21:31:49] hmm .. can't replicate it now [21:32:15] yuvipanda: how goes fixing up the footer clearing the page? [21:32:42] i think i found the bug [21:32:45] and am working on a fix [21:32:50] give me a minute or so [21:39:32] i know the issue but my fix seems to just open the URL in an external page?! [21:39:35] looking.. [21:39:38] . [21:44:50] flyingclimber: i've a fix. [21:44:57] testing on iOS 5 now [21:45:09] we now have 3 variants of scrolling, one for iOS 4.x one for 5.x and one for andorid [21:48:46] k [21:52:36] brb [22:00:04] * tfinc waits for other machine to finish rebooting [22:11:41] there we go [22:16:13] hmm [22:16:18] it works but is a few pixels off on 5.x [22:18:36] whats a few pixels off / [22:18:37] ? [22:19:57] flyingclimber: so, I fixed the page disappearing [22:20:09] but now when I hit the reference, the scroll position is a few pixels off [22:28:01] okay [22:28:04] works on 5.0 [22:28:06] testing on 5.1 [22:28:45] flyingclimber: okay, fixed. [22:28:48] committing [22:31:02] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/075ooQ [22:31:02] [WikipediaMobile/v3.1.2-iOS] Fix issue with scrolling past bottom on iOS 4.x - YuviPanda [22:31:02] flyingclimber: ^ [22:31:12] pulling [22:31:15] Project WikipediaMobile - Nightly builds build #290: SUCCESS in 6.7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/290/ [22:31:15] yuvipanda: Fix issue with scrolling past bottom on iOS 4.x [22:37:32] 2012-04-08 15:37:32.695 Wikipedia-iOS[827:307] Received memory warning. Level=2 :( [22:37:40] after some large article browsing [22:39:32] tfinc: crashes? [22:39:37] yes [22:41:16] :( [22:41:23] let me start on some memory debugging [22:41:31] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/OTO4BA [22:41:31] [WikipediaMobile/v3.1.2-iOS] Move to iScroll-lite - YuviPanda [22:41:45] Project WikipediaMobile - Nightly builds build #291: SUCCESS in 6.8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/291/ [22:41:45] yuvipanda: Move to iScroll-lite [22:41:46] as a first step, replaced iScroll4 with iScroll4-lite. Same iScroll, no zoom features, etc [22:41:54] tfinc: was the 'page blanking' bug still there? [22:42:21] no. thats fixed [22:42:30] ok [22:42:38] tfinc: which article crashed it? [22:43:27] tfinc: also, try on 5.x? [22:43:56] I was reading the New York article but that came after a sequence of big articles like Ancient Rome ... etc [22:45:28] tfinc: try replicating it and see if you can get a article list / count? [22:47:13] i'm going to have to attach instruments to this. this phone got really hot after 5-6 big articles [22:47:39] ouch [22:47:51] jailbroken phone with anything running in the bg? [22:48:00] according to SO, level 2 is sent to all apps when the phone runs low on memor [22:48:03] y [22:48:14] it lost the jail break after i reset it [22:48:21] only other app was safari [22:48:46] ok [22:51:38] i lost the ether pad link after rebooting .. can you paste it back in … i have a new bug [22:51:49] sure [22:52:17] were keeping window focus across page loads making any new article open at the exact same place [22:52:40] http://etherpad.wikimedia.org/WikipediaMobile-3-1-1-scratchpad [22:52:51] tfinc: aka not scroll to top? [22:53:02] yes [22:54:00] looking into it [23:01:57] Fixed this, but that makes expanding sections intermittently not work [23:01:59] ... [23:04:44] ok [23:04:46] looks fixed [23:10:42] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/GwApFw [23:10:42] [WikipediaMobile/v3.1.2-iOS] Reset scroll to top on opening new pages - YuviPanda [23:10:47] flyingclimber: tfinc ^ [23:10:55] Project WikipediaMobile - Nightly builds build #292: SUCCESS in 6.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/292/ [23:10:55] yuvipanda: Reset scroll to top on opening new pages [23:11:03] pulling [23:17:38] yuvipanda: seems to be fixed [23:17:40] tfinc: did a run with allocations. Increased only two MB, not enough to actually kill the app... [23:17:48] went through ~8 large-ish articles [23:17:51] tfinc: cool [23:17:59] were you able to repro the OOM error again? [23:18:15] yuvipanda: using instruments on 4.2 is a mess. it actually makes the phone unstable [23:18:28] and it can't even load a single article when instruments is attached [23:18:29] i... see [23:18:34] i ran it on the sim [23:18:41] but detached the app is better [23:18:55] were you able to make it crash with an OOM again? [23:19:14] haven't been able to yet [23:19:19] ok [23:21:38] i need to step away for 30min [23:22:02] ok [23:29:39] * yuvipanda should crash sometime soon [23:32:27] back [23:32:42] yuvipanda: you crashing for the night ? [23:32:45] not yet [23:32:55] will be up for an hour or so i guess [23:32:58] at least [23:33:17] who am I kidding I'll probably end up staying up for another 6 or so hours :) [23:33:19] nevermind [23:33:35] tfinc: all the issues I see there (except images being slow) are style ones. I'm trying to figure out how to fix them [23:33:42] k [23:33:55] looks like doing the replaces that were happening in CSS in js are the way to go. [23:34:10] tfinc: what are you currently testing? [23:34:30] yuvipanda: nothing right now [23:34:33] need something ? [23:34:41] nah, just general 4.2 testing [23:34:53] k. i'll keep on that [23:34:56] if those in the etherpad are the only ones you're seeing, i'm good [23:35:00] also, upgrade testing [23:35:09] so far yes [23:35:21] 2.x -> 3.1.2 and 2.x -> 3.1.1 -> 3.1.2 [23:42:21] yuvipanda: do you have anyone with 4.3 who can test on device? [23:42:52] yuvipanda: browsing around is certainly better but long articles continue to be frustrating to navigate. i wonder how much of our time were going to lose in order to make small cpu gains [23:43:23] tfinc: I'll ask around on sane people hours and see if I can get one [23:43:51] k [23:44:10] and I'm not sure how much time we should spend, considering 1.2 move to the API which will change a lot of the code hence making any profiling we do here useless [23:50:41] if 4.3 works really well then i'm considering dropping support for 4.2 [23:50:47] its going to continue to be a pain in the ass [23:50:56] and i hate cross ocean debugging ;) [23:51:43] hehe [23:52:01] tfinc: how many iOS devices do you have? [23:52:06] any chance you have one with 4.3? [23:52:26] iOS 3.1.3, 4.2, 5.0 [23:52:37] can any of them go 4.3? [23:52:52] or we could just wait for tomorrow(?) and find someone with 4.3 to test [23:52:53] nevermind [23:53:00]