[00:01:06] YuviPanda: need any testing ? [00:01:10] tfinc: yes [00:01:16] pull the v3.1.2-iOS branch [00:01:21] the search delay fix is there [00:01:23] try that out [00:01:47] so preilly if i use //m.wikipedia.org/wiki/Wikipedia:Text_of_Creative_Commons_Attribution-ShareAlike_3.0_Unported_License?useformat=mobile instead of //wikipedia.org/wiki/Wikipedia:Text_of_Creative_Commons_Attribution-ShareAlike_3.0_Unported_License?useformat=mobile [00:01:49] tfinc: then try https://github.com/yuvipanda/WikipediaMobile/tree/v3.1.2-iOS-no-large-images on articles with large images. [00:01:49] np [00:02:16] k, pulling [00:02:53] YuviPanda: i'm planning on leaving the office @ 18:30 PST [00:02:56] so thats about 1.5 hrs [00:03:17] tfinc: IMO if the search performs okay we can do an RC [00:03:18] how goes that line up with getting RC1 ready? [00:03:41] only thing i'm trying is to figure out a way to have minified files [00:04:07] (which requires debug/production separation) or I could just do it as a hack. Currently doing the latter [00:04:24] philinje: http://mobilehtml5.org/ [00:04:30] jdlrobson: fun one for you too --^ [00:04:36] New patchset: Jdlrobson; "use more specific link for license info" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4600 [00:05:18] tfinc also fun - http://www.browserscope.org/ [00:05:41] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4600 [00:05:43] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4600 [00:05:50] thats a good one too [00:07:28] tfinc: thanks [00:07:35] jdlrobson: can you get that change on your vm or something and post a link to it on the bug so that Pete can test it [00:09:18] YuviPanda: whats your key press timeout ? [00:09:24] tfinc: 750ms [00:09:48] so, when there is a 750ms gap without any keypresses, network req will be made [00:11:05] YuviPanda: much better [00:11:12] tfinc: usable? [00:11:32] yes [00:11:51] did you make this switch for all versions or just iOS4.2 ? [00:12:12] tfinc: all [00:12:13] versions [00:12:19] i think it makes sense, i'll merge that into master too later [00:12:51] preilly: does this link work for you? [00:12:52] http://bit.ly/Icu8Ob [00:13:28] jdlrobson: yes [00:13:36] my android is being weird [00:14:06] jdlrobson: in what way? [00:14:42] it redirects to sportspyder.com [00:14:42] YuviPanda: given the small amount of screen real estate were going to have to dismiss the keyboard upon full screen search scrolling .. not a blocker for 3.1.2 but a necessary feature [00:14:48] on iOS [00:15:01] tfinc: file a bug? [00:15:06] anyway.. it works for me but i'll add that link [00:15:12] i can dismiss it on first touch on non-searchbar/non-keyboard [00:15:13] yes [00:15:55] tfinc: file a bug, will do that on [00:16:21] done [00:16:23] oh .. landscape view [00:17:18] tfinc: i'm unsure what to do on landscape view. [00:17:25] other than autohide [00:17:56] cut it in half [00:18:11] ? [00:18:18] reduce the size? Move them both to the top? [00:18:30] on the same line? [00:18:38] i'm still a fan of autohide, but that comes after this, I guess [00:19:12] reduce the size [00:19:56] tfinc: file a bug :) [00:19:57] our nav+search take up half the screen in landscape [00:20:04] i did .. trying to find it ;) [00:20:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=35795 :D [00:20:56] but really dismissing the nav is going to be the really fix [00:22:12] also patrick any idea about https://bugzilla.wikimedia.org/show_bug.cgi?id=31510 [00:22:15] preilly: ^ [00:23:43] jdlrobson: what do you mean idea? [00:24:06] well do you know what it means, and why it was removed and if it is still relevant? [00:24:09] jdlrobson: http://mobile-geo.wmflabs.org/w/index.php?title=Main_Page&useformat=mobile&mobileaction=beta … what happened to more/less on the top right ? [00:24:35] good question [00:24:40] some how they have disappeared! :) [00:24:44] find them! [00:24:51] we miss them [00:25:19] my local is fine.. [00:25:20] its funny … i really can't use the site in non beta mode anymore [00:25:30] must have new design :D [00:26:02] jdlrobson: 'wmgMFRemovableClasses' => array( [00:26:03] 'default' => array( 'table.metadata', [00:26:04] '.metadata mbox-small', [00:26:06] '.metadata plainlinks ambox ambox-content', [00:26:07] '.metadata plainlinks ambox ambox-move', [00:26:08] '.metadata plainlinks ambox ambox-style', ), [00:26:09] ), [00:26:17] ahhh of course tfinc [00:26:25] jdlrobson: in fenari:/home/wikipedia/common/wmf-config/InitialiseSettings.php [00:27:39] fixed [00:28:27] just opened a ticket about a caching issue with mf - https://bugzilla.wikimedia.org/show_bug.cgi?id=35842 [00:28:45] binasher: thanks! [00:28:53] preilly: i'm not sure what i'm looking at :( [00:29:02] might be because I'm entering sleepy mode [00:29:05] binasher: can I get that as a pretty graph? [00:29:25] jdlrobson: those are classes that are removed [00:29:36] jdlrobson: e.g., table.metadata... [00:29:37] * binasher prints out a pretty graph, gives preilly a paper cut [00:30:01] * preilly bleeds  [00:30:21] ohno :( [00:30:44] * preilly — stops hemorrhaging [00:30:53] ah i see preilly - just seen the comment there [00:31:01] so this is addressed? [00:31:49] jdlrobson: I think so [00:32:42] well closing then [00:32:47] jdlrobson: okay, great [00:32:51] if it's not someone can tell me otherwise :) [00:33:18] * preilly — notes that it's 1:32am Tuesday (BST) - in Kent, UK [00:33:45] that's pretty early [00:34:01] by Panda standards [00:34:57] indeed [00:35:51] preilly: the Makefile in MF mentiones yuicompressor.jar. Is that included in the repo? [00:37:38] no it isn't. [00:37:39] not just me [00:37:41] nevermind [00:38:38] i read that as yuvicompressor.jar and got worried [00:40:25] YuviPanda: no [00:40:36] tfinc: compresses yuvi into jars? [00:40:39] tfinc: ha ha ha [00:40:43] ROFL [00:40:49] canned yuvi [00:40:53] if that happens, I'll update yuvi.in/where.html [00:40:56] a great travel treat [00:41:08] :D [00:41:19] on the plus side, no visas! [00:42:56] YuviPanda: you have worked from weirder places [00:43:37] weirdest is possibly in one of http://www.shatabdigaurav.com/images/share_auto.jpg [00:43:44] I was, however, sitting inside [00:44:23] i've actually jumped off a just-moving train laptop open in hand because i forgot my station has turned up [00:44:55] YuviPanda: the US must be so tame for you [00:45:30] tfinc: you can easily go rock climbing climb to the top *and then* write code. [00:45:35] opportunities for these are there everywhere :P [00:45:38] and then? [00:45:43] space [00:45:45] Do it on the way up [00:45:59] and then do it on the way down. [00:46:07] we don't get enough commits at 30,000 ft either [00:46:20] and then do it while belaying, though the other person might not like that [00:46:26] Make that a challenge for WM2012 [00:46:54] oooh, how about writing code while crossing a Road? [00:47:00] in India, possibly Mumbai [00:47:09] at around 4PM or 9AM [00:47:13] *that* would be something [00:47:14] I guess bonus points if you ever actually get to commit said code? [00:47:51] i'd like to see the fundraiser banner for that - Send me to space! an appeal from Yuvaraj Pandian [00:47:55] with emphasis on 'you' [00:48:11] i'd donate to that [00:48:18] one way trip to mars [00:48:20] Will our mobile app work in space? WE NEED TO FIND OUT! [00:48:22] especially if yuvi wears a space suit in the photo [00:48:26] 'the internet here is bad, but not as bad as back in chennai!' [00:48:35] wait [00:48:40] 'the wifi here is bad, but not as bad as SF office' [00:48:43] #FTFY [00:48:45] You can get to Mars and back many times in your lifetime [00:49:07] i have heard someone say desktop development is like earth, mobile is like mars [00:49:39] YuviPanda: though, doing OSX updates while travelling might be an issue [00:49:43] * tfinc keeps filing bugs [00:49:45] (to mars) [00:50:07] do i need to get special funding to send Yuvi to space? [00:50:08] Reedy: clearly, you need MS-DOS running to go to Mars [00:50:14] i can put in a line item of rthat [00:50:19] interstellar travel [00:50:28] i'm sure someone will fund it [00:50:38] kickstarter [00:50:46] but only if Max can guarantee our api will show articles near yuvi on mars [00:51:03] 'pledge 5000 rupees more and i'll scream obscenities at the editor of your choice from space!' [00:51:06] err [00:51:08] not rupees. [00:51:11] i meant dollars. [00:51:12] not as chea [00:51:12] haha [00:51:13] p [00:51:21] nope, you said rupees [00:51:23] You need a laser beam too... [00:51:32] Reedy: with the shark attached? [00:51:38] Preferably [00:51:50] YuviPanda: making your going rate 97.7796 USD [00:52:13] YuviPanda: 30min warning [00:52:17] Reedy: if sharks can survive in the air, we're in a lot of trouble. [00:52:18] YuviPanda: where are we at? [00:52:26] tfinc: sharks and space. [00:52:30] going back to yuicompresser now [00:52:41] tfinc: i think once we try that out and see if it has any effects, we can cut an RC [00:52:45] k [00:53:06] hmm, I don't think I can do a proper 'split' in time [00:53:09] * YuviPanda starts writing hack [00:55:56] YuviPanda: as we fix everything else .. https://bugzilla.wikimedia.org/show_bug.cgi?id=35843 is biting us badly [00:56:00] especially since its blocking [00:56:14] jdlrobson: ^ [00:56:24] jdlrobson: anything we can do to speed that up, other than the API? [00:56:58] will look [00:57:35] regexs can't be good [00:57:54] oh yes, that's there too [00:58:01] jdlrobson: doesn't DOM parsing/loading block? [00:59:29] this is going to be one of those annoying onces I can't replicate in my VM easily :/ [01:02:32] * YuviPanda twiddles thumbs as yuicompressor does its thing [01:05:31] tfinc: https://github.com/yuvipanda/WikipediaMobile/tree/v3.1.2-iOS-minify-hack [01:05:52] tfinc: pull, go to commandline, execute assets/compress.bash do not look at git diff, then build [01:07:22] pulling [01:07:48] YuviPanda: do you want me to clones that fork ? [01:07:50] clone* [01:07:53] tfinc: ? [01:07:58] you have me as a remote, right? [01:08:03] no [01:08:19] but i can add it [01:08:23] one sec [01:08:24] sur [01:08:24] e [01:12:27] YuviPanda: which branch ? [01:12:32] v3.1.2-iOS-minify-hack ? [01:12:34] yes [01:12:59] i'm missing the yuvi compressor :( [01:13:14] Unable to access jarfile yuicompressor.jar [01:13:17] too soon [01:14:07] tfinc: right. stupid code. [01:14:11] tfinc: cd to assets and then run it [01:14:27] 'go to your assets, you'll find the yuvicompressor' [01:14:27] its compressing now [01:14:28] yeah [01:14:35] * tfinc waits [01:14:54] org.mozilla.javascript.EvaluatorException: Compilation produced 3 syntax errors. [01:15:08] yeah, ignore that for now. i'm looking into it [01:15:13] the app still works despite [01:15:22] hmm [01:15:39] * tfinc goes to build the app [01:16:05] i'm not sure about bug https://bugzilla.wikimedia.org/show_bug.cgi?id=35843 [01:16:37] wrapping the success of loadPage in a timeout might reduce any blocking - but very hard to explore this with a vm that doesn't replicate live environment [01:17:00] i've tried timing the renderHtml function but there doesn't seem much consistency in results [01:17:02] jdlrobson: isn't DOM parsing 'blocking'? [01:17:17] i believe so [01:17:27] YuviPanda: i should be testing app load time right .. time to first article load ? [01:17:31] tfinc: yes [01:18:32] YuviPanda: not enough of a speed up to make it worth it [01:18:44] :( [01:18:49] it still takes about 5 seconds to get past the spinner [01:18:55] whats is happening then ? [01:19:15] tfinc: does it reduce time after the 'spinner'? [01:21:07] if it does then i can't see it [01:21:30] hmm, clean and build once again just to be sure? [01:21:35] sure [01:22:08] unless we were doing something extraordinarily stupid yuicompress shouldn't give us that much a speedup, but it was worth a shot [01:22:43] no perceivable speed up [01:22:48] ok [01:22:52] sigh [01:23:01] tfinc: we won't be getting any until the swich to require.js [01:23:04] tfinc: cut an RC? [01:24:02] is require.js the api switch ? [01:24:42] tfinc: API switch will reduce per-page load [01:25:02] tfinc: require.js lets you load js as and when you need them only. Reduces memory footprint + startup time [01:25:12] YuviPanda: cut an rc from v3.1.2-iOS ? [01:25:16] initially not scheduled for 1.2, but i guess we'll have to sit and talk about that after the dust on this clears [01:25:22] yes. we will [01:25:30] tfinc: wait, let me update the moniker in about [01:25:35] k [01:26:06] tfinc: pushing. [01:26:14] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/U1K9MQ [01:26:14] [WikipediaMobile/v3.1.2-iOS] Update Version number - YuviPanda [01:26:19] tfinc: ^ [01:26:27] Project WikipediaMobile - Nightly builds build #316: SUCCESS in 6.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/316/ [01:26:27] yuvipanda: Update Version number [01:26:42] tfinc: can you poke brion for some iPad testing [01:27:30] YuviPanda: he's not in the office [01:27:33] was working from home [01:27:42] ok [01:31:47] * tfinc has to clean up his stashes before he can compile RC1 [01:33:43] * jdlrobson is struggling to stay awake - tfinc YuviPanda how much longer do you need me for? [01:34:02] jdlrobson: i guess you should crash? unless tfinc has something else... [01:34:19] jdlrobson: go to bed [01:34:45] drop me a mail with anything you want me to look into tomorrow ... preferably ones i might be able to replicate :) [01:37:51] tfinc: how long a testing cycle should we be looking at? [01:40:58] hmm [01:41:05] pretty short [01:41:11] this is an emergency bugfix [01:41:12] 24hrs [01:44:14] screw trying to make git behave .. i'm just re-cloning [01:45:02] tfinc: git reset —hard origin/master [01:45:06] why reclone? [01:45:23] i couldn't get the git index to a happy state [01:45:30] it kept showing me modified file [01:45:31] s [01:45:34] and i got tired of it [01:45:36] heh [01:45:53] git branch -b gitisannoying origin/master [01:45:56] err [01:46:05] s/git branch/git checkout/ [01:46:16] your current branch may have been totally screwed [01:46:37] tfinc: git reset --hard not working? [01:46:55] * YuviPanda wonders how tfinc got git there [01:50:06] meh [01:50:13] it was easier to just clone [01:51:05] * tfinc goes to create the ipa [01:51:41] * tfinc waits on app validation [01:51:44] no issues found [01:53:51] YuviPanda: http://dumps.wikimedia.org/iOS/Wikipedia-3.1.2-RC1.ipa [01:53:54] give it a spin [01:54:09] Ryan_Lane: i should be good to go in about 5 [01:54:15] ok [01:55:20] tfinc: ok [01:55:28] tfinc: make sure you have it on your devices too [01:55:36] i'll poke the people who tested it last time and see if they would be able to help [01:55:38] YuviPanda: i'm going to try it on the iPad [01:55:51] and on the other two IPhones as well, I hope :) [01:58:51] YuviPanda: will do post climbing tonight [01:58:56] cool [01:58:58] enjoy climbing [02:00:09] YuviPanda: crash on page save iPad2 [02:00:21] iOS version? [02:00:24] 5.1 [02:02:03] my screen is too small for me to reach the top part of the iPad sim [02:02:04] ... [02:02:25] nevermind [02:02:51] tfinc: again, works on the simulator [02:02:52] gah [02:03:13] had to remove the app [02:03:19] now it works fine [02:03:33] were ok [02:03:54] YuviPanda: need anything from me ? [02:03:57] nope [02:04:00] i'll back on in a couple of hours [02:04:02] tfinc: when will you be back after climbing? [02:04:02] k [02:04:05] hmm [02:04:10] 11PM PST [02:04:12] i'm reasonably sleepy not sure if i'll be up or not. [02:04:19] so about three hours [02:04:26] ok [02:04:34] do poke / test at it even if i'm not around, and email me if you need me [02:04:49] will do [02:04:56] are you mailing this to mobile-l ? [02:05:02] yeah [02:05:06] k [02:05:10] writing it out now [02:06:24] k [07:58:15] New review: MaxSem; "Where's FIXME in Gerrit? :P First, this change leads people browsing the safe site to bare HTTP, sec..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4600 [09:13:02] New patchset: MaxSem; "Follow-up change 4587: redirect from old URLs to new special page." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4605 [10:51:59] New patchset: MaxSem; "Switched enabling/disabling images to Special:MobileOptions" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4610 [11:02:13] jdlrobson, I can't find the "leave feedback" link in current design. any ideas where it is? :P [11:02:26] in the beta or norm? [11:02:59] oh, stupid /me [11:03:04] :) [11:03:11] [WikipediaMobile] reedy pushed 2 new commits to master: http://git.io/GYLNdw [11:03:11] [WikipediaMobile/master] Syntax error in attribution-osm message - Minh Nguyễn [11:03:11] [WikipediaMobile/master] Merge pull request #204 from 1ec5/patch-1 - Sam Reed [11:03:13] ON / OFF switch [11:03:25] Project WikipediaMobile - Nightly builds build #317: SUCCESS in 7.1 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/317/ [11:03:25] mxn: Syntax error in attribution-osm message [14:31:42] New patchset: Jdlrobson; "remove default styling in firefox mobile (fennec)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4633 [14:39:23] New review: Jdlrobson; "On my mobile it seems visiting http://wikipedia.org or https://wikipedia.org redirects me to http://..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4600 [14:53:05] New patchset: MaxSem; "Move feedback functionality to Special:MobileFeedback." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4636 [15:52:53] New patchset: Jdlrobson; "temporarily override common.css rule" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4642 [16:36:18] New patchset: Jdlrobson; "changes to references for consumption by mobile app" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4646 [16:42:14] Project WiktionaryMobile - Nightly builds build #56: SUCCESS in 7.1 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/56/ [16:42:15] hy.cheng: fixed Forwards button being permanently disabled [16:45:57] Project WiktionaryMobile - Nightly builds build #57: SUCCESS in 7.1 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/57/ [16:45:57] pfhayes: fixed Forwards button being permanently disabled [17:06:51] * YuviPanda pokes maplebed  [17:07:12] * maplebed bites off YuviPanda's finger [17:07:25] which one? [17:07:27] NOMS [17:08:03] (you never know what might happen when you poke me. Sometimes it tickles, and sometimes I bite off your finger.) [17:08:11] maplebed: http://lists.wikimedia.org/pipermail/mobile-l/2012-April/005486.html [17:08:27] maplebed: i like people biting off fingers more :P I'm sure I can grow them back [17:08:50] maplebed: please do test. We're getting hammered in the App store, and would like to get this update out asap [17:09:11] I'm sorry, I don't have time to test this week. [17:09:15] ouch [17:09:19] ok [17:09:27] guess it's time to hire someone to do qa. [17:09:30] maplebed: i'll poke you for our next releases then. [17:09:35] maplebed: we're on it. [17:09:50] maplebed: should hopefully have someone in a few weeks (or less (or more)) [17:12:05] maplebed: thanks anyway :) [17:24:45] greetings all [17:24:50] YuviPanda: hows RC1 looking ? [17:25:06] Reedy: how did the new android emu work out? [17:26:09] tfinc: reasonably bad, have been poking prior testers individually, haven't gotten anyone to bite. Just got on, so continuing poking [17:26:24] emailing Axel now [17:26:35] bad meaning its not working well or bad because no one has responded ? [17:27:44] bad because nobody's responded. [17:27:50] (yet) [17:28:08] lifeeth: poke. Think you'll be able to test out the iOS app a bit today? [17:28:12] YuviPanda: who do we know that has 4.2/4.3 ? [17:28:29] we should add iOS versions to the spreadsheet [17:28:33] Axel, kaldari [17:28:36] and/or device [17:28:38] hmm, yes. [17:28:42] YuviPanda : the iOS devices are in Delhi [17:28:42] jarry has a 4.x device as well [17:28:44] and I am in BLR [17:28:45] :| [17:28:47] lifeeth: :( [17:29:05] tfinc: emailed axel, kaldari not on IRC, Jarry missing too. I'm going to leave a talk page message for Jarry now [17:29:31] YuviPanda: i'll try and find kaldari [17:29:36] cool [17:29:38] YuviPanda: what about james ? [17:29:43] what iOS ver. does he have? [17:30:26] tfinc: not sure, he didn't respond last time either [17:31:19] tfinc: From what I now see, you have a 4.2 device, philinje has a 4.3 device, jarry has a 5.0 device and I have a 5.1 device [17:32:05] tfinc: i'm sending kaldari an email [17:34:12] YuviPanda: mail staff and see who bites [17:34:18] ok [17:35:02] awjr, how was your vacation? [17:35:14] MaxSem: awesome :) [17:35:33] but now trying to wade through a bazillion emails [17:36:12] awjr, meanwhile I've solved the problem of MF borking forms: now special pages can order it to omit some transformations [17:36:39] MaxSem that's awesome - i had figured something similar out in the contact-us-redesign branch [17:36:46] but you did this in master? [17:37:18] no [17:39:45] awjr: welcome back! [17:39:55] tfinc: thanks :) [17:40:56] awjr, I lied - first commit of this saga is already in master [17:41:26] so you just need to $wgExtMobileFrontend->setContentTransformations( false ); [17:42:11] YuviPanda: does brion have a device that would help in testing ? [17:42:46] tfinc: he'd be able to help us test with the iPad, but I'm not sure if he has an older device [17:42:49] you guys on ios 4.x stuff still? fraid not [17:43:03] brion: we cut RC1 and need 4.x testers [17:43:15] brion: quick .. downgrade your portable OS! [17:43:25] lemme see what i can do :) [17:44:03] kaldari: ! [17:44:11] kaldari: thanks for joining [17:44:14] YuviPanda: --^ [17:44:23] howdy folks [17:44:27] kaldari: hello! [17:44:34] we've fixed major issues with your version of iOS [17:44:38] can you help us test it out [17:44:38] ? [17:44:40] kaldari: ^ [17:45:14] What's the URL for d/ling the App again? [17:45:33] nevermind [17:45:36] I see it in the email [17:46:57] downloading now [17:49:03] kaldari: thanks! [17:50:28] YuviPanda: is this fixed https://bugzilla.wikimedia.org/show_bug.cgi?id=34908 ? [17:52:25] tfinc: updated bug [17:52:30] thanks [17:52:38] * tfinc wonders where preilly is [17:56:00] ok i've got an iphone 3gs running 4.3.2, managed to activate it by borrowing my wife's sim card :P :) [17:57:47] and…. xcode won't attach to it. nice. [17:58:11] let's see if the "ios 4.0 - 4.1 device debugging support" is just misnamed [17:59:05] going afk for about 20 minutes [18:11:13] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4605 [18:11:15] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4605 [18:12:52] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4610 [18:12:54] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4610 [18:13:24] preilly: last week you mentioned that you had spare cycles. could you get the bugzilla bot working during your spare cycles ? [18:13:30] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4633 [18:13:32] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4633 [18:13:49] ok, so iscroll is pretty painful on the articles :( [18:13:50] oh wells [18:14:36] brion: still? [18:14:41] Hi Amgine - where's the standup, again? [18:14:43] on which device/version? [18:14:52] #Wiktionary-mobile, sumanah [18:15:35] Project WiktionaryMobile - Nightly builds build #58: SUCCESS in 7 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/58/ [18:15:36] pfhayes: Fixing MobileFrontend.toggle for v1.0.1b [18:15:43] lemme make sure i'm up to date [18:15:47] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4636 [18:15:49] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4636 [18:16:06] brion: not master. v3.1.2-iOS [18:16:12] ah [18:16:42] jdlrobson: https://gerrit.wikimedia.org/r/#patch,sidebyside,4642,1,MobileFrontend.php [18:16:56] jdlrobson: $wgMFConfigProperties = array( [18:16:57] 142 » 'minifyJS' => false, [18:16:58] 143 » 'isBetaGroupMember' => true, [18:16:59] 144 ); [18:17:19] jdlrobson: you should be setting this in your LocalSettings.php NOT directly in the code [18:20:02] preilly, thanks [18:20:05] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4646 [18:20:08] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4646 [18:20:13] for some reason i can't get v3.1.2-iOS to run. somewhere during startup i get 'broken pipe' wtf [18:20:24] MaxSem: np [18:20:37] jdlrobson: ping [18:21:11] broken pipe?! :| [18:21:17] yeah srsly [18:21:36] MaxSem: i just saw https://gerrit.wikimedia.org/r/#change,4636 - this duplicates work we've already been doing in the contact-us-redesign branch [18:21:36] New review: preilly; "$wgMFConfigProperties = array(" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/4642 [18:21:39] ends up stuck on the splash screen, never gets past it [18:22:02] lemme restart stuff :P [18:22:07] preilly: i saw that you approved https://gerrit.wikimedia.org/r/#change,4636 but this duplicates work that jon and i have been doing in the contact-us-redesign branch [18:22:12] awjr: it was just refactoring [18:22:34] Project WiktionaryMobile - Nightly builds build #59: SUCCESS in 7.1 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/59/ [18:22:34] pfhayes: Adding xhdpi version of share for v1.0.1b [18:22:42] awjr: I figured you would update your branch and overwrite it with your changes [18:23:10] preilly: the special page changes that MaxSem has been doing is a different approach than we've taken in contact-us-redesign [18:23:23] awjr: in what way? [18:24:08] preilly well for contact-us-redesign we had talked about having just one special page acting as a controller for different things we'd want to use special pages for, whereas it looks like MaxSem has gone down the road of using different special pages for different functionality [18:24:30] page names are cheap, awjr [18:24:39] awjr: well, MaxSem has a MobileOptions page for all options [18:24:51] awjr: and a MobileFeedback page for all feedback [18:24:59] MaxSem for sure but we've now duplicated a lot of the same work in different ways and now we have to figure out how to merge them [18:25:14] lemme look at your work [18:25:19] awjr: I don't really think it's much duplication [18:25:38] MaxSem - it's in the contact-us-redesign branch [18:25:39] awjr: he basically just refactored a little bit and move some stuff around [18:26:00] YuviPanda: whee! got it running. much better than master on ios 4.3.2 [18:26:07] ok - when i wrap up the mobile cookie stuff i can take a look at what it will take to merge these together [18:26:10] awjr: it wouldn't be difficult to collapse this all in to one special page [18:26:11] MaxSem, preilly ^ [18:26:45] but why put it into the same special page? [18:27:19] i tried 'share to twitter' and now some of the toolbar items are broken. can't open up the share or source menus anymore [18:28:01] MaxSem: just to minimize the routes for mobile related activities [18:28:03] MaxSem it was a design decision made based on a conversation with preilly to have a special page acting as a controller (in an MVC kind of way) [18:28:46] isn't MVC an overkill for these simple forms? [18:29:09] instead of putting everything into one page, you can inherit from one base class [18:29:46] MaxSem i dont think it's overkill as in the end, it's not just for the feedback form. [18:30:14] but the other approach is totally valid as well, and probably more typical for MediaWiki [18:30:30] brion: hmm, share to twitter not available on < 5.x. Let me disable that [18:30:53] i guess we need to come to a decision on which approach to use and then i can start merging our changes together [18:30:58] preilly, MaxSem ^ [18:31:17] YuviPanda: thx; here's a bz entry for it: https://bugzilla.wikimedia.org/show_bug.cgi?id=35863 [18:31:40] awjr, MaxSem: So, my preference is an MVC style [18:32:06] preilly, awjr, MF has enough code untypical for MW already. adding more isn't helpful if we want to merge it with core eventually [18:32:09] awjr, MaxSem: I don't mind if we inherit from one base class or not [18:32:49] MaxSem: So, is that the only reason that you dislike this? [18:33:56] MaxSem, preilly: we should probably think about this with an eye towards ultimately moving this stuff into core. generally speaking, my personal preference on the matter is more MVC-style, but for the sake of getting things into MW core perhaps MaxSem's approach is more sensible [18:34:15] I can't say for sure before looking thoroughly through Arthur's code [18:34:19] looking right now [18:36:16] awjr: What is your plan for the cookie changes at this point? [18:36:41] awjr: Also, have you read binasher 's most recent email regarding cache issues? [18:36:49] preilly: what's left is implementing the canonical redirects [18:37:09] preilly: no im not sure i've seen it - what's the subject line? (i'm still wading through post-vacation emial backlog) [18:37:31] awjr, first of all, MW has HtmlForm [18:38:23] awjr: [Bug 35842] New: MobileFrontend breaks frontend caching in some cases [18:38:24] MaxSem: i know, but i figured i wanted to take a phased approach to changing how the feedback form works, which is why i left it using the 'template' [18:38:47] awjr, but you already started your own validation framework [18:39:29] awjr: you don't really mean canonical do you? [18:39:58] bbiab [18:40:02] awjr: you mean format based redirects right? (e.g., mobile to .m. and desktop sans .m., etc.) [18:41:15] preilly: yes you're correct [18:42:00] awjr: did you look at that bug? [18:42:46] preilly yes [18:43:02] but i dont think this will work - "Instead of setting useformat=desktop, delete the cookie when switching to the desktop view. " [18:43:46] actually never mind i see what asher's getting at [18:45:36] preilly i need think more about this in order to make sure that the code changes aren't going to just be WMF-centric again [18:47:11] there shouldn't be anything incompatible with universality in the logic outlined in the ticket [18:47:31] awjr: would it make sense to step back and remove all of the cookie logic and start fresh? [18:47:51] preilly that might depend on what you mean by 'fresh' [18:48:53] awjr: well, I meant it in the, " full of or renewed in vigor " sort of way… [18:49:22] lol [18:50:13] lulz [18:50:18] preilly i think there's valuable stuff still there that we'd wind up just implementing again if we just got rid of it all [18:50:20] awjr: so, I was thinking remove all the cookie logic and just implement the format specific redirects [18:50:39] awjr: then add the stop redirect cookie [18:50:52] awjr: the stop redirect cookie can be done as a hook [18:51:04] awjr: to avoid WMF-centric criticism [18:51:20] awjr: like what stuff? [18:52:02] preilly how would we accomodate context-switching for people running MF from a single instance of MW and do not have mobile-specific domains set up? [18:52:53] awjr: and no path either? [18:53:12] preilly: right [18:53:23] MF doesn't support mobile-specific paths now anyway [18:53:26] this RC1 is pretty rapid [18:53:36] awjr: I understand that [18:53:59] awjr: well, if we don't have a domain part we just append use format to the redirect right? [18:54:21] preilly: with no cookies that would not be 'sticky' [18:54:57] can we start saying persistent instead of 'sticky' [18:55:06] preilly: awjr : jdlrobson : MaxSem : who's got some spare cycles to do an assessment of the upload wizard for WLM ? i have more specifics [18:55:18] WLM? [18:55:24] WLM? [18:55:26] preilly ok, with no cookies that would not be persistent [18:55:29] oh, monuments [18:55:35] wiki loves monuments [18:55:40] oh, monuments [18:56:12] someone should fix that noprint bug though. Is that filed in Bugzilla? [18:56:12] awjr: let me think about it for a minute [18:56:21] kaldari: yes, I think that it is [18:56:26] it's not specific to the mobile app though [18:56:36] kaldari: yeah, that's a MF thing too [18:56:37] preilly i understood this project originally to be a way to simplify desktop/mobile switching both for WMF implementations as well as non-WMF implementations in such a way that anyone could rely on it - meaning, no special server configuration, url switching, etc [18:57:12] awjr: yeah, that's my understanding as well [18:58:13] tfinc: im feeling a little swamped with persistent cookie stuff + contact us redesign stuff, but if WLM is higher priority than either of those, i can take a look [18:59:09] tfinc: I can look at it [18:59:21] awjr: don't worry about WLM [18:59:32] tfinc: unless MaxSem really wants to do it…. [18:59:32] its not higher priority [18:59:56] tfinc, I can look [19:00:16] i need one of you to take a look at the code and see how easy making changes to the backend and js are going to be [19:00:32] MaxSem: k, i'll mail you the info [19:01:21] awjr: so, regarding the cookie need for a single MW instance [19:01:24] preilly we could make whether or not the cookie varies the cache configurable and only do redirects if there's a specific mobile domain configured [19:01:30] awjr: can we just set the cookie only in that case? [19:02:03] awjr: so, only set the cookie if there isn't a mobile domain [19:02:14] preilly i think we need to set the cookie in either case - if you're on a mobile device the MF knows is a mobile device and want to view the desktop version of the site persistently, there's no way to do that without a cookie [19:02:15] awjr: is that what you are saying? [19:02:19] preilly almost [19:02:38] awjr: well, that is the cookie I originally had [19:02:52] awjr: that cookie isn't really view related it's stop redirect related [19:03:06] preilly i see what you're seaying [19:03:08] er [19:03:09] saying [19:03:27] tfinc: might be good to get a little of Patrick's time because of the JS [19:03:48] awjr: so the stop redirect cookie I think should be set from a hook [19:03:53] New review: Jdlrobson; "Whoops that was a mistake... thanks will correct on my return." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/4642 [19:04:02] philinje: MaxSem can always ask for preilly's help if he needs it [19:04:08] awjr: as that's very WMF-centric thing [19:04:18] philinje, tfinc: agreed [19:04:50] preilly: i dont think that cookie /should/ be a WMF-centric thing [19:04:52] MaxSem: let me know if a Skype call would help [19:05:02] awjr: that stop redirect cookie? [19:05:08] preilly yeah [19:05:13] awjr: how is that not a WMF-centric thing? [19:05:29] awjr: it's controls a redirect that we do at the caching layer [19:05:47] preilly thinking about it as a 'stop redirect cookie' is WMF-centric, but thinking about it as a "i want to see the desktop view even though i am a mobile device" is not [19:05:48] awjr: based on device detection [19:06:23] philinje, I haven't received the email yet [19:06:27] awjr: I don't think we need cookies at all except for the case of no mobile domain [19:06:32] practically everything in mw core that is frontend caching related is 100% wmf specific and unused by every other mw install [19:07:02] awjr: this cookie serves a different purpose [19:07:03] not only is X-Vary-Option a non-standard thing that Tim invented, but the squid team rejected our attempt to get them to accept it [19:07:45] don't try to go further down the non-wmf-specific road than core [19:08:22] just make pretend you are working in core [19:08:23] BE THE CORE [19:08:35] lulz [19:09:15] preilly so you're suggesting if there's a mobile domain, never set a useformat cookie, but if a user wants to stay on the desktop domain, use stopMobileRedirect cookie. OTHERWISE, use useformat cookies? [19:09:39] MaxSem: just sent it [19:09:46] awjr: yes [19:10:44] if there's no mobile domain, you still may not want to set useformat=desktop ever. only useformat=mobile [19:11:01] preilly so essentially going back to how things were, but make clicking 'Desktop view' from the mobile site set the stopMobileRedirect cookie if there's a mobile domain [19:11:18] awjr: yes [19:11:47] binasher: you mean useformat=mobile to force mobile view and stopMobileRedirect=true to force desktop view if there's no mobile domain? [19:12:31] awjr: stopMobileRedirect=true wouldn't be relevant in that case [19:12:42] preilly: and we should still keep query string view switching as a one-time thing, right? [19:12:57] tfinc, part one: "fluent with JS". uh-oh [19:13:05] yeah, if no subdomain, just useformat=mobile, or delete useformat if switching to desktop [19:13:06] MaxSem: ha ha [19:13:33] awjr: so in the case of no mobile domain the default will always be desktop [19:13:51] last time I looked into UW, I realised that my JS knowledge is... [19:13:56] lacking [19:14:04] MaxSem: take a stab at it [19:14:09] preilly, binasher: then are you suggesting that we set the mobile cookie if the user selects to view the mobile domain OR if their device is detected as a mobile device? [19:14:15] MaxSem: I can answer any questions you have [19:14:50] MaxSem: and if I can't jdlrobson can for sure [19:16:17] preilly, binasher: because otherwise, if we don't support a useformat=desktop cookie, a user on a mobile device would not otherwise be able to persistently view the desktop version of the site (with no mobile-specific domain, that is) [19:16:33] MaxSem: like i sad .. pull in preilly or others as neded [19:16:35] said* [19:17:12] awjr: use the stopMobileRedirect cookie for that [19:17:19] awjr: the default would always be desktop [19:17:24] if it's set - never render mobile [19:17:37] this is something that will come up with MF does its own device detection by default [19:17:49] which it doesn't currently do [19:18:15] binasher: preilly was suggesting that we'd only use stopMobileRedirect for sites with a mobile-specific domain configured [19:18:27] preilly: you mean the default would always be desktop, even for a user with a mobile device? [19:18:35] it is only applicable if there's a mobile specific domain today [19:18:56] preilly was thinking in the current reality where MF does not do device detection by default [19:19:29] MF does do device detection by default [19:19:58] so use stopMobileRedirect regardless of configuration [19:20:18] that makes sense to me - preilly are you on board with that ^? [19:20:51] preilly says that if you install it in a vanilla MW install and do no config, it will never render the mobile view unless you click view mobile (re: device detection by default) [19:21:31] YuviPanda: how is your tester pool looking ? [19:22:02] tfinc, philinje: what's the context? mobile version of UW? [19:22:08] MaxSem: mobile [19:22:14] binasher i guess that's true unless you have a server that's setting HTTP_X_DEVICE [19:22:15] tfinc: small. brion, kaldari so far. I left a message on Jarry's talk. [19:22:19] tfinc: brion found a bug, am fixing it [19:23:56] preilly, binasher: it's still possible that someone will have a set up that would set an http-x-device header and /not/ have a separate mobile domain [19:24:02] yep, and we only set X-DEVICE if a user hits the m subdomain [19:24:12] but in the future [19:24:18] you need both cookies regardless [19:24:38] preilly was just pointing out that it doesn't matter right now [19:24:43] yeah, so my vote is to set stopMobileRedirect if a user selects 'Desktop view' no matter what [19:24:46] for sure [19:25:15] yeah.. if you add logic around that based on conf, you'll just have to delete it later [19:27:17] preilly, binasher: to recap before i keep going on this: if a user selects 'Desktop view', always set stopMobileRedirect cookie. if there is no mobile-specific domain and a user selects 'mobile view', set useformat=mobile, else just redirect to mobile domain. if there is a mobile-specific domain set up, redirect all requests that should be mobile-friendly to the mobile domain, and vice versa for desktop [19:27:55] Project WiktionaryMobile - Nightly builds build #60: SUCCESS in 6.8 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/60/ [19:27:55] pfhayes: Removing trailing whitespace in audiolinks-close [19:28:29] Project WiktionaryMobile - Nightly builds build #61: SUCCESS in 7.4 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/61/ [19:28:30] * pfhayes: Fix extra space appearing at bottom of screen in ICS and iPad [19:28:30] * pfhayes: Removing trailing whitespace in audiolinks-close [19:28:41] preilly, binahser: one problem i see with that is a mobile device user who does not get caught by our device detection. every time they view the site, they will have to click 'mobile view' [19:29:15] that's not new [19:29:16] awjr: the main site? [19:29:25] binasher sure but it sucks [19:29:26] preilly yes [19:29:41] so what is the downside to setting useformat=mobile whenever a user selects 'Mobile view'? [19:29:43] they'll probably come in via google and google will send them to the mobile site directly if google thinks they should get it, heh [19:29:44] awjr: well if the click mobile view they are redirected to mobile domain [19:30:03] awjr: and then all links are mobile [19:30:05] preilly and they will stay there for that session, but not when they come back again [19:30:11] unless we set a cookie [19:30:18] no [19:30:45] i don't want my desktop browser to redirect me to .m. every time i try to go to regular wikipedia due to a cookie [19:30:50] plus being able to do that [19:30:55] breacks caching [19:31:18] if there's a problem with device detection [19:31:20] people should tell us [19:31:22] and we should fix it [19:32:16] philinje: http://www.mediawiki.org/wiki/Mobile_design/status needs an update [19:32:28] philinje: you might want to split out nav bar into its own project [19:32:38] binasher: most people will not report device detection problems. we could also set the cookie to vary ONLY if there is no mobile-specific domain, so it will not mess up caching for us [19:33:20] huh? [19:33:35] if there is no mobile domain, they get useformat=mobile per everything discussed above [19:33:54] we're going in circles here [19:34:48] binasher: im saying i think it's important to be able to set useformat=mobile on WMF domains as well, because i do no think most people do or will report device detection problems. and in that particular case, we can make sure that useformat=mobile will not vary the cache [19:35:29] then it wouldn't work [19:35:52] in conjunction with redirecting them to the .m. domain? [19:35:57] how would that not work? [19:36:06] how would it work if it doesn't vary cache? [19:36:14] please don't go back to javascript redirects [19:36:20] philinje: http://www.mediawiki.org/wiki/MobileFrontend/Photo_upload/status needs an update too [19:36:40] add a "report issues" link on the mobile site [19:36:42] binasher it wouldn't happen with a javascript redirect, it would happen with a php redirect [19:36:59] and if people have issues, they can always go to m.wiki and always get mobile [19:37:25] binasher most people won't even know that their device is /supposed/ to be detected and most people won't even know about the .m. domain [19:38:08] do you have any inkling or evidence than device detection has any major flaws? [19:38:31] don't complicate solving a problem that exists right now by trying to solve a problem that doesn't. [19:38:32] binasher only annecdotal from playing with random devices [19:39:14] build an extensive mobile qa infrastructure. perform regular qa on device detection. [19:39:18] tfinc, philinje, sorry I'm not qualified to judge how much effort it could take. point 1) for desktop looks reasonably easy, but I'm not experienced with huge JS projects to make judgements on 2) but likely it would be quite serious effort [19:39:40] binasher: that would be nice :) [19:39:49] I see no serious backend tasks for either 1) or 2) [19:40:44] URL parsing for 1) could be reasonably done in JS completely, or special page could provide frontend with parsed and validated data from URL [19:41:26] kaldari: got any more feedback on the RC? [19:46:12] YuviPanda, tfinc: 15 minutes, right? [19:46:20] thats what my calendar says [19:46:34] mine too [19:46:54] i set the time aside to *talk* about it as i haven't prepped anything [19:48:33] do you have any inkling or evidence than device detection has any major flaws? https://bugzilla.wikimedia.org/show_bug.cgi?id=30827 [19:49:31] ok, so fix those problems as they come up [19:50:12] and good job samsung configuring making your webkit browser send a wap accept header by default [19:51:01] that bug isn't a case of users not getting mobile detected.. [19:55:58] binasher i dont really understand what the problem is with setting useformat=mobile and making it vary the cache only if there is no mobile domain configured [19:57:56] awjr: walk me through the request cycle in the case where there's a mobile domain configured [20:00:00] tfinc: test [20:00:40] binasher: a user with an undetected mobile device goes to en.wikipedia.org and selects 'Mobile view'. a useformat=mobile cookie will get set for *.wikipedia.org (without settint X-V-O) and they will be sent to the same article on en.m.wikipedia.org. every subsequent request to a *.wikipedia.org will be served to them as a mobile request, until they select "Desktop view" [20:01:28] no [20:01:29] YuviPanda: one very minor thing, which is a subjective comment... I thought it was a little bit confusing that after choosing an article from the search results it first dumps me back at the article I was looking at previously, and then loads the new article. If you're on a slow connection, I imagine this might seem weird. But it's very minor. [20:02:10] i wanted you to think about what requests to en.wikipedia.org actually look like, and how they're passed across the stack [20:03:33] YuviPanda: Amgine : where are we meeting ? [20:03:41] you guys pick. [20:03:51] i'm happy with skype [20:03:57] Amgine: send me your Skype id [20:04:00] I can't skype on this box. [20:04:08] Amgine: then pick something else please [20:04:12] I can call anywhere in North America though. [20:04:36] #WTMobile_discussion ?? [20:04:48] i prefer voice for this … it'll go faster [20:05:19] okay. [20:05:24] Gimme # to call? [20:05:44] YuviPanda: is there any easy for you to dial in that won't be insanely expensive [20:05:49] Amgine: keep in mind yuvi is in india [20:05:59] which is why syke/google hangout/etc are cheaper [20:06:03] skype* [20:06:11] tfinc: i'm not sure. Let me try google voice [20:06:11] I think I can google hangout. [20:06:52] DNS is down at the WMF office [20:06:56] this will make things harder [20:07:09] :D [20:07:16] * tfinc reroutes his dns request elsewhere [20:07:23] Could WMF call YuviPanda, and then conference me in? [20:07:25] can someone pass me google dns servers please [20:07:30] 8.8.8.8 [20:07:32] 8.8.4.4 [20:10:21] much better [20:10:45] what did i miss? [20:10:51] tfinc: nothing [20:10:57] you missed 8.8.8.8 [20:11:01] i got that [20:11:05] then nothing [20:11:05] awjr, poke me if you need to discuss special pages further [20:11:07] and 8.8.4.4 [20:11:36] Other people at office falling off freenode. [20:11:37] I use Google DNS too [20:11:52] i can try conferencing you guys but i never use my desk phone so who knows what will happen :D [20:12:19] the problem is that I need my ISP's DNS for L2TP anyway:[ [20:12:24] :D [20:12:59] tfinc: ask someone to set us up? [20:15:35] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/yFMSHw [20:15:35] [WikipediaMobile/v3.1.2-iOS] Do not crash when using twitter on pre 5.0 devices - YuviPanda [20:15:41] brion: fixed the twitter [20:15:47] Amgine: YuviPanda pm me the number to call [20:15:48] Project WikipediaMobile - Nightly builds build #318: SUCCESS in 6.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/318/ [20:15:49] yuvipanda: Do not crash when using twitter on pre 5.0 devices [20:16:24] \o/ tx [20:17:10] [20:17:33] [20:17:54] brion: pull + verify? [20:17:58] if you have the time [20:18:36] tfinc: you sound like darth vader with a cold [20:19:04] tfinc: spaceballs variety, not star wars variety. [20:20:14] ooh i crashed xcode [20:21:54] YuviPanda: ok confirmed that on ios 4.3.2 i don't see the twitter button anymore [20:22:05] check if the other ones work [20:22:08] y'know, Office has the most mysterious telecommunications. [20:22:10] and that hitting cancel does not crash the app [20:22:26] Amgine: so tfinc called me, put me on hold, and called me again and then put me on hold again [20:22:31] yep they seem happy [20:22:33] while on the same call [20:22:45] so two of me were in the conference, and none of Amgine [20:22:48] brion: cool :) [20:23:02] Well, we're in #WTMobiles_discussion YuviPanda [20:23:16] sorry, #WTMobile_discussion [20:26:49] hi tfinc [20:27:05] A curious thing from the Hebrew Wikipedia: [20:28:34] a page marked with noindex is not supposed to appear in Google Search. [20:28:57] in theory [20:29:11] but it appears as a result in Google Search from our mobile site. [20:29:38] aharoni, this bug was fixed recently [20:29:44] oh, ok [20:29:49] * MaxSem wonders if it's deployed [20:30:18] hmm, it should be, but probably it's from an older spider crawl [20:30:29] ok, cool. [20:33:43] kaldari: we *used* to load a blocking animation, but that sucked. We're moving to the API next release, should make page loads much faster [20:33:59] cool [20:39:00] actually, what is fixed - the appearance of noindexed content as a search result from the mobile site or the fact the mobile site appears in search results at all? [20:39:17] because generally there should be no reason for it to appear. [20:40:42] awjr_lunch: you there? [20:40:51] preilly_: yep [20:42:18] maxsem, brion ^ [20:42:40] oy [20:43:12] awjr: Skype?!? [20:43:27] preilly_ let's do it [20:47:42] aharoni, MobileFrontend now properly outputs noindex [20:51:57] aharoni, any specific pages? [20:53:11] it seems to work correctly on pages that ask for this. [20:53:22] but maybe it should work everywhere. [20:54:23] so that no pages from the mobile site would appear in search results. [20:54:33] noooo [20:55:12] Google intentionally scans our sites with a mobile UA to get mobile results [20:55:26] preilly: forwarded an email that went to Max originally [20:55:44] oh, so it shows mobile results to mobile users and hides mobile results from desktop users? [20:56:27] that's the theory anyway [20:57:09] cool. good night. [22:01:13] preilly and awjr, I've discovered a lot of unused messages in MF. could you check if you need/may need them in the future before I remove them? http://dpaste.com/729803/ [22:04:47] jdlrobson: i also made a new commit today, review that when you can. Smallish [22:04:52] v3.1.2-iOS branch [22:05:22] New patchset: MaxSem; "Got rid of a couple of variables, message tweaks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4668 [22:05:43] brion: did any more 4.x testing? [22:06:35] i had some problems with save/load on one page, but couldn't repro it on another page. will try on 5.1 and see [22:06:37] np YuviPanda [22:06:47] brion: crashy or slowy? [22:07:01] didn't load at least one picture, sections couldn't be expanded [22:08:39] brion: which one? [22:08:42] which article, that is [22:09:21] Bubba Watson [22:11:01] New patchset: Jdlrobson; "temporarily override common.css rule" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4642 [22:11:52] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4642 [22:11:54] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4642 [22:12:15] jdlrobson: Change has been successfully merged into the git repository. [22:12:20] merci preilly [22:13:11] MaxSem: https://gerrit.wikimedia.org/r/#patch,sidebyside,4668,1,MobileFrontend.body.php callback was used in the old iPhone app [22:13:31] MaxSem: People can possibly still be using it [22:13:54] YuviPanda: sections work on it now, though the main image still doesn't come back up from saved version on ios 4.3.2 [22:14:09] brion: other images turn up? [22:14:24] preilly, I didn't remove it, I merely moved the $wgRequest->getText() call closer to the sole user [22:14:26] smaller flag images on the same page do turn up yes [22:16:35] MaxSem: self::$callback = $wgRequest->getText( 'callback' ); [22:16:54] MaxSem: nevermind [22:17:17] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4668 [22:17:19] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4668 [22:17:33] MaxSem: Change has been successfully merged into the git repository. [22:17:41] thx [22:18:56] MaxSem: np [22:26:43] tfinc: who is on the mobile-tech list? [22:27:05] new nav UI is up [22:27:30] philinje: https://groups.google.com/a/wikimedia.org/forum/#!members/mobile-tech [22:27:58] "don't have permission to access this growp" [22:28:18] i'll pm you the list [22:28:25] thanks [22:28:42] never mind, it let me in [22:28:55] Arthur Richards Jon Robson Lindsey Smith Max Semenik Patrick Reilly Philip Chang Tomasz Finc Yuvaraj Pandian [22:29:08] ok thanks [22:29:26] http://www.mediawiki.org/wiki/Mobile_design/Wikipedia_navigation#Initial_menu [22:29:40] Design Comps [22:30:28] philinje: fun. send it out to mobile-l for discussion [22:31:03] should we do that before getting Erik and Howie's input? [22:33:22] what do we need stuff like hidelogo and hidesearchbox for? [22:36:17] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/w7geUg [22:36:17] [WikipediaMobile/v3.1.2-iOS] Hide navbar when in overlays - YuviPanda [22:36:23] tfinc: ^ fixes https://bugzilla.wikimedia.org/show_bug.cgi?id=34908 [22:36:27] MaxSem: that was for the applications [22:36:30] Project WikipediaMobile - Nightly builds build #319: SUCCESS in 7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/319/ [22:36:31] yuvipanda: Hide navbar when in overlays [22:36:31] brion: think you could pull and have a look at it? [22:36:48] jdlrobson: can you look at the latest commit to v3.1.2-iOS? Made minor CSS corrections [22:36:55] sure [22:37:16] pulling [22:37:31] awjr, your changes made DisableTemplate unused - can we remove it? [22:37:43] MaxSem: yep [22:42:30] New patchset: MaxSem; "rm unused DisableTemplate" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4671 [22:43:28] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4671 [22:43:31] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4671 [22:43:35] YuviPanda: now the picture shows on saved Bubba Watson, but the sections don't expand still for me [22:43:38] (on 4.3.2) [22:43:42] MaxSem: Change has been successfully merged into the git repository. [22:44:20] brion: this change is to remove the nav bar when you're in an overlay [22:45:10] aho [22:45:59] YuviPanda: is that going to hide on ipad too? cause that won't look very good [22:46:08] brion: not on iPad, no. [22:46:22] ah good, i see [22:47:15] YuviPanda: the last two lines of content in the article are cut off below the toolbar [22:47:18] other than that, seems ok [22:47:30] that's "organization" and "Contact us" that get cut [22:48:42] brion: hmm, can repro that in the sim [22:49:07] need some extra space or padding in there i guess [22:49:32] yeah, working on it [22:52:22] brion: try now? [22:52:26] [WikipediaMobile] yuvipanda pushed 2 new commits to v3.1.2-iOS: http://git.io/aMJPCg [22:52:26] [WikipediaMobile/v3.1.2-iOS] Show feedback when saving pages on iOS - YuviPanda [22:52:26] [WikipediaMobile/v3.1.2-iOS] Stop lines from being cut off at bottom of content - YuviPanda [22:52:40] Project WikipediaMobile - Nightly builds build #320: SUCCESS in 6.8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/320/ [22:52:40] * yuvipanda: Show feedback when saving pages on iOS [22:52:40] * yuvipanda: Stop lines from being cut off at bottom of content [22:53:15] tfinc: thoughts on when we could push this release out? [22:54:39] YuviPanda: looks good! (scrolling padding) [22:54:47] cool [22:55:04] oh -- i have a couple fixes y'all might want to cherry-pick from master [22:55:43] * updated splash screen images [22:55:51] * fix for links on about page crashing the app [22:55:59] brion: i'll cherry pick them all, though I think the open in safari one will clash [22:56:01] meh [22:56:03] * YuviPanda does a rebase [22:56:20] yeah that one might clash and need a fix. [22:58:47] jdlrobson, does $wgOut->addModuleStyles() work? [22:59:03] it did... does it not any more? [22:59:35] no, just wondered how [23:00:32] preilly helped with that [23:00:53] MaxSem: what is broken about it? [23:01:29] how it gets passed from $wgOut to our skin [23:01:52] MaxSem: the application template outputs it [23:02:43] MaxSem: $cssLinks = $wgOut->buildCssLinks(); [23:02:54] oh [23:11:03] Project WiktionaryMobile - Nightly builds build #62: SUCCESS in 6.9 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/62/ [23:11:04] sheaclare: Changing logo and icon [23:11:56] Project WiktionaryMobile - Nightly builds build #63: SUCCESS in 7 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/63/ [23:11:57] pfhayes: Changing logo and icon [23:13:28] YuviPanda: i'll be out of meetings @ 5 [23:13:30] how is our testing going? [23:13:52] tfinc: brion is helping with 4.3, kaldari gave us a thumbs up on 4.2 [23:14:05] woot! [23:14:12] and i'm testing on 5.1 [23:14:41] tfinc: poke me when back, i should have something that we can put through one final round of 'upgrade' testing and then push out [23:34:03] awjr: heading downstairs … i'll be ready in about 5min [23:34:09] tfinc no problem [23:46:34] no brion, sigh [23:46:46] [WikipediaMobile] yuvipanda pushed 4 new commits to v3.1.2-iOS: http://git.io/dfWfFQ [23:46:46] [WikipediaMobile/v3.1.2-iOS] bug 35710 - about page links now open in external browser - Brion Vibber [23:46:46] [WikipediaMobile/v3.1.2-iOS] Bug 35734 - Update iOS splash screen images - Brion Vibber [23:46:46] [WikipediaMobile/v3.1.2-iOS] Bug 35741 - iOS save/share menu should offer to open page in Safari - Brion Vibber [23:47:00] Project WikipediaMobile - Nightly builds build #321: SUCCESS in 6.7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/321/ [23:47:00] * yuvipanda: bug 35710 - about page links now open in external browser [23:47:01] * yuvipanda: Bug 35734 - Update iOS splash screen images [23:47:01] * yuvipanda: Bug 35741 - iOS save/share menu should offer to open page in Safari [23:47:02] * yuvipanda: Translation updates from translatewiki.net