[00:00:01] at least in the response [00:00:09] the show/hide works on the mobile web yuvi [00:00:27] awjr, but not in the following requests [00:01:08] meh, time to sleep. I've got a mini-hackathon tomorrow with aharoni and vvv [00:01:10] which cookie mf_useformat=mobile [00:01:12] also the scrolling wheel isn't very prominent [00:01:22] I can barely see it, can you make it the same dark colour as the toolbar? [00:02:32] can we save images directly through the app instead of having to go to the mobile version? [00:02:36] mobile web* [00:03:02] Thehelpfulone: that's on the pipeline too - lightboxes for images [00:03:08] Thehelpfulone: scrolling wheel? [00:03:10] you mean the scrollbar? [00:03:32] I mean when somethings loading [00:03:45] the wheel that rotates [00:03:55] YuviPanda: i think he means the article loading animation [00:03:59] in the search box [00:04:00] ah [00:04:01] yeah that's it [00:04:03] right. [00:04:07] I didn't know the official name ;) [00:04:45] if I click on view saved pages [00:04:51] and then click on the x next to saved pages [00:05:00] the message is "index.html clear all saved pages?" [00:05:35] YuviPanda: i'm looking to head out in about an hour [00:05:41] tfinc: ok [00:05:54] Thehelpfulone: can you check the 'clear history' and tell me if you see the same? [00:06:05] YuviPanda: what's left before we can release to the market ? [00:06:13] that says "Confirm" as the title [00:06:21] and "Clear history?" as the message [00:06:38] Thehelpfulone: okay, looking into it [00:06:44] ty [00:06:45] tfinc: I see a RIL issue as blocking. [00:06:55] i'm working on it [00:07:03] Thehelpfulone: would you consider anything else blocking? [00:07:13] blocking == as a temp fix to the 1 star deluge [00:07:34] let me see hm [00:10:01] the problem with the settings is a blocker [00:10:01] Thehelpfulone: the index.html issue has been fixed [00:10:04] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/wl0vVw [00:10:04] [WikipediaMobile/v3.1.2-iOS] Remove stray index.html title in 'clear saved pages' box - YuviPanda [00:10:07] how I can't get out of it [00:10:12] Thehelpfulone: i'm still unable to reproduce it. hitting back steems to close it for me :( [00:10:20] Thehelpfulone: does it happen everytime? [00:10:20] Project WikipediaMobile - Nightly builds build #327: SUCCESS in 8.8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/327/ [00:10:21] yuvipanda: Remove stray index.html title in 'clear saved pages' box [00:10:27] yes [00:10:37] if I go to about us and then back to the settings then the back button works YuviPanda [00:10:44] but otherwise it doesn't if I only go to settings [00:11:06] Thehelpfulone: the back button to the left of the word 'settings' [00:11:11] yes [00:11:11] or the back button in the toolbar? [00:11:24] the back button to the left of the word settings [00:11:28] sorry, I'm talking about the iPhone now YuviPanda [00:11:39] theres no toolbar for settings in the iphone [00:11:50] MaxSem, preilly: i do not experience the same problem in chrome on windows vista [00:12:03] but it doesn't really work for me on the ipad either it seems [00:14:16] Thehelpfulone: works for the other overlays? [00:14:19] saved pages, history? [00:14:39] it seems so [00:15:31] also on the nearby YuviPanda, can you add one of those dots like you get on google maps? [00:15:39] and maybe zoom it out a little bit so you see at least one entry [00:15:56] Thehelpfulone: ah, right. file a bug? Will add it in for 1.2? [00:16:09] ok [00:16:24] this is kind of a blocker, if you click on the nearby optino YuviPanda [00:16:30] and then you go to an article [00:16:34] you can't get back to the nearby option [00:16:40] by simply pressing back [00:17:10] Thehelpfulone: that's an issue with all overlays. I understand that it affects nearby the most. [00:17:24] file a bug, and I'll make sure this gets fixed for 1.2 [00:17:49] ok [00:18:18] so i'm currently looking into the RIL issue, and will check settings back after that [00:18:26] Thehelpfulone: i'm still unable to replicate it on my simulator :( [00:18:31] the 'back button' not working. [00:18:39] brion: is the 'back' next to 'settings' working on your iPad? [00:19:13] YuviPanda: yep [00:19:20] brion: 5.1? [00:19:26] 5.1 [00:19:44] YuviPanda: sorry, back now - what was your question before? [00:20:06] philinje: nah, nothing. Just wanted to know if you had the mobile URL handy, no big deal. [00:20:13] preilly have you been able to replicate MaxSem's problems? [00:20:24] awjr: nope [00:20:37] hmm [00:20:44] YuviPanda: URL for? [00:20:55] awjr: but, I'm on the http://preilly.m.mediawiki.org/ domain NOT localhost [00:21:03] awjr: but, I don't really think that — that matters [00:21:06] the mobile designs. Again, nevermind, I found it and gave it to Thehelpfulone. [00:21:12] YuviPanda: do you need me to test anything ? [00:21:50] preilly well assuming Max's issues are unique to him, the only outstanding issue i see around the cookie stuff is for sites that use a single domain for both desktop and mobile view - there are browser caching issues [00:21:53] tfinc: confirmation that the 'back' button next to 'settings' works would be good. [00:22:02] k [00:22:03] preilly and i'm not really sure how to cope with them, or if there's even a sensible way to do so [00:22:06] tfinc: + ofcourse, general 4.2 testing. I'm figuring out ways to fix the RIL bug. [00:22:37] back button works fine [00:23:47] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4761 [00:23:49] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4761 [00:24:44] preilly what do you think about making having a separate mobile domain a requirement for MobileFrontend until we can figure out unique mobile paths? [00:25:15] awjr: well, I don't think we need to do it [00:25:34] awjr: you could just bust the cache with a custom query string parameter [00:25:53] preilly but that would have to happen on like, every request [00:25:55] awjr: just some random number converted to a MD5 hash or she! [00:26:04] s/she!/sha1 [00:26:29] awjr: just on the redirect [00:27:11] preilly with sites that don't have a separate mobile domain, there's no real redirect. so the URL for the mobile version of an article will be the same as the URL for the desktop version [00:28:09] YuviPanda: i did manage to replicate 'settings back button doesn't work, and hitting it a few times leads to a crash' on ipod touch (5.1) [00:28:18] brion: ow? [00:28:19] how? [00:28:31] just trying it a few times o_O [00:28:57] but i've not got it to happen on the ipad at all [00:29:31] LIFI [00:29:59] preilly so the problem is no necessarily just on redirect. you can have mf_useformat=mobile and be clicking around like crazy and then come to a page that was locally cached with the desktop version [00:30:21] brion: trying to reproduce now, switching between that and RIL bug (orientation switch not happening) [00:34:13] awjr: well short of cache control or vary [00:34:54] brion: I see it. [00:35:51] preilly well Vary is already set to cookie [00:36:09] jumping into 'about' and then back sometimes fixes it, but not always (may just be reopening the dialog, i forget) [00:41:04] awjr: but, that's for intermediate caches [00:41:44] brion: looks like the event is being unbound. Looking into it [00:41:58] preilly: is there something like 'vary' for browser caches? [00:44:26] awjr: not really [00:44:28] preilly i thought cache-control and vary were used by browsers as well as proxy caches [00:45:39] awjr: not vary [00:46:55] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/A8aY5g [00:46:55] [WikipediaMobile/v3.1.2-iOS] Fix for 'back' from settings not ocassionaly working - YuviPanda [00:46:55] brion: that commit should fix it, can you take a look? [00:47:11] Project WikipediaMobile - Nightly builds build #328: SUCCESS in 9.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/328/ [00:47:12] yuvipanda: Fix for 'back' from settings not ocassionaly working [00:47:25] pulling [00:48:55] YuviPanda: doesn't fix it for me on the ipod touch :( [00:49:47] brion: damn, intermittent problems suck. It was working and now it isn't [00:49:54] YuviPanda: 10min warning [00:49:55] j [00:50:00] need me to test anything ? [00:50:14] yeah about 1/2 the time on the ipod touch settings close button doesn't work. WEEEEEEEEIRD [00:53:36] tfinc: Nokia — http://i.imgur.com/k0viD.jpg [00:53:47] brion: interlanguage list, are you able to scroll? [00:53:51] brion: 'read' in? [00:54:55] sec… app crashed on me while wildly tapping at settings close :) [00:55:23] this is reasonably infuriatig [00:55:46] yes, scrolling ok in language list [00:56:01] ok... [00:58:53] YuviPanda: need me for anything? [00:59:01] tfinc: not right now, no. [00:59:12] cya tomorrow, hopefully i'll have these two issues fixed [00:59:21] k, if i leave now then i'll be back around 10PM [00:59:25] maybe earlier [00:59:32] call if you need anything [00:59:36] tfinc: ok [00:59:47] i also setup a daily standup till this is in the market [00:59:48] brion: looks like it stops working right after the page loads. [00:59:54] you will have to deal with a daily meeting till we get this resovled [00:59:55] which makes no sense to me. It works until a page loads [00:59:57] hows that for motivation ;) [01:00:18] honestly, the fact that I can't look at the iTunes store or twitter without hating myself is motivation enough. [01:00:29] that's the spirit [01:01:51] maybe something in doFocusHack... [01:02:40] brion: i got rid of .cleanButton from there, still issues [01:03:05] .cleanButton or .closeButton [01:03:43] .closeButton [01:03:45] sorry [01:03:47] not cleanButton [01:03:54] cleanButton is there [01:04:19] yeah i can confirm commenting out the .closeButton in doFocusHack doesn't help :( [01:05:05] brion: not calling doFocusHack also doesn't seem to help [01:05:52] confirmed [01:06:11] and it doesn't seem to happen with the other pages [01:09:12] specifically make it a selector and binding it also doesn't seem to help [01:09:13] wtf [01:12:54] wtf indeed sir [01:18:18] * YuviPanda continues feeling like a failed voodo practiioner rather than a programmer [01:20:02] i've tried hooking the event on the particular element, checking touchstart/touchend…. nothing stands out. this is just damn odd [01:21:12] yes, tried those as well. [01:21:30] and it only happens at all on one out of four devices i've got. so wtf [01:21:40] but on that one it's so common, about 50% of the time. wtfffffff [01:22:32] more wtf. i commented out the event that bound click to showContent. other back buttons still work [01:23:53] ah, that was just an unclean build [01:23:56] not *that* wtf [01:24:05] :) [01:25:45] brion: binding to "button" also does not show up. [01:26:20] could there be some zindex thing or focus thing stealing events? [01:27:02] but why on settings and nowhere else… [01:27:17] * YuviPanda looks in settings [01:27:26] brion: the only difference is that we don't call doScrollHack for settings [01:27:51] * YuviPanda meant to say he was looking in CSS [01:36:29] brion: poke. [01:36:40] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/uVchEA [01:36:40] [WikipediaMobile/v3.1.2-iOS] Adding Scrollhack seems to fix the back button in settings - YuviPanda [01:36:46] brion: can you try out this commit? It seems to fix the issue for me, but I can never be sure. Also, I've no idea why the fuck it works, if it works at all [01:36:56] Project WikipediaMobile - Nightly builds build #329: SUCCESS in 8.7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/329/ [01:36:56] yuvipanda: Adding Scrollhack seems to fix the back button in settings [01:40:03] * YuviPanda pokes brion some more. [01:57:14] sorry was afk [01:59:14] son of a bitch, that seems to fix it :D [01:59:17] lemme double-check on 4.3 [01:59:52] yeah, 4.3 is where iScroll does stuff [02:00:52] seems all as expected [02:01:00] \o/ you got it YuviPanda :D [02:01:13] 'keep shooting random people until you hit hitler' seems to be the way to debug [02:01:36] rofl [02:13:00] [WikipediaMobile] yuvipanda pushed 2 new commits to v3.1.2-iOS: http://git.io/VicJ5A [02:13:00] [WikipediaMobile/v3.1.2-iOS] Added warning about code in comments - YuviPanda [02:13:00] [WikipediaMobile/v3.1.2-iOS] Fixed bash misunderstanding - YuviPanda [02:13:09] right. now RIL and some more [02:13:15] Project WikipediaMobile - Nightly builds build #330: SUCCESS in 8.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/330/ [02:13:16] * yuvipanda: Added warning about code in comments [02:13:16] * yuvipanda: Fixed bash misunderstanding [02:43:34] YuviPanda: you about? [02:43:38] devgeeks: heya [02:43:41] hey [02:43:46] Just looking at RIL [02:44:20] devgeeks: awesome! [02:44:31] You won't say that in a second [02:44:32] lol [02:44:57] I think it's in RIL's "full" built in interface [02:45:34] yeah, that's the conclusion I came to too. Seems to be a bug there? [02:45:42] yeah [02:45:53] raise it with them? Have more weight coming from the big W [02:47:16] devgeeks: i'm not sure how iOS handles rotations, but if I understand correctly, it is done mostly automatically? [02:47:22] unless you want to do specific changes? [02:48:16] is that right or am I completely off my bonkers? [02:48:17] yeah, kinda [02:48:31] but they are creating their UI programatically [02:48:40] with frame widths and heights [02:49:28] interesting [02:49:33] i found a section of code marked with [02:49:33] // Allow for rotation [02:50:18] yeah [02:50:24] why isn't that working [02:51:25] devgeeks: maybe we're not passing it on to it? [02:51:32] we = phonegap [02:51:35] yeah [02:51:38] though it should [02:51:47] shouldn't be UP to phonegap [02:53:14] yeah [02:53:21] devgeeks: not like phonegap's hosting this [02:54:55] got an idea [02:55:20] devgeeks: ok? [02:55:49] gah [02:55:53] didn't help [02:55:56] :( [02:56:28] GOT IT! [02:56:30] BAM [02:56:43] * devgeeks does a happy dance [02:56:51] - (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation [02:57:04] it's missing from ReadItLaterFull [02:57:25] rather: ReadItLaterFullView [02:57:39] Dantman: aha [02:57:44] err [02:57:47] sorry Dantman [02:57:49] devgeeks: haha! [02:57:54] heh.. tab fail ? [02:57:57] yeah [02:57:59] heh [02:58:04] I had d, hit tab. [02:58:13] what client do you use? [02:58:16] devgeeks: want to commit and gimme a pull request? [02:58:22] Irssi does that to me sometimes [02:58:23] devgeeks: textual, will migrate to weechat soon [02:58:34] well, here's the thing [02:58:40] it's still not right [02:58:45] see [02:59:00] it SHOULD be return [super shouldAutorotateToInterfaceOrientation:interfaceOrientation]; [02:59:09] but that doesn't WORK [02:59:28] I guess because of its plugin status it's not getting the correct answer from super [02:59:40] if I hardcode return YES [02:59:43] it works [03:00:06] but that would mean it would support orientations NOT supported by the app [03:02:02] Just gimme a sec to figure that out... [03:02:03] devgeeks: hmmm [03:02:05] ok [03:02:09] then the OTHER issue is [03:02:11] ... [03:02:22] To make it work we are changing THEIR lib [03:02:25] heh [03:02:31] we'll submit changes back up stream? :P [03:03:09] I am not sure what the licensing is on their lib. It's not clear [03:03:51] MIT, I think? [03:03:53] * YuviPanda goes to look [03:04:09] Not sure it says [03:04:33] hmm, it doesn't. will poke back and clarify. [03:04:37] k [03:04:46] i'm sure they're not going to proprietary it. Even if it is GPL that's fine for us [03:05:06] I'll make the changes on the assumption we can get away with it ;) [03:05:30] yup! [03:14:34] Which DO you support? [03:14:36] All? [03:16:02] devgeeks: looks like it [03:16:21] Trying to avoid a W specific hack [03:16:23] :/ [03:16:34] devgeeks: actually not 'all' [03:16:41] we don't seem to support 'reverse portrait' [03:16:44] not upside down [03:16:45] yeah [03:20:31] stoopid shouldAutorotateToInterfaceOrientation is getting called like 5 times just to pop up the modal, and answering differently every time ;) [03:29:33] devgeeks: ah [03:38:04] devgeeks: any luck? [03:38:15] [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/FYX0Dg [03:38:15] [WikipediaMobile/v3.1.2-iOS] Open attribution links under maps in external browser - YuviPanda [03:38:30] Project WikipediaMobile - Nightly builds build #331: SUCCESS in 8.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/331/ [03:38:30] yuvipanda: Open attribution links under maps in external browser [03:39:20] YuviPanda: trying stuff [03:41:18] devgeeks: ok! [03:41:22] :) [03:41:36] and crashing Xcode. I rule ;) [03:41:49] :D [03:44:01] infinite loop., oopsie [03:44:10] :D [03:44:12] they're fun [03:46:17] I like infinite recursion though [03:46:44] 'yo dawg, I herd you like a function call, so I'll put a function call in your function call in your function call in your function call in your ...' [03:47:02] hahahahah [03:49:11] Just trying to figure out how to get to the MainViewController from the ReadItLaterFullView [03:49:22] It's not as simple as super [03:49:47] ah [03:54:43] Or at least super isn't giving me the right answer ;) [04:09:12] devgeeks: think you can do a 'working fix first then do it right' type fix? :) [04:09:37] Yes :) [04:09:49] I have a 2 second fix that will fix it just for you [04:09:57] want that first? ;) [04:10:06] indeed sir! [04:10:10] hehe [04:11:37] ack! [04:11:55] It pops up correctly, just won't let me input [04:11:58] ough [04:12:00] not quite there :( [04:12:37] devgeeks: you might also want to work off v3.1.2-iOS branch instead of master [04:12:42] has a *ton* of iOS fixes that master doesn't [04:12:50] OK [04:13:07] devgeeks: might also be because of the lack of an API key... [04:13:31] My test app has one [04:13:34] I am using that [04:13:42] it's just a basic app to test the plugin' [04:15:37] gah! it's all messed up... their stuff is REALLY rotation unfriendly [04:16:10] failed login still gives an unrotated view [04:16:20] :( [04:16:47] probably why the "proper" method isn't working [04:16:58] one of the views is still saying NO to rotation [04:16:59] hehe [04:17:23] ah [04:21:39] This is getting a bit over my head, I am afraid [04:21:47] You might need to contact RIL [04:22:41] devgeeks: :( [04:22:58] devgeeks: diff what you have and give me so I have a starting point to poke them with? [04:23:23] yeah [04:23:24] sure [04:23:33] we're hoping to make a release tomorrow (1 star reviews ugh) and this is the final blocker. I might have to take this up myself when i wakeup [04:25:46] dang [04:26:09] yeah it's really messed up [04:26:32] if you are in landscape and pop it up, fine enough, but rotating after it's up does nothing, etc [04:27:09] ugh, this sounds nasty [04:27:15] It is [04:27:17] :/ [04:27:53] A proper iOS champ would probably be able to fix it, but there is a reason I use PhoneGap ;) [04:28:02] heh [04:28:07] And it's all to do with the UI parts [04:28:08] haha [04:28:11] :D [04:28:23] even then, I guess your iOS skills trump mine anyday [04:28:27] heh [04:28:47] dunno.. I am getting better everyday, but still [04:33:32] devgeeks: thanks! [04:33:37] now I shall get some sleepp... [04:33:51] hehe [04:34:04] take care, sorry I didn't have a better answer [04:36:07] thanks for your help! [11:45:23] New patchset: Jdlrobson; "redesign sections" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4774 [11:45:23] New patchset: Jdlrobson; "toggling fix ups" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4775 [11:45:24] New patchset: Jdlrobson; "jslint and styling fix ups" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4776 [11:45:25] New patchset: Jdlrobson; "slight tweaks to footer text" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4777 [14:36:13] hmm, those plugins are doing terrible things they're not supposed to be doing [14:36:36] if the problem is that you want the ReadItLaterFull VC to be rotating and it's not, [14:37:04] that's easy to fix, just implement shouldAutorotateToInterfaceOrientation: [14:38:57] this should do it http://pastebin.com/zxKJNuYi [14:39:27] because there's none in there, and the class inherits directly from UIViewController, it's falling back on the standard UIViewController implementation, which is portrait only by default [14:40:08] stick that somewhere between @implementation and @end in ReadItLaterFull.m and everything should be peachy [14:40:30] hope that helps :) [14:41:56] let's highlight devgeeks so he sees when he's around [14:44:49] those plugins are kinda badly mangling MVC; Views are supposed to be dumb terminals, and ViewControllers are supposed to handle all the view-data coordination, and classes inheriting from UIViewController should not have names ending in --View [16:26:17] gugh, bad time to get sick :| [16:28:35] hey YuviPanda- http://pastebin.com/Pt1C96Y6 [16:29:47] Should solve one problem [16:30:08] Rolken: reading [16:31:45] Rolken: so that was what I first did [16:31:52] that has no effect at all [16:32:00] and it was then that i poked devgeeks [16:32:04] Oh =\ Ah well [16:32:07] who also tried the same bit and found it to not work [16:33:51] YuviPanda: I left a couple of comments here a day or so ago, did you manage to get them? [16:34:34] Jarry1250: which ones? [16:35:04] we put out a new one after that [16:36:30] Rolken: any other thoughts [16:36:31] ? [16:38:13] hmm, I'll download phonegap and see if I can fix it [16:38:57] Rolken: the RIL code isn't really part of PhoneGap, it's an SDK they released [16:39:18] Yeah but it's hard to do much real debugging if I can't compile it [16:41:17] right [16:41:45] well, every version of PhoneGap I've tried to download has been converted to 'CDV'; is the one you're using online somewhere? [16:43:09] Rolken: they make it hard to find it. Give me a second [16:45:35] YuviPanda: The comments on 1.1.2 [16:45:59] Rolken: https://nodeload.github.com/phonegap/phonegap/zipball/1.4.1 [16:46:33] looking at it again, my second best guess is that you're nesting view controllers, and rotate signals don't correctly propagate between them by default, you have to do it manually [16:49:41] Rolken: did you manage to get it to build? [16:50:02] YuviPanda: Sorry, I mean 3.1.2. Okay, three issues I notice with 3.1.2 on iOS 4.3.5 (and probably others): the main page is still saved as ?useformat=mobile; the show/hide buttons on [[Blah]] (literally that article, maybe others) don't work; and Nearby->Change Language->Nearby will show articles in the old language, not the new one." [16:50:16] fussing with linker errors now that it doesn't like having both cordova and phonegap installed [16:50:42] now it builds [16:50:47] hey YuviPanda [16:51:12] tfinc: heya [16:51:26]