[00:00:06] <MaxSem>	 but why it intermittently works then?
[00:00:30] <YuviPanda>	 brion: i'm seeing it on my 5.1 too
[00:00:32] <MaxSem>	 awjr, try replacing line 760 of MF.body.php with
[00:00:39] <MaxSem>	 $formatter = new MobileFormatter( MobileFormatter::wrapHTML( $html ), self::$title, $this->contentFormat, $this->wmlContext );
[00:01:53] <YuviPanda>	 brion: current MF deploy removes the #content wrapper, this kills *all* our apps, including android
[00:01:55] <YuviPanda>	 tfinc: ^
[00:02:03] <awjr>	 MaxSem before $html = $out->getHTML(); ?
[00:02:12] <tfinc>	 YuviPanda: this is very bad
[00:02:30] <tfinc>	 did you sync up with patrick to make sure our screen scraping wasn't going to break ?
[00:02:32] <YuviPanda>	 I remember discussing this with MaxSem, we investigated and figured out we won't remove that until the API switch :|
[00:02:33] <awjr>	 preilly perhaps this deployment needs to be aborted and rolled back
[00:02:41] <tfinc>	 roll it back then
[00:03:03] <YuviPanda>	 tfinc: MaxSem bought it up, we investigated and figured we can't do this for now.
[00:03:03] <awjr>	 preilly ^
[00:03:15] <brion>	 YuviPanda: "whoops"
[00:03:38] <MaxSem>	 awjr, I was on a branch
[00:03:55] <awjr>	 MaxSem makes sense :p
[00:04:33] <MaxSem>	 it's line 765 in master
[00:05:08] <awjr>	 MaxSem still empty object
[00:05:12] <MaxSem>	 or, even better
[00:05:18] <MaxSem>	 with $formatter = new MobileFormatter( MobileFormatter::wrapHTML( "<div id='content'>$html</div>" ), self::$title, $this->contentFormat, $this->wmlContext );
[00:05:39] <awjr>	 still empty
[00:08:34] <awjr>	 preilly have you started rolling back the deployment yet?
[00:08:54] <tfinc>	 preilly stepped away to the restroom
[00:09:06] <awjr>	 k
[00:09:07] <MaxSem>	 crap. I say abort and try again when we have a test wiki to repro
[00:09:42] <brion>	 i stuck lindsey's animation on the wiki page: https://www.mediawiki.org/wiki/Mobile_design/Wikipedia_navigation#Animated
[00:11:19] <awjr>	 RyanLane: per rt #2756 (re getting test.m.wikipedia.org to work right and not redirect to incubator) what was the issue you found preventing it from working right?
[00:11:34] <awjr>	 er Ryan_Lane ^
[00:11:48] <tfinc>	 preilly: lets roll this deployment back
[00:12:41] <Ryan_Lane>	 I have no clue
[00:12:52] <Ryan_Lane>	 our fucked up apache configuration maybe?
[00:12:54] <awjr>	 preilly i think the last good rev was r114716 from the change i pushed out last weds
[00:13:08] <Ryan_Lane>	 I stopped once I spent 4 hours trying to get it working and couldn't
[00:13:14] <awjr>	 owch.
[00:13:26] <Ryan_Lane>	 I have it working in dns and squid
[00:13:41] <Ryan_Lane>	 and our apache is to convoluted for me to continue trying
[00:13:56] <awjr>	 Ryan_Lane would you mind posting what you've done so far in the RT ticket so someone can pick up where you left off? not having test.m.wikipedia.org is a problem for us
[00:14:14] <Ryan_Lane>	 the only step left is to get apache working
[00:22:45] <tfinc>	 preilly: how is the rollback looking ?
[00:25:41] <preilly>	 tfinc: I'm talking to Tim right now
[00:26:40] <tfinc>	 are Roan, Aaron, and RobLA aware of the breakage ?
[00:26:57] <preilly>	 tfinc: I know that Aaron is
[00:27:02] <tfinc>	 k
[00:27:05] <preilly>	 tfinc: Tim is actively working on it
[00:28:03] <preilly>	 awjr: so, http://en.m.wikipedia.org/wiki/Main_Page?adfsdkkkkkk
[00:28:12] <preilly>	 renders ...
[00:28:26] <preilly>	 when I add <div id="mf-tt">...</div>
[00:28:53] <awjr>	 preilly yeah i was playing around with it locally. the formatter seems to pick up the mf ids but not the mp ones
[00:29:30] <preilly>	 awjr: well, $elements = $xpath->query( '//*[starts-with(@id, "mf-")]' );
[00:29:47] <preilly>	 awjr: I think maybe $mainPage->getElementById is failing
[00:30:53] <tfinc>	 YuviPanda: i can't wait till our apps are decoupled
[00:30:55] <awjr>	 preilly yeah
[00:31:33] <awjr>	 preilly i also did a var_dump( $mainPage ) in parseMainPage() and was surprised to get back an empty object
[00:31:55] <awjr>	 i think MaxSem was checking it out further
[00:32:21] <MaxSem>	 it's 4:32am here
[00:32:43] <awjr>	 or not
[00:32:50] <MaxSem>	 not quite time for my head to function
[00:33:07] <preilly>	 awjr: did you get object(DOMDocument)#114 (0) { }
[00:33:18] <YuviPanda>	 tfinc: yeah, me neither. it'll also help things be much faster.
[00:33:29] <awjr>	 preilly yeah
[00:33:34] <awjr>	 or something similar
[00:33:40] <preilly>	 running scap now
[00:33:43] <tfinc>	 YuviPanda: we'll want to do a blog post and write docs on it
[00:33:47] <preilly>	 awjr: that's not an empty object
[00:33:50] <tfinc>	 so that we can encourage app authors to switch
[00:34:07] <preilly>	 awjr: that is totally normal for a DOMDocument
[00:34:09] <YuviPanda>	 tfinc: yes. I'm currently figuring out how to merge the iOS fixes into api-move
[00:34:14] <awjr>	 oic
[00:34:17] <preilly>	 awjr: as it's a resource
[00:34:27] <tfinc>	 YuviPanda: once this MF deployment is fixed we can debug again
[00:34:37] <tfinc>	 s/debug/test
[00:34:47] <YuviPanda>	 tfinc: sigh. ok. I'm working on api-move for now
[00:34:57] <YuviPanda>	 tfinc: what's your schedule today like?
[00:35:11] <tfinc>	 i was planning on leaving in about an hour
[00:35:24] <tfinc>	 what do you need me to focus on ?
[00:36:31] <tfinc>	 YuviPanda: did the adhoc cert i sent you work?
[00:36:51] <YuviPanda>	 tfinc: i'd have liked you to just generally give a 'thumbs up' for 4.2
[00:37:14] <tfinc>	 k
[00:37:24] <YuviPanda>	 tfinc: I hadn't needed it yet, the last build you made got a thumbs up from Thehelpfulone on 5.1 and the next build brion gave me a thumbs up on 5.x and 4.3 as well
[00:37:34] <tfinc>	 preilly: are you chatting with tim about this in a particular channel ?
[00:37:53] <preilly>	 tfinc: wikimedia-dev
[00:38:01] <preilly>	 tfinc: why do you not trust me?
[00:38:24] <tfinc>	 there it is … thanks
[00:38:29] <Thehelpfulone>	 lol
[00:38:37] <tfinc>	 it was all too quiet for me in here
[00:38:38] <tfinc>	 :D
[00:46:56] <MaxSem>	 at last, reprod it in a VM
[00:47:39] <preilly>	 MaxSem: what is the issue?
[00:47:55] <MaxSem>	 looking
[00:48:27] <preilly>	 MaxSem: how did you reproduce locally?
[00:48:42] <preilly>	 MaxSem: e.g., what is the wikitext of your main page
[00:49:34] <MaxSem>	 default main page wrapped in <div id="mp-tfa">
[00:51:09] <preilly>	 MaxSem: I get the proper results if I do that
[00:51:43] <MaxSem>	 preilly, on 10.04 LTS?
[00:51:56] <preilly>	 MaxSem: my page has:
[00:51:57] <preilly>	 <div id='mp-tfa'>
[00:51:58] <preilly>	 This is a test!
[00:51:58] <preilly>	 </div>
[00:52:46] <preilly>	 Distributor ID:	Ubuntu
[00:52:47] <preilly>	 Description:	Ubuntu 11.10
[00:52:48] <preilly>	 Release:	11.10
[00:52:48] <preilly>	 Codename:	oneiric
[00:53:13] <awjr>	 wow i hard refreshed my mobile version of the main page and it's working for me now as well whereas it wasnt earlier
[00:53:52] <awjr>	 i blame solar flares.
[00:55:44] <preilly>	 MaxSem: can you paste bin your wikitext that fails
[00:56:14] <MaxSem>	 it's not just strictly wikitext, it's fucking libxml
[00:57:00] <preilly>	 MaxSem: can you show me the wikitext that fails
[00:57:04] <preilly>	 MaxSem: on your VM
[00:57:19] <MaxSem>	 fuck you libxml
[00:57:58] <preilly>	 MaxSem: could $mainPage->getElementById be failing due to a missing DTD in the source HTML
[00:58:13] <MaxSem>	 preilly, MobileFrontend.body.php
[00:58:30] <MaxSem>	 line 765
[00:58:33] <MaxSem>	 $formatter = new MobileFormatter( MobileFormatter::wrapHTML( "<div id='content'>$html</div>" ), self::$title, $this->contentFormat, $this->wmlContext );
[00:59:14] <preilly>	 MaxSem: what is that?
[00:59:24] <MaxSem>	 new content for it
[00:59:42] <MaxSem>	 try making local hack and synching it to the cluster
[01:00:25] <preilly>	 MaxSem: so, just <div id='content'>$html</div>
[01:00:44] <MaxSem>	 goddamn, I checked main page on Labs recently because I was suspecting something like that after skin change
[01:00:47] <MaxSem>	 it worked
[01:00:54] <MaxSem>	 caching?]
[01:01:11] <MaxSem>	 preilly, also wrapHTML
[01:02:43] <MaxSem>	 can you check it quckly?
[01:02:54] <preilly>	 MaxSem: I already reverted
[01:03:12] <preilly>	 MaxSem: I'd have to revert the revert
[01:03:40] <preilly>	 svn up -r 114870
[01:03:45] <MaxSem>	 preilly, I see it's still borked
[01:04:39] <preilly>	 -		$formatter = new MobileFormatter( $html, self::$title, $this->contentFormat, $this->wmlContext );
[01:04:40] <preilly>	 +		$formatter = new MobileFormatter( MobileFormatter::wrapHTML( "<div id='content'>$html</div>" ), self::$title, $this->contentFormat, $this->wmlContext );
[01:05:41] <preilly>	 MaxSem: you want that change?
[01:06:01] <MaxSem>	 preilly, if you revertd why it's still broken
[01:06:03] <MaxSem>	 ?
[01:06:17] <MaxSem>	 oh, now it's not
[01:06:22] <preilly>	 MaxSem: http://en.m.wikipedia.org/wiki/Main_Page?asdfkkkkkkkkk
[01:06:36] <MaxSem>	 scap works slowly
[01:06:47] <MaxSem>	 yes, I want this change
[01:07:26] <MaxSem>	 but let's try it tomorrow
[01:07:40] <MaxSem>	 too late here
[01:08:47] <MaxSem>	 okay?
[01:09:44] <MaxSem>	 preilly, ^^
[01:09:57] <tfinc>	 MaxSem: preilly stepped away for a sec
[01:10:46] <MaxSem>	 just tell him not to touch anything today w/o me
[01:10:59] <MaxSem>	 goin to sleep... 5:10 am
[01:12:25] <YuviPanda>	 tfinc: has this deploy been rolled back?
[01:12:33] <tfinc>	 preilly: --^
[01:13:59] <YuviPanda>	 tfinc: made http://www.mediawiki.org/wiki/Mobile/Test_iOS_app shall use on https://bugzilla.wikimedia.org/show_bug.cgi?id=35936
[01:15:10] <preilly>	 YuviPanda: it should be working now
[01:17:22] <tfinc>	 mark that bug as a duplicate
[01:17:49] <tfinc>	 YuviPanda: --^
[01:19:49] <YuviPanda>	 tfinc: the app should be working now
[01:19:58] <tfinc>	 YuviPanda: the app is stable enough for me to test now
[01:20:30] <YuviPanda>	 tfinc: cool, test it on 4.2?
[01:20:36] <YuviPanda>	 tfinc: clear your cache
[01:23:30] <awjr>	 git/gerrit sometimes give me a serious headache.
[01:25:09] <tfinc>	 YuviPanda: i am
[01:25:24] * YuviPanda  notes the amount of pain he's in for when he has to merge 3 *very* diverged branches together which will conflict a lot

[01:25:26] <tfinc>	 YuviPanda: so far its been ok
[01:28:04] <gerrit-wm>	 New patchset: preilly; "Add call to wrapHTML in HTML formatter" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4832
[01:29:48] <tfinc>	 no issues so far
[01:32:17] <gerrit-wm>	 New patchset: awjrichards; "Test change for remote branch" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4833
[01:32:31] <tfinc>	 YuviPanda: no major issues
[01:32:36] <YuviPanda>	 \o/
[01:32:39] <tfinc>	 YuviPanda: one minor issue
[01:32:49] <gerrit-wm>	 Change abandoned: awjrichards; "/me stabs git/gerrit" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/4833
[01:32:57] <YuviPanda>	 tfinc: hmm?
[01:33:17] <tfinc>	 YuviPanda: the search type ahead timeout is too short on this iPhone3G
[01:34:03] <tfinc>	 typing three characters goes through three different search results
[01:34:09] <tfinc>	 which is silly
[01:34:12] <tfinc>	 lets increase it
[01:34:26] <tfinc>	 feel free to only do it for the iPhone3
[01:34:41] <YuviPanda>	 tfinc: do you want to play around with values and tell me one?
[01:34:52] <YuviPanda>	 tfinc: chrome.js, search for '250', change them and see how it is?
[01:38:27] <gerrit-wm>	 New patchset: preilly; "Add back <META NAME="ROBOTS" CONTENT="NOINDEX, NOFOLLOW"> to template" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4834
[01:41:24] * YuviPanda  pokes tfinc 

[01:48:34] <gerrit-wm>	 New review: Demon; "Can we adjust the commit summary so it doesn't look like we're shouting?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/4834
[01:48:44] <tfinc>	 sure
[01:49:09] <preilly>	 http://etherpad.wikimedia.org/RobotsMetaTag
[01:49:12] <preilly>	 tfinc: ^^
[01:49:16] <tfinc>	  k
[01:51:11] <gerrit-wm>	 New patchset: preilly; "Add back robots meta tag to template" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4834
[01:54:20] <tfinc>	 YuviPanda: 350 seems to be working on .. let me try a couple more
[01:54:22] <tfinc>	 ok*
[01:54:28] <YuviPanda>	 tfinc: ok
[02:02:14] <tfinc>	 YuviPanda: 450 is too much
[02:02:22] * tfinc  tries 300

[02:06:09] <tfinc>	 YuviPanda: i'm liking 300 .. going down to 250 to see if it'll annoy me again
[02:06:15] <YuviPanda>	 tfinc: okay :)
[02:06:23] <YuviPanda>	 tfinc: are we planning on submitting this to the app store right after?
[02:07:42] <tfinc>	 YuviPanda: whats left in the 2 tracking bugs ?
[02:07:49] * YuviPanda  looks

[02:08:20] <YuviPanda>	 tfinc: https://bugzilla.wikimedia.org/show_bug.cgi?id=35776 has 'startup slow'
[02:08:29] <tfinc>	 300
[02:08:47] <YuviPanda>	 tfinc: shall change and push, unless you want to commit
[02:09:01] <tfinc>	 i'll do it
[02:09:05] <YuviPanda>	 cool
[02:10:03] <wikipedia-github>	 [WikipediaMobile] flyingclimber pushed 1 new commit to v3.1.2-iOS: http://git.io/vBiiuA
[02:10:03] <wikipedia-github>	 [WikipediaMobile/v3.1.2-iOS] Increasing keypress timeout to 300. Works better on iPhone3G - Tomasz Finc
[02:10:17] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #337: SUCCESS in 7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/337/
[02:10:17] <mw-jenkinsbot>	 tomasz: Increasing keypress timeout to 300. Works better on iPhone3G
[02:10:27] * tfinc  notices that desktop switching isn't actually working in the beta

[02:10:45] <preilly>	 tfinc: refresh the page
[02:10:54] <tfinc>	 i have
[02:10:56] <tfinc>	 many of times
[02:15:31] <tfinc>	 bug filed
[02:15:37] <tfinc>	 YuviPanda: so for slow startup time
[02:15:46] <tfinc>	 the only short term fix is to do a loading screen
[02:16:16] <YuviPanda>	 yes. I'd like a loading screen even after we make it fast. We shouldn't be showing the user something that looks like the UI but doesn't work (static image)
[02:16:26] <tfinc>	 it confused me to no end to see that
[02:16:31] <tfinc>	 and i thought the app was crashing
[02:16:35] <tfinc>	 do we have anything that we could use ?
[02:17:10] <tfinc>	 i'll need an updated change log for the store update
[02:17:10] <YuviPanda>	 we coudl just put the W logo on a white screen...
[02:17:20] <tfinc>	 try it
[02:17:21] <YuviPanda>	 yeah, that i'll make once we decide we're going to ship this to the store
[02:17:38] <YuviPanda>	 tfinc: i'll have to make one now :)
[02:17:59] <YuviPanda>	 hmm, I realized we'll have to make them for the iPad as well
[02:19:37] <YuviPanda>	 tfinc: I also found 'Avoid displaying an About window or a splash screen. In general, try to avoid providing any type of startup experience that prevents people from using your application immediately.' on https://developer.apple.com/library/ios/#documentation/userexperience/conceptual/mobilehig/UEBestPractices/UEBestPractices.html#//apple_ref/doc/uid/TP40006556-CH20-SW1
[02:22:57] <tfinc>	 there is no difference between our W and the current splash screen
[02:23:10] <tfinc>	 both are splash screens
[02:23:28] <tfinc>	 but in general sure … splash screen are dumb and are usually used for marketing
[02:23:38] <tfinc>	 we shouldn't need it
[02:24:22] <tfinc>	 although they do say 'Display a launch image '
[02:24:24] <tfinc>	 interesting
[02:24:39] <YuviPanda>	 so they want people to have something that looks like the UI but doesn't work like the UI?
[02:24:47] <tfinc>	 i don't get that
[02:25:08] <YuviPanda>	 also, my photoshop is french and crashing. Not sure I can make images now...
[02:26:09] <tfinc>	 i see
[02:26:17] <tfinc>	 meh .. lets just pass on it then
[02:26:20] <tfinc>	 we should be making it faster
[02:26:25] <tfinc>	 not covering up our slow app
[02:26:35] <YuviPanda>	 right.
[02:26:41] <YuviPanda>	 shall i do a version bump + changelog?
[02:26:45] <tfinc>	 yes
[02:26:56] <YuviPanda>	 ok
[02:27:11] <tfinc>	 YuviPanda: i'll have to go in about 20min
[02:27:16] <tfinc>	 as i'm way over my leave time
[02:27:57] <YuviPanda>	 tfinc: ok
[02:30:49] <tfinc>	 preilly: http://en.m.wikipedia.org/wiki/India#section_footer :(
[02:30:54] <tfinc>	 no i18n messages
[02:32:03] <tfinc>	 preilly: do you know why only some of them are missing ?
[02:32:04] <YuviPanda>	 tfinc: pushed. When do you plan on submitting to the app store?
[02:32:43] <wikipedia-github>	 [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/_CvYIQ
[02:32:43] <wikipedia-github>	 [WikipediaMobile/v3.1.2-iOS] Bumped version number and updated CHANGELOG - YuviPanda
[02:32:57] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #338: SUCCESS in 6.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/338/
[02:32:57] <mw-jenkinsbot>	 yuvipanda: Bumped version number and updated CHANGELOG
[02:33:14] <tfinc>	 pulling and building a release
[02:33:31] <YuviPanda>	 tfinc: are we submitting to the app store now?
[02:33:42] <tfinc>	 yes. pending developer release
[02:33:50] <YuviPanda>	 ok
[02:33:57] <tfinc>	 its your last chance to make any other changes
[02:37:56] <tfinc>	 YuviPanda: --^
[02:38:30] <YuviPanda>	 tfinc: testing upgrade from 2.x. Seems to crash :(
[02:38:41] <YuviPanda>	 despite this having the code from 3.1.1
[02:39:57] <preilly>	 tfinc: I'm talking to Tim about it right now
[02:40:28] <tfinc>	 k
[02:43:37] <tfinc>	 YuviPanda: try the near by view for [[India]]
[02:44:08] <tfinc>	 you won't see anything till you zoom way out … then it shows you an insane amount of pins
[02:44:12] <YuviPanda>	 tfinc: i'm upgrade testing. Interestingly or not, even the *old* iOS version is crashing on startup and I'm not sure why
[02:44:27] <YuviPanda>	 tfinc: will look into it once i'm done with this
[02:47:02] <tfinc>	 YuviPanda: i have to head home. I'll be back online from there
[02:47:25] <YuviPanda>	 tfinc: okay
[03:25:11] <flyingclimber>	 back
[03:25:30] <flyingclimber>	 YuviPanda: were you able to replicate what i saw on the near by geo coordinates view ?
[03:26:46] <YuviPanda>	 flyingclimber: been resetting my iPod. The previos 'upgrade problem' I reported was a false alarm. Just doing another upgrade test to be sure
[03:27:22] <YuviPanda>	 flyingclimber: yes, IIRC that was a limitation of geonames and how we were doing naive 'nearby' searches for any point. There was a bug for it as well…
[03:27:30] <YuviPanda>	 Let me do one more bit of upgrade testing and get back to nearby
[03:27:49] <flyingclimber>	 k
[03:28:04] * flyingclimber  goes to pickup laundry

[03:33:17] <YuviPanda>	 flyingclimber: upgrade testing seems ok
[03:44:13] <YuviPanda>	 flyingclimber: not ok. saved pages disappearing between 3.1.1 and 3.1.2
[03:44:15] <YuviPanda>	 investigating
[03:44:58] <flyingclimber>	 k
[04:26:53] <YuviPanda>	 flyingclimber: it is a phonegap issue. I'm investigating
[04:28:29] <flyingclimber>	 k
[05:41:03] <YuviPanda>	 flyingclimber: status update: Still investigating. No luck yet - haven't even been able to identify a potential source of the problem
[05:41:14] <YuviPanda>	 still at it
[05:41:18] <flyingclimber>	 what are you seeing?
[05:41:32] <flyingclimber>	 also, when are you going to bed?
[05:43:01] <YuviPanda>	 no idea.
[05:43:16] <YuviPanda>	 flyingclimber: so essentially, I'm seeing that the data persisted in v 3.1.1 is not being made available to 3.1.2
[05:43:29] <YuviPanda>	 flyingclimber: I can not look into the actual data folder itself without jailbreaking
[05:44:09] <YuviPanda>	 so I'm now trying to debug in objective-C. Am trying out something, if this is able to fix it/pinpoint the problem, all fine. Else i'll have to jailbreak this to take a look
[05:44:20] <YuviPanda>	 this assumes there's a jailbreak available for 5.1, which is not news i've been following
[05:45:05] <YuviPanda>	 flyingclimber: so essentially, saved pages will go 'poof' when you update. bad
[05:45:13] <flyingclimber>	 very bad
[05:45:22] <flyingclimber>	 can i help ?
[05:46:22] <YuviPanda>	 I have no specific things I can ask for help with.
[05:47:52] <flyingclimber>	 ok
[05:48:41] <YuviPanda>	 flyingclimber: think we can poke the PhoneGap devs who work at adobe about this?
[05:49:00] <YuviPanda>	 also the 'upgrade' testing has maddeningly too many clicks.
[05:49:18] <flyingclimber>	 sure, mail the iOS contact that brian gave us
[05:49:35] <YuviPanda>	 right, let me do that if this fails
[05:51:05] <YuviPanda>	 ok, that failed :(
[05:51:11] <YuviPanda>	 now I need to jailbreak this
[05:52:52] <YuviPanda>	 '3 hours left'
[05:52:59] <YuviPanda>	 and I can't do upgrade tests on the simulator
[05:58:59] <YuviPanda>	 hmm, short hop from berlin to the netherlands and I can get euthanized! :D
[06:11:17] <Rolken>	 you can actually see data without jailbreaking- look for iExplorer (er… assuming you're on a mac)
[06:11:45] <YuviPanda>	 Rolken: People on #phonegap reccomended iFunBox and that doesn't actually show me anything
[06:11:47] <YuviPanda>	 looking for iExplorer
[06:11:51] <Rolken>	 i don't think you can *edit* it without jailbreaking, but I haven't had reason to try, so I could be wrong on that
[06:12:01] <YuviPanda>	 i just need to see where the files are going
[06:24:07] <YuviPanda>	 Rolken: thanks, that works :)
[06:28:51] <Rolken>	 huh, apparently you CAN edit without jailbreaking. I'd be very careful doing so though
[06:29:34] <Rolken>	 I'm loathe to mess with a live system that clearly is not built to expect random programs messing with its innards
[06:29:58] <Rolken>	 but if you don't need that capability anyway, it's strictly of academic interest
[06:31:00] <Rolken>	 at any rate, it's a highly useful program
[06:31:10] <YuviPanda>	 Rolken: yeah, i'm just trying to figure out if things are staying where they have to be
[06:34:46] <Rolken>	 you can also cheat a bit and gain some insight into how other commercial devs have structured their programs :p
[06:35:09] <YuviPanda>	 surely not as crappily as ours :D
[06:38:22] <YuviPanda>	 interesting. The data is  still around
[06:38:25] <YuviPanda>	 and my localsettings is persisted
[06:38:28] <YuviPanda>	 my db settings ren't
[06:38:30] <YuviPanda>	 *aren't
[06:38:31] <YuviPanda>	 o_O
[06:38:54] * YuviPanda  makes clean builds

[06:48:50] <YuviPanda>	 flyingclimber: so, I found the 'bug'
[06:48:58] <flyingclimber>	 uhuh
[06:49:02] <YuviPanda>	 flyingclimber: essentially, saved pages list is getting wiped out after every app close
[06:49:06] <YuviPanda>	 ALL THE TIME
[06:49:09] <YuviPanda>	 so it is not upgrade that is failing
[06:49:12] <YuviPanda>	 if you save a page
[06:49:16] <YuviPanda>	 close the app (really close it)
[06:49:19] <YuviPanda>	 and open app again
[06:49:21] <YuviPanda>	 the page is gone
[06:49:29] <YuviPanda>	 this has been a bug in 3.1.1 that we haven't caught until now
[06:49:53] <YuviPanda>	 so, there are no saved pages to migrate. There never were. I now have a bug to fix.
[06:51:24] <flyingclimber>	 ahh
[06:53:13] <YuviPanda>	 did I miss anything?
[06:53:25] <YuviPanda>	 nope
[06:56:28] <flyingclimber>	 no
[07:09:50] <YuviPanda>	 heh, and this bug does not manifest in the simulators. how wonderful
[07:25:40] <wikipedia-github>	 [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/ZlAO7A
[07:25:40] <wikipedia-github>	 [WikipediaMobile/v3.1.2-iOS] Fix for saved pages never persisting - YuviPanda
[07:25:45] <YuviPanda>	 flyingclimber: i've a fix. Pushed.
[07:25:53] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #339: SUCCESS in 6.8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/339/
[07:25:53] <mw-jenkinsbot>	 yuvipanda: Fix for saved pages never persisting
[07:26:45] <flyingclimber>	 :)
[07:27:29] <flyingclimber>	 that means you can finally go to bed
[07:27:31] <YuviPanda>	 flyingclimber: now doing upgrade testing from 2.x to 3.1.2
[07:27:37] <YuviPanda>	 not really. I've a feeling that might break
[07:28:05] <YuviPanda>	 if I can verify that that doesn't break, then I'll go to bed :)
[07:28:21] <YuviPanda>	 doubt I'll be able to sleep in peace with this still out.
[07:32:10] <YuviPanda>	 yup, it breaks 2.x to 3.1.2
[07:32:12] <YuviPanda>	 ugh
[07:40:51] <YuviPanda>	 flyingclimber: got it to work
[07:41:00] <YuviPanda>	 I think.
[07:41:02] <YuviPanda>	 testing some more
[07:46:10] <wikipedia-github>	 [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/n10fAQ
[07:46:10] <wikipedia-github>	 [WikipediaMobile/v3.1.2-iOS] Does not crash on 2.x -> 3.x app upgrade - YuviPanda
[07:46:23] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #340: SUCCESS in 6.8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/340/
[07:46:24] <mw-jenkinsbot>	 yuvipanda: Does not crash on 2.x -> 3.x app upgrade
[07:54:51] <YuviPanda>	 flyingclimber: it's been fixed. Sent you an email
[07:54:59] <flyingclimber>	 excellent
[07:55:22] <flyingclimber>	 we can do final testing tomorrow and ship it out for approval
[07:55:31] <YuviPanda>	 yes
[07:55:48] <YuviPanda>	 flyingclimber: i've emailed you with precisely what to check for that affects these as well
[07:55:52] <flyingclimber>	 k
[07:56:54] <YuviPanda>	 2PM. I should reset my sleep cycle soon.
[07:56:58] <YuviPanda>	 flyingclimber: good night
[07:57:53] <YuviPanda>	 hmm, 1:30 PM, not two. nevermind
[07:59:08] <gerrit-wm>	 New patchset: MaxSem; "Restore <div id="content"> for b/c with apps, possible fix of blank main page during last deployment" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4844
[08:58:01] <MaxSem>	 jdlrobson, ohai
[08:58:07] <jdlrobson>	 hello MaxSem
[08:58:35] <MaxSem>	 why do we serve CSS both with RL and as static files at the same time?
[09:00:15] <MaxSem>	 jdlrobson, ^
[09:00:31] <jdlrobson>	 it's the device specific stylesheet
[09:00:39] <jdlrobson>	 i couldn't work out of a good way of using resource loader to do that
[09:00:47] <jdlrobson>	 can you?
[09:00:56] <jdlrobson>	 ideally we just want to use RL obviously
[09:01:58] <MaxSem>	 and what's the deal with <!--[if gt IE 9]><!--> ?
[09:02:10] <MaxSem>	 do I even understand what it does?
[09:02:33] <jdlrobson>	 it's a conditional if statement
[09:02:58] <jdlrobson>	 it's basically saying we don't support javascript for you unless you have IE 10 or higher - as the situation used to be extremely broken for IE users on mobile
[09:03:07] <jdlrobson>	 it's probably better now and we could probably relax it
[09:03:29] <jdlrobson>	 (obviously this is just for IE users)
[09:04:46] <MaxSem>	 but all the other user agents should receive them too?
[09:05:23] <jdlrobson>	 it's just an html comment so all browsers should ignore it
[09:05:34] <jdlrobson>	 it just has special meaning in IE land
[09:05:48] <jdlrobson>	 btw on wikipedia.org - i cannot get out of the mobile site at all
[09:08:30] <MaxSem>	 it's a fallout of yesterday's reverted deployment
[09:09:00] <jdlrobson>	 it was reverted?
[09:09:51] <MaxSem>	 yup, main page stubbornly remained blank
[09:10:11] <MaxSem>	 ...in addition to app being broken by div changes
[09:10:36] <jdlrobson>	 eek not again
[09:11:17] <jdlrobson>	 yet i'm looking at wikipedia now and it seems to have quite a lot of the styling changes
[09:11:37] <MaxSem>	 squids?
[09:12:32] <jdlrobson>	 guess so
[09:13:25] <MaxSem>	 any ideas when we will start moving features from beta to normal views?
[09:14:15] <jdlrobson>	 well tfinc saw several blockers - disabling images (which is now present), positioning desktop switcher (done), finalising toggling designs (pretty much design) and footer (done)
[09:14:15] <jdlrobson>	 s
[09:14:22] <jdlrobson>	 so i think now it is a case of making sure the app works with the beta
[09:14:40] <jdlrobson>	 btw MaxSem do you have any more background on this for me -https://bugzilla.wikimedia.org/show_bug.cgi?id=35910
[09:14:47] <jdlrobson>	 had make minified definitely been run?
[09:15:04] <MaxSem>	 no
[09:15:19] <MaxSem>	 but we misunderstood all those conditionals
[09:15:45] <MaxSem>	 let's just keep the bug till we have no need for separate minification
[09:16:45] <jdlrobson>	 that will be moving to resource loader
[09:44:11] <gerrit-wm>	 New patchset: Jdlrobson; "prevent infinite search" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4848
[09:51:32] <jdlrobson>	 MaxSem: have you got your samsung jet still?
[09:55:12] <MaxSem>	 yes, though it's inactive now
[09:58:01] <jdlrobson>	 no worries - i just think i have a fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=30829 and can't find a way to check
[10:14:22] <MaxSem>	 I can test it
[10:26:06] <MaxSem>	 jdlrobson, is it OK to use core's version of jQuery?
[10:26:15] <jdlrobson>	 i don't see why not
[10:30:33] <gerrit-wm>	 New patchset: Jdlrobson; "make text show with images disabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4850
[10:30:39] <jdlrobson>	 MaxSem: > https://gerrit.wikimedia.org/r/4850
[10:30:46] <jdlrobson>	 i think that's the best we are going to get
[10:34:07] <jdlrobson>	 also MaxSem  is this still broken -> https://bugzilla.wikimedia.org/show_bug.cgi?id=30827 ?
[10:34:12] <jdlrobson>	 can't test that either :(
[10:34:30] <MaxSem>	 yes
[10:34:58] <MaxSem>	 poked at it, everything should have wroked but it didn't
[10:36:15] <jdlrobson>	 :(
[10:36:50] <jdlrobson>	 let me know if  https://gerrit.wikimedia.org/r/4850 doesn't solve the samsung jet problem but doing the right thing for disabled images is a hard problem
[10:36:54] <MaxSem>	 I'll leave our jQuery as it is for now, core's version is not minified
[10:36:57] <jdlrobson>	 as browsers do what they fancy
[10:37:13] <MaxSem>	 sure
[10:37:32] <MaxSem>	 busy rewriting different parts now though
[10:43:35] <MaxSem>	 grrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr
[10:44:13] <MaxSem>	 our current RL usage results in us loading the same crap as desktop site
[10:45:37] <MaxSem>	 jdlrobson, we don't need mediawiki.legacy.commonPrint and mediawiki.legacy.shared, don't we?
[10:46:05] <jdlrobson>	 i'm guessing not
[10:46:06] <MaxSem>	 and we should decide if we need other extensions' CSS as well
[10:46:13] <jdlrobson>	 we do need the common.css as well though
[10:46:26] <MaxSem>	 our, not core's one?
[10:46:34] <jdlrobson>	 the cores one
[10:46:40] <MaxSem>	 why?
[10:46:57] <jdlrobson>	 to give admins more control for customisations
[10:47:02] <jdlrobson>	 there's a bug let me dig it out..
[10:47:15] <MaxSem>	 ah, you mean MediaWIki:common.css
[10:47:22] <jdlrobson>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=34325
[10:47:39] <jdlrobson>	 on extensions.. some extensions we will want their css
[10:47:43] <MaxSem>	 that's a bit different thing, as there's a static file with this name as well
[10:47:50] <jdlrobson>	 i guess extensions should have the ability to say whether they are needed by the mobile site though
[10:48:06] <MaxSem>	 worms, big can o'them
[10:48:08] <jdlrobson>	 for instance WebFonts
[10:52:31] <jdlrobson>	 also MaxSem is this bug still relevant? https://bugzilla.wikimedia.org/show_bug.cgi?id=30409
[10:52:41] <jdlrobson>	 I don't see a views directory in MFE
[10:58:20] <MaxSem>	 they're called templates and still need to go
[10:59:05] * MaxSem  --> away

[11:04:19] <gerrit-wm>	 New patchset: Jdlrobson; "don't make filepage links white" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4853
[11:04:20] <gerrit-wm>	 New patchset: Jdlrobson; "whitespace cleanup" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4854
[12:33:23] * YuviPanda  waves at jdlrobson 

[12:33:45] * jdlrobson  waves at yuvi

[12:33:57] <jdlrobson>	 hows the osx firefighting going?
[12:34:00] <jdlrobson>	 ios sorry
[12:34:17] <YuviPanda>	 jdlrobson: was up till about 3 hours ago. I think it is mostly done.
[12:34:28] <jdlrobson>	 also do you know whether it is possible to get an ipod touch simulator?
[12:34:39] <jdlrobson>	 anything i can help with?
[12:34:46] <YuviPanda>	 jdlrobson: no. the 'iOS simulator' is all you get.
[12:34:50] <jdlrobson>	 :(
[12:34:53] <YuviPanda>	 jdlrobson: so, I wanted to talk about merging things to master
[12:35:02] <jdlrobson>	 k np
[12:35:10] <YuviPanda>	 jdlrobson: I don't want to merge the modified common.css or toggle.js
[12:35:15] <jdlrobson>	 no
[12:35:19] <jdlrobson>	 agreed
[12:35:21] <YuviPanda>	 (and associated chrome.js hack)
[12:35:31] <YuviPanda>	 thoughts on how to get around that?
[12:35:41] <YuviPanda>	 are those *= based styles also in beta_common.css?
[12:35:43] * YuviPanda  looks

[12:35:57] <Rolken>	 tbh the differences between the 'iPhone' and the 'iPhone simulator' are larger than the differences would be between the 'iPhone simulator' and a hypothetical 'iPod touch sim'
[12:36:21] <jdlrobson>	 so YuviPanda i did lots of refactoring for yu
[12:36:22] <YuviPanda>	 +1 on Rolken, they're way more than 'oh, it is just faster'
[12:36:46] <jdlrobson>	 there is now a hacks.css file that has all the troublesome styles
[12:36:51] <YuviPanda>	 aha
[12:37:24] <jdlrobson>	 beta_common.css and sections.css are probably the only ones you need
[12:37:31] <YuviPanda>	 ok
[12:37:33] <jdlrobson>	 (but this would mean we'd need to take care of hacks some other way)
[12:37:35] <Rolken>	 actually the iPhone simulator is probably closer to an iPod touch simulator as it stands anyway- no cell, no gyro/accel, only fake-ish gps
[12:37:40] <jdlrobson>	 as the hacks are there for a purpose
[12:37:51] <YuviPanda>	 yeah, how do we fix clearInlineStyle?
[12:37:56] <YuviPanda>	 *clearInlineStyles?
[12:38:12] <jdlrobson>	 yeh reason I asked Rolken was I noticed today someone using an iPod touch - and I think what is happening is it is not getting detected and is being sent the wrong stylesheet
[12:38:15] <YuviPanda>	 jdlrobson: clearly, maintaining those is going to be a pain, since I assume you'll want to add more of them in the future
[12:38:36] <YuviPanda>	 jdlrobson: I can do specific testing for you if you want (have an iPod touch)
[12:38:52] <jdlrobson>	 its okay it is not urgent
[12:38:58] <YuviPanda>	 ok
[12:39:36] <YuviPanda>	 jdlrobson: also, I've stopped using toggle.js at all in the API move branch.
[12:39:43] <YuviPanda>	 I no longer inject the sections into DOM before they are expanded
[12:39:53] <YuviPanda>	 this makes things much faster.
[12:40:09] <jdlrobson>	 you load the section content dynamically?
[12:40:12] <YuviPanda>	 yes
[12:40:15] <jdlrobson>	 sweet
[12:40:24] <jdlrobson>	 i want this on the mobile site going forward
[12:40:29] <YuviPanda>	 :)
[12:40:57] <jdlrobson>	 what ever is easiest - i suspect i'll fork your toggling code at some point and we will come up with something that works for both
[12:41:07] <jdlrobson>	 so yeh the inline styles are annoying
[12:41:16] <YuviPanda>	 yeah, and how do we fix theM?
[12:41:27] <jdlrobson>	 so it is just the ones which have * in it?
[12:41:34] <jdlrobson>	 or all of the !important 's
[12:42:08] <YuviPanda>	 jdlrobson: the ones with the * was what we isolated them to, jdlrobson
[12:42:28] <jdlrobson>	 i think going forward what needs to happen is we need to scrub all inline styles on mobile and say that stuff needs to be done with classes - but that's a big change and could break lots
[12:42:50] <jdlrobson>	 k
[12:43:09] <jdlrobson>	 so I could rewrite those to be just [style]
[12:43:14] <jdlrobson>	 and see what side effects that has
[12:45:15] <jdlrobson>	 YuviPanda try this > https://gist.github.com/2376677
[12:51:30] <YuviPanda>	 jdlrobson: what did I miss?
[12:52:31] * YuviPanda  reads log

[12:53:47] <jdlrobson>	 basically  https://gist.github.com/2376677 YuviPanda
[12:53:52] <jdlrobson>	 or YuviPand_
[12:54:31] <YuviPand_>	 jdlrobson: how/where do you want me to try that?
[12:54:50] <jdlrobson>	 well depends if you have a real iphone :/
[12:55:07] <YuviPand_>	 heh, I don't yet :|
[12:55:09] <jdlrobson>	 this is the stylesheet without wildcard selectors
[12:55:28] <YuviPand_>	 jdlrobson: common.css? seems a bit too short for that...
[12:55:34] * YuviPand_  hasn't updated MFE

[12:56:13] <jdlrobson>	 nope i did a big refactor
[12:56:20] <jdlrobson>	 ohh but that only applies to the beta
[12:56:20] <jdlrobson>	 doh
[12:56:44] <YuviPand_>	 jdlrobson: so that's another question i wanted to talk about.
[12:56:48] <jdlrobson>	 but i can make it apply to the generic site
[12:56:53] <YuviPand_>	 jdlrobson: sure
[12:56:56] <YuviPand_>	 that'd be nice
[12:56:57] <YuviPanda>	 to test
[12:57:06] <YuviPanda>	 jdlrobson: also, I was wondering about how we're going to merge
[12:57:30] <YuviPanda>	 jdlrobson: I was thinking about cherrypicking whatever we need from v3.1.2-iOS into api-move and then rebase on top of master
[12:59:33] <YuviPanda>	 thoughts on that?
[13:00:14] <jdlrobson>	 is the plan for the next ios release to also move to the api?
[13:00:27] <YuviPanda>	 yes
[13:00:32] <jdlrobson>	 sweet
[13:00:40] <jdlrobson>	 so yeh i think cherry picking is the way to go here alas
[13:00:50] <jdlrobson>	 create a branch off api-move
[13:00:53] <YuviPanda>	 yeah, that's a lot of commits that'd need cherry picking :(
[13:00:59] <jdlrobson>	 and we cherry pick
[13:01:08] <jdlrobson>	 at least it means we will be thorough
[13:01:59] <YuviPanda>	 yeah
[13:02:21] <YuviPanda>	 jdlrobson: i'll cherrypick stuff that doesn't involve the style work but all other stuff
[13:02:38] <jdlrobson>	 so i will refactor the current common.css
[13:02:43] <jdlrobson>	 so that the hacks are not there
[13:02:58] <jdlrobson>	 it will then just be a case of including common.css and hacks.css
[13:03:33] <YuviPanda>	 jdlrobson: ok!
[13:03:42] <jdlrobson>	 i should have done that anyway..
[13:03:48] <jdlrobson>	 seems a bit of an oversight on my part
[13:07:29] <jdlrobson>	 done
[13:08:27] <gerrit-wm>	 New patchset: Jdlrobson; "fixed issue with squashed disambiguation text on certain pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4867
[13:08:28] <gerrit-wm>	 New patchset: Jdlrobson; "reduce font size of search for smaller screens" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4868
[13:08:29] <gerrit-wm>	 New patchset: Jdlrobson; "remove wildcard selectors, collapse hacks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4869
[13:08:29] <gerrit-wm>	 New patchset: Jdlrobson; "remove duplicate definitions from common.css that are in hacks.css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4870
[13:12:37] <gerrit-wm>	 New review: Demon; "You seem to have missed my inline comments on patch 1. Why are we still yelling here?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/4834
[13:16:44] * MaxSem  --> back

[13:19:13] <gerrit-wm>	 Change abandoned: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4844
[13:19:39] <jdlrobson>	 YuviPanda: so try out common.css https://gerrit.wikimedia.org/r/cat/4870%2C1%2Cstylesheets/common.css%5E0
[13:19:47] <jdlrobson>	 and the hacks.css file i linked to
[13:20:02] <jdlrobson>	 hopefully that takes care of the styling problems
[13:20:22] <YuviPanda>	 jdlrobson: does it cause any issues in mf?
[13:20:28] <jdlrobson>	 doesn't seem to
[13:20:33] <jdlrobson>	 i'm still testing on mobile-geo
[13:21:00] <YuviPanda>	 cool, then shouldn't here either
[13:52:06] <gerrit-wm>	 New patchset: Jdlrobson; "Revert "limit checkHash to links with a content_block"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4876
[13:54:53] <jdlrobson>	 right YuviPanda popping out for some air and food for tonight
[15:54:34] <Amgine>	 ChrisMcMahon: ping
[16:10:40] <chrismcmahon>	 hi Amgine
[16:11:29] <Amgine>	 Heya ChrisMcMahon! wiktionary mobile app needs beta testers. Got some in your pockets?
[16:11:56] <chrismcmahon>	 Amgine: I can always ask.  what OS/device?
[16:12:08] <Amgine>	 Android/any
[16:12:42] <chrismcmahon>	 Amgine! I'll sign up, I have an android.  (I don't have any iOS devices though)
[16:13:09] <gerrit-wm>	 New patchset: MaxSem; "Switched the remaining CSS to RL" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4892
[16:13:41] <Amgine>	 ChrisMcMahon: http://integration.mediawiki.org/WiktionaryMobile/nightly/Wiktionary_latest.apk
[16:18:21] <chrismcmahon>	 Amgine: word of the day is "pink slime" I see
[16:19:21] <Amgine>	 <gg> Don't blame me! it's chosen by the project.
[16:20:12] <chrismcmahon>	 Amgine: discuss issues in this channel, or report them somewhere?
[16:20:41] <Amgine>	 Some of the things we're looking for testing are the menus, the 'listen-in' pronunciation sound files, and the display of the top section. Feedback to http://meta.wikimedia.org/wiki/Mobile_Projects/WiktionaryMobileAndroidFeedback
[16:25:46] <chrismcmahon>	 Amgine:  one thing I notice right away on the front page is that "Word of the day" and "for April 13" are in different fonts, and shown as "day" (big font) "for" (small font) "edit" (link) , "refresh" (link) <line break> April 13 (small font)
[16:26:34] <Amgine>	 ChrisMcMahon: Noted. I will look to see if that's a template issue or default fonts issue.
[16:27:05] <Amgine>	 I'm adding to http://meta.wikimedia.org/wiki/Mobile_Projects/WiktionaryMobileAndroidFeedback, which I forgot to give you.
[16:32:49] <chrismcmahon>	 Amgine: feature or bug?  search for a word, the top of the resulting page shows only "Hide" button and text "English", not the string/word searched.
[16:33:35] <Amgine>	 Hum. Bug.
[16:33:59] <Amgine>	 That's really odd behavior, actually.
[16:34:15] <Amgine>	 pfhayes: help troubleshoot?
[16:35:00] <chrismcmahon>	 Amgine, word I searched was "rhythm", the resulting page has a number of layout and display issues.
[16:35:23] <pfhayes>	 Amgine, chrismcmahon: http://en.m.wiktionary.org/wiki/rhythm, you see the same behaviour in browser
[16:36:06] <Amgine>	 Does the show/hide button display, ChrisMcMahon?
[16:36:33] <chrismcmahon>	 Amgine: yes, show/hide works
[16:36:50] <Amgine>	 And there's no content change?
[16:36:58] <Amgine>	 On the phone.
[16:37:10] <chrismcmahon>	 nope, behavior in browser and phone is similar
[16:37:28] <pfhayes>	 chrismcmahon, Amgine : as far as I can tell, on both Wikipedia and Wiktionary, in all mediums, mobile pages don't have titles
[16:37:30] <Amgine>	 in browser for me it displays properly.
[16:37:45] <chrismcmahon>	 note one thing though, the really big indent under Translation/Chinese/Mandarin looks OK in the browser, not so OK on the phone
[16:37:48] <pfhayes>	 Amgine: yes, i think the objection is that there is no title 'rhythm'
[16:37:51] <gerrit-wm>	 New review: Jdlrobson; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1;  - https://gerrit.wikimedia.org/r/4892
[16:38:06] <Amgine>	 Oh. I missed that pfhayes.
[16:38:32] <chrismcmahon>	 pfhayes: given that typing on phones is not so accurate, I think it would be good to display the title of the resulting page to confirm that result is what user searched for
[16:38:57] <Amgine>	 That's actually a feature of the mobile frontend, chrismcmahon.
[16:44:10] <chrismcmahon>	 my phone clearly has a far more limited set of characters than my browser does :)
[16:45:07] <Amgine>	 <grins> Mine too.
[16:46:12] <Amgine>	 My kid studies Syriac. I'm probably one of a dozen people on the planet with multiple syriac fonts.
[16:46:49] <mw-jenkinsbot>	 Project WiktionaryMobile - Nightly builds build #73: SUCCESS in 9.9 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/73/
[16:46:49] <mw-jenkinsbot>	 * dale.lemieux: Update to handle sharing from Wiktionary to Wiktionary
[16:46:50] <mw-jenkinsbot>	 * dale.lemieux: Added support for all wiki urls
[16:47:38] <chrismcmahon>	 ah, here's something:  under Translation, browser shows lines of text as grey headers for boxes, phone shows just plain text and the yellow boxes without the headers or background behind the yellow boxes
[16:48:47] <Amgine>	 Yes. Wiktionary has custom javascript to show/hide elements. There's a bug to allow project-specific javascript.
[16:48:52] <jdlrobson>	 MaxSem: the mobile site seems to be throwing away headings was that intended?
[16:48:57] <jdlrobson>	 e.g. http://en.m.wikipedia.org/wiki/South
[16:50:07] <MaxSem>	 throwing away?
[16:51:18] <wikipedia-github>	 [WikipediaMobile] jdlrobson created nearbylistview31956 (+6 new commits): http://git.io/whSOzw
[16:51:18] <wikipedia-github>	 [WikipediaMobile/nearbylistview31956] [Bug #31956] Offers a list view(lacks a switch though) - Ashish Dubey
[16:51:18] <wikipedia-github>	 [WikipediaMobile/nearbylistview31956] [Bug #31956] Offers nearby list with view switches - updated - Ashish Dubey
[16:51:18] <wikipedia-github>	 [WikipediaMobile/nearbylistview31956] Merge remote-tracking branch 'dash1291/master' into tmp - Jon Robson
[16:51:33] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #341: SUCCESS in 7.3 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/341/
[16:56:17] <jdlrobson>	 yeh MaxSem - for example compare http://jonrobson.me.uk/wikipedia/toggling/obama.html with http://en.wikipedia.org/wiki/Barack_Obama
[16:56:23] <jdlrobson>	 the first is how it used to be outputted
[16:56:29] <tfinc>	 greetings all
[16:56:34] <jdlrobson>	 it's a bit confusing as it's not clear what article you are viewing
[16:56:45] <chrismcmahon>	 http://en.m.wiktionary.org/wiki/run the 3-column layout for "Derived terms" looks pretty  bad on the phone.  And the two-column view of "Translations" has many empty right-hand columns.
[16:56:46] <jdlrobson>	 hey tfinc
[16:57:46] <chrismcmahon>	 (btw, "run" is a really good word for testing, iirc it is the longest entry in the OED)
[16:58:09] * YuviPanda  looks around

[16:58:17] <tfinc>	 hey YuviPanda
[16:58:22] <YuviPanda>	 heya tfinc
[16:58:28] <tfinc>	 i got in too late to do our 9:45 standup
[16:58:31] <tfinc>	 damn metro
[16:58:43] <tfinc>	 so we'll just use the 10 standup and talk after as needed
[16:58:52] <YuviPanda>	 alright
[16:59:06] <Amgine>	 chrismcmahon: The most famous test word in en.WT is 'Water', because it has the longest/most complex template (the translations of water)
[17:00:01] <tfinc>	 all right … lets do out standup
[17:00:21] <wikipedia-github>	 [WikipediaMobile] jdlrobson force-pushed nearbylistview31956 from 9abca07 to 5e00e24: http://git.io/j1K52Q
[17:00:21] <wikipedia-github>	 [WikipediaMobile/nearbylistview31956] post merge cleanup - Jon Robson
[17:00:21] <wikipedia-github>	 [WikipediaMobile/nearbylistview31956] make switch to map view label elastic - Jon Robson
[17:00:21] <wikipedia-github>	 [WikipediaMobile/nearbylistview31956] css and html tweaks for ios - Jon Robson
[17:00:35] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #342: SUCCESS in 6.7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/342/
[17:00:35] <mw-jenkinsbot>	 * jdlrobson: post merge cleanup
[17:00:36] <mw-jenkinsbot>	 * jdlrobson: make switch to map view label elastic
[17:00:36] <mw-jenkinsbot>	 * jdlrobson: css and html tweaks for ios
[17:14:23] <tfinc>	 13 minutes … wow … that was getting clsoe
[17:14:24] <tfinc>	 close*
[17:14:32] <YuviPanda>	 heh
[17:14:36] * tfinc  needs to speed things along better next time

[17:14:38] <MaxSem>	 jdlrobson, expandable sections work for me on both pages
[17:14:54] <tfinc>	 YuviPanda: what do you need me to test on 4.2 ?
[17:14:54] <jdlrobson>	 and so they should... why wouldn't they?
[17:15:03] <tfinc>	 YuviPanda: also .. did you buy a 4.2 device ?
[17:15:03] <YuviPanda>	 tfinc: i mentioned that in the email
[17:15:06] <tfinc>	 k
[17:15:17] <YuviPanda>	 tfinc: I've found sources that have 3GS, none that have a 3G
[17:15:33] <tfinc>	 take another day on it and if you can't find it then i can buy one and mail it to you
[17:15:47] <YuviPanda>	 yeah, cool.
[17:16:05] <YuviPanda>	 i'll put the weekend to it
[17:16:45] <tfinc>	 besides my testing. what else is blocking market release ?
[17:17:07] <tfinc>	 awjr: did prielly catch you up enough on yesterdays deployment ?
[17:17:14] <MaxSem>	 I'm having problems with git on labs:
[17:17:16] <jdlrobson>	 I can't see the problem preilly mentioned about the coordinates - http://en.wikipedia.org/wiki/Toronto#_
[17:17:19] <MaxSem>	 maxsem@mobile-enwp:/var/www/wgit/core/extensions/MobileFrontend$ sudo git fetch https://gerrit.wikimedia.org/r/p/mediawiki/extensions/MobileFrontend refs/changes/50/4850/1 && git checkout FETCH_HEAD
[17:17:24] <jdlrobson>	 http://en.wikipedia.org/wiki/Toronto?mobileaction=beta
[17:17:28] <MaxSem>	 fatal: Unable to create '/var/www/wgit/core/extensions/MobileFrontend/.git/index.lock': Permission denied
[17:17:30] <awjr>	 tfinc: i grokked the highlights during the standup
[17:17:30] <jdlrobson>	 neither have it
[17:17:33] <tfinc>	 jdlrobson: i stand by that i can't use mobile if i'm not on the beta :) nice new changes
[17:17:33] <YuviPanda>	 tfinc: nothing, though i'd like brion to check on 4.3 as well
[17:17:40] <tfinc>	 brion: --^
[17:17:44] <brion>	 can do
[17:17:46] <tfinc>	 thanks
[17:18:11] * brion  checks what changed since yesterday

[17:18:12] <YuviPanda>	 brion: we found a super nasty bug yesterday. The databases were not being saved at all, so saved pages and history were being wiped out after every app close
[17:18:12] <YuviPanda>	 brion: has been fixed, so I'd like you to test that
[17:18:23] <brion>	 hah!
[17:18:27] <brion>	 ouchies
[17:18:29] <tfinc>	 jdlrobson: preilly: can you let phil know when the common.css changes are fixed. i'd like him to message to mobile-l@ to get people testing again
[17:18:40] <philinje>	 jdlrobson: question, did you say "headings are not showing up"?
[17:18:49] <jdlrobson>	 the initial heading yes
[17:19:02] <jdlrobson>	  compare http://jonrobson.me.uk/wikipedia/toggling/obama.html with http://en.wikipedia.org/wiki/Barack_Obama
[17:19:06] <MaxSem>	 ah heh - got it
[17:19:07] <jdlrobson>	 i'm trying to work out now what has happened
[17:19:17] <jdlrobson>	 MaxSem: got the headings?
[17:19:35] <MaxSem>	 this happened because it was part of skin, not page output
[17:19:51] <MaxSem>	 so we need to construct it manually now
[17:20:08] <jdlrobson>	 in ApplicationTemplate ?
[17:20:15] <MaxSem>	 yes
[17:22:03] <jdlrobson>	 i'll look into that
[17:22:28] <philinje>	 jdlrobson: also curious about the user test video - was that a fix for Firefox?
[17:22:41] <jdlrobson>	 that was an issue with the mediawiki instance
[17:22:44] <MaxSem>	 mmm, we've got a perf regression https://graphite.wikimedia.org/render?width=500&from=-2days&until=now&height=380&target=ExtMobileFrontend.DOMParse-templates.tavg&uniq=0.8990247335995537&title=ExtMobileFrontend.DOMParse-templates.tavg
[17:22:49] <jdlrobson>	 but it was only being exposed on firefox
[17:22:55] <tfinc>	 jdlrobson: i've asked phil to always specify browser for our usertesting.com tests … so that we don't run into surprises
[17:22:59] <brion>	 so far so good on 4.3.2
[17:23:11] <jdlrobson>	 also philinje i thought the obama test wasn't very useful..
[17:23:25] <jdlrobson>	 since the answers were in the infobox so they didn't actually using the toggling on the sections :(
[17:24:21] <YuviPanda>	 brion: kill the app and start again to check if the data is still around
[17:24:41] <brion>	 YuviPanda: confirmed
[17:25:07] <YuviPanda>	 confirmed to work or confirmed to not? :D
[17:25:21] <brion>	 my saved pages and history are retained :)
[17:25:40] <YuviPanda>	 awesome
[17:26:01] <MaxSem>	 looks like the slowdown is caused by RL initialisation that previously happened earlier, outside of our code
[17:26:02] <YuviPanda>	 brion: can you do upgrade testing from 2.x? That's something that was affected too...
[17:26:10] <tfinc>	 i'm testing as well but the iPhone3G isn't know for its fast response time in doing anything
[17:26:34] <brion>	 2.x is the obj-c app?
[17:26:39] <tfinc>	 brion: yes
[17:26:43] <brion>	 i'll try
[17:27:23] <YuviPanda>	 brion: so, note that you'll have to name the old *and* new ipa the same name for the upgrade process to work
[17:27:38] <YuviPanda>	 and by default the new app produces a different IPA name
[17:30:20] <brion>	 ok got the old app installed
[17:30:40] <brion>	 updating to new app...
[17:31:00] <brion>	 seems to work!
[17:31:43] <YuviPanda>	 brion: no crashes, spinner spins, and saved pages persist after app kill?
[17:31:51] <brion>	 yep
[17:32:02] <brion>	 no crashes, spinner's ok, saved page persisted across a kill/restart
[17:32:06] <brion>	 \o/
[17:32:08] <YuviPanda>	 awesome!
[17:32:10] <YuviPanda>	 tfinc: ^
[17:32:18] <tfinc>	 woot!
[17:32:29] <tfinc>	 YuviPanda: test #1 passes
[17:32:51] <MaxSem>	 preilly & awjr, do you know if there's a Graphite metric that can evaluate the overall mobile site performance, as opposed to separate functions?
[17:33:01] <YuviPanda>	 tfinc: how's 4.2 testing coming along?
[17:33:02] <YuviPanda>	 cool
[17:33:02] <YuviPanda>	 you've two more
[17:33:36] <awjr>	 tfinc not that i'm aware of
[17:34:19] <philinje>	 some more comments from the user Axel, not sure if we have bugs on all these
[17:34:56] * tfinc  builds the old app

[17:35:42] <tfinc>	 tfinc: YuviPanda: test #1 passes 10:32AM
[17:38:01] <philinje>	 putting Axel's comments on iOS feedback wiki page
[17:38:21] <tfinc>	 philinje: are they bugs or new feature requests ?
[17:40:04] <philinje>	 both
[17:40:14] <philinje>	 mostly bugs
[17:40:33] <philinje>	 i will see if they match current bugs and add new ones as necessary
[17:42:10] <tfinc>	 philinje: exactly . if their bugs then lets get them into bugzilla
[17:42:19] <YuviPanda>	 tfinc: *they're
[17:42:24] <tfinc>	 right
[17:42:25] <tfinc>	 :D
[17:42:28] <philinje>	 by the way, I added links to all 3 feedback pages from Mobile design
[17:42:32] <tfinc>	 k
[17:42:42] <jdlrobson>	 preilly: i can't replicate the coordinates bug..
[17:43:11] <philinje>	 i'm not seeing it either
[17:43:41] <tfinc>	 YuviPanda: test #2 passes
[17:43:47] <YuviPanda>	 \o/
[17:43:59] <YuviPanda>	 test three should pass as well, but try it anyway
[17:44:14] <tfinc>	 YuviPanda: which branch should i pull from for v3.1.1 ?
[17:44:19] <YuviPanda>	 v3.1.1-iOS
[17:45:01] <tfinc>	 k
[17:46:15] <gerrit-wm>	 New patchset: preilly; "Add back robots meta tag to template" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4834
[17:47:25] <MaxSem>	 preilly, we're blocking spiders on mobile site again?
[17:49:19] <gerrit-wm>	 New review: MaxSem; "There's also optional inclusion of noindex tags with {$robots} above, there might be duplication." [mediawiki/extensions/MobileFrontend] (master) C: 0;  - https://gerrit.wikimedia.org/r/4834
[17:49:39] <preilly>	 MaxSem: yes
[17:49:48] <preilly>	 MaxSem: That is what Erik wants
[17:50:03] <MaxSem>	 ??
[17:50:15] <preilly>	 jdlrobson: yeah, I don't see it anymore either
[17:50:53] <preilly>	 MaxSem: why the ??
[17:51:07] <gerrit-wm>	 New patchset: Jdlrobson; "restore article title" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4898
[17:51:08] <gerrit-wm>	 New patchset: Jdlrobson; "make large tables scrollable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4899
[17:51:12] <MaxSem>	 preilly, what was his motivation, I mean?
[17:52:16] <philinje>	 MaxSem: i will forward the very long email thread
[17:52:50] <tfinc>	 arg
[17:53:13] <tfinc>	 YuviPanda: test case #3 is harder to do
[17:53:19] <YuviPanda>	 tfinc: ?
[17:53:37] <tfinc>	 there is something wrong with entitlements
[17:53:41] <tfinc>	 i've fixed this in the past
[17:54:16] <YuviPanda>	 are you naming the IPAs the same?
[17:54:26] <tfinc>	 YuviPanda: this is a build problem
[17:54:30] <YuviPanda>	 ugh
[17:54:31] <YuviPanda>	 ok
[17:57:09] <MaxSem>	 philinje, thanks
[17:58:33] <tfinc>	 and due to the voodoo that is the apple eco system .. it works when i rebuild
[17:59:16] <YuviPanda>	 right
[18:05:36] <jdlrobson>	 YuviPanda: need assistance with anything?
[18:05:59] <YuviPanda>	 jdlrobson: just cherry-picking. half way through.
[18:06:12] <jdlrobson>	 give me a shout if i can help with anything
[18:06:22] <jdlrobson>	 i was thinking about the toggle.js changes btw
[18:06:23] <YuviPanda>	 jdlrobson: also, a few more commits were added to v3.1.2-iOS since you last looked at it. Want to CR those?
[18:06:23] <YuviPanda>	 nothing big
[18:06:27] <tfinc>	 YuviPanda: iTunes is being a pain
[18:06:29] <tfinc>	 stay tuned
[18:06:39] <YuviPanda>	 jdlrobson: ah
[18:06:48] <jdlrobson>	 since we are using an old version maybe we should store that version as a gist temporarily and just point the remotes at it
[18:06:48] <YuviPanda>	 jdlrobson: they're all in api-move branch on my repo, btw
[18:06:50] <tfinc>	 now 3.1.2 is throwing entitlement issues
[18:06:53] * tfinc  hates this

[18:07:45] <YuviPanda>	 jdlrobson: ? the version we use in the app is 'pinned' from svn
[18:07:56] <jdlrobson>	 yes but i thought we had to make changes to it?
[18:08:00] <chrismcmahon>	 Amgine: so here's an odd thing.  from page http://en.m.wiktionary.org/wiki/Santa_Fe  "From Spanish santa fe, "holy faith".  Click the link for "santa", and the first result opened by default is Finnish for "sand".  To be expected I guess since Finnish is first alphabetically.  The table for "declension" at http://en.m.wiktionary.org/wiki/santa#section_1 appears highly squished on the phone.
[18:08:36] <jdlrobson>	 for instance using jQuery toggle
[18:08:51] <jdlrobson>	 also yuvi think you may need to push
[18:08:51] <jdlrobson>	 https://github.com/yuvipanda/WikipediaMobile/commits/api-move
[18:08:55] <jdlrobson>	 last commits are from the 6th
[18:09:09] <YuviPanda>	 au
[18:09:20] <YuviPanda>	 in middle of cherry picking, gimme a few
[18:09:29] <jdlrobson>	 no worries
[18:09:33] <Amgine>	 ChrisMcMahon: Ouch, very squished yes.
[18:12:00] <YuviPanda>	 jdlrobson: api-move now has required things cherry-picked
[18:12:07] <jdlrobson>	 awesome
[18:12:33] <YuviPanda>	 jdlrobson: quite a long list though :)
[18:13:08] <YuviPanda>	 jdlrobson: and pushed. please do check out to make sure there is nothing cherry-picked that you don't agree with.
[18:13:08] <YuviPanda>	 i didn't pick any of the common.css or toggle.js stuff
[18:13:19] <YuviPanda>	 now rebasing against master. This is going to be painful
[18:17:46] <tfinc>	 YuviPanda: i can't debug the entitlements issue right now. will have to get back to it in about an hour
[18:17:53] <tfinc>	 feel free to get someone else to do test #3
[18:17:54] <YuviPanda>	 augh
[18:18:07] * YuviPanda  sighs

[18:18:09] <YuviPanda>	 tfinc: ok
[18:19:48] <gerrit-wm>	 New patchset: awjrichards; "Fixes bug 35940" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4904
[18:19:58] <awjr>	 preilly can you take a look at that ^
[18:21:15] <YuviPanda>	 jdlrobson: force pushed to api-move from master.
[18:21:30] <YuviPanda>	 jdlrobson: think you can take a look?
[18:21:50] <jdlrobson>	 sure gimme 10 mins just fixing up some dinner and my multi-tasking is not doing so well :)
[18:22:19] <YuviPanda>	 hehe
[18:25:57] <preilly>	 awjr: *clicking*
[18:26:02] <preilly>	 awjr: *looking*
[18:27:29] <preilly>	 awjr: https://gerrit.wikimedia.org/r/#patch,sidebyside,4904,1,tests/MobileFrontendTest.php
[18:27:38] <preilly>	 awjr: evil whitespace!
[18:28:19] <awjr>	 sigh.
[18:28:21] <awjr>	 one sec
[18:29:34] <preilly>	 MaxSem: how should we do this robots stuff correctly
[18:29:54] <MaxSem>	 preilly, I'm thinking of configuration option
[18:30:10] <gerrit-wm>	 New patchset: awjrichards; "Fixes bug 35940" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4904
[18:30:27] <awjr>	 preilly see new patchset ^
[18:31:01] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4904
[18:31:27] <MaxSem>	 awjr, it's usually frowned upon to combile w/s changes with logic changes
[18:31:32] <MaxSem>	 *combine
[18:31:43] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4904
[18:31:45] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4904
[18:32:02] <awjr>	 MaxSem i'll keep it in mind next time.
[18:32:03] <preilly>	 awjr: booyakasha – change has been successfully merged into the git repository.
[18:32:07] <awjr>	 far out
[18:32:48] <YuviPanda>	 jdlrobson: also, do you have a 'favorite' fastclick implementation?
[18:32:57] <awjr>	 preilly i dont normally like deploying on fridays but should we push that change out?
[18:33:10] <preilly>	 awjr: yes, I think so
[18:33:15] <awjr>	 k
[18:33:42] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2;  - https://gerrit.wikimedia.org/r/4832
[18:33:53] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4832
[18:33:55] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4832
[18:33:55] <awjr>	 preilly did i hear you correctly this AM that 1.19wmf1 is still on SVN so we have to do the wacky gitsvn merge?
[18:34:06] <preilly>	 awjr: yes, sir
[18:34:22] <awjr>	 preilly k thanks - any other fixes to go out right now?
[18:35:15] <preilly>	 MaxSem: can we approve this https://gerrit.wikimedia.org/r/#change,4834
[18:35:27] <preilly>	 MaxSem: and then switch it to a configuration option later
[18:35:42] <MaxSem>	 why not
[18:35:55] <MaxSem>	 I'll fix it once I finish my current chunk
[18:36:12] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4848
[18:36:14] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4848
[18:36:26] <preilly>	 awjr: I'm looking through the queue right now
[18:37:21] <jdlrobson>	 no i don't... sorry YuviPanda !
[18:37:30] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4817
[18:37:32] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4817
[18:38:32] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4834
[18:38:35] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4834
[18:39:23] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4898
[18:39:25] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4898
[18:40:12] * YuviPanda  checks log

[18:40:18] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4899
[18:40:20] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4899
[18:41:22] <awjr>	 preilly: going afk for a minute - let me know if there are any other chagnes to go out, otherwise i'll just patch deployment with my changes.
[18:43:17] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4892
[18:44:25] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4850
[18:44:27] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4850
[18:44:59] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4853
[18:45:01] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4853
[18:45:23] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4854
[18:45:25] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4854
[18:45:46] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4867
[18:45:48] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4867
[18:46:17] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4868
[18:46:19] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4868
[18:46:49] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4869
[18:46:52] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4869
[18:47:14] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4870
[18:47:44] <preilly>	 jdlrobson: https://gerrit.wikimedia.org/r/#change,4870 — Your change requires a recursive merge to resolve. Please merge (or rebase) the change locally and upload the resolution for review.
[18:48:17] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4876
[18:48:20] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4876
[18:49:36] <preilly>	 MaxSem: https://gerrit.wikimedia.org/r/#change,4892 — Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
[18:49:52] <MaxSem>	 affirmative
[18:51:06] <awjr>	 preilly do you want all of those changes you just merged pushed as well?
[18:51:17] <preilly>	 awjr: well, I think so
[18:51:33] <awjr>	 k
[18:51:37] <preilly>	 awjr: I actually want 4870 and 4892
[18:51:44] <preilly>	 awjr: as well...
[18:51:49] <preilly>	 jdlrobson: ping
[18:51:55] <awjr>	 preilly k i'll wait
[18:51:59] <gerrit-wm>	 New patchset: Jdlrobson; "remove duplicate definitions from common.css that are in hacks.css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4870
[18:52:00] <preilly>	 awjr: thanks
[18:52:12] <awjr>	 preilly np that'll be easier anyway than cherry picking
[18:52:16] <jdlrobson>	 hey preilly
[18:52:19] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4870
[18:52:21] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4870
[18:52:24] <preilly>	 jdlrobson: nevermind
[18:52:36] <jdlrobson>	 always one step ahead? :)
[18:53:44] <preilly>	 ha
[18:53:53] <preilly>	 MaxSem: are you rebasing your change?
[18:54:01] <MaxSem>	 waitasec
[18:56:47] <gerrit-wm>	 New patchset: Jdlrobson; "remove geography text align hack" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4906
[18:57:22] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4906
[18:57:24] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4906
[18:59:47] <awjr>	 ok preilly, ready?
[19:00:01] <preilly>	 awjr: waiting on MaxSem
[19:00:04] <awjr>	 o
[19:00:45] <YuviPanda>	 tfinc: do you know when you would be able to get back?
[19:00:58] <MaxSem>	 sorry, merging right now
[19:03:57] <gerrit-wm>	 New patchset: MaxSem; "Switched the remaining CSS to RL" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4907
[19:04:11] <gerrit-wm>	 Change abandoned: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4892
[19:04:14] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4892
[19:04:20] <MaxSem>	 damn, my git-fu teh sux
[19:04:47] <preilly>	 MaxSem: just submit a new commit
[19:04:57] <MaxSem>	 preilly, just what I did
[19:05:03] <MaxSem>	 preilly, https://gerrit.wikimedia.org/r/4907
[19:05:37] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4907
[19:05:37] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4907
[19:05:47] <preilly>	 awjr: okay, we're good
[19:05:58] <awjr>	 preilly ok ima go ahead and patch 1.19wmf1
[19:09:41] <YuviPanda>	 jdlrobson: attr vs data
[19:09:59] <YuviPanda>	 I like keeping things in attr because then I can set defaults in the html markup
[19:10:32] <jdlrobson>	 but don't those get inherited by jQuery these days?
[19:10:40] * jdlrobson  runs a little test

[19:11:54] <jdlrobson>	 yup
[19:11:55] <YuviPanda>	 ah
[19:12:08] <YuviPanda>	 does it reflect as well?
[19:12:13] <jdlrobson>	 reflect?
[19:12:18] <YuviPanda>	 i.e. if I change data in .data, would the attr change?
[19:12:25] <YuviPanda>	 (debugging with a DOM tree visualization)
[19:12:58] <jdlrobson>	 no but does it matter?
[19:13:25] <jdlrobson>	 debug using javascript :)
[19:13:33] <YuviPanda>	 :) right
[19:13:38] <YuviPanda>	 jdlrobson: will change.
[19:13:46] <jdlrobson>	 i'll continue reviewing
[19:13:48] <YuviPanda>	 I guess being able to use any object is a + for data
[19:13:49] <YuviPanda>	 jdlrobson: ok
[19:17:14] <YuviPanda>	 jdlrobson: any reason for having hide *and* show buttons, instead of just one button that toggles?
[19:18:03] <jdlrobson>	 no reason
[19:18:10] <jdlrobson>	 it's just the way it was originally
[19:18:21] <jdlrobson>	 i'll be changing that myself soon i think
[19:18:24] <tfinc>	 YuviPanda: back
[19:18:32] <tfinc>	 YuviPanda: were you able to get anyone else with 4.2 to test?
[19:18:37] <YuviPanda>	 tfinc: nope :(
[19:18:42] <YuviPanda>	 jdlrobson: cool.
[19:18:46] <tfinc>	 k, i'll get back to it then
[19:20:25] <YuviPanda>	 tfinc: awesome.
[19:21:47] <YuviPanda>	 jdlrobson: also, I don't know if I can use the Reference reveal code either.
[19:21:55] <YuviPanda>	 jdlrobson: since I no longer have full html in the page
[19:22:07] <jdlrobson>	 what do you mean?
[19:22:32] <chrismcmahon>	 Amgine: if we're still discussing wiktionary issues: type "G" in search; get many possible results; scroll down the list of possible results:  upon scrolling, the "magnifying glass" icon in upper right goes white and the search results get kicked left, making the search results list not readable.
[19:22:55] <jdlrobson>	 you should be able to run MobileFrontend.references.init() after api calls
[19:23:05] <jdlrobson>	 i guess i should patch it so init takes a parent to search in
[19:23:14] <jdlrobson>	 to save you double initialising
[19:23:15] <tfinc>	 YuviPanda: entitlements problem fixed. Xcode was signing it with the wrong cert
[19:23:19] <YuviPanda>	 tfinc: cool
[19:23:31] <YuviPanda>	 jdlrobson: so, i'm now loading things into the DOM only when someone expands it
[19:23:37] <YuviPanda>	 jdlrobson: which means references won't be in the DOM by default
[19:23:43] <jdlrobson>	 oooh i see
[19:23:48] <jdlrobson>	 load references by default?
[19:23:56] <YuviPanda>	 jdlrobson: so, I could load it by default and use it, but that seems hacky to me
[19:24:10] <jdlrobson>	 mm i'll have to think of tht some more
[19:24:12] <YuviPanda>	 double the work - Load into DOM, then parse it out.
[19:24:28] <YuviPanda>	 since I have that section anyway, I *could* just parse out that section in my page parsing step and use that
[19:25:25] <YuviPanda>	 jdlrobson: also re == vs ===. I tend to use the latter only when there are potentials for issues (like checking for null). Thoughts?
[19:25:54] <jdlrobson>	 i always use the latter
[19:26:05] <jdlrobson>	 as i might make the wrong assumption
[19:26:08] <awjr>	 preilly, MaxSem, jdlrobson: changes are live on test.wikipedia.org
[19:26:31] <jdlrobson>	 im always too quick awjr  - Our servers are currently experiencing a technical problem.
[19:26:42] <awjr>	 yeah there's a php fatal
[19:26:48] <MaxSem>	 DeviceDetection.php wasn't updated
[19:26:51] <awjr>	 PHP fatal error in /home/wikipedia/common/php-1.19/extensions/MobileFrontend/MobileFrontend.body.php line 1559:
[19:26:51] <awjr>	 Call to undefined method DeviceDetection::getCssFiles()
[19:26:57] <awjr>	 !
[19:27:33] <tfinc>	 YuviPanda: test #3 passes . i'm going to do it one more time due to the weird entitlement issues
[19:27:39] <tfinc>	 but no blockers yet
[19:27:39] <YuviPanda>	 tfinc: cool
[19:27:48] <awjr>	 MaxSem then we must be missing a revision or something because what's in deployment matches what's at head of master
[19:28:02] <chrismcmahon>	 Amgine: also compare http://en.m.wiktionary.org/wiki/G#section_1 in browser vs. phone. "Other representations of G" leftmost column is squished to one character per line on phone display
[19:28:16] <MaxSem>	 awjr, this function exists in master, just checked
[19:28:24] <awjr>	 huh
[19:28:25] <awjr>	 one sec
[19:28:31] <YuviPanda>	 jdlrobson: any thoughts on when you can 'merge' the two hide/show buttons into one?
[19:28:42] <jdlrobson>	 i guess sometime next week :)
[19:28:44] <YuviPanda>	 ah
[19:28:47] <YuviPanda>	 okay
[19:28:50] <awjr>	 shit MaxSem you're right sorry i was diffing against the wrong working dir >_<
[19:28:53] <jdlrobson>	 i think the main thing holding me back is your app
[19:28:55] <jdlrobson>	 the old versions :)
[19:29:10] <jdlrobson>	 as they use 2 buttons
[19:29:17] <jdlrobson>	 ill have to make sure i keep things backwards compatible
[19:29:29] <MaxSem>	 yeah, git-->svn deployments are "special":(
[19:30:54] * tfinc  rebuilds 3.1.1

[19:30:55] <YuviPanda>	 jdlrobson: ok. 22% haven't upgraded yet.
[19:31:22] <YuviPanda>	 jdlrobson: i'm going to assume that all the section related css is in section.css
[19:31:30] <jdlrobson>	 you'd be correct
[19:31:35] <jdlrobson>	 for the beta
[19:31:52] <awjr>	 MaxSem, jdlrobson, preilly: now it's correct. please test changes on test.wikipedia.org
[19:32:20] <jdlrobson>	 (tip to test beta - http://test.wikipedia.org/wiki/Main_Page?mobileaction=beta )
[19:32:24] <jdlrobson>	 rather than opting in
[19:32:47] <awjr>	 oo
[19:32:49] <awjr>	 nice.
[19:32:51] <jdlrobson>	 disabled images doesn't seem to be working...
[19:32:52] <YuviPanda>	 jdlrobson: also, any reason why border-bottom is on .content_block rather than on the h2 or section?
[19:33:11] <jdlrobson>	 heatherw wanted that to show they are part of the same thing
[19:33:18] <jdlrobson>	 so when closed it looks like border bottom of h2
[19:33:37] <YuviPanda>	 jdlrobson: border-bottom on .section would've done the same too, no?
[19:33:52] <heatherw>	 Hi YuviPanda, jdlrobson  :)
[19:34:01] <jdlrobson>	 no.. there's a slight indent i believe so the border wouldn't have been the right length
[19:34:06] <YuviPanda>	 ah
[19:34:22] <YuviPanda>	 so now I can't set display:none to hide them but need to use what you used.
[19:35:03] <jdlrobson>	 k there is a bug awjr
[19:35:30] <jdlrobson>	 you need to use classes YuviPanda
[19:35:36] <awjr>	 jdlrobson: quick fix?
[19:35:38] <jdlrobson>	 awjr there is a request for http://test.wikipedia.org/w/extensions/MobileFrontend/stylesheets/images/blank.gif
[19:35:44] <jdlrobson>	 using w instead of wiki
[19:35:50] <jdlrobson>	 is that a LocalSettings problem?
[19:35:57] <awjr>	 jdlrobson i dont know
[19:36:29] <awjr>	 jdlrobson w should work
[19:36:31] <jdlrobson>	 it's using $wgScriptPath
[19:36:42] <awjr>	 jdrobson yeah w is the correct script path on test wiki
[19:37:04] <jdlrobson>	 w/ doesn't work though :/
[19:38:26] <jdlrobson>	 mm so somehow the blank.gif image hasn't surfaced
[19:38:37] <jdlrobson>	 http://test.wikipedia.org/w/extensions/MobileFrontend/stylesheets/images/blank.gif 404s when it should not
[19:39:03] <awjr>	 jdlrobson my fault
[19:39:06] <awjr>	 i didn't pick up the new file.
[19:39:54] <jdlrobson>	 can i check rtl on test?
[19:39:59] <awjr>	 sec
[19:40:04] <awjr>	 oh yeah you should be able to
[19:40:26] <jdlrobson>	 so enable/disable images doesn't seem to work
[19:41:04] <awjr>	 ?uselang=he should give you rtl
[19:41:10] <awjr>	 jdlrobson: the gif shoudl now be working
[19:41:20] <jdlrobson>	 yep it looks good awjr
[19:42:01] <awjr>	 jdlrobson disable images is working for me
[19:42:06] <jdlrobson>	 actually when i go into language he it also changes the extension folder to extensions-1.19
[19:42:07] <MaxSem>	 mobileaction=toggle_view_mobile required an extra F5 after going to main page to result. even on HTTPS.
[19:42:09] <jdlrobson>	 so //test.wikipedia.org/w/extensions-1.19/MobileFrontend/stylesheets/images/blank.gif 404s again
[19:42:35] <awjr>	 the behavior is a little weird on test i think because it doesnt have a separate mobile domain configure
[19:42:36] <awjr>	 d
[19:43:20] <awjr>	 jdlrobson i might need to sync-common on test one sec
[19:44:03] <awjr>	 Reedy: do you know if it's currently safe to run scap? none of the other usual suspects are around to confirm
[19:44:11] <awjr>	 jdlrobson ok try now
[19:44:27] <jdlrobson>	 good man awjr
[19:44:31] <jdlrobson>	 yeh everything looks fine to me
[19:44:36] <awjr>	 MaxSem: yeah that should not be a problem on sites with a separate mobile domain
[19:44:37] <jdlrobson>	 im just not convinced disabled images is working
[19:44:58] <jdlrobson>	 ooh saying that
[19:44:59] <awjr>	 jdlrobson it appears to be working but the behavior is whacky because of the single domain
[19:45:10] <jdlrobson>	 the footer looks messed up in rtl
[19:45:33] <tfinc>	 YuviPanda: i reran test #3. no functional issues :)
[19:45:39] <YuviPanda>	 wooo
[19:45:43] <tfinc>	 some places where i'd like to see us get faster
[19:45:46] * tfinc  goes to file bugs

[19:45:48] <jdlrobson>	 let me patch up
[19:45:51] <awjr>	 ok, next time we need to push out a fix, we should not deploy all the other changes that people have made
[19:46:02] <awjr>	 especially on a friday.
[19:46:49] <MaxSem>	 jdlrobson, speaking of RTL: RL automatically converts CSS to RTL via CssJanus if needed. do we take it into account?
[19:47:06] <jdlrobson>	 YuviPanda: code review done
[19:47:18] <YuviPanda>	 jdlrobson: awesome. Will fix.
[19:47:18] <jdlrobson>	 no MaxSem - i had no idea
[19:47:21] <jdlrobson>	 how do we invoke that
[19:47:24] <tfinc>	 YuviPanda: i need to add a new bugzilla version for 3.1.2
[19:47:30] <YuviPanda>	 tfinc: cool
[19:47:31] <tfinc>	 YuviPanda: what did you think about 3.1.1 (iOS)
[19:47:34] <tfinc>	 do you like that
[19:47:46] <YuviPanda>	 in 'versions'?
[19:47:49] <tfinc>	 or should we just do 3.1.2 sans saying ios
[19:47:50] <tfinc>	 yes
[19:47:54] <YuviPanda>	 I think that's the way to go
[19:47:56] <YuviPanda>	 we need toh ave iOS
[19:47:59] <tfinc>	 k
[19:48:03] <YuviPanda>	 iOS v6.x will be Android 3.x
[19:48:44] <tfinc>	 ok. we have it now
[19:48:53] <tfinc>	 YuviPanda: what else is blocking the release ?
[19:48:57] <YuviPanda>	 nothing
[19:49:01] <tfinc>	 i like the sound of that
[19:49:02] <tfinc>	 :D
[19:49:13] <tfinc>	 let me paste in the release notes
[19:49:16] <MaxSem>	 jdlrobson, https://www.mediawiki.org/wiki/Directionality_support https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader#CSS_parsing
[19:49:16] <tfinc>	 and prep a final build
[19:49:24] <MaxSem>	 the latter is especially useful:P
[19:49:27] <YuviPanda>	 tfinc: oh, there is one more item added to CHANGELOG. let me add that.
[19:49:35] <tfinc>	 YuviPanda: i'm sure nothing will make you happier then knowing that 3.1.1 is  gone :)
[19:50:06] <YuviPanda>	 :)
[19:51:22] <jdlrobson>	 MaxSem: ill look at that next week - its a quick fix no
[19:53:34] <gerrit-wm>	 New patchset: Jdlrobson; "update footer for rtl direction" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4912
[19:53:35] <jdlrobson>	 awjr: sent for review
[19:56:31] <awjr>	 jdlrobson the footer still looks weird for me in RTL after your fix on my local instance
[19:56:57] <tfinc>	 YuviPanda: did you want to add anything to the change log ?
[19:57:12] <YuviPanda>	 tfinc: yes, forgot about it. one liner, give me a second
[19:57:17] <tfinc>	 k
[19:57:28] <jdlrobson>	 awjr: think this is related to a bug... let me dig out
[19:57:48] <YuviPanda>	 tfinc: pushed.
[19:58:04] <jdlrobson>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=35911
[19:58:08] <YuviPanda>	 tfinc: hmm, am having issues with pushing
[19:58:10] <YuviPanda>	 here's the line
[19:58:11] <YuviPanda>	  Fixed bugs with saved pages not persisting
[19:58:15] <jdlrobson>	 so it seems setting uselang=he doesn't change dir to rtl
[19:58:17] <YuviPanda>	 let me go fix the issues with git
[19:58:22] <jdlrobson>	 (on the html tag)
[19:59:04] <awjr>	 oh i see
[19:59:11] <jdlrobson>	 i'm not sure how to fix that
[19:59:17] <jdlrobson>	 but that had me confused for a bit as well
[19:59:33] <jdlrobson>	 i find the most reliable test is to open web inspector and manually change the html dir attribute :)
[19:59:53] <wikipedia-github>	 [WikipediaMobile] yuvipanda pushed 1 new commit to v3.1.2-iOS: http://git.io/AKp91g
[19:59:53] <wikipedia-github>	 [WikipediaMobile/v3.1.2-iOS] Updated CHANGELOG - YuviPanda
[20:00:06] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #343: SUCCESS in 7.3 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/343/
[20:00:07] <mw-jenkinsbot>	 yuvipanda: Updated CHANGELOG
[20:00:10] <YuviPanda>	 tfinc: done
[20:00:38] <awjr>	 jdlrobson even after switching to use $wgLanguageCode footer looks wrong
[20:01:34] <jdlrobson>	 really?
[20:01:39] <jdlrobson>	 is the html dir attribute set?
[20:02:35] <awjr>	 jdlrobson dunno - where would i look
[20:02:36] <awjr>	 ?
[20:02:43] <jdlrobson>	 got chrome?
[20:02:54] <MaxSem>	 flipped CSS?
[20:02:56] <jdlrobson>	 open console and run $("html[dir=rtl]")
[20:03:13] <jdlrobson>	 if it outputs empty list it's not being flipped
[20:03:22] <awjr>	 jdlrobson gives me nothing
[20:03:42] <awjr>	 that was in FF
[20:03:53] <jdlrobson>	 yeh so something weird is going on
[20:03:59] <jdlrobson>	 it's not flipping the html dir attribute
[20:04:08] <tfinc_>	 YuviPanda: just edit the copy on github .. that'll go faster
[20:04:12] <tfinc_>	 and it'll unblock me
[20:04:15] <YuviPanda>	 tfinc_: i had pushed
[20:04:18] <YuviPanda>	 a few mintues ago?
[20:04:20] <awjr>	 ok i dont feel good about this deployment
[20:04:35] <jdlrobson>	 awjr: ahh so dir is determined by $wgContLang
[20:04:36] <awjr>	 preilly any objections to just pushing out the view toggling fix and saving everything else for next week?
[20:04:36] <tfinc_>	 ahh i see it
[20:04:37] <jdlrobson>	 what value is that?
[20:04:37] <YuviPanda>	 tfinc_: you missed that with liefi
[20:05:24] <tfinc_>	 YuviPanda: i'm prepping the release build
[20:05:30] <YuviPanda>	 ok
[20:05:43] <awjr>	 jdlrobson try $wgLanguageCode='he' in local settings
[20:07:15] <preilly>	 awjr: why?
[20:07:51] <awjr>	 preilly because we're still uncovering bugs in new stuff to deploy and it's friday
[20:08:09] <preilly>	 awjr: ok
[20:08:11] <awjr>	 and im supposed to be doing 20% stuff now
[20:08:32] <preilly>	 awjr: well, this is 20% stuff
[20:08:41] <awjr>	 preilly no, this is what i normally do...
[20:08:42] <preilly>	 awjr: your testing the new deployment method ;)
[20:08:49] <awjr>	 hahaha
[20:08:53] <preilly>	 awjr: ha ha I was right
[20:08:59] <awjr>	 lulz
[20:09:08] <MaxSem>	 awjr, you can just scap and declare site emergency, mwahaha
[20:09:33] <awjr>	 as entertaining as that sounds, i'd like to be not staring at my computer this friday evening :)
[20:10:04] <MaxSem>	 what? don't you be tellin' me that you have a life
[20:11:17] <awjr>	 lol even if i didn't have a life i wouldn't want to be staring at my computer screen this friday evening :
[20:11:19] <awjr>	 :p
[20:11:22] <jdlrobson>	 ok yeh awjr
[20:11:24] <jdlrobson>	 i messed up
[20:12:58] <jdlrobson>	 so i think ResourceLoader is doing magic
[20:13:40] <tfinc_>	 YuviPanda: the app has been validated. were ready to submit it
[20:13:41] <MaxSem>	 jdlrobson, CssJanus
[20:13:46] <YuviPanda>	 *w're
[20:13:48] <YuviPanda>	 err
[20:13:49] <tfinc>	 yes
[20:13:49] <YuviPanda>	 *we're
[20:13:55] <YuviPanda>	 tfinc: cool :)
[20:14:17] <jdlrobson>	 yep MaxSem i didnt realise you didnt have to opt in :)
[20:14:32] <awjr>	 ok jdlrobson, MaxSem, preilly: im going to back out the changes from the deployment branch and *just* push changes to fix bug 35940
[20:14:45] <MaxSem>	 no objections
[20:14:51] <tfinc>	 YuviPanda: do you have any other changes before i submit ?
[20:14:55] <YuviPanda>	 tfinc: nope
[20:14:58] <MaxSem>	 when will be our next window?
[20:15:13] * tfinc  hits send and breathes a bit more 

[20:15:55] <tfinc>	 YuviPanda: 3.1.2 has been submitted
[20:15:56] <tfinc>	 :D
[20:16:16] <jdlrobson>	 Css janus is actually doing some annoying things
[20:16:18] <awjr>	 MaxSem good question. we had originally been doing mondays, which i liked, but i think there *might* be some kind of conflict with the platform team doing regular core upgrades on mondays but i'm not sure… preilly do you know?
[20:16:22] <YuviPanda>	 tfinc: awesome!
[20:16:38] <tfinc>	 YuviPanda: now i'm going to see if apple can fast track it. they may tell us to screw off since they did it for us last time
[20:16:41] <YuviPanda>	 tfinc: i'm making good progress in api-move, should hit master in a few days.
[20:16:42] <YuviPanda>	 yeah
[20:17:34] <tfinc>	 preilly: were you the one who found the fast track to approval page ?
[20:17:47] <tfinc>	 found it https://developer.apple.com/appstore/contact/appreviewteam/index.html
[20:21:25] <gerrit-wm>	 New patchset: Jdlrobson; "fixup css for rtl for header" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4914
[20:21:26] <gerrit-wm>	 New patchset: Jdlrobson; "update footer for rtl direction" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4912
[20:21:30] <jdlrobson>	 k done
[20:21:43] <tfinc>	 YuviPanda: expedited request sent
[20:21:59] <YuviPanda>	 jdlrobson: what do you think needs to be done before api-move can be merged in to master?
[20:22:08] <tfinc>	 YuviPanda: did you send out a tweet ?
[20:22:13] <YuviPanda>	 tfinc: let me do tha
[20:22:15] <tfinc>	 s/did/can
[20:22:24] <jdlrobson>	 it looked good to me YuviPanda apart from my comments
[20:22:51] <YuviPanda>	 jdlrobson: okay. I need to figure out how to do saved pages though.
[20:38:19] <awjr>	 maplebed: would you mind flushing the mobile varnish cache?
[20:39:25] <philinje>	 brion: h, u there?
[20:39:28] <philinje>	 hi
[20:39:33] <brion>	 yo philinje
[20:39:47] <preilly>	 Ryan_Lane1: I know that you're busy, but when you get a chance can you take a look at: https://gerrit.wikimedia.org/r/#patch,sidebyside,4916,2,templates/varnish/mobile-frontend.inc.vcl.erb
[20:40:03] <philinje>	 need a little help understanding user rights for commons
[20:40:31] <brion>	 ?
[20:41:28] <philinje>	 for example, my staff account doesn't work on commons - only my wikipedia user account
[20:41:41] <brion>	 doesn't work how?
[20:41:57] <philinje>	 doesn't exist
[20:42:09] <brion>	 does it exist on any other wikis?
[20:42:26] <philinje>	 on all wikis my staff account is fine, expect wikipedia and commons
[20:43:03] <brion>	 what happens when you log in?
[20:43:10] <brion>	 any error messages?
[20:43:32] <philinje>	 no. on commons i login with my WP account and it's fine, but no admin privileges
[20:43:47] <brion>	 ok, so your account on commons works fine
[20:43:52] <brion>	 but you don't have admin privileges there?
[20:44:20] <philinje>	 correct
[20:44:30] <brion>	 so you want to get admin privileges?
[20:44:49] <philinje>	 yes, or to get my staff account working across all wikis (WP and commons)
[20:44:50] <brion>	 i assume there's a standard process
[20:44:58] <brion>	 ok, what's wrong with your staff account?
[20:45:21] <brion>	 does it work on en.wikipedia.org, meta.wikimedia.org, etc?
[20:45:52] <philinje>	 no, yes, for some reason it is not recognized on wikipedia and commons
[20:46:14] <brion>	 is that an actual global account, or your office.wikimedia.org account (which is not connected to anything else)?
[20:46:58] <brion>	 is there any wiki that it does work on?
[20:47:20] <philinje>	 all of our wikis - meta, office, mw
[20:47:50] <brion>	 philinje: what's the username?
[20:47:55] <philinje>	 pchang
[20:48:01] <brion>	 what happens wjen you log in and it's "not recognized"? any error messages?
[20:48:09] <philinje>	 hang on
[20:48:43] <philinje>	 No user by the name Pchang
[20:49:05] <brion>	 where?
[20:49:13] <philinje>	 commons
[20:49:19] <philinje>	 or wp
[20:49:19] <brion>	 ok
[20:49:30] <brion>	 on en.wikipedia.org there's a pchang account created in 2006: http://en.wikipedia.org/w/index.php?title=Special:ListUsers&limit=1&username=Pchang
[20:49:35] <awjr>	 preilly: in order to finish that bug fix we need to flush the mobile varnish cache but opsen are telling me it's pretty risky to do so on account of the mysterious memleaks
[20:49:56] <philinje>	 i am looking on meta looking at my prefs, global account status is not using unified account
[20:50:16] <brion>	 there doesn't appear to be a pchang account on commons
[20:50:18] <philinje>	 so maybe there was an attempt to create a unified account but it got blocked on wp and commons
[20:50:28] <philinje>	 oh really
[20:50:30] <brion>	 so you may need to unify it
[20:50:41] <awjr>	 preilly i think it's probably ok to wait to flush the cache as that bug is a bit of an edge case (Since you'd ahve to type in 'en.m.wikipedia.org' and then immediately toggle to desktop view to make it happen)
[20:50:50] <preilly>	 awjr: that's bits not mobile
[20:50:50] <philinje>	 but that won't work for wp
[20:51:04] <awjr>	 preilly i know but they're still hesitant
[20:51:12] <brion>	 philinje: on meta, try doing the unify thing. if you can't get through en.wikipedia see if you can do the rest
[20:51:22] <brion>	 in which case you should be able to log in on commons afterwards
[20:51:49] <preilly>	 awjr: I'll push them to do it
[20:51:54] <philinje>	 would i then have admin privileges?
[20:51:59] <awjr>	 preilly alright
[20:52:31] <brion>	 philinje: not until somebody gave you privleges
[20:52:32] <preilly>	 awjr: Ryan_Lane1 is doing it right now
[20:52:43] <preilly>	 awjr: we owe him something
[20:52:44] <brion>	 but since you don't exist, right now nobody can give them to you
[20:52:45] <philinje>	 ok, so who can do that?
[20:52:52] <MaxSem>	 philinje, contact Philippe for staff flag
[20:52:57] <awjr>	 preilly otphj?
[20:53:20] <philinje>	 thanks Brion - sorry to drag you into this
[20:53:26] <philinje>	 thanks Max
[20:53:28] <preilly>	 awjr: ha ha ha ha ha
[20:53:33] <brion>	 :)
[20:54:05] * preilly  — http://www.urbandictionary.com/define.php?term=OTPHJ

[20:56:05] <awjr>	 preilly: ok bug looks resolved in production
[20:56:09] <awjr>	 im going to go get some lunch
[20:56:12] <awjr>	 bbia
[20:56:13] <awjr>	 b
[20:56:16] <preilly>	 awjr: enjoy your food
[20:58:06] <MaxSem>	 mmm, now I have desktop site stubbornly serving me mobile yummies;)
[21:11:38] <pfhayes>	 YuviPanda: right now the error.html and 404.html pages don't give very clear error messages. notably, they don't repeat the name of the page the user was searching for, so they don't know if they misspelt the page or not. i was going to put in a fix for this in WIktionaryMobile - does WikipediaMobile want this change as well?
[21:11:50] <YuviPanda>	 yes!
[21:11:58] <pfhayes>	 okay :_
[21:11:59] <pfhayes>	 :)
[21:18:26] <preilly>	 jdlrobson: 'title' => self::$title,
[21:18:53] <preilly>	 jdlrobson: shouldn't that be a page title in line 959 of MobileFrontend.body.php
[21:19:23] <preilly>	 jdlrobson: like $wgOut->getPageTitle();
[21:19:33] <jdlrobson>	 that also gives the wiki name though no?
[21:20:09] <jdlrobson>	 e.g. Sideshow Bob - Wikipedia, the free encyclopedia
[21:20:29] <preilly>	 jdlrobson: nope
[21:20:46] <preilly>	 var_dump($out->getPageTitle()); === string(24) "Zero Rated Mobile Access"
[21:21:16] <jdlrobson>	 it probably should then :)
[21:21:23] <jdlrobson>	 my bad
[21:22:06] <preilly>	 jdlrobson: no worries
[21:22:37] <preilly>	 jdlrobson: I just wanted to be able to $out->setPageTitle( null ); on some pages to clear the title
[21:22:44] <preilly>	 jdlrobson: that is how I noticed the issue
[21:22:52] <jdlrobson>	 cool glad you found it
[21:23:01] <jdlrobson>	 my php code is always suspect ;-)
[21:23:21] <philinje>	 preilly: how is the beta site shown - do we set a cookie?
[21:23:38] <jdlrobson>	 you can use mobileaction=beta philinje on the end of your url
[21:24:08] <philinje>	 so it is by URL always, or is that an option to see the beta site?
[21:24:45] <jdlrobson>	 do you want to turn it on permanently? or just temporarily?
[21:24:50] <jdlrobson>	 (for a given a page)
[21:25:07] <jdlrobson>	 its by cookie if you want it permanently
[21:25:25] <philinje>	 i want to know how to track that view in our log files
[21:25:35] <philinje>	 for data analysis
[21:26:08] <jdlrobson>	 ah i don't know about that - i guess you could look at how often references.js is accessed
[21:26:21] <philinje>	 so it sounds like we can do it by URL, which allows us to track it
[21:26:46] <philinje>	 references.js - interesting
[21:26:57] <jdlrobson>	 no... you would have to choose a resource that is only enabled on beta e.g. reference.js
[21:27:10] <jdlrobson>	 unless someone can think of something more clever
[21:27:19] <jdlrobson>	 you could obviously see how many visits there are to opt in to the beta as well
[21:27:27] <jdlrobson>	 but that won't give you an idea if people are actually using it
[21:28:40] <philinje>	 would reference.js be accessed once per page view?
[21:31:10] <MaxSem>	 philinje, worse - once in a while due to caching
[21:31:35] <MaxSem>	 philinje, do you want to know the number of page views or people with beta?
[21:32:26] <philinje>	 yes
[21:32:53] <MaxSem>	 that's a Vorlon answer ;)
[21:32:53] <philinje>	 also other things, like number of search requests on the beta vs normal mobile site, for example
[21:34:25] <MaxSem>	 philinje, the latter one is easily doable, as it involves no caching
[21:34:28] <philinje>	 sorry, is Vorlon Star Trek lingo?
[21:34:36] <MaxSem>	 Babylon 5
[21:34:58] <MaxSem>	 I asked you whether you want this or that, you answered yes
[21:35:12] <philinje>	 MaxSem: sorry about that, was thinking ahead
[21:35:29] <philinje>	 we want to do an A/B test based on the design of the search bar
[21:36:00] <philinje>	 this will likely involve a larger infrastructure change but i was talking with Andre about the data tracking part
[21:42:33] <tfinc>	 YuviPanda: i'm surprised that the tail of Android version 4 still has 23%
[21:42:43] <YuviPanda>	 tfinc: yeah, I guess some people don't upgrade at all?
[21:42:44] <tfinc>	 its taking us a while to get the tail taken care of
[21:43:18] <tfinc>	 perhaps
[21:43:29] <tfinc>	 i need to talk to some app authors
[21:43:35] <tfinc>	 to find out if thats typical
[21:45:10] <YuviPanda>	 tfinc: ok
[21:45:33] <tfinc>	 but our stats show that you either upgrade right away … or don't bother
[21:48:14] <YuviPanda>	 yeah, that sounds like people ignoring 'update' notifications from market
[21:54:22] <tfinc>	 YuviPanda: check out the bump of active installs after we pushed out 1.1.1
[21:54:40] <YuviPanda>	 yeah, it seemed to bump up and then sortof 'stabilize'
[21:54:47] <tfinc>	 err
[21:54:53] <tfinc>	 i mean android 2.3.3 users
[21:55:01] <YuviPanda>	 ugh, i wasn't looking at that
[21:55:03] * YuviPanda  goes back to console

[21:55:09] <tfinc>	 Active device installs by Android Version
[21:55:33] <tfinc>	 1.1.1 gave us 300,000 more 2.3.3 users
[21:56:14] <tfinc>	 that explains where we've seen our growth  on total installs
[21:56:20] <YuviPanda>	 tfinc: yeah, I see quite a big bump
[21:56:35] <tfinc>	 were seeing the exact same bump on 4.x but the scale is so much smaller
[21:56:40] <YuviPanda>	 i'm not sure why thta happened? 2.2 was constant
[21:57:07] <tfinc>	 there are very few 2.2 device coming out on the market
[21:57:44] <YuviPanda>	 true, I'm wondering if there was a proportional bump in 4.x as well
[21:57:58] <tfinc>	 tfinc: were seeing the exact same bump on 4.x but the scale is so much smaller 2:56
[21:58:12] <YuviPanda>	 yeah
[22:10:03] <YuviPanda>	 hmm, I wonder if there's a event that is triggered on DOM ready..
[22:10:17] <gerrit-wm>	 New patchset: MaxSem; "Factored language URLs builder into a separate function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4925
[22:21:47] <YuviPanda>	 tfinc: you should be able to try out the api-move version on my repo if you want to. 4.x fixes have been merged in.
[22:22:03] <YuviPanda>	 jon's given me some CR comments and once I fix those, this will be merged to master
[22:22:08] <YuviPanda>	 i'll fix those before going to sleep today
[22:22:26] <YuviPanda>	 tfinc: when do you want to talk about 3.2/1.2?
[22:25:59] <mw-jenkinsbot>	 Project WiktionaryMobile - Nightly builds build #74: SUCCESS in 6.8 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/74/
[22:25:59] <mw-jenkinsbot>	 pfhayes: Trying to get starting words working on 4.0
[22:26:45] <philinje>	 tfinc: u there?
[22:30:31] <awjr>	 preilly, MaxSem: i just created a remote branch under MobileFrontend to do some testing around the command line gerrit stuff i've been working on - there should be nothing of value in the branch, just test commits etc. so if you see anything about 'dippy-bird-sandbox' in gerrit, ignore it for now.
[22:30:59] <MaxSem>	 awjr, there's a test repo
[22:31:16] <awjr>	 well hsit
[22:31:22] <awjr>	 MaxSem what is it?
[22:32:08] <MaxSem>	 awjr, test/mediawiki
[22:32:23] <awjr>	 :D
[22:32:25] <awjr>	 thanks MaxSem
[22:33:36] <MaxSem>	 awjr, or test/mediawiki/extensions/examples
[22:35:34] <awjr>	 awesome
[22:35:43] <awjr>	 i deleted the remote branch i made in MobileFrontend
[23:00:45] <preilly>	 MaxSem: why did you get rid of getRelativeURL?
[23:00:45] <MaxSem>	 preilly, because its only usage was feeding it already relative urls
[23:00:45] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4925
[23:00:45] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4925
[23:02:05] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4912
[23:02:05] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4912
[23:02:05] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4914
[23:02:05] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4914
[23:09:37] <preilly>	 MaxSem: can you take a look at https://gerrit.wikimedia.org/r/4939
[23:10:47] <MaxSem>	 preilly, +1'd
[23:11:36] <preilly>	 awjr: can you approve https://gerrit.wikimedia.org/r/#change,4939
[23:14:00] <preilly>	 awjr: thanks!
[23:14:04] <awjr>	 preilly np
[23:17:38] <preilly>	 binasher: you around?
[23:17:57] <binasher>	 yo
[23:18:15] <preilly>	 binasher: can you look at https://gerrit.wikimedia.org/r/#change,4916
[23:23:10] <binasher>	 hrm
[23:23:45] <binasher>	 i wish gerrit let you see the entire changed file without downloading a zip
[23:27:44] <binasher>	 preilly: 1) tag_carrier is only called if reg.host ~ zero so none of that will work, 2) does Special:ZeroRatedMobileAccess expect to get options following it with a / ?
[23:34:55] <preilly>	 binasher: hmm
[23:36:28] <preilly>	 binasher: 2) I don't know what you mean?
[23:36:39] <preilly>	 binasher: 2) do you mean query string parameters?
[23:36:56] <binasher>	 i closed it, but see the comment on the gerrit change
[23:37:43] <binasher>	 the string append won't translate into query paramaters
[23:40:15] <preilly>	 binasher: can I just remove the string append
[23:40:59] <binasher>	 and just redirect to Special::ZeroRatedMobileAccess ?
[23:41:41] <preilly>	 binasher: yeah
[23:42:29] <preilly>	 binasher: can you look at https://gerrit.wikimedia.org/r/#change,4916 patch set 4
[23:43:26] <preilly>	 binasher: I mean patch set 5
[23:45:05] <YuviPanda>	 tfinc: https://github.com/wikimedia/WikipediaMobile/pull/208 :)
[23:45:34] <binasher>	 5 still has a prob - if m, tag_carrier is called before the req.http.host rewrite, if zero it's called after (but you check for req.http.host ~ zero in tag_carrer)
[23:49:49] <preilly>	 binasher: what is the fix?
[23:50:18] <preilly>	 binasher: I want to call it before right?
[23:51:13] <binasher>	 since you're calling it regardless now, remove both calls and put one unconditionally at the top of vcl_recb
[23:51:47] <tfinc>	 YuviPanda: how are you still awake ?
[23:52:09] <tfinc>	 YuviPanda: GO TO SLEEP
[23:52:10] <tfinc>	 hehe
[23:52:13] <YuviPanda>	 tfinc: not really sure :)
[23:52:19] <tfinc>	 seriously .. when was the last time you slept
[23:52:28] <tfinc>	 i bet *you* don't even remember
[23:52:34] <Ryan_Lane>	 stay awake. sleeping is for suckers!
[23:52:41] <YuviPanda>	 I think I slept for about 4-5 hours on friday evening IST
[23:52:44] <preilly>	 binasher: can you look at https://gerrit.wikimedia.org/r/#change,4916 patch set 7
[23:52:48] <YuviPanda>	 Ryan_Lane++
[23:53:07] <preilly>	 Ryan_Lane++
[23:53:11] <preilly>	 YuviPanda--
[23:53:31] <YuviPanda>	 so that's ++ Ryan_Lane and a -- for me ++ing Ryan_Lane
[23:53:35] <tfinc>	 -2
[23:53:56] <preilly>	 tfinc: is karma neutral
[23:54:47] <preilly>	 Ryan_Lane: ssh -A bastion.wmflabs.org
[23:54:48] <preilly>	 If you are having access problems, please see: https://labsconsole.wikimedia.org/wiki/Access#Accessing_public_and_private_instances
[23:54:48] <preilly>	 Connection closed by 208.80.153.194
[23:54:51] <binasher>	 preilly: lucky number 7
[23:54:59] * YuviPanda  throws http://i.imgur.com/0WIqX.gif at tfinc 

[23:55:05] <YuviPanda>	 no longer karma neutral
[23:55:20] * tfinc  responds with http://cats.io/

[23:55:30] <tfinc>	 checkmate
[23:55:42] <preilly>	 Ryan_Lane: do you like that show archer?
[23:55:43] <ArcherBot>	 : Lana. Lana. Lana? LANA! Danger zone.
[23:56:11] <preilly>	 Ryan_Lane: do you know a guy named sterling archer?
[23:56:11] <ArcherBot>	 : Lying is like 95% of what I do.
[23:56:19] * YuviPanda  gets tfinc to click aww.reddit.com

[23:56:29] <tfinc>	 i wonder when we'll get new episodes of archer
[23:56:29] <ArcherBot>	 : Can I offer you a drink? How about this expensive prostitute?
[23:57:04] <preilly>	 oh, silly archer bot
[23:57:05] <ArcherBot>	 : Malory: It's okay! They're just blanks.Lana: Well, see, you say that ...Malory: But they were blanks—weren't they?Sterling: Only if the back of his skull picked that exact moment to explode outwards
[23:58:18] <tfinc>	 YuviPanda: i like cat.io better. its more obnoxious
[23:58:51] <preilly>	 Ryan_Lane: archer is a great show
[23:58:51] <ArcherBot>	 : Hey, we're out there risking our lives every—many of the days!
[23:59:07] <tfinc>	 YuviPanda: awesome to see the pull request come in
[23:59:17] <tfinc>	 thats a beefy review
[23:59:42] <YuviPanda>	 tfinc: those were all inline comments that he gave me which have been resolved
[23:59:50] <YuviPanda>	 tfinc: also, http://reddpics.com/r/aww > cats.io