[10:07:00] New review: Reedy; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4971 [10:07:03] Change merged: Reedy; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4971 [12:02:08] New review: MaxSem; "Did someone just say SVN? :P" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4971 [12:02:41] New review: Reedy; "Hater!" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/4971 [12:24:51] Arrrgh [12:25:00] * YuviPanda pokes heatherw about https://bugzilla.wikimedia.org/show_bug.cgi?id=36008 [12:25:02] My laptop has defaulted to using hte mobile site [12:25:15] YuviPanda: wait 4 or 5 hours :p [12:25:20] sticky cookies being too sticky [12:25:28] Reedy: ah, timezones. [12:25:44] Dammit [12:25:53] How do I disable using the mobile site? [12:26:05] why couldn't the earth have been flat, resting on one layer of regex after the other? [12:26:10] Reedy: iirc you'll need to unset a cookie [12:26:19] There is/was a page to do it at one point [12:26:48] Reedy: http://en.wikipedia.org/w/index.php?title=Main_Page&mobileaction=toggle_view_desktop [12:26:48] ? [12:27:00] Yay [12:27:01] Thanks [12:27:03] $wgMobileResourceVersion; [12:27:05] * Reedy sighs [12:27:07] :) [12:27:38] At least set a damn value [12:28:08] Reedy: poke preilly and awjr 4 hours from now, I guess? :) [12:28:26] IIRC the entire cookie / mobile domain / varnish setup is a bit… fragile [12:28:45] The usage of it seems we could set that to '' [12:30:31] $cookieDuration = ( abs( intval( $wgMobileFrontendFormatCookieExpiry ) ) > 0 ) ? [12:30:32] $wgMobileFrontendFormatCookieExpiry : $wgCookieExpiration; [12:32:45] New patchset: Reedy; "Explicitly set default values for globals" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5006 [12:35:05] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/5006 [12:35:34] New patchset: Reedy; "Set $subdomainTokenReplacement to a value before passing it in a hook" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5007 [12:37:29] * MaxSem notes that Reedy's using PhpStorm today [12:37:48] I use it most days [12:37:55] 'mobile-frontend-leave-feedback-title' => 'Give us feedback about your mobile site experience', [12:38:02] 'mobile-frontend-leave-feedback-title' => 'Mobile site feedback', [12:38:07] Which one do we think is right? [12:38:46] There's 2 of 'mobile-frontend-featured-article' => 'Today\'s Featured Article', [12:40:25] New patchset: Reedy; "Remove duplicate mobile-frontend-featured-article as message is the same" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5008 [12:41:58] 'mobile-frontend-leave-feedback' => 'Mobile site feedback', [12:41:58] 'mobile-frontend-leave-feedback-title' => 'Mobile site feedback', [12:44:38] New patchset: MaxSem; "Fixed two messages with the same key" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5009 [12:45:23] New review: Reedy; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5009 [12:45:26] Change merged: Reedy; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5009 [12:46:17] Reedy, the latter is OK since they're used in different contexts and thus may be different in other languages [12:47:13] Yeah [12:49:04] New patchset: Reedy; "Bump to jquery-1.7.2 (yay, bugfixes)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5011 [12:49:44] $copyright = $copyright; [12:49:46] lol [12:50:34] Reedy, you're not gonna laugh when we merge it with core [12:50:37] Reedy: copyright assignment? :D [12:50:42] HAHAHA [12:51:22] $wgExtMobileFrontend::$minifyJS [12:52:20] btw YuviPanda, I thought about making prop=images return only existing images, but it would be inefficient with remote repos [12:52:44] MaxSem: i'm thinking that I should just regex it out. [12:52:47] so DOM tree parse looks like the method [12:52:54] global $wgReqeust, [12:52:59] and then i'll have two problems. [12:53:21] \d problems? acutually. [12:53:44] MaxSem: also, is there an API that is like mobileview (gives you sections), but doesn't pass things through the mobile formatter? [12:53:51] well, good that not \d+ [12:54:18] mmm, no [12:54:34] New patchset: Reedy; "Remove unused (and typoed) globals" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5012 [12:54:36] because I was wondering if we should skip the mobile formatting on tablet devices [12:54:47] since it looks way too sparse and the full desktop view suits them just fine [12:54:52] MaxSem: thoughts on that? [12:55:09] needs broader discussion [12:55:14] indeed. [12:55:27] for example with Brion the tabletter;) [12:55:41] it just popped in a few days ago from someone's feedback about the app. [12:58:52] srsly, after playing with our app I ditched it in favor of plain ol' browser [13:04:10] MaxSem: yeah, I understand. [13:04:16] jdlrobson: heya [13:04:22] hey YuviPanda [13:04:38] jdlrobson: you've a pull req with 65+ commits :) [13:04:46] i've seen [13:04:48] jdlrobson: i responded to your comments about makefile [13:04:49] i made a few comments [13:05:00] i've discovered a problem as well :( [13:05:04] oh? [13:05:06] safari [13:05:07] ? [13:05:22] references are broken [13:05:33] open file:///git/wikimedia/MasterWikipediaMobile/assets/www/index.html [13:05:41] jdlrobson: I know. [13:05:47] jdlrobson: we discussed this, no? [13:05:54] no it's slightly different [13:05:56] jdlrobson: saved pages are also broken. [13:06:03] as they don't even jump to the relevant reference [13:06:11] jdlrobson: yes, because they haven't been loaded into the DOM yet [13:06:19] in the mobile site - if you open a hash link that is hidden under a section it opens the related section [13:06:36] is there any way the api can report which hash links are present in a given section? [13:06:52] e.g. look at ids in the section and provide them in the response [13:07:04] from what we discussed, the opinion was to just parse out the references section on first load [13:07:17] but there are other problems [13:07:30] sometimes Section A might link to #Section C.2 [13:07:35] which is hidden in section c [13:08:33] jdlrobson: hmm, that's a solveable problem too [13:08:47] jdlrobson: because we know the section IDs beforehand, it's easy to keep a list and expand/jump to that [13:09:10] not quite - let me see if i can find an example [13:10:13] the problem basically lies in that i can write [[#myuniqueid]] in wikitext [13:10:28] So I could introduce a div with id myuniqueid in a section within a section etc.. [13:10:29] do people do that? [13:10:47] i've encountered it somewhere so it does exist (but can't point at anything right now) :) [13:10:49] other than for section headers... [13:11:22] i guess the main example is references - essentially i'm pointing to an id within the references section not the references section itself [13:11:38] so we'd need to parse out IDs from the references section and keep them handy [13:11:51] i'm currently working on a 'fastclick' implementation [13:11:59] next was saved pages, and after that references/hashlinks [13:12:28] yep i was just wondering if those ids could be parsed out on your behalf in the api for a more generic solution [13:13:02] e.g. { line: "section 4", contains: ['foo', 'citenote-3'], toclevel: 2 } [13:13:11] MaxSem: ^ [13:13:27] where contains is a list of all the ids in that section - it might be unrealistic but it would be cool to not have to get the references until you need them [13:14:56] well, I already return which sections have references [13:15:07] as in [13:16:13] MaxSem: i just noticed that. Also seems to be sometimes wrong? [13:16:27] MaxSem: for example, in [[Mumbai]], the Notes section had references: "" [13:16:32] rather than the References section [13:17:42] YuviPanda, look at the page [13:18:27] Look at the page, YuviPanda [13:18:46] notes is what you need while references is just a bullet list [13:20:56] ugh. [13:20:57] ok [13:21:37] MaxSem: it seems inconsistent, I see 'Notes' in some, 'Notes and References' in others and 'References' in some others, being used for the same thing [13:21:49] Sounds about right [13:26:46] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/5012 [13:27:36] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/5008 [13:28:21] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/5007 [13:29:34] Reedy, can you merge your changes I've reviewed to avoid conflicts during refactoring I'm going to continue? [13:29:47] sure [13:30:15] New review: Reedy; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5012 [13:30:17] Change merged: Reedy; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5012 [13:30:23] New review: Reedy; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5008 [13:30:26] Change merged: Reedy; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5008 [13:30:31] New review: Reedy; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5007 [13:30:34] Change merged: Reedy; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5007 [13:30:48] New review: Reedy; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5006 [13:30:51] Change merged: Reedy; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5006 [13:30:58] jdlrobson: i'm using http://cubiq.org/remove-onclick-delay-on-webkit-for-iphone as the fastclick implementation [13:31:15] thanks, Reedy [13:31:16] Done, everything but jquery [13:34:04] jdlrobson: I was hoping you could merge api-move in so that further fixes (references, saved pages, fastclick) can come in as smaller pull requests [13:34:17] NoClick YuviPanda: code wise looks fine - what license is it though? [13:34:27] i can merge api-move yes [13:34:37] i was just looking into refactoring toggling like you suggested to use one button [13:34:37] jdlrobson: MIT [13:34:41] and then i was gonna look into tit [13:34:44] jdlrobson: mentioned in the sidebar [13:34:57] ahh yeh [13:39:19] jdlrobson: i'm also going to replace doFocusHack with that implementation [13:39:25] * jdlrobson nods [13:39:45] I'm guessing whoever originally wrote doFocusHack had something like that in mind, but couldn't actually do it properly [13:39:46] * YuviPanda sighs [13:40:07] jdlrobson: anything you'd want me to change in api-move before merge? [13:42:53] i'm not sure yet - i need to build it and have a play some more. the main thing was the missing remotes and common.css [13:43:06] jdlrobson: as I mentioned, the makefile is no longer needed [13:43:19] jdlrobson: git submodule update --init should get you the entire MobileFrontend repo [13:43:20] sure - but there are still remotes no? e.g. images [13:43:27] ah ok [13:43:30] what about common.css ? [13:43:35] as in the MediaWiki:Common.css [13:43:42] yeah, so that's something i'd need to figure out [13:44:01] jdlrobson: i'm thinking of dynamically pulling that in, because IIRC it can dynamically change in every wiki [13:44:13] (I'm assuming we're talkinga bout [[MediaWiki:Common.css]]) [13:44:19] yep [13:44:20] sorry [13:44:29] ok that makes sense [13:46:14] hacks.css - was there a reason we don't include that? [13:46:36] jdlrobson: because it broke iScroll? [13:46:49] I remember replying to this on github... [13:46:51] i thought that was just the wildcard selectors? [13:47:01] eg. [style*= [13:47:20] ough, for some reason I thought that hacks.css was separation of the wildcard selectors [13:47:24] sorry, will include them. [13:48:24] no i removed them altogether [13:51:32] jdlrobson & YuviPanda, do you need
to wrap firstHeading? [13:52:09] context MaxSem? [13:52:33] previously it did, after the recent changes (yours?) it doesn't [13:52:46] I'm touching this part anyway so... [13:53:00]

History of China

should be inside content_wrapper [13:53:04] it does on my local version.. [13:53:48] id=content, not content_wrapper [13:54:15] we possibly don't even need content.. [13:54:47] old apps do [13:55:51] well i'd rather have just content or just content_wrapper personally [13:56:22] happy to put firstHeading in #content for the time being if that is needed for older apps [13:59:56] MaxSem: jdlrobson we'd need it for current versions of the app [13:59:59] they check for #content [14:00:02] not #content_wrapper [14:00:33] could we not throw away content_wrapper than and just have content/ [14:14:21] sorry YuviPanda got side tracked by some new bugs [14:14:47] I might have broken my ebow. Checking it out [14:14:53] *elbow [14:15:04] Can you lick it? [14:15:50] nope. any position other than straight down kills tho [14:17:04] :/ [14:35:50] ok pinched nerve [14:35:57] giving it a rest brb [14:36:04] :( [14:39:58] YuviPanda: any more pulls to push? Several issues: 1) I'm still seeing the problem with not special casing the main page in the app 2) in android when i click a link it doesnt' scroll to the top any more 3) no article titles shown at top of page (note this is also a bug on the deployed mobile site) 4) toggling on current article breaks when I go to the nearby view and click back [14:40:57] actually.. the last section can be toggled - just not the ones before it [15:05:08] okay, a bit better. [15:05:23] jdlrobson: so, api does nothing special for main page. we need to figure out what to do [15:05:35] will look into 2 [15:05:53] 3 is just me forgetting to put the h1 in the title :) [15:06:57] well on MFE currently we only show things which have an id beginning with the prefix mp- [15:07:50] actually i think it is more complicated then that [15:08:06] ? [15:08:09] on main page? [15:08:34] yeh [15:09:06] it's special cased and not very elegantly https://bugzilla.wikimedia.org/show_bug.cgi?id=30405 [15:12:09] having a close look at current situation. It's not too bad apart from the summary [15:14:31] jdlrobson: so, last time I talked with tfinc the idea was to load the app with a blank page till we figure out what to do about main page [15:15:59] that could also work YuviPanda [15:16:04] or maybe show saved pages? [15:16:08] no. [15:16:21] no to showing saved pages? [15:16:36] i'm not sure how that'd be useful. I was thinking either 1. API for main page or 2. Something with featured feeds? [15:16:46] i'm not sure how saved pages would be useful. [15:17:33] infact personally, I think offline saving/reading should be handled by an app dedicated to that (Instapaper/RIL). To convince tfinc I need to show numbers, so there's been click tracking code added to the app that lets us count number of pages being saved [15:18:05] but still, blanking it out is a temperoary 'solution' - I don't think we will ship with that :) [15:18:21] well we show the last viewed page currently yes? [15:18:27] or is that only for the time being? [15:18:47] if we do that id suggest the homepage could just be some instructions or just the article of the day section [15:19:09] +1 [15:20:27] actually instructions might make more sense for the app [15:21:20] Welcome to your new Wikipedia Mobile app! You now have Wikipedia at your finger tips! Search for the article you are interested in using the search box above or find articles near you by using nearby (something along those lines) [15:22:42] YuviPanda: what?is that my bug? did you poke me about it at 6am? [15:23:11] jdlrobson: +1 again. [15:23:13] let me file a bug [15:23:26] heatherw: heya! Apologies about the timing. [15:23:31] hey heatherw ! [15:23:34] just filed it, looking for an icon that says 'no network connection' [15:23:41] hi j!dlrobson [15:23:45] oops [15:23:50] jdlrobson: hi! [15:25:46] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=36017 [15:26:10] when you get a moment heatherw - feel free to critique http://mobile-geo.wmflabs.org/w/index.php/San_Francisco and tell me which pixels are wrong [15:27:12] YuviPanda: commented [15:27:16] jdlrobson: weirdly, the footer lines up when it is desktop width, but not when it's mobile-width [15:27:39] ahh yes.. hadn't noticed that [15:27:44] jdlrobson: thanks [15:27:47] i'm sure there is a logical reason though :) [15:29:24] found it heatherw :) [15:29:39] : [15:29:41] :) [15:30:02] i am not awake enough to type apparently [15:30:18] jdlrobson: android is behaving weirdly [15:30:23] what is it with wikimedians and lack of sleep [15:30:30] how so YuviPanda ? [15:30:33] i noticed it was sluggish. [15:30:36] every touch scrolls me to a seemingly random position [15:31:03] after a few touches, the content blanks out [15:32:19] ok it doesn't blank out [15:32:46] it just scrolls way down, where there are lots of white space [15:33:22] * YuviPanda does a bisect [15:34:24] ugh, it might be my phone acting up? [15:34:29] it's not registering random touches :| [15:34:44] *now [15:39:06] jdlrobson: seems to be 4.x specific :( [15:39:38] New patchset: Jdlrobson; "Revert "fixed height for search input"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5029 [15:39:39] New patchset: Jdlrobson; "revert media query introduced in eae3f1f0" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5030 [15:39:56] more things jdlrobson: the footer opens down, and if we could give the lines of text in the footer more space above and below each line, that would be great. [15:41:35] jdlrobson: the shadow of the reference reveal has the old issue of having a margin/doesn't hit the edges. [15:42:14] skype heatherw or too early? [15:43:10] i could, give me 5 [15:44:44] np [15:44:57] New patchset: MaxSem; "Main page and
fun" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5032 [15:45:09] jdlrobson, ^^ [15:45:30] YuviPanda: are patrick's pull requests relevant given the move to the api? [15:45:53] * YuviPanda peeks [15:46:17] jdlrobson: 'page normalization'? [15:46:18] nope [16:01:16] New review: Jdlrobson; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/5032 [16:10:45] New review: Jdlrobson; "Only thought is that we should possibly pull in jQuery using a wget / curl rather than storing in th..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/5011 [16:11:48] scrolltop seems to have no effect... [16:12:09] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5068 [16:12:13] New review: gerrit2; "Auto-approving/merging l10n updates" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5068 [16:12:13] Change merged: gerrit2; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5068 [16:13:15] New review: Reedy; "MediaWiki itself includes jQuery... You could just serve that up" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/5011 [16:18:11] New review: Jdlrobson; "Agreed! It would make sense to use this instead" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/5011 [16:19:47] brb [16:26:49] preilly: We just released vumi 0.4 -- it might be a good idea to switch to that instead of the snapshot. [16:27:29] (I don't really have the time to build a deb for it this week, though.) [16:27:37] * jerith heads out to band practice. [16:27:44] New review: Reedy; "That seems sensible, especially as it's something happening in the near future, and as such, isn't w..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/5011 [16:28:31] jerith: okay [16:29:02] preilly: The difference is really just that one is a more reliable reference point in the commit history. [16:29:03] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5029 [16:29:05] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5029 [16:29:35] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5030 [16:29:36] (There are some fixes and improvements, but nothing relevant to the wikipedia app.) [16:29:37] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5030 [16:29:42] * jerith really heads out now. [16:31:22] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5032 [16:31:24] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5032 [16:34:11] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5011 [16:34:13] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5011 [16:40:41] * YuviPanda heads to the doctor [16:40:46] might miss the standup, brb [16:42:06] might be of interest: http://bradfrostweb.com/blog/mobile/test-on-real-mobile-devices-without-breaking-the-bank/ It's at least a good list of platforms. (via Jonathan Kohl on Twitter just now) [16:58:15] tfinc: I'm not going to be able to make the stand up [16:58:41] preilly: because of the 10-11 testing? [16:58:44] tfinc: I'm in the middle of these varnish changes and zero related push [16:58:50] [16:58:52] preilly: k [16:59:01] did we lose a Reedy ? [16:59:19] Depends what you mean by "lose" [16:59:26] Just haven't spoken to xyr yet. [16:59:51] Amgine had me worried there [16:59:55] :) [17:00:10] Reedy: when trying to get pages recently created via en.m.wiktionary.org, they are not found. Is this slave lag? [17:00:59] lets do our standup [17:01:40] It could be lag, but unless it's really bad, it wouldn't be an issue [17:03:03] For sure 1 hour+ [17:03:22] That's not slave lag [17:03:29] If it was that bad, people would be screaming [17:03:35] kk. [17:03:48] Do they appear via non mobile methods? [17:04:01] non-MF? yes. [17:05:12] Sounds like it's cache of something in the api methods used [17:05:27] Bug report it? [17:12:34] Via search? [17:12:43] I thought you meant direct access [17:12:49] It's possible lucene is borked [17:14:14] I just got two terms more than 8 hours old. [17:14:33] (they may have had multiple edits, dunno.) [17:20:04] tfinc: do you know if the platform team moving the rest of the cluster to the 1.20wmf1 branch today? [17:20:33] awjr: i do not but you can ask robla now or i can ask him in 10min [17:38:04] awjr: its still going out in stages … commons coming up .. en wiki next week [17:38:28] tfinc: thanks - robla reminded me it was all on the deployment calendar [17:49:47] Project WiktionaryMobile - Nightly builds build #87: SUCCESS in 8.1 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/87/ [17:49:48] pfhayes: Fix for trying to get starting word on non-android platforms [17:53:24] tfinc: heya [17:57:23] welcome YuviPanda [17:57:31] YuviPanda: app is still in review state [17:57:55] YuviPanda: can you sync up with the iOS5.1 users who are tweeting about scrolling issues [17:58:19] yeah, will do [18:00:16] YuviPanda: did my last message go through ? [18:00:26] sync up with iOS 5.1 users on twitter [18:00:28] was the last one [18:00:29] yes [18:00:36] tfinc: responding to them now [18:00:40] YuviPanda: thanks [18:12:25] awjr, has everything from http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments#12_April.2C_2012 actually been deployed? [18:13:00] MaxSem I have no idea, check with preilly [18:13:08] oh, right [18:17:06] MaxSem: yes [18:17:08] preilly ^^ [18:31:14] YuviPanda: just saw your mail … you doing ok? [18:31:40] tfinc: painkillers for the night. It's not broken. [18:31:48] YuviPanda: take it easy [18:32:01] unable to use a hand though [18:32:28] YuviPanda: since you couldn't find a 3G i'm just going to buy one [18:32:36] working on a few of the things jon wanted fixed before crashing [18:32:37] and ill either send it to you or bring it to berlin [18:32:41] tfinc: cool [18:33:05] berlin is a month and a half away though [18:33:20] hows that vs indian customs ;) [18:33:41] tfinc: I also think i will be moving away from PDT to more of Jon's time zone [18:33:54] so will get to spend time with him and then SF office for the morning as well [18:33:59] YuviPanda: as long as you make the standup thats fine [18:34:02] yea [18:34:23] YuviPanda: http://www.ebay.com/ctg/Apple-iPhone-3G-8GB-Black-Unlocked-Smartphone-/100014203?_dmpt=Cell_Phones&_pcategid=9355&_pcatid=801&_refkw=iphone3g&_trkparms=65%253A12%257C66%253A2%257C39%253A1%257C72%253A6064&_trksid=p3286.c0.m14 [18:34:59] tfinc: ok [18:40:00] New patchset: awjrichards; "Merging from master at 5ea662f03af3034af3c0c89424163ffa0db42960" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5115 [18:40:39] Change abandoned: awjrichards; "wrong branch" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5115 [18:42:57] tfinc: I'll be crashing in a while when the pain killers work in. since i missed the standup: 1. worked fixing bugs jon spotted to fix api branch before merging 2. Found a nasty scrolling regression on android (in API move branch), investigating that 3. Talked with Jon about how to implement reference reveal with the new on-demand DOM loading 4. Implemented a version of 'fast click' so that people get instant touch responses (the 'lag' issue) [18:43:02] will continue with (2) and (1) tomorrow [18:43:07] ^ resending [18:43:34] YuviPanda: i'm going to ask Rachel about import fees before hitting buy [18:43:58] yeah, i am not sure how complicated it will be [18:44:05] YuviPanda : k .. i'm going to send that on your behalf to mobile-tech [18:44:10] ok [18:44:15] thanks [18:49:51] YuviPanda: wow .. Indian customs are so arbitrary [18:50:00] for electronics [18:50:55] :) [18:52:06] tfinc: http://products.ebay.in/iphone-3g?_trksid=p2041978&_rdc=1 [18:52:28] YuviPanda: how much do you trust this seller ? [18:53:25] PaisaPay is supposed to be safe [18:53:44] however, i've never bought anything from there. Do not personally know anyone who has either [18:54:12] lifeeth: how reliable is ebay.in here? [18:54:57] WTF, git-review bails out on push stating it can't apply a long-merged commit [18:57:00] MaxSem: hmm, that's pretty weird [18:57:19] hey YuviPanda [18:57:31] YuviPanda : its pretty safe -- just check the seller reputation [18:57:34] MaxSem: what is the CLI output? [18:57:44] tfinc : tell me about the customs :) [18:57:54] lifeeth: http://www.ebay.in/itm/190667701820#ht_1463wt_922 [18:57:57] tfinc : I have had my share of trouble trying to run a tiny electronics firm [18:58:07] 1 bobcat per 20 iPhones? [18:58:15] preilly, http://dpaste.com/732650/ [18:58:22] YuviPanda : You want a 3G right? [18:58:27] lifeeth: yes [18:59:12] YuviPanda : There is no bill or warranty [18:59:22] but 94.6 % positive reviews so [18:59:26] ough, that too [18:59:41] MaxSem: did you try git review-R [19:00:16] MaxSem: I mean, "git review -R" [19:00:45] preilly, http://dpaste.com/732652/ [19:01:29] MaxSem: what happens if you git commit --amend [19:01:59] * preilly — will brb [19:05:31] fuck you git [19:05:50] i too am battling git. [19:06:15] preilly: im having a hard time merging changes from trunk into the contact-us-redesign remote branch again [19:06:44] preilly: does this sound like the correct workflow for getting changes from master into the remote branch: [19:07:03] git checkout [19:07:13] git pull origin master (to pick up changes from master) [19:07:25] # fix conflicts [19:07:36] git review -R [19:07:37] ? [19:08:14] or do i actually need to rebase against… something, like the last merged commit in the remote branch/ [19:09:00] * MaxSem thinks he had lost 2 hours' work in those rebases [19:10:00] once again, fuck you git and your history rewriting [19:10:13] * MaxSem starts redoing everything [19:11:43] * jeroid avoids rebase on general principles. [19:12:01] jeroid, tell that to git-review [19:12:45] tfinc: replied to jon's email. Am heading to sleep. Good night [19:12:50] night YuviPanda [19:13:21] awjr_lunch: that seems logical [19:13:49] I don't know git-review. [19:14:11] jeroid, you're lucky! [19:14:21] We use github for that kind of thing. [19:16:47] woot .. apple approved our expedited review [19:18:23] We also avoid having lots of different people working on the same branch. [19:20:00] tfinc: sweet [19:20:14] preilly: dan came by and said we could shut down the test [19:20:31] So there's very little need to rebase. [19:20:47] * tfinc goes to pickup lunch [19:24:44] * preilly thinks tfinc is lying about picking up lunch  [19:25:02] * preilly but, not as bad as our office wifi lies [19:25:11] * tfinc goes to prove preilly wrong [19:28:09] Bet xe comes back with a Ford. [19:30:12] New patchset: MaxSem; "Fixed tests broken by previous commits" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5123 [19:30:54] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5123 [19:30:57] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5123 [19:58:41] tfinc: I created the following RT ticket: http://rt.wikimedia.org/Ticket/Display.html?id=2826 [20:00:46] brion: https://office.wikimedia.org/wiki/Engineering/Mobile/Testing_Devices [20:07:40] checked out & charging [20:11:48] New patchset: awjrichards; "Resolving merge conflicts from sync from master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5125 [20:12:26] awjr: what is with https://gerrit.wikimedia.org/r/#change,5125 [20:12:28] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5125 [20:12:57] preilly im trying to get changes in master sync'd with contact-us-redesign [20:13:22] awjr: well, that was an empty changeset [20:13:35] preilly: yes, which is why i abandoned it. [20:16:56] awjr: roger [20:23:47] awjr: are you still having issues getting that merged in? [20:24:20] preilly: yeah but im hoping this round is going to be ok [20:24:26] im still cleaning up conflicts etc [20:24:53] awjr: hmm [20:25:02] we should probably be syncing to master like, daily [20:25:10] or from mater, rather [20:25:20] awjr: yeah, from master [20:25:43] so preilly, i did a git pull origin master (on my local contact-us-redesign) [20:25:49] which had a bunch of merge conflicts, which i cleaned up [20:26:08] and then ran git rebase -i 0efdb21438618b9ec7e255e7478616b91656c3b1 [20:26:17] 0efdb21438618b9ec7e255e7478616b91656c3b1 was the last merged commit on the remote branch [20:26:37] awjr: this one https://gerrit.wikimedia.org/r/#change,4318 right? [20:27:04] and am now cleaning up more conflicts - but git keeps trying to apply things that have already been applied, which results in something like "Could not apply 7ad9f01... re-enabled toggling on the footer" [20:27:14] but a git rebase —continue seems to just do the trick [20:27:23] preilly, correct [20:27:26] awjr: yeah [20:27:31] awjr: so, is it working now? [20:27:37] still getting through the conflicts [20:29:17] did you try a git merge master? [20:29:40] preilly no i did not [20:29:50] preilly should have i done that instaed of git pull origin master? [20:33:00] awjr: yes [20:33:39] awjr: the other way you probably have broken the ability to do a fast-forward merge [20:33:51] preilly interesting - why is that? [20:34:08] awjr: basically disparate commits, [20:34:18] and is that why by git rebase is wonky and trying to apply things that have already been applied? [20:34:29] yeah [20:34:33] ok [20:34:34] fml [20:34:35] so [20:34:40] the workflow should be: [20:34:49] git checkout [20:34:51] git merge master [20:35:01] git rebase -i 0efdb21438618b9ec7e255e7478616b91656c3b1 [20:35:05] git review -R contact-us-redesign [20:35:06] ? [20:35:23] yeah [20:35:54] * preilly okay, I'm getting food [20:45:27] preilly, are you sure format=json is still used? https://graphite.wikimedia.org/render?width=500&from=-1hours&until=now&height=380&target=ExtMobileFrontend.DOMParse-json.count [20:46:51] sigh [20:47:01] preilly i just tried what we talked about and got the following: [20:47:02] ! [remote rejected] HEAD -> refs/for/contact-us-redesign/contact-us-redesign (no new changes) [20:47:02] error: failed to push some refs to 'ssh://awjrichards@gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend.git' [20:49:04] oh i think because i missed a conflict [20:54:46] preilly: im seeing the same behavior with the workflow we just talked about [20:59:17] preilly: when you get back, what do the wiktionaries need to do to make content visible on their main page? [20:59:28] in mobile frontend [21:02:00] Amgine: http://meta.wikimedia.org/wiki/Mobile_Projects/Mobile_Gateway#How_do_I_format_a_mobile_homepage.3F [21:02:23] ty tfinc [21:03:04] awjr: has IT done your SSD switch yet? [21:03:27] wow that is english wikipedia centric. [21:03:33] tfinc no but chip mentioned to me on friday that they ordered me the hd [21:04:46] Amgine: its really not. read the global prefix section [21:05:06] I am. [21:05:18] tfinc i think chip is having the ssd sent directly to me and i will do the replacement myself [21:05:34] awjr: let me know how it goes as i'm looking to do the same on an old laptop [21:05:45] tfinc will do [21:05:59] i've been looking at this drive http://www.newegg.com/Product/Product.aspx?Item=N82E16820148449 [21:06:09] recommend it to chip too [21:06:25] oo [21:06:35] IT wasn't willing to go bigger than 128gb [21:06:37] for me at least [21:06:49] i'm trying to update this winphone7 device to 7.5... wish me luck [21:07:00] * awjr wishes brion luck [21:07:08] \o/ [21:07:18] awjr: 256GB is still pricey but falling fast [21:07:34] much faster then traditional drives ever did [21:07:43] it gave me a cryptic error message which turned out to be "the clock on your phone is set two years off" [21:07:45] nice [21:07:53] so given a couple more months we should see sub $300 256GB + drive [21:07:54] s [21:08:03] no doubt [21:09:23] but i've been able to make the old laptop work nicely as long as i use flash bock, piano bar, … last part is speeding up the drive to SSD [21:09:29] [21:10:35] tfinc: flash bock? [21:10:42] block* [21:10:51] oic [21:10:52] flash kills the cpu on that laptop [21:10:57] what is this old laptopt? [21:11:06] last non unibody mac [21:11:41] oh wow - i have an old aluminium powerbook (pre-intel) that is barely limping along still [21:12:15] i *almost* miss my old g4 powerbook... except my macbook air wipes the floor with it now :) [21:12:34] lol [21:13:37] awjr: this will come in hand once i buy the SSD http://www.ifixit.com/Guide/MacBook-Pro-15-Inch-Core-2-Duo-Models-A1226-and-A1260-Hard-Drive-Replacement/670/1 [21:13:53] pretty sure its an A1226 or A1260 [21:14:13] awjr: make sure they send you a T6 Torx Screwdriver [21:14:39] tfinc: hd replacment on my model is much easier :p [21:14:49] nice [21:15:10] jebus it looks like you have to entirely disect the thing [21:15:53] mwmw … read the product overview http://www.ifixit.com/MacBook-Parts/MacBook-Pro-15-Inch-Model-A1226-Display-Assembly/IF185-068?utm_medium=frame_module_bottom&utm_term=macbook_pro_15%22_core_2_duo_models_a1226_and_a1260&utm_source=ifixit_guide&utm_content=related_products [21:17:30] hahaha [21:17:59] tfinc do you know if jon robson will be around later today or is he gone all day? [21:18:09] he's gone [21:18:11] js meetup [21:18:17] he sent mail to mobile-tech [21:19:49] tfinc: i know but whether or not he'd be around this afternoon (particularly for deployment) seemed ambiguous from his email, was curious if you had more insight [21:21:57] awjr: i wouldn't count on him being around [21:22:30] k [21:22:32] thanks [21:25:37] brion: handy link for whenever you get to it https://github.com/wikimedia/WikipediaMobile/pull/208#issuecomment-5159891 [21:26:02] \o/ [21:26:03] there is some great back and forth between yuvi and jon already [21:27:47] New patchset: MaxSem; "Switch to RequestContext, ditch $wgUser, $wgRequest and $wgOut" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5133 [21:33:39] yeah, looks like windows phone 7 installs the updates in sequence, one at a time [21:33:54] instead of, oh, rolling them up and applying one giant update [21:34:01] or downloading them all and installing them automativcally [21:35:31] MaxSem: thanks for responding to Jonas [21:42:27] MaxSem, preilly: changes for today's deployment are live on test.wikipedia.org - please test [21:47:39] oops forgot to minify js [21:50:12] ok fixed [21:52:32] awjr, jquery-1.7.2.min.js is still a 404 [21:53:08] MaxSem it is working for me [21:53:37] awjr, https://test.wikipedia.org/w/extensions-1.19/MobileFrontend/javascripts/jquery-1.7.2.min.js [21:53:59] yes, it shows me jquery 1.72.min.js :p [21:54:16] MaxSem ^ [21:55:05] awjr, then it's esams [21:55:21] just checked in another browser [21:55:31] same problem? [21:55:35] yup [21:55:35] that is very strange. [21:57:04] awjr, loaded for me with query appended [21:58:37] phew [21:58:54] this is strange [21:59:35] footer stuff is still busted in RTL languages - is that a deployment blocker? [21:59:59] sinec RTL in general is inda busted in MF [22:00:03] *since [22:00:56] preilly ^ [22:00:58] MaxSem are you still seeing weirdness? [22:01:58] New patchset: MaxSem; "Append version to jQuery URL" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5134 [22:05:25] awjr, tried wget from toolserver - same crap [22:06:19] http://dpaste.com/732777/ [22:06:57] awjr, see the commit^^^ [22:07:24] MaxSem very strange - it is working fine for me here. maybe ask about esams in #wikimedia-operations? [22:07:33] MaxSem is that commit necessary? [22:07:52] awjr, at least it would fix the problem for me and TS [22:07:53] :P [22:08:11] awjr, have you scapped, I see changes on enwiki [22:08:58] MaxSem no i have not scapped [22:09:21] MaxSem and i see no log msgs in #wikimedia-tech [22:10:28] MaxSem i do not see changes on enwiki -for instance, enwiki is still requesting jquery-1.7.1.min.js [22:11:03] yup, false alarm [22:11:56] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5134 [22:12:09] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5134 [22:14:14] MaxSem that change should now be live on testwiki [22:15:56] yes, this seems to have solved the problem [22:17:19] awjr, moar fun: cookies don't seem to stick [22:17:55] MaxSem: describe the behavior you're seeing? it might be the known issue with browser caching on single-domain sites [22:18:08] repro: load testwiki with a fresh browser, click mobile view, click home [22:19:02] same stuff works on my single-domain dev wiki [22:19:31] MaxSem actually works fine for me in FF on os x [22:19:44] Opera and Safari/Win [22:20:25] what happens if you hard-refresh? [22:20:58] hmm, works [22:21:08] yeah it's your browser cache [22:21:35] consistence of user (mis)experiense is scary [22:21:46] yes it is [22:22:09] short of getting mediawiki to properly support etags i haven't thought of or heard a solution to that problem [22:22:37] the good news, though, is that in production on the cluster it should not be a problem sine that behavior is not present on sites with separate mobile domains [22:23:35] preilly: are you seeig any deployment blockers? [22:23:38] *seeing [22:23:57] awjr: is this https://gerrit.wikimedia.org/r/#change,5133 in the mix at all? [22:24:16] preilly no, should it be? [22:24:26] it shouldn't [22:24:30] MaxSem: okay [22:24:38] awjr: yeah, I think things look good [22:24:54] preilly the only thing i've noticed is that the footer is messed up for RTL languages [22:25:10] but wasn't sure if that's a deployment blocker since MF is kinda messed up for RTL languages anyway [22:25:31] awjr: yeah, I'd so it's okay based on what we've already got [22:25:51] preilly ok [22:26:08] MaxSem: 77 » » » {htmlTitle} [22:26:10] we should connect jdlrobson with aharoni [22:26:16] preilly also - since some sites are running 1.20wmf1, do i need to do anything special to get changes pushed to them? [22:26:18] MaxSem: in https://gerrit.wikimedia.org/r/#patch,sidebyside,5133,1,templates/ApplicationTemplate.php [22:26:34] awjr: you need to update the sub module [22:26:40] preilly how do i do that? [22:26:59] awjr: check out core [22:27:12] there is nothing in the deployment documentation about it [22:27:21] preilly can you add it? [22:27:27] http://wikitech.wikimedia.org/view/How_to_deploy_code [22:28:25] awjr: have you done this: git checkout -b wmf/1.20wmf1 origin/wmf/1.20wmf1 [22:28:40] awjr: I think it would be best if Roan or someone else did that [22:28:50] preilly: i have not [22:29:02] awjr: then git submodule init [22:29:18] awjr: then git submodule update extensions/MobileFrontend [22:29:56] awjr: git commit -a [22:30:28] awjr: skip that last part [22:30:37] awjr: cd extensions/MobileFrontend [22:30:39] awjr: git pull [22:31:12] awjr: then git checkout origin/master [22:31:19] awjr: then cd back out [22:31:24] awjr: git commit -a [22:31:36] awjr: then try git push origin wmf/1.20wmf1 [22:31:46] awjr: if that fails use git review [22:31:53] awjr: does that makes sense to you? [22:32:01] New patchset: MaxSem; "Switch to RequestContext, ditch $wgUser, $wgRequest and $wgOut" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5133 [22:32:06] preilly sort of - i'm not seeing origin/wmf/1.20wmf1 as a remote branch [22:32:27] preilly, fixed^^ [22:32:29] awjr: git pull [22:32:33] MaxSem: thanks! [22:32:51] oh duh [22:34:42] preilly: [22:34:43] awjrichards@virtualbot:~/Dev/1.19wmf1$ [wmf/1.20wmf1]$ cd extensions/MobileFrontend/ [22:34:43] awjrichards@virtualbot:~/Dev/1.19wmf1/extensions/MobileFrontend$ $ git pull [22:34:43] You are not currently on a branch, so I cannot use any [22:34:43] 'branch..merge' in your configuration file. [22:34:43] Please specify which remote branch you want to use on the command [22:34:43] line and try again (e.g. 'git pull '). [22:34:43] See git-pull(1) for details. [22:35:14] preilly after i got that i did: [22:35:16] awjrichards@virtualbot:~/Dev/1.19wmf1/extensions/MobileFrontend$ $ git branch [22:35:16] * (no branch) [22:35:16] master [22:35:16] awjrichards@virtualbot:~/Dev/1.19wmf1/extensions/MobileFrontend$ $ git checkout master [22:35:16] Switched to branch 'master' [22:35:17] awjrichards@virtualbot:~/Dev/1.19wmf1/extensions/MobileFrontend$ [master]$ git pull [22:35:17] Already up-to-date. [22:35:31] why are you in 1.19wmf1? [22:35:43] hahaha im not [22:35:51] it's just the name i gave the dir a long time ago [22:36:00] awjr: okay [22:36:04] awjr: so, you did this git checkout -b wmf/1.20wmf1 origin/wmf/1.20wmf1 [22:36:15] then then git submodule init [22:36:25] then git submodule update extensions/MobileFrontend [22:36:32] cd extensions/MobileFrontend [22:36:36] then git pull [22:36:49] almost [22:36:55] preilly i had to git checkout master before git pull worked [22:37:22] use git fetch instead [22:37:44] okay, so is it working now? [22:37:56] preilly yes it looks up to date and correct [22:38:05] awjr: did you commit? [22:39:24] preilly yeah [22:39:26] and tried git push [22:39:31] but got an error with git push [22:39:39] To ssh://review/mediawiki/core.git [22:39:39] ! [remote rejected] wmf/1.20wmf1 -> wmf/1.20wmf1 (prohibited by Gerrit) [22:39:39] error: failed to push some refs to 'ssh://review/mediawiki/core.git' [22:39:52] awjr: use git review [22:40:01] awjr: you don't have permission for the push [22:40:05] https://gerrit.wikimedia.org/r/5136 [22:40:30] huh it is an empty changeset [22:41:43] No it's not, MobileFrontend has a diff [22:41:54] It updates the commit hash [22:42:00] awjr: -Subproject commit b246830720baa9030bcfe20d961a8ce585927691 [22:42:01] +Subproject commit 6329cd0ea5d03ffb83de91352886f5e85389b4a6 [22:42:14] awjr: that looks correct to me? [22:42:38] Yeah that looks correct [22:42:43] Approved and merged [22:44:52] preilly my net connection went wonky [22:45:08] RoanKattouw No it's not, MobileFrontend has a diff [22:45:09] RoanKattouw It updates the commit hash [22:45:11] preilly awjr: -Subproject commit b246830720baa9030bcfe20d961a8ce585927691 [22:45:13] preilly +Subproject commit 6329cd0ea5d03ffb83de91352886f5e85389b4a6 [22:45:14] preilly awjr: that looks correct to me? [22:45:15] RoanKattouw Yeah that looks correct [22:45:17] RoanKattouw Approved and merged [22:45:29] ah ok thanks RoanKattouw [22:46:04] awjr: so, now update fenari.wikimedia.org [22:46:46] awjr: /home/wikipedia/common/php-1.20wmf1 [22:46:58] preilly git pull? [22:47:14] awjr: yeah [22:47:29] preilly permission denied [22:48:31] awjr: are you not in the wikidev group? [22:49:06] preilly i thought i was [22:49:17] awjrichards@fenari:/home/wikipedia/common/php-1.20wmf1$ groups [22:49:17] wikidev [22:49:20] preilly ^ [22:49:31] awjr: hmm [22:49:36] awjr: okay, well I updated it [22:50:04] preilly it was because my connection was lost [22:50:11] i had been in a screen session on fenari [22:50:15] i logged back in and it worked [22:50:19] awjr: okay [22:50:36] awjr: 32 files changed, 2094 insertions(+), 3934 deletions(-) [22:50:42] preilly: so if i scap now, will it update both 1.19 and 1.20? [22:50:54] awjr: I think so [22:50:58] ok here goes [22:51:06] awjr: do you really need to scap? [22:51:15] awjr: couldn't you just sync-dir? [22:51:17] preilly: i guess i could sync-dir [22:51:54] awjr: actually just scap [22:52:14] awjr: I'm not sure if sync-dir is the best thing to use based on message cache etc [22:52:34] If there are message changes, you will need scap [22:52:57] hmm, I've set mobile cookies at testwiki, after that enwiki refuses to switch me back, even displaying mobile content on page with mobileaction=toggle_view_desktop [22:53:18] MaxSem: the cookie is based on the TLD [22:53:41] MaxSem: e.g., wikimedia, mediawiki, wikipedia.org, etc. [22:53:54] RoanKattouw: will scap push out changes for 1.19 and 1.20? [22:54:00] TLD is the same on both sites [22:54:12] (wikipedia.org) [22:54:17] Yes it will [22:54:21] ok thanks [22:54:33] MaxSem: so, it's sharing the same cookie [22:55:15] yeah, and enwiki can't do anything with cookies set by testwiki. even if cookies are messed, toggle_view_desktop should force desktop content [22:55:19] ? [22:55:46] MaxSem: it can change the cookies no problem [22:56:08] MaxSem: as they are setting them in the wikipedia.org domain not their subdomain scope [22:56:25] awjr: any ideas why toggle_view_desktop is failing? [22:56:46] preilly no i am not experiencing the same problem [22:56:50] * awjr pokes some more [22:57:43] MaxSem: can you also try a different browser? [22:57:53] trying right now [22:59:20] i am not seeing the same problem [23:01:31] scap is complete [23:03:01] * MaxSem tries another browser [23:03:12] *yet another* [23:03:59] hmm, behaviour exists only in Opera [23:04:21] FF and Safari ignore testwiki's cookies [23:04:42] weird [23:05:22] buh [23:05:42] no, reprod in Safari, too [23:06:09] mobileaction=toggle_view_desktop displays mobile content! [23:06:13] ... [23:06:20] this shouldn't happen, evar [23:06:28] no, it should not. [23:07:40] MaxSem you are seeing mobile content on desktop enwiki? [23:07:49] yes [23:07:59] * awjr scratches head [23:08:49] MaxSem: what is your request [23:08:55] MaxSem: can you paste bin it? [23:09:05] MaxSem: actually can you clear your cache and try it again [23:09:54] pic: http://tinypic.com/view.php?pic=nx8214&s=5 [23:10:07] i think i see the problem. [23:10:15] sec [23:10:56] ok well i think i see part of the problem. [23:11:31] if you are on a single-domain property and switch to mobile view, you get a mf_useformat=mobile cookie set for the TLD [23:11:56] so if you then go somewhere like enwiki, it will load the mobile version on the desktop version of the site [23:12:24] it wont redirect you to the mobile domain because MF only does redirection on mobileaction=toggle_desktop/mobile_view [23:12:42] which sucks but makes sense [23:13:11] but what doesn't make sense to me is that when i then click 'desktop view', it will NOT toggle the desktop view. instead it is setting the stopMobileRedirect=true cookie while leaving mf_useformat=mobile in tact [23:13:14] which should not happen. [23:15:03] so for the first part of the problem, i can hack a check into MF to see if you have a mf_useformat cookie and are trying to access the desktop domain - if so, redirect to mobile domain, and vice versa [23:15:12] but im not sure wtf is up with the second problem [23:16:19] oh [23:16:24] i do know what is up with the second problem [23:16:51] we only unset the useformat cookie IF the user is on a property with only one domain [23:17:19] MaxSem, preilly ^ [23:17:33] awjr: yeah, we should change that behavior [23:17:39] i need to take 5 and then i'll start putting together a fix [23:18:01] preilly my guess is this is enough of an edgecase that we can leave this in production for now until i get a fix out - what do you think? [23:18:21] this behavior would have been in existence since our deployment last week [23:23:52] MaxSem: where is getRequest() defined in https://gerrit.wikimedia.org/r/#patch,sidebyside,5133,2,MobileFrontend.body.php [23:24:08] awjr: probably fine [23:24:45] preilly, in ContextSource [23:25:34] MaxSem: ah, I missed the extends ContextSource [23:25:57] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5133 [23:26:00] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5133 [23:39:25] preilly: i think we need to stop setting the cookie at the TLD - it will only cause cache fragementation. with the most recent persistent cookie changes, it should no longer be needed. [23:40:05] awjr: okay, totally your call [23:40:07] awjr: seems sane [23:40:58] preilly: i think it's fine to leave the stopMobileRedirect cookie as a TLD cookie - in fact, i think we have to. but mf_useformat will need to be full domain-specific [23:42:46] preilly im also tempted to rename mf_useformat to force people into the new paradigm if they already have a mf_useformat cookie set [23:48:21] hmm … were getting only a trickle of applicants for the partner support engineer. it needs a rename. i think the word support is turning people off . any ideas ? [23:48:36] here is the open req http://hire.jobvite.com/Jobvite/Job.aspx?j=oX2hWfwW&c=qSa9VfwQ [23:48:48] Partnership Engineer [23:49:09] awjr: okay, that makes total sense [23:49:12] that could work [23:51:06] tfinc: Partner specialist engineer [23:51:31] or should we just saw Software Developer (Partnerships) [23:51:34] say& [23:51:45] so that its really not that much different [23:51:50] tfinc: that works too [23:51:55] tfinc: probably even better [23:52:42] k [23:52:44] thanks [23:53:24] SD(Mobile Partnerships) ?