[00:02:23] awjr: so, that is ten classes right? [00:07:40] preilly yeah that looks right [00:09:20] preilly: yeah, ten classes looks right, which in and of itself is not that big of a deal, it just feels like we're replacing one possible custom solution with another [00:10:35] preilly: i can go ahead and just do it for the fields that we care about for now, but we'll have to be mindful if we ever want to use other fields [00:12:04] awjr: or just write a method that strips tables and replaces them with divs [00:12:09] awjr: heh heh [00:12:15] so… ugly [00:12:39] i think what it boils down to is HTMLForm offends my sensibilities [00:12:45] awjr: nothing, "]*>|]*>|]*>|]*>|]*>" can't fix [00:12:51] lol [00:13:16] i just died a little inside [00:14:21] awjr: ha ha ha [00:14:34] awjr: you could always make HTMLForm2 [00:14:38] * preilly hides [00:14:40] lol [00:18:24] awjr: you know I think HTMLForm should support a decorator pattern [00:18:42] preilly: go for it! [00:19:30] awjr: I actually am curious now what preg_replace( '/\<[\/]?(table|tr|td)([^\>]*)\>/i', '', $htmlForm ); would look like [00:19:35] s/I/I'm [00:20:03] s/am// [00:27:31] awjr: can you respond to https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=6496828 [00:28:27] is there a nifty interwiki for mobile? [00:29:50] Amgine: what do you mean? [00:29:59] Amgine: interwiki links? [00:30:20] like mwp: for m.wikipedia.org [00:30:32] [[mwp:Main Page]] [00:30:39] Amgine: nope [00:30:46] darn. [00:31:59] preilly: i've already responded to that ticket [00:32:13] tfinc: asked you NOT me [00:32:14] see correspondence #6 and #7 [00:32:17] awjr: ^^ [00:32:44] doh tfinc ^ [00:39:41] haha [00:39:43] ok [00:40:00] awjr: you already responded to their response ? [00:40:06] tfinc yes [00:40:12] see responses 6 and 7 [00:40:35] OTRS UI FTFAIL [00:40:36] yes [00:40:37] mybad [00:40:49] hehehe [00:40:51] no worries [00:45:13] * awjr stabs HTMLForm in the face [00:45:29] this is turning into a real hackjob. [00:45:31] tfinc: ready for it [00:45:46] * tfinc worries a bit when he hears that [00:45:47] tfinc: feast your eyes on this: http://i.imgur.com/l87nA.jpg [00:46:01] tfinc: Help me 2Pac, you're my only hope. [00:46:09] only a matter of time before we saw that [00:46:24] ahahaha [00:47:15] why would you want a protected static function? [00:47:28] useless. [00:47:32] tfinc: I presume it's best not for me to respond to emails necessarily on the mobile-feedback-l? I'll do bug reports but emails to customers (I imagine you could call them that) from "Thehelpfulone" would be awkward I imagine (and I'm not official @wikimedia.org) [00:47:42] awjr: same reason you'd want this alarm clock http://www.modernman.com/wake-up-defusable-bomb-alarm-clock/ [00:47:59] roflmaobbq [00:48:09] preilly where do you come up with this shit [00:48:26] preilly: that's going on the wedding registry [00:50:28] Thehelpfulone: lets hold off on the emails for now [00:50:49] Thehelpfulone: i imagine that changing after we see the kinds of emails that come in [00:51:06] yeah sure, that's what I was thinking [00:51:15] I can just do the bug reports (if you don't beat me to them!) [00:51:26] Thehelpfulone: the race is on! [00:51:37] heh [00:51:56] Thehelpfulone: you should be worried if i ever get a cli to bugzilla [00:53:08] you're a bugzilla admin, don't you already have that? [00:53:20] tfinc: http://www.bugzilla.org/docs/2.16/html/cmdline.html [00:53:22] although bugzilla is probably buggy in itself :P [00:53:28] heh I thought so [00:53:45] i can only imagine the horrors of what that holds [00:54:01] tfinc: are you scared of a little sed -e 's/,/ /g' | wc | awk '{printf $2 "\n"}' [00:55:13] haha .. now if you could just make it so that i never have to leave vim .. i'm in [00:55:33] tfinc: have you looked at: http://www.liquidx.net/pybugz/ [00:56:01] * tfinc has been doing python coding lately and likes this [00:56:14] plus PuBugz .. how could you go wrong with a name like that [00:56:30] and its in pip [00:56:41] oh wait [00:56:42] nm [00:58:12] tfinc: https://answers.launchpad.net/pybugz/+packages [00:58:51] i'd have to spin up a virt to use those [00:59:43] tfinc: have you seen: http://www.theoldmonk.net/gitzilla/ [01:03:38] tfinc: https://github.com/williamh/pybugz [01:07:37] New patchset: awjrichards; "Merged previous contact us form with MaxSem's new special page magic using HTMLForm." [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5217 [01:09:42] New patchset: awjrichards; "Merged previous contact us form with MaxSem's new special page magic using HTMLForm." [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5217 [01:10:16] preilly ^ [01:11:40] awjr: preilly just stepped out for the day [01:11:42] i'm taking off too [06:30:29] hey YuviPanda [06:30:34] flyingclimber: heya [06:30:46] I've been tailing the reviews [06:31:52] I see one in UK store about crashing :( [06:31:59] checking US now [06:32:04] positive reviews in the US store [06:32:53] Hi, I'm fighting with MobileFrontend extension at http://espiral.org [06:33:18] I'd appreciate if you could check with your mobile devices whether you see a desktop homepage or a mobile one [06:33:54] I only get desktop, unless I force mobile manually - then again I have only a Nokia N9 and a Kindle Fire at hand right now... [06:34:13] and maybe those devices are not recognized as mobiles by the extension [06:36:00] flyingclimber: would you mind checking http://espiral.org in your mobile device, please? [06:36:07] hey qgil_ [06:36:08] fu [06:36:10] sure* [06:36:15] happy to help [06:36:18] thanks! [06:36:43] * flyingclimber loads up the simulator first [06:36:54] ah! simulators! [06:37:06] gosh, it's so late that I had forgotten them ;) [06:37:35] flyingclimber: we still have a lot of work left. I'm unable to replicate the 5.1 scrolling issues [06:38:02] qgil_: i'm seeing the desktop view [06:38:10] YuviPanda: i don't see them on 5.0 either [06:38:12] yep, looks like that [06:39:15] I'm kind of lost, then. The Extension page doesn't really help if the WURFL stuff is not recognized [06:39:21] and I'm not a sysadmin [06:39:27] YuviPanda: do we have anyone who can reliability show 5.x as breaking ? [06:40:07] flyingclimber: no. brion found it intermittently slow but was not able to reproduce it [06:40:13] I'll leave a message in the discussion page. Thank you for your help flyingclimber [06:40:19] qgil_: thanks! [06:41:14] YuviPanda: is it a subset of iOS devices ? [06:41:21] YuviPanda: or is it all of them? [06:41:43] flyingclimber: the reports have been on brion's iPod touch and on the store. [06:44:19] flyingclimber: so no, no pinpointing information [06:44:36] lifeeth: dealt with Indian Customs on phone imports? [06:44:40] bribey or workable? [06:45:02] YuviPanda : If it is through DHL/Fedex/UPS it gets through without an issue [06:45:14] if you are going with post -- highly unlikely that you will get it [06:45:30] yeah, post just lost my sim card and it was coming from inside india :D [06:45:34] YuviPanda : I mean you will have to pay the customs fee though [06:45:37] ah! :) [07:14:47] YuviPanda: that'll make things significantly harder . i bet we can get someone from twitter [07:16:16] we so far haven't found anyone on twitter reporting this. I'm wondering if I should tweet out asking for it [07:16:48] YuviPanda: do it [07:17:02] yup, figuring out correct way to phrase this [07:25:19] YuviPanda: nice tweet [07:25:45] :) [07:26:00] flyingclimber: progress on QA front? I remember reading that awjr is doing another round [07:26:17] yeah, let me pm you [07:26:22] ok [07:39:26] https://en.wikipedia.org/wiki/Wikipedia:Mobile_Extension_Feedback#Saved_pages [07:41:54] OuKB: sweet. [07:42:41] have contacted RIL (Pocket) about their iOS SDK. looking into saved pages [10:12:07] New patchset: Reedy; "Pass RequestContext" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5222 [10:13:36] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/5222 [10:16:08] New patchset: Reedy; "Pass RequestContext" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5222 [10:17:06] I don't see the difference [10:17:13] A much longer commit summary [10:18:03] was it really needed? :P [10:18:16] Yup :D [10:18:17] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/5222 [10:19:01] New review: Reedy; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5222 [10:19:03] Change merged: Reedy; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5222 [10:21:29] MaxSem: have you tried https://gerrit.wikimedia.org/r/#change,5217 ? I'm getting errors when I try to access it... [10:21:34] New review: Hashar; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5222 [10:21:58] nope [10:22:45] I'm getting Descriptor with no class: Array - which seems to be a problem in getForm caused by use of custom input types [10:24:41] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5222 [10:40:02] New review: Jdlrobson; "This doesn't work for me - something doesn't seem to be picking up your changes to $typeMappings" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) C: -1; - https://gerrit.wikimedia.org/r/5217 [10:54:07] YuviPanda: fixed the content flash problem [10:54:13] jdlrobson: w00 [10:54:14] woo [10:54:15] i mean [10:54:16] woot [10:54:19] -webkit-transform again [10:54:23] ugh [10:54:31] now looking into the scrolling problem [10:54:33] jdlrobson: removing that translate3D messes things up on iOS [10:54:34] (horizontal) [10:54:38] ok [10:54:41] its only applied to android devices YuviPanda [10:54:51] it now is, I guess :) [10:55:05] https://github.com/yuvipanda/WikipediaMobile/pull/3 [10:56:21] jdlrobson: https://github.com/jdlrobson/WikipediaMobile/commit/f9367652c4f75f46eebdaa6c6e45063b28da1903 [10:56:57] yup [10:57:08] jdlrobson: so, i'm considering getting rid of line 68 and 73 on app.css [10:57:15] and just adding those translates to iOS [10:57:23] instead of setting them in general and removing them in android [10:57:33] we could also do that yes [10:57:43] seems cleaner to me [10:57:43] that might be more readable [10:57:46] yes [10:57:49] yep agreed [10:57:57] let me go do that [10:59:12] testing [12:07:06] YuviPanda: think ive got the horizontal scroll problem [12:07:27] viewport issues or more css issues? [12:07:31] css [12:10:16] jdlrobson: also, my fix (of applying it only to iOS) doesn't seem to be working [12:10:17] investigaitng [12:13:14] pushes.. [12:15:38] at least this one made sense [12:16:43] ok im noticing that my screen flash problem only fixed the initial page load [12:16:54] it doesn't seem to fix the screen flash after searching or clicking page links [12:16:56] grr [12:22:15] it's more css problems... [12:23:27] ugh [12:23:32] not webkit transform [12:28:20] not sure yet still trying to find the troublesome css by divide and conquer [12:29:36] that seems to be the only viable debuggins strategy :| [12:29:53] jdlrobson: is there something about the nature of the app's structure that is causing these kind of 'fix only by divide and conquer' bugs? [12:30:01] they're incredibly irritating [12:30:14] well the thing i'm slowly learning is vendor prefixes are causing problems [12:30:39] and we have badly documented hacks that might be there for a specific device but it is not clear [12:31:36] (the .android .ios classes should help with these) [12:31:45] :| [12:31:49] true [12:36:03] seems to be related to scroller surprise surprise [12:36:52] i'm scared everytime we touch anything scroller because maybe it'll break iscroll [12:37:15] iScroll is just for iphone ? [12:37:24] (ios) [12:39:51] yeah [12:39:52] 4.x [12:42:23] grr so yeh its iscroll css causing problems in ics here [12:42:57] so ios targeting would help here [12:43:07] just trying to work out the rule in particular.. [12:43:19] then shall we merge? [12:43:22] (to master?) [12:44:57] yeah [12:45:16] i've narrowed it down to 1 or 2 lines [12:45:22] * 1 of 2 [12:45:58] -webkit-overflow-scrolling: touch; :/ [12:47:22] :/ [12:47:42] jdlrobson: that's something we can move to iOS only [12:47:46] IIRC not supported in Android [12:48:02] * YuviPanda checks [12:48:20] it's causing the screen flashes though [12:49:08] pushed [12:49:12] pulling [12:49:30] https://github.com/jdlrobson/WikipediaMobile/commit/d4e2605a7ab27da32d242b85bde6a2f9a2af995b [12:49:35] fun times [12:49:39] pulling and merging i hope? [12:49:44] we then need to tackle the homepage [12:49:56] unless there are any outstanding large bugs [12:53:08] btw YuviPanda there seems to be a lot of MobileFrontend bugs on https://bugzilla.wikimedia.org/buglist.cgi?field0-0-0=priority&resolution=---&resolution=LATER&resolution=DUPLICATE&query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&type0-0-0=notequals&value0-0-0=enhancement&product=Wikimedia%20Mobile&list_id=108591 [12:53:12] jdlrobson: checking. [12:53:19] (listed as apps in the bug) [12:53:37] jdlrobson: you're looking for Product: Wikipedia App [12:53:39] not Wikipedia Mobile [12:53:41] we re-orged it [12:54:47] ahh ok ... so am I using the wrong filter for MobileFrontend? [12:54:51] I tend to use extensions/MobileFrontend [12:54:57] e.g. this url https://bugzilla.wikimedia.org/buglist.cgi?query_format=advanced&field0-0-0=bug_severity&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&type0-0-0=notequals&value0-0-0=enhancement&component=MobileFrontend&resolution=---&resolution=LATER&resolution=DUPLICATE&product=MediaWiki%20extensions&list_id=108593 [12:55:06] jdlrobson: that's where it should be. [12:55:22] IIRC tfinc re-orged it so that 'Wikipedia Mobile' is 'obsolete' [12:55:38] someone needs to sit for a day, triage all the 'Mobile' ones and move them appropriately [12:56:03] ok cool - just checking - i find people are opening bugs under Wikipedia Mobile - which I guess is what I'd do if I wasn't familiar with the codebase and that the mobile site is actually an extension [12:56:13] true, should do that soon [12:56:19] right i was going to pop out for some air [12:56:20] but tfinc is the best person to poke about this [12:56:23] anything you want me to do before that? [12:57:04] jdlrobson: so, android 4.x [12:57:11] article doesn't scroll to top after nav :D [12:57:32] let me pull that in and go check that [12:57:54] jdlrobson: is there anything we could do to prevent these bugs from occuring in the first place? [12:58:00] (weird css ones) [12:58:04] app's architecture, etc? [12:59:51] jdlrobson: https://github.com/jdlrobson/WikipediaMobile/commit/4ba192637355111768cca1f7911cad6abb9f9436 and https://github.com/jdlrobson/WikipediaMobile/commit/d4e2605a7ab27da32d242b85bde6a2f9a2af995b only? [13:00:52] only? [13:01:32] nevermind I can't seem to read [13:01:34] well.. by targeting hacks like this at specific browsers i'd hope these bugs would stop appearing [13:02:36] i'm not even sure how effective -webkit-overflow-scrolling: touch; is but luckily the original commit https://github.com/jdlrobson/WikipediaMobile/commit/f130a3e3c823309d3e5d8cc57d202e67f3631fce did explain it was for ios [13:03:13] we're going to have to be vigilant about pull requests including hacks in future to avoid bugs going into the code base [13:03:36] we'll have to ensure hacks target the right browsers [13:03:48] jdlrobson: right. makes sense. [13:04:18] anyway... air and errands. Be back online in about 30mins-1hr [14:05:26] jdlrobson: I still see the flash of no content until I scroll issue on ICS [14:05:30] even after your fixes [14:05:30] :( [14:05:35] have you turned it off and on again? [14:05:40] good point [14:05:42] let me try that [14:05:46] :) [14:05:50] also, how're gun laws in the UK? [14:05:58] might be easier than this. [14:06:03] http://www.youtube.com/watch?v=nn2FB1P_Mn8 [14:16:55] any luck YuviPanda ? [14:17:06] jdlrobson: nope. [14:17:24] and still flashes after turning it off and on again? [14:17:35] yes [14:17:36] it does [14:17:43] and the window.scrollTo hack does not work [14:17:50] grr wtf is with these emulators [14:18:12] is this still all on the api branch? [14:19:32] jdlrobson: yes [14:19:36] i pushed after picking up your changes [14:19:56] ill verify in my emulator [14:20:16] ok [14:22:56] mm so on my emulator i cant seem to load any page [14:23:43] has anything else changed? [14:25:37] jdlrobson: can't? [14:25:38] no [14:25:38] ... [14:26:01] it might be the wifi connection in my cafe - but nothing ever loads in the emulator [14:26:18] let me check ios [14:26:26] i just see the ajax loader [14:26:28] jdlrobson: ok [14:26:32] ios is fine.. [14:26:33] mm [14:27:05] jdlrobson: try scrolling? [14:27:16] nope [14:27:27] works fine on device :| [14:27:31] jdlrobson: what commit are you on? [14:27:43] are you on a fresh checkout of api-move? [14:28:00] well i was on 0e0ce9b9fab501ba4c44e2d5730dc0b077df4efb and did a git merge [14:28:07] i'll try again with a fresh clean one [14:28:40] merge and cherry-pick are not friends :D [14:29:58] ok brb food [14:31:47] still not loading.. [14:36:34] ERROR!{"readyState":0,"status":0,"statusText":"abort"} at file:///android_asset/www/js/search.js:96 < assuming this is my connection so moving somewhere more reliable [15:03:05] New patchset: MaxSem; "Restore message lost in merges and refactorings" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5228 [15:13:26] New review: Siebrand; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5228 [15:13:29] Change merged: Siebrand; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5228 [15:22:23] so YuviPanda - on a better internet connection i can see content again and bizarrely the white flashes have returned which is most confusing [15:26:17] bizarrely i seem to have fixed it as well [15:47:36] jdlrobson: bizzare css bugs? You don't say [15:47:45] :D [15:47:45] jdlrobson: yes, readyState '0' is a connection bug. [15:47:55] I should poke heatherw again about that icon [15:47:55] does that commit fix ICS for you? [15:48:09] jdlrobson: anything now? [15:48:11] i'm just checking [15:48:15] came back after lunch [15:48:17] I mean dinner [15:49:06] jdlrobson: where? I don't see anything at https://github.com/yuvipanda/WikipediaMobile/pull/3 [15:49:43] right [15:49:45] i see another one [15:51:01] trying [15:52:21] hi YuviPanda [15:52:29] heya heatherw [15:52:43] did you make a screenshot of where that happens? [15:53:01] heatherw: it doesn't happen yet :D [15:53:06] but wait I can explain with a screenshot [15:53:31] this: "the spinner just keeps doing its thing." YuviPanda [15:53:40] yeah, I'm guessing that wasn't very clear [15:53:46] looking for a screenshot to explain, wait a minute [15:53:47] :D [15:54:41] heatherw: https://p.twimg.com/Aqu9gXsCEAArzm8.jpg [15:54:57] heatherw: so, essentially, when the network is down [15:55:06] heatherw: the spinner just keeps spinning until the network is back [15:55:15] heatherw: I want to replace it with some other icon that says 'network is down' [15:55:18] that shot has a few problems ;P [15:55:21] rather than just the generic spinner [15:55:24] right [15:55:29] i was picking for *any* shot :D [15:55:44] heatherw: i could ask you to 'forget about everything but the spinner' :D [15:55:56] already forgotten YuviPanda [15:55:56] or I could make you another shot that doesn't have that [15:56:00] heatherw: :) [15:56:15] heatherw: am I clearer now or still phrasing things badly? [15:56:37] it made sense, i just needed to see the context (size, etc) [15:56:50] thanks! YuviPanda [15:56:55] heatherw: :) [15:57:30] heatherw YuviPanda - something like this :D http://3.bp.blogspot.com/-agtpn2Q43bk/TxzTkYjzD-I/AAAAAAAAFu4/2va8paYaG6w/s1600/2510442.jpg [15:58:07] jdlrobson: http://rlv.zcache.com/no_network_connection_available_flyer-p244075390443863723b2pv5_400.jpg [15:58:08] ? [15:58:08] :D [15:58:17] jdlrobson: lol [15:58:21] :) [15:58:35] jdlrobson: but I think this will be a pleasing one for 'no internet' http://plug-in.bestbuy.ca/t5/image/serverpage/image-id/3632iD197CF6F101B87CF/image-size/original?v=mpbl-1&px=-1 [15:58:36] :D [15:59:23] that should just be on everything [15:59:27] :D [15:59:42] jdlrobson now has no internet [15:59:54] heh [16:00:39] YuviPanda: lets chat in 15min [16:01:05] tfinc: cool [16:01:53] hey tfinc [16:03:34] jdlrobson: unintentional side effects? [16:03:42] the top bar is no longer position:fixed! [16:04:49] how did that happen? [16:05:06] the search bar you mean? [16:05:14] can you send me a screenshot? [16:05:28] jdlrobson: yes [16:05:32] it essentially scrolls with the content [16:05:40] mm [16:05:48] and that was after cherry picking my commit?! [16:06:03] yes, am recertng that to confirm [16:06:35] jdlrobson: yup [16:06:41] reverting fixes it [16:06:42] overflow-y: auto; does that!? [16:06:44] let me get you a screenie [16:07:04] wait a minute.. [16:08:05] i think i know what you mean [16:08:13] i just for some reason thought it was always like that [16:08:16] we scroll the search? [16:08:28] we *don't* scroll the search [16:08:32] it remains on top no matter what [16:08:39] and now with your commit, search scrolls [16:09:03] sorry yeh i know what you mean [16:09:13] i guess i just thought we hid search on a scroll [16:09:19] of course my change would do that [16:09:26] weird it fixes the flashing bug.. [16:10:06] (ie. content more important debate) [16:10:39] jdlrobson: https://minus.com/mLcrPZHeF/ [16:10:55] yep we are on the same wavelength [16:10:59] i'm exploring it now [16:11:13] jdlrobson: yeah, that one. I think we figured we'd eventually autohide them after a timeout, have them tap to show, etc. I don't think we even started on that debate :) [16:11:14] ok [16:11:30] mm [16:12:20] we could just use position fixed for android.. avoiding any use of scrolling divs where possible [16:16:15] ok [16:27:57] YuviPanda: thoughts? https://github.com/jdlrobson/WikipediaMobile/commit/b219e68e5bc1aefb6aa8bdd77ae35011cf01cb0f [16:28:13] it seems to fix the scrolling problem and i suspect it will obsolete scroll hack [16:50:31] jdlrobson: saw your comment about my code changes for contact-us-redesign [16:50:35] what were you doing when you got that error? [16:50:59] just tryin to access the form via the contact link [16:51:23] hmm [16:51:32] http://localhost/w/index.php?title=Special:MobileFeedback&returnto=Main+Page [16:51:43] i'm up to date on mediawiki [16:51:47]