[11:08:51] New review: Jdlrobson; "Looks good to me. I successfully managed to save to a remote wiki. - Now just need to deal with wher..." [mediawiki/extensions/MobileFrontend] (contact-us-redesign) C: 1; - https://gerrit.wikimedia.org/r/5394 [13:18:11] [WikipediaMobile] Nikerabbit pushed 1 new commit to master: http://git.io/BIHc_g [13:18:11] [WikipediaMobile/master] Localisation updates from http://translatewiki.net. - Niklas Laxström [13:50:13] * YuviPanda looks around [13:53:43] see anything useful? [13:54:40] MaxSem: there is no valid answer to that question :) [16:01:50] MaxSem: any idea why the div #section_SpokenWikipedia jumps from the bottom of the page here http://en.wikipedia.org/wiki/Wage_reform_in_the_Soviet_Union,_1956%E2%80%931962 to the top here http://en.m.wikipedia.org/w/index.php?title=Wage_reform_in_the_Soviet_Union,_1956%E2%80%931962 ? [16:07:57] mmm [16:08:12] yes, it seems to have moved up in html [16:09:12] jdlrobson, http://en.m.wikipedia.org/wiki/Wage_reform_in_the_Soviet_Union,_1956–1962 [16:09:55] yeh... not sure why that might have happened :S [16:10:07] jdlrobson, apparently, non-canonical URL is stuck in caches [16:11:05] yep, it was so a few revisions back http://en.wikipedia.org/w/index.php?title=Wage_reform_in_the_Soviet_Union,_1956%E2%80%931962&oldid=488824609 [16:12:54] we need to discuss this with Patrick or Artur when they appeear [16:13:55] cool [16:14:13] (not cool that it's stuck in cache but cool you identified the problem :-)) [16:14:40] so bug 30829 - i'm going to knock up some test pages for you to open in your samsung jet [16:14:51] as i think this is a case of 'can't fix' [16:15:32] no, you can fix it. just add a normal button and style it to your liking instead o inventing clickable images [16:15:52] * MaxSem is a primitivist [16:21:29] it's not that simple. [16:23:00] if a browser doesn't display alt text with images disabled - i consider that bad [16:24:05] i tried disabling images on google today on my browser and the search icon was just a bordered box which personally I consider acceptable [16:37:28] awjr: ping [16:37:41] preilly pong [16:37:42] awjr: are you planning on doing the deployment today? [16:38:03] i didn't have any specific plans [16:38:07] preilly but im happy to do it [16:38:14] awjr: okay [16:38:23] awjr: can you do it today and I'll do next week? [16:38:31] preilly sounds good [16:38:42] awjr: we can deploy master right? [16:39:07] preilly im not sure what the right thing to do is now that i created a deployment branch for that fix last week [16:39:24] preilly i guess it wouldn't be a big deal to switch back to master [16:41:07] preilly: i guess i feel ambivalent about it all - on the one hand it's nice to have a buffer between master and deployment so it's easier to cherry pick fixes like we had to do last week. but on the other, being able to deploy driectly form master is also really nice [16:41:12] i guess i dont know what the best approach is [16:41:14] awjr: well, you can update that branch to master [16:41:18] <^demon> preilly, awjr: There's currently 5 pending revs for 1.20wmf1 to change the submodule for MobileFrontend. Could we abandon 4 of those and just do it once? [16:41:57] then again, it's probably not a big deal to temporarily use a different branch for cherry picking changes when we need to (a la last week) [16:42:00] ^demon: I don't really understand why there are 5 pending revs [16:42:07] preilly ^ [16:42:08] <^demon> preilly: https://gerrit.wikimedia.org/r/#q,status:open+project:mediawiki/core+branch:wmf/1.20wmf1+topic:wmf/1.20wmf1,n,z [16:42:14] awjr1: yeah, that's fine too [16:42:17] i forgot how much i love the office wifi [16:42:37] ^demon: yeah, I know there are 5 [16:42:45] ^demon: just not sure why awjr? [16:42:55] eh? [16:43:08] awjr: can you abandon some of these https://gerrit.wikimedia.org/r/#q,status:open+project:mediawiki/core+branch:wmf/1.20wmf1+topic:wmf/1.20wmf1,n,z [16:43:50] <^demon> If you guys are going to deploy today, we should abandon 4 of them and then rebase the remaining one :) [16:44:09] blargh [16:44:25] i imagine those are a result of trying and failing to get the deployment branch set up last week [16:44:32] i'll take a closer look shortly [16:44:49] ^demon: yeah, I agree [16:45:06] awjr: it should be fine to delete those 4 and rebase the last one [16:49:48] preilly ping [16:50:04] preilly ping2 [16:50:19] awjr: lame [16:50:32] no alerty? [16:50:35] preilly! [16:50:43] awjr: not if I'm watching this pane [16:50:53] preilly what client are you using? [16:50:55] awjr: if I click to another pane it does [16:51:06] awjr: Colloquy [16:51:19] preilly i got fed up with colloquy and just started using adium [16:53:14] awjr: do you like it better? [16:53:21] preilly: i think we can actually abandon all of those changes - the meaningful one was already merged [16:53:23] preilly i do [16:53:38] awjr: any major reason? [16:53:51] preilly i use adium for other instant messaging too, so it's nice to keep everything in one place [16:54:47] preilly it took a minute to get used to it because it's definitely different than your average irc client, but i've had less headaches using adium than colloquy [16:55:02] preilly also dunno if you saw this but: preilly i use adium for other instant messaging too, so it's nice to keep everything in one place [16:55:03] okay, I'm trying that now [16:55:10] I just switched to it [16:56:43] preilly awjr the div irc://irc.freenode.net/#section_SpokenWikipedia jumps from the bottom of the page here http://en.wikipedia.org/wiki/Wage_reform_in_the_Soviet_Union,_1956%E2%80%931962 to the top here http://en.m.wikipedia.org/w/index.php?title=Wage_reform_in_the_Soviet_Union,_1956%E2%80%931962 - according to MaxSem this is due to apparently, non-canonical URL is stuck in caches - any ideas how to fix? [16:56:48] greetings all [16:56:53] standup in 5min [16:57:12] jdlrobson, I've posted it to BZ https://bugzilla.wikimedia.org/36182 [16:57:24] ah sorry didn't see [16:57:39] jdlrobson: did you try to use purge [16:58:26] Did I purge my cache? [16:58:33] jdlrobson: no, http://en.wikipedia.org/wiki/Wikipedia:Purge [16:59:04] No I didn't [16:59:09] preilly, purge doesn't help with non-canonical URLs:/ [16:59:22] MaxSem: yes, it does [17:00:10] just checked;) [17:00:37] are you logged in or out? [17:01:34] all right .. lets do it [17:02:24] preilly, I'm not logged in on HTTP [17:11:33] tfinc: update on shipping the iPhone? [17:13:23] jdlrobson: hi, are you writing down your thoughts for the new mock-up? [17:13:58] I thought I sent them Friday... no? [17:14:24] hmm, somehow missed that [17:14:27] eek I only sent to Brion. Fail. [17:15:00] sent [17:15:25] at the moment I'm just thinking about how best to implement the sliding [17:15:52] ok, i will copy Lindsey on the reply so you guys can also chat about this as necessary [17:16:36] YuviPanda: soon [17:32:12] tfinc: Ok. I do not have any way to test scrolling issues on 4.x until then :( [17:33:00] YuviPanda: so we have nobody from twitter who can reliably reproduce iOS5.x ? [17:33:02] YuviPanda: yes i know [17:33:32] tfinc: nope. [17:33:50] awjr: preilly http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments is dismally empty .. can we rig something to gerrit to show us whats going out ? [17:34:04] YuviPanda: I can tweet asking for help, what exactly are you after? [17:34:04] so that we don't have to update the deployment list with each individual change [17:34:11] tfinc: I'll take a look [17:34:22] preilly: thanks [17:34:36] chrismcmahon: people on the iTunes store are reporting scrolling issues with the app on iOS 5.1. We've been unable to reproduce them. Figuring out how to repro them would be very useful [17:34:39] argh i thought i'd found a hack for getting debug output on winphone 7 but it's just going into the ether for me [17:35:06] brion: me and Roan used 'throw'. Worked :) [17:35:44] YuviPanda: if I find someone, who should they contact? [17:35:46] ooh i'll try that [17:36:06] chrismcmahon: mobile-feedback-l@lists.wikimedia.org [17:36:16] or tweet to us (@WikimediaMobile) [17:36:31] YuviPanda, where'd the errors get displayed? [17:36:43] brion: Visual Studio had a console for us [17:37:11] i do not see this console, must search for it [17:40:23] YuviPanda: twooted, maybe someone will jump in [17:42:43] tfinc: how does http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments#23_April.2C_2012 look now? [17:43:08] preilly: just abandoned all 5 of those revs [17:43:16] awjr: okay, cool [17:43:18] preilly: needs a little bit of format cleanup [17:43:27] but the detail is great [17:44:15] tfinc: any update on the QA position? [17:44:38] preilly: what do you think about my cleanup of the first commit ? [17:44:58] YuviPanda: positive. i'm going to move forward but with a shorter contract. can give you more details over pm [17:45:05] tfinc: seems fine [17:46:23] tfinc: pm'd [17:47:45] YuviPanda: are you on the mobile feedback list? [17:47:59] preilly: what do you think about keeping a separate deployment branch from master? [17:48:13] tfinc: yes [17:48:28] tfinc: how does http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments#23_April.2C_2012 look now? [17:48:40] awjr: let's talk about it later today [17:49:02] preilly sure thing [17:49:03] YuviPanda: were seeing people still report network related issues [17:49:15] YuviPanda: respond to them and find out if their using an old version [17:49:19] preilly: checking [17:49:35] preilly: looks great. that multi line last commit is a tough one [17:49:50] but the format is great and give me the change id's to find out more [17:50:00] preilly: let add this to a deployment checklist [17:50:09] tfinc: okay [17:50:23] tfinc: should the change id be clickable? [17:50:33] preilly: if its easy [17:51:03] MaxSem: as soon as you get your refactoring changes checked in on the remote branch i can start taking a look [17:51:58] awjr, I can reopen https://gerrit.wikimedia.org/r/#change,5361 and post a patchset here [17:52:24] jdlrobson: i'm eager to see the translations come in todays deployment as thats the only thing blocking the new design [17:52:37] what remains to be done is merge preilly's changes [17:52:41] MaxSem: actually, yeah - i can just start looking through that particular changeset while you get it committed to the remote branch [17:52:56] jdlrobson: we should have code named the design changes so that we can be less ambiguous [17:53:32] code named the design changes? not sure I follow... [17:54:17] * YuviPanda wonders when the beta design will go non-beta [17:54:18] jdlrobson: the collapsed sections, footer, etc changes [17:54:23] i keep looking for a word to refer to all of them [17:54:33] but not a word that makes us think of the nav bar changes [17:54:49] YuviPanda: if i see enough translations come in then next week [17:54:50] kermit :P [17:54:52] haha [17:54:58] we sooo need a project named kermit [17:55:05] new nav is miss-piggy [17:55:28] yes tfinc we also need to take care that when the new beta goes live we dont break old apps [17:55:37] YuviPanda: do we have an easy way to point the old releases at a test server? [17:55:59] jdlrobson: which release? and which server? [17:56:24] basically https://bugzilla.wikimedia.org/show_bug.cgi?id=35513 [17:56:36] although now I see that was resolved.. [17:56:46] jdlrobson: with the new ones, yes. [17:57:04] we need to check all the old releases work too I guess [17:57:19] jdlrobson: yes. so that's why I wanted to know before they went live :) [17:57:27] yup [17:57:51] jdlrobson: I shall make those builds tomorrow? [17:57:57] jdlrobson: I want to finish off saved pages today [17:58:28] yeh.. i guess what would be good is if the old builds can also be tweaked to scrape from mobile-geo.wmflabs.org rather than wikipedia.org [17:58:48] jdlrobson: I can make a one off build / commit that does that [17:58:57] sweet [17:59:49] if I understand correctly translations come today, so we could aim to move to beta next monday tfinc ? [18:00:23] brb [18:06:53] preilly, jdlrobson, MaxSem - are you guys getting nothing but 503 errors with gerrit? [18:07:06] haven't tried committing today.. [18:07:13] ahh you mean web view [18:07:17] yup, dead meat [18:07:21] yep [18:07:23] broken for me too [18:09:16] gerrit is restarting [18:09:31] should be back shortly [18:10:05] *windos [18:10:07] *windows [18:13:39] awjr: it's back [18:14:01] huzzah! [18:18:48] jdlrobson: translations are done and should be exposed when we deploy [18:21:57] you guys can't replicate the ios scrolling bugs? [18:22:09] Rolken: on 4.x, yes. On 5.x, no [18:22:23] Rolken: we fixed them on 4.x [18:22:35] philinje / linSmith could I get the icons for the menu in http://www.mediawiki.org/wiki/File:Design-comp-actions.png ? [18:23:06] hmm. the scrolling bugs out for me whenever i do practically anything [18:23:25] Rolken: which version of the app? [18:23:33] and iOS version / device? [18:23:42] tfinc: http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments#23_April.2C_2012 the change-ids now link to gerrit [18:23:50] wiki 3.1.2, ios 5.1, iphone 4 gsm [18:24:04] jdlrobson sure thing [18:24:05] see also: https://bugzilla.wikimedia.org/show_bug.cgi?id=35932 [18:25:58] Rolken: hmm, so it is not really stuttery scrolling, but the finger tracking seems off? [18:26:09] right [18:28:25] jdlrobson: Lindsey will send the ones she was using, which will be updated soon [18:32:49] so philinje - i've got a working prototype with left and right menus and search in centre. Just waiting for those icons to make it pretty. Going to grab some dinner now and will be back in about 30 mins [18:37:25] jdlrobson: great! [18:45:59] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5343 [18:46:01] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5343 [18:47:36] in https://gerrit.wikimedia.org/r/#patch,sidebyside,5394,3,specials/SpecialMobileFeedback.php line 93 [18:47:37] » » $returnTo = $form['returnto']; [18:47:37] Shouldn't you first check if returnto key is set? [18:49:16] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5394 [18:50:02] awjr: https://gerrit.wikimedia.org/r/#change,5394 -> Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. [18:50:26] :( [18:50:48] also, should the MW Api client for MobileFrontend be in a different class? [18:50:53] preilly any idea what the actual path conflict is? [18:50:59] preilly: yes [18:51:00] like should we have a utility class [18:51:05] preilly yeah it absolutely should be [18:51:14] i just did it in there as a proof of concept/to get it done [18:51:47] i'll do that in a future revision [18:51:50] MaxSem: do you think it makes sense to create a MobileFrontend.Utilities class? [18:52:20] preilly, for what kind of functions? [18:52:36] MaxSem: well, the MW Api client for MobileFrontend for example [18:53:11] MaxSem: and maybe getDom sort of stuff too [18:53:18] API client should be upmerged into core:) [18:53:34] philinje: linSmith work in progress but hopefully gives you an idea of where i'm going > http://jonrobson.me.uk/wikipedia/experiments/nav/ [18:53:36] and I was definitely going to put HtmlFormatter there [18:54:51] okay [18:55:10] awjr: are you rebasing https://gerrit.wikimedia.org/r/#change,5394 ? [18:55:48] preilly i will in a minute jsut want to finish the chunk of MaxSem's refactor that im looking at [18:56:08] awjr: okay [18:56:25] MaxSem how goes getting your refactor changes checked into the remote branch? [18:57:08] im about halfway through doing basic review of the changes and would like to leave some comments [18:57:14] I'm merging preilly's work of last week [18:58:23] New patchset: awjrichards; "Modest cleanup of html handling; getFeedbackHtml() now returns html rather than piping it directly to getOutput. This now handled in execute() method." [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5394 [18:58:59] preilly ^ [18:59:23] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5394 [18:59:26] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5394 [18:59:32] awjr: looks good [18:59:42] w00t [19:00:45] awjr, can you leave your comments on existing patchset, it isn't much different from the final version [19:06:09] New review: awjrichards; "I still haven't finished reviewing all of this yet (still going over the actual skin code), but here..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5361 [19:06:26] MaxSem ^ [19:06:36] thanks [19:06:44] but i've still got a ways to go - and these notes are only form reading through the code, i haven't actually tested anything yet [19:07:37] YuviPanda: one response on twitter for 5.1 [19:07:45] hopefully they can reproduce [19:08:30] New review: awjrichards; "Also, not specific to this commit - just a few things I noticed while reviewing this - we should pro..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5361 [19:08:41] tfinc: responding to him... [19:08:46] woot [19:09:37] sweet! Zeljko stepped up :) [19:09:47] Change restored: preilly; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5361 [19:14:57] MaxSem: are you moving https://gerrit.wikimedia.org/r/#change,5361 to the proper remote branch? [19:15:12] MaxSem: e.g., https://gerrit.wikimedia.org/r/#q,status:open+project:mediawiki/extensions/MobileFrontend+branch:master+topic:skin-rewrite,n,z [19:16:51] MaxSem: I mean branch:skin-rewrite [19:19:25] awjr1, D:\Projects\MediaWiki\includes>ack -o "private \$" |wc -l [19:19:28] 329 [19:20:20] private properties are an integral part of isolation of interface from implementation [19:21:29] preilly, I'll just submit another patchset [19:21:52] MaxSem I think they are often over/incorrectly used in core as well. [19:22:39] nope, core is moving to make even more vars private [19:24:14] MaxSem private only makes sense to use if you only want that property/method to ever be available to an instance of that specific class. a lot of the things labeled private are things that you'd want available if you were to extend those classes - particularly in the skin [19:26:10] Members declared as private may only be accessed by the class that defines the member. [19:26:25] exactly [19:26:30] But, members declared protected can be accessed only within the class itself and by inherited and parent classes. [19:26:41] descendant classes don't need to access all the guts [19:27:12] because when guts change, descendants break [19:27:15] MaxSem device detection, for instance, is something i imagine descendant classes would want to access [19:27:28] So, protected might be the way to go if we think that we'll be subclassing [19:27:52] there's a getter for it [19:28:14] a getter is useless for descendant classes because they still can't access a private property [19:28:26] they don't need to [19:29:35] MaxSem: why not? [19:30:38] philinje: i changed my mind again - http://jonrobson.me.uk/wikipedia/experiments/nav/index2.html thoughts ? [19:30:50] (continuing about guts) thus, to have a stable class hierarchy parent classes should provide a reasonable interface, not expose all their internals [19:32:29] so, private methods never participate in the overriding because these methods are not visible in the child classes [19:33:05] so, if we never ever see a need for overriding we can use private if we are even the slightest bit concerned we should use protected [19:33:41] grrr … credit card fraud [19:33:59] tfinc: what? [19:34:17] awjrichards@virtualbot:~/Dev/wikimedia_git/extensions/MobileFrontend$ $ ack private MobileFrontend.body.php [19:34:17] private $contentFormat = ''; [19:34:17] private $xDevice; [19:34:17] private $device; [19:34:17] private $wmlContext; [19:34:17] private $forceMobileView = false; [19:34:18] private $contentTransformations = true; [19:34:18] private function removeQueryStringParameter( $url, $field ) { [19:34:19] private function checkUserLoggedIn() { [19:34:19] private function checkUserStatus() { [19:34:20] private function getOptInOutCookie() { [19:34:20] private function disableCaching() { [19:34:21] private function sendXDeviceVaryHeader() { [19:34:21] private function sendApplicationVersionVaryHeader() { [19:34:45] and there are private properties that are referenced in non-private methods, which will cause bad behavior upon inheritence [19:35:19] just got a call from my credit card company. they caught it right away [19:35:24] imho it's better to err on the side of 'protected' unless truly necessary, especially in the context of an open source project [19:38:35] tfinc: were you donating to the WMF again? [19:40:11] is there a more MW appropriate way to get $_SERVER['HTTP_HOST']? [19:42:24] awjr: not unless were fundraising at target [19:42:25] ;) [19:42:37] lol [19:46:40] tfinc: is phil around? [19:46:54] jdlrobson: nope [19:46:59] :( [19:47:00] awjr: what about http://svn.wikimedia.org/doc/classWebRequest.html#a5e9ad2484bd41a09e2803a1812325684 [19:47:05] linSmith are you there? [19:47:10] jdlrobson: it's lunch time [19:47:17] i see.. [19:47:22] jdlrobson: linSmith isn't around either [19:48:10] as of getDom(), it's static because it's easier and this function will die soon anyway [19:50:57] MaxSem: self::getDom() is easier than $this->getDom()? sorry for being so nitpicky, but i think we need to get in the habit of declaring things more appropriately. my extending HTMLForm drove me insane because of inappropriately used static methods and properties and now i'm on a vendetta. [19:51:35] awjr, I need that function outside of ExtMobileFrontend [19:51:51] and once again, it will live just a few more days [19:51:53] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5651 [19:51:57] New review: gerrit2; "Auto-approving/merging l10n updates" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5651 [19:51:57] Change merged: gerrit2; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5651 [19:52:06] MaxSem the only other place i see it being used in MobileFrontend is in the skin, where you have access to an extMobileFrontend object [19:52:52] and i realize it will likely be short lived, but i dont think that's a reason to ignore good practice [19:56:16] awjr: especially since we want to keep things in a forkable state [19:56:25] exactly [19:56:42] * preilly really just liked saying forkable for some reason [19:56:54] forkin a [20:07:07] awjr_lunch, previous username was cooler!:P [20:12:04] Change abandoned: preilly; "Please use the skin-rewrite remote branch for these changes." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5361 [20:31:42] jdlrobson: good responses to the inline thread on wikitech [20:31:49] i know kaldari is going to weigh in as well [20:32:10] ok cool. I was waiting for more people to chip in before continuing it - but some interesting ideas there [20:32:39] yes [20:32:52] i've been prodding people here really actively as its been bugging me [20:33:05] kaldari should be able to weigh in on the rampant issues in templates [20:33:12] as he agreed that templates are usually to blame [20:49:36] https://gerrit.wikimedia.org/r/#q,status:open+project:+mediawiki/extensions/MobileFrontend,n,z looks nice and clean [20:49:47] so, I guess we are fine to deploy from master today [20:52:09] jdlrobson: philinje is back [20:52:14] jdlrobson: as is linSmith [20:52:26] yeh have spoken to linSmith so I'm good now. Thanks preilly [20:52:33] jdlrobson: np [20:53:46] preilly: can you respond to this guy https://bugzilla.wikimedia.org/show_bug.cgi?id=32596 [20:55:57] tfinc: and say what exactly? [20:56:04] tfinc: that it's been deployed? [20:56:21] yeah, just let him know when that went out [20:58:12] jdlrobson: Lindsey showed me the mock-ups, looking great [20:58:27] sounds like you guys are nailing down the way forward [20:58:48] yup. Been working more on - http://jonrobson.me.uk/wikipedia/experiments/nav/index.html - annoyingly mobile safari seems to have some kind of horizontal scrolling bug :( [20:59:23] MaxSem: i tried but needed a password for 'lunch' :p [21:00:09] preilly: i'd like to start getting ready for the deployment - what are you thoughts about keeping the separate deployment branch? [21:00:19] philinje linSmith - what are your views on what happens when opening the more menu in http://jonrobson.me.uk/wikipedia/experiments/nav/index.html and moving to the far left menu? [21:01:59] awjr: we should just switch to masetr [21:02:06] preilly righteous. [21:02:08] s/masetr/master [21:05:50] jdlrobson maybe it should automatically close? [21:06:07] tfinc YuviPanda Zeljko is checking in on Twitter to @WikimediaMobile, if you haven't seen it [21:06:09] yeh that's what i thought - but I did this accidently and found it quite interesting :) [21:06:24] (and I forgot to change my nick, crud) [21:06:26] * YuviPanda checks [21:08:44] chrismcmahon: responded. He seems to have found an issue in the frontpage content. [21:09:04] jdlrobson: are the minified js files up to date in the master branch? [21:09:16] no awjr [21:10:09] preilly: i didnt know you had a time machine [21:10:11] was hoping to get a fix in for https://bugzilla.wikimedia.org/show_bug.cgi?id=32773 but no reply from luc ... does luc live on irc? [21:10:11] commit 25206570852c28624ad8e098b3dd6aaecb9e9826 [21:10:11] Author: Patrick Reilly [21:10:11] Date: Sat May 11 17:12:07 2013 -0700 [21:10:28] jdlrobson no clue [21:11:26] wow. that's all the makings of a great film - [21:11:48] awjr: I've go VM drift [21:11:52] s/go/got [21:12:25] preilly is that some sort of VD? [21:12:38] awjr: no [21:18:44] awjr: want me to minify then? [21:18:54] jdlrobson it's ok, i'lm on it [21:19:23] * jdlrobson nods [21:19:33] jdlrobson just realized though - filepage.js is not in the makefile [21:19:35] shall i add it? [21:20:55] interesting... [21:20:57] 1s [21:21:22] so.. [21:21:31] it would need a change in ApplicationTemplate [21:22:28] {$filePageScript} would need to be replaced with {$startScriptTag}{$javaScriptPath}{$betaPrefix}filepage.{$resourceSuffix}js{$endScriptTag} [21:22:50] actually no that doesn't work [21:22:55] is there any reason we shouldn't do that? [21:22:56] oh [21:22:56] nm [21:23:06] we should do that [21:23:10] but it's not such a big deal [21:23:14] as it only gets run on file pages [21:23:29] but $filePageScript would be the variable to change - it just needs to make sure of resourceSuffix [21:23:30] ok, good to stay consistent if we can [21:23:47] jdlrobson can you go ahead and implement that? [21:23:53] sure [21:23:55] ty [21:24:19] jdlrobson in that case, go ahead and minify the js as well and i'll keep getting things set up for the deployment [21:24:24] will do [21:24:27] awesome thanks [21:33:01] sorry awjr - just noticed something i quickly want to change [21:34:38] np jdlrobson [21:35:03] i just realized my cookie changes from a while back haven't been deployed yet [21:35:55] * YuviPanda gives up on SavedPages for the day, does a few other commits [21:36:18] do they effect the javascript? [21:36:43] jdlrobson yes but those changes have been in master for over a week i think [21:36:49] ok cool [21:36:52] so i should go ahead and minify [21:36:56] aye [21:37:50] k pushed [21:37:53] New patchset: Jdlrobson; "add support for minified filepage.js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5672 [21:37:53] New patchset: Jdlrobson; "make slide up the default reference animation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5673 [21:37:54] New patchset: Jdlrobson; "minify latest javascript code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5674 [21:40:05] it seems like cookie + some of MaxSem's refactoring are the biggest things to go out today - jdlrobson none of the JS changes look particularly huge or scary, but perhaps i'm not reading the diff right, is there anything particularly scary we should keep an eye out for? [21:40:23] not that I can think of [21:40:28] just some bug fixes here and there [21:40:36] and tweaks [21:41:00]